D1849: lfs: remove internal url in test

mharbison72 added a comment. Yeah, I’ve been ignoring this failure. I thought I mentioned it back when this was first brought over. I’m assuming that FB will start using the built in extension and tests soon, and I didn’t want to drop test coverage on you like that. Thanks for fixing it.

D1849: lfs: remove internal url in test

quark created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY `test-lfs-test-server.t` refers to a FB internal domain and requires certain implementation (ex. set error code to 404) at that endpoint. Without any workaround,

D1848: perf: do not import util.queue

quark created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This was added by https://phab.mercurial-scm.org/rHGaf25237be091ac307bc65a2c2b3688fd73eb9bf3. But util.queue is not a module and is not importable. I guess it

[PATCH 2 of 2 V2] filterlang: add a small language to filter files

# HG changeset patch # User Matt Harbison # Date 1515641014 18000 # Wed Jan 10 22:23:34 2018 -0500 # Node ID 548e748cb3f4eea0aedb36a2b2e9fe3b77ffb263 # Parent 962b2bdd70d094ce4bf9a8135495788166b04510 filterlang: add a small language to filter files This patch was

[PATCH 1 of 2 V2] fileset: split the logic for matching a size expression to a separate method

# HG changeset patch # User Matt Harbison # Date 1515641708 18000 # Wed Jan 10 22:35:08 2018 -0500 # Node ID 962b2bdd70d094ce4bf9a8135495788166b04510 # Parent a864c7916e03d5e4b7f2e024c890f8502f2e0b16 fileset: split the logic for matching a size expression to a

D1847: rust: add TODO about lifetime of program_name variable

indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Per review comment in https://phab.mercurial-scm.org/D1581. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D1847 AFFECTED FILES

D1846: rust: avoid redundant 'static lifetime

indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY 'static is apparently automatic for const variables. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D1846 AFFECTED FILES

D1845: rust: move import of PathBuf

indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY By moving it to the single function that uses it, we eliminate a #cfg. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D1845

D1581: rust: implementation of `hg`

indygreg marked 7 inline comments as done. indygreg added a comment. I'll address this and other review feedback in follow-up patches. Thanks for the review! INLINE COMMENTS > cramertj wrote in main.rs:45 > Nit: you can just write ``. Also, I'm not familiar with what you're > trying to

D1779: unionrepo: use named attributes on revlog index entries

indygreg added a comment. I think we should hold off landing until the native C type is ready. I don't like shipping a performance regression on such low-level code without any other user benefit to offset it. The assumption here is that I'm the only one who will absorb pain from this

D1844: rust: move Cargo.lock

This revision was automatically updated to reflect the committed changes. Closed by commit rHG98b87b8307e0: rust: move Cargo.lock (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D1844?vs=4786=4788 REVISION DETAIL

D1843: run-tests: fix regular expression for path test

This revision was automatically updated to reflect the committed changes. Closed by commit rHG31acf6619f08: run-tests: fix regular expression for path test (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D1844: rust: move Cargo.lock

indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY If you do a `cargo build` in rust/, Cargo will create rust/Cargo.lock. Furthermore, the previous rust/hgcli/Cargo.lock appears to not even be consulted because

D1843: run-tests: fix regular expression for path test

indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY The previous regexp would match the empty string. This fixes a mistake added in https://phab.mercurial-scm.org/rHG964212780daf231a17bc9de9c79c1324372ce468.

mercurial@35541: 2 new changesets (2 on stable)

2 new changesets (2 on stable) in mercurial: https://www.mercurial-scm.org/repo/hg/rev/f948c5b3f5c9 changeset: 35540:f948c5b3f5c9 branch: stable user:Mihai Popescu date:Mon Jan 08 13:52:43 2018 +0100 summary: run-tests: avoid set PYTHONUSERBASE

D1830: test-run-tests: stabilize the test (issue5735)

durin42 added a comment. As a note (re your test plan): there's a --runs-per-test flag on run-tests for exactly this kind of "did I fix a flaky test" debugging. I often set it to 100. :) REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D1830 To: quark,

D1756: remotenames: introduce class to encapsulate remotenames info in an extension

durin42 added a comment. In https://phab.mercurial-scm.org/D1756#29970, @pulkit wrote: > As per previous discussions, the storage part can only go to core directly (https://phab.mercurial-scm.org/D1358#22905). I am not sure about how out of core extension and in-core extension will

D1755: logexchange: introduce helper function to get remote path name

durin42 requested changes to this revision. durin42 added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > logexchange.py:109 > +if local: > +rpath = getattr(remote, 'root', None) > +if rpath is None: This should be cleaned up to not have all

Re: [PATCH V2] perf: add threading capability to perfbdiff

On Wed, Jan 10, 2018 at 03:23:13PM +0100, Paul Morelle wrote: > # HG changeset patch > # User Boris Feld > # Date 1513481487 -3600 > # Sun Dec 17 04:31:27 2017 +0100 > # Node ID a04df08f0f218da10bb57c9f7080770a7f3e56c0 > # Parent

Re: [PATCH] upgraderepo: select correct deltareuse depending on actions

On Wed, Jan 10, 2018 at 05:39:57PM +0100, Paul Morelle wrote: > # HG changeset patch > # User Paul Morelle > # Date 1515601465 -3600 > # Wed Jan 10 17:24:25 2018 +0100 > # Node ID e95cf6b79a9abdc5fc3a071cb82f5cabe0b117f3 > # Parent

Re: [PATCH 2 of 3] lfs: add a small language to filter files

On Sun, Jan 07, 2018 at 11:09:02PM -0500, Matt Harbison wrote: > On Sun, 07 Jan 2018 03:17:12 -0500, Yuya Nishihara wrote: > > > On Thu, 04 Jan 2018 23:58:55 -0500, Matt Harbison wrote: > > > # HG changeset patch > > > # User Matt Harbison > > > # Date

D1792: py3: use node.hex(h.digest()) instead of h.hexdigest()

This revision was automatically updated to reflect the committed changes. Closed by commit rHG72b91f905065: py3: use node.hex(h.digest()) instead of h.hexdigest() (authored by pulkit, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D1799: py3: use list() to get a list of items using dict.items()

This revision was automatically updated to reflect the committed changes. Closed by commit rHG3328d53254d9: py3: use list() to get a list of items using dict.items() (authored by pulkit, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

Re: [PATCH 7 of 7] revsetlang: add %p specifier to format list of function arguments

On Mon, Jan 08, 2018 at 10:36:30PM +0900, Yuya Nishihara wrote: > # HG changeset patch > # User Yuya Nishihara > # Date 1514885711 -32400 > # Tue Jan 02 18:35:11 2018 +0900 > # Node ID 179f10e4e296f2464ab0c14054d1221c4666cb45 > # Parent

D1795: py3: use pycompat.bytestr() instead of str()

This revision was automatically updated to reflect the committed changes. Closed by commit rHG35fb3367f72d: py3: use pycompat.bytestr() instead of str() (authored by pulkit, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D1795?vs=4672=4778

D1798: py3: convert dict keys' to str before passing as kwargs

This revision was automatically updated to reflect the committed changes. Closed by commit rHGdadbf213a765: py3: convert dict keys to str before passing as kwargs (authored by pulkit, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D1797: py3: make sure we open the file to write in bytes mode

This revision was automatically updated to reflect the committed changes. Closed by commit rHGf2f0a777b2e2: py3: make sure we open the file to write in bytes mode (authored by pulkit, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D1800: py3: add 8 new passing tests to the whitelist

This revision was automatically updated to reflect the committed changes. Closed by commit rHGaaeba70d5cbe: py3: add 8 new passing tests to the whitelist (authored by pulkit, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D1800?vs=4677=4783

D1796: py3: don't use dict.iterkeys()

This revision was automatically updated to reflect the committed changes. Closed by commit rHGfbf1a5d680ea: py3: dont use dict.iterkeys() (authored by pulkit, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D1796?vs=4673=4779 REVISION

D1790: py3: use pycompat.ziplist instead of inbuilt zip

This revision was automatically updated to reflect the committed changes. Closed by commit rHGcb0db11f392d: py3: use pycompat.ziplist instead of inbuilt zip (authored by pulkit, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D1794: py3: make regular expressions bytes by prepending b''

This revision was automatically updated to reflect the committed changes. Closed by commit rHG6f62a1c3e11d: py3: make regular expressions bytes by prepending b (authored by pulkit, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D1793: py3: slice on bytes instead of indexing

This revision was automatically updated to reflect the committed changes. Closed by commit rHG2f123f309f61: py3: slice on bytes instead of indexing (authored by pulkit, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D1793?vs=4670=4776

D1838: phase: use context managers for lock and transaction

This revision was automatically updated to reflect the committed changes. Closed by commit rHGdda3cae3c9c5: phase: use context managers for lock and transaction (authored by martinvonz, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D1591: visibility: improve the message when accessing filtered obsolete rev

This revision was automatically updated to reflect the committed changes. Closed by commit rHG265cd9e19d26: visibility: improve the message when accessing filtered obsolete rev (authored by lothiraldan, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D1791: tests: make autodiff.py work on Python 3

This revision was automatically updated to reflect the committed changes. Closed by commit rHG154754d1f137: tests: make autodiff.py work on Python 3 (authored by pulkit, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D1791?vs=4668=4774

D1789: py3: use bytes and open() instead of file() in test-diff-upgrade.t

This revision was automatically updated to reflect the committed changes. Closed by commit rHG15ddf83fbf84: py3: use bytes and open() instead of file() in test-diff-upgrade.t (authored by pulkit, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D1581: rust: implementation of `hg`

This revision was automatically updated to reflect the committed changes. Closed by commit rHG964212780daf: rust: implementation of `hg` (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D1581?vs=4753=4762 REVISION

D1841: exchange: use context manager for locks and transaction in unbundle()

This revision was automatically updated to reflect the committed changes. Closed by commit rHG86f9aabed67b: exchange: use context manager for locks and transaction in unbundle() (authored by martinvonz, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D1840: bookmarks: use context managers for locks and transaction in pushbookmark()

This revision was automatically updated to reflect the committed changes. Closed by commit rHGac7ee75ee664: bookmarks: use context managers for locks and transaction in pushbookmark() (authored by martinvonz, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D1836: obsolete: use context manager for lock in pushmarker()

This revision was automatically updated to reflect the committed changes. Closed by commit rHG5574629d5d45: obsolete: use context manager for lock in pushmarker() (authored by martinvonz, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D1837: obsolete: use context manager for transaction in pushmarker()

This revision was automatically updated to reflect the committed changes. Closed by commit rHG09285733ad71: obsolete: use context manager for transaction in pushmarker() (authored by martinvonz, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D1839: bookmarks: use context managers for lock and transaction in update()

This revision was automatically updated to reflect the committed changes. Closed by commit rHGb9a0de08110e: bookmarks: use context managers for lock and transaction in update() (authored by martinvonz, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D1835: obsolete: use context manager for transaction in createmarkers()

This revision was automatically updated to reflect the committed changes. Closed by commit rHG8b729856ca03: obsolete: use context manager for transaction in createmarkers() (authored by martinvonz, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D1788: tests: add b'' to string literals where bytes are required

This revision was automatically updated to reflect the committed changes. Closed by commit rHG3e3f4c03876b: tests: add b to string literals where bytes are required (authored by pulkit, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D1779: unionrepo: use named attributes on revlog index entries

durin42 accepted this revision. durin42 added a comment. This revision is now accepted and ready to land. Happy to see these land, but waiting for any objections from others. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D1779 To: indygreg, #hg-reviewers,

D1773: revlog: use named attributes on revlog index entries

durin42 added a comment. In https://phab.mercurial-scm.org/D1773#30628, @yuja wrote: > > However, it is quite large and I suspect it will take a bit more effort to finish it. > > Isn't that something like `dirstateTupleType`? If we had a native type, we wouldn't > need

D1694: debugcommands: replace opts.get('foo') by opts['foo']

durin42 added a comment. In https://phab.mercurial-scm.org/D1694#29072, @yuja wrote: > Queued the first three patches, but I'm not certain about this. Sometimes we > do the reverse change for ease of calling command function as a plain function. I think it's probably okay for

D1829: merge: add `--abort` flag which can abort the merge

durin42 accepted this revision as: durin42. durin42 added a comment. I'm fine with this. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D1829 To: pulkit, #hg-reviewers, durin42 Cc: durin42, mercurial-devel ___

D1581: rust: implementation of `hg`

cramertj added a comment. In https://phab.mercurial-scm.org/D1581#31035, @indygreg wrote: > In https://phab.mercurial-scm.org/D1581#31029, @cramertj wrote: > > > There are a lot of uses of `unwrap`, `expect`, and `panic` that can (and probably should) be replaced with proper error

D1581: rust: implementation of `hg`

indygreg added a comment. In https://phab.mercurial-scm.org/D1581#31029, @cramertj wrote: > There are a lot of uses of `unwrap`, `expect`, and `panic` that can (and probably should) be replaced with proper error handling using `Result` (and the `failure` crate). I definitely

D1581: rust: implementation of `hg`

cramertj added a comment. Looks pretty good to me-- left a couple nits inline. There are a lot of uses of `unwrap`, `expect`, and `panic` that can (and probably should) be replaced with proper error handling using `Result` (and the `failure` crate). There are also a couple of

D1840: bookmarks: use context managers for locks and transaction in pushbookmark()

martinvonz created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D1840 AFFECTED FILES mercurial/bookmarks.py CHANGE DETAILS diff --git a/mercurial/bookmarks.py

D1838: phase: use context managers for lock and transaction

martinvonz created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D1838 AFFECTED FILES mercurial/commands.py CHANGE DETAILS diff --git a/mercurial/commands.py

D1837: obsolete: use context manager for transaction in pushmarker()

martinvonz created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D1837 AFFECTED FILES mercurial/obsolete.py CHANGE DETAILS diff --git a/mercurial/obsolete.py

D1841: exchange: use context manager for locks and transaction in unbundle()

martinvonz created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Note that the transactionmanager doesn't actually create a transaction - that is done the first time .transaction() is called on it (if at all).

D1836: obsolete: use context manager for lock in pushmarker()

martinvonz created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D1836 AFFECTED FILES mercurial/obsolete.py CHANGE DETAILS diff --git a/mercurial/obsolete.py

D1839: bookmarks: use context managers for lock and transaction in update()

martinvonz created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D1839 AFFECTED FILES mercurial/bookmarks.py CHANGE DETAILS diff --git a/mercurial/bookmarks.py

D1835: obsolete: use context manager for transaction in createmarkers()

martinvonz created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D1835 AFFECTED FILES mercurial/obsolete.py CHANGE DETAILS diff --git a/mercurial/obsolete.py

D1813: bookmarks: add bookmarks to hidden revs if directaccess config is set

pulkit updated this revision to Diff 4754. pulkit edited the summary of this revision. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D1813?vs=4732=4754 REVISION DETAIL https://phab.mercurial-scm.org/D1813 AFFECTED FILES mercurial/bookmarks.py

D1581: rust: implementation of `hg`

indygreg updated this revision to Diff 4753. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D1581?vs=4745=4753 REVISION DETAIL https://phab.mercurial-scm.org/D1581 AFFECTED FILES .hgignore rust/.cargo/config rust/Cargo.toml rust/README.rst

[PATCH] upgraderepo: select correct deltareuse depending on actions

# HG changeset patch # User Paul Morelle # Date 1515601465 -3600 # Wed Jan 10 17:24:25 2018 +0100 # Node ID e95cf6b79a9abdc5fc3a071cb82f5cabe0b117f3 # Parent ebf14075a5c113f4fea6e89a4394d8c8fc9e6935 # EXP-Topic upgrade-deltareuse # Available At

[PATCH V2] perf: add threading capability to perfbdiff

# HG changeset patch # User Boris Feld # Date 1513481487 -3600 # Sun Dec 17 04:31:27 2017 +0100 # Node ID a04df08f0f218da10bb57c9f7080770a7f3e56c0 # Parent b55a142f00c5a92a19ff94fbe9b5d09e28716860 # EXP-Topic threaded-diff # Available At

Re: [PATCH] perf: add threading capability to perfbdiff

Please wait for the V2, as this doesn't pass the tests. Sorry for the premature post! Paul On 01/10/2018 02:18 PM, Paul Morelle wrote: > # HG changeset patch > # User Boris Feld > # Date 1513481487 -3600 > # Sun Dec 17 04:31:27 2017 +0100 > # Node ID

D1830: test-run-tests: stabilize the test (issue5735)

This revision was automatically updated to reflect the committed changes. Closed by commit rHG87676e8ee056: test-run-tests: stabilize the test (issue5735) (authored by quark, committed by ). CHANGED PRIOR TO COMMIT https://phab.mercurial-scm.org/D1830?vs=4743=4752#toc REPOSITORY rHG

D1830: test-run-tests: stabilize the test (issue5735)

yuja accepted this revision. yuja added a comment. This revision is now accepted and ready to land. Queued for stable. Thanks for fixing this issue. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D1830 To: quark, #hg-reviewers, yuja Cc: yuja, mercurial-devel

[PATCH] perf: add threading capability to perfbdiff

# HG changeset patch # User Boris Feld # Date 1513481487 -3600 # Sun Dec 17 04:31:27 2017 +0100 # Node ID 642ecc1f18e946df58d9870fce258f85a57bc9a3 # Parent b55a142f00c5a92a19ff94fbe9b5d09e28716860 # EXP-Topic threaded-diff # Available At

Re: [PATCH] run-tests: avoid set PYTHONUSERBASE environment variable to None

On Mon, 08 Jan 2018 13:23:13 +, Mihai Popescu wrote: > # HG changeset patch > # User Mihai Popescu > # Date 1515415963 -3600 > # Mon Jan 08 13:52:43 2018 +0100 > # Node ID 913c426a392121e6f629f591374b8a10d55c05ea > # Parent 4c3a4bb31c0e3d9b8920b4c9b64ae930b1fe52ce >

D1581: rust: implementation of `hg`

yuja added inline comments. INLINE COMMENTS > indygreg wrote in Cargo.lock:1 > According to > https://doc.rust-lang.org/cargo/faq.html#why-do-binaries-have-cargolock-in-version-control-but-not-libraries > (and other places I found on the Internet), `Cargo.lock` files under version > control

[Bug 5769] New: test-largefiles-misc test failure: find -printf

https://bz.mercurial-scm.org/show_bug.cgi?id=5769 Bug ID: 5769 Summary: test-largefiles-misc test failure: find -printf Product: Mercurial Version: 4.4.2 Hardware: All OS: NetBSD Status: UNCONFIRMED

D1813: bookmarks: add bookmarks to hidden revs if directaccess config is set

yuja requested changes to this revision. yuja added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > bookmarks.py:856 > if rev: > +warnm = "adding bookmarks to a hidden changeset" > +repo = scmutil.unhidehashlikerevs(repo, [rev],

D1827: scmutil: add warnmessage argument to unhidehashlikerevs function

yuja requested changes to this revision. yuja added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > scmutil.py:1350 > +warnmessage += " %s\n" > +repo.ui.warn(_(warnmessage) % revstr) > `_()` must wrap a string literal. FWIW,

Re: pull request for evolve

Thank you, they have been taken for review. On Tue, 2018-01-09 at 14:46 -0800, Martin von Zweigbergk wrote: > I have a little series that makes hg's amend extension work better > with the evolve extension. I still can't send proper emails from this > address, so please pull from >

D1802: Add a template item for linking to a differential review.

pulkit added inline comments. INLINE COMMENTS > phabricator.py:873 > +templatekw.keywords['phabreview'] = template_review > + > + couple of new lines here and above too, did you ran test-check-commit.t? REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D1802 To:

D1832: style: remove multiple statement on a single line

lothiraldan created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This is similar to the change made in https://phab.mercurial-scm.org/rHG5326e4ef1dab0bb33f5262aa9e68491d115525fb. REPOSITORY rHG Mercurial REVISION DETAIL

D1831: pylint: split command line argument on multiple lines

lothiraldan created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This clarify the important line in that configuration. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D1831 AFFECTED FILES

D1834: pylint: add a check for multiple statement on a single line

lothiraldan created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Now that they are all cleaned up, we can install a check so that no new occurrence appears. REPOSITORY rHG Mercurial REVISION DETAIL

D1833: style: remove multiple statement on a single line in zeroconf

lothiraldan created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D1833 AFFECTED FILES hgext/zeroconf/Zeroconf.py CHANGE DETAILS diff --git