Re: [Mesa-dev] [PATCH 4/4] i965: Make GL_TIME_ELAPSED only track time for this context.

2012-10-24 Thread Kenneth Graunke
I like this! For the series: Reviewed-by: Kenneth Graunke kenn...@whitecape.org However, there's one thing you missed: since you made it emit_end_query for (potentially) both OQ -and- timestamp on batchbuffer end, you should reserve enough space for the extra PIPE_CONTROLs emitted by

Re: [Mesa-dev] [PATCH 1/2] shared-glapi: implement _glapi_get_proc_name().

2012-10-24 Thread Kenneth Graunke
On 10/23/2012 12:37 PM, Paul Berry wrote: Previously this function was only implemented for non-shared-glapi builds. Since the function is only intended for debugging purposes we use a simple O(n) algorithm. --- src/mapi/mapi/mapi_glapi.c | 4 ++-- src/mapi/mapi/stub.c | 22

[Mesa-dev] [PATCH v2] st/mesa: Fix assertions for copying texture image to finalized miptree.

2012-10-24 Thread Michel Dänzer
From: Michel Dänzer michel.daen...@amd.com The layer dimension of array textures is not subject to mipmap minification. OTOH we were missing an assertion for the depth dimension. Fixes assertion failures with piglit {f,v}s-textureSize-sampler1DArrayShadow. For some reason, they only resulted in

[Mesa-dev] [PATCH] vl: fix the dri winsys helper screen init

2012-10-24 Thread Christian König
Signed-off-by: Christian König deathsim...@vodafone.de --- src/gallium/auxiliary/vl/vl_winsys_dri.c |2 ++ 1 file changed, 2 insertions(+) diff --git a/src/gallium/auxiliary/vl/vl_winsys_dri.c b/src/gallium/auxiliary/vl/vl_winsys_dri.c index 8e4e026..95aabac 100644 ---

Re: [Mesa-dev] [PATCH v2] st/mesa: Fix assertions for copying texture image to finalized miptree.

2012-10-24 Thread Andreas Boll
2012/10/23 Michel Dänzer mic...@daenzer.net: From: Michel Dänzer michel.daen...@amd.com The layer dimension of array textures is not subject to mipmap minification. OTOH we were missing an assertion for the depth dimension. Fixes assertion failures with piglit

Re: [Mesa-dev] [PATCH v2] st/mesa: Fix assertions for copying texture image to finalized miptree.

2012-10-24 Thread Brian Paul
On 10/23/2012 10:09 AM, Michel Dänzer wrote: From: Michel Dänzermichel.daen...@amd.com The layer dimension of array textures is not subject to mipmap minification. OTOH we were missing an assertion for the depth dimension. Fixes assertion failures with piglit

Re: [Mesa-dev] [PATCH v2] st/mesa: Fix assertions for copying texture image to finalized miptree.

2012-10-24 Thread Michel Dänzer
On Mit, 2012-10-24 at 17:47 +0200, Andreas Boll wrote: 2012/10/23 Michel Dänzer mic...@daenzer.net: From: Michel Dänzer michel.daen...@amd.com The layer dimension of array textures is not subject to mipmap minification. OTOH we were missing an assertion for the depth dimension. Fixes

Re: [Mesa-dev] [PATCH] glsl_to_tgsi: set correct register type for array and structure elements

2012-10-24 Thread Andreas Boll
2012/10/24 Marek Olšák mar...@gmail.com: On Tue, Oct 23, 2012 at 11:52 PM, Bryan Cain bryanca...@gmail.com wrote: On 10/23/2012 04:50 PM, Brian Paul wrote: On 10/23/2012 10:58 AM, Bryan Cain wrote: This fixes an issue where glsl_to_tgsi_visior::get_opcode() would emit the wrong opcode

Re: [Mesa-dev] [PATCH v2] st/mesa: Fix assertions for copying texture image to finalized miptree.

2012-10-24 Thread Andreas Boll
2012/10/24 Michel Dänzer mic...@daenzer.net: On Mit, 2012-10-24 at 17:47 +0200, Andreas Boll wrote: 2012/10/23 Michel Dänzer mic...@daenzer.net: From: Michel Dänzer michel.daen...@amd.com The layer dimension of array textures is not subject to mipmap minification. OTOH we were missing

[Mesa-dev] [PATCH 0/8] sRGB fixes

2012-10-24 Thread Ian Romanick
This series contains a bunch of Mesa and GLX fixes releated to sRGB drawables. It should contain all of the work necessary to allow drivers to advertise sRGB fbconfigs. What is missing is a 9th patch to actually add some sRGB fbconfigs to the Intel driver. I haven't done this yet because I

[Mesa-dev] [PATCH 5/8] dri_util: Elminiate the bytes_per_pixel table

2012-10-24 Thread Ian Romanick
From: Ian Romanick ian.d.roman...@intel.com With fewer formats to support, it's kind of useless. Signed-off-by: Ian Romanick ian.d.roman...@intel.com --- src/mesa/drivers/dri/common/utils.c | 12 +++- 1 file changed, 3 insertions(+), 9 deletions(-) diff --git

[Mesa-dev] [PATCH 4/8] dri_util: Remove support for RGB332 framebuffers

2012-10-24 Thread Ian Romanick
From: Ian Romanick ian.d.roman...@intel.com None of the remaining DRI drivers in Mesa use this. Signed-off-by: Ian Romanick ian.d.roman...@intel.com --- src/mesa/drivers/dri/common/utils.c | 34 +++--- 1 file changed, 7 insertions(+), 27 deletions(-) diff --git

[Mesa-dev] [PATCH 7/8] intel: If the visual is sRGB, use an sRGB internal format

2012-10-24 Thread Ian Romanick
From: Ian Romanick ian.d.roman...@intel.com Signed-off-by: Ian Romanick ian.d.roman...@intel.com --- src/mesa/drivers/dri/intel/intel_screen.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/mesa/drivers/dri/intel/intel_screen.c b/src/mesa/drivers/dri/intel/intel_screen.c index

[Mesa-dev] [PATCH 6/8] dri: Convert driCreateConfigs to use a gl_format enum

2012-10-24 Thread Ian Romanick
From: Ian Romanick ian.d.roman...@intel.com This is instead of the pair of GLenums for format and type that were previously used. This is necessary for the Intel drivers to expose sRGB framebuffer formats. Signed-off-by: Ian Romanick ian.d.roman...@intel.com Cc: Chad Versace

[Mesa-dev] [PATCH 8/8] dri: Support MESA_FORMAT_SARGB8 in driCreateConfigs

2012-10-24 Thread Ian Romanick
From: Ian Romanick ian.d.roman...@intel.com Signed-off-by: Ian Romanick ian.d.roman...@intel.com --- src/mesa/drivers/dri/common/utils.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/mesa/drivers/dri/common/utils.c b/src/mesa/drivers/dri/common/utils.c index

Re: [Mesa-dev] [PATCH 3/8] swrast: Remove the 2_3_3_REV framebuffer format

2012-10-24 Thread Brian Paul
On 10/24/2012 11:08 AM, Ian Romanick wrote: From: Ian Romanickian.d.roman...@intel.com There is no gl_format in Mesa that corresponds to this arrangement, so I have a very hard time believing that this works. Signed-off-by: Ian Romanickian.d.roman...@intel.com Cc: Brian Paulbri...@vmware.com

Re: [Mesa-dev] [PATCH v2 3/6] glapi: Alias VertexAttribDivisor and VertexAttribDivisorARB.

2012-10-24 Thread Stéphane Marchesin
Hi Paul, This change regresses instanced_arrays with i915g, and probably with llvmpipe as well. Could you take a look? Thanks, Stéphane On Mon, Oct 22, 2012 at 5:22 PM, Paul Berry stereotype...@gmail.com wrote: There's no reason to have separate slots in the dispatch table for these two

[Mesa-dev] [Bug 56211] src/mesa/state_tracker/st_cb_texture.c:1123:copy_image_data_to_texture: Assertion `u_minify(stImage-pt-height0, src_level) == stImage-base.Height' failed.

2012-10-24 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=56211 Andreas Boll andreas.boll@gmail.com changed: What|Removed |Added Status|NEW |RESOLVED

[Mesa-dev] [PATCH 0/6] intel: Add support for remaining ETC2 texture formats

2012-10-24 Thread Anuj Phogat
This patch series (along with my earlier posted etc2 patches) can be found at my 'etc2-v12' branch: https://github.com/aphogat/mesa These patches add decompression for following etc2 textures: GL_COMPRESSED_RGB8_PUNCHTHROUGH_ALPHA1_ETC2 GL_COMPRESSED_SRGB8_PUNCHTHROUGH_ALPHA1_ETC2 I have also

[Mesa-dev] [PATCH 1/6] mesa: Add a new texture format GL_COMPRESSED_RGB8_PUNCHTHROUGH_ALPHA1_ETC2

2012-10-24 Thread Anuj Phogat
Signed-off-by: Anuj Phogat anuj.pho...@gmail.com --- src/mesa/main/format_unpack.c |9 + src/mesa/main/formats.c | 13 + src/mesa/main/formats.h |1 + src/mesa/main/glformats.c |2 ++ src/mesa/main/texcompress.c |9 +

[Mesa-dev] [PATCH 2/6] mesa: Add decoding functions for GL_COMPRESSED_RGB8_PUNCHTHROUGH_ALPHA1_ETC2

2012-10-24 Thread Anuj Phogat
Signed-off-by: Anuj Phogat anuj.pho...@gmail.com --- src/mesa/main/texcompress_etc.c | 179 ++- src/mesa/main/texcompress_etc.h |8 ++ 2 files changed, 166 insertions(+), 21 deletions(-) diff --git a/src/mesa/main/texcompress_etc.c

[Mesa-dev] [PATCH 3/6] intel: Enable support for GL_COMPRESSED_RGB8_PUNCHTHROUGH_ALPHA1_ETC2 textures

2012-10-24 Thread Anuj Phogat
Signed-off-by: Anuj Phogat anuj.pho...@gmail.com --- src/mesa/drivers/dri/i965/brw_wm_surface_state.c |1 + src/mesa/drivers/dri/intel/intel_mipmap_tree.c |1 + 2 files changed, 2 insertions(+), 0 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_wm_surface_state.c

[Mesa-dev] [PATCH 4/6] mesa: Add a new texture format GL_COMPRESSED_SRGB8_PUNCHTHROUGH_ALPHA1_ETC2

2012-10-24 Thread Anuj Phogat
Signed-off-by: Anuj Phogat anuj.pho...@gmail.com --- src/mesa/main/format_unpack.c |9 + src/mesa/main/formats.c | 13 + src/mesa/main/formats.h |1 + src/mesa/main/glformats.c |2 ++ src/mesa/main/texcompress.c |9 +

[Mesa-dev] [PATCH 5/6] mesa: Add decoding functions for GL_COMPRESSED_SRGB8_PUNCHTHROUGH_ALPHA1_ETC2

2012-10-24 Thread Anuj Phogat
Signed-off-by: Anuj Phogat anuj.pho...@gmail.com --- src/mesa/main/texcompress_etc.c | 77 +++ src/mesa/main/texcompress_etc.h |8 2 files changed, 85 insertions(+), 0 deletions(-) diff --git a/src/mesa/main/texcompress_etc.c

[Mesa-dev] [PATCH 6/6] intel: Enable support for GL_COMPRESSED_SRGB8_PUNCHTHROUGH_ALPHA1_ETC2 textures

2012-10-24 Thread Anuj Phogat
Signed-off-by: Anuj Phogat anuj.pho...@gmail.com --- src/mesa/drivers/dri/i965/brw_wm_surface_state.c |1 + src/mesa/drivers/dri/intel/intel_mipmap_tree.c |1 + 2 files changed, 2 insertions(+), 0 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_wm_surface_state.c

[Mesa-dev] [PATCH] llvmpipe: Fix creation for shared and scanout.

2012-10-24 Thread John Kåre Alsaker
NOTE: This is a candidate for the stable branches. --- src/gallium/drivers/llvmpipe/lp_texture.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/gallium/drivers/llvmpipe/lp_texture.c b/src/gallium/drivers/llvmpipe/lp_texture.c index b4ea94c..ccea4e2 100644 ---

[Mesa-dev] [PATCH 0/9] GL 3.1 CORE dispatch_sanity test

2012-10-24 Thread Jordan Justen
Patches 1-4: * Cleanups for CORE profile dispatch tables Patches 5-9: * Modify dispatch_sanity test for GL 3.1 CORE profile testing Follow on work still required: * Add all GL CORE functions to Mesa's XML. (So no funcions start with a dash (-) in the dispatch_sanity test.) Jordan Justen (9):

[Mesa-dev] [PATCH 1/9] mesa api_exec: add comment regarding GetPointerv CORE profiles

2012-10-24 Thread Jordan Justen
GetPointerv was de-deprecated in 893ddb. Signed-off-by: Jordan Justen jordan.l.jus...@intel.com --- src/mesa/main/api_exec.c |4 1 file changed, 4 insertions(+) diff --git a/src/mesa/main/api_exec.c b/src/mesa/main/api_exec.c index a670fba..d21c99e 100644 --- a/src/mesa/main/api_exec.c

[Mesa-dev] [PATCH 2/9] mesa shaderapi: don't enable various functions for GL CORE

2012-10-24 Thread Jordan Justen
These functions will no longer be enabled for CORE profiles: * DeleteObjectARB * GetHandleARB * DetachObjectARB * CreateShaderObjectARB * CreateProgramObjectARB * AttachObjectARB * GetObjectParameterfvARB * GetObjectParameterivARB * GetInfoLogARB * GetAttachedObjectsARB * ProgramParameteriARB *

[Mesa-dev] [PATCH 3/9] mesa transform feedback: disable BindBufferOffsetEXT for CORE profiles

2012-10-24 Thread Jordan Justen
Signed-off-by: Jordan Justen jordan.l.jus...@intel.com --- src/mesa/main/transformfeedback.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mesa/main/transformfeedback.c b/src/mesa/main/transformfeedback.c index 0669b3a..9360d87 100644 ---

[Mesa-dev] [PATCH 4/9] mesa api_exec: disable various functions for GL CORE profiles

2012-10-24 Thread Jordan Justen
These functions will no longer be enabled for CORE profiles: * ResizeBuffersMESA * MultiModeDrawArraysIBM * MultiModeDrawElementsIBM * DepthBoundsEXT * EGLImageTargetTexture2DOES * EGLImageTargetRenderbufferStorageOES * ObjectPurgeableAPPLE * ObjectUnpurgeableAPPLE * GetObjectParameterivAPPLE *

[Mesa-dev] [PATCH 7/9] dispatch_sanity test: allow newer functions to be set to NOP

2012-10-24 Thread Jordan Justen
If a GL function was introduced in a later GL version than the context we are testing, then it is okay if it is set to the _mesa_generic_nop function. Signed-off-by: Jordan Justen jordan.l.jus...@intel.com --- src/mesa/main/tests/dispatch_sanity.cpp | 14 +++--- 1 file changed, 11

[Mesa-dev] [PATCH 5/9] dispatch_sanity test: add version to function list

2012-10-24 Thread Jordan Justen
This will be used by GL CORE contexts to differentiate functions that can be set to nop from functions that are required for a particular context version. Signed-off-by: Jordan Justen jordan.l.jus...@intel.com --- src/mesa/main/tests/dispatch_sanity.cpp | 707 --- 1

[Mesa-dev] [PATCH 9/9] dispatch_sanity test: add GL CORE 3.1 test

2012-10-24 Thread Jordan Justen
The function list was generated from glcorearb.h for GL 4.3. Note that many GL 4.X functions start with a dash (-) which indicates that they are not yet known to Mesa. Signed-off-by: Jordan Justen jordan.l.jus...@intel.com --- src/mesa/main/tests/dispatch_sanity.cpp | 639

[Mesa-dev] [PATCH 8/9] dispatch_sanity test: allow functions that Mesa doesn't yet support

2012-10-24 Thread Jordan Justen
For newer versions of GL, we can indicate that GL requires the function, but Mesa does not yet support it. To indicate a function is not yet known by Mesa, you add a dash (-) at the start of the name. If the function is required for the context version being tested, then the test will assert.

Re: [Mesa-dev] [PATCH 1/2] shared-glapi: implement _glapi_get_proc_name().

2012-10-24 Thread Matt Turner
On Tue, Oct 23, 2012 at 12:37 PM, Paul Berry stereotype...@gmail.com wrote: Previously this function was only implemented for non-shared-glapi builds. Since the function is only intended for debugging purposes we use a simple O(n) algorithm. --- src/mapi/mapi/mapi_glapi.c | 4 ++--

[Mesa-dev] Mesa 8.0.5 release

2012-10-24 Thread Andreas Boll
Mesa 8.0.5 has been released. Mesa 8.0.5 is a bug fix release which fixes bugs found since the 8.0.4 release. The tag in the GIT repository for Mesa 8.0.5 is 'mesa-8.0.5'. Mesa 8.0.5 is available for download at ftp://freedesktop.org/pub/mesa/8.0.5/ Sorry for the long delay of Mesa 8.0.5, but

[Mesa-dev] [PATCH 1/2] Split dispatch sanity's validate_function test into two

2012-10-24 Thread Matt Turner
Will be useful for the next patch, adding GLES 3 testing. --- This patch has been trivially rebased onto Paul's dispatch_sanity: print names of functions that shouldnt be in dispatch table. src/mesa/main/tests/dispatch_sanity.cpp | 11 +++ 1 files changed, 11 insertions(+), 0

[Mesa-dev] [PATCH 2/2] mesa/tests: Add ES3.0 dispatch table sanity test

2012-10-24 Thread Matt Turner
Since ES3.0 is backward compatible with 2.0, we check that all the 2.0 functions and additional 3.0 functions exist. --- src/mesa/main/tests/dispatch_sanity.cpp | 149 +++ 1 files changed, 149 insertions(+), 0 deletions(-) diff --git

[Mesa-dev] [PATCH] egl: Import eglext.h revision 19332

2012-10-24 Thread Matt Turner
The version number (14) wasn't updated. --- include/EGL/eglext.h |8 +++- 1 files changed, 7 insertions(+), 1 deletions(-) diff --git a/include/EGL/eglext.h b/include/EGL/eglext.h index e96c3a4..974b2c0 100644 --- a/include/EGL/eglext.h +++ b/include/EGL/eglext.h @@ -34,7 +34,7 @@ extern

Re: [Mesa-dev] Pure OpenGL|ES 1.1 s/w renderer

2012-10-24 Thread Dave Airlie
On Thu, Oct 25, 2012 at 7:44 AM, Ilyes Gouta ilyes.go...@gmail.com wrote: Hi, I'm rather new to mesa and would like to ask if there is still a pure s/w rendering path for the OpenGL|ES 1.1 pipeline in mesa; that's not LLVM based (gallium) but just plain C? Yes softpipe, but I've no idea how

Re: [Mesa-dev] [PATCH 4/9] mesa api_exec: disable various functions for GL CORE profiles

2012-10-24 Thread Eric Anholt
Jordan Justen jordan.l.jus...@intel.com writes: These functions will no longer be enabled for CORE profiles: * ResizeBuffersMESA GL_MESA_resize_buffers is marked GL not GLL. * MultiModeDrawArraysIBM * MultiModeDrawElementsIBM GL_IBM_multimode_draw_arrays is marked GL not GLL, but I don't

[Mesa-dev] [PATCH] glsl: Allow ir_if in the linker's move_non_declarations function.

2012-10-24 Thread Kenneth Graunke
Global initializers using the ?: operator with at least one non-constant operand generate ir_if statements. For example, float foo = some_boolean ? 0.0 : 1.0; becomes: (declare (temporary) float conditional_tmp) (if (var_ref some_boolean) ((assign (x) (var_ref conditional_tmp)

Re: [Mesa-dev] Pure OpenGL|ES 1.1 s/w renderer

2012-10-24 Thread Kenneth Graunke
On 10/24/2012 02:44 PM, Ilyes Gouta wrote: Hi, I'm rather new to mesa and would like to ask if there is still a pure s/w rendering path for the OpenGL|ES 1.1 pipeline in mesa; that's not LLVM based (gallium) but just plain C? If yes, what's it status vs. GLES and is there any additional

Re: [Mesa-dev] [PATCH 2/9] mesa shaderapi: don't enable various functions for GL CORE

2012-10-24 Thread Matt Turner
On Wed, Oct 24, 2012 at 2:20 PM, Jordan Justen jordan.l.jus...@intel.com wrote: - if (ctx-API != API_OPENGLES2) { + if (ctx-API != API_OPENGL_CORE ctx-API != API_OPENGLES2) { @@ -1732,9 +1732,8 @@ _mesa_init_shader_dispatch(const struct gl_context *ctx, - if (ctx-API != API_OPENGLES2) {