[Mesa-dev] [PATCH] i965: Add defines for tessellation stages

From: Chris Forbes v2 (Ken): - Squash together commits for HS, DS, and TE, as well as fixes. - Add INTEL_MASK variants so we can use SET_FIELD if we want. - Rename GEN7_HS_INSTANCE_CONTROL to GEN7_HS_INSTANCE_COUNT to match the documentation. - Add some more fields from the

[Mesa-dev] [Bug 91869] [PATCH] ralloc: atexit(3) handlers used in dlopened libraries

https://bugs.freedesktop.org/show_bug.cgi?id=91869 Jean-Sébastien Pédron changed: What|Removed |Added Attachment #118072|0 |1

[Mesa-dev] [PATCH 2/2] i965: Mark topologies with adjacency information as G45+.

These didn't exist on the original 965. Signed-off-by: Kenneth Graunke --- src/mesa/drivers/dri/i965/brw_defines.h | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_defines.h

[Mesa-dev] [PATCH 1/2] i965: Fix value of _3DPRIM_TRIFAN_NOSTIPPLE.

TRIFAN_NOSTIPPLE has always been 0x16 - 0x15 is marked "Reserved" on all platforms. See the 965 PRM, Volume 2, Table 3-1, "3D Primitive Topology Type Encoding" for a list. We don't currently use this, and I don't expect we will, but we may as well not leave the bogus value around.

Re: [Mesa-dev] [PATCH 1/2] i965: Fix value of _3DPRIM_TRIFAN_NOSTIPPLE.

These two are: Reviewed-by: Chris Forbes On Mon, Sep 7, 2015 at 7:03 PM, Kenneth Graunke wrote: > TRIFAN_NOSTIPPLE has always been 0x16 - 0x15 is marked "Reserved" on all > platforms. See the 965 PRM, Volume 2, Table 3-1, "3D Primitive Topology > Type

[Mesa-dev] [Bug 91793] the "bin" directory is not created

https://bugs.freedesktop.org/show_bug.cgi?id=91793 --- Comment #3 from Emil Velikov --- Nope, I mean that the requirements are not being met :) It should be a matter of making sure the relevant .pc are around at configure time and the headers + libs (.dll, .dll.a

[Mesa-dev] [PATCH v2 1/2] egl/dri2: Close file descriptor on error.

From: Matt Turner v2: [Emil Velikov] Rework the error path to a common goto, close only if we own the fd. Signed-off-by: Emil Velikov --- src/egl/drivers/dri2/platform_drm.c | 27 ++- 1 file changed, 14 insertions(+), 13

[Mesa-dev] [PATCH 2/2] egl/dri2/drm: compact existing device mgmt

Move the fcntl(dupfd_cloexec) to the else branch where it belongs. Otherwise it's not immediately obvious that the code is hit, only when an existing device is used. Signed-off-by: Emil Velikov --- src/egl/drivers/dri2/platform_drm.c | 10 -- 1 file changed, 4

Re: [Mesa-dev] [PATCH] Use IMP_LIB_EXT when checking for LLVM shared libraries

Hi Jon, On 4 September 2015 at 14:00, Jon TURNEY wrote: > When checking for LLVM shared libraries, use IMP_LIB_EXT for the extension for > shared libraries appropriate to the target, rather than hardcoding '.so' > > Also add some comments to explain why we have this

Re: [Mesa-dev] [PATCH] ralloc: Use __attribute__((destructor)) instead of atexit(3)

On 04.09.2015 01:37, Matt Turner wrote: >> +__attribute__((destructor)) > > You need to test for this support in configure.ac. It's as simple as > adding a call to AX_GCC_FUNC_ATTRIBUTE in the existing alphabetized > list and then a little bit of preprocessor in src/util/macros.h. (I > think you

Re: [Mesa-dev] [PATCH 0/2] Fix remaining uses of X11_CFLAGS

Hi Jon, On 4 September 2015 at 12:43, Jon TURNEY wrote: > X11_CFLAGS isn't defined by configure.ac since commmit 35189d76 removed > PKG_CHECK_MODULES([X11],[x11]) > > Fix the remaining uses of X11_CFLAGS. There are no uses of X11_LIBS > > Jon TURNEY (2): > Use

[Mesa-dev] [PATCH 1/2] nir: Add a nir_system_value_from_intrinsic() function.

This converts NIR intrinsics that load system values into Mesa's SYSTEM_VALUE_* enumerations. Signed-off-by: Kenneth Graunke --- src/glsl/nir/nir.c | 34 ++ src/glsl/nir/nir.h | 2 ++ 2 files changed, 36 insertions(+) diff --git

[Mesa-dev] [PATCH 2/2] i965/nir: Use nir_system_value_from_intrinsic to reduce duplication.

This code is all pretty much identical. We just needed the translation from one enum value to the other. Signed-off-by: Kenneth Graunke --- src/mesa/drivers/dri/i965/brw_fs_nir.cpp | 47 +++--- src/mesa/drivers/dri/i965/brw_vec4_nir.cpp | 30

Re: [Mesa-dev] Adaptive Vsync

On 7 September 2015 at 05:59, Albert Freeman wrote: > Correction, we just need someone to mark all the comitted patches in > patchwork... This is already done automatically. Sigh top posting :'(. -Emil ___ mesa-dev mailing

Re: [Mesa-dev] Adaptive Vsync

On 07/09/15 11:22, Emil Velikov wrote: On 7 September 2015 at 05:59, Albert Freeman wrote: Correction, we just need someone to mark all the comitted patches in patchwork... This is already done automatically. Sigh top posting :'(. -Emil I often have to help

[Mesa-dev] [Bug 91888] EGL Wayland software rendering no longer work after regression

https://bugs.freedesktop.org/show_bug.cgi?id=91888 --- Comment #2 from Daniel Stone --- I think that commit is a a red herring. 0x3098 is EGL_CONTEXT_CLIENT_VERSION, and Mesa has recently gained more strictness: if ((api != EGL_OPENGL_ES_API &&

Re: [Mesa-dev] [PATCH] ralloc: Use __attribute__((destructor)) instead of atexit(3)

On 04.09.2015 01:37, Matt Turner wrote: > You need to test for this support in configure.ac. It's as simple as > adding a call to AX_GCC_FUNC_ATTRIBUTE in the existing alphabetized > list and then a little bit of preprocessor in src/util/macros.h. Should the code fallbacks on atexit(3) if the

Re: [Mesa-dev] [Mesa-stable] [PATCH] ralloc: Use __attribute__((destructor)) instead of atexit(3)

On 06.09.2015 23:40, Emil Velikov wrote: > Hi Jean-Sébastien, Hi! > On 3 September 2015 at 19:07, Jean-Sébastien Pédron > We have 4(5) users of atexit() - EGL, gallium trace driver, core mesa > and util/ralloc. The latter of which is used almost everywhere in > mesa. So a bit I'm confused how

Re: [Mesa-dev] [PATCH v4 (part2) 19/59] i965/wm: surfaces should have the API buffer size, not the drm buffer size

On 07/09/15 11:32, Samuel Iglesias Gonsálvez wrote: > > > On 29/08/15 00:59, Jordan Justen wrote: >> On 2015-08-05 01:30:16, Iago Toral Quiroga wrote: >>> From: Samuel Iglesias Gonsalvez >>> >>> The returned drm buffer object has a size multiple of 4096 but that should

Re: [Mesa-dev] [PATCH v4 (part2) 19/59] i965/wm: surfaces should have the API buffer size, not the drm buffer size

On 29/08/15 00:59, Jordan Justen wrote: > On 2015-08-05 01:30:16, Iago Toral Quiroga wrote: >> From: Samuel Iglesias Gonsalvez >> >> The returned drm buffer object has a size multiple of 4096 but that should >> not >> be exposed to the API user, which is working with a

Re: [Mesa-dev] [PATCH] nir: UBO loads no longer use const_index[1]

Jason, since that commit is yours, could you review this change? it is a one liner. Thanks, Iago On Tue, 2015-09-01 at 11:32 +0200, Iago Toral Quiroga wrote: > Commit 2126c68e5cba killed the array elements parameter on load/store > intrinsics that was stored in const_index[1]. It looks like that

Re: [Mesa-dev] [PATCH 02/13] i965: Keep track of whether LRI is allowed in the context struct.

On Mon, Sep 07, 2015 at 05:21:53PM +0300, Francisco Jerez wrote: > I'm sure you had some specific practical advantage in mind? Bashing the > rather sensitive L3 configuration registers to see if something sticks > is a hack with potential implications. I'd prefer to avoid that unless > there is

Re: [Mesa-dev] [PATCH] ralloc: Use __attribute__((destructor)) instead of atexit(3)

On 07/09/15 10:17, Jean-Sébastien Pédron wrote: On 04.09.2015 01:37, Matt Turner wrote: You need to test for this support in configure.ac. It's as simple as adding a call to AX_GCC_FUNC_ATTRIBUTE in the existing alphabetized list and then a little bit of preprocessor in src/util/macros.h.

Re: [Mesa-dev] [PATCH 2/2] i965/nir: Use nir_system_value_from_intrinsic to reduce duplication.

Reviewed-by: Iago Toral Quiroga On Mon, 2015-09-07 at 00:30 -0700, Kenneth Graunke wrote: > This code is all pretty much identical. We just needed the translation > from one enum value to the other. > > Signed-off-by: Kenneth Graunke > --- >

Re: [Mesa-dev] [PATCH 02/13] i965: Keep track of whether LRI is allowed in the context struct.

Chris Wilson writes: > On Mon, Sep 07, 2015 at 05:21:53PM +0300, Francisco Jerez wrote: >> I'm sure you had some specific practical advantage in mind? Bashing the >> rather sensitive L3 configuration registers to see if something sticks >> is a hack with potential

Re: [Mesa-dev] [PATCH] i965: Disallow fast blit paths for CopyTexImage with PixelTransfer ops

Looks correct, based on the previous discussion about the same fix for ReadPixels and TexImage. CopyTexImage has the same requirements. Reviewed-by: Iago Toral Quiroga On Sun, 2015-09-06 at 17:37 +0100, Chris Wilson wrote: > glCopyTexImage behaves similarly to glReadPixels

Re: [Mesa-dev] [PATCH 02/13] i965: Keep track of whether LRI is allowed in the context struct.

Chris Wilson writes: > On Sun, Sep 06, 2015 at 07:48:40PM +0300, Francisco Jerez wrote: >> Chris Wilson writes: >> >> > On Sun, Sep 06, 2015 at 07:28:12PM +0300, Francisco Jerez wrote: >> >> Chris Wilson writes: >>

Re: [Mesa-dev] [PATCH 1/2] nir: Add a nir_system_value_from_intrinsic() function.

Reviewed-by: Iago Toral Quiroga On Mon, 2015-09-07 at 00:30 -0700, Kenneth Graunke wrote: > This converts NIR intrinsics that load system values into Mesa's > SYSTEM_VALUE_* enumerations. > > Signed-off-by: Kenneth Graunke > --- > src/glsl/nir/nir.c |

Re: [Mesa-dev] [RFC] i965: Resolve color for all active shader images in intel_update_state().

On Mon, Sep 07, 2015 at 10:15:56AM -0700, Kenneth Graunke wrote: > On Saturday, September 05, 2015 08:58:07 PM Chris Wilson wrote: > > On Sat, Sep 05, 2015 at 11:30:44AM -0700, Jordan Justen wrote: > > > From: Francisco Jerez > > > > > > Fixes > > >

Re: [Mesa-dev] [PATCH 3/5] nir: Add new GS intrinsics that maintain a count of emitted vertices.

On Sep 3, 2015 1:49 AM, "Kenneth Graunke" wrote: > > This patch also introduces a lowering pass to convert the simple GS > intrinsics to the new ones. See the comments above that for the > rationale behind the new intrinsics. > > This should be useful for i965; it's a

Re: [Mesa-dev] [PATCH 4/5] i965/gs: Use new NIR intrinsics.

On Mon, Sep 7, 2015 at 11:06 AM, Jason Ekstrand wrote: > On Thu, Sep 3, 2015 at 1:48 AM, Kenneth Graunke wrote: >> By performing the vertex counting in NIR, we're able to elide a ton of >> useless safety checks around every EmitVertex() call: >> >>

Re: [Mesa-dev] [PATCH] i965: Disallow fast blit paths for CopyTexImage with PixelTransfer ops

On Sunday, September 06, 2015 05:37:18 PM Chris Wilson wrote: > glCopyTexImage behaves similarly to glReadPixels with respect to the > pixel transfer operations. Therefore if any are set we cannot use the > simply blit fast paths. > > Signed-off-by: Chris Wilson > Cc:

Re: [Mesa-dev] [RFC] i965: Resolve color for all active shader images in intel_update_state().

On Saturday, September 05, 2015 08:58:07 PM Chris Wilson wrote: > On Sat, Sep 05, 2015 at 11:30:44AM -0700, Jordan Justen wrote: > > From: Francisco Jerez > > > > Fixes > > arb_shader_image_load_store/execution/load-from-cleared-image.shader_test > > > > Cc: Chris Wilson

Re: [Mesa-dev] [PATCH] nir: UBO loads no longer use const_index[1]

LGTM: Reviewed-by: Jason Ekstrand On Mon, Sep 7, 2015 at 4:52 AM, Iago Toral wrote: > Jason, since that commit is yours, could you review this change? it is a > one liner. > > Thanks, > Iago > > On Tue, 2015-09-01 at 11:32 +0200, Iago Toral Quiroga

Re: [Mesa-dev] [PATCH] r600: don't use shader key without verifying shader type

On 8 September 2015 at 08:46, Dave Airlie wrote: > On 8 September 2015 at 08:38, Dave Airlie wrote: >> From: Dave Airlie >> >> Since 7a32652231f96eac14c4bfce02afe77b4132fb77 >> r600: Turn 'r600_shader_key' struct into union >> >> we were

[Mesa-dev] [PATCH] clover: Avoid using typename to allow compilation of clover by clang

When parsing an variable declaration qualified with the typename keyword, clang attempted to declare a variable with the type of non type member "enum type type" of module::argument (within the header file clover/core/module.hpp) instead of the typed member of module::argument "enum type".

[Mesa-dev] [PATCH] r600: don't use shader key without verifying shader type (v2)

From: Dave Airlie Since 7a32652231f96eac14c4bfce02afe77b4132fb77 r600: Turn 'r600_shader_key' struct into union we were accessing key fields that might be aliased in the union with other fields, so we should check what shader type we are compiling for before using key values

Re: [Mesa-dev] Adaptive Vsync

On 7 September 2015 at 08:22, Emil Velikov wrote: > On 7 September 2015 at 05:59, Albert Freeman > wrote: >> Correction, we just need someone to mark all the comitted patches in >> patchwork... > This is already done automatically. > > Sigh

Re: [Mesa-dev] [PATCH 1/3] glsl: Use hash tables in opt_constant_variable().

I did not get as impressive results with these 3 patches (how did you measure?) but on my machine (HSW GT2) complete shader_runner time goes from ~83 secs to ~70secs so it is definitely improving. I simply do 'time bin/shader_runner' for the measurement. Tested-by: Tapani Pälli

Re: [Mesa-dev] [PATCH 1/2] r600/llvm: remove dead code for LLVM 3.3

Kill it ! -- Edward O'Callaghan edward.ocallag...@koparo.com On Mon, Sep 7, 2015, at 08:14 AM, Marek Olšák wrote: > From: Marek Olšák > > LLVM 3.3 has been unsupported for quite a while. > --- > src/gallium/drivers/r600/r600_llvm.c | 106 >

Re: [Mesa-dev] [PATCH 2/2] egl/dri2/drm: compact existing device mgmt

2015-09-07 16:58 GMT+08:00 Emil Velikov : > Move the fcntl(dupfd_cloexec) to the else branch where it belongs. > Otherwise it's not immediately obvious that the code is hit, only when > an existing device is used. A potential problem here. The fd acquired from gbm device

Re: [Mesa-dev] [PATCH] r600: don't use shader key without verifying shader type

On 8 September 2015 at 08:38, Dave Airlie wrote: > From: Dave Airlie > > Since 7a32652231f96eac14c4bfce02afe77b4132fb77 > r600: Turn 'r600_shader_key' struct into union > > we were accessing key fields that might be aliased in the union > with other fields,

Re: [Mesa-dev] Adaptive Vsync

On 8 September 2015 at 01:16, Albert Freeman wrote: > On 7 September 2015 at 08:22, Emil Velikov wrote: >> On 7 September 2015 at 05:59, Albert Freeman >> wrote: >>> Correction, we just need someone to mark all the

[Mesa-dev] [PATCH] r600: don't use shader key without verifying shader type

From: Dave Airlie Since 7a32652231f96eac14c4bfce02afe77b4132fb77 r600: Turn 'r600_shader_key' struct into union we were accessing key fields that might be aliased in the union with other fields, so we should check what shader type we are compiling for before using key values

Re: [Mesa-dev] [PATCH v2 1/2] egl/dri2: Close file descriptor on error.

2015-09-07 16:58 GMT+08:00 Emil Velikov : > From: Matt Turner > > v2: [Emil Velikov] > Rework the error path to a common goto, close only if we own the fd. > > Signed-off-by: Emil Velikov Reviewed-by: Boyan Ding

Re: [Mesa-dev] [PATCH V3 1/6] glsl: order indices for samplers inside a struct array

On Mon, 2015-09-07 at 11:24 -0700, Jason Ekstrand wrote: > On Tue, Sep 1, 2015 at 7:44 PM, Timothy Arceri > wrote: > > This allows the correct offset to be easily calculated for indirect > > indexing when a struct array contains multiple samplers, or any crazy > > nesting.

Re: [Mesa-dev] [PATCH] r600: don't use shader key without verifying shader type (v2)

LGTM, thanks for catching this! -- Edward O'Callaghan edward.ocallag...@koparo.com On Tue, Sep 8, 2015, at 09:32 AM, Dave Airlie wrote: > From: Dave Airlie > > Since 7a32652231f96eac14c4bfce02afe77b4132fb77 > r600: Turn 'r600_shader_key' struct into union > > we were

Re: [Mesa-dev] [PATCH 2/2] gallium/radeon: drop support for LLVM 3.4

Kill it! -- Edward O'Callaghan edward.ocallag...@koparo.com On Mon, Sep 7, 2015, at 08:14 AM, Marek Olšák wrote: > From: Marek Olšák > > This allows using the new tex instrinsics unconditionally. > --- > configure.ac| 2 +- >

[Mesa-dev] [Bug 91888] EGL Wayland software rendering no longer work after regression

https://bugs.freedesktop.org/show_bug.cgi?id=91888 --- Comment #3 from nerdopol...@verizon.net --- So, should I report this against qtwayland instead? -- You are receiving this mail because: You are the QA Contact for the bug. ___ mesa-dev mailing

[Mesa-dev] [PATCH v3 4/4] build: enable st/va with nouveau driver

vainfo fails in vaDriverInit because "dd_create_screen" does not reach strcmp(driver_name, "nouveau") code. Indeed when compiling the va target.c, the macro GALLIUM_NOUVEAU is not defined. This patch define the macro the same it is done for dri and vdpau targets. Tested with: ./autogen.sh

[Mesa-dev] [PATCH v3 2/4] nvc0: add support for st/va

- split nvc0_decoder_bsp in begin/next/end - preserve content buffer when calling nvc0_decoder_bsp_next - implement pipe_video_codec::begin_frame/end_frame https://bugs.freedesktop.org/show_bug.cgi?id=89969 Signed-off-by: Julien Isorce ---

[Mesa-dev] [PATCH v3 3/4] nouveau: fix chunk decoding by updating number of slices

https://bugs.freedesktop.org/show_bug.cgi?id=89969 Signed-off-by: Julien Isorce --- src/gallium/drivers/nouveau/nouveau_vp3_video.h | 3 +++ src/gallium/drivers/nouveau/nouveau_vp3_video_bsp.c | 8 2 files changed, 11 insertions(+) diff --git

[Mesa-dev] [PATCH v3 1/4] nouveau: split nouveau_vp3_bsp in begin/next/end

It allows to call nouveau_vp3_bsp_next multiple times between one begin/end. It is required to support st/va. https://bugs.freedesktop.org/show_bug.cgi?id=89969 Signed-off-by: Julien Isorce --- src/gallium/drivers/nouveau/nouveau_vp3_video.h| 16 +++-

Re: [Mesa-dev] [PATCH V3 1/6] glsl: order indices for samplers inside a struct array

On Tue, 2015-09-08 at 08:09 +1000, Timothy Arceri wrote: > On Mon, 2015-09-07 at 11:24 -0700, Jason Ekstrand wrote: > > On Tue, Sep 1, 2015 at 7:44 PM, Timothy Arceri < > > t_arc...@yahoo.com.au> > > wrote: > > > This allows the correct offset to be easily calculated for > > > indirect > > >

Re: [Mesa-dev] [PATCH mesa 2/3] nv30: Fix color resolving for nv3x cards

May I ask why you're doing 512x512 instead of 1024x1024? These are already scaled up coordinates, so 1024x1024 should work no? Or is it because of the seams on the edges? Do those not also appear with 512x512 or does it sample outside of the box? Separately, why not use this approach on nv40 as

Re: [Mesa-dev] [PATCH mesa 3/3] nv30: Disable msaa for now because it causes lockups

On Mon, Sep 7, 2015 at 3:50 PM, Hans de Goede wrote: > msaa use on nv30 may trigger a (mesa?) bug where dmesg says: > [ 1197.850642] nouveau E[soffice.bin[3785]] fail ttm_validate > [ 1197.850648] nouveau E[soffice.bin[3785]] validating bo list > [ 1197.850654] nouveau

Re: [Mesa-dev] [PATCH V3 1/6] glsl: order indices for samplers inside a struct array

On Tue, Sep 1, 2015 at 7:44 PM, Timothy Arceri wrote: > This allows the correct offset to be easily calculated for indirect > indexing when a struct array contains multiple samplers, or any crazy > nesting. > > The indices for the folling struct will now look like this: >

Re: [Mesa-dev] [PATCH V3 2/6] glsl: assign hidden uniforms their slot id earlier

On Tue, Sep 1, 2015 at 7:44 PM, Timothy Arceri wrote: > This is required so that the next patch can safely assign the slot id > to the var. > > The ids are now assigned in the order we want before allocating storage > so there is no need to sort the storage array and move

Re: [Mesa-dev] [PATCH V3 4/6] glsl: make variables private

Reviewed-by: Jason Ekstrand On Tue, Sep 1, 2015 at 7:44 PM, Timothy Arceri wrote: > --- > src/glsl/link_uniforms.cpp | 22 +++--- > 1 file changed, 11 insertions(+), 11 deletions(-) > > diff --git a/src/glsl/link_uniforms.cpp

Re: [Mesa-dev] [Mesa-stable] [PATCH v2 2/2] gallium/hud: display the Celsius temperature unit

Le 05/09/2015 10:19, Samuel Pitoiset a écrit : > > On 09/04/2015 08:57 PM, Benjamin Bellec wrote: >> Currently, the temperature is displayed with a "%" symbol in >> gallium/hud, which is quite odd. >> Marek suggested to only change the value "100" to another value so >> that this symbol is no more

[Mesa-dev] [PATCH mesa 2/3] nv30: Fix color resolving for nv3x cards

We do not have a generic blitter on nv3x cards, so we must use the sifm object for color resolving. This commit divides the sources and dest surfaces in to tiles which match the constraints of the sifm object, so that color resolving will work properly on nv3x cards. Signed-off-by: Hans de Goede

[Mesa-dev] [PATCH mesa 1/3] nv30: Fix max width / height checks in nv30 sifm code

The sifm object has a limit of 1024x1024 for its input size and 2048x2048 for its output. The code checking this was trying to be clever resulting in it seeing a surface of e.g 1024x256 being outside of the input size limit. This commit fixes this. Signed-off-by: Hans de Goede

[Mesa-dev] [PATCH mesa 3/3] nv30: Disable msaa for now because it causes lockups

msaa use on nv30 may trigger a (mesa?) bug where dmesg says: [ 1197.850642] nouveau E[soffice.bin[3785]] fail ttm_validate [ 1197.850648] nouveau E[soffice.bin[3785]] validating bo list [ 1197.850654] nouveau E[soffice.bin[3785]] validate: -12 [ 1201.766955] nouveau E[soffice.bin[3785]] fail

Re: [Mesa-dev] [PATCH V3 3/6] glsl: store uniform slot id in var location field

On Tue, Sep 1, 2015 at 7:44 PM, Timothy Arceri wrote: > This will allow us to access the uniform later on without resorting to > building a name string and looking it up in UniformHash. > > V2: store slot number for all non-UBO uniforms to make code more > consitent,

Re: [Mesa-dev] [PATCH mesa 1/3] nv30: Fix max width / height checks in nv30 sifm code

Yeah, I noticed this was odd too when looking over the code earlier. Glad you picked up on that as well. Reviewed-by: Ilia Mirkin Cc: "10.6 11.0" On Mon, Sep 7, 2015 at 3:50 PM, Hans de Goede wrote: > The sifm