Re: [Mesa-dev] [PATCH 15/17] nvc0: handle the case where there are no framebuffer attachments

Please leave this and the next patch out of your series. I'm going to need to retest everything carefully once the core support is in (and I get a bit of time). Thanks, -ilia On Thu, Mar 24, 2016 at 8:11 PM, Edward O'Callaghan wrote: > From: Ilia Mirkin

Re: [Mesa-dev] [PATCH 10/17] gallium/util: Ensure util_framebuffer_get_num_samples() is valid

Instead of introducing buggy code in patch 6/17 and then fixing it up here, you need to fold this with patch 6 so that it's all done at the same time. On Thu, Mar 24, 2016 at 8:11 PM, Edward O'Callaghan wrote: > Upon context creation, internal driver structures are

Re: [Mesa-dev] [PATCH 05/17] mesa/st: Use _mesa_geometric_ functions appropriately

On Thu, Mar 24, 2016 at 8:11 PM, Edward O'Callaghan wrote: > Change references to gl_framebuffer::Width, Height, MaxNumLayers > and Visual::samples to use the _mesa_geometric_ convenience functions > for those places where the geometry of the gl_framebuffer is

Re: [Mesa-dev] [PATCH 03/17] mesa/st: Set _NumSamples in update_framebuffer_state()

On Thu, Mar 24, 2016 at 8:11 PM, Edward O'Callaghan wrote: > Using PIPE_FORMAT_NONE to indicate what MSAA modes are supported > with a framebuffer using no attachment. > > Signed-off-by: Edward O'Callaghan > --- >

Re: [Mesa-dev] [PATCH] i965: Whack UAV bit when FS discards and there are no color writes.

Francisco Jerez writes: > Jason Ekstrand writes: > >> On Thu, Mar 24, 2016 at 5:50 PM, Kenneth Graunke >> wrote: >> >>> dEQP-GLES31.functional.fbo.no_attachments.* draws a quad with no >>> framebuffer attachments, using a

Re: [Mesa-dev] [PATCH] i965: Whack UAV bit when FS discards and there are no color writes.

Jason Ekstrand writes: > On Thu, Mar 24, 2016 at 5:50 PM, Kenneth Graunke > wrote: > >> dEQP-GLES31.functional.fbo.no_attachments.* draws a quad with no >> framebuffer attachments, using a shader that discards based on >> gl_FragCoord. It uses

[Mesa-dev] [RFC 1/4] gallium: add compute shader IR type

Needed to distinguish NATIVE and TGSI compute shaders on compute state creation. Signed-off-by: Bas Nieuwenhuizen --- src/gallium/drivers/trace/tr_dump_state.c | 2 ++ src/gallium/include/pipe/p_state.h| 1 +

[Mesa-dev] [RFC 0/4] Gallium interface change for compute shaders

These patches contain some interface changes that I want to use for my compute shader work for radeonsi. I am interested in any input or objections on the patches, especially the fourth one. Thanks, Bas Nieuwenhuizen Bas Nieuwenhuizen (4): gallium: add compute shader IR type gallium: Add

[Mesa-dev] [RFC 3/4] gallium: Add global buffer memory barrier bit

Currently radeonsi synchronizes after every dispatch and Clover does nothing to synchronize. This is overzealous, especially with GL compute, so add a barrier for global buffers. Signed-off-by: Bas Nieuwenhuizen --- src/gallium/include/pipe/p_defines.h | 1

[Mesa-dev] [RFC 2/4] gallium: Add fixed block size to pipe_compute_state

This avoids shader variants for radeonsi, or if we go with shader variants, it lets us compile an initial variant. Signed-off-by: Bas Nieuwenhuizen --- src/gallium/drivers/trace/tr_dump_state.c | 4 src/gallium/include/pipe/p_state.h| 6 ++

[Mesa-dev] [RFC 4/4] gallium: Distinguish between shader IR's in get_compute_param.

For radeonsi, native and TGSI use different compilers and this results in different limits for different IR's. The set we strictly need for radeonsi is only the MAX_BLOCK_SIZE and MAX_THREADS_PER_BLOCK params, but I added a few others as shader related that seemed like they would also typically

Re: [Mesa-dev] [PATCH] i965: Whack UAV bit when FS discards and there are no color writes.

On Thu, Mar 24, 2016 at 5:50 PM, Kenneth Graunke wrote: > dEQP-GLES31.functional.fbo.no_attachments.* draws a quad with no > framebuffer attachments, using a shader that discards based on > gl_FragCoord. It uses occlusion queries to inspect whether pixels > are rendered

Re: [Mesa-dev] [PATCH] gallium: Formatted code in pb_buffer_fenced.c according to style guide.

Welcome to the community! Some small comments. We usually write patch messages in present tense. So, "Format code in ". Some more comments below. On Mar 25, 2016 01:24, "Rovanion Luckey" wrote: > > This is a tiny housekeeping patch which does the following: > >

Re: [Mesa-dev] [PATCH] i965: Whack UAV bit when FS discards and there are no color writes.

Kenneth Graunke writes: > dEQP-GLES31.functional.fbo.no_attachments.* draws a quad with no > framebuffer attachments, using a shader that discards based on > gl_FragCoord. It uses occlusion queries to inspect whether pixels > are rendered or not. > > Unfortunately, the

[Mesa-dev] [PATCH] i965: Whack UAV bit when FS discards and there are no color writes.

dEQP-GLES31.functional.fbo.no_attachments.* draws a quad with no framebuffer attachments, using a shader that discards based on gl_FragCoord. It uses occlusion queries to inspect whether pixels are rendered or not. Unfortunately, the hardware is not dispatching any pixel shaders, so discards

[Mesa-dev] [PATCH] gallium: Formatted code in pb_buffer_fenced.c according to style guide.

This is a tiny housekeeping patch which does the following: * Replaced tabs with three spaces. * Formatted oneline and multiline code comments. Some doxygen comments weren't marked as such and some code comments were marked as doxygen comments.

[Mesa-dev] [PATCH 02/17] gallium: Obtain ARB_framebuffer_no_attachment constants

Set default values for the constants required in ARB_framebuffer_no_attachments and obtained the number of layers from ``PIPE_CAP_MAX_TEXTURE_ARRAY_LAYERS``. We also obtain the MaxFramebufferSamples value using a query back to the driver for PIPE_FORMAT_NONE. Signed-off-by: Edward O'Callaghan

[Mesa-dev] [PATCH 04/17] mesa: Add comment to framebuffer_parameteri()

Signed-off-by: Edward O'Callaghan --- src/mesa/main/fbobject.c | 5 + 1 file changed, 5 insertions(+) diff --git a/src/mesa/main/fbobject.c b/src/mesa/main/fbobject.c index bb8d4c3..42f40b2 100644 --- a/src/mesa/main/fbobject.c +++ b/src/mesa/main/fbobject.c @@

[Mesa-dev] [PATCH 09/17] softpipe: Set samples and layers in set_framebuffer_state() cb

Carries across the number of samples and layers state in the 'softpipe_set_framebuffer_state()' callback. This state is part of 'ARB_framebuffer_no_attachments' support. Signed-off-by: Edward O'Callaghan Reviewed-by: Marek Olšák ---

[Mesa-dev] [PATCH 06/17] gallium: Put no.of {samples, layers} into pipe_framebuffer_state

Here we store the number of samples and layers directly in the pipe_framebuffer_state so that in the case of ARB_framebuffer_no_attachment we may make use of them directly. Further, we adjust various gallium/auxiliary helper functions accordingly. V2: Convert branches in

[Mesa-dev] [PATCH 01/17] gallium: Add PIPE_CAP_FRAMEBUFFER_NO_ATTACHMENT

Add PIPE_CAP to determine if the GL extension 'GL_ARB_framebuffer_no_attachments' shall be supported. The driver is required to support 'PIPE_FORMAT_NONE' via its 'is_format_supported()' callback in order to determine the MSAA modes the hardware supports so that values requested from the

[Mesa-dev] [PATCH 03/17] mesa/st: Set _NumSamples in update_framebuffer_state()

Using PIPE_FORMAT_NONE to indicate what MSAA modes are supported with a framebuffer using no attachment. Signed-off-by: Edward O'Callaghan --- src/mesa/state_tracker/st_atom_framebuffer.c | 51 1 file changed, 51 insertions(+) diff

[Mesa-dev] [PATCH 05/17] mesa/st: Use _mesa_geometric_ functions appropriately

Change references to gl_framebuffer::Width, Height, MaxNumLayers and Visual::samples to use the _mesa_geometric_ convenience functions for those places where the geometry of the gl_framebuffer is needed. This is in contrast to the geometry of the intersection of the attachments of the

[Mesa-dev] [PATCH 07/17] gallium/trace: Dump no.of samples and layers in fb state

Signed-off-by: Edward O'Callaghan Reviewed-by: Marek Olšák --- src/gallium/drivers/trace/tr_dump_state.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/gallium/drivers/trace/tr_dump_state.c

[Mesa-dev] [PATCH 11/17] radeonsi: Allow 16 samples MSAA mode for PIPE_FORMAT_NONE

For ARB_framebuffer_no_attachment; A is_format_supported() query with 'PIPE_FORMAT_NONE' passed implies a query of the number of samples supported from the framebuffer with no attachment. Signed-off-by: Edward O'Callaghan --- src/gallium/drivers/radeonsi/si_state.c

[Mesa-dev] [PATCH 12/17] radeonsi: Improve assert info out of si_set_framebuffer_state()

Lets give the developer a little hand if we are going to assert on a zero literal at the end of a branch. Signed-off-by: Edward O'Callaghan --- src/gallium/drivers/radeonsi/si_state.c | 2 ++ 1 file changed, 2 insertions(+) diff --git

[Mesa-dev] [PATCH 16/17] nvc0: Enable ARB_framebuffer_no_attachment

Signed-off-by: Edward O'Callaghan --- src/gallium/drivers/nouveau/nvc0/nvc0_screen.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/drivers/nouveau/nvc0/nvc0_screen.c b/src/gallium/drivers/nouveau/nvc0/nvc0_screen.c index

[Mesa-dev] [PATCH 13/17] radeonsi: Enable ARB_framebuffer_no_attachments

Signed-off-by: Edward O'Callaghan --- src/gallium/drivers/radeonsi/si_pipe.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/drivers/radeonsi/si_pipe.c b/src/gallium/drivers/radeonsi/si_pipe.c index 51ebb96..d00e562 100644 ---

[Mesa-dev] [PATCH 15/17] nvc0: handle the case where there are no framebuffer attachments

From: Ilia Mirkin Signed-off-by: Ilia Mirkin Reviewed-by: Edward O'Callaghan --- src/gallium/drivers/nouveau/nvc0/nvc0_program.c| 7 +++ src/gallium/drivers/nouveau/nvc0/nvc0_state_validate.c | 16

[Mesa-dev] [PATCH 17/17] GL3.txt: Mark ARB_framebuffer_no_attachments as done

Signed-off-by: Edward O'Callaghan --- docs/GL3.txt | 2 +- docs/relnotes/11.3.0.html | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/docs/GL3.txt b/docs/GL3.txt index 88c14c4..8cb17f3 100644 --- a/docs/GL3.txt +++ b/docs/GL3.txt @@

[Mesa-dev] [PATCH 14/17] r600g: Enable ARB_framebuffer_no_attachments

Signed-off-by: Edward O'Callaghan --- src/gallium/drivers/r600/r600_pipe.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/drivers/r600/r600_pipe.c b/src/gallium/drivers/r600/r600_pipe.c index 4b91874..7b4f9cb 100644 ---

[Mesa-dev] [PATCH 10/17] gallium/util: Ensure util_framebuffer_get_num_samples() is valid

Upon context creation, internal driver structures are malloc()'ed and memset() to zero them. This results in a invalid number of samples 'by default'. Handle this in the simplest way to avoid elaborate and probably equally sub-optimial solutions. V2: Minor, use "NOTE:" instead of "N.B." in

[Mesa-dev] [PATCH 08/17] mesa/st: Update framebuffer state with no.of samples, layers

Handle the case of ARB_framebuffer_no_attachment. Also, kill off a dead debug printf() call while we are here. Signed-off-by: Edward O'Callaghan Reviewed-by: Marek Olšák --- src/mesa/state_tracker/st_atom_framebuffer.c | 8 +--- 1 file

[Mesa-dev] ARB_framebuffer_no_attachment - final for real this time

I hope to have finally addressed everything by now, fingers crossed. ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH] nv50/ra: `isinf()` is in namespace `std` since C++11

On 24/03/16 22:07, Ilia Mirkin wrote: On Sat, Mar 19, 2016 at 6:30 PM, Jose Fonseca wrote: On 19/03/16 22:25, Ilia Mirkin wrote: On Sat, Mar 19, 2016 at 6:23 PM, Jose Fonseca wrote: On 18/03/16 04:00, Ilia Mirkin wrote: On Mar 17, 2016 8:27

[Mesa-dev] [PATCH] st/mesa: allow glsl version up to 420

radeonsi and nouveau are pretty close to have OpenGL 4.2. Signed-off-by: Samuel Pitoiset --- src/mesa/state_tracker/st_extensions.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/mesa/state_tracker/st_extensions.c

[Mesa-dev] [PATCH] svga: avoid freeing non-malloced memory

svga_shader_expand will fall back to using non-malloced memory for emit.buf if malloc fails. We should check if the memory is malloced before freeing it in the error path of svga_tgsi_vgpu9_translate. --- All we need to do is check if emit->buf points to the err_buf. I was surprised to see a

Re: [Mesa-dev] [PATCH v2] anv: Sanitize Image extents and offsets

rb On Thu, Mar 24, 2016 at 3:22 PM, Nanley Chery wrote: > From: Nanley Chery > > Prepare Image extents and offsets for internal consumption by assigning > the default values implicitly defned by the spec. Fixes textures on > several Vulkan demos

[Mesa-dev] [PATCH v2] anv: Sanitize Image extents and offsets

From: Nanley Chery Prepare Image extents and offsets for internal consumption by assigning the default values implicitly defned by the spec. Fixes textures on several Vulkan demos in which the VkImageCopy depth is set to zero when copying a 2D image. v2 (Jason

Re: [Mesa-dev] [PATCH] nv50/ra: `isinf()` is in namespace `std` since C++11

On Sat, Mar 19, 2016 at 6:30 PM, Jose Fonseca wrote: > On 19/03/16 22:25, Ilia Mirkin wrote: >> >> On Sat, Mar 19, 2016 at 6:23 PM, Jose Fonseca wrote: >>> >>> On 18/03/16 04:00, Ilia Mirkin wrote: On Mar 17, 2016 8:27 PM, "Matt

Re: [Mesa-dev] [PATCH] nv50/ra: `isinf()` is in namespace `std` since C++11

On Thu, Mar 17, 2016 at 5:25 PM, Samuel Pitoiset wrote: > > > On 03/18/2016 01:22 AM, Matt Turner wrote: >> >> On Thu, Mar 17, 2016 at 5:17 PM, Pierre Moreau >> wrote: >>> >>> This fixes a compile error while building Nouveau with C++11 enabled

Re: [Mesa-dev] [PATCH] mesa: Check glReadBuffer enums against the ES3 table.

On 03/24/2016 07:12 PM, Kenneth Graunke wrote: On Thursday, March 24, 2016 10:29:44 AM PDT Eduardo Lima Mitev wrote: On 03/24/2016 07:54 AM, Kenneth Graunke wrote: From the ES 3.2 spec, section 16.1.1 (Selecting Buffers for Reading): "An INVALID_ENUM error is generated if src is not

[Mesa-dev] [RFC 1/2] nir: lower-indirect-io pass

From: Rob Clark Prior to running nir_lower_io_types (next patch), we need to eliminate indirect load_input/store_output. This can either be done via nir_lower_indirect_derefs (for hw which does not support indirect var access) or this pass (for hw which does). ---

[Mesa-dev] [RFC 2/2] nir: lower-io-types pass

From: Rob Clark A pass to lower complex (struct/array/mat) inputs/outputs to primitive types. This allows, for example, linking that removes unused components of a larger type which is not indirectly accessed. In the near term, it is needed for gallium (mesa/st)

[Mesa-dev] [RFC 0/2] nir: lowering complex input/output types

From: Rob Clark The first pass would be used if you are not using nir_lower_indirect_deref's (which would be the case for ir3, since we do have indirect register access). This simply ensure there are no indirected input/outputs. The second pass splits up

Re: [Mesa-dev] [PATCH] mesa: Check glReadBuffer enums against the ES3 table.

On Thursday, March 24, 2016 10:29:44 AM PDT Eduardo Lima Mitev wrote: > On 03/24/2016 07:54 AM, Kenneth Graunke wrote: > > From the ES 3.2 spec, section 16.1.1 (Selecting Buffers for Reading): > > > > "An INVALID_ENUM error is generated if src is not BACK or one of > > the values from

[Mesa-dev] [PATCH 06/11] glapi: Fix whitespace droppings when printing the license header

Signed-off-by: Adam Jackson --- src/mapi/glapi/gen/gl_XML.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mapi/glapi/gen/gl_XML.py b/src/mapi/glapi/gen/gl_XML.py index 2e7123e..e11f6fc 100644 --- a/src/mapi/glapi/gen/gl_XML.py +++

[Mesa-dev] [PATCH 04/11] glapi/glx: Thunk non-ABI calls through GetProcAddress

Signed-off-by: Adam Jackson --- src/mapi/glapi/gen/glX_proto_recv.py | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/src/mapi/glapi/gen/glX_proto_recv.py b/src/mapi/glapi/gen/glX_proto_recv.py index 916da94..1cfa8c5 100644 ---

[Mesa-dev] [PATCH 02/11] glapi/glx: Emit direct GL calls instead of dispatch lookup

Signed-off-by: Adam Jackson --- src/mapi/glapi/gen/Makefile.am | 11 --- src/mapi/glapi/gen/glX_proto_recv.py | 33 ++--- 2 files changed, 10 insertions(+), 34 deletions(-) diff --git a/src/mapi/glapi/gen/Makefile.am

[Mesa-dev] [PATCH 05/11] glapi/glx: Treat xserver generated targets as .PHONY

Meaning, always rebuild them when asked instead of bothering to look at timestamps (and then wondering why nothing happened when you said make). Signed-off-by: Adam Jackson --- src/mapi/glapi/gen/Makefile.am | 2 ++ 1 file changed, 2 insertions(+) diff --git

[Mesa-dev] [PATCH 08/11] glapi: Harden GLX request size processing

--- src/mapi/glapi/gen/glX_XML.py| 2 +- src/mapi/glapi/gen/glX_proto_recv.py | 2 -- src/mapi/glapi/gen/glX_proto_send.py | 2 -- src/mapi/glapi/gen/glX_proto_size.py | 24 +++- src/mapi/glapi/gen/gl_XML.py | 2 +- 5 files changed, 13 insertions(+), 19

[Mesa-dev] [PATCH 07/11] glapi: Add the safe_{add, mul, pad} functions from xserver

We're about to update the generator scripts to use these, easier not to vary between client and server. Signed-off-by: Adam Jackson --- src/mapi/glapi/gen/glX_proto_send.py | 24 1 file changed, 24 insertions(+) diff --git

[Mesa-dev] [PATCH 09/11] glapi/glx: Sync some additional error checking from xserver

Signed-off-by: Adam Jackson --- src/mapi/glapi/gen/glX_proto_recv.py | 4 1 file changed, 4 insertions(+) diff --git a/src/mapi/glapi/gen/glX_proto_recv.py b/src/mapi/glapi/gen/glX_proto_recv.py index 21b187c..a138adb 100644 --- a/src/mapi/glapi/gen/glX_proto_recv.py +++

[Mesa-dev] [PATCH 10/11] glapi/glx: Mark byteswap functions as _X_UNUSED

Squashes the one remaining warning in the xserver build. Signed-off-by: Adam Jackson --- src/mapi/glapi/gen/glX_proto_recv.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mapi/glapi/gen/glX_proto_recv.py b/src/mapi/glapi/gen/glX_proto_recv.py index

[Mesa-dev] [PATCH 01/11] glx: Unbreak generating some of the xorg glx headers

Broken by: commit 9ace0b542241c77ae82a0835ac8a09e2a7510eaf Author: Dylan Baker Date: Wed May 20 15:49:11 2015 -0700 glapi: glX_proto_size.py: use argparse instead of getopt Which changed most, but not all, callers to use --header-tag instead of

[Mesa-dev] [PATCH 11/11] glapi/glx: Mark the indirect swapped dispatch functions _X_COLD

A modest size savings: textdata bss dec hex filename 264143 15608 232 279983 445af libglx.so.before 254303 15608 232 270143 41f3f libglx.so.after Signed-off-by: Adam Jackson --- src/mapi/glapi/gen/glX_proto_recv.py | 6 +++--- 1 file

[Mesa-dev] [PATCH 03/11] glapi/glx: skip that which is marked for skipping

Signed-off-by: Adam Jackson --- src/glx/indirect_vertex_array.c | 39 src/glx/indirect_vertex_program.c | 202 -- src/glx/tests/indirect_api.cpp| 2 - src/mapi/glapi/gen/glX_XML.py | 6 +- 4 files changed, 4

[Mesa-dev] [PATCH 00/11] Generated GLX dispatch updates

Apologies for the stray duplicate copy of 01/11, neglected to say --compose and didn't hit ^C in time. This long-overdue series synchronizes the GLX dispatch scripts with the state of the world in xserver. We no longer use the CALL_* pattern instead emitting gl* calls directly (or thunking

[Mesa-dev] [PATCH 01/11] glx: Unbreak generating some of the xorg glx headers

Broken by: commit 9ace0b542241c77ae82a0835ac8a09e2a7510eaf Author: Dylan Baker Date: Wed May 20 15:49:11 2015 -0700 glapi: glX_proto_size.py: use argparse instead of getopt Which changed most, but not all, callers to use --header-tag instead of

[Mesa-dev] [Bug 94657] [llvmpipe] [softpipe] piglit arb_texture_view-getteximage-srgb regression

https://bugs.freedesktop.org/show_bug.cgi?id=94657 Nicolai Hähnle changed: What|Removed |Added Status|NEW |RESOLVED

Re: [Mesa-dev] [PATCH] anv: Sanitize Image extents and offsets

On Thu, Mar 24, 2016 at 9:27 AM, Nanley Chery wrote: > From: Nanley Chery > > Prepare Image extents and offsets for internal consumption by assigning > the default values implicitly defined by the spec. Fixes textures on > several Vulkan demos in

[Mesa-dev] [PATCH] anv: Sanitize Image extents and offsets

From: Nanley Chery Prepare Image extents and offsets for internal consumption by assigning the default values implicitly defined by the spec. Fixes textures on several Vulkan demos in which the VkImageCopy depth is set to zero when copying a 2D image. Signed-off-by:

Re: [Mesa-dev] [PATCH] mesa: replace gl_context->Multisample._Enabled with _mesa_is_multisample_enabled.

Will do. BTW, I had to add #include "main/framebuffer.h" in st_atom_rasterizer.c -Brian On 03/24/2016 05:29 AM, Bas Nieuwenhuizen wrote: Can someone push this patch for me? Thanks, Bas Nieuwenhuizen On Wed, Mar 23, 2016 at 4:21 PM, Brian Paul wrote: No regressions

Re: [Mesa-dev] [PATCH] mesa: replace gl_context->Multisample._Enabled with _mesa_is_multisample_enabled.

Can someone push this patch for me? Thanks, Bas Nieuwenhuizen On Wed, Mar 23, 2016 at 4:21 PM, Brian Paul wrote: > No regressions here, Bas. > > -Brian > > > On 03/22/2016 01:27 PM, Brian Paul wrote: >> >> If you can wait until tomorrow, Bas, I'll do an overight piglit run to

Re: [Mesa-dev] [GSOC] looking for information

Hi Lurie, Thx for your interest. In order to work on this project you would need either a AMD or NVIDIA graphic hardware. Indeed current st/omx in Gallium, only work with these 2 hardwares and it would be out of scope of the project to add support for another hardware. In order to check that

Re: [Mesa-dev] [android-x86-devel] Re: gralloc_drm_pipe

On Wed, Mar 23, 2016 at 10:14 PM, Chih-Wei Huang wrote: > 2016-03-24 8:51 GMT+08:00 Rob Clark : > [deleted] >> >> [*] the caveat there is vmwgfx stuff which seems to want to do blits.. >> although I'm not entirely sure why or if that is even still

Re: [Mesa-dev] [PATCH] mesa: Check glReadBuffer enums against the ES3 table.

On 03/24/2016 07:54 AM, Kenneth Graunke wrote: From the ES 3.2 spec, section 16.1.1 (Selecting Buffers for Reading): "An INVALID_ENUM error is generated if src is not BACK or one of the values from table 15.5." Table 15.5 contains NONE and COLOR_ATTACHMENTi. Mesa properly returned

Re: [Mesa-dev] [PATCH 2/2] mesa: Handle negative length in glPushDebugGroup().

Both patches are: Reviewed-by: Eduardo Lima Mitev Together with the other patch you sent earlier, I get these results for dEQP-GLES31.functional.debug.* : Test run totals: Passed:1004/1010 (99.4%) Failed:6/1010 (0.6%) Not supported: 0/1010 (0.0%)

[Mesa-dev] [PATCH 1/2] mesa: Make glDebugMessageInsert deal with negative length for all types.

From the KHR_debug spec, section 5.5.5 (Externally Generated Messages): "If is negative, it is implied that contains a null terminated string. The error INVALID_VALUE will be generated if the number of characters in , excluding the null terminator when is negative, is not less

[Mesa-dev] [PATCH 2/2] mesa: Handle negative length in glPushDebugGroup().

The KHR_debug spec doesn't actually say we should handle this, but that is most likely an oversight - it says to check against strlen and generate errors if length is negative. It appears they just forgot to explicitly spell out that we should then proceed to actually handle it. Fixes crashes

[Mesa-dev] [PATCH] mesa: Check glReadBuffer enums against the ES3 table.

From the ES 3.2 spec, section 16.1.1 (Selecting Buffers for Reading): "An INVALID_ENUM error is generated if src is not BACK or one of the values from table 15.5." Table 15.5 contains NONE and COLOR_ATTACHMENTi. Mesa properly returned INVALID_ENUM for unknown enums, but it decided what