Re: [Mesa-dev] [PATCH] r600g: fix and optimize tgsi_cmp when using ABS and NEG modifier

2016-04-06 Thread Ian Romanick
On 04/02/2016 02:45 AM, Patrick Rudolph wrote: > Are there optimizations done on TGSI ? > I can't find any file in src/gallium/auxiliary/tgsi that does so. What I meant was, at some point the driver translates TGSI into its own representation. When that translation occurs, generate the smarter

Re: [Mesa-dev] [PATCH 1/2] dri/i965: extend GLES3 sRGB workaround to cover all byte orders

2016-04-06 Thread Haixia Shi
I am afraid that I am not the original author of the gles3_srgb_workaround, and from the comments it appears to only apply for argb formats, so I am not sure if extending it to all other formats would cause behavioral regression. On Apr 6, 2016 10:13 PM, "Jason Ekstrand"

Re: [Mesa-dev] [PATCH 7/8] glx: fix the refcounting of dri drawables

2016-04-06 Thread Ian Romanick
Why would you do that? I've NAKed this patch several times. On 04/06/2016 03:52 AM, Marek Olšák wrote: > This looks good to me. I'll commit this on April 9th if there are > other comments. > > Marek > > On Thu, Mar 24, 2016 at 1:13 AM, Miklós Máté wrote: >> This fixes

Re: [Mesa-dev] [android-x86-devel] Re: gralloc_drm_pipe

2016-04-06 Thread Rob Herring
On Wed, Apr 6, 2016 at 11:12 AM, Chih-Wei Huang wrote: > 2016-04-04 6:25 GMT+08:00 Rob Herring : >> On Sun, Apr 3, 2016 at 12:29 PM, Chih-Wei Huang >> wrote: >>> Besides, the module name is still gralloc.drm. >>> How about

Re: [Mesa-dev] [PATCH 0/2] Extra check for GenQueriesARB and DeleteQueriesARB

2016-04-06 Thread Ian Romanick
On 04/06/2016 07:47 PM, Kenneth Graunke wrote: > On Tuesday, April 5, 2016 2:26:59 PM PDT kevin.rogo...@intel.com wrote: >> From: Kevin Rogovin >> >> This patch sequence enforces an extra check >> for GenQueriesARB and DeleteQueriesARB that >> is not preset in GenQueries

Re: [Mesa-dev] [PATCH 1/2] i965/fs: Add a flat_inputs field to prog_data

2016-04-06 Thread Samuel Iglesias Gonsálvez
On 06/04/16 19:20, Jason Ekstrand wrote: > On Wed, Apr 6, 2016 at 12:47 AM, Samuel Iglesias Gonsálvez < > sigles...@igalia.com> wrote: > >> >> >> On 06/04/16 08:03, Samuel Iglesias Gonsálvez wrote: >>> >>> >>> On 06/04/16 05:12, Jason Ekstrand wrote: ---

Re: [Mesa-dev] [PATCH 1/2] dri/i965: extend GLES3 sRGB workaround to cover all byte orders

2016-04-06 Thread Jason Ekstrand
On Apr 6, 2016 7:23 PM, "Kenneth Graunke" wrote: > > On Wednesday, April 6, 2016 4:43:39 PM PDT Haixia Shi wrote: > > It is incorrect to assume BGRA byte order for the GLES3 sRGB workaround. > > > > Signed-off-by: Haixia Shi > > Reviewed-by: Stéphane

Re: [Mesa-dev] [PATCH 1/2] glsl: Don't remove XFB-only varyings.

2016-04-06 Thread Timothy Arceri
On Sun, 2016-04-03 at 21:30 -0700, Kenneth Graunke wrote: > On Sunday, April 3, 2016 9:34:05 PM PDT Timothy Arceri wrote: > > > > On Sun, 2016-04-03 at 01:37 -0700, Kenneth Graunke wrote: > > > > > > Consider the case of linking a program with both a vertex and > > > fragment > > > shader.  The

Re: [Mesa-dev] [PATCH 1/2] gallium: add pipe_depth_state::disable_occlusion_queries

2016-04-06 Thread Ilia Mirkin
Is it just occlusion queries, or all queries? (e.g. primitives generated, etc). I think all queries... we need a mechanism to tell gallium to pause all the queries (i.e. save off the values) and then resume them. On Wed, Apr 6, 2016 at 9:22 PM, Roland Scheidegger wrote: >

Re: [Mesa-dev] r600/compute: cleanup evergreen_compute.c

2016-04-06 Thread Tom Stellard
On Wed, Apr 06, 2016 at 10:40:50PM +0100, Dave Airlie wrote: > This probably should have been cleaned up before merging, but we > were a bit lax with it. This is a bunch of cleanups and changes, > that make adding ARB_compute_support less of a task. > Acked-by: Tom Stellard

Re: [Mesa-dev] [PATCH 0/2] Extra check for GenQueriesARB and DeleteQueriesARB

2016-04-06 Thread Kenneth Graunke
On Tuesday, April 5, 2016 2:26:59 PM PDT kevin.rogo...@intel.com wrote: > From: Kevin Rogovin > > This patch sequence enforces an extra check > for GenQueriesARB and DeleteQueriesARB that > is not preset in GenQueries and DeleteQueries. > > Kevin Rogovin (2): >

Re: [Mesa-dev] [PATCH 1/2] dri/i965: extend GLES3 sRGB workaround to cover all byte orders

2016-04-06 Thread Kenneth Graunke
On Wednesday, April 6, 2016 4:43:39 PM PDT Haixia Shi wrote: > It is incorrect to assume BGRA byte order for the GLES3 sRGB workaround. > > Signed-off-by: Haixia Shi > Reviewed-by: Stéphane Marchesin > Cc: kenneth.w.grau...@intel.com > > Change-Id:

Re: [Mesa-dev] radeonsi, r600g ARB_framebuffer_no_attachments rebased

2016-04-06 Thread Dave Airlie
On 3 April 2016 at 21:56, wrote: > On 2016-04-03 14:55, Ilia Mirkin wrote: >> >> On Sat, Apr 2, 2016 at 10:54 PM, Edward O'Callaghan >> wrote: >>> >>> This series implements ARB_framebuffer_no_attachments for radeonsi & >>> r600g. It

[Mesa-dev] [PATCH v2] radeonsi: use guard band clipping

2016-04-06 Thread Grigori Goronzy
With the previous changes to handling of viewport clipping, it is almost trivial to add proper support for guard band clipping. Select a suitable integer clipping value to keep inside the rasterizer's guard band range of [-32768, 32767] and program the hardware to use guard band clipping. Guard

Re: [Mesa-dev] [PATCH 1/2] gallium: add pipe_depth_state::disable_occlusion_queries

2016-04-06 Thread Roland Scheidegger
Where's the doc bits... But aside from that, this doesn't look quite right to me. Doesn't really feel like depth state (more like context one to suspend queries), and more importantly it should most likely apply to all queries, not just occlusion ones (making it definitely no longer dsa state).

[Mesa-dev] [PATCH 1/2] gallium: add pipe_depth_state::disable_occlusion_queries

2016-04-06 Thread Marek Olšák
From: Marek Olšák Since occlusion queries count Z passes, the depth state seems to be the best place. --- src/gallium/auxiliary/hud/hud_context.c| 2 ++ src/gallium/auxiliary/postprocess/pp_mlaa.c| 1 + src/gallium/auxiliary/postprocess/pp_program.c | 1 +

[Mesa-dev] [PATCH 2/2] radeonsi: handle pipe_depth_state::disable_occlusion_queries

2016-04-06 Thread Marek Olšák
From: Marek Olšák + 2 piglits --- src/gallium/drivers/radeonsi/si_state.c | 11 ++- src/gallium/drivers/radeonsi/si_state.h | 1 + 2 files changed, 11 insertions(+), 1 deletion(-) diff --git a/src/gallium/drivers/radeonsi/si_state.c

Re: [Mesa-dev] [PATCH] radeonsi: disable perfect ZPASS counts for PIPE_QUERY_OCCLUSION_PREDICATE

2016-04-06 Thread Nicolai Hähnle
Reviewed-by: Nicolai Hähnle On 06.04.2016 19:36, Marek Olšák wrote: From: Marek Olšák --- src/gallium/drivers/radeon/r600_pipe_common.h | 3 ++- src/gallium/drivers/radeon/r600_query.c | 12 ++--

Re: [Mesa-dev] [PATCH 26/26] nir/dead_variables: Configurably work with any variable mode

2016-04-06 Thread Kenneth Graunke
On Friday, March 25, 2016 4:12:40 PM PDT Jason Ekstrand wrote: > The old version of the pass only worked on globals and locals and always > left inputs, outputs, uniforms, etc. alone. > --- > src/compiler/nir/nir.h | 2 +- > src/compiler/nir/nir_remove_dead_variables.c | 33

Re: [Mesa-dev] [PATCH 6/6] i965: Push everything if pull_param == NULL

2016-04-06 Thread Kenneth Graunke
On Tuesday, April 5, 2016 9:11:13 PM PDT Jason Ekstrand wrote: > --- > src/mesa/drivers/dri/i965/brw_fs.cpp | 10 -- > src/mesa/drivers/dri/i965/brw_vec4_visitor.cpp | 6 ++ > 2 files changed, 14 insertions(+), 2 deletions(-) > > diff --git

Re: [Mesa-dev] [PATCH 5/6] i965/vec4: Support full std140 layout for push constants

2016-04-06 Thread Kenneth Graunke
On Tuesday, April 5, 2016 9:11:12 PM PDT Jason Ekstrand wrote: > Up until now, we have been able to assume that all push constants are > vec4-aligned because this is what the GL driver gives us. In Vulkan, we > need to be able to support full std140 because we get the layout from the > client. >

[Mesa-dev] [PATCH] radeonsi: disable perfect ZPASS counts for PIPE_QUERY_OCCLUSION_PREDICATE

2016-04-06 Thread Marek Olšák
From: Marek Olšák --- src/gallium/drivers/radeon/r600_pipe_common.h | 3 ++- src/gallium/drivers/radeon/r600_query.c | 12 ++-- src/gallium/drivers/radeonsi/si_state.c | 6 -- 3 files changed, 16 insertions(+), 5 deletions(-) diff --git

Re: [Mesa-dev] [PATCH] radeonsi: don't use the real barrier instruction in tess ctrl shaders

2016-04-06 Thread Nicolai Hähnle
Reviewed-by: Nicolai Hähnle On 06.04.2016 19:07, Marek Olšák wrote: From: Marek Olšák --- src/gallium/drivers/radeonsi/si_shader.c | 8 1 file changed, 8 insertions(+) diff --git a/src/gallium/drivers/radeonsi/si_shader.c

Re: [Mesa-dev] [PATCH] svga: add some trivial null pointer checks

2016-04-06 Thread eocallaghan
Reviewed-by: Edward O'Callaghan +1 for defensive programming. On 2016-04-07 06:00, Brian Paul wrote: These small mallocs will probably never fail, but static analysis tools may complain about the missing checks. --- src/gallium/drivers/svga/svga_pipe_blend.c

Re: [Mesa-dev] [PATCH 4/7] gallium: raise PIPE_MAX_SAMPLERS to 32

2016-04-06 Thread Roland Scheidegger
Am 07.04.2016 um 00:47 schrieb Nicolai Hähnle: > From: Nicolai Hähnle > > The previous value of 18 was motivated by having drivers that want to expose > 16 samplers but also use some additional samplers for internal use. Raising > the value even higher isn't going to

Re: [Mesa-dev] [PATCH] radeonsi: don't use the real barrier instruction in tess ctrl shaders

2016-04-06 Thread Bas Nieuwenhuizen
This patch is Reviewed-by: Bas Nieuwenhuizen On Thu, Apr 7, 2016 at 2:07 AM, Marek Olšák wrote: > From: Marek Olšák > > --- > src/gallium/drivers/radeonsi/si_shader.c | 8 > 1 file changed, 8 insertions(+) > > diff

Re: [Mesa-dev] [PATCH 00/12] nir: Functions!

2016-04-06 Thread Jason Ekstrand
On Tue, Apr 5, 2016 at 8:31 PM, ShawQ <361213...@qq.com> wrote: > Hi all, > > > > I am sorry to trouble you. I have a question when I build Vulkan with > scons find will not build the project of root/src/compiler/nir. > > I found there was not SConscript file in the root/src/compiler/nir. Can we

Re: [Mesa-dev] r600/compute: cleanup evergreen_compute.c

2016-04-06 Thread eocallaghan
Nice cleanup. This series is, Reviewed-by: Edward O'Callaghan On 2016-04-07 07:40, Dave Airlie wrote: This probably should have been cleaned up before merging, but we were a bit lax with it. This is a bunch of cleanups and changes, that make adding

Re: [Mesa-dev] [PATCH 16/26] i965: Implement the new imod and irem opcodes

2016-04-06 Thread Jason Ekstrand
On Fri, Mar 25, 2016 at 4:12 PM, Jason Ekstrand wrote: > --- > src/mesa/drivers/dri/i965/brw_fs_nir.cpp | 32 > ++ > src/mesa/drivers/dri/i965/brw_vec4_nir.cpp | 32 > ++ > 2 files changed, 64 insertions(+) > > diff

Re: [Mesa-dev] [PATCH 1/4] i965: Move get_hw_prim_for_gl_prim to brw_util.c

2016-04-06 Thread Kenneth Graunke
On Monday, April 4, 2016 3:51:12 PM PDT Jason Ekstrand wrote: > It's used by brw_compile_gs in brw_vec4_gs_visitor.cpp so it needs to be in > a file that's linked into libi965_compiler.la. > --- > src/mesa/drivers/dri/i965/brw_draw.c | 29 - >

Re: [Mesa-dev] [PATCH 00/12] nir: Functions!

2016-04-06 Thread ShawQ
Hi all, I am sorry to trouble you. I have a question when I build Vulkan with scons find will not build the project of root/src/compiler/nir. I found there was not SConscript file in the root/src/compiler/nir. Can we build the spirv project in linux enviroment with automake tool?

Re: [Mesa-dev] [PATCH 1/6] i965/vec4: Move can_do_writemask to vec4_instruction

2016-04-06 Thread Michael Schellenberger Costa
Hi Jason, Am 06.04.2016 um 06:11 schrieb Jason Ekstrand: > --- > src/mesa/drivers/dri/i965/brw_ir_vec4.h| 1 + > src/mesa/drivers/dri/i965/brw_vec4.cpp | 28 +++ > .../dri/i965/brw_vec4_dead_code_eliminate.cpp | 31 > +- > 3

Re: [Mesa-dev] [PATCH 4/6] i965/vec4: Handle MOV_INDIRECT in pack_uniform_registers

2016-04-06 Thread Michael Schellenberger Costa
Hi Jason, Am 06.04.2016 um 06:11 schrieb Jason Ekstrand: > --- > src/mesa/drivers/dri/i965/brw_vec4.cpp | 18 ++ > 1 file changed, 18 insertions(+) > > diff --git a/src/mesa/drivers/dri/i965/brw_vec4.cpp > b/src/mesa/drivers/dri/i965/brw_vec4.cpp > index e2aa109..6433fc5 100644

Re: [Mesa-dev] [PATCH 0/7] gallium, radeonsi: raise number of samplers to 32

2016-04-06 Thread Bas Nieuwenhuizen
Hi Nicolai, Patches 1-2 and 5-6 are Reviewed-by: Bas Nieuwenhuizen However, for increasing the limits there are several cases which still use signed shifts (i.e. 1 << ...) which is undefined behavior shifting into bit 31. mesa/st contains several of those, not sure

[Mesa-dev] [Bug 94168] Incorrect rendering when running Populous 3 on wine using DDraw->WineD3D->OpenGL wrapper [apitrace]

2016-04-06 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=94168 --- Comment #2 from Grazvydas Ignotas --- i965 seems to be fine, at least matches LIBGL_ALWAYS_SOFTWARE. -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for the

[Mesa-dev] [PATCH] radeonsi: do per-pixel clipping based on viewport states

2016-04-06 Thread Marek Olšák
From: Marek Olšák In other words, vport scissors are derived from viewport states. If the scissor test is enabled, the intersection of both is used. The guard band will disable clipping, so we have to clip per-pixel. --- src/gallium/drivers/radeonsi/si_state.c | 95

[Mesa-dev] [PATCH] radeonsi: don't use the real barrier instruction in tess ctrl shaders

2016-04-06 Thread Marek Olšák
From: Marek Olšák --- src/gallium/drivers/radeonsi/si_shader.c | 8 1 file changed, 8 insertions(+) diff --git a/src/gallium/drivers/radeonsi/si_shader.c b/src/gallium/drivers/radeonsi/si_shader.c index bf3f008..08da3e3 100644 ---

Re: [Mesa-dev] [PATCH v3] dri/i965: fix incorrect rgbFormat in intelCreateBuffer().

2016-04-06 Thread Kristian Høgsberg
On Tue, Apr 5, 2016 at 6:20 PM, Haixia Shi wrote: > It is incorrect to assume that pixel format is always in BGR byte order. > We need to check bitmask parameters (such as |redMask|) to determine whether > the RGB or BGR byte order is requested. It still seems like something

Re: [Mesa-dev] [PATCH v2] dri/i965: fix incorrect rgbFormat in intelCreateBuffer().

2016-04-06 Thread Haixia Shi
Ilia: please review patch v4. I have added a separate patch to fix the GLES3 sRGB workaround, which fixes the colorspace issue. On Tue, Apr 5, 2016 at 5:20 PM, Ilia Mirkin wrote: > Sounds right. That's glEnable/glDisable(GL_FRAMEBUFFER_SRGB). It > defaults to off for

[Mesa-dev] [PATCH 1/2] dri/i965: extend GLES3 sRGB workaround to cover all byte orders

2016-04-06 Thread Haixia Shi
It is incorrect to assume BGRA byte order for the GLES3 sRGB workaround. Signed-off-by: Haixia Shi Reviewed-by: Stéphane Marchesin Cc: kenneth.w.grau...@intel.com Change-Id: I5a081d7eaa7544afff0e7874cffef80d3f69a401 ---

[Mesa-dev] [PATCH 2/2 v4] dri/i965: fix incorrect rgbFormat in intelCreateBuffer().

2016-04-06 Thread Haixia Shi
It is incorrect to assume that pixel format is always in BGR byte order. We need to check bitmask parameters (such as |redMask|) to determine whether the RGB or BGR byte order is requested. v2: reformat code to stay within 80 character per line limit. v3: just fix the byte order problem first and

Re: [Mesa-dev] [PATCH 3/7] st/glsl_to_tgsi: make samplers_used an uint32_t

2016-04-06 Thread Brian Paul
On 04/06/2016 04:46 PM, Nicolai Hähnle wrote: From: Nicolai Hähnle It is used as a bitfield, so it seems cleaner to keep it unsigned. --- src/mesa/state_tracker/st_glsl_to_tgsi.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [Mesa-dev] [PATCH 2/2] radeonsi: use guard band clipping

2016-04-06 Thread Marek Olšák
There is one small issue with this. It uses viewport extents clamped to [0, 16384], but it should use unclamped signed coordinates of the viewport. The hw clipper doesn't do any clamping, so it's easy to generate window coordinates outside of [-32768, 32768] if the viewport covers [-32768, 1] in

[Mesa-dev] [PATCH 7/7] radeonsi: raise number of samplers per shader to 32

2016-04-06 Thread Nicolai Hähnle
From: Nicolai Hähnle Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=94835 --- src/gallium/drivers/radeonsi/si_state.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/gallium/drivers/radeonsi/si_state.h

[Mesa-dev] [PATCH 0/7] gallium, radeonsi: raise number of samplers to 32

2016-04-06 Thread Nicolai Hähnle
Hi, it seems that games increasingly expect to be able to use 32 samplers in their shaders. This series is intended to enable that for radeonsi, but as a side effect also does so for the Gallium software renderers. It's mostly an exercise in changing constants. This increases the size of

[Mesa-dev] [PATCH 1/7] util/pstipple: stronger guard against no free samplers

2016-04-06 Thread Nicolai Hähnle
From: Nicolai Hähnle When hasFixedUnit is false, polygon stippling will fail when there is no free sampler available. Make the corresponding guard more robust in preparation of raising PIPE_MAX_SAMPLERS to 32. --- src/gallium/auxiliary/util/u_pstipple.c | 2 +- 1 file

[Mesa-dev] [PATCH 2/7] draw/aaline: stronger guard against no free samplers

2016-04-06 Thread Nicolai Hähnle
From: Nicolai Hähnle Line anti-aliasing will fail when there is no free sampler available. Make the corresponding guard more robust in preparation of raising PIPE_MAX_SAMPLERS to 32. --- src/gallium/auxiliary/draw/draw_pipe_aaline.c | 2 +- 1 file changed, 1

[Mesa-dev] [PATCH 4/7] gallium: raise PIPE_MAX_SAMPLERS to 32

2016-04-06 Thread Nicolai Hähnle
From: Nicolai Hähnle The previous value of 18 was motivated by having drivers that want to expose 16 samplers but also use some additional samplers for internal use. Raising the value even higher isn't going to hurt that case. On the other hand, some drivers actually

[Mesa-dev] [PATCH 5/7] radeonsi: replace magic 16 by SI_NUM_USER_SAMPLERS

2016-04-06 Thread Nicolai Hähnle
From: Nicolai Hähnle --- src/gallium/drivers/radeonsi/si_pipe.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/drivers/radeonsi/si_pipe.c b/src/gallium/drivers/radeonsi/si_pipe.c index 12e0d50..10b3a03 100644 ---

[Mesa-dev] [PATCH 6/7] radeonsi: expand the compressed color and depth texture masks to 64 bits

2016-04-06 Thread Nicolai Hähnle
From: Nicolai Hähnle This is in preparation of raising the number of exposed sampler views to 32 bits, which will raise the total number of sampler views to 33 for the polygon stipple texture. That texture should never be compressed (and it's certainly not a depth

[Mesa-dev] [PATCH 3/7] st/glsl_to_tgsi: make samplers_used an uint32_t

2016-04-06 Thread Nicolai Hähnle
From: Nicolai Hähnle It is used as a bitfield, so it seems cleaner to keep it unsigned. --- src/mesa/state_tracker/st_glsl_to_tgsi.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mesa/state_tracker/st_glsl_to_tgsi.cpp

Re: [Mesa-dev] [PATCH 5/8] main: rework the compatibility check of visuals in glXMakeCurrent

2016-04-06 Thread Miklós Máté
On 04/06/2016 12:52 PM, Marek Olšák wrote: This looks good to me. I'll commit this on April 9th if there are other comments. Marek Thanks for not forgetting this. MM On Thu, Mar 24, 2016 at 1:12 AM, Miklós Máté wrote: Now it follows the compatibility criteria listed in

[Mesa-dev] [PATCH 6/7] r600: make compute global buffer functions static.

2016-04-06 Thread Dave Airlie
From: Dave Airlie This moves things around so that the global buffer handling functions in evergreen_compute.c are static. Signed-off-by: Dave Airlie --- src/gallium/drivers/r600/evergreen_compute.c | 172 +--

[Mesa-dev] [PATCH 5/7] r600: make two compute functions static.

2016-04-06 Thread Dave Airlie
From: Dave Airlie These aren't used outside evergreen_compute.c Signed-off-by: Dave Airlie --- src/gallium/drivers/r600/evergreen_compute.c | 6 +++--- src/gallium/drivers/r600/evergreen_compute.h | 2 -- 2 files changed, 3 insertions(+), 5 deletions(-)

[Mesa-dev] [PATCH 3/7] r600: in evergreen_compute use ctx consistently instead of ctx_

2016-04-06 Thread Dave Airlie
From: Dave Airlie Signed-off-by: Dave Airlie --- src/gallium/drivers/r600/evergreen_compute.c | 50 ++-- 1 file changed, 25 insertions(+), 25 deletions(-) diff --git a/src/gallium/drivers/r600/evergreen_compute.c

[Mesa-dev] [PATCH 4/7] r600: using pipe_grid_info more in evergreen_compute.

2016-04-06 Thread Dave Airlie
From: Dave Airlie No reason to pull the pieces apart here, also make one of the functions static as it's unused outside this. Signed-off-by: Dave Airlie --- src/gallium/drivers/r600/evergreen_compute.c | 46 +---

[Mesa-dev] [PATCH 1/7] r600: cleanup whitespace in evergreen_compute.c

2016-04-06 Thread Dave Airlie
From: Dave Airlie This aligns the code with the style of the rest of the driver. Makes editing it a lot less painful. Signed-off-by: Dave Airlie --- src/gallium/drivers/r600/evergreen_compute.c | 162 +-- 1 file changed, 75

[Mesa-dev] r600/compute: cleanup evergreen_compute.c

2016-04-06 Thread Dave Airlie
This probably should have been cleaned up before merging, but we were a bit lax with it. This is a bunch of cleanups and changes, that make adding ARB_compute_support less of a task. Dave. ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org

[Mesa-dev] [PATCH 2/7] r600: use rctx consistently in evergreen_compute.c

2016-04-06 Thread Dave Airlie
From: Dave Airlie Another step towards cleaning this up. Signed-off-by: Dave Airlie --- src/gallium/drivers/r600/evergreen_compute.c | 148 +-- 1 file changed, 74 insertions(+), 74 deletions(-) diff --git

[Mesa-dev] [PATCH 7/7] r600: use radeon_emit in a few more places in evergreen_compute

2016-04-06 Thread Dave Airlie
From: Dave Airlie This is just a cleanup of the code. Signed-off-by: Dave Airlie --- src/gallium/drivers/r600/evergreen_compute.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/gallium/drivers/r600/evergreen_compute.c

[Mesa-dev] [Bug 92877] Add support for libglvnd

2016-04-06 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=92877 --- Comment #3 from Kyle Brenneman --- I've written up a rough draft for allowing a vendor library to provide per-context dispatch tables: https://github.com/NVIDIA/libglvnd/pull/85 -- You are receiving this mail

Re: [Mesa-dev] [PATCH] st/va: avoid dereference after free

2016-04-06 Thread Thomas H.P. Andersen
On Sun, Mar 6, 2016 at 10:08 AM, Thomas H.P. Andersen wrote: > > > On Sat, Mar 5, 2016 at 1:30 PM, Emil Velikov > wrote: > >> Hi Thomas, >> >> On 5 March 2016 at 12:07, Thomas Hindoe Paaboel Andersen >> wrote: >> > --- >> >

[Mesa-dev] [PATCH 2/2] radeonsi: use guard band clipping

2016-04-06 Thread Grigori Goronzy
With the previous changes to handling of viewport clipping, it is almost trivial to add proper support for guard band clipping. Select a suitable integer clipping value to keep inside the rasterizer's guard band range of [-32768, 32767] and program the hardware to use guard band clipping. Guard

[Mesa-dev] [PATCH 1/2] radeonsi: do per-pixel clipping based on viewport states

2016-04-06 Thread Grigori Goronzy
From: Marek Olšák In other words, vport scissors are derived from viewport states. If the scissor test is enabled, the intersection of both is used. The guard band will disable clipping, so we have to clip per-pixel. v2: fix check for r600_draw_rectangle and other overflow

[Mesa-dev] [PATCH] svga: add some trivial null pointer checks

2016-04-06 Thread Brian Paul
These small mallocs will probably never fail, but static analysis tools may complain about the missing checks. --- src/gallium/drivers/svga/svga_pipe_blend.c| 3 +++ src/gallium/drivers/svga/svga_pipe_depthstencil.c | 3 +++ src/gallium/drivers/svga/svga_pipe_rasterizer.c | 3 +++ 3

Re: [Mesa-dev] [PATCH 2/2] Differentiate between DeleteQueries and DeleteQueriesARB

2016-04-06 Thread Emil Velikov
Hi Kevin, On 5 April 2016 at 12:27, wrote: > From: Kevin Rogovin > > The extension, GL_ARB_occlusion_queries typo -> ...query (same goes for patch 1/2) > mandates that an > INVALID_OPERATION should be thrown if DeleteQueriesARB is > called

Re: [Mesa-dev] [PATCH 1/2] Differentiate between GenQueries and GenQueriesARB

2016-04-06 Thread Matt Turner
On Tue, Apr 5, 2016 at 4:27 AM, wrote: > From: Kevin Rogovin Subject is missing a required prefix. > The extension, GL_ARB_occlusion_queries mandates that an > INVALID_OPERATION should be thrown if GenQueriesARB is > called while a query is

Re: [Mesa-dev] [PATCH 2/2] Differentiate between DeleteQueries and DeleteQueriesARB

2016-04-06 Thread Matt Turner
On Tue, Apr 5, 2016 at 4:27 AM, wrote: > From: Kevin Rogovin Subject is missing a required prefix. > The extension, GL_ARB_occlusion_queries mandates that an > INVALID_OPERATION should be thrown if DeleteQueriesARB is > called while a query is

Re: [Mesa-dev] [PATCH 2/2] i965/tiled_memcpy: Protect against wrong alignments

2016-04-06 Thread Chad Versace
On 04/05/2016 04:50 PM, Jason Ekstrand wrote: > On Tue, Apr 5, 2016 at 4:26 PM, Chad Versace > wrote: > > On 04/04/2016 06:04 PM, Jason Ekstrand wrote: > > It's possible, when doing an x-tiled copy, to end up with a case where >

Re: [Mesa-dev] [PATCH 1/2] i965/fs: Add a flat_inputs field to prog_data

2016-04-06 Thread Jason Ekstrand
On Wed, Apr 6, 2016 at 12:47 AM, Samuel Iglesias Gonsálvez < sigles...@igalia.com> wrote: > > > On 06/04/16 08:03, Samuel Iglesias Gonsálvez wrote: > > > > > > On 06/04/16 05:12, Jason Ekstrand wrote: > >> --- > >> src/mesa/drivers/dri/i965/brw_compiler.h | 6 ++ > >>

Re: [Mesa-dev] [android-x86-devel] Re: gralloc_drm_pipe

2016-04-06 Thread Chih-Wei Huang
2016-04-04 6:25 GMT+08:00 Rob Herring : > On Sun, Apr 3, 2016 at 12:29 PM, Chih-Wei Huang > wrote: >> Besides, the module name is still gralloc.drm. >> How about call it gralloc.gbm? > > Eventually yes, but for now it is more convenient for my

Re: [Mesa-dev] [PATCH 2/2] Differentiate between DeleteQueries and DeleteQueriesARB

2016-04-06 Thread Iago Toral
On Tue, 2016-04-05 at 14:27 +0300, kevin.rogo...@intel.com wrote: > From: Kevin Rogovin > > The extension, GL_ARB_occlusion_queries mandates that an > INVALID_OPERATION should be thrown if DeleteQueriesARB is > called while a query is active. In contrast, the GL spec >

[Mesa-dev] [Bug 94838] switch between drivers

2016-04-06 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=94838 Ilia Mirkin changed: What|Removed |Added Resolution|--- |NOTABUG

Re: [Mesa-dev] [PATCH 00/16] gallium: add support for NIR as alternate IR

2016-04-06 Thread Rob Clark
On Wed, Apr 6, 2016 at 8:34 AM, Emil Velikov wrote: > Hi Rob, > > If I'm reading the series correctly, NIR will only be used with vertex > and fragment shaders. Is there much left to make freedreno (vc4?) > "tgsi-free" ? Both driver side and state-tracer/nir ? Or you

Re: [Mesa-dev] [PATCH 00/16] gallium: add support for NIR as alternate IR

2016-04-06 Thread Emil Velikov
Hi Rob, If I'm reading the series correctly, NIR will only be used with vertex and fragment shaders. Is there much left to make freedreno (vc4?) "tgsi-free" ? Both driver side and state-tracer/nir ? Or you plan is to keep the TGSI code paths around just in case ? -Emil

Re: [Mesa-dev] Merging the Vulkan driver

2016-04-06 Thread Emil Velikov
Hi Jason, On 5 April 2016 at 20:30, Jason Ekstrand wrote: > All, > > We are getting very close to being able to merge the Vulkan driver into mesa > master. I've got around 30 patches on the mailing list that are still > awaiting review. Once those get merged, the diff

Re: [Mesa-dev] [PATCH v3] egl: add EGL_KHR_reusable_sync to egl_dri

2016-04-06 Thread Emil Velikov
On 5 April 2016 at 22:32, Dongwon Kim wrote: > Hi Emil, > > I don't think I still have a chance to update > this to version 4 since this has already been pushed > according to Marek... Indeed it is. Guess I was too slow on that one. > However, I will follow up your >

Re: [Mesa-dev] [PATCH V.2] Further Coccinelle inspired cleanups

2016-04-06 Thread Emil Velikov
Hi Edward, On 17 December 2015 at 03:41, Edward O'Callaghan wrote: > V.2 > * Fixup issue with MSVC needing a 'break;' on fall-though. > - > > The following patch series continues on what can be done with > Coccinelle to clean up Mesa3D house keeping duties. On a

Re: [Mesa-dev] [PATCH 5/8] main: rework the compatibility check of visuals in glXMakeCurrent

2016-04-06 Thread Marek Olšák
This looks good to me. I'll commit this on April 9th if there are other comments. Marek On Thu, Mar 24, 2016 at 1:12 AM, Miklós Máté wrote: > Now it follows the compatibility criteria listed in section 2.1 of > the GLX 1.4 specification. > This is needed for post-process

Re: [Mesa-dev] [PATCH 7/8] glx: fix the refcounting of dri drawables

2016-04-06 Thread Marek Olšák
This looks good to me. I'll commit this on April 9th if there are other comments. Marek On Thu, Mar 24, 2016 at 1:13 AM, Miklós Máté wrote: > This fixes premature deallocation on unbind, and introduces > support for deleting GLX drawables while they are current to a context. >

[Mesa-dev] [Bug 94838] switch between drivers

2016-04-06 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=94838 --- Comment #1 from martin.bacht...@gmail.com --- I mean for one specified application -- You are receiving this mail because: You are the assignee for the bug. You are the QA Contact for the bug.___

[Mesa-dev] [Bug 94838] switch between drivers

2016-04-06 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=94838 martin.bacht...@gmail.com changed: What|Removed |Added CC||martin.bacht...@gmail.com --

[Mesa-dev] [Bug 94838] switch between drivers

2016-04-06 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=94838 Bug ID: 94838 Summary: switch between drivers Product: Mesa Version: unspecified Hardware: x86-64 (AMD64) OS: Linux (All) Status: NEW Severity: normal

Re: [Mesa-dev] [PATCH 1/2] i965/fs: Add a flat_inputs field to prog_data

2016-04-06 Thread Samuel Iglesias Gonsálvez
On 06/04/16 09:47, Samuel Iglesias Gonsálvez wrote: > > > On 06/04/16 08:03, Samuel Iglesias Gonsálvez wrote: >> >> >> On 06/04/16 05:12, Jason Ekstrand wrote: >>> --- >>> src/mesa/drivers/dri/i965/brw_compiler.h | 6 ++ >>> src/mesa/drivers/dri/i965/brw_fs.cpp | 31 >>>

Re: [Mesa-dev] [PATCH 1/2] i965/fs: Add a flat_inputs field to prog_data

2016-04-06 Thread Samuel Iglesias Gonsálvez
On 06/04/16 08:03, Samuel Iglesias Gonsálvez wrote: > > > On 06/04/16 05:12, Jason Ekstrand wrote: >> --- >> src/mesa/drivers/dri/i965/brw_compiler.h | 6 ++ >> src/mesa/drivers/dri/i965/brw_fs.cpp | 31 >> +++ >> 2 files changed, 37 insertions(+) >> >>

Re: [Mesa-dev] [PATCH 2/2] i965/sf_state: Pull flat_enables out of prog_data

2016-04-06 Thread Samuel Iglesias Gonsálvez
Reviewed-by: Samuel Iglesias Gonsálvez On 06/04/16 05:12, Jason Ekstrand wrote: > Previously, we were walking over the shader source to figure out which > inputs should be marked flat. Now, we can just pull it out of prog_data. > This is needed for properly setting up

Re: [Mesa-dev] [PATCH 1/2] i965/fs: Add a flat_inputs field to prog_data

2016-04-06 Thread Samuel Iglesias Gonsálvez
On 06/04/16 05:12, Jason Ekstrand wrote: > --- > src/mesa/drivers/dri/i965/brw_compiler.h | 6 ++ > src/mesa/drivers/dri/i965/brw_fs.cpp | 31 +++ > 2 files changed, 37 insertions(+) > > diff --git a/src/mesa/drivers/dri/i965/brw_compiler.h >