[Mesa-dev] [PATCH 1/2] radv: drop the RADV_CALL macro.

2016-10-10 Thread Dave Airlie
From: Dave Airlie This is leftover from anv, and we really never needed it. Signed-off-by: Dave Airlie --- src/amd/vulkan/radv_meta_blit.c | 12 ++-- src/amd/vulkan/radv_meta_blit2d.c | 10 +- src/amd/vulkan/radv_meta_clear.c

[Mesa-dev] Fwd: [PATCH] radv: trivial case stmt style fixups

2016-10-10 Thread Thomas Helland
This patch is: Reviewed-by: Thomas Helland 2016-10-11 2:45 GMT+02:00 Edward O'Callaghan : > Relocate a 'default:' to the end of a case stmt and fix an > indent issue. > > Signed-off-by: Edward O'Callaghan >

[Mesa-dev] [Bug 98135] dEQP-GLES31.functional.debug.negative_coverage.get_error.shader.transform_feedback_varyings wants a different GL error code

2016-10-10 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=98135 Tapani Pälli changed: What|Removed |Added Resolution|--- |FIXED

Re: [Mesa-dev] [PATCH 2/2] [RFC] radv: add scratch support for spilling.

2016-10-10 Thread Dave Airlie
On 11 October 2016 at 12:13, Dave Airlie wrote: > On 11 October 2016 at 11:42, Dave Airlie wrote: >> On 11 October 2016 at 05:50, Dave Airlie wrote: >>> On 10 October 2016 at 21:45, Arsenault, Matthew >>>

[Mesa-dev] [PATCH] radv: check driver name before calling amdgpu.

2016-10-10 Thread Dave Airlie
From: Dave Airlie This checks the kernel driver name is amdgpu before calling libdrm_amdgpu. This avoids the following error: amdgpu_device_initialize: DRM version is 1.6.0 but this driver is only compatible with 3.x.x when run on a machine with i915 graphics as well as

Re: [Mesa-dev] [PATCH 00/15] GLSL memory allocation rework for faster compilation

2016-10-10 Thread Tapani Pälli
On 10/10/2016 02:52 PM, Marek Olšák wrote: I prefer some of my GLSL fixes in 1-4 over JP's changes, because they seem cleaner to me. Agreed, I was considering following patches from JP: https://patchwork.freedesktop.org/patch/93266/ https://patchwork.freedesktop.org/patch/93262/

Re: [Mesa-dev] [PATCH] trace: add invalidate_resource callback

2016-10-10 Thread Edward O'Callaghan
Reviewed-by: Edward O'Callaghan On 10/11/2016 02:17 PM, Ilia Mirkin wrote: > Signed-off-by: Ilia Mirkin > --- > src/gallium/drivers/trace/tr_context.c | 21 + > 1 file changed, 21 insertions(+) > > diff --git

[Mesa-dev] [PATCH] trace: add invalidate_resource callback

2016-10-10 Thread Ilia Mirkin
Signed-off-by: Ilia Mirkin --- src/gallium/drivers/trace/tr_context.c | 21 + 1 file changed, 21 insertions(+) diff --git a/src/gallium/drivers/trace/tr_context.c b/src/gallium/drivers/trace/tr_context.c index e833fb2..8423bb2 100644 ---

Re: [Mesa-dev] [PATCH 2/5] glsl: last duplicated layout-qualifier-name in multiple layout-qualifiers overrides the former

2016-10-10 Thread Timothy Arceri
Again the subject should say what the change is rather than making an assertion. How about: glsl: ignore all but the rightmost layout qualifier name from the rightmost layout qualifier On Fri, 2016-10-07 at 01:52 +0300, Andres Gomez wrote: > From page 46 (page 52 of the PDF) of the GLSL 4.20

Re: [Mesa-dev] [PATCH 1/5] glsl: last duplicated layout-qualifier-name in a layout-qualifier overrides the former

2016-10-10 Thread Timothy Arceri
The subject line should describe the change not make an assertion. How about:  glsl: ignore all but the rightmost layout-qualifier-name On Fri, 2016-10-07 at 01:52 +0300, Andres Gomez wrote: > In a declaration, when a layout qualifier appears and holds > duplicated > layout-qualifier-name, only

Re: [Mesa-dev] [PATCH 2/2] [RFC] radv: add scratch support for spilling.

2016-10-10 Thread Dave Airlie
On 11 October 2016 at 11:42, Dave Airlie wrote: > On 11 October 2016 at 05:50, Dave Airlie wrote: >> On 10 October 2016 at 21:45, Arsenault, Matthew >> wrote: >>> I don't like adding explicit IR arguments for ABI arguments,

[Mesa-dev] [PATCH v2 6/6] configure.ac: Add required LLVM versions to the top

2016-10-10 Thread Tobias Droste
Consolidate the required LLVM versions at the top where the other versions for dependencies are listed. Rework the LLVM_VERSION and LLVM_VERSION_INT calculation to make the format "x.y.z." possible. LLVM_VERSION_INT is now including LLVM_VERSION_PATCH. For the C define HAVE_LLVM is set now which

[Mesa-dev] [PATCH v2 5/6] configure.ac: Rework radeon_llvm_check

2016-10-10 Thread Tobias Droste
This makes radeon_llvm_checks use the new helper function, use the same ordering of arguments as llvm_check_version_for and adds the radv check to the Vulkan section. Signed-off-by: Tobias Droste --- configure.ac | 24 1 file changed, 12 insertions(+),

[Mesa-dev] [PATCH v2 1/6] configure.ac: Move LLVM related stuff to the top

2016-10-10 Thread Tobias Droste
This moves the LLVM related stuff to the top of the fileto make it available to all later checks. It's below the low level system checks without dependecies or heavy logic. WARNING: This just moves stuff, but breaks the build due to the new ordering!!! Signed-off-by: Tobias Droste

[Mesa-dev] [PATCH v2 0/6] configure.ac: LLVM changes

2016-10-10 Thread Tobias Droste
This series contains the changes split over 6 patches. Patches 1-5 should be squashed when pushed, because 1-4 break the build. I tested a build with llvmpipe, swr, radeonsi, r600 and radv. I also tested what happens when no LLVM is installed, version < required is installed, not all

[Mesa-dev] [PATCH v2 2/6] configure.ac: Add helper to add LLVM components/targets

2016-10-10 Thread Tobias Droste
This adds helper function to add components and/or targets anywhere i configure.ac. The first driver that calls "llvm_check_version_for()" adds the default components. This is done so that they only get added and checked for if there is a driver that actually needs them. WARNING: Still a broken

[Mesa-dev] [PATCH v2 3/6] configure.ac: Move LLVM oCL checks to the oCL section

2016-10-10 Thread Tobias Droste
This consolidates all openCL checks inside one "if test "x$enable_opencl" = xyes; then [...] fi" Uses new helper functions to add the LLVM components. WARNING: Still a broken build!!! Signed-off-by: Tobias Droste --- configure.ac | 39 +++ 1

[Mesa-dev] [PATCH v2 4/6] configure.ac: Move gallium LLVM to the gallium section

2016-10-10 Thread Tobias Droste
All gallium drivers that need LLVM have to call "gallium_require_llvm()". This runs the checks for "-.enable_gallium_llvm", the host_cpu checks and adds the "x86" target. "--enable-gallium-llvm" is only needed if at least one driver calls "gallium_require_llvm()". If the flag is set to auto it

Re: [Mesa-dev] [PATCH 2/2] [RFC] radv: add scratch support for spilling.

2016-10-10 Thread Dave Airlie
On 11 October 2016 at 05:50, Dave Airlie wrote: > On 10 October 2016 at 21:45, Arsenault, Matthew > wrote: >> I don't like adding explicit IR arguments for ABI arguments, especially this >> one. Adding a special case for the first index feels dirty.

Re: [Mesa-dev] [PATCH] i915g: fix incorrect gl_FragCoord value

2016-10-10 Thread Stéphane Marchesin
I pushed it. Thanks Nicholas. Stéphane On Thu, Sep 22, 2016 at 9:40 AM, Roland Scheidegger wrote: > Am 22.09.2016 um 17:40 schrieb Emil Velikov: > > Hi Nicholas, > > > > On 26 August 2016 at 00:31, Nicholas Bishop > wrote: > >> From: Nicholas Bishop

Re: [Mesa-dev] [PATCH] i965: solve cubemap negative x/y/z faces buffer offset issue in dEQP.

2016-10-10 Thread Jason Ekstrand
Reviewed-by: Jason Ekstrand On Sat, Oct 8, 2016 at 1:15 AM, Randy Xu wrote: > From: "Xu,Randy" > > Add the miptree level/slice x/y_offset when count the surface offset > in brw_emit_surface_state. The surface offset has two parts,

[Mesa-dev] [PATCH] i965: solve cubemap negative x/y/z faces buffer offset issue in dEQP.

2016-10-10 Thread Randy Xu
From: "Xu,Randy" Add the miptree level/slice x/y_offset when count the surface offset in brw_emit_surface_state. The surface offset has two parts, one is from mt->offset, which should be 32 aligned in width/height for tiled buffer; another is from

Re: [Mesa-dev] [PATCH 1/3] i965: solve cubemap negative x/y/z faces buffer offset issue in dEQP.

2016-10-10 Thread Xu, Randy
Thanks, Jason I did more test and submitted the patch version 2 with the assertion added, please review it. Thanks, Randy From: Jason Ekstrand [mailto:ja...@jlekstrand.net] Sent: Friday, October 7, 2016 12:38 AM To: Xu, Randy Cc: Palli, Tapani ;

[Mesa-dev] New to X.org

2016-10-10 Thread Umesh Singla
Hi I'm Umesh, presently in my third year at IIIT Hyderabad. I'm not very new to open source community but haven't contributed much before due to time constraints. I recently came to know about EVoC initiative by X.org. So, I went ahead and had a look on the projects. The janitor looks a good way

Re: [Mesa-dev] [PATCH 2/2] [RFC] radv: add scratch support for spilling.

2016-10-10 Thread Arsenault, Matthew
I don't like adding explicit IR arguments for ABI arguments, especially this one. Adding a special case for the first index feels dirty. The rest of llvm also won't be aware of the specialness of the argument. It would be problematic because bugpoint would eliminate the unused argument and then

Re: [Mesa-dev] [PATCH 16/22] anv/hiz: Perform HiZ resolves for all partial renders

2016-10-10 Thread Jason Ekstrand
On Mon, Oct 10, 2016 at 2:23 PM, Nanley Chery wrote: > On Fri, Oct 07, 2016 at 09:41:14PM -0700, Jason Ekstrand wrote: > > If we don't, we can end up with corruption in the portion of the depth > > buffer that lies outside the render area when we do a HiZ resolve at the >

Re: [Mesa-dev] [PATCH] tgsi: fix parsing nan float inputs

2016-10-10 Thread Roland Scheidegger
Am 10.10.2016 um 23:57 schrieb Roland Mainz: > On Mon, Oct 10, 2016 at 11:40 PM, Ilia Mirkin wrote: >> On Mon, Oct 10, 2016 at 5:36 PM, Roland Mainz >> wrote: >>> On Mon, Oct 10, 2016 at 6:12 PM, Ilia Mirkin wrote:

[Mesa-dev] [PATCH] radv: trivial case stmt style fixups

2016-10-10 Thread Edward O'Callaghan
Relocate a 'default:' to the end of a case stmt and fix an indent issue. Signed-off-by: Edward O'Callaghan --- src/amd/vulkan/radv_image.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/amd/vulkan/radv_image.c

Re: [Mesa-dev] [PATCH v2 00/13] st/mesa: finally finish ARB_enhanced_layouts

2016-10-10 Thread Edward O'Callaghan
So with Dave's suggestion on patch 4 patches 1-9 and 11-13 are, Reviewed-by: Edward O'Callaghan I could not get my head around the full implications of patch 10 but seems fine so just, Acked-by: Edward O'Callaghan Kind Regards, Edward.

Re: [Mesa-dev] [PATCH 2/5] anv/cmd_buffer: Delay variable assignment in HZ function

2016-10-10 Thread Nanley Chery
On Mon, Oct 10, 2016 at 04:01:29PM -0700, Jason Ekstrand wrote: > My patch to fix partial draws makes us use full_surface_op for HiZ resolves > as well so this patch (and maybe the next one?) are probably moot. > I realize that this patch conflicts with yours, but in my reply to that patch, I

[Mesa-dev] [PATCH v5 10/10] i965: use nir loop unrolling pass

2016-10-10 Thread Timothy Arceri
V2: - enable on all gens --- src/compiler/glsl/glsl_parser_extras.cpp | 12 +++- src/mesa/drivers/dri/i965/brw_compiler.c | 5 - src/mesa/drivers/dri/i965/brw_nir.c | 22 +- 3 files changed, 28 insertions(+), 11 deletions(-) diff --git

[Mesa-dev] [PATCH v5 9/10] nir: pass compiler rather than devinfo to functions that call nir_optimize

2016-10-10 Thread Timothy Arceri
Later we will pass compiler to nir_optimise to be used by the loop unroll pass. --- src/mesa/drivers/dri/i965/brw_fs.cpp | 10 -- src/mesa/drivers/dri/i965/brw_nir.c | 7 --- src/mesa/drivers/dri/i965/brw_nir.h | 4 ++--

[Mesa-dev] [PATCH v5 8/10] nir: add a loop unrolling pass

2016-10-10 Thread Timothy Arceri
V2: - tidy ups suggested by Connor. - tidy up cloning logic and handle copy propagation based of suggestion by Connor. - use nir_ssa_def_rewrite_uses to fix up lcssa phis suggested by Connor. - add support for complex loop unrolling (two terminators) - handle case were the ssa defs use outside

Re: [Mesa-dev] [PATCH 2/5] anv/cmd_buffer: Delay variable assignment in HZ function

2016-10-10 Thread Jason Ekstrand
My patch to fix partial draws makes us use full_surface_op for HiZ resolves as well so this patch (and maybe the next one?) are probably moot. On Oct 10, 2016 3:33 PM, "Nanley Chery" wrote: > Delay the assignment of some variables until we know they will be used. > >

Re: [Mesa-dev] V5 Loop unrolling in NIR

2016-10-10 Thread Timothy Arceri
I forgot to add that Jenkins is saying the following piglit test is fixed by this series in IVY and HSW. I assume this is due to patch 2 piglit.spec.arb_tessellation_shader.execution.variable-indexing.tes- both-input-array-vec4-index-rd On Tue, 2016-10-11 at 09:38 +1100, Timothy Arceri wrote: >

Re: [Mesa-dev] [PATCH] radeonsi: emit TA_CS_BC_BASE_ADDR on SI only if the kernel allows it

2016-10-10 Thread Edward O'Callaghan
Nice catch. Reviewed-by: Edward O'Callaghan On 10/10/2016 10:25 PM, Marek Olšák wrote: > From: Marek Olšák > > The kernel patch has been sent to amd-gfx. > --- > src/gallium/drivers/radeonsi/si_compute.c | 7 ++- > 1 file changed, 6

[Mesa-dev] [Bug 96770] include/GL/mesa_glinterop.h:62: error: redefinition of typedef ‘GLXContext’

2016-10-10 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=96770 Vinson Lee changed: What|Removed |Added Resolution|--- |FIXED

[Mesa-dev] [PATCH v5 07/10] nir: add helper for cloning nir_cf_list

2016-10-10 Thread Timothy Arceri
V2: - updated to create a generic list clone helper nir_cf_list_clone() - continue to assert on clone when fallback flag not set as suggested by Jason. --- src/compiler/nir/nir_clone.c| 58 +++-- src/compiler/nir/nir_control_flow.h | 3 ++ 2 files

[Mesa-dev] [PATCH v5 04/10] nir: Add a LCSAA-pass

2016-10-10 Thread Timothy Arceri
From: Thomas Helland V2: Do a "depth first search" to convert to LCSSA V3: Small comment fixup V4: Rebase, adapt to removal of function overloads V5: Rebase, adapt to relocation of nir to compiler/nir Still need to adapt to potential if-uses Work around

[Mesa-dev] [PATCH v5 06/10] nir: create helper for fixing phi srcs when cloning

2016-10-10 Thread Timothy Arceri
This will be useful for fixing phi srcs when cloning a loop body during loop unrolling. --- src/compiler/nir/nir_clone.c | 36 +--- 1 file changed, 21 insertions(+), 15 deletions(-) diff --git a/src/compiler/nir/nir_clone.c b/src/compiler/nir/nir_clone.c index

[Mesa-dev] [PATCH v5 02/10] i965: use nir_lower_indirect_derefs() for GLSL

2016-10-10 Thread Timothy Arceri
This moves the nir_lower_indirect_derefs() call into brw_preprocess_nir() so thats is called by both OpenGL and Vulkan and removes that call to the old GLSL IR pass lower_variable_index_to_cond_assign() We want to do this pass in nir to be able to move loop unrolling to nir. There is a increase

[Mesa-dev] [PATCH v5 01/10] i965: allow sampler indirects on all gens

2016-10-10 Thread Timothy Arceri
Without this we will regress the max-samplers piglit test on Gen6 and lower when loop unrolling is done in NIR. There is a check in the GLSL IR linker that errors when it finds indirects and EmitNoIndirectSampler is set. As far as I can tell there is no reason for not enabling this for all gens

[Mesa-dev] V5 Loop unrolling in NIR

2016-10-10 Thread Timothy Arceri
Again thanks to Jason and Connor for their feedback, and to Thomas for getting this work started. V5: Has been updated to reflect Jasons feedback and also some changes from self review after not looking at this for a few weeks. total instructions in shared programs: 8530600 -> 8530365 (-0.00%)

[Mesa-dev] [PATCH v5 05/10] nir: don't count removal of lcssa_phi as progress

2016-10-10 Thread Timothy Arceri
--- src/compiler/nir/nir_opt_remove_phis.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/compiler/nir/nir_opt_remove_phis.c b/src/compiler/nir/nir_opt_remove_phis.c index acaa6e1..d4344b0 100644 --- a/src/compiler/nir/nir_opt_remove_phis.c +++

[Mesa-dev] [PATCH v5 03/10] nir: Add a loop analysis pass

2016-10-10 Thread Timothy Arceri
From: Thomas Helland This pass detects induction variables and calculates the trip count of loops to be used for loop unrolling. I've removed support for float induction values for now, for the simple reason that they don't appear in my shader-db collection, and so I

[Mesa-dev] [PATCH 4/5] anv/cmd_buffer: Manage Anv state around HZ op emission

2016-10-10 Thread Nanley Chery
Move the assignment to a less surprising location. Signed-off-by: Nanley Chery --- src/intel/vulkan/gen8_cmd_buffer.c | 16 +--- 1 file changed, 9 insertions(+), 7 deletions(-) diff --git a/src/intel/vulkan/gen8_cmd_buffer.c

[Mesa-dev] [PATCH 5/5] anv/cmd_buffer: Enable stencil-only HZ clears

2016-10-10 Thread Nanley Chery
The HZ sequence modifies less state than the meta path and requires less CPU time to be generated. Signed-off-by: Nanley Chery --- src/intel/vulkan/gen8_cmd_buffer.c | 63 ++ 1 file changed, 43 insertions(+), 20 deletions(-) diff

[Mesa-dev] [PATCH 2/5] anv/cmd_buffer: Delay variable assignment in HZ function

2016-10-10 Thread Nanley Chery
Delay the assignment of some variables until we know they will be used. Signed-off-by: Nanley Chery --- src/intel/vulkan/gen8_cmd_buffer.c | 32 +--- 1 file changed, 17 insertions(+), 15 deletions(-) diff --git

[Mesa-dev] [PATCH 3/5] anv/cmd_buffer: Rename full_surface_op to full_surf_clear

2016-10-10 Thread Nanley Chery
This matches the HW docs and specifies what the variable is actually concerned with. Signed-off-by: Nanley Chery --- src/intel/vulkan/gen8_cmd_buffer.c | 13 ++--- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/src/intel/vulkan/gen8_cmd_buffer.c

[Mesa-dev] [PATCH 1/5] anv/cmd_buffer: Clarify HZ rectangle behavior

2016-10-10 Thread Nanley Chery
This behavior differs from what's described in the PRMs and was observed by analyzing CTS test results. Signed-off-by: Nanley Chery --- src/intel/vulkan/gen8_cmd_buffer.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git

Re: [Mesa-dev] [PATCH] android: intel/genxml: add rules to generate xml headers

2016-10-10 Thread Mauro Rossi
2016-10-10 13:04 GMT+02:00 Emil Velikov : > Hi Mauro, > > On 9 October 2016 at 11:13, Mauro Rossi wrote: > >> New generated headers were introduced by commit 63a366a >> "intel: aubinator: generate a standalone binary" >> >> Once the generated files

Re: [Mesa-dev] [PATCH] tgsi: fix parsing nan float inputs

2016-10-10 Thread Roland Mainz
On Mon, Oct 10, 2016 at 11:40 PM, Ilia Mirkin wrote: > On Mon, Oct 10, 2016 at 5:36 PM, Roland Mainz > wrote: >> On Mon, Oct 10, 2016 at 6:12 PM, Ilia Mirkin wrote: >>> Signed-off-by: Ilia Mirkin >>>

Re: [Mesa-dev] [PATCH 1/3] gallium/os: Fix overflow on 32 bits

2016-10-10 Thread Axel Davy
On 10/10/2016 12:44, Emil Velikov wrote: On 6 October 2016 at 18:51, Axel Davy wrote: On systems with more than 4GB of ram, os_get_total_physical_memory was triggering an integer overflow for the linux and haiku path, when on 32 bits. Bugzilla:

Re: [Mesa-dev] [PATCH] tgsi: fix parsing nan float inputs

2016-10-10 Thread Ilia Mirkin
On Mon, Oct 10, 2016 at 5:36 PM, Roland Mainz wrote: > On Mon, Oct 10, 2016 at 6:12 PM, Ilia Mirkin wrote: >> Signed-off-by: Ilia Mirkin >> --- >> src/gallium/auxiliary/tgsi/tgsi_text.c | 7 ++- >> 1 file changed, 6

Re: [Mesa-dev] [PATCH] tgsi: fix parsing nan float inputs

2016-10-10 Thread Roland Mainz
On Mon, Oct 10, 2016 at 6:12 PM, Ilia Mirkin wrote: > Signed-off-by: Ilia Mirkin > --- > src/gallium/auxiliary/tgsi/tgsi_text.c | 7 ++- > 1 file changed, 6 insertions(+), 1 deletion(-) > > diff --git a/src/gallium/auxiliary/tgsi/tgsi_text.c >

[Mesa-dev] [PATCH v2] mesa/extensions: expose OES_vertex_half_float for ES2

2016-10-10 Thread Kevin Strasser
Half float support already exists for desktop GL. Reuse the ARB_half_float_vertex enable bit and account for the different enum to enable the extension for ES2. Signed-off-by: Kevin Strasser Reviewed-by: Kenneth Graunke ---

Re: [Mesa-dev] [PATCH 16/22] anv/hiz: Perform HiZ resolves for all partial renders

2016-10-10 Thread Nanley Chery
On Fri, Oct 07, 2016 at 09:41:14PM -0700, Jason Ekstrand wrote: > If we don't, we can end up with corruption in the portion of the depth > buffer that lies outside the render area when we do a HiZ resolve at the > end. The only reason we weren't seeing this before was that all of the > meta-based

Re: [Mesa-dev] [PATCH] tgsi: fix parsing nan float inputs

2016-10-10 Thread Ilia Mirkin
On Mon, Oct 10, 2016 at 3:59 PM, Dave Airlie wrote: > On 11 October 2016 at 02:12, Ilia Mirkin wrote: >> Signed-off-by: Ilia Mirkin >> --- >> src/gallium/auxiliary/tgsi/tgsi_text.c | 7 ++- >> 1 file changed, 6 insertions(+), 1

Re: [Mesa-dev] [PATCH 2/2] radv/winsys: Fix radv_amdgpu_cs_grow min_size argument. (v2)

2016-10-10 Thread Gustaw Smolarczyk
2016-10-10 22:04 GMT+02:00 Bas Nieuwenhuizen : > Hi Gustaw, > > The patch is > reviewed-by: Bas Nieuwenhuizen Thanks, please push it since I don't have commit access. > > What needs to be done too, is checking if the resulting IB becomes too >

Re: [Mesa-dev] [PATCH v2 04/13] tgsi/ureg: add ureg_DECL_output_layout

2016-10-10 Thread Dave Airlie
On 10 October 2016 at 18:32, Nicolai Hähnle wrote: > From: Nicolai Hähnle > > For specifying an exact location/component. Any reason you have the args ordering different, that seems like it might get confusing. I'd prefer you kept the output_layout

Re: [Mesa-dev] [PATCH 2/2] radv/winsys: Fix radv_amdgpu_cs_grow min_size argument. (v2)

2016-10-10 Thread Bas Nieuwenhuizen
Hi Gustaw, The patch is reviewed-by: Bas Nieuwenhuizen What needs to be done too, is checking if the resulting IB becomes too large in the SI case, and handling that gracefully. I don't care if that happens with this patch, or if someone writes a follow up patch though

Re: [Mesa-dev] [PATCH] tgsi: fix parsing nan float inputs

2016-10-10 Thread Dave Airlie
On 11 October 2016 at 02:12, Ilia Mirkin wrote: > Signed-off-by: Ilia Mirkin > --- > src/gallium/auxiliary/tgsi/tgsi_text.c | 7 ++- > 1 file changed, 6 insertions(+), 1 deletion(-) Is this a problem you've seen somewhere, it's why in virgl I

Re: [Mesa-dev] [PATCH 2/2] [RFC] radv: add scratch support for spilling.

2016-10-10 Thread Dave Airlie
On 10 October 2016 at 21:45, Arsenault, Matthew wrote: > I don't like adding explicit IR arguments for ABI arguments, especially this > one. Adding a special case for the first index feels dirty. The rest of llvm > also won't be aware of the specialness of the argument.

Re: [Mesa-dev] [RFC 00/12] egl, i965: Support EGL_ANDROID_native_fence_sync (v2)

2016-10-10 Thread Rob Clark
On Mon, Oct 10, 2016 at 1:43 PM, Chad Versace wrote: > Background: > > This extension is needed by Android (via ARC++) on Chrome OS. > Essentially, this extension provides a translation between EGLSync and > explicit cross-process synchronization points,

Re: [Mesa-dev] [PATCH] nvc0: fix valid range for shader buffers

2016-10-10 Thread Ilia Mirkin
Reviewed-by: Ilia Mirkin On Sun, Oct 9, 2016 at 4:17 PM, Samuel Pitoiset wrote: > When offset != 0, the valid range was wrong because the second > argument of util_range_add() is end, not size. > > Signed-off-by: Samuel Pitoiset

Re: [Mesa-dev] [PATCH] radeonsi: emit TA_CS_BC_BASE_ADDR on SI only if the kernel allows it

2016-10-10 Thread Alex Deucher
On Mon, Oct 10, 2016 at 7:25 AM, Marek Olšák wrote: > From: Marek Olšák > > The kernel patch has been sent to amd-gfx. Reviewed-by: Alex Deucher > --- > src/gallium/drivers/radeonsi/si_compute.c | 7 ++- > 1 file changed,

Re: [Mesa-dev] [PATCH] radeonsi: emit TA_CS_BC_BASE_ADDR on SI only if the kernel allows it

2016-10-10 Thread Edmondo Tommasina
Reviewed-by: Edmondo Tommasina On Mon, Oct 10, 2016 at 1:25 PM, Marek Olšák wrote: > From: Marek Olšák > > The kernel patch has been sent to amd-gfx. > --- > src/gallium/drivers/radeonsi/si_compute.c | 7 ++- > 1 file

[Mesa-dev] [Bug 77449] Tracker bug for all bugs related to Steam titles

2016-10-10 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=77449 cokochiaki changed: What|Removed |Added CC|ern...@gmail.com| -- You are

[Mesa-dev] [Bug 77449] Tracker bug for all bugs related to Steam titles

2016-10-10 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=77449 cokochiaki changed: What|Removed |Added CC||mayoc...@icloud.com

[Mesa-dev] [Bug 77449] Tracker bug for all bugs related to Steam titles

2016-10-10 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=77449 cokochiaki changed: What|Removed |Added CC|lem...@gmail.com, |

[Mesa-dev] [Bug 97250] Mesa/Clover: openCV library bugs on CL_MEM_USE_HOST_PTR

2016-10-10 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=97250 cokochiaki changed: What|Removed |Added CC||mayoc...@icloud.com

[Mesa-dev] [RFC 11/12] i965/sync: Rename brw_fence_insert()

2016-10-10 Thread Chad Versace
Rename to brw_fence_insert_locked(). This is correct because the fence's mutex is effectively locked, as all callers are also *creators* of the fence, and have not yet returned the new fence. This reduces noise in the next patch, which defines and uses brw_fence_insert(), an unlocked variant. ---

[Mesa-dev] [RFC 12/12] i965/sync: Implement fences based on Linux sync_file

2016-10-10 Thread Chad Versace
This patch implements a new type of struct brw_fence, one that is based struct sync_file. This completes support for EGL_ANDROID_native_fence_sync. * Background Linux 4.7 added a new file type, struct sync_file. See commit 460bfc41fd52959311ed0328163f785e023857af Author: Gustavo

[Mesa-dev] [RFC 10/12] i965/sync: Fail sync creation with batchbuffer flush fails

2016-10-10 Thread Chad Versace
Pre-patch, brw_sync.c ignored the return value of intel_batchbuffer_flush(). When intel_batchbuffer_flush() fails during eglCreateSync (brw_dri_create_fence), we now give up, cleanup, and return NULL. When it fails during glFenceSync, however, we blindly continue and hope for the best because

[Mesa-dev] [RFC 06/12] squash! egl: add EGL_ANDROID_native_fence_sync

2016-10-10 Thread Chad Versace
From: Chad Versace Close the sync fd *after* the sync's refcount drops to 0. --- src/egl/drivers/dri2/egl_dri2.c | 14 ++ 1 file changed, 10 insertions(+), 4 deletions(-) diff --git a/src/egl/drivers/dri2/egl_dri2.c b/src/egl/drivers/dri2/egl_dri2.c index

[Mesa-dev] [RFC 07/12] i965: Add intel_screen::has_fence_fd

2016-10-10 Thread Chad Versace
From: Chad Versace This bool maps to I915_PARAM_HAS_EXEC_FENCE_FD. TODO: The i915 param is not yet upstream. Wait for the kernel interface before committing. --- src/mesa/drivers/dri/i965/intel_screen.c | 3 +++ src/mesa/drivers/dri/i965/intel_screen.h | 2 +- 2

[Mesa-dev] [RFC 09/12] i965/sync: Add brw_fence::type

2016-10-10 Thread Chad Versace
This a refactor patch; no expected changed in behavior. Add `enum brw_fence_type` and brw_fence::type. There is only one type currently, BRW_FENCE_TYPE_BO_WAIT. This patch reduces a lot of noise in the next, which adds new type BRW_FENCE_TYPE_SYNC_FD. --- src/mesa/drivers/dri/i965/brw_sync.c |

[Mesa-dev] [RFC 04/12] squash! egl: add EGL_ANDROID_native_fence_sync

2016-10-10 Thread Chad Versace
Add EGL_KHR_debug tracing to eglDupNativeFenceFDANDROID, because all EGL entrypoints support tracing now. --- src/egl/main/eglapi.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/egl/main/eglapi.c b/src/egl/main/eglapi.c index 3c0b017..449a2be 100644 --- a/src/egl/main/eglapi.c +++

[Mesa-dev] [RFC 08/12] i965: Add intel_batchbuffer_flush_fence()

2016-10-10 Thread Chad Versace
From: Chad Versace A variant of intel_batchbuffer_flush() with parameters for in and out fence fds. --- src/mesa/drivers/dri/i965/intel_batchbuffer.c | 25 +++-- src/mesa/drivers/dri/i965/intel_batchbuffer.h | 14 -- 2 files changed, 27

[Mesa-dev] [RFC 05/12] squash! egl: add EGL_ANDROID_native_fence_sync

2016-10-10 Thread Chad Versace
From: Chad Versace Don't set SyncCondition twice. --- src/egl/main/eglsync.c | 1 - 1 file changed, 1 deletion(-) diff --git a/src/egl/main/eglsync.c b/src/egl/main/eglsync.c index ccfa474..b1b8c43 100644 --- a/src/egl/main/eglsync.c +++ b/src/egl/main/eglsync.c @@

[Mesa-dev] [RFC 02/12] dri: extend fence extension to support native fd fences

2016-10-10 Thread Chad Versace
From: Rob Clark Required to implement EGL_ANDROID_native_fence_sync. Signed-off-by: Rob Clark --- include/GL/internal/dri_interface.h | 44 - 1 file changed, 43 insertions(+), 1 deletion(-) diff --git

[Mesa-dev] [RFC 03/12] egl: add EGL_ANDROID_native_fence_sync

2016-10-10 Thread Chad Versace
From: Rob Clark [chadv]: Resolve rebase conflicts. Signed-off-by: Rob Clark --- src/egl/drivers/dri2/egl_dri2.c | 49 + src/egl/main/eglapi.c | 36 +++---

[Mesa-dev] [RFC 00/12] egl, i965: Support EGL_ANDROID_native_fence_sync (v2)

2016-10-10 Thread Chad Versace
Background: This extension is needed by Android (via ARC++) on Chrome OS. Essentially, this extension provides a translation between EGLSync and explicit cross-process synchronization points, represented as "sync fds". The relevant documentation is: [1]:

[Mesa-dev] [RFC 01/12] egl: initialize SyncCondition after attr parsing

2016-10-10 Thread Chad Versace
From: Rob Clark Reduce the noise in the next patch. For EGL_SYNC_NATIVE_FENCE_ANDROID the sync condition is conditional on EGL_SYNC_NATIVE_FENCE_FD_ANDROID attribute. Signed-off-by: Rob Clark --- src/egl/main/eglsync.c | 8 1 file

Re: [Mesa-dev] [PATCH] configure.ac: Rework LLVM dependency handling

2016-10-10 Thread Tobias Droste
Hi Emil, comments below. Am Montag, 10. Oktober 2016, 13:36:15 CEST schrieben Sie: > Hi Tobias, > > On 8 October 2016 at 16:55, Tobias Droste wrote: > > After this change each driver can request LLVM with a specific version > > and specific targets/components anywhere. > > > >

Re: [Mesa-dev] [PATCH 10/22] intel/blorp: Add an entrypoint for clearing depth and stencil

2016-10-10 Thread Jason Ekstrand
Topi, There are some patches in this branch: https://cgit.freedesktop.org/~jekstrand/mesa/log/?h=wip/i965-blorp-ds That I intend to send or squash in as part of a v2. Feel free to look at them and/or review preemptively. --Jason On Sun, Oct 9, 2016 at 11:00 PM, Pohjolainen, Topi <

Re: [Mesa-dev] [PATCH] intel: Fix bash-specific redirection.

2016-10-10 Thread Emil Velikov
On 10 October 2016 at 17:19, Eric Anholt wrote: > --- > > I went to test-build my previous bash fix, and another area got broken > in the meantime. > > src/intel/Makefile.genxml.am | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git

Re: [Mesa-dev] [PATCH] intel: Fix bash-specific redirection.

2016-10-10 Thread Chad Versace
On Mon 10 Oct 2016, Eric Anholt wrote: > --- > > I went to test-build my previous bash fix, and another area got broken > in the meantime. > > src/intel/Makefile.genxml.am | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/intel/Makefile.genxml.am

[Mesa-dev] [PATCH mesa v2] egl: add eglSwapBuffersWithDamageKHR

2016-10-10 Thread Eric Engestrom
EGL_KHR_swap_buffers_with_damage is actually already supported, as it is technically nothing but a rename of EGL_EXT_swap_buffers_with_damage. To that effect, both extension are advertised depending on the same condition, and the new entrypoint simply redirects to the previous one.

Re: [Mesa-dev] [PATCH mesa] egl: add eglSwapBuffersWithDamageKHR

2016-10-10 Thread Eric Engestrom
On Mon, Oct 10, 2016 at 04:57:01PM +0100, Emil Velikov wrote: > On 10 October 2016 at 15:37, Eric Engestrom wrote: > > >> > +static EGLBoolean EGLAPIENTRY > >> > +eglSwapBuffersWithDamageKHR(EGLDisplay dpy, EGLSurface surface, > >> > +EGLint

Re: [Mesa-dev] [PATCH] nvc0/ir: fix overwriting of value backing non-constant gather offset

2016-10-10 Thread Samuel Pitoiset
Confirmed. Reviewed-by: Samuel Pitoiset On 10/10/2016 06:12 PM, Ilia Mirkin wrote: Normally the value is an immediate, which is moved to some temporary, so there's no problem. In the case of a non-constant offset (as allowed by ARB_gpu_shader5), we have to take care

Re: [Mesa-dev] [PATCH] intel: Fix bash-specific redirection.

2016-10-10 Thread Lionel Landwerlin
Thanks, I think that explains a problem I have in another patch. Reviewed-by: Lionel Landwerlin On 10/10/16 17:19, Eric Anholt wrote: --- I went to test-build my previous bash fix, and another area got broken in the meantime. src/intel/Makefile.genxml.am | 2

[Mesa-dev] [PATCH] intel: Fix bash-specific redirection.

2016-10-10 Thread Eric Anholt
--- I went to test-build my previous bash fix, and another area got broken in the meantime. src/intel/Makefile.genxml.am | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/intel/Makefile.genxml.am b/src/intel/Makefile.genxml.am index 8d7d40266383..160a41151795 100644 ---

[Mesa-dev] [PATCH] tgsi: fix parsing nan float inputs

2016-10-10 Thread Ilia Mirkin
Signed-off-by: Ilia Mirkin --- src/gallium/auxiliary/tgsi/tgsi_text.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/gallium/auxiliary/tgsi/tgsi_text.c b/src/gallium/auxiliary/tgsi/tgsi_text.c index be80842..36dc979 100644 ---

[Mesa-dev] [PATCH] nvc0/ir: fix overwriting of value backing non-constant gather offset

2016-10-10 Thread Ilia Mirkin
Normally the value is an immediate, which is moved to some temporary, so there's no problem. In the case of a non-constant offset (as allowed by ARB_gpu_shader5), we have to take care to copy it first before using it to build up the bits. This fixes a compilation error observed in F1 2015.

[Mesa-dev] [Bug 98169] lm_sensors hud option crashes unigine heaven

2016-10-10 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=98169 --- Comment #4 from Christoph Haag --- Only thing I can think of is that you may need LIBGL_DRIVERS_PATH. Try LIBGL_DRIVERS_PATH=$PWD/root/lib/xorg/modules/dri/ or something like that. also LIBGL_DEBUG=verbose to check

Re: [Mesa-dev] [PATCH mesa] egl: add eglSwapBuffersWithDamageKHR

2016-10-10 Thread Emil Velikov
On 10 October 2016 at 15:37, Eric Engestrom wrote: >> > +static EGLBoolean EGLAPIENTRY >> > +eglSwapBuffersWithDamageKHR(EGLDisplay dpy, EGLSurface surface, >> > +EGLint *rects, EGLint n_rects) >> > +{ >> > + return

[Mesa-dev] [Bug 98169] lm_sensors hud option crashes unigine heaven

2016-10-10 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=98169 --- Comment #3 from Steven Toth --- I'm not familiar with Unigine and I'm having issues trying to get it to run with mesa tip. Your feedback is welcome. Testing with a Heaven-Unigine 4.0 binary downloaded today.

[Mesa-dev] [Bug 98169] lm_sensors hud option crashes unigine heaven

2016-10-10 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=98169 --- Comment #2 from Steven Toth --- Tests OK on glxgears, glxdemo and glxheads, on my platform (x86_64 Ubuntu 16.04), with NVIDIA GTX 950. I'll look at installing unigine. -- You are receiving this mail because: You are

Re: [Mesa-dev] [PATCH mesa] egl: add eglSwapBuffersWithDamageKHR

2016-10-10 Thread Eric Engestrom
On Mon, Oct 10, 2016 at 01:07:57PM +0100, Emil Velikov wrote: > Hi Eric, > > On 4 October 2016 at 10:30, Eric Engestrom wrote: > > EGL_KHR_swap_buffers_with_damage is actually already supported, as it is > > technically nothing but a rename of

  1   2   >