Re: [Mesa-dev] [RFC] mesa: drop current draw/read buffer when ctx is released

On 11/04/2016 05:37 PM, Rob Clark wrote: On Fri, Nov 4, 2016 at 11:31 AM, Emil Velikov wrote: On 1 November 2016 at 22:05, Rob Clark wrote: On Tue, Nov 1, 2016 at 5:42 PM, Mauro Rossi wrote: Mauro or Chih-Wei should be

[Mesa-dev] [PATCH 2/2] i965: Advertise 8 subpixel bits always.

The mesa default is 4, but we program the hardware for 8 on all generations. Signed-off-by: Chris Forbes --- src/mesa/drivers/dri/i965/brw_context.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/mesa/drivers/dri/i965/brw_context.c

[Mesa-dev] [PATCH 1/2] mesa: Remove EXTRA_EXT declaration for ARB_viewport_array

Now that we also have to consider OES_viewport_array & friends, nothing uses this. Signed-off-by: Chris Forbes --- src/mesa/main/get.c | 1 - 1 file changed, 1 deletion(-) diff --git a/src/mesa/main/get.c b/src/mesa/main/get.c index 5f5e76a..854f8ab 100644 ---

[Mesa-dev] [Bug 98512] radeon r600 vdpau: Invalid command stream: texture bo too small

https://bugs.freedesktop.org/show_bug.cgi?id=98512 --- Comment #14 from jcamp --- (In reply to Nicolai Hähnle from comment #13) > I think I understand the problem. > https://patchwork.freedesktop.org/patch/119855/ fixes the issue for me, > could you please check that it

[Mesa-dev] [Bug 98604] [VDPAU, DRI3] Fullscreen flash video fails when hardware acceleration is enabled.

https://bugs.freedesktop.org/show_bug.cgi?id=98604 --- Comment #7 from Dieter Nützel --- (In reply to Chris Rankin from comment #1) > I think this bug is related to DRI3, because this change "fixes" the problem: > > diff --git a/src/gallium/state_trackers/vdpau/device.c >

Re: [Mesa-dev] [PATCH 7/7] nvc0: add support for PIPE_CAP_SURFACE_REINTERPRET_BLOCKS

Can you describe what this is doing? I'm confused. And I'm not sure if the thing you're doing with blocks is the right thing either... On Tue, Oct 25, 2016 at 3:41 PM, Samuel Pitoiset wrote: > Loosely based on radeonsi, thanks Nicolai! > > Signed-off-by: Samuel

Re: [Mesa-dev] [PATCH 3/7] nvc0: simplify draw parameters upload for vertex shaders

On Tue, Oct 25, 2016 at 3:41 PM, Samuel Pitoiset wrote: > Signed-off-by: Samuel Pitoiset > --- > src/gallium/drivers/nouveau/nvc0/nvc0_vbo.c | 14 ++ > 1 file changed, 6 insertions(+), 8 deletions(-) > > diff --git

Re: [Mesa-dev] [PATCH 2/7] nvc0: only update primitive restart for indexed draws

Primitive restart is a thing for non-indexed draws too. There's a method that controls it - NVC0_3D_PRIM_RESTART_WITH_DRAW_ARRAYS. The more recently GL 4.5 behaviour is to *not* do primitive restart for draw arrays, however the older behavior is to do it. I don't think there's clear direction on

Re: [Mesa-dev] [PATCH 1/7] nvc0: reduce the number of PUSH_SPACE in draw path

On Wed, Oct 26, 2016 at 4:14 AM, Samuel Pitoiset wrote: > > > On 10/25/2016 09:49 PM, Ilia Mirkin wrote: >> >> What if instance_count = 1M? (It can happen.) > > > We allocate a giant space in the pushbuf in one shot. Well, anyways this is > not the optimization of the

Re: [Mesa-dev] [PATCH 3/3] nvc0: refactor textures/samplers validation

Patches 1-2 seem OK. I'm a little concerned that this one is changing functionality, since it's removing the "need_flush" thing. It'd be nice if you could get this patch some heavier testing before pushing it out... On Wed, Oct 26, 2016 at 4:00 PM, Samuel Pitoiset

Re: [Mesa-dev] [PATCH 4/4] i965: Fix alpha-to-coverage and alpha test enabled checks

Series is: Reviewed-by: Ben Widawsky On 16-10-26 11:29:51, Anuj Phogat wrote: On Tue, Oct 25, 2016 at 4:36 PM, Ilia Mirkin wrote: On Tue, Oct 25, 2016 at 7:09 PM, Anuj Phogat wrote: Signed-off-by: Anuj Phogat

[Mesa-dev] [PATCH 1/2] Fix races during _mesa_HashWalk().

There is currently no protection against walking a hash (using _mesa_HashWalk()) and modifying it at the same time, for instance by inserting or deleting elements. This leads to segfaults in multithreaded code if e.g. someone calls glTexImage2D (which may have to walk the list of FBOs) while

[Mesa-dev] [PATCH 2/2] Make shader refcounting atomic.

These were racy when using the same shaders (seemingly even from different program objects) on multiple theads sharing the same objects, leading to issues such as (excerpts from an apitrace dump from a real application): 1097 @0 glCreateProgram() = 9 1099 @0 glAttachShader(program = 9, shader

Re: [Mesa-dev] [PATCH 1/2] Fix races during _mesa_HashWalk().

On Mon, Nov 07, 2016 at 08:54:13AM +1100, Timothy Arceri wrote: > The problem is is can happen totally unintentionally. Anyway I've sent > a couple of patches as a follow-up to your series, one to fix it and > one to make use of it. > > https://patchwork.freedesktop.org/series/14902/ Great,

Re: [Mesa-dev] [PATCH 2/2] Make shader refcounting atomic.

On Mon, Nov 07, 2016 at 08:42:18AM +1100, Timothy Arceri wrote: >> Interesting. So other code seemingly has done refcounting with non- >> atomics but with locking; those locks were just missing here. > I was trying to point you to the fact that locking is known to be > broken in some places in

Re: [Mesa-dev] [PATCH 1/2] Fix races during _mesa_HashWalk().

On Sun, 2016-11-06 at 12:16 +0100, Steinar H. Gunderson wrote: > On Sun, Nov 06, 2016 at 09:35:37AM +1100, Timothy Arceri wrote: > > > > Can you please change this line to say something like. With this > > change > > we switch to using a recursive mutex, which avoids the deadlock. > > Rewording.

[Mesa-dev] [Bug 98604] [VDPAU, DRI3] Fullscreen flash video fails when hardware acceleration is enabled.

https://bugs.freedesktop.org/show_bug.cgi?id=98604 --- Comment #6 from smoki --- That was pure information :), as i tried to reproduce it with that old affected one and newest which does not have an issue since it does not have decode... so no offense, bug is there. --

[Mesa-dev] [PATCH 1/2] mesa: handle callback functions that remove the ht entry in _mesa_HashDeleteAll()

Now that we use recursive locking for the hash table mutex, it is possible to pass a callback to that remove the entry to _mesa_HashDeleteAll() without getting stuck waiting for a lock. However we will end up removing the entry twice and the hash table entry counts will get messed up. To avoid

[Mesa-dev] [PATCH 2/2] mesa: remove free_shader_program_data_cb

We no longer need this as it was just working around a locking issue that has been fixed by switching to using recursive locking in the hash table. We can now just let delete_shader_cb() free the shader program data. --- src/mesa/main/shared.c | 17 - 1 file changed, 17

Re: [Mesa-dev] [PATCH 2/2] Make shader refcounting atomic.

On Sun, 2016-11-06 at 12:17 +0100, Steinar H. Gunderson wrote: > On Sun, Nov 06, 2016 at 09:40:03AM +1100, Timothy Arceri wrote: > > > > https://lists.freedesktop.org/archives/mesa-dev/2016-October/132629 > > .html > > Interesting. So other code seemingly has done refcounting with non- > atomics

Re: [Mesa-dev] [PATCH v4 0/4] nv50/ir: PostRaConstantFolding improvements

no regressions in piglit on my nve6 2016-11-06 15:05 GMT+01:00 Karol Herbst : > This series reworks the structure of the pass to make it easier to add > more optimisations to it. > > I have to rework the RA commit a bit and the post_ra_dead patch should be > submitted on

[Mesa-dev] [Bug 98604] [VDPAU, DRI3] Fullscreen flash video fails when hardware acceleration is enabled.

https://bugs.freedesktop.org/show_bug.cgi?id=98604 --- Comment #5 from Chris Rankin --- (In reply to smoki from comment #4) > In couple months 11.2.x seems will cease to be supported anymore, so this > might be time fixable... well in case they did not decide to enable

[Mesa-dev] [Bug 98604] [VDPAU, DRI3] Fullscreen flash video fails when hardware acceleration is enabled.

https://bugs.freedesktop.org/show_bug.cgi?id=98604 --- Comment #4 from smoki --- But yeah newer does not have VDPAU support, neither this 24 beta it seems: http://labs.adobe.com/downloads/flashplayer.html In couple months 11.2.x seems will cease to be supported

[Mesa-dev] [Bug 98604] [VDPAU, DRI3] Fullscreen flash video fails when hardware acceleration is enabled.

https://bugs.freedesktop.org/show_bug.cgi?id=98604 Nayan Deshmukh changed: What|Removed |Added CC|

[Mesa-dev] [PATCH] r600g: add HUD queries for shaders created and compiler invocations

r600g: add HUD queries for shaders created and compiler invocations for easy review, it is based on these commits for radeonsi: 70f5e49ba5ca8eb063a0d7db94fbef1585b21b2d 30a7e0c021c3a77c20c6f041dc80b7dc90ad238f it is my first patch and I don't have commit access tested on a richland apu with

Re: [Mesa-dev] [PATCH v4 4/4] gm107/ir: add LIMM form of mad

Subject: [PATCH v5] gm107/ir: add LIMM form of mad v2: renamed commit reordered modifiers add assert(dst == src2) v3: reordered modifiers again v5: no roudning bit for limms Signed-off-by: Karol Herbst --- .../drivers/nouveau/codegen/nv50_ir_emit_gm107.cpp | 34

Re: [Mesa-dev] clover: Add CL_PROGRAM_BINARY_TYPE support (CL1.2).

After latest clover commit 'luxmark-v3.0' sigfault immediately: SOURCE/luxmark-v3.0> ./luxmark ./luxmark.bin: /usr/local/lib/libOpenCL.so.1: no version information available (required by ./luxmark.bin) *** Error in `./luxmark.bin': corrupted double-linked list: 0x7f51a57829e0 *** ===

Re: [Mesa-dev] [PATCH 1/2] gallivm: introduce 32x32->64bit lp_build_mul_32_lohi function

On 04/11/16 04:14, srol...@vmware.com wrote: From: Roland Scheidegger This is used by shader umul_hi/imul_hi functions (and soon by draw). It's actually useful separating this out on its own, however the real reason for doing it is because we're using an optimized sse2

[Mesa-dev] Where to place the SPIR-V headers

Hello everyone, I have been working on translating SPIR-V to NV50 IR inside Nouveau in order to run OpenCL kernels, received as SPIR-V binaries, on Nouveau. I have some patches for clover as well as gallium, but before sending those for review, I would like to know how to handle the SPIR-V header

Re: [Mesa-dev] [PATCH v4 4/4] gm107/ir: add LIMM form of mad

On Nov 6, 2016 9:06 AM, "Karol Herbst" wrote: > > v2: renamed commit > reordered modifiers > add assert(dst == src2) > v3: reordered modifiers again > > Signed-off-by: Karol Herbst > --- > .../drivers/nouveau/codegen/nv50_ir_emit_gm107.cpp |

[Mesa-dev] [PATCH v4 1/4] nv50/ir: restructure and rename postraconstantfolding pass

we might want to add more folding passes here, so make it a bit more generic v2: leave the comment and reword commit message v4: rename it to PostRaLoadPropagation Signed-off-by: Karol Herbst Reviewed-by: Samuel Pitoiset ---

[Mesa-dev] [PATCH v4 3/4] gk110/ir: add LIMM form of mad

v2: renamed commit reordered modifiers add assert(dst == src2) v3: removed wrong neg mod emission Signed-off-by: Karol Herbst --- .../drivers/nouveau/codegen/nv50_ir_emit_gk110.cpp | 50 ++ .../drivers/nouveau/codegen/nv50_ir_peephole.cpp |

[Mesa-dev] [PATCH v4 2/4] nv50/ir: implement mad post ra folding for nvc0+

changes for GpuTest /test=pixmark_piano /benchmark /no_scorebox /msaa=0 /benchmark_duration_ms=6 /width=1024 /height=640: score: 1026 -> 1044 changes for shader-db: total instructions in shared programs : 3499445 -> 3491273 (-0.23%) total gprs used in shared programs: 453803 -> 453803

[Mesa-dev] [PATCH v4 0/4] nv50/ir: PostRaConstantFolding improvements

This series reworks the structure of the pass to make it easier to add more optimisations to it. I have to rework the RA commit a bit and the post_ra_dead patch should be submitted on its own. v2: swaped the last two commits v3: reworked order v4: droped last two patches Karol Herbst (4):

[Mesa-dev] [PATCH v4 4/4] gm107/ir: add LIMM form of mad

v2: renamed commit reordered modifiers add assert(dst == src2) v3: reordered modifiers again Signed-off-by: Karol Herbst --- .../drivers/nouveau/codegen/nv50_ir_emit_gm107.cpp | 35 -- .../drivers/nouveau/codegen/nv50_ir_peephole.cpp | 3 +-

Re: [Mesa-dev] [PATCH 2/2] Make shader refcounting atomic.

On Sun, Nov 06, 2016 at 09:40:03AM +1100, Timothy Arceri wrote: > https://lists.freedesktop.org/archives/mesa-dev/2016-October/132629.html Interesting. So other code seemingly has done refcounting with non-atomics but with locking; those locks were just missing here. (I've skipped the finer

Re: [Mesa-dev] [PATCH 1/2] Fix races during _mesa_HashWalk().

On Sun, Nov 06, 2016 at 09:35:37AM +1100, Timothy Arceri wrote: > Can you please change this line to say something like. With this change > we switch to using a recursive mutex, which avoids the deadlock. Rewording. > I was a little confused. At first I thought it was already using a > recursive

[Mesa-dev] [Bug 98595] glsl: ralloc assertion "info->canary == CANARY" failed

https://bugs.freedesktop.org/show_bug.cgi?id=98595 --- Comment #7 from Jonathan Gray --- Sorry that commit was just looking over commits. An actual bisect results in "a4a93103fb8f5c21c4cd17e89f07badfab14c0ab is the first bad commit". glsl: use the linear allocator for

[Mesa-dev] [Bug 98002] Mud rendering bug in Portal 2

https://bugs.freedesktop.org/show_bug.cgi?id=98002 --- Comment #12 from Clément Guérin --- For some reason it doesn't work either with Firefox here, but it's fine with Epiphany (GNOME Web). -- You are receiving this mail because: You are the assignee for the bug. You are