Re: [Mesa-dev] GLSL IR & TGSI on-disk shader cache

2017-02-06 Thread Timothy Arceri
On Tue, 7 Feb 2017 15:50:28 +0900 Michel Dänzer wrote: > On 07/02/17 12:42 PM, Timothy Arceri wrote: > > > > This series does not include the patch that adds cache support > > to the radeonsi backend, the main reason for this is that llvm > > currently doesn't allow the

Re: [Mesa-dev] [PATCH] [RFC] radv: enable transfer queues on CIK using SDMA engine.

2017-02-06 Thread Nicolai Hähnle
It may be time to start thinking about whether CS emit functions can be shared between radv and the gallium winsys. This code has seen a lot of subtle bug fixes over time, so duplication is not very nice. Nicolai On 07.02.2017 07:01, Dave Airlie wrote: From: Dave Airlie

[Mesa-dev] [Bug 99701] loader.c:353:8: error: implicit declaration of function 'geteuid' is invalid in C99 [-Werror, -Wimplicit-function-declaration]

2017-02-06 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=99701 --- Comment #1 from Nicolai Hähnle --- Created attachment 129378 --> https://bugs.freedesktop.org/attachment.cgi?id=129378=edit always include unistd.h The attached patch might fix this. Out of curiosity, what kind of

Re: [Mesa-dev] [PATCH] spirv: Add more asserts in vtn_vector_construct

2017-02-06 Thread Samuel Iglesias Gonsálvez
Reviewed-by: Samuel Iglesias Gonsálvez On Mon, 2017-02-06 at 21:20 -0800, Jason Ekstrand wrote: > On Mon, Feb 6, 2017 at 9:18 PM, Jason Ekstrand > wrote: > > These are currently getting hit by the Skia Vulkan back-end > > Bugzilla:

Re: [Mesa-dev] [PATCH] i965/fs: don't lower different type size conversions on opt_peephole_sel()

2017-02-06 Thread Samuel Iglesias Gonsálvez
Gentle reminder :) Sam On Wed, 2017-01-25 at 11:20 +0100, Samuel Iglesias Gonsálvez wrote: > Don't lower a type conversion between different type sizes > because SEL does't support them, SEL without conditional modifier > just do a raw move. > > Signed-off-by: Samuel Iglesias Gonsálvez

Re: [Mesa-dev] GLSL IR & TGSI on-disk shader cache

2017-02-06 Thread Michel Dänzer
On 07/02/17 12:42 PM, Timothy Arceri wrote: > > This series does not include the patch that adds cache support > to the radeonsi backend, the main reason for this is that llvm > currently doesn't allow the version to be queried at runtime > (as far as I'm aware) although it seems like other are

[Mesa-dev] [Bug 97967] glsl/tests/cache-test regression

2017-02-06 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=97967 --- Comment #15 from Vinson Lee --- Here is make check failure with the debug statements from attachment 129357. FAIL: glsl/tests/cache-test === Failed to create ./cache-test-tmp/xdg-cache-home for

[Mesa-dev] [Bug 99246] [d3dadapter+radeonsi & bisect] EVE-Online : hang on wormhole sight

2017-02-06 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=99246 Mathieu Belanger changed: What|Removed |Added Resolution|--- |NOTOURBUG

[Mesa-dev] [PATCH] [RFC] radv: enable transfer queues on CIK using SDMA engine.

2017-02-06 Thread Dave Airlie
From: Dave Airlie This enables a transfer queue using the SDMA engine on CIK/VI/Polaris GPUs. TODO: decide what to do with HW limitations from radeonsi (fail to record?) add linear bounds check to the buffer->image copies dEQP-VK.synchronization.op.multi_queue.fence.*:

Re: [Mesa-dev] [PATCH] spirv: Add more asserts in vtn_vector_construct

2017-02-06 Thread Jason Ekstrand
On Mon, Feb 6, 2017 at 9:18 PM, Jason Ekstrand wrote: > These are currently getting hit by the Skia Vulkan back-end > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=99465 > --- > src/compiler/spirv/spirv_to_nir.c | 15 +++ > 1 file changed, 15

[Mesa-dev] [PATCH] spirv: Add more asserts in vtn_vector_construct

2017-02-06 Thread Jason Ekstrand
These are currently getting hit by the Skia Vulkan back-end --- src/compiler/spirv/spirv_to_nir.c | 15 +++ 1 file changed, 15 insertions(+) diff --git a/src/compiler/spirv/spirv_to_nir.c b/src/compiler/spirv/spirv_to_nir.c index 9f0b8fd..416e12a 100644 ---

[Mesa-dev] [PATCH V2 01/40] st/mesa/i965: create link status enum

2017-02-06 Thread Timothy Arceri
For the on-disk shader cache we want to be able to differentiate between a program that was linked and one that was loaded from cache. V2: - don't return the new enum directly to the application when queried, instead return GL_TRUE or GL_FALSE as required. Fixes google-chrome corruptions

Re: [Mesa-dev] [PATCH] glsl: correct compute shader checks for memoryBarrier functions

2017-02-06 Thread Kenneth Graunke
On Monday, February 6, 2017 9:07:30 AM PST Marc Di Luzio wrote: > As per the spec - > "The functions memoryBarrierShared() and groupMemoryBarrier() are > available only in compute shaders; the other functions are available > in all shader types." > > Conform to this by adding another delegate to

[Mesa-dev] [Bug 99246] [d3dadapter+radeonsi & bisect] EVE-Online : hang on wormhole sight

2017-02-06 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=99246 --- Comment #4 from Mathieu Belanger --- Will do more debugging, was out of time. Just to let you know, I have updated to latest git and upgraded to a RX480, bug still present. -- You are receiving this mail because: You are

[Mesa-dev] [PATCH 35/40] util/disk_cache: allow drivers to pass a directory structure

2017-02-06 Thread Timothy Arceri
In order to avoid costly fallback recompiles when cache items are created with an old version of Mesa or for a different gpu on the same system we want to create directories that look like this: ./{MESA_VERSION_STRING}/{GPU_ID} For llvm based drivers we will probably want an additional

[Mesa-dev] [PATCH 39/40] mesa: add helper to create cache name string

2017-02-06 Thread Timothy Arceri
--- src/mesa/main/version.c | 9 + src/mesa/main/version.h | 3 +++ 2 files changed, 12 insertions(+) diff --git a/src/mesa/main/version.c b/src/mesa/main/version.c index 85ec9de..daf0dcb 100644 --- a/src/mesa/main/version.c +++ b/src/mesa/main/version.c @@ -110,6 +110,15 @@ exit:

[Mesa-dev] [PATCH 32/40] glsl: reserve parameter storage on cache restore

2017-02-06 Thread Timothy Arceri
From: Timothy Arceri Since we know how big the list will be we can allocate the storage upfront. --- src/compiler/glsl/shader_cache.cpp | 1 + 1 file changed, 1 insertion(+) diff --git a/src/compiler/glsl/shader_cache.cpp b/src/compiler/glsl/shader_cache.cpp

[Mesa-dev] [PATCH 34/40] mesa: remove cache creation from _mesa_initialize_context()

2017-02-06 Thread Timothy Arceri
We will change the way we create the cache directory in the following patches. --- src/mesa/main/context.c | 5 - 1 file changed, 5 deletions(-) diff --git a/src/mesa/main/context.c b/src/mesa/main/context.c index 16e25a9..bbc13a9 100644 --- a/src/mesa/main/context.c +++

[Mesa-dev] [PATCH 40/40] r600/radeonsi: enable glsl/tgsi on-disk cache

2017-02-06 Thread Timothy Arceri
--- src/gallium/drivers/radeon/r600_pipe_common.c | 17 + src/gallium/drivers/radeon/r600_pipe_common.h | 2 ++ src/gallium/include/pipe/p_screen.h | 3 +++ src/mesa/state_tracker/st_context.c | 6 ++ 4 files changed, 28 insertions(+) diff --git

[Mesa-dev] [PATCH 38/40] st/mesa: implement a tgsi on-disk shader cache

2017-02-06 Thread Timothy Arceri
Implements a tgsi cache for the OpenGL state tracker. --- src/mesa/state_tracker/st_glsl_to_tgsi.cpp | 217 + src/mesa/state_tracker/st_program.c| 133 +- 2 files changed, 345 insertions(+), 5 deletions(-) diff --git

[Mesa-dev] [PATCH 37/40] util/disk_cache: check cache exists before calling munmap()

2017-02-06 Thread Timothy Arceri
--- src/util/disk_cache.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/util/disk_cache.c b/src/util/disk_cache.c index da4eb47..a70bd66 100644 --- a/src/util/disk_cache.c +++ b/src/util/disk_cache.c @@ -385,7 +385,8 @@ disk_cache_create(const char *gpu_name, const

[Mesa-dev] [PATCH 36/40] util/disk_cache: add support for removing old versions of the cache

2017-02-06 Thread Timothy Arceri
--- src/util/disk_cache.c | 38 ++ 1 file changed, 38 insertions(+) diff --git a/src/util/disk_cache.c b/src/util/disk_cache.c index df511e4..da4eb47 100644 --- a/src/util/disk_cache.c +++ b/src/util/disk_cache.c @@ -24,6 +24,7 @@ #ifdef ENABLE_SHADER_CACHE

[Mesa-dev] [PATCH 33/40] glsl: create separate 32bit and 64bit versions of shader cache objects

2017-02-06 Thread Timothy Arceri
From: Timothy Arceri Pointers will have different lengths so we simply create a different sha1 for each platform. In theory we should be able to share cached shaders as we cache all pointer as uint64_t however if a pointer is ever added to one of the structs we

[Mesa-dev] [PATCH 31/40] glsl: don't try to load/store buffer object values in the cache

2017-02-06 Thread Timothy Arceri
From: Timothy Arceri Also add an assert to catch buffer overflows. --- src/compiler/glsl/shader_cache.cpp | 13 +++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/src/compiler/glsl/shader_cache.cpp b/src/compiler/glsl/shader_cache.cpp

[Mesa-dev] [PATCH 29/40] glsl/mesa: make a copy of FragData bindings in case of cache fallback

2017-02-06 Thread Timothy Arceri
From: Timothy Arceri If the shader cache falls back to doing a compile and link we need the original FragData bindings as they could have changed after the program was first linked. --- src/compiler/glsl/shader_cache.cpp | 8 src/mesa/main/mtypes.h

[Mesa-dev] [PATCH 28/40] glsl/mesa: make a copy of attribute bindings in case of cache fallback

2017-02-06 Thread Timothy Arceri
From: Timothy Arceri If the shader cache falls back to doing a compile and link we need the original attribute bindings as they could have changed after the program was first linked. --- src/compiler/glsl/shader_cache.cpp | 15 +++

[Mesa-dev] [PATCH 30/40] glsl: disable on disk shader cache when running as another user

2017-02-06 Thread Timothy Arceri
From: Timothy Arceri --- src/util/disk_cache.c | 4 1 file changed, 4 insertions(+) diff --git a/src/util/disk_cache.c b/src/util/disk_cache.c index 7451b08..382ac6c 100644 --- a/src/util/disk_cache.c +++ b/src/util/disk_cache.c @@ -142,6 +142,10 @@

[Mesa-dev] [PATCH 18/40] glsl: make uniform values helper available for use elsewhere

2017-02-06 Thread Timothy Arceri
From: Timothy Arceri --- src/compiler/glsl/link_uniforms.cpp | 2 +- src/compiler/glsl/linker.h | 3 +++ 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/src/compiler/glsl/link_uniforms.cpp b/src/compiler/glsl/link_uniforms.cpp index

[Mesa-dev] [PATCH 23/40] glsl: don't reference shader prog data during cache fallback

2017-02-06 Thread Timothy Arceri
From: Timothy Arceri We already have a reference. --- src/compiler/glsl/linker.cpp | 3 ++- src/mesa/main/shaderobj.c| 3 ++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/src/compiler/glsl/linker.cpp b/src/compiler/glsl/linker.cpp index

[Mesa-dev] [PATCH 25/40] glsl: skip more uniform initialisation when doing fallback linking

2017-02-06 Thread Timothy Arceri
From: Timothy Arceri We already pull these values from the metadata cache so no need to recreate them. --- src/compiler/glsl/linker.cpp | 20 src/mesa/main/shaderobj.c| 8 +--- 2 files changed, 17 insertions(+), 11 deletions(-) diff

[Mesa-dev] [PATCH 26/40] glsl: don't reprocess or clear UBOs on cache fallback

2017-02-06 Thread Timothy Arceri
From: Timothy Arceri --- src/compiler/glsl/linker.cpp | 62 +++- src/mesa/main/shaderobj.c| 16 +++- 2 files changed, 42 insertions(+), 36 deletions(-) diff --git a/src/compiler/glsl/linker.cpp

[Mesa-dev] [PATCH 24/40] glsl: don't lose uniform values when falling back to full compile

2017-02-06 Thread Timothy Arceri
From: Timothy Arceri Here we skip the recreation of uniform storage if we are relinking after a cache miss. This is improtant because uniform values may have already been set by the application and we don't want to reset them. ---

[Mesa-dev] [PATCH 27/40] util: make string_to_uint_map hash table public

2017-02-06 Thread Timothy Arceri
From: Timothy Arceri This will allow us to make use of the hash_table_call_foreach() function from outside the object. --- src/util/string_to_uint_map.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/util/string_to_uint_map.h

[Mesa-dev] [PATCH 21/40] mesa/glsl: add cache_fallback flag to gl_shader_program_data

2017-02-06 Thread Timothy Arceri
From: Timothy Arceri This will allow us to skip certain things when falling back to a full recompile on a cache miss such as avoiding reinitialising uniforms. In this chage we use it to avoid reading the program metadata from the cache and skipping linking during a

[Mesa-dev] [PATCH 20/40] glsl: track mesa version shader cache items were created with

2017-02-06 Thread Timothy Arceri
From: Timothy Arceri Also remove cache item and fallback to full recompile if current Mesa version differs. V2: don't leak buffer --- src/compiler/glsl/shader_cache.cpp | 13 + 1 file changed, 13 insertions(+) diff --git

[Mesa-dev] [PATCH 22/40] glsl: make a copy of the shader source for use with cache fallback

2017-02-06 Thread Timothy Arceri
From: Timothy Arceri A number of things can happen that change the shader source after it is compiled or linked. For example: - Source changed after it is first compiled - Source changed after linking - Shader detached after linking In order to be able to fallback

[Mesa-dev] [PATCH 15/40] glsl: add shader cache support for buffer blocks

2017-02-06 Thread Timothy Arceri
From: Timothy Arceri --- src/compiler/glsl/shader_cache.cpp | 163 + 1 file changed, 163 insertions(+) diff --git a/src/compiler/glsl/shader_cache.cpp b/src/compiler/glsl/shader_cache.cpp index deabc2a..530bdad 100644 ---

[Mesa-dev] [PATCH 17/40] glsl: cache some more image metadata

2017-02-06 Thread Timothy Arceri
From: Timothy Arceri --- src/compiler/glsl/shader_cache.cpp | 10 ++ 1 file changed, 10 insertions(+) diff --git a/src/compiler/glsl/shader_cache.cpp b/src/compiler/glsl/shader_cache.cpp index e75717c..6225dea 100644 ---

[Mesa-dev] [PATCH 13/40] glsl: add support for caching subroutines

2017-02-06 Thread Timothy Arceri
From: Timothy Arceri --- src/compiler/glsl/shader_cache.cpp | 107 + 1 file changed, 107 insertions(+) diff --git a/src/compiler/glsl/shader_cache.cpp b/src/compiler/glsl/shader_cache.cpp index 4c43fc3..7d651bc 100644 ---

[Mesa-dev] [PATCH 16/40] glsl: add support for caching atomic buffers

2017-02-06 Thread Timothy Arceri
From: Timothy Arceri --- src/compiler/glsl/shader_cache.cpp | 89 ++ 1 file changed, 89 insertions(+) diff --git a/src/compiler/glsl/shader_cache.cpp b/src/compiler/glsl/shader_cache.cpp index 530bdad..e75717c 100644 ---

[Mesa-dev] [PATCH 19/40] glsl: cache uniform values

2017-02-06 Thread Timothy Arceri
From: Timothy Arceri These may be lowered constant arrays or uniform values that we set before linking so we need to cache the actual uniform values. --- src/compiler/glsl/shader_cache.cpp | 33 + 1 file changed, 33 insertions(+)

[Mesa-dev] [PATCH 09/40] glsl: fix uniform remap table cache when explicit locations used

2017-02-06 Thread Timothy Arceri
From: Timothy Arceri --- src/compiler/glsl/shader_cache.cpp | 32 +--- 1 file changed, 25 insertions(+), 7 deletions(-) diff --git a/src/compiler/glsl/shader_cache.cpp b/src/compiler/glsl/shader_cache.cpp index ba05655..ff8d150 100644

[Mesa-dev] [PATCH 11/40] glsl: add shader cache support for samplers

2017-02-06 Thread Timothy Arceri
From: Timothy Arceri --- src/compiler/glsl/shader_cache.cpp | 18 ++ 1 file changed, 18 insertions(+) diff --git a/src/compiler/glsl/shader_cache.cpp b/src/compiler/glsl/shader_cache.cpp index 56ea305..05b11ed 100644 ---

[Mesa-dev] [PATCH 12/40] glsl: add support for caching shaders with xfb qualifiers

2017-02-06 Thread Timothy Arceri
From: Timothy Arceri For now this disables the shader cache when transform feedback is enabled via the GL API as we don't currently allow for it when generating the sha for the shader. --- src/compiler/glsl/linker.cpp | 14 -

[Mesa-dev] [PATCH 14/40] glsl: store subroutine remap table in shader cache

2017-02-06 Thread Timothy Arceri
From: Timothy Arceri --- src/compiler/glsl/shader_cache.cpp | 57 ++ 1 file changed, 51 insertions(+), 6 deletions(-) diff --git a/src/compiler/glsl/shader_cache.cpp b/src/compiler/glsl/shader_cache.cpp index 7d651bc..deabc2a

[Mesa-dev] [PATCH 10/40] glsl: add basic support for resource list to shader cache

2017-02-06 Thread Timothy Arceri
From: Timothy Arceri This initially adds support for simple uniforms and varyings. --- src/compiler/glsl/shader_cache.cpp | 121 + 1 file changed, 121 insertions(+) diff --git a/src/compiler/glsl/shader_cache.cpp

[Mesa-dev] [PATCH 02/40] docs: add shader cache environment variables

2017-02-06 Thread Timothy Arceri
From: Timothy Arceri Reviewed-by: Eric Anholt --- docs/envvars.html | 11 +++ 1 file changed, 11 insertions(+) diff --git a/docs/envvars.html b/docs/envvars.html index 276cea3..2269f18 100644 --- a/docs/envvars.html +++

[Mesa-dev] [PATCH 05/40] glsl: add initial implementation of shader cache

2017-02-06 Thread Timothy Arceri
From: Timothy Arceri This uses disk_cache.c to write out a serialization of various state that's required in order to successfully load and use a binary written out by a drivers backend, this state is referred to as "metadata" throughout the implementation. This

[Mesa-dev] [PATCH 06/40] glsl: add helper to convert pointers to uint64_t

2017-02-06 Thread Timothy Arceri
From: Timothy Arceri This will be used to store all pointers in the cache as 64bit ints allowing us to avoid issues when a 32bit program reads a cached shader that was created by a 64bit application. --- src/compiler/glsl/shader_cache.h | 10 ++ 1 file

[Mesa-dev] [PATCH 01/40] st/mesa/i965: create link status enum

2017-02-06 Thread Timothy Arceri
For the on-disk shader cache we want to be able to differentiate between a program that was linked and one that was loaded from cache. --- src/compiler/glsl/linker.cpp | 6 +++--- src/compiler/glsl/standalone.cpp | 2 +- src/mesa/drivers/dri/i965/brw_cs.c | 4

[Mesa-dev] GLSL IR & TGSI on-disk shader cache

2017-02-06 Thread Timothy Arceri
This series adds support for a GLSL IR level and TGSI (OpenGL/st) level caches. There are a few small bug fixes and a little bit of restructuring to the GLSL IR patches to make things work for Gallium drivers vs just i965 previously, but nothing too major. The biggest change is patch 35 which

[Mesa-dev] [PATCH 08/40] glsl: Serialize three additional hash tables with program metadata

2017-02-06 Thread Timothy Arceri
From: Carl Worth The three additional tables are AttributeBindings, FragDataBindings, and FragDataIndexBindings. The first table (AttributeBindings) was identified as missing by trying to test the shader cache with a program that called glGetAttribLocation. Many thanks to

[Mesa-dev] [PATCH 07/40] glsl: make use of on disk shader cache

2017-02-06 Thread Timothy Arceri
From: Timothy Arceri The hash key for glsl metadata is a hash of the hashes of each GLSL source string. This commit uses the put_key/get_key support in the cache put the SHA-1 hash of the source string for each successfully compiled shader into the cache. This

[Mesa-dev] [PATCH 03/40] util: add a disk_cache_remove() function

2017-02-06 Thread Timothy Arceri
From: Timothy Arceri This will be used to remove cache items created with old versions of Mesa or other invalid cache items from the cache. V2: rename stub function (cache_* funtions were renamed disk_cache_*) in master. --- src/util/disk_cache.c | 22

[Mesa-dev] [PATCH 04/40] glsl: add param to force shader recompile

2017-02-06 Thread Timothy Arceri
From: Timothy Arceri This will be used to skip checking the cache and force a recompile. --- src/compiler/glsl/glsl_parser_extras.cpp | 2 +- src/compiler/glsl/program.h | 2 +- src/compiler/glsl/standalone.cpp | 3 ++-

Re: [Mesa-dev] [PATCH] gallium/tgsi: fix oob access in parse instruction

2017-02-06 Thread Li Qiang
Hello, Ping! 2017-01-23 15:44 GMT+08:00 Li Qiang : > When parsing texture instruction, it doesn't stop if the > 'cur' is ',', the loop variable 'i' will also be increased > and be used to index the 'inst.TexOffsets' array. This can lead > an oob access issue. This patch avoid

Re: [Mesa-dev] [Freedreno] WebProcess crash on DB410c

2017-02-06 Thread Sivasubramanian Patchaiperumal
Tried writing a simple EGL pbuffer application and tested it on DB410c. As expected, eglChooseConfig returned no matched config available. Is there something we can do to get pbuffer support on Mesa? On 3 February 2017 at 20:33, Rob Clark wrote: > Hmm, could be that

[Mesa-dev] [PATCH] glx/glvnd: Fix GLXdispatchIndex sorting

2017-02-06 Thread Hans de Goede
Commit 8bca8d89ef3b ("glx/glvnd: Fix dispatch function names and indices") fixed the sorting of the array initializers in g_glxglvnddispatchfuncs.c because FindGLXFunction's binary search needs these to be sorted alphabetically. That commit also mostly fixed the sorting of the DI_foo defines in

Re: [Mesa-dev] Time to merge threaded GL dispatch? (aka glthread)

2017-02-06 Thread Kenneth Graunke
On Monday, February 6, 2017 8:54:40 PM PST Marek Olšák wrote: > On Mon, Feb 6, 2017 at 8:20 PM, Ernst Sjöstrand wrote: > > FYI glmark2 segfaults with mesa_glthread=true. Expected that some programs > > will segfault? > > Yes, even segfaults are expected with mesa_glthread=true.

[Mesa-dev] [Bug 99701] loader.c:353:8: error: implicit declaration of function 'geteuid' is invalid in C99 [-Werror, -Wimplicit-function-declaration]

2017-02-06 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=99701 Bug ID: 99701 Summary: loader.c:353:8: error: implicit declaration of function 'geteuid' is invalid in C99 [-Werror,-Wimplicit-function-declaration] Product: Mesa

[Mesa-dev] [PATCH 03/10] swr: [rasterizer jitter] Fix issues with stream-out on llvm>=3.8

2017-02-06 Thread Tim Rowley
--- src/gallium/drivers/swr/rasterizer/jitter/builder.cpp | 4 +--- src/gallium/drivers/swr/rasterizer/jitter/builder.h | 2 -- src/gallium/drivers/swr/rasterizer/jitter/streamout_jit.cpp | 6 +- 3 files changed, 6 insertions(+), 6 deletions(-) diff --git

[Mesa-dev] [PATCH 09/10] swr: [rasterizer core] Frontend SIMD16 WIP

2017-02-06 Thread Tim Rowley
Removed temporary scafolding in PA, widended the PA_STATE interface for SIMD16, and implemented PA_STATE_CUT and PA_TESS for SIMD16. PA_STATE_CUT and PA_TESS now work in SIMD16. --- src/gallium/drivers/swr/rasterizer/core/context.h | 6 + .../drivers/swr/rasterizer/core/frontend.cpp |

[Mesa-dev] [PATCH 10/10] swr: [rasterizer jitter] Pass LLVM-IR size into jitter

2017-02-06 Thread Tim Rowley
--- src/gallium/drivers/swr/rasterizer/jitter/JitManager.cpp | 4 ++-- src/gallium/drivers/swr/rasterizer/jitter/JitManager.h | 2 +- src/gallium/drivers/swr/rasterizer/jitter/jit_api.h | 1 + 3 files changed, 4 insertions(+), 3 deletions(-) diff --git

[Mesa-dev] [PATCH 04/10] swr: [rasterizer jitter] Change SimdVector representation to array

2017-02-06 Thread Tim Rowley
Make all SimdVectors in LLVM represented as simdscalar[4] rather than a struct. Fixes issues with promotion of values from i32 to i64 to match register width. --- src/gallium/drivers/swr/rasterizer/jitter/JitManager.cpp | 6 ++ src/gallium/drivers/swr/rasterizer/jitter/JitManager.h | 2 --

[Mesa-dev] [PATCH 06/10] swr: [rasterizer jitter] Add DEBUGTRAP jit builder function

2017-02-06 Thread Tim Rowley
--- src/gallium/drivers/swr/rasterizer/jitter/builder_misc.cpp | 7 +++ src/gallium/drivers/swr/rasterizer/jitter/builder_misc.h | 3 ++- 2 files changed, 9 insertions(+), 1 deletion(-) diff --git a/src/gallium/drivers/swr/rasterizer/jitter/builder_misc.cpp

[Mesa-dev] [PATCH 08/10] swr: [rasterizer jitter] Disable unsafe FP optimizations in the jitter

2017-02-06 Thread Tim Rowley
--- src/gallium/drivers/swr/rasterizer/jitter/JitManager.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/drivers/swr/rasterizer/jitter/JitManager.cpp b/src/gallium/drivers/swr/rasterizer/jitter/JitManager.cpp index 74ffd27..5bd21a1 100644 ---

[Mesa-dev] [PATCH 02/10] swr: [rasterizer jitter] Adjust jitter header includes

2017-02-06 Thread Tim Rowley
--- src/gallium/drivers/swr/rasterizer/jitter/JitManager.cpp| 8 src/gallium/drivers/swr/rasterizer/jitter/JitManager.h | 6 +++--- src/gallium/drivers/swr/rasterizer/jitter/blend_jit.cpp | 2 +- src/gallium/drivers/swr/rasterizer/jitter/builder.cpp | 2 +-

[Mesa-dev] [PATCH 00/10] swr: update rasterizer

2017-02-06 Thread Tim Rowley
Highlights include more avx512 work and fixes for llvm>=3.8. Tim Rowley (10): swr: [rasterizer core] Frontend SIMD16 WIP swr: [rasterizer jitter] Adjust jitter header includes swr: [rasterizer jitter] Fix issues with stream-out on llvm>=3.8 swr: [rasterizer jitter] Change SimdVector

[Mesa-dev] [PATCH 05/10] swr: [rasterizer jitter] Multisample blend jit fix

2017-02-06 Thread Tim Rowley
--- src/gallium/drivers/swr/rasterizer/jitter/blend_jit.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/gallium/drivers/swr/rasterizer/jitter/blend_jit.cpp b/src/gallium/drivers/swr/rasterizer/jitter/blend_jit.cpp index 76a58b6..b4a33b8 100644 ---

[Mesa-dev] [PATCH 07/10] swr: [rasterizer core] Frontend SIMD16 WIP

2017-02-06 Thread Tim Rowley
Widen simdvertex to SIMD16/simd16vertex in frontend for passing VS attributes from VS to PA. --- .../drivers/swr/rasterizer/core/frontend.cpp | 33 ++- src/gallium/drivers/swr/rasterizer/core/frontend.h | 8 + src/gallium/drivers/swr/rasterizer/core/pa.h | 64 +

[Mesa-dev] [PATCH 01/10] swr: [rasterizer core] Frontend SIMD16 WIP

2017-02-06 Thread Tim Rowley
SIMD16 Primitive Assembly (PA) only supports TriList and RectList. CUT_AWARE_PA, TESS, GS, and SO disabled in the SIMD16 front end. --- .../drivers/swr/rasterizer/core/frontend.cpp | 299 ++--- src/gallium/drivers/swr/rasterizer/core/frontend.h | 4 +-

Re: [Mesa-dev] [PATCH] radv: pass FMASK alignment to application

2017-02-06 Thread Bas Nieuwenhuizen
Yep, Reviewed-by: Bas Nieuwenhuizen On Tue, Feb 7, 2017, at 01:32, Dave Airlie wrote: > From: Dave Airlie > > As was done for dcc and cmask. > > Cc: "17.0" > Signed-off-by: Dave Airlie >

[Mesa-dev] [PATCH] radv: pass FMASK alignment to application

2017-02-06 Thread Dave Airlie
From: Dave Airlie As was done for dcc and cmask. Cc: "17.0" Signed-off-by: Dave Airlie --- src/amd/vulkan/radv_image.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/amd/vulkan/radv_image.c

[Mesa-dev] [Bug 99517] [TRACKER] Mesa 17.0 release tracker

2017-02-06 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=99517 Bug 99517 depends on bug 99633, which changed state. Bug 99633 Summary: rasterizer/core/clip.h:279:49: error: ‘const struct API_STATE’ has no member named ‘linkageCount’ https://bugs.freedesktop.org/show_bug.cgi?id=99633 What

[Mesa-dev] [Bug 99633] rasterizer/core/clip.h:279:49: error: ‘const struct API_STATE’ has no member named ‘linkageCount’

2017-02-06 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=99633 Bruce Cherniak changed: What|Removed |Added Resolution|--- |FIXED

Re: [Mesa-dev] [PATCH 2/2] radv: Enable fast clears by default.

2017-02-06 Thread Dave Airlie
On 7 February 2017 at 09:53, Andres Rodriguez wrote: > For the series: > > Reviewed-by: Andres Rodriguez > > > > On 2017-02-06 06:47 PM, Bas Nieuwenhuizen wrote: >> >> Works for me on dota2 and talos now. >> >> Signed-off-by: Bas Nieuwenhuizen

[Mesa-dev] [PATCH] i965: Select pipeline and emit state base address in Gen8+ HiZ ops.

2017-02-06 Thread Kenneth Graunke
If a HiZ op is the first thing in the batch, we should make sure to select the render pipeline and emit state base address before proceeding. I believe 3DSTATE_WM_HZ_OP creates 3DPRIMITIVEs internally, and dispatching those on the GPGPU pipeline seems a bit sketchy. I'm not actually sure that

Re: [Mesa-dev] [PATCH 2/2] radv: Enable fast clears by default.

2017-02-06 Thread Andres Rodriguez
For the series: Reviewed-by: Andres Rodriguez On 2017-02-06 06:47 PM, Bas Nieuwenhuizen wrote: Works for me on dota2 and talos now. Signed-off-by: Bas Nieuwenhuizen --- src/amd/vulkan/radv_device.c | 4 ++-- src/amd/vulkan/radv_meta_clear.c | 2

[Mesa-dev] [PATCH 2/2] radv: Enable fast clears by default.

2017-02-06 Thread Bas Nieuwenhuizen
Works for me on dota2 and talos now. Signed-off-by: Bas Nieuwenhuizen --- src/amd/vulkan/radv_device.c | 4 ++-- src/amd/vulkan/radv_meta_clear.c | 2 +- src/amd/vulkan/radv_private.h| 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git

[Mesa-dev] [PATCH 1/2] radv: Pass DCC alignment to application.

2017-02-06 Thread Bas Nieuwenhuizen
Signed-off-by: Bas Nieuwenhuizen Cc: "17.0" --- src/amd/vulkan/radv_image.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/amd/vulkan/radv_image.c b/src/amd/vulkan/radv_image.c index 202f460aafe..1581645b18d 100644 ---

[Mesa-dev] [PATCH] radv: Pass CMASK alignment to application.

2017-02-06 Thread Bas Nieuwenhuizen
CMASK alignment can be greater than image data alignment, so pass it to the app so that it knows what alignment to backing memory should have. Signed-off-by: Bas Nieuwenhuizen Cc: --- src/amd/vulkan/radv_image.c | 1 + 1 file changed, 1

Re: [Mesa-dev] [PATCH] radv/ac: avoid the fmask path when doing txs.

2017-02-06 Thread Bas Nieuwenhuizen
Reviewed-by: Bas Nieuwenhuizen On Mon, Feb 6, 2017, at 03:41, Dave Airlie wrote: > From: Dave Airlie > > This fixes the vulkan samples deferredmultisampling test. > > Cc: "17.0" > Signed-off-by: Dave Airlie

Re: [Mesa-dev] Time to merge threaded GL dispatch? (aka glthread)

2017-02-06 Thread Marek Olšák
On Mon, Feb 6, 2017 at 9:27 PM, Jan Ziak <0xe2.0x9a.0...@gmail.com> wrote: > Hello > > I am against application profiles - in the form of "a > community-maintained whitelist of apps" or in any other form > explicitly associating the name/ID of an app with a Mesa variable > which controls the

Re: [Mesa-dev] [ANNOUNCE] mesa 17.0.0-rc3

2017-02-06 Thread Ilia Mirkin
May I ask why commit 7d3f9ed71c71637a91ecf15f50dbe7578a65d57e Author: Ilia Mirkin Date: Wed Jan 25 22:31:58 2017 -0500 st/mesa: MAX_VARYING is the max supported number of patch varyings, not min and commit e73f87fcbdcb12b0b8d28c4ca3444bfb7669bca5 Author: Ilia

Re: [Mesa-dev] [RFC PATCH] gallium: add a common uploader to pipe_context

2017-02-06 Thread Marek Olšák
On Mon, Feb 6, 2017 at 9:58 PM, Brian Paul wrote: > On 02/06/2017 12:11 PM, Marek Olšák wrote: >> >> On Mon, Feb 6, 2017 at 5:15 PM, Brian Paul wrote: >>> >>> On 02/03/2017 02:41 PM, Marek Olšák wrote: On Fri, Feb 3, 2017 at 9:45 PM, Brian

Re: [Mesa-dev] [PATCH 3/8] radv/amdgpu: Add winsys implementation of virtual buffers.

2017-02-06 Thread Dave Airlie
On 5 February 2017 at 21:43, Bas Nieuwenhuizen wrote: > Signed-off-by: Bas Nieuwenhuizen > --- > src/amd/vulkan/radv_radeon_winsys.h | 5 + > src/amd/vulkan/winsys/amdgpu/radv_amdgpu_bo.c | 218 > +++--- >

Re: [Mesa-dev] [PATCH] swr: [rasterizer core] Removed unused clip code.

2017-02-06 Thread Rowley, Timothy O
Reviewed-by: Tim Rowley > On Feb 3, 2017, at 11:35 AM, Bruce Cherniak > wrote: Removed unused Clip() and FRUSTUM_CLIP_MASK define. ---

Re: [Mesa-dev] [Mesa-stable] [PATCH] swr: [rasterizer core] Remove dead code Clipper::ClipScalar()

2017-02-06 Thread Rowley, Timothy O
Reviewed-by: Tim Rowley > On Feb 4, 2017, at 5:55 PM, Vinson Lee > wrote: Tested-by: Vinson Lee > On Thu, Feb 2, 2017 at 12:42 PM,

Re: [Mesa-dev] [RFC PATCH] gallium: add a common uploader to pipe_context

2017-02-06 Thread Brian Paul
On 02/06/2017 12:11 PM, Marek Olšák wrote: On Mon, Feb 6, 2017 at 5:15 PM, Brian Paul wrote: On 02/03/2017 02:41 PM, Marek Olšák wrote: On Fri, Feb 3, 2017 at 9:45 PM, Brian Paul wrote: On 02/01/2017 02:23 PM, Brian Paul wrote: On 01/27/2017 04:00

Re: [Mesa-dev] Time to merge threaded GL dispatch? (aka glthread)

2017-02-06 Thread Jan Ziak
Hello I am against application profiles - in the form of "a community-maintained whitelist of apps" or in any other form explicitly associating the name/ID of an app with a Mesa variable which controls the behavior of Mesa. Application profiles would be a manifestation of poor algorithms in the

Re: [Mesa-dev] [RFC PATCH 1/1] st/dri: add a new driconf option override_glsl_version for ARK games

2017-02-06 Thread Samuel Pitoiset
On 02/06/2017 04:45 PM, Eero Tamminen wrote: Hi, On 05.02.2017 15:19, Samuel Pitoiset wrote: On 02/03/2017 07:48 PM, Bas Nieuwenhuizen wrote: As far as I can see[1], when the game detects GL 4.3+, the engine tries to load a different set of shaders from disk, but the game developers have

Re: [Mesa-dev] [RFC PATCH 1/1] st/dri: add a new driconf option override_glsl_version for ARK games

2017-02-06 Thread Samuel Pitoiset
On 02/06/2017 04:04 PM, Eero Tamminen wrote: Hi, On 03.02.2017 19:23, Samuel Pitoiset wrote: This is similar to the MESA_GLSL_VERSION_OVERRIDE envvar (mainly for developers). But this one has the advantage to be configured for specific apps which require a context with an explicit version.

Re: [Mesa-dev] [RFC] EGL extension for additional DRM_BUFFER_FORMATs

2017-02-06 Thread Dave Airlie
> >> >> On 26.01.2017 12:50, Nicolai Hähnle wrote: >> > Hi all, >> > >> > this is mostly motivated by the need to support more screen depths than >> > just 24/32-bit RGB in Glamor. The extension is simple enough, just adding >> > three more enums that are accepted. >> > >> > I _think_ every DRI

Re: [Mesa-dev] Time to merge threaded GL dispatch? (aka glthread)

2017-02-06 Thread Marek Olšák
On Mon, Feb 6, 2017 at 8:20 PM, Ernst Sjöstrand wrote: > FYI glmark2 segfaults with mesa_glthread=true. Expected that some programs > will segfault? Yes, even segfaults are expected with mesa_glthread=true. Marek ___ mesa-dev mailing

Re: [Mesa-dev] [PATCH 14/34] gbm: Get modifiers from DRI

2017-02-06 Thread Daniel Stone
Hi, On 6 February 2017 at 19:22, Jason Ekstrand wrote: > On Sun, Feb 5, 2017 at 1:15 PM, Ben Widawsky wrote: >> Introducing the LINEAR modifier (which happened after v2 of this series) did >> make things complex because it's possible in some horrific

Re: [Mesa-dev] [PATCH RFC 3/3] egl: add support for EGL_MESA_drm_image_formats

2017-02-06 Thread Eric Anholt
Nicolai Hähnle writes: > From: Nicolai Hähnle > > XXX do we need a separate enable bit? I don't think so -- the driver can take a normal error path when asked to create an image, right? So, if you write some more commit message on this one, the

Re: [Mesa-dev] [PATCH 14/34] gbm: Get modifiers from DRI

2017-02-06 Thread Jason Ekstrand
On Sun, Feb 5, 2017 at 1:15 PM, Ben Widawsky wrote: > On 17-01-31 12:38:44, Jason Ekstrand wrote: > >> On Mon, Jan 23, 2017 at 10:21 PM, Ben Widawsky wrote: >> >> Replace the naive, 'save all the modifiers' with a proper query for just >>> the modifier that

Re: [Mesa-dev] Time to merge threaded GL dispatch? (aka glthread)

2017-02-06 Thread Ernst Sjöstrand
FYI glmark2 segfaults with mesa_glthread=true. Expected that some programs will segfault? ATTENTION: default value of option mesa_glthread overridden by environment. [New Thread 0x7fffed73d700 (LWP 23060)] _mesa_glthread_init === glmark2

Re: [Mesa-dev] [PATCH v3] gbm: Export a per plane getter for stride

2017-02-06 Thread Jason Ekstrand
On Sun, Feb 5, 2017 at 8:16 PM, Ben Widawsky wrote: > v2: Preserve legacy behavior when plane is 0 (Jason Ekstrand) > EINVAL when input plane is greater than total planes (Jason Ekstrand) > Don't leak the image after fromPlanar (Daniel) > Move bo->image check below plane count

Re: [Mesa-dev] Time to merge threaded GL dispatch? (aka glthread)

2017-02-06 Thread Eric Anholt
Marek Olšák writes: > Yes, I'm aware that glthread is far from perfect. However, I don't consider > that an issue. My idea is that the actual work will take place in master. I > have zero faith that any work on that will take place outside of master. Yeah. Now that there's

  1   2   >