[Mesa-dev] [PATCH 4/6] egl/drm: Use modifiers for backbuffer creation

Split into a separate patch from the previous patch as requested by Emil. Requeted-by: Emil Velikov Signed-off-by: Ben Widawsky --- src/egl/drivers/dri2/platform_drm.c | 19 +++ 1 file changed, 15 insertions(+), 4 deletions(-)

[Mesa-dev] [PATCH 1/6] dri: Add an image creation with modifiers

Modifiers will be obtained or guessed by the client and passed in during image creation/import. In guessing, a client might decide to simply pass along all known modifiers This requires bumping the DRIimage version. As of this patch, the modifiers aren't plumbed all the way down, this patch

[Mesa-dev] [PATCH 2/6] i965: Implement basic modifier image creation

This is just a stub for now and will be filled in later. This was split out of an earlier patch Requested-by: Emil Velikov Signed-off-by: Ben Widawsky --- src/mesa/drivers/dri/i965/intel_screen.c | 38 1 file

[Mesa-dev] [PATCH 3/6] gbm: Introduce modifiers into surface/bo creation

The idea behind modifiers like this is that the user of GBM will have some mechanism to query what properties the hardware supports for its BO or surface. This information is directly passed in (and stored) so that the DRI implementation can create an image with the appropriate attributes. A

[Mesa-dev] [PATCH 6/6] gbm: Export a get modifiers

This patch originally had i965 specific code and was named: commit 61cd3c52b868cf8cb90b06e53a382a921eb42754 Author: Ben Widawsky Date: Thu Oct 20 18:21:24 2016 -0700 gbm: Get modifiers from DRI To accomplish this, two new query tokens are added to the extension:

[Mesa-dev] [PATCH 5/6] i965: introduce modifier selection.

Nothing special here other than a brief introduction to modifier selection. Originally this was part of another patch but was split out from gbm: Introduce modifiers into surface/bo creation by request of Emil. Requested-by: Emil Velikov Signed-off-by: Ben Widawsky

Re: [Mesa-dev] [PATCH] radv: trivial tidy ups

Reviewed-by: Edward O'Callaghan On 03/14/2017 03:50 PM, Timothy Arceri wrote: > --- > src/amd/vulkan/radv_pipeline.c | 6 +- > src/amd/vulkan/radv_pipeline_cache.c | 1 + > 2 files changed, 2 insertions(+), 5 deletions(-) > > diff --git

[Mesa-dev] [PATCH] radv: trivial tidy ups

--- src/amd/vulkan/radv_pipeline.c | 6 +- src/amd/vulkan/radv_pipeline_cache.c | 1 + 2 files changed, 2 insertions(+), 5 deletions(-) diff --git a/src/amd/vulkan/radv_pipeline.c b/src/amd/vulkan/radv_pipeline.c index 723c32c..06e7446 100644 --- a/src/amd/vulkan/radv_pipeline.c +++

[Mesa-dev] [Bug 100073] Shader Disk Cache 32/64 bit detection has a flaw. Missed existence of x32 ABI

https://bugs.freedesktop.org/show_bug.cgi?id=100073 --- Comment #38 from Timothy Arceri --- This bug report is closed. Please stop spamming it. We have already discussed collisions on the mailing list [1] where these discussions belong.

[Mesa-dev] Lets try that again. Proposal for merging GL dispatch (aka glthread)

Hi all, There hasn't been any major comments on V2 of the series [1] so I'll assume that's a good thing. It seemed the biggest objection to not merging V1 was that some piglit tests were crashing, since that has been addressed I'm proposing we merge V2 as is. The only opposition to

Re: [Mesa-dev] [PATCH] gallium/tgsi: Treat UCMP sources as floats to match the GLSL-to-TGSI pass expectations.

On second thought, you're quite right this is inconsistent. Especially because the inputs must be "typeless" when there's no modifiers (the instruction is not allowed to alter bits of the sources like ordinary float instructions, since otherwise NaNs/denorms could get altered, which of course

[Mesa-dev] [Bug 100073] Shader Disk Cache 32/64 bit detection has a flaw. Missed existence of x32 ABI

https://bugs.freedesktop.org/show_bug.cgi?id=100073 --- Comment #37 from oia...@gmail.com --- (In reply to Marek Olšák from comment #36) > The build id and GPU id can be compared directly after the hash lookup and > decompression to prevent collisions when two shaders with different IDs have >

Re: [Mesa-dev] MESA and KOTOR

Looks like my KOTOR patch never made it to master. I'm attaching it below so you can try it. I should commit it master. In any case, let me know if it helps. -Brian On 03/13/2017 10:55 AM, Federico Dossena wrote: Hi Jose, thanks for replying, I've seen your name inside many files in mesa

[Mesa-dev] [PATCH] nir: Rewrite nir_type_conversion_op

The original version was very convoluted and tried way too hard to not just have the nested switch statement that it needs. Let's just write the obvious code and then we know it's correct. This fixes a bunch of missing cases particularly with int64. --- This patch has to be inserted before the

[Mesa-dev] [PATCH v2 15/18] anv: Pull the guts of cmd_buffer_execbuf into a helper

--- src/intel/vulkan/anv_batch_chain.c | 55 +- 1 file changed, 31 insertions(+), 24 deletions(-) diff --git a/src/intel/vulkan/anv_batch_chain.c b/src/intel/vulkan/anv_batch_chain.c index e5cc21d..c55938a 100644 --- a/src/intel/vulkan/anv_batch_chain.c +++

[Mesa-dev] [PATCH v2 12/18] anv: Implement VK_KHX_external_semaphore_capabilities

This just stubs things out. Real external semaphore support will come with VK_KHX_external_semaphore_fd. --- src/intel/vulkan/anv_device.c | 4 src/intel/vulkan/anv_entrypoints_gen.py | 1 + src/intel/vulkan/anv_queue.c| 13 + 3 files changed, 18

[Mesa-dev] [PATCH v2 13/18] anv: Implement VK_KHX_external_semaphore

--- src/intel/vulkan/anv_device.c | 4 src/intel/vulkan/anv_entrypoints_gen.py | 1 + src/intel/vulkan/anv_queue.c| 8 3 files changed, 13 insertions(+) diff --git a/src/intel/vulkan/anv_device.c b/src/intel/vulkan/anv_device.c index 3674029..e9d919d 100644

[Mesa-dev] [PATCH v2 17/18] anv/gem: Use EXECBUFFER2_WR when the FENCE_OUT flag is set

--- src/intel/vulkan/anv_gem.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/intel/vulkan/anv_gem.c b/src/intel/vulkan/anv_gem.c index 0dde6d9..d8beab1 100644 --- a/src/intel/vulkan/anv_gem.c +++ b/src/intel/vulkan/anv_gem.c @@ -168,7 +168,10 @@ int

[Mesa-dev] [PATCH v2 14/18] anv/cmd_buffer: Use the device allocator for QueueSubmit

The command is really operating on a Queue not a command buffer and the nearest object to that with an allocator is VkDevice. Cc: "17.0" --- src/intel/vulkan/anv_batch_chain.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git

[Mesa-dev] [PATCH v2 08/18] anv: Use the BO cache for DeviceMemory allocations

--- src/intel/vulkan/anv_device.c | 27 --- src/intel/vulkan/anv_image.c | 2 +- src/intel/vulkan/anv_intel.c | 14 ++ src/intel/vulkan/anv_private.h | 4 +++- src/intel/vulkan/anv_wsi.c | 6 +++--- 5 files changed, 29 insertions(+), 24 deletions(-)

[Mesa-dev] [PATCH v2 18/18] anv: Implement support for exporting semaphores as FENCE_FD

--- src/intel/vulkan/anv_batch_chain.c | 86 -- src/intel/vulkan/anv_device.c | 26 src/intel/vulkan/anv_gem.c | 36 src/intel/vulkan/anv_private.h | 24 --- src/intel/vulkan/anv_queue.c | 61

[Mesa-dev] [PATCH v2 16/18] anv: Implement VK_KHX_external_semaphore_fd

This implementation allocates a 4k BO for each semaphore that can be exported using OPAQUE_FD and uses the kernel's already-existing synchronization mechanism on BOs. --- src/intel/vulkan/anv_batch_chain.c | 44 +-- src/intel/vulkan/anv_device.c | 4 +

[Mesa-dev] [PATCH v2 11/18] anv: Add a real semaphore struct

It's just a dummy for now, but we'll flesh it out as needed for external semaphores. --- src/intel/vulkan/anv_private.h | 28 src/intel/vulkan/anv_queue.c | 32 ++-- 2 files changed, 54 insertions(+), 6 deletions(-) diff --git

[Mesa-dev] [PATCH v2 10/18] anv: Move queues, events, and semaphores to their own file

Things are about to get more complicated, especially as far as semaphores are concerned. --- src/intel/Makefile.sources| 1 + src/intel/vulkan/Makefile.sources | 86 +++ src/intel/vulkan/anv_device.c | 440 --- src/intel/vulkan/anv_queue.c |

[Mesa-dev] [PATCH v2 09/18] anv: Implement VK_KHX_external_memory_fd

v2 (chadv): - Rebase. - Fix vkGetPhysicalDeviceImageFormatProperties2KHR when handleType == 0. - Move handleType-independency comments out of handleType-switch, in vkGetPhysicalDeviceExternalBufferPropertiesKHX. Reduces diff in future dma_buf patches. Co-authored-with: Chad

[Mesa-dev] [PATCH v2 07/18] anv/allocator: Add a BO cache

This cache allows us to easily ensure that we have a unique anv_bo for each gem handle. We'll need this in order to support multiple-import of memory objects and semaphores. --- src/intel/vulkan/anv_allocator.c | 212 +++ src/intel/vulkan/anv_private.h | 26

[Mesa-dev] [PATCH v2 02/18] anv: Refactor device_get_cache_uuid into physical_device_init_uuids

--- src/intel/vulkan/anv_device.c | 31 +-- 1 file changed, 17 insertions(+), 14 deletions(-) diff --git a/src/intel/vulkan/anv_device.c b/src/intel/vulkan/anv_device.c index 5db0a6c..13c1c50 100644 --- a/src/intel/vulkan/anv_device.c +++

[Mesa-dev] [PATCH v2 03/18] anv/physical_device: Rename uuid to pipeline_cache_uuid

We're about to have more UUIDs for different things so this one really needs to be properly labeled. --- src/intel/vulkan/anv_device.c | 5 +++-- src/intel/vulkan/anv_pipeline_cache.c | 4 ++-- src/intel/vulkan/anv_private.h| 2 +- 3 files changed, 6 insertions(+), 5 deletions(-)

[Mesa-dev] [PATCH v2 01/18] anv: Add the pci_id into the shader cache UUID

This prevents a user from using a cache created on one hardware generation on a different one. Of course, with Intel hardware, this requires moving their drive from one machine to another but it's still possible and we should prevent it. Reviewed-by: Chad Versace ---

[Mesa-dev] [PATCH v2 05/18] anv: Implement VK_KHX_external_memory_capabilities

From: Chad Versace This is a complete but trivial implementation. It's trivial becasue We support no external memory capabilities yet. Most of the real work in this commit is in reworking the UUIDs advertised by the driver. v2 (chadv): - Fix chain traversal in

[Mesa-dev] [PATCH v2 06/18] anv: Implement VK_KHX_external_memory

There's really nothing for us to do here. So long as the user doesn't set any crazy environment variables such as INTEL_VK_HIZ=false, all of the compression formats etc. should "just work" at least for opaque handle types. --- src/intel/vulkan/anv_device.c | 6 +-

[Mesa-dev] [PATCH v2 00/18] anv: Implement VK_KHX_external_*

This series is a second revision on my earlier two series to implement the following extensions: - VK_KHX_external_memory_capabilities - VK_KHX_external_memory - VK_KHX_external_memory_fd - VK_KHX_external_semaphore_capabilities - VK_KHX_external_semaphore - VK_KHX_external_semaphore_fd

[Mesa-dev] [PATCH v2 04/18] util/vk: Add helpers for finding an extension struct

--- src/util/vk_util.h | 17 + 1 file changed, 17 insertions(+) diff --git a/src/util/vk_util.h b/src/util/vk_util.h index e0b5d0b..0b9cb47 100644 --- a/src/util/vk_util.h +++ b/src/util/vk_util.h @@ -40,4 +40,21 @@ struct vk_struct_common { for (const struct vk_struct_common

[Mesa-dev] [PATCH 1/5] util/disk_cache: seed rand

Otherwise we will always remove old cache entries from the same dirs. --- src/util/disk_cache.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/util/disk_cache.c b/src/util/disk_cache.c index 2a1024a..dc65d52 100644 --- a/src/util/disk_cache.c +++ b/src/util/disk_cache.c @@ -402,20

[Mesa-dev] [PATCH 2/5] util/disk_cache: don't fallback to an empty cache dir on evict

If we fail to randomly select a two letter cache dir, don't select an empty dir on fallback. In real world use we should never hit the fallback path but it can be hit by tests when the cache is set to a very small max value. --- src/util/disk_cache.c | 33 +++-- 1

[Mesa-dev] [PATCH 4/5] util/disk_cache: actually enforce cache size

From: Alan Swanson Currently only a one in one out eviction so if at max_size and cache files were to constantly increase in size then so would the cache. Restrict to limit of 8 evictions per new cache entry. V2: (Timothy Arceri) fix make check tests ---

[Mesa-dev] [PATCH 5/5] util/disk_cache: scale cache according to filesystem size

From: Alan Swanson Select higher of current 1G default or 10% of filesystem where cache is located. Acked-by: Timothy Arceri --- src/util/disk_cache.c | 11 --- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git

[Mesa-dev] [PATCH 3/5] util/disk_cache: use LRU eviction rather than random eviction

From: Alan Swanson Still using fast random selection of two-character subdirectory in which to check cache files rather than scanning entire cache. v2: Factor out double strlen call v3: C99 declaration of variables where used Reviewed-by: Grazvydas Ignotas

[Mesa-dev] [PATCH V3] util/disk_cache: use a thread queue to write to shader cache

This should help reduce any overhead added by the shader cache when programs are not found in the cache. To avoid creating any special function just for the sake of the tests we add a one second delay whenever we call dick_cache_put() to give it time to finish. V2: poll for file when waiting for

Re: [Mesa-dev] [PATCH 2/3] gbm: Introduce modifiers into surface/bo creation

On 17-03-10 11:32:35, Emil Velikov wrote: On 10 March 2017 at 01:48, Ben Widawsky wrote: The idea behind modifiers like this is that the user of GBM will have some mechanism to query what properties the hardware supports for its BO or surface. This information is directly

[Mesa-dev] [PATCH] gallium/tgsi: Treat UCMP sources as floats to match the GLSL-to-TGSI pass expectations.

Currently the GLSL-to-TGSI translation pass assumes it can use floating point source modifiers on the UCMP instruction. See the bug report linked below for an example where an unrelated change in the GLSL built-in lowering code for atan2 (e9ffd12827ac11a2d2002a42fa8eb1) caused the generation of

Re: [Mesa-dev] [PATCH] anv/blorp: Only set a clear color for resolves if fast-cleared

On Mon, Mar 13, 2017 at 5:34 PM, Emil Velikov wrote: > On 13 March 2017 at 19:08, Jason Ekstrand wrote: > > On Mon, Mar 13, 2017 at 11:19 AM, Emil Velikov > > > wrote: > >> > >> On 5 March 2017 at 16:36, Eduardo Lima

[Mesa-dev] [PATCH V2] util/disk_cache: use a thread queue to write to shader cache

This should help reduce any overhead added by the shader cache when programs are not found in the cache. To avoid creating any special function just for the sake of the tests we add a one second delay whenever we call dick_cache_put() to give it time to finish. V2: poll for file when waiting for

Re: [Mesa-dev] [PATCH 2/3] gbm: Introduce modifiers into surface/bo creation

On 17-03-09 18:52:52, Jason Ekstrand wrote: On Thu, Mar 9, 2017 at 5:48 PM, Ben Widawsky wrote: The idea behind modifiers like this is that the user of GBM will have some mechanism to query what properties the hardware supports for its BO or surface. This information is

Re: [Mesa-dev] MESA and KOTOR

Hi Jose, thanks for replying, I've seen your name inside many files in mesa ;) I have tried mesa master (previously I was using 17.0.1) but it still crashes for the same null pointer. Do you have a link to that patch you've mentioned for kotor? I have used apitrace and took traces of both

Re: [Mesa-dev] [PATCH] Convert sed(1) syntax to be compatible with FreeBSD and OpenBSD

Eric Engestrom writes: > On Monday, 2017-03-13 11:56:45 +, Jan Beich wrote: > >> Eric Engestrom writes: >> >> >> +echo " `$1`" | sed -E \ >> >> +-e 's/[[[:space:]]]+-m[[^[:space:]]]*//g' \ [...] >> Do you want me to quote

Re: [Mesa-dev] MESA and KOTOR

If I put printf("HELLO MESA\n"); into wglGetProcAddress it prints it, so some code from Mesa is certainly being executed. The reason why I suspect that I have a windows dll loaded is that when it calls wglGetProcAddress("wglMakeContextCurrentARB") it seems to be inside a small DLL, while mesa

[Mesa-dev] [PATCH] drm-atomic: Include header file

Include header file to fix the following build error: drm-atomic.c: In function ‘get_plane_id’: drm-atomic.c:290:44: error: ‘DRM_MODE_OBJECT_PLANE’ undeclared (first use in this function) drmModeObjectGetProperties(drm.fd, id, DRM_MODE_OBJECT_PLANE); This error only happens when using a

Re: [Mesa-dev] [PATCH] Convert sed(1) syntax to be compatible with FreeBSD and OpenBSD

Eric Engestrom writes: >> +echo " `$1`" | sed -E \ >> +-e 's/[[[:space:]]]+-m[[^[:space:]]]*//g' \ > > These only work for me if I remove the outermost `[]` on each line, > leaving one pair around `:space:` and one for the set. > The above line, for

Re: [Mesa-dev] [PATCH v2 3/3] util/sha1: drop _mesa_sha1_{update, format} return type

On Tue, Mar 14, 2017 at 2:28 AM, Emil Velikov wrote: > On 13 March 2017 at 22:38, Grazvydas Ignotas wrote: >> On Mon, Mar 13, 2017 at 6:52 PM, Emil Velikov >> wrote: >>> ... >>> diff --git a/src/util/mesa-sha1.h

Re: [Mesa-dev] [PATCH] anv/blorp: Only set a clear color for resolves if fast-cleared

On 13 March 2017 at 19:08, Jason Ekstrand wrote: > On Mon, Mar 13, 2017 at 11:19 AM, Emil Velikov > wrote: >> >> On 5 March 2017 at 16:36, Eduardo Lima Mitev wrote: >> > Reviewed-by: Eduardo Lima Mitev >> > >>

Re: [Mesa-dev] [PATCH 2/3] gbm: Introduce modifiers into surface/bo creation

On 17-03-10 11:34:19, Jason Ekstrand wrote: On Thu, Mar 9, 2017 at 6:52 PM, Jason Ekstrand wrote: On Thu, Mar 9, 2017 at 5:48 PM, Ben Widawsky wrote: The idea behind modifiers like this is that the user of GBM will have some mechanism to query what

Re: [Mesa-dev] [PATCH v2 3/3] util/sha1: drop _mesa_sha1_{update, format} return type

On 13 March 2017 at 22:38, Grazvydas Ignotas wrote: > On Mon, Mar 13, 2017 at 6:52 PM, Emil Velikov > wrote: >> ... >> diff --git a/src/util/mesa-sha1.h b/src/util/mesa-sha1.h >> index f927d5772d..ecbc708b5e 100644 >> --- a/src/util/mesa-sha1.h >>

[Mesa-dev] [PATCH] android: intel/compiler: fix include paths

Fixes the following building error: out/target/product/x86_64/obj_x86/STATIC_LIBRARIES/libmesa_intel_compiler_intermediates/compiler/brw_nir_trig_workarounds.c:1:10: fatal error: 'brw_nir.h' file not found ^ 1 error generated. Fixes: 700bebb "i965: Move the back-end compiler to

Re: [Mesa-dev] [PATCH] radv: setup llvm target data layout

Reviewed-by: Bas Nieuwenhuizen On Mon, Mar 13, 2017 at 9:52 PM, Dave Airlie wrote: > From: Dave Airlie > > Ported from radeonsi, pointed out by Tom. > > "This prevents LLVM from using sext instructions for local memory > offsets

Re: [Mesa-dev] [PATCH 3/4] util/disk_cache: have disk_cache_put() optionally free memory

On 13/03/17 21:16, Grazvydas Ignotas wrote: On Mon, Mar 13, 2017 at 3:01 AM, Timothy Arceri wrote: The following patch will move disk_cache_put() into a thread queue so we need to be sure memory is not freed before the thread is completed. Here we move responsibility

Re: [Mesa-dev] [PATCH 4/4] util/disk_cache: use a thread queue to write to shader cache

On Tue, Mar 14, 2017 at 12:20 AM, Timothy Arceri wrote: > > > On 13/03/17 22:53, Grazvydas Ignotas wrote: >> >> On Mon, Mar 13, 2017 at 3:01 AM, Timothy Arceri >> wrote: >>> >>> This should help reduce any overhead added by the shader cache >>> when

Re: [Mesa-dev] [PATCH] radv: Reinitialise loaderMagic when allocating a cached command buffer

Thanks. Pushed. - Bas On Mon, Mar 13, 2017 at 2:28 PM, Alex Smith wrote: > This must be set to ICD_LOADER_MAGIC by vkAllocateCommandBuffers, which > was being done when allocating a new buffer but not when reusing an > existing one in the cache. This would hit an

Re: [Mesa-dev] [PATCH 2/4] util/disk_cache: add helpers for creating/destroying disk cache put jobs

On Tue, Mar 14, 2017 at 12:06 AM, Timothy Arceri wrote: > On 13/03/17 22:55, Grazvydas Ignotas wrote: >> >> On Mon, Mar 13, 2017 at 3:01 AM, Timothy Arceri >> wrote: >>> >>> --- >>> src/util/disk_cache.c | 48 >>>

Re: [Mesa-dev] [PATCH v2 3/3] util/sha1: drop _mesa_sha1_{update, format} return type

On Mon, Mar 13, 2017 at 6:52 PM, Emil Velikov wrote: > ... > diff --git a/src/util/mesa-sha1.h b/src/util/mesa-sha1.h > index f927d5772d..ecbc708b5e 100644 > --- a/src/util/mesa-sha1.h > +++ b/src/util/mesa-sha1.h > @@ -34,7 +34,7 @@ extern "C" { > > #define

Re: [Mesa-dev] [PATCH] radv: setup llvm target data layout

On Tue, Mar 14, 2017 at 06:52:19AM +1000, Dave Airlie wrote: > From: Dave Airlie > > Ported from radeonsi, pointed out by Tom. > > "This prevents LLVM from using sext instructions for local memory > offsets and allows the backend to fold immediate offsets into the >

Re: [Mesa-dev] [PATCH] android: i965: generate code for OA counter queries

2017-03-13 14:00 GMT+01:00 Emil Velikov : > On 12 March 2017 at 23:01, Mauro Rossi wrote: > > Automake generation rules are replicated for android. > > $* macro was expected to return "hsw" but instead gives "hsw.{h,c}" > > so $(basename $*) is

[Mesa-dev] [PATCH 4/7] isl: Validate the calculated row pitch

Validate that it fits in RENDER_SURFACE_STATE::SurfacePitch or, if it's an aux surface, AuxiliarySurfacePitch. --- src/intel/isl/isl.c | 35 +-- 1 file changed, 29 insertions(+), 6 deletions(-) diff --git a/src/intel/isl/isl.c b/src/intel/isl/isl.c index

[Mesa-dev] [PATCH 1/7] isl: Drop misplaced comment about padding

isl has a giant comment that explains the hardware's padding requirements. (Hint: Cache lines and page faults). But the comment is in the wrong place, in isl_calc_linear_row_pitch(), which is unrelated to padding. The important parts of that comment were copied to isl_apply_surface_padding() long

[Mesa-dev] [PATCH 3/7] isl: Add func isl_tiling_is_aux()

--- src/intel/isl/isl.h | 9 + 1 file changed, 9 insertions(+) diff --git a/src/intel/isl/isl.h b/src/intel/isl/isl.h index 9d92906ca71..b79793b0c93 100644 --- a/src/intel/isl/isl.h +++ b/src/intel/isl/isl.h @@ -473,6 +473,9 @@ typedef uint32_t isl_tiling_flags_t; /** The Skylake BSpec

[Mesa-dev] [PATCH 5/7] isl: Let isl_surf_init's caller set the exact row pitch (v2)

The caller does so by setting the new field isl_surf_init_info::row_pitch. v2: - Validate the requested row_pitch. --- src/intel/isl/isl.c | 14 +- src/intel/isl/isl.h | 6 ++ 2 files changed, 19 insertions(+), 1 deletion(-) diff --git a/src/intel/isl/isl.c

[Mesa-dev] [PATCH 6/7] intel: Fix requests for exact surface row pitch

All callers of isl_surf_init() that set 'min_row_pitch' wanted to request an *exact* row pitch, as evidenced by nearby asserts, but isl lacked API for doing so. Now that isl has an API for that, update the code to use it. Reviewed-by: Nanley Chery Reviewed-by: Anuj

[Mesa-dev] [PATCH 7/7] isl: Drop unused isl_surf_init_info::min_pitch

Reviewed-by: Nanley Chery Reviewed-by: Anuj Phogat --- src/intel/isl/isl.c | 13 +++-- src/intel/isl/isl.h | 3 --- 2 files changed, 3 insertions(+), 13 deletions(-) diff --git a/src/intel/isl/isl.c b/src/intel/isl/isl.c index

[Mesa-dev] [PATCH 2/7] isl: Refactor row pitch calculation (v2)

The calculations of row_pitch, the row pitch's alignment, surface size, and base_alignment were mixed together. This patch moves the calculation of row_pitch and its alignment to occur before the calculation of surface_size and base_alignment. This simplifies a follow-on patch that adds a new

[Mesa-dev] [PATCH 0/6] isl: Fix requests for exact row pitch (v2)

All callers of isl_surf_init() that set 'min_pitch' wanted to request an *exact* row pitch, as evidenced by nearby asserts, but isl lacked API for doing so. This series fixes that by adding a field, isl_surf_init_info::row_pitch. This prepares for VK_MESAX_external_image_dma_buf, which requires

Re: [Mesa-dev] [PATCH 4/4] util/disk_cache: use a thread queue to write to shader cache

On 13/03/17 22:53, Grazvydas Ignotas wrote: On Mon, Mar 13, 2017 at 3:01 AM, Timothy Arceri wrote: This should help reduce any overhead added by the shader cache when programs are not found in the cache. To avoid creating any special function just for the sake of the

Re: [Mesa-dev] [PATCH 2/3] anv: Use vk_outarray in vkEnumeratePhysicalDevices

On Mon 13 Mar 2017, Chad Versace wrote: > On Mon 13 Mar 2017, Jason Ekstrand wrote: > > On Mon, Mar 13, 2017 at 2:32 PM, Jason Ekstrand > > wrote: > > > > > On Mon, Mar 13, 2017 at 2:23 PM, Chad Versace > > > wrote: > > > > > >> No intended change

Re: [Mesa-dev] [PATCH 2/3] anv: Use vk_outarray in vkEnumeratePhysicalDevices

On Mon 13 Mar 2017, Jason Ekstrand wrote: > On Mon, Mar 13, 2017 at 2:32 PM, Jason Ekstrand > wrote: > > > On Mon, Mar 13, 2017 at 2:23 PM, Chad Versace > > wrote: > > > >> No intended change in behavior. Just a refactor. > >> --- > >>

Re: [Mesa-dev] [PATCH 2/4] util/disk_cache: add helpers for creating/destroying disk cache put jobs

On 13/03/17 22:55, Grazvydas Ignotas wrote: On Mon, Mar 13, 2017 at 3:01 AM, Timothy Arceri wrote: --- src/util/disk_cache.c | 48 1 file changed, 48 insertions(+) diff --git a/src/util/disk_cache.c

Re: [Mesa-dev] [PATCH] [RFC] clover: flush event queue when sequencing new event

Vedran Miletić writes: > OpenMM holds events created during runtime in the queue and destroys > them at the end, which causes a stack overflow in nontrivial examples. Did you manange to get a backtrace? > This patch forces flushing of the event queue and destruction of >

Re: [Mesa-dev] [PATCH 1/3] dri: Add an image creation with modifiers

On 17-03-10 10:28:42, Emil Velikov wrote: Hi Ben, Mostly pointing out a few things that look strange, pardon if some seem too pedantic. On 10 March 2017 at 01:48, Ben Widawsky wrote: --- include/GL/internal/dri_interface.h | 27 ++- Split the

Re: [Mesa-dev] MESA and KOTOR

On Mon, 2017-03-13 at 11:40 +0200, Grazvydas Ignotas wrote: > On Sat, Mar 11, 2017 at 1:51 PM, Federico Dossena > wrote: > > This issue is not new: a guy named Miklós Máté, here in the Mesa mailing > > list somehow managed to fix it in Mesa 11, but his patches do not seem

Re: [Mesa-dev] [PATCH 2/3] anv: Use vk_outarray in vkEnumeratePhysicalDevices

On Mon, Mar 13, 2017 at 2:32 PM, Jason Ekstrand wrote: > On Mon, Mar 13, 2017 at 2:23 PM, Chad Versace > wrote: > >> No intended change in behavior. Just a refactor. >> --- >> src/intel/vulkan/anv_device.c | 32 ++-- >>

Re: [Mesa-dev] [PATCH 2/3] anv: Use vk_outarray in vkEnumeratePhysicalDevices

On Mon, Mar 13, 2017 at 2:23 PM, Chad Versace wrote: > No intended change in behavior. Just a refactor. > --- > src/intel/vulkan/anv_device.c | 32 ++-- > 1 file changed, 6 insertions(+), 26 deletions(-) > > diff --git

Re: [Mesa-dev] [PATCH 1/3] dri: Add an image creation with modifiers

On 17-03-09 18:38:15, Jason Ekstrand wrote: On Thu, Mar 9, 2017 at 5:48 PM, Ben Widawsky wrote: Modifiers will be obtains or guessed by the client and passed in during "obtained" Got it. image creation/import. This requires bumping the DRIimage version. As of

[Mesa-dev] [PATCH 0/3] anv: Add an vk_outarray_append() macro (v2)

The macro vk_outarray_append() deduplicates a lot of nit-picky boilerplate code. It appends to a Vulkan output array, handling null pointers and overflow correctly. (A Vulkan output array, as I'm using the term, is one that follows the convention of the parameters to

[Mesa-dev] [PATCH 2/3] anv: Use vk_outarray in vkEnumeratePhysicalDevices

No intended change in behavior. Just a refactor. --- src/intel/vulkan/anv_device.c | 32 ++-- 1 file changed, 6 insertions(+), 26 deletions(-) diff --git a/src/intel/vulkan/anv_device.c b/src/intel/vulkan/anv_device.c index f04e11e..35c5a4645ff 100644 ---

[Mesa-dev] [PATCH 1/3] util/vulkan: Add vk_outarray

This is a wrapper for a Vulkan output array. A Vulkan output array is one that follows the convention of the parameters to vkGetPhysicalDeviceQueueFamilyProperties(). --- src/util/vk_util.h | 140 + 1 file changed, 140 insertions(+) diff --git

[Mesa-dev] [PATCH 3/3] anv: Use vk_outarray in vkGetPhysicalDeviceQueueFamilyProperties

No intended change in behavior. Just a refactor. --- src/intel/vulkan/anv_device.c | 73 +++ 1 file changed, 18 insertions(+), 55 deletions(-) diff --git a/src/intel/vulkan/anv_device.c b/src/intel/vulkan/anv_device.c index 35c5a4645ff..21130feac82 100644

Re: [Mesa-dev] [PATCH 1/3] anv: Add anv_outarray

On Wed 08 Mar 2017, Chad Versace wrote: > On Mon 06 Mar 2017, Jason Ekstrand wrote: > > On Mon, Mar 6, 2017 at 10:25 AM, Chad Versace > > wrote: > > > > > anv_outarray is a wrapper for a Vulkan output array. A Vulkan output > > > array is one that follows the convention

[Mesa-dev] [PATCH] radv: setup llvm target data layout

From: Dave Airlie Ported from radeonsi, pointed out by Tom. "This prevents LLVM from using sext instructions for local memory offsets and allows the backend to fold immediate offsets into the instruction. This also prevents some incorrect code generation for ptrtoint and

[Mesa-dev] [Bug 77449] Tracker bug for all bugs related to Steam titles

https://bugs.freedesktop.org/show_bug.cgi?id=77449 Bug 77449 depends on bug 84663, which changed state. Bug 84663 Summary: high cpu usage, poor performance in Borderlands 2 with radeonsi, PRIME https://bugs.freedesktop.org/show_bug.cgi?id=84663 What|Removed

[Mesa-dev] [PATCH] [RFC] clover: flush event queue when sequencing new event

OpenMM holds events created during runtime in the queue and destroys them at the end, which causes a stack overflow in nontrivial examples. This patch forces flushing of the event queue and destruction of events which are CL_COMPLETE. I am pretty sure this isn't the nicest solution and probably

Re: [Mesa-dev] [PATCH 0/3] GBM modifier plumbing

Hi, On Mon, 13 Mar 2017 at 7:08 pm, Jason Ekstrand wrote: > On Mon, Mar 13, 2017 at 11:53 AM, Kristian H. Kristensen < > k...@bitplanet.net> wrote: > > Daniel Stone writes: > > > I guess it depends on how much asymmetry there is between texture and >

Re: [Mesa-dev] [PATCH kmscube] drm-common.h: forward-declare needed structs

On 13 March 2017 at 17:14, Eric Engestrom wrote: > drm-common.h:63:49: warning: ‘struct egl’ declared inside parameter list will > not be > visible outside of this definition or declaration > int (*run)(const struct gbm *gbm, const struct egl *egl); >

Re: [Mesa-dev] [PATCH] anv/blorp: Only set a clear color for resolves if fast-cleared

On Mon, Mar 13, 2017 at 11:19 AM, Emil Velikov wrote: > On 5 March 2017 at 16:36, Eduardo Lima Mitev wrote: > > Reviewed-by: Eduardo Lima Mitev > > > > On 03/04/2017 01:56 AM, Jason Ekstrand wrote: > >> Cc: "17.0"

Re: [Mesa-dev] [PATCH 0/3] GBM modifier plumbing

On Mon, Mar 13, 2017 at 11:53 AM, Kristian H. Kristensen wrote: > Daniel Stone writes: > > > Hey Kristian, > > > > On 13 March 2017 at 17:31, Kristian H. Kristensen > wrote: > >> Jason Ekstrand writes: > >>> I

Re: [Mesa-dev] [PATCH 0/3] GBM modifier plumbing

Daniel Stone writes: > Hey Kristian, > > On 13 March 2017 at 17:31, Kristian H. Kristensen wrote: >> Jason Ekstrand writes: >>> I was talking to Daniel today and I think we also need another some sort of >>> GL or GBM api that

Re: [Mesa-dev] [PATCH] anv/blorp: Only set a clear color for resolves if fast-cleared

On 5 March 2017 at 16:36, Eduardo Lima Mitev wrote: > Reviewed-by: Eduardo Lima Mitev > > On 03/04/2017 01:56 AM, Jason Ekstrand wrote: >> Cc: "17.0" >> --- >> src/intel/vulkan/anv_blorp.c | 3 ++- >> 1 file changed, 2

Re: [Mesa-dev] [PATCH v3 4/6] i965/fs: Re-arrange conversion operations

On Mon, Mar 13, 2017 at 09:18:13AM -0700, Jason Ekstrand wrote: > --- > src/intel/compiler/brw_fs_nir.cpp | 67 > ++- > 1 file changed, 31 insertions(+), 36 deletions(-) Reviewed-by: Topi Pohjolainen > > diff --git

Re: [Mesa-dev] Mesa 17.0.1 release candidate

On Mon, Mar 13, 2017 at 2:13 PM, Matt Turner wrote: > I think Bcc'ing also means my gmail filters wouldn't know it came from > the announce list. listid:mesa-announce.freedesktop.org should pick it up - even though it's bcc'd, the mailing list distribution logic should still

Re: [Mesa-dev] [PATCH 0/3] GBM modifier plumbing

Hey Kristian, On 13 March 2017 at 17:31, Kristian H. Kristensen wrote: > Jason Ekstrand writes: >> I was talking to Daniel today and I think we also need another some sort of >> GL or GBM api that gives you the modifiers supported for >>

Re: [Mesa-dev] Mesa 17.0.1 release candidate

On Mon, Mar 13, 2017 at 2:04 AM, Michel Dänzer wrote: > On 03/03/17 11:53 AM, Michel Dänzer wrote: >> On 03/03/17 03:38 AM, Matt Turner wrote: >>> On Wed, Mar 1, 2017 at 7:44 PM, Michel Dänzer wrote: P.S. It would be better to put the mesa-announce

[Mesa-dev] [Bug 99467] [radv] DOOM 2016 + wine. Green screen everywhere (but can be started)

https://bugs.freedesktop.org/show_bug.cgi?id=99467 --- Comment #20 from Vedran Miletić --- (In reply to Sebastian Jug from comment #19) > I would like to see these patches go mainline as well so we can all play. I believe the issue is whether Doom Vulkan implementation

Re: [Mesa-dev] [PATCH] android: i965: generate code for OA counter queries

Acked-by: Robert Bragg On Sun, Mar 12, 2017 at 11:01 PM, Mauro Rossi wrote: > Automake generation rules are replicated for android. > $* macro was expected to return "hsw" but instead gives "hsw.{h,c}" > so $(basename $*) is used as a workaround > to

  1   2   3   >