Re: [Mesa-dev] [PATCH 4/8] intel/compiler: More peephole select

2018-06-06 Thread Ian Romanick
On 06/06/2018 05:39 PM, Ian Romanick wrote: > On 06/06/2018 04:26 PM, Matt Turner wrote: >> On Wed, Jun 6, 2018 at 2:33 PM, Ian Romanick wrote: >>> From: Ian Romanick >>> >>> Shader-db results: >>> >>> Skylake and Broadwell had similar results. (Skylake shown) >>> total instructions in shared

[Mesa-dev] [PATCH v2 02/22] i965/fs: Implement float64/int64 to float16 conversion

2018-06-06 Thread Samuel Iglesias Gonsálvez
It is not supported directly in the HW, we need to convert to a 32-bit type first as intermediate step. v2 (Iago): handle conversions from 64-bit integers as well Signed-off-by: Samuel Iglesias Gonsálvez --- Added missing (u)int64 -> fp16 conversion and fixed issues with the fallthroughs.

Re: [Mesa-dev] [PATCH 00/16] Move the Mesa Website to Sphinx

2018-06-06 Thread Stuart Young
I see that the theme and logo is now on the test site! All looks good. As a test, I threw the site at WebSiteTest, Pingdom, GTMetrix and Google PageSpeed Insights and all came back with great results. There's a few things like client caching times of static resources like css/js/tff/woff/etc and

Re: [Mesa-dev] [PATCH v2] intel/blorp: Emit VF cache invalidates for 48-bit bugs with softpin.

2018-06-06 Thread Kenneth Graunke
On Wednesday, June 6, 2018 6:39:19 PM PDT Kenneth Graunke wrote: > +/** > + * See vf_invalidate_for_vb_48b_transitions in genX_state_upload.c. > + */ > +static void > +blorp_vf_invalidate_for_vb_48b_transitions(struct blorp_batch *batch, > + const struct

Re: [Mesa-dev] [PATCH mesa] vma/tests: cast away implementation detail of using strtoul()

2018-06-06 Thread Dylan Baker
Yeah, Scott and I thought that went to the list before I did an offer the shoulder review, then realized it didn't after pushing. On June 6, 2018 10:31:38 AM PDT, Eric Anholt wrote: >Eric Engestrom writes: > >> On MacOS, the build fails because of a compiler complaint about >> a downcast: >>

Re: [Mesa-dev] [PATCH v2] intel/blorp: Emit VF cache invalidates for 48-bit bugs with softpin.

2018-06-06 Thread Jason Ekstrand
On Wed, Jun 6, 2018 at 6:39 PM, Kenneth Graunke wrote: > commit 92f01fc5f914fd500497d0c3aed75f3ac8dc054d made i965 start emitting > VF cache invalidates when the high bits of vertex buffers change. But > we were not tracking vertex buffers emitted by BLORP. This was papered > over by a mistake

[Mesa-dev] [PATCH v2] intel/blorp: Emit VF cache invalidates for 48-bit bugs with softpin.

2018-06-06 Thread Kenneth Graunke
commit 92f01fc5f914fd500497d0c3aed75f3ac8dc054d made i965 start emitting VF cache invalidates when the high bits of vertex buffers change. But we were not tracking vertex buffers emitted by BLORP. This was papered over by a mistake where I emitted VF cache invalidates all the time, which Chris

Re: [Mesa-dev] [PATCH 1/2] nir: add pass to move load_const

2018-06-06 Thread Rob Clark
On Wed, Jun 6, 2018 at 8:34 PM, Ian Romanick wrote: > On 06/06/2018 04:47 PM, Rob Clark wrote: >> On Wed, Jun 6, 2018 at 6:51 PM, Ian Romanick wrote: >>> On 06/06/2018 07:43 AM, Rob Clark wrote: Run this pass late (after opt loop) to move load_const instructions back into the basic

Re: [Mesa-dev] [PATCH 2/2] nir: add opt_if_loop_terminator()

2018-06-06 Thread Ian Romanick
On 06/03/2018 11:30 PM, Timothy Arceri wrote: > On 02/06/18 04:34, Ian Romanick wrote: > >> On 05/31/2018 10:37 PM, Timothy Arceri wrote: >>> This pass detects potential loop terminators and moves intructions >>> from the non breaking branch after the if. >>> >>> This enables both the new

[Mesa-dev] [PATCH] radeonsi: fix possible truncation on renderer string

2018-06-06 Thread Timothy Arceri
Fixes truncation warning in gcc 8.1 Fixes: 8539c9bf3158 ("gallium/radeon: add the kernel version into the renderer string") --- src/gallium/drivers/radeonsi/si_pipe.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/drivers/radeonsi/si_pipe.h

[Mesa-dev] [PATCH] anv: Set fence/semaphore types to NONE in impl_cleanup

2018-06-06 Thread Jason Ekstrand
There were some places that were calling anv_semaphore_impl_cleanup and neither deleting the semaphore nor setting the type back to NONE. Just set it to NONE in impl_cleanup to avoid these issues. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=106643 Fixes: 031f57eba "anv: Add a basic

[Mesa-dev] [PATCH] features: add virgl to the GL features list

2018-06-06 Thread Dave Airlie
From: Dave Airlie This hopefully adds virgl to the correct places and current statuses of various extensions. virgl of course relies on two external things a) host driver that can support the features b) up to date host virglrenderer library that can support the features. This list will be

Re: [Mesa-dev] [PATCH 4/8] intel/compiler: More peephole select

2018-06-06 Thread Ian Romanick
On 06/06/2018 04:26 PM, Matt Turner wrote: > On Wed, Jun 6, 2018 at 2:33 PM, Ian Romanick wrote: >> From: Ian Romanick >> >> Shader-db results: >> >> Skylake and Broadwell had similar results. (Skylake shown) >> total instructions in shared programs: 14371513 -> 14346174 (-0.18%) >> instructions

Re: [Mesa-dev] [PATCH 1/2] nir: add pass to move load_const

2018-06-06 Thread Ian Romanick
On 06/06/2018 04:47 PM, Rob Clark wrote: > On Wed, Jun 6, 2018 at 6:51 PM, Ian Romanick wrote: >> On 06/06/2018 07:43 AM, Rob Clark wrote: >>> Run this pass late (after opt loop) to move load_const instructions back >>> into the basic blocks which use the result, in cases where a load_const >>>

[Mesa-dev] [PATCH] ac: fix possible truncation of intrinsic name

2018-06-06 Thread Timothy Arceri
Fixes the gcc warning: snprintf’ output between 26 and 33 bytes into a destination of size 32 Fixes: d5f7ebda3ec0 ("ac: add LLVM build functions for subgroup instrinsics") --- src/amd/common/ac_llvm_build.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [Mesa-dev] [PATCH v2 11/15] docs: Toctree for systems.rst as in jhertel docs.

2018-06-06 Thread Laura Ekstrand
So actually, Nanley Chery noticed that this puts the xlib driver in the menu under "Deprecated systems." Xlib driver is in active development! Since xlib was not in the navigation menu on the old website, let's just delete this patch. nack'd by Laura Ekstrand (la...@jlekstrand.net) On Wed, May

Re: [Mesa-dev] [PATCH] radv: fix Coverity no effect control flow issue

2018-06-06 Thread Bas Nieuwenhuizen
Reviewed-by: Bas Nieuwenhuizen On Thu, Jun 7, 2018 at 1:49 AM, Timothy Arceri wrote: > swizzle is unsigned so "desc->swizzle[c] < 0" is never true. > --- > src/amd/vulkan/radv_formats.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/amd/vulkan/radv_formats.c

[Mesa-dev] [PATCH] radv: fix Coverity no effect control flow issue

2018-06-06 Thread Timothy Arceri
swizzle is unsigned so "desc->swizzle[c] < 0" is never true. --- src/amd/vulkan/radv_formats.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/amd/vulkan/radv_formats.c b/src/amd/vulkan/radv_formats.c index 50ec904d514..958f2a2c821 100644 ---

Re: [Mesa-dev] [PATCH 1/2] nir: add pass to move load_const

2018-06-06 Thread Rob Clark
On Wed, Jun 6, 2018 at 6:51 PM, Ian Romanick wrote: > On 06/06/2018 07:43 AM, Rob Clark wrote: >> Run this pass late (after opt loop) to move load_const instructions back >> into the basic blocks which use the result, in cases where a load_const >> is only consumed in a single block. > > If the

[Mesa-dev] [Bug 106774] GLSL IR copy propagates loads of SSBOs

2018-06-06 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=106774 --- Comment #12 from almos --- (In reply to Michel Dänzer from comment #10) > Please don't add piglit tests which are expected to hang the GPU, or at > least don't set them up to be run by default. Not all drivers can reliably > recover from

Re: [Mesa-dev] [PATCH 4/8] intel/compiler: More peephole select

2018-06-06 Thread Matt Turner
On Wed, Jun 6, 2018 at 2:33 PM, Ian Romanick wrote: > From: Ian Romanick > > Shader-db results: > > Skylake and Broadwell had similar results. (Skylake shown) > total instructions in shared programs: 14371513 -> 14346174 (-0.18%) > instructions in affected programs: 890389 -> 865050 (-2.85%) >

Re: [Mesa-dev] [PATCH 0/6] Fix Various Compilation Issues With Bindless

2018-06-06 Thread Rhys Perry
Oops, I meant r-values, not l-values. Seems to meaning of the word in my head changed at some point. On Wed, Jun 6, 2018 at 8:55 PM, Rhys Perry wrote: > Previously, there were some errors in the compiler's implementation of > ARB_bindless_texture, mostly related to usage of bound image or

Re: [Mesa-dev] [PATCH] dri: add missing 16bits formats mapping

2018-06-06 Thread Lionel Landwerlin
Thanks, pushed with your comment added. - Lionel On 06/06/18 23:17, Jason Ekstrand wrote: It might be good to add some additional commentary in the commit message such as: i965 advertises the 16-bit R and RG formats through eglQueryDmaBufFormatsEXT but falls over when a client tries to use

Re: [Mesa-dev] [PATCH 2/6] nv50/ir: add support for SAMP2HND on gk104+ and IMG2HND on gm107+

2018-06-06 Thread Ilia Mirkin
On Wed, Jun 6, 2018 at 3:55 PM, Rhys Perry wrote: > Signed-off-by: Rhys Perry > --- > src/gallium/drivers/nouveau/codegen/nv50_ir.cpp| 2 ++ > src/gallium/drivers/nouveau/codegen/nv50_ir.h | 2 ++ > .../drivers/nouveau/codegen/nv50_ir_from_tgsi.cpp | 22 +++ >

Re: [Mesa-dev] [PATCH 1/2] nir: add pass to move load_const

2018-06-06 Thread Ian Romanick
On 06/06/2018 03:51 PM, Ian Romanick wrote: > On 06/06/2018 07:43 AM, Rob Clark wrote: >> Run this pass late (after opt loop) to move load_const instructions back >> into the basic blocks which use the result, in cases where a load_const >> is only consumed in a single block. > > If the

Re: [Mesa-dev] [PATCH 1/2] nir: add pass to move load_const

2018-06-06 Thread Ian Romanick
On 06/06/2018 07:43 AM, Rob Clark wrote: > Run this pass late (after opt loop) to move load_const instructions back > into the basic blocks which use the result, in cases where a load_const > is only consumed in a single block. If the load_const is used in more than one block, you could use it to

Re: [Mesa-dev] [PATCH 1/6] gallium: add new SAMP2HND and IMG2HND opcodes

2018-06-06 Thread Ilia Mirkin
On Wed, Jun 6, 2018 at 3:55 PM, Rhys Perry wrote: > This commit does not add support for the opcodes in gallivm or tgsi_to_nir.c > > Signed-off-by: Rhys Perry > --- > src/gallium/auxiliary/tgsi/tgsi_info.c | 2 ++ > src/gallium/auxiliary/tgsi/tgsi_info_opcodes.h | 4 ++-- >

Re: [Mesa-dev] [PATCH] mesa/program_binary: add implicit UseProgram after successful ProgramBinary

2018-06-06 Thread Timothy Arceri
On 07/06/18 03:44, Jordan Justen wrote: Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=106810 Fixes: b4c37ce2140 "i965: Add ARB_get_program_binary support using nir_serialization" Ref: 3fe8d04a6d6 "mesa: don't always set _NEW_PROGRAM when linking" Ref: c505d6d8522 "mesa: use gl_program

Re: [Mesa-dev] [PATCH] dri: add missing 16bits formats mapping

2018-06-06 Thread Jason Ekstrand
It might be good to add some additional commentary in the commit message such as: i965 advertises the 16-bit R and RG formats through eglQueryDmaBufFormatsEXT but falls over when a client tries to use or asks more information about such a format because driImageFormatToGLFormat returns

Re: [Mesa-dev] [PATCH 1/2] intel/isl: Add bounds-checking assertions in isl_format_get_layout

2018-06-06 Thread Jason Ekstrand
On Wed, Jun 6, 2018 at 10:25 AM, Lionel Landwerlin < lionel.g.landwer...@intel.com> wrote: > On 06/06/18 18:17, Jason Ekstrand wrote: > >> We add two assertions instead of one because the first assertion that >> format != ISL_FORMAT_UNSUPPORTED is more descriptive and checks for a >> real but

Re: [Mesa-dev] [PATCH 1/8] nir: Document a couple instances of parent_instr

2018-06-06 Thread Jason Ekstrand
On Wed, Jun 6, 2018 at 2:33 PM, Ian Romanick wrote: > From: Ian Romanick > > nir_ssa_def::parent_instr and nir_src::parent_instr have the same name, > but they mean really different things. I choose to save the next person > the hour+ that I just spent figuring that out. Even now that I know,

[Mesa-dev] [PATCH 5/8] nir: Add nir_const_value_negative_equal

2018-06-06 Thread Ian Romanick
From: Ian Romanick Signed-off-by: Ian Romanick --- src/compiler/nir/meson.build| 12 + src/compiler/nir/nir.h | 6 + src/compiler/nir/nir_instr_set.c| 98 + src/compiler/nir/tests/negative_equal_tests.cpp | 278

[Mesa-dev] [PATCH 7/8] nir: Add partial redundancy elimination for compares

2018-06-06 Thread Ian Romanick
From: Ian Romanick This pass attempts to dectect code sequences like if (x < y) { z = y - z; ... } and replace them with sequences like t = x - y; if (t < 0) { z = t; ... } On architectures where the subtract can generate the flags used by

[Mesa-dev] [PATCH 3/8] intel/compiler: Silence unused parameter warnings brw_nir.c

2018-06-06 Thread Ian Romanick
From: Ian Romanick src/intel/compiler/brw_nir.c: In function ‘brw_nir_lower_vue_outputs’: src/intel/compiler/brw_nir.c:464:32: warning: unused parameter ‘is_scalar’ [-Wunused-parameter] bool is_scalar) ^

[Mesa-dev] [PATCH 4/8] intel/compiler: More peephole select

2018-06-06 Thread Ian Romanick
From: Ian Romanick Shader-db results: Skylake and Broadwell had similar results. (Skylake shown) total instructions in shared programs: 14371513 -> 14346174 (-0.18%) instructions in affected programs: 890389 -> 865050 (-2.85%) helped: 3601 HURT: 1 helped stats (abs) min: 1 max: 92 x̄: 7.05 x̃:

[Mesa-dev] [PATCH 2/8] nir: Add helper functions to get the instruction that generated a nir_src

2018-06-06 Thread Ian Romanick
From: Ian Romanick Signed-off-by: Ian Romanick --- src/compiler/nir/nir.h | 23 +++ 1 file changed, 23 insertions(+) diff --git a/src/compiler/nir/nir.h b/src/compiler/nir/nir.h index ba2a7142aa0..1ce7bcb9df1 100644 --- a/src/compiler/nir/nir.h +++ b/src/compiler/nir/nir.h

[Mesa-dev] [PATCH 6/8] nir: Add nir_alu_srcs_negative_equal

2018-06-06 Thread Ian Romanick
From: Ian Romanick Signed-off-by: Ian Romanick --- src/compiler/nir/nir.h | 4 + src/compiler/nir/nir_instr_set.c| 103 src/compiler/nir/tests/negative_equal_tests.cpp | 84 +++ 3 files changed, 191

[Mesa-dev] [PATCH 8/8] intel/compiler: Use partial redundancy elimination for compares

2018-06-06 Thread Ian Romanick
From: Ian Romanick Almost all of the hurt shaders are repeated instances of the same shader in synmark's compilation speed tests. shader-db results: All Gen7+ platforms had similar results. (Haswell shown) total instructions in shared programs: 12944679 -> 12943956 (<.01%) instructions in

[Mesa-dev] [PATCH 1/8] nir: Document a couple instances of parent_instr

2018-06-06 Thread Ian Romanick
From: Ian Romanick nir_ssa_def::parent_instr and nir_src::parent_instr have the same name, but they mean really different things. I choose to save the next person the hour+ that I just spent figuring that out. Even now that I know, I doubt I'd notice in code review that someone typed

[Mesa-dev] [Bug 106774] GLSL IR copy propagates loads of SSBOs

2018-06-06 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=106774 --- Comment #11 from Caio Marcelo de Oliveira Filho --- Even with the fixes to the GLSL copy propagation (and other passes) logic, the shader was still hanging. After a debugging session with Jason, he figured that the helper invocations were

Re: [Mesa-dev] [PATCH 5/7] i965/screen: Don't advertise support for RG formats

2018-06-06 Thread Jason Ekstrand
On Wed, Jun 6, 2018 at 1:25 PM, Daniel Stone wrote: > We definitely do, but I assume it's not been tested recently ... Ok, Lionel's patch it is then. :) > (Sorry about mangled formatting) > Wow, you managed to mangle it bad... No worries though; I have to talk to plenty of Outlook users

[Mesa-dev] [Bug 106843] GLES support and osmesa cannot be built together using Scons and MSVC

2018-06-06 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=106843 --- Comment #1 from Alex Granni --- I was able to replicate this with Mesa master too. -- You are receiving this mail because: You are the assignee for the bug. You are the QA Contact for the

Re: [Mesa-dev] [PATCH 5/7] i965/screen: Don't advertise support for RG formats

2018-06-06 Thread Daniel Stone
We definitely do, but I assume it's not been tested recently ... (Sorry about mangled formatting) On Wed, 6 Jun 2018, 8:42 pm Jason Ekstrand, wrote: > On June 6, 2018 12:37:58 Daniel Stone wrote: > >> Right, it's a feature we use, because we do all import them as separate >> EGLImages ... and

Re: [Mesa-dev] [PATCH v4 00/15] TGSI: improved live range tracking, also including arrays

2018-06-06 Thread Benedikt Schemmer
Hi Gert, Hi Nicolai, I did play around with this quite a lot (mostly with the previous version) and found it to be stable (doesn't crash deus ex on start up from cold shader cache like NIR) or leak memory like llvm 7 (at least used to leak ~100MB with piglit shaders, haven't given it another

[Mesa-dev] [PATCH 2/6] nv50/ir: add support for SAMP2HND on gk104+ and IMG2HND on gm107+

2018-06-06 Thread Rhys Perry
Signed-off-by: Rhys Perry --- src/gallium/drivers/nouveau/codegen/nv50_ir.cpp| 2 ++ src/gallium/drivers/nouveau/codegen/nv50_ir.h | 2 ++ .../drivers/nouveau/codegen/nv50_ir_from_tgsi.cpp | 22 +++ .../drivers/nouveau/codegen/nv50_ir_inlines.h | 4 ++--

[Mesa-dev] [PATCH 5/6] glsl, glsl_to_tgsi: fix sampler/image constants

2018-06-06 Thread Rhys Perry
Signed-off-by: Rhys Perry --- src/compiler/glsl/ir.cpp | 32 -- src/mesa/state_tracker/st_glsl_to_tgsi.cpp | 14 ++--- 2 files changed, 41 insertions(+), 5 deletions(-) diff --git a/src/compiler/glsl/ir.cpp b/src/compiler/glsl/ir.cpp index

[Mesa-dev] [PATCH 3/6] glsl_to_tgsi: allow bound samplers and images to be used as l-values

2018-06-06 Thread Rhys Perry
Signed-off-by: Rhys Perry --- src/mesa/state_tracker/st_glsl_to_tgsi.cpp | 55 +++- src/mesa/state_tracker/st_glsl_to_tgsi_private.h | 1 + 2 files changed, 55 insertions(+), 1 deletion(-) diff --git a/src/mesa/state_tracker/st_glsl_to_tgsi.cpp

[Mesa-dev] [PATCH 6/6] glsl: fix function inlining with opaque parameters

2018-06-06 Thread Rhys Perry
Signed-off-by: Rhys Perry --- src/compiler/glsl/opt_function_inlining.cpp | 52 - 1 file changed, 44 insertions(+), 8 deletions(-) diff --git a/src/compiler/glsl/opt_function_inlining.cpp b/src/compiler/glsl/opt_function_inlining.cpp index 04690b6cf4..52f57da936

[Mesa-dev] [PATCH 4/6] glsl: allow ?: operator with images and samplers when bindless is enabled

2018-06-06 Thread Rhys Perry
Signed-off-by: Rhys Perry --- src/compiler/glsl/ast_to_hir.cpp | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/src/compiler/glsl/ast_to_hir.cpp b/src/compiler/glsl/ast_to_hir.cpp index 3bf581571e..8a7dd62506 100644 --- a/src/compiler/glsl/ast_to_hir.cpp +++

[Mesa-dev] [PATCH 1/6] gallium: add new SAMP2HND and IMG2HND opcodes

2018-06-06 Thread Rhys Perry
This commit does not add support for the opcodes in gallivm or tgsi_to_nir.c Signed-off-by: Rhys Perry --- src/gallium/auxiliary/tgsi/tgsi_info.c | 2 ++ src/gallium/auxiliary/tgsi/tgsi_info_opcodes.h | 4 ++-- src/gallium/auxiliary/tgsi/tgsi_opcode_tmp.h | 3 +++

[Mesa-dev] [PATCH 0/6] Fix Various Compilation Issues With Bindless

2018-06-06 Thread Rhys Perry
Previously, there were some errors in the compiler's implementation of ARB_bindless_texture, mostly related to usage of bound image or sampler handles allowed by ARB_bindless_texture, resulting in assertions or compilation errors. This series fixes following issues found in mesa: - Assertions when

Re: [Mesa-dev] [PATCH 5/7] i965/screen: Don't advertise support for RG formats

2018-06-06 Thread Jason Ekstrand
On June 6, 2018 12:37:58 Daniel Stone wrote: Right, it's a feature we use, because we do all import them as separate EGLImages ... and we won't if it's not advertised. I'm a bit skeptical given that it doesn't actually work today because the DRI format to Mesa format conversation function

Re: [Mesa-dev] [PATCH 5/7] i965/screen: Don't advertise support for RG formats

2018-06-06 Thread Daniel Stone
Right, it's a feature we use, because we do all import them as separate EGLImages ... and we won't if it's not advertised. On Wed, 6 Jun 2018, 7:05 pm Jason Ekstrand, wrote: > On Wed, Jun 6, 2018 at 11:03 AM, Jason Ekstrand > wrote: > >> On Wed, Jun 6, 2018 at 11:00 AM, Daniel Stone >> wrote:

[Mesa-dev] [Bug 106842] Error de prueba

2018-06-06 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=106842 Adam Jackson changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

Re: [Mesa-dev] [PATCH mesa 1/3] egl: rewire the build systems to use libwayland-egl

2018-06-06 Thread Matt Turner
On Tue, May 29, 2018 at 7:41 AM, Eric Engestrom wrote: > Cc: Emil Velikov > Cc: Daniel Stone > Signed-off-by: Eric Engestrom > --- I just pushed this series. Thanks! ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org

[Mesa-dev] [Bug 106843] GLES support and osmesa cannot be built together using Scons and MSVC

2018-06-06 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=106843 Bug ID: 106843 Summary: GLES support and osmesa cannot be built together using Scons and MSVC Product: Mesa Version: unspecified Hardware: Other OS: All

[Mesa-dev] [Bug 106842] Error de prueba

2018-06-06 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=106842 Bug ID: 106842 Summary: Error de prueba Product: Mesa Version: unspecified Hardware: Other OS: All Status: NEW Severity: normal Priority:

Re: [Mesa-dev] [PATCH] mesa/program_binary: add implicit UseProgram after successful ProgramBinary

2018-06-06 Thread Plamena Manolova
This looks good to me :) Reviewed-by: Plamena Manolova On Wed, 6 Jun 2018 at 18:51, Jordan Justen wrote: > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=106810 > Fixes: b4c37ce2140 "i965: Add ARB_get_program_binary support using > nir_serialization" > Ref: 3fe8d04a6d6 "mesa: don't

Re: [Mesa-dev] [PATCH 5/7] i965/screen: Don't advertise support for RG formats

2018-06-06 Thread Jason Ekstrand
On Wed, Jun 6, 2018 at 11:03 AM, Jason Ekstrand wrote: > On Wed, Jun 6, 2018 at 11:00 AM, Daniel Stone > wrote: > >> Sorry, but as written this will regress ability to import NV12 images as >> separately-addressed planes with shader conversion to RGB; Kodi, Mutter and >> Weston all use this. >>

Re: [Mesa-dev] [PATCH 5/7] i965/screen: Don't advertise support for RG formats

2018-06-06 Thread Jason Ekstrand
On Wed, Jun 6, 2018 at 11:00 AM, Daniel Stone wrote: > Sorry, but as written this will regress ability to import NV12 images as > separately-addressed planes with shader conversion to RGB; Kodi, Mutter and > Weston all use this. > I don't believe it will. It only makes it so that we don't

Re: [Mesa-dev] [PATCH 5/7] i965/screen: Don't advertise support for RG formats

2018-06-06 Thread Daniel Stone
Sorry, but as written this will regress ability to import NV12 images as separately-addressed planes with shader conversion to RGB; Kodi, Mutter and Weston all use this. On Wed, 6 Jun 2018, 6:48 pm Jason Ekstrand, wrote: > Cc: mesa-sta...@lists.freedesktop.org > --- >

[Mesa-dev] [PATCH 7/7] i965/screen: Sanity check that all formats we advertise are useable

2018-06-06 Thread Jason Ekstrand
--- src/mesa/drivers/dri/i965/intel_screen.c | 24 1 file changed, 20 insertions(+), 4 deletions(-) diff --git a/src/mesa/drivers/dri/i965/intel_screen.c b/src/mesa/drivers/dri/i965/intel_screen.c index dbf0009cb02..d4818435bac 100644 ---

[Mesa-dev] [PATCH 6/7] i965/screen: Use RGBA non-sRGB formats for images

2018-06-06 Thread Jason Ekstrand
Not all of the MESA_FORMAT and ISL_FORMAT helpers we use can properly handle RGBX formats. Also, we don't want to make decisions based on those in the first place because we can't render to RGBA and we use the non-sRGB version to determine whether or not to allow CCS_E. Cc:

[Mesa-dev] [PATCH 4/7] i965/screen: Return false for unsupported formats in query_modifiers

2018-06-06 Thread Jason Ekstrand
Cc: mesa-sta...@lists.freedesktop.org --- src/mesa/drivers/dri/i965/intel_screen.c | 16 ++-- 1 file changed, 14 insertions(+), 2 deletions(-) diff --git a/src/mesa/drivers/dri/i965/intel_screen.c b/src/mesa/drivers/dri/i965/intel_screen.c index 2c783591202..5f0eeb41779 100644 ---

[Mesa-dev] [PATCH 3/7] i965/screen: Refactor query_dma_buf_formats

2018-06-06 Thread Jason Ekstrand
This reworks it to work like query_dma_buf_modifiers and, in particular, makes it more flexible so that we can disallow a non-static set of formats. Cc: mesa-sta...@lists.freedesktop.org --- src/mesa/drivers/dri/i965/intel_screen.c | 25 1 file changed, 13 insertions(+),

[Mesa-dev] [PATCH 5/7] i965/screen: Don't advertise support for RG formats

2018-06-06 Thread Jason Ekstrand
Cc: mesa-sta...@lists.freedesktop.org --- src/mesa/drivers/dri/i965/intel_screen.c | 12 1 file changed, 12 insertions(+) diff --git a/src/mesa/drivers/dri/i965/intel_screen.c b/src/mesa/drivers/dri/i965/intel_screen.c index 5f0eeb41779..f681b221e7b 100644 ---

[Mesa-dev] [PATCH 2/7] intel/isl: Add bounds-checking assertions for the format_info table

2018-06-06 Thread Jason Ekstrand
We follow the same convention as isl_format_get_layout in having two assertions to ensure that only valid formats are passed in. We also check against the array size of the table because some valid formats such as CCS formats will may be past the end of the table. This fixes some potential

[Mesa-dev] [PATCH 0/7] i965: Be more careful about advertising formats and

2018-06-06 Thread Jason Ekstrand
When we originally added modifiers support we were, apparently, way more sloppy with our implementations of the core queries than anyone realized. We just dumped out the intel_image_formats table with very little thought to whether or not we actually wanted to support them all. We also didn't

[Mesa-dev] [PATCH 1/7] intel/isl: Add bounds-checking assertions in isl_format_get_layout

2018-06-06 Thread Jason Ekstrand
We add two assertions instead of one because the first assertion that format != ISL_FORMAT_UNSUPPORTED is more descriptive and checks for a real but unsupported enumerant while the second ensures that they don't pass in garbage values. We also update some other helpers to use

[Mesa-dev] [PATCH] mesa/program_binary: add implicit UseProgram after successful ProgramBinary

2018-06-06 Thread Jordan Justen
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=106810 Fixes: b4c37ce2140 "i965: Add ARB_get_program_binary support using nir_serialization" Ref: 3fe8d04a6d6 "mesa: don't always set _NEW_PROGRAM when linking" Ref: c505d6d8522 "mesa: use gl_program for CurrentProgram rather than

[Mesa-dev] [PATCH] dri: add missing 16bits formats mapping

2018-06-06 Thread Lionel Landwerlin
Found by Eero. v2: Add G16R16 formats (Lionel) v3: Fix G16R16 mapping to mesa format (Jason) Signed-off-by: Lionel Landwerlin Reviewed-by: Plamena Manolova (v2) Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=106642 --- src/mesa/drivers/dri/common/dri_util.c | 16 1

Re: [Mesa-dev] [PATCH v2] dri: add missing 16bits formats mapping

2018-06-06 Thread Lionel Landwerlin
On 06/06/18 18:27, Jason Ekstrand wrote: On Wed, Jun 6, 2018 at 7:57 AM, Lionel Landwerlin mailto:lionel.g.landwer...@intel.com>> wrote: Found by Eero. v2: Add G16R16 formats (Lionel) Signed-off-by: Lionel Landwerlin mailto:lionel.g.landwer...@intel.com>> Bugzilla:

Re: [Mesa-dev] [PATCH mesa] vma/tests: cast away implementation detail of using strtoul()

2018-06-06 Thread Eric Anholt
Eric Engestrom writes: > On MacOS, the build fails because of a compiler complaint about > a downcast: > > vma_random_test.cpp:239:18: error: non-constant-expression cannot be > narrowed from type 'unsigned long' to 'uint_fast32_t' (aka 'unsigned int') in > initializer list

Re: [Mesa-dev] [PATCH v2] dri: add missing 16bits formats mapping

2018-06-06 Thread Jason Ekstrand
On Wed, Jun 6, 2018 at 7:57 AM, Lionel Landwerlin < lionel.g.landwer...@intel.com> wrote: > Found by Eero. > > v2: Add G16R16 formats (Lionel) > > Signed-off-by: Lionel Landwerlin > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=106642 > --- > src/mesa/drivers/dri/common/dri_util.c | 16

Re: [Mesa-dev] [PATCH 2/2] intel/isl: Add bounds-checking assertions for the format_info table

2018-06-06 Thread Lionel Landwerlin
Reviewed-by: Lionel Landwerlin On 06/06/18 18:17, Jason Ekstrand wrote: We follow the same convention as isl_format_get_layout in having two assertions to ensure that only valid formats are passed in. We also check against the array size of the table because some valid formats such as CCS

Re: [Mesa-dev] [PATCH 1/2] intel/isl: Add bounds-checking assertions in isl_format_get_layout

2018-06-06 Thread Lionel Landwerlin
On 06/06/18 18:17, Jason Ekstrand wrote: We add two assertions instead of one because the first assertion that format != ISL_FORMAT_UNSUPPORTED is more descriptive and checks for a real but unsupported enumerant while the second ensures that they don't pass in garbage values. We also update

[Mesa-dev] [PATCH 1/2] intel/isl: Add bounds-checking assertions in isl_format_get_layout

2018-06-06 Thread Jason Ekstrand
We add two assertions instead of one because the first assertion that format != ISL_FORMAT_UNSUPPORTED is more descriptive and checks for a real but unsupported enumerant while the second ensures that they don't pass in garbage values. We also update some other helpers to use

[Mesa-dev] [PATCH 2/2] intel/isl: Add bounds-checking assertions for the format_info table

2018-06-06 Thread Jason Ekstrand
We follow the same convention as isl_format_get_layout in having two assertions to ensure that only valid formats are passed in. We also check against the array size of the table because some valid formats such as CCS formats will may be past the end of the table. This fixes some potential

Re: [Mesa-dev] [Fwd: Gitlab migration]

2018-06-06 Thread Jason Ekstrand
Could you please send that unencrypted? I'm happy if you want to sign it but sending encrypted mail to public list is a bit weird. 2018-06-06 6:56 GMT-07:00 Alejandro Piñeiro : > -BEGIN PGP MESSAGE- > > hQIMAxofeYe0BHiSARAAi5AXyHgpmhQ9wIAfFtpGfqnHbThXHRymLy4WzRjLpBb8 >

Re: [Mesa-dev] [PATCH v2] dri: add missing 16bits formats mapping

2018-06-06 Thread Plamena Manolova
v2 is Reviewed-by: Plamena Manolova On Wed, 6 Jun 2018 at 15:59, Lionel Landwerlin < lionel.g.landwer...@intel.com> wrote: > Found by Eero. > > v2: Add G16R16 formats (Lionel) > > Signed-off-by: Lionel Landwerlin > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=106642 > --- >

[Mesa-dev] [PATCH] egl/glvnd: Fix a segfault in eglGetProcAddress.

2018-06-06 Thread Kyle Brenneman
If FindProcIndex in egldispatchstubs.c is called with a name that's less than the first entry in the array, it would end up trying to store an index of -1 in an unsigned integer, wrap around to 2^32, and then crash when it tries to look that up. Change FindProcIndex so that it uses bsearch(3)

[Mesa-dev] [Bug 106833] glLinkProgram is expected to fail when vertex attribute aliasing happens on ES3.0 context or later

2018-06-06 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=106833 --- Comment #5 from Tapani Pälli --- (In reply to Tapani Pälli from comment #4) > Created attachment 140052 [details] [review] > possible fix > > This should fix the issue but will investigate if there is a cleaner way. *Warning, this fixes

[Mesa-dev] [PATCH v2] dri: add missing 16bits formats mapping

2018-06-06 Thread Lionel Landwerlin
Found by Eero. v2: Add G16R16 formats (Lionel) Signed-off-by: Lionel Landwerlin Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=106642 --- src/mesa/drivers/dri/common/dri_util.c | 16 1 file changed, 16 insertions(+) diff --git a/src/mesa/drivers/dri/common/dri_util.c

Re: [Mesa-dev] [Fwd: Gitlab migration]

2018-06-06 Thread Alejandro Piñeiro
Please ignore those two emails. Were intended to a internal mailing list. Sorry for the noise. On 06/06/18 16:43, Alejandro Piñeiro wrote: > > > ___ > mesa-dev mailing list > mesa-dev@lists.freedesktop.org >

[Mesa-dev] [PATCH 1/2] nir: add pass to move load_const

2018-06-06 Thread Rob Clark
Run this pass late (after opt loop) to move load_const instructions back into the basic blocks which use the result, in cases where a load_const is only consumed in a single block. This helps reduce register usage in cases where the backend driver cannot lower the load_const to a uniform.

[Mesa-dev] [PATCH 2/2] nir: add lowering for gl_HelperInvocation

2018-06-06 Thread Rob Clark
Signed-off-by: Rob Clark --- I can't say for sure that this will work on all drivers, but it is what the blob driver does, and it seems to make deqp happy. I could move this to it's own pass inside ir3, but that seemed like overkill src/compiler/nir/nir.h | 10 ++

Re: [Mesa-dev] [Fwd: Gitlab migration]

2018-06-06 Thread Alejandro Piñeiro
bin1bz8_m0JgN.bin Description: PGP/MIME version identification encrypted.asc Description: OpenPGP encrypted message ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH] dri: add missing 16bits formats mapping

2018-06-06 Thread Plamena Manolova
Reviewed-by: Plamena Manolova On Wed, 6 Jun 2018 at 13:53, Lionel Landwerlin < lionel.g.landwer...@intel.com> wrote: > Signed-off-by: Lionel Landwerlin > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=106642 > --- > src/mesa/drivers/dri/common/dri_util.c | 8 > 1 file

Re: [Mesa-dev] [Fwd: Gitlab migration]

2018-06-06 Thread Alejandro Piñeiro
binHRfGIbLv5F.bin Description: PGP/MIME version identification encrypted.asc Description: OpenPGP encrypted message ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [PATCH] dri: add missing 16bits formats mapping

2018-06-06 Thread Lionel Landwerlin
Signed-off-by: Lionel Landwerlin Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=106642 --- src/mesa/drivers/dri/common/dri_util.c | 8 1 file changed, 8 insertions(+) diff --git a/src/mesa/drivers/dri/common/dri_util.c b/src/mesa/drivers/dri/common/dri_util.c index

Re: [Mesa-dev] [PATCH] glsl: Take 'double' as reserved after GLSL ES 1.0

2018-06-06 Thread Ilia Mirkin
On Wed, Jun 6, 2018 at 4:11 AM, Kenneth Graunke wrote: > On Monday, June 4, 2018 2:33:59 PM PDT zhaowei yuan wrote: >> GLSL ES 1.0.17 specifies that "double" is a keyword reserved >> >> Signed-off-by: zhaowei yuan >> --- >> src/compiler/glsl/glsl_lexer.ll | 2 +- >> 1 file changed, 1

[Mesa-dev] [Bug 106833] glLinkProgram is expected to fail when vertex attribute aliasing happens on ES3.0 context or later

2018-06-06 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=106833 --- Comment #4 from Tapani Pälli --- Created attachment 140052 --> https://bugs.freedesktop.org/attachment.cgi?id=140052=edit possible fix This should fix the issue but will investigate if there is a cleaner way. -- You are receiving this

Re: [Mesa-dev] [PATCH 00/21] Towards NIR support for etnaviv

2018-06-06 Thread Philipp Zabel
Hi Christian, On Tue, 2018-06-05 at 17:43 +0200, Christian Gmeiner wrote: > Am Di., 5. Juni 2018 um 16:40 Uhr schrieb Philipp Zabel > : > Thanks for this nice patch series. I have been working for too long on > the nir topic > for etnaviv and never pushed any patches (which is quite sad). I have

Re: [Mesa-dev] [PATCH 06/21] etnaviv: nir: hardwire position location

2018-06-06 Thread Philipp Zabel
On Tue, 2018-06-05 at 11:50 -0400, Rob Clark wrote: > On Tue, Jun 5, 2018 at 10:38 AM, Philipp Zabel wrote: > > The temporary input/output register 0 is reserved for position in the > > fragment shader. Hardwire it to 0 and start other input/output variables > > at 1. The intrinsic input load and

Re: [Mesa-dev] [PATCH 08/21] etnaviv: nir: add virtual register classes

2018-06-06 Thread Philipp Zabel
On Tue, 2018-06-05 at 11:39 -0400, Rob Clark wrote: > On Tue, Jun 5, 2018 at 10:38 AM, Philipp Zabel wrote: > > Since all threads share a global temporary vec4 register file, it is > > important to reduce temporary register use of shaders. > > Using source swizzles and destination write mask of

[Mesa-dev] [Bug 106833] glLinkProgram is expected to fail when vertex attribute aliasing happens on ES3.0 context or later

2018-06-06 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=106833 --- Comment #3 from Tapani Pälli --- (In reply to xinghua from comment #2) > (In reply to Tapani Pälli from comment #1) > > FYI I noticed this test prints out following before failing tests: > > > > "Testing with shader that has entirely

[Mesa-dev] [PATCH v3 2/2] wayland/egl: update surface size on window resize

2018-06-06 Thread Juan A. Suarez Romero
According to EGL 1.5 spec, section 3.10.1.1 ("Native Window Resizing"): "If the native window corresponding to _surface_ has been resized prior to the swap, _surface_ must be resized to match. _surface_ will normally be resized by the EGL implementation at the time the native window is

[Mesa-dev] [PATCH v3 1/2] wayland/egl: initialize window surface size to window size

2018-06-06 Thread Juan A. Suarez Romero
When creating a windows surface with eglCreateWindowSurface(), the width and height returned by eglQuerySurface(EGL_{WIDTH,HEIGHT}) is invalid until buffers are updated (like calling glClear()). But according to EGL 1.5 spec, section 3.5.6 ("Surface Attributes"): "Querying EGL_WIDTH and

Re: [Mesa-dev] [PATCH v2 18/21] i965: Update TexturesUsed after linking the shaders

2018-06-06 Thread Timothy Arceri
Reviewed-by: Timothy Arceri On 12/05/18 19:40, Alejandro Piñeiro wrote: From: Neil Roberts Otherwise if the shader is SPIR-V then SamplerUsed won’t have been initialised yet so it will end up thinking no textures are used. This was causing a crash later on if nothing causes it to regenerate

Re: [Mesa-dev] [PATCH v2 17/21] i965: Build SPIR-V programs' resource list using NIR

2018-06-06 Thread Timothy Arceri
Reviewed-by: Timothy Arceri On 12/05/18 19:40, Alejandro Piñeiro wrote: From: Eduardo Lima Mitev v2: tweak after nir_linker.h being renamed to gl_nir_linker.h --- src/mesa/drivers/dri/i965/brw_link.cpp | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git

  1   2   >