Some types of params such as some builtins are always padded. We
need to keep track of this so we can restore the list correctly.
Here we also remove a couple of cache entries that are not actually
required as they get rebuilt by the _mesa_add_parameter() calls.
This patch fixes a bunch of
On Tuesday, February 26, 2019 9:41:07 AM PST Christian Gmeiner wrote:
> Push this format to the pipe driver unchanged.
>
> Signed-off-by: Christian Gmeiner
> ---
> include/GL/internal/dri_interface.h | 1 +
> src/gallium/state_trackers/dri/dri2.c | 2 ++
> 2 files changed, 3 insertions(+)
>
https://bugs.freedesktop.org/show_bug.cgi?id=109617
--- Comment #6 from Natalia ---
Unfortunately, I will not have access to this machine at the nearest time. When
I have it, I think, I will check this.
--
You are receiving this mail because:
You are the assignee for the bug.
You are the QA
Reviewed-by: Samuel Iglesias Gonsálvez
On Wed, 2019-02-27 at 00:15 -0600, Jason Ekstrand wrote:
> No idea how this fell through the cracks besides the fact that the
> sampler bound at 0 almost always works and the CTS isn't amazing. In
> any case, this appears to have been broken for almost
No idea how this fell through the cracks besides the fact that the
sampler bound at 0 almost always works and the CTS isn't amazing. In
any case, this appears to have been broken for almost forever.
Cc: mesa-sta...@lists.freedesktop.org
---
src/compiler/spirv/spirv_to_nir.c | 2 +-
1 file
smul comes first in the pipeline, before vmul. Until we have a full
instruction scheduler, it's better to have vmul prioritized to maximize
bundle size.
Signed-off-by: Alyssa Rosenzweig
---
src/gallium/drivers/panfrost/midgard/midgard_compile.c | 2 +-
1 file changed, 1 insertion(+), 1
If a selected unit causes a data hazard, the whole block gets cut short.
So, we preview for data hazards _while_ selecting units.
Signed-off-by: Alyssa Rosenzweig
---
.../panfrost/midgard/midgard_compile.c| 25 ---
1 file changed, 16 insertions(+), 9 deletions(-)
diff
We tweak the scheduler for slightly better instruction bundling.
Alyssa Rosenzweig (2):
panfrost/midgard: Promote smul to vmul
panfrost/midgard: Preview for data hazards
.../panfrost/midgard/midgard_compile.c| 27 ---
1 file changed, 17 insertions(+), 10 deletions(-)
Signed-off-by: Alyssa Rosenzweig
---
src/gallium/drivers/panfrost/include/panfrost-job.h | 2 ++
1 file changed, 2 insertions(+)
diff --git a/src/gallium/drivers/panfrost/include/panfrost-job.h
b/src/gallium/drivers/panfrost/include/panfrost-job.h
index 1d738486617..d719325d07b 100644
---
v2: panfrost: Remove some scanout special cases
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
This special-case was needlessly added and breaks purely offscreen
rendering (when there is no scanout involved).
Signed-off-by: Alyssa Rosenzweig
---
src/gallium/drivers/panfrost/pan_context.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git
Previously, we forced a #0 inline constant tacked on for the lut
instructions to mirror the blob's behaviour, which caused some
suboptimal codegen due to our constant inlining implementation. Instead,
just don't force a constant at all.
Signed-off-by: Alyssa Rosenzweig
---
This helps improve compile times. For example the shader-db dolphin
shader shaders/dolphin/ubershaders/120.shader_test goes from
~1.69 -> ~1.57 seconds on my machine with this change.
---
src/gallium/drivers/radeonsi/si_state_shaders.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
Chris Wilson writes:
> A few of the GEM drivers provide matching ioctls to allow control of
> their bo caches. Hook these up to APPLE_object_purgeable to allow
> clients to discard video memory under pressure where they are able to
> fallback to restoring content themselves, e.g. from their own
https://bugs.freedesktop.org/show_bug.cgi?id=109617
--- Comment #5 from Aaron Watry ---
For where ever you have clover installed, can you check that it's linked
against the right LLVM? If you've just installed an updated LLVM, it's likely
that clover is still running against the old version.
At the moment, Panfrost state is ad hoc, which creates issues for FBOs.
This commit imports the skeleton of the v3d_job structure as
panfrost_job, in preparation for refactors to organize this state.
Signed-off-by: Alyssa Rosenzweig
---
src/gallium/drivers/panfrost/meson.build | 1 +
Signed-off-by: Alyssa Rosenzweig
---
src/gallium/drivers/panfrost/pan_context.c | 25 +++---
src/gallium/drivers/panfrost/pan_context.h | 10 -
2 files changed, 3 insertions(+), 32 deletions(-)
diff --git a/src/gallium/drivers/panfrost/pan_context.c
The operations of gallium->clear() and the hardware callbacks are
fundamentally independent. This routine decouples them by routing shared
information via panfrost_job, allowing the hardware half to be deferred
to the fragment job generation.
Signed-off-by: Alyssa Rosenzweig
---
In an effort to cleanup the codebase and prepare for more complex FBO
usecases, this patch series begins the slow refactor towards
jobs/batches, rather than shoving all state into panfrost_context and
hoping it works. We use some data structures from v3d and cleanup the
clear code here. More
Hi List,
Sorry for the short summary, it took me longer to get the release ready than
normal and I'm running a bit short on time.
Mesa 19.0.0-rc6 is now available for your general consumption. Lots and lots in
this release candidate, mostly Intel, AMD, and NIR changes, but with a few other
Iago Toral Quiroga writes:
> ---
> src/intel/compiler/brw_eu_validate.c| 10 +-
> src/intel/compiler/test_eu_validate.cpp | 46 +
> 2 files changed, 55 insertions(+), 1 deletion(-)
>
> diff --git a/src/intel/compiler/brw_eu_validate.c
>
I ran a simple test verifying that compute is working properly on the
compute ring.
When clover is using compute rings, it doesn't stall/block graphics
operations.
Marek
On Tue, Feb 26, 2019 at 4:10 PM Jan Vesely wrote:
> Can you add a bit of background why clover should/should not use other
https://bugs.freedesktop.org/show_bug.cgi?id=109788
--- Comment #1 from Lionel Landwerlin ---
Let me know if that works for you :
https://gitlab.freedesktop.org/mesa/mesa/merge_requests/339
--
You are receiving this mail because:
You are the assignee for the
Yes, we can.
Marek
On Tue, Feb 26, 2019 at 5:30 PM Timothy Arceri
wrote:
> Hi Guys,
>
> Can we get this one into the next 18.3 release. It fixes a hang with
> Counter Strike on start-up. I'm a little concerned this just works
> around the problem but the patch seems safe for stable.
>
>
Iago Toral Quiroga writes:
> ---
> src/intel/compiler/brw_eu_validate.c| 64 -
> src/intel/compiler/test_eu_validate.cpp | 122
> 2 files changed, 185 insertions(+), 1 deletion(-)
>
> diff --git a/src/intel/compiler/brw_eu_validate.c
>
Hi Guys,
Can we get this one into the next 18.3 release. It fixes a hang with
Counter Strike on start-up. I'm a little concerned this just works
around the problem but the patch seems safe for stable.
Thanks,
Tim
On 12/1/19 10:53 am, Marek Olšák wrote:
From: Marek Olšák
same as all other
https://bugs.freedesktop.org/show_bug.cgi?id=109788
Jason Ekstrand changed:
What|Removed |Added
CC|ja...@jlekstrand.net|
--
You are receiving this mail
https://bugs.freedesktop.org/show_bug.cgi?id=109788
Bug ID: 109788
Summary: vulkan-overlay-layer: Only installs 64bit version
Product: Mesa
Version: unspecified
Hardware: Other
OS: All
Status: NEW
https://bugs.freedesktop.org/show_bug.cgi?id=109532
Dmytro Chystiakov changed:
What|Removed |Added
CC||dmytro.chystia...@intel.com
--
Iago Toral Quiroga writes:
> The section 'Execution Data Types' of 3D Media GPGPU volume, which
> describes execution types, is exactly the same in BDW and SKL+.
>
> Also, this section states that there is a single execution type, so it
> makes sense that this is the wider of the two floating
A few of the GEM drivers provide matching ioctls to allow control of
their bo caches. Hook these up to APPLE_object_purgeable to allow
clients to discard video memory under pressure where they are able to
fallback to restoring content themselves, e.g. from their own (presumably
compressed, on
A few of the GEM drivers provide matching ioctls to allow control of
their bo caches. Hook these up to APPLE_object_purgeable to allow
clients to discard video memory under pressure where they are able to
fallback to restoring content themselves, e.g. from their own (presumably
compressed, on
Can you add a bit of background why clover should/should not use other
rings?
I planned to test this, but my raven system can't run clover since kernel
4.20 release (BZ 109649), so I need to bisect that first.
Can this patch help address the soft lockup issue on CIK (BZ 108879)?
presumably, it
https://bugs.freedesktop.org/show_bug.cgi?id=109739
Jason Ekstrand changed:
What|Removed |Added
CC|ja...@jlekstrand.net|
--
You are receiving this mail
https://bugs.freedesktop.org/show_bug.cgi?id=109739
--- Comment #11 from Shmerl ---
(In reply to Mike Lothian from comment #10)
> The next issue seems to be the .so gets installed into:
>
> /usr/share/vulkan/explicit_layer.d/libVkLayer_MESA_overlay.so
>
> In gentoo the .so files get installed
https://bugs.freedesktop.org/show_bug.cgi?id=109739
--- Comment #10 from Mike Lothian ---
I've created a merge request to get the vulkan-layers headers put into the
correct place
https://github.com/gentoo/gentoo/pull/11166
The next issue seems to be the .so gets installed into:
I'll just push it.
Marek
On Mon, Feb 25, 2019 at 9:37 PM Dieter Nützel wrote:
> Hello Marek,
>
> this series need a rebase (if you have some time).
>
> Dieter
>
> Am 12.02.2019 19:12, schrieb Marek Olšák:
> > From: Marek Olšák
> >
> > initialize all non-compute context functions to NULL.
> >
On Mon, Feb 25, 2019 at 02:18:52PM -0800, Kenneth Graunke wrote:
> On Monday, February 25, 2019 11:01:33 AM PST Pohjolainen, Topi wrote:
> > On Mon, Feb 25, 2019 at 10:32:27AM -0800, Kenneth Graunke wrote:
> > > On Monday, February 25, 2019 6:33:11 AM PST Pohjolainen, Topi wrote:
> > > > On Thu,
https://bugs.freedesktop.org/show_bug.cgi?id=109739
--- Comment #9 from Shmerl ---
(In reply to Mike Lothian from comment #8)
> On Gentoo it installs into /usr/include :(
According to upstream, that's something distributions should fix. You can open
a Gentoo bug.
--
You are receiving this
https://bugs.freedesktop.org/show_bug.cgi?id=109739
Mike Lothian changed:
What|Removed |Added
CC||m...@fireburn.co.uk
--- Comment #8 from
https://bugs.freedesktop.org/show_bug.cgi?id=109443
--- Comment #6 from Jose Fonseca ---
How about this as workaround:
diff --git a/scons/gallium.py b/scons/gallium.py
index 963834a5fbc..565f19f3f1a 100755
--- a/scons/gallium.py
+++ b/scons/gallium.py
@@ -308,7 +308,10 @@ def generate(env):
Changes v1 -> v2:
- Avoid the GPU sampling from the resource that gets mutated by the the
transfer map by setting DRM_ETNA_PREP_WRITE.
Signed-off-by: Christian Gmeiner
---
.../drivers/etnaviv/etnaviv_resource.c| 3 +
.../drivers/etnaviv/etnaviv_resource.h| 5 ++
ETC2 is supported with HALTI0, however that implementation is buggy
in hardware. The blob driver does per-block patching to work around
this. We need to swap colors for t-mode etc2 blocks.
Signed-off-by: Christian Gmeiner
---
src/gallium/drivers/etnaviv/Makefile.sources | 2 +
HALTI0 GPUs have broken ETC2 support (for RGB and RGBA)
formats. The blob driver does per-block patching. The patching
is quite simple: color swaping.
This patch series adds support for the needed block patching
and enabled ETC2 support for HALTI0.
Passes all tested formats of the following
Saves us from calling etna_bo_map(..) and saves us from doing the
same offset calcs for map() and unmap() operations.
Signed-off-by: Christian Gmeiner
Reviewed-by: Lucas Stach
---
src/gallium/drivers/etnaviv/etnaviv_context.h | 1 +
.../drivers/etnaviv/etnaviv_transfer.c| 19
Signed-off-by: Christian Gmeiner
---
src/gallium/drivers/etnaviv/etnaviv_screen.c | 12 +---
1 file changed, 1 insertion(+), 11 deletions(-)
diff --git a/src/gallium/drivers/etnaviv/etnaviv_screen.c
b/src/gallium/drivers/etnaviv/etnaviv_screen.c
index de822fc85ca..ee32a499fb5 100644
https://bugs.freedesktop.org/show_bug.cgi?id=109532
--- Comment #47 from Dylan Baker ---
It's not that the cross file is overriding, CFLAGS and friends are for
native (build) targets, not cross (host) targets.
I'm on mobile, please excuse autocorrect fail.
On Tue, Feb 26, 2019, 09:33 wrote:
Push this format to the pipe driver unchanged.
Signed-off-by: Christian Gmeiner
---
include/GL/internal/dri_interface.h | 1 +
src/gallium/state_trackers/dri/dri2.c | 2 ++
2 files changed, 3 insertions(+)
diff --git a/include/GL/internal/dri_interface.h
https://bugs.freedesktop.org/show_bug.cgi?id=109532
--- Comment #46 from Mark Janes ---
I confirmed that the cross file is overriding our 32 bit flags that we pass
through the environment.
--
You are receiving this mail because:
You are the assignee for the
https://bugs.freedesktop.org/show_bug.cgi?id=109784
--- Comment #1 from Alok Hota ---
I believe this is a bug caused by a change I introduced to our autotools setup.
EventHandler is declared in a codegen file, which is not generated correctly. I
believe this MR should fix it:
https://bugs.freedesktop.org/show_bug.cgi?id=109532
--- Comment #45 from Mark Janes ---
https://bugs.freedesktop.org/show_bug.cgi?id=109532
Mark Janes changed:
What|Removed |Added
CC||baker.dyla...@gmail.com
--
You are
On Mon, Feb 25, 2019 at 03:40:24PM -0800, Nanley Chery wrote:
> On Mon, Feb 25, 2019 at 03:14:10PM -0800, Dylan Baker wrote:
> > Quoting Eleni Maria Stea (2019-02-22 13:02:30)
> > > Calculating the scissor rectangle fields with the y flipped (0 on top)
> > > can generate negative values that will
Looks good.
Reviewed-by: Neha Bhende
Regards,
Neha
From: Brian Paul
Sent: Monday, February 25, 2019 7:13 PM
To: mesa-dev@lists.freedesktop.org
Cc: Neha Bhende
Subject: [PATCH] svga: fix dma.pending > 0 test
The dma.pending field is boolean, so testing for >
https://bugs.freedesktop.org/show_bug.cgi?id=109786
fin4...@hotmail.com changed:
What|Removed |Added
Status|NEW |RESOLVED
Resolution|---
On 2/25/19 6:54 PM, Rob Clark wrote:
> On Wed, Feb 13, 2019 at 4:30 PM Eduardo Lima Mitev wrote:
>>
>> This pass moves to NIR some offset computations that are currently
>> implemented on the IR3 backend compiler, to allow NIR to possibly
>> optimize them.
>>
>> For now, it only supports lowering
https://bugs.freedesktop.org/show_bug.cgi?id=109739
Lionel Landwerlin changed:
What|Removed |Added
Status|NEW |RESOLVED
Resolution|---
This drastically reduces the number of SGPRs because the driver
now uses descriptors per vertex binding, instead of per vertex
attribute format.
29077 shaders in 15096 tests
Totals:
SGPRS: 1354285 -> 1282109 (-5.33 %)
VGPRS: 909896 -> 908800 (-0.12 %)
Spilled SGPRs: 24840 -> 24811 (-0.12 %)
Code
Be more generic, this will be used by an upcoming series.
Signed-off-by: Samuel Pitoiset
---
src/amd/common/ac_llvm_build.c | 106
src/amd/common/ac_llvm_build.h | 30 -
src/amd/common/ac_nir_to_llvm.c | 4 +-
3 files changed, 83 insertions(+), 57
They are required for using typed buffer loads.
Signed-off-by: Samuel Pitoiset
---
src/amd/vulkan/radv_pipeline.c | 27 +++
src/amd/vulkan/radv_private.h | 4
src/amd/vulkan/radv_shader.h | 6 ++
3 files changed, 37 insertions(+)
diff --git
https://bugs.freedesktop.org/show_bug.cgi?id=109532
--- Comment #44 from asimiklit ---
(In reply to Mark Janes from comment #42)
> i965 CI runs debug builds by default, but for mesa it uses these meson
> configurations:
>
> -Dbuildtype=release -Db_ndebug=true
>
> We must catch assertions in
https://bugs.freedesktop.org/show_bug.cgi?id=109757
--- Comment #2 from Shmerl ---
I don't see a problem with using it if it's helpful (and it is). But if you
want to drop it, then backticks don't make sense, i.e.:
```
VK_INSTANCE_LAYERS=VK_LAYER_MESA_overlay /path/to/my_vulkan_app
On Monday, 2019-02-25 20:06:47 +, Ross Burton wrote:
> From: Khem Raj
>
> vmw_screen.h uses dev_t which is defines in sys/types.h
> this header is required to be included for getting dev_t
> definition. This issue happens on musl C library, it is hidden
> on glibc since sys/types.h is
On Monday, 2019-02-25 20:06:48 +, Ross Burton wrote:
> This patch claimed that the autotools build generates libGLESv1_CM.so.1.0.0,
> but
> it doesn't:
>
> es1api_libGLESv1_CM_la_LDFLAGS = \
> -no-undefined \
> -version-number 1:1 \
> $(GC_SECTIONS) \
>
https://bugs.freedesktop.org/show_bug.cgi?id=109757
--- Comment #1 from Lionel Landwerlin ---
While adding fps file output, I decided to drop the markdown. It's not used
anywhere else in the mesa project :
https://gitlab.freedesktop.org/mesa/mesa/merge_requests/320/
--
You are receiving this
Reviewed-by: Samuel Pitoiset
On 2/18/19 2:23 PM, Rhys Perry wrote:
I don't see a 16-bit version of tbuffer.store in IntrinsicsAMDGPU.td
and simply changing "llvm.amdgcn.tbuffer.store.i32" to
"llvm.amdgcn.tbuffer.store.i16" and removing the zext doesn't seem to
work.
On Mon, 18 Feb 2019 at
Hi Matthias;
I pushed this change earlier (commit 1d5e5ec30a6) with you in 'Reported-by'.
Thanks;
// Tapani
On 2/25/19 1:16 PM, Matthias Lorenz wrote:
Use of nir_variable_create was suggested by Jason Ekstrand.
Fixes: 3d7611e9 "st/nir: use NIR for asm programs"
---
Use of nir_variable_create was suggested by Jason Ekstrand.
Fixes: 3d7611e9 "st/nir: use NIR for asm programs"
---
src/mesa/program/prog_to_nir.c | 13 ++---
1 file changed, 6 insertions(+), 7 deletions(-)
diff --git a/src/mesa/program/prog_to_nir.c b/src/mesa/program/prog_to_nir.c
68 matches
Mail list logo
