Re: [Mesa-dev] [PATCH] mesa: require at least 14 UBOs for GL 4.3

extensions->ARB_ES3_compatibility && extensions->ARB_arrays_of_arrays && extensions->ARB_compute_shader && Reviewed-by: Brian Paul <bri...@vmware.com> __

Re: [Mesa-dev] [PATCH] util: fix NORETURN for msvc, add HAVE_FUNC_ATTRIBUTE_NORETURN to c99_compat.h

, but looks OK to me. Reviewed-by: Brian Paul <bri...@vmware.com> ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [PATCH] svga: update SVGA_NEW_ flags for updating sampler state

The SVGA_NEW_FS flag is needed since we now examine the fragment shader's fs_shadow_compare_units flags. The SVGA_NEW_TEXTURE_FLAGS flag is not needed since it's only for pre-VGPU10. No piglit changes. This doesn't fix any known issues but it could pop up somewhere. Suggested by Charmaine. ---

[Mesa-dev] [PATCH] svga: check for null fs pointer in update_samplers()

This can happen when there's no active fragment shader, such as when using transform feedback. This wasn't hit by any Piglit test but is hit by Daniel Rákos' Nature demo. VMware bug 2026189. --- src/gallium/drivers/svga/svga_state_sampler.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

[Mesa-dev] [PATCH] st/mesa: increase size of glsl_base_type bitfields

Change 59f458cd8703b97b31b8 added more enums to glsl_base_type. We have to bump up the size of the bitfields for fields of this type for MSVC. Also, add another assertion to catch another place where this enum bitfield is used. --- src/mesa/state_tracker/st_glsl_to_tgsi.cpp | 1 +

[Mesa-dev] [PATCH] svga: move variant->fs_shadow_compare_units assignment

Fixes a crash since the variant object isn't allocated until later in the function. Not sure how this got through. --- src/gallium/drivers/svga/svga_tgsi_vgpu10.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/gallium/drivers/svga/svga_tgsi_vgpu10.c

[Mesa-dev] [PATCH 1/2] tgsi: improve comment on tgsi_util_get_shadow_ref_src_index()

--- src/gallium/auxiliary/tgsi/tgsi_util.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/src/gallium/auxiliary/tgsi/tgsi_util.c b/src/gallium/auxiliary/tgsi/tgsi_util.c index 78a5413..a78172a 100644 --- a/src/gallium/auxiliary/tgsi/tgsi_util.c +++

[Mesa-dev] [PATCH 2/2] svga: use tgsi_util_get_shadow_ref_src_index() in a couple place

No piglit changes. --- src/gallium/drivers/svga/svga_tgsi_vgpu10.c | 29 +++-- 1 file changed, 7 insertions(+), 22 deletions(-) diff --git a/src/gallium/drivers/svga/svga_tgsi_vgpu10.c b/src/gallium/drivers/svga/svga_tgsi_vgpu10.c index 31149dd..3e4a6ed 100644 ---

[Mesa-dev] [PATCH 1/2] svga: fix shadow comparison failures

In some cases, We do shadow comparison cases in the fragment shader instead of with texture sampler state. But when we do so, we must disable the shadow comparison test in the sampler state. As it was, we were doing the comparison twice, which resulted in nonsense. Also, we had the texcoord and

[Mesa-dev] [PATCH 2/2] svga: fix TGSI_TEXTURE_SHADOW1D coordinate selection

Fixes about 24 Piglit tex-miplevel-selection tests. --- src/gallium/drivers/svga/svga_tgsi_vgpu10.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/src/gallium/drivers/svga/svga_tgsi_vgpu10.c b/src/gallium/drivers/svga/svga_tgsi_vgpu10.c index deb8e5a..31149dd 100644 ---

Re: [Mesa-dev] [PATCH] glsl: use bitwise operators in varying_matches::compute_packing_class()

Ping, anyone? -Brian On 12/18/2017 09:30 PM, Brian Paul wrote: The mix of bitwise operators with * and + to compute the packing_class values was a little weird. Just use bitwise ops instead. v2: add assertion to make sure interpolation bits fit without collision, per Timothy. Basically

[Mesa-dev] [PATCH] glsl: minor simplification in assign_varying_locations()

--- src/compiler/glsl/link_varyings.cpp | 8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/src/compiler/glsl/link_varyings.cpp b/src/compiler/glsl/link_varyings.cpp index 9039c3b..6d74f9a 100644 --- a/src/compiler/glsl/link_varyings.cpp +++

[Mesa-dev] [PATCH] glsl: use bitwise operators in varying_matches::compute_packing_class()

The mix of bitwise operators with * and + to compute the packing_class values was a little weird. Just use bitwise ops instead. v2: add assertion to make sure interpolation bits fit without collision, per Timothy. Basically, rewrite function to be simpler. ---

Re: [Mesa-dev] [PATCH 5/9] glsl: use bitwise operators in varying_matches::compute_packing_class()

On 12/18/2017 06:49 PM, Timothy Arceri wrote: On 19/12/17 07:47, Brian Paul wrote: The mix of bitwise operators with * and + to compute the packing_class values was a little weird. Just use bitwise ops instead. --- src/compiler/glsl/link_varyings.cpp | 7 --- 1 file changed, 4

[Mesa-dev] [PATCH 9/9] glsl: disable vec3 packing/splitting in tfb separate mode

This fixes a varying packing issue when using transform feedback in GL_SEPARATE_ATTRIBS mode. By time we get to linking, we already know that the number of feedback attributes is under the GL_MAX_TRANSFORM_FEEDBACK_SEPARATE_ATTRIBS limit so packing isn't as critical. In fact, packing/splitting

[Mesa-dev] [PATCH 4/9] glsl: simplify loop in varying_matches::assign_locations()

The use of break/continue was kind of weird/confusing. --- src/compiler/glsl/link_varyings.cpp | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/src/compiler/glsl/link_varyings.cpp b/src/compiler/glsl/link_varyings.cpp index 6d74f9a..7821b1e 100644 ---

[Mesa-dev] [PATCH 3/9] glsl: minor simplification in assign_varying_locations()

--- src/compiler/glsl/link_varyings.cpp | 8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/src/compiler/glsl/link_varyings.cpp b/src/compiler/glsl/link_varyings.cpp index 9039c3b..6d74f9a 100644 --- a/src/compiler/glsl/link_varyings.cpp +++

[Mesa-dev] [PATCH 8/9] glsl: simply packing class comparison

Handle comparing the packing class using the same method as we do for var->data.is_xfb_only --- src/compiler/glsl/link_varyings.cpp | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/compiler/glsl/link_varyings.cpp b/src/compiler/glsl/link_varyings.cpp index

[Mesa-dev] [PATCH 5/9] glsl: use bitwise operators in varying_matches::compute_packing_class()

The mix of bitwise operators with * and + to compute the packing_class values was a little weird. Just use bitwise ops instead. --- src/compiler/glsl/link_varyings.cpp | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/src/compiler/glsl/link_varyings.cpp

[Mesa-dev] [PATCH 1/9] glsl: trivial comment fix in lower_packed_varyings.cpp

--- src/compiler/glsl/lower_packed_varyings.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/compiler/glsl/lower_packed_varyings.cpp b/src/compiler/glsl/lower_packed_varyings.cpp index 1aec7ee..b840d26 100644 --- a/src/compiler/glsl/lower_packed_varyings.cpp +++

[Mesa-dev] [PATCH 7/9] glsl: document varying_matches::assign_locations() params and return value

And change *components to components[] as a reminder that it's an array. --- src/compiler/glsl/link_varyings.cpp | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/src/compiler/glsl/link_varyings.cpp b/src/compiler/glsl/link_varyings.cpp index 3de3f25..95306fa 100644

[Mesa-dev] [PATCH 2/9] glsl: make varying_matches::is_varying_packing_safe() const

--- src/compiler/glsl/link_varyings.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/compiler/glsl/link_varyings.cpp b/src/compiler/glsl/link_varyings.cpp index cadffeb..9039c3b 100644 --- a/src/compiler/glsl/link_varyings.cpp +++

[Mesa-dev] [PATCH 6/9] glsl: remove some continue statements

In some cases, I think loop code is easier to read without continue statements. --- src/compiler/glsl/link_varyings.cpp | 24 +++- 1 file changed, 11 insertions(+), 13 deletions(-) diff --git a/src/compiler/glsl/link_varyings.cpp b/src/compiler/glsl/link_varyings.cpp index

Re: [Mesa-dev] [PATCH 2/2] gallium/u_blitter: enable MSAA when blitting to MSAA surfaces

-by: Marek Olšák <marek.ol...@amd.com> Marek On Mon, Dec 11, 2017 at 9:09 PM, Brian Paul <bri...@vmware.com> wrote: If we're doing a Z -> Z MSAA blit (for example) we need to enable msaa rasterization when drawing the quads so that we can properly write the per-sample values. This

Re: [Mesa-dev] [PATCH 2/2] gallivm: fix an issue with NaNs with seamless cube filtering

[1], coord_bld->zero, > + GALLIVM_NAN_RETURN_OTHER_SECO > ND_NONNAN); >coord = lp_build_mul(coord_bld, coords[0], flt_width_vec); >/* instead of clamp, build mask if overflowed */ >coord = lp_build_sub(coord_bld, coord, half); >

[Mesa-dev] [PATCH] gallium/docs: document behavior of set_sample_mask()

The sample mask is used even if msaa is not explicity enabled when we have a framebuffer with multisampled surfaces. That's DX behavior and what the Radeon drivers do. Not sure about other drivers at this point. --- src/gallium/docs/source/context.rst | 5 - 1 file changed, 4 insertions(+),

[Mesa-dev] [PATCH 2/2] gallium/u_blitter: enable MSAA when blitting to MSAA surfaces

If we're doing a Z -> Z MSAA blit (for example) we need to enable msaa rasterization when drawing the quads so that we can properly write the per-sample values. This fixes a number of Piglit ext_framebuffer_multisample blit tests such as ext_framebuffer_multisample/no-color 2 depth combined with

[Mesa-dev] [PATCH 1/2] gallium/u_blitter: add code to save/set/restore min_samples for msaa

Will be used by the next patch. --- src/gallium/auxiliary/util/u_blitter.c | 8 src/gallium/auxiliary/util/u_blitter.h | 11 +++ 2 files changed, 19 insertions(+) diff --git a/src/gallium/auxiliary/util/u_blitter.c b/src/gallium/auxiliary/util/u_blitter.c index

Re: [Mesa-dev] [PATCH 1/2] gallium/u_blitter: enable MSAA when blitting to MSAA surfaces

On 12/11/2017 11:06 AM, Marek Olšák wrote: On Thu, Dec 7, 2017 at 5:09 PM, Brian Paul <bri...@vmware.com> wrote: If we're doing a Z -> Z MSAA blit (for example) we need to enable msaa rasterization when drawing the quads so that we can properly write the per-sample values. This fixes

[Mesa-dev] [PATCH] cso: add point rasterization sanity check assertion

--- src/gallium/auxiliary/cso_cache/cso_context.c | 5 + 1 file changed, 5 insertions(+) diff --git a/src/gallium/auxiliary/cso_cache/cso_context.c b/src/gallium/auxiliary/cso_cache/cso_context.c index df5543c..dd9821e 100644 --- a/src/gallium/auxiliary/cso_cache/cso_context.c +++

[Mesa-dev] [PATCH] xlib: call _mesa_warning() instead of fprintf()

We use _mesa_warning() everywhere else in this code. Change requested by Rick Irons of Mathworks. CC: --- src/mesa/drivers/x11/fakeglx.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/mesa/drivers/x11/fakeglx.c

[Mesa-dev] [PATCH] xlib: call _mesa_warning() instead of fprintf()

We use _mesa_warning() everywhere else in this code. Change requested by Rick Irons of Mathworks. CC: --- src/mesa/drivers/x11/fakeglx.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/mesa/drivers/x11/fakeglx.c

[Mesa-dev] [PATCH 2/2] gallium/util: don't pass a pipe_resource to util_resource_is_array_texture()

No need to pass a pipe_resource when we can just pass the target. This makes the function potentially more usable. Rename it too. --- src/gallium/auxiliary/util/u_resource.h | 6 +++--- src/gallium/drivers/radeon/r600_texture.c | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-) diff

[Mesa-dev] [PATCH 1/2] gallium/aux: include nr_samples in util_resource_size() computation

This function is only used in two places: 1. VMware driver, but only for HUD reporting 2. st/nine state tracker, used for texture memory accounting --- src/gallium/auxiliary/util/u_resource.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git

[Mesa-dev] [PATCH 1/2] gallium/u_blitter: enable MSAA when blitting to MSAA surfaces

If we're doing a Z -> Z MSAA blit (for example) we need to enable msaa rasterization when drawing the quads so that we can properly write the per-sample values. This fixes a number of Piglit ext_framebuffer_multisample blit tests such as ext_framebuffer_multisample/no-color 2 depth combined with

[Mesa-dev] [PATCH 2/2] gallium/u_blitter: replace tabs with spaces

--- src/gallium/auxiliary/util/u_blitter.c | 36 +- 1 file changed, 18 insertions(+), 18 deletions(-) diff --git a/src/gallium/auxiliary/util/u_blitter.c b/src/gallium/auxiliary/util/u_blitter.c index 2a2fd17..5e8800e 100644 ---

[Mesa-dev] [PATCH 2/2] mesa: add const qualifier on _mesa_is_renderable_texture_format()

--- src/mesa/main/teximage.c | 3 ++- src/mesa/main/teximage.h | 3 ++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/src/mesa/main/teximage.c b/src/mesa/main/teximage.c index 572e380..e5f8bb0 100644 --- a/src/mesa/main/teximage.c +++ b/src/mesa/main/teximage.c @@ -5712,7 +5712,8

[Mesa-dev] [PATCH 1/2] mesa: add const qualifier on _mesa_base_fbo_format()

--- src/mesa/main/fbobject.c | 2 +- src/mesa/main/fbobject.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/mesa/main/fbobject.c b/src/mesa/main/fbobject.c index 30287ab..d23916d 100644 --- a/src/mesa/main/fbobject.c +++ b/src/mesa/main/fbobject.c @@ -1804,7 +1804,7

[Mesa-dev] [PATCH 4/4] mesa: s/%u/%d/ in _mesa_error() call in check_layer()

The layer parameter is signed. Fixes the error message seen when running the arb_texture_multisample-errors test which checks a negative layer value. --- src/mesa/main/fbobject.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/mesa/main/fbobject.c

[Mesa-dev] [PATCH 1/4] mesa: add const qualifier in test_attachment_completeness()

--- src/mesa/main/fbobject.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mesa/main/fbobject.c b/src/mesa/main/fbobject.c index 8116563..f7702f1 100644 --- a/src/mesa/main/fbobject.c +++ b/src/mesa/main/fbobject.c @@ -793,7 +793,7 @@ test_attachment_completeness(const

[Mesa-dev] [PATCH 2/4] mesa: trivial whitespace fixes in transformfeedback.c

--- src/mesa/main/transformfeedback.c | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/src/mesa/main/transformfeedback.c b/src/mesa/main/transformfeedback.c index a5ea2a5..e4cc1db 100644 --- a/src/mesa/main/transformfeedback.c +++

[Mesa-dev] [PATCH 3/4] mesa: simplify/improve some _mesa_error() calls in teximage.c

--- src/mesa/main/teximage.c | 14 +- 1 file changed, 5 insertions(+), 9 deletions(-) diff --git a/src/mesa/main/teximage.c b/src/mesa/main/teximage.c index 41de966..572e380 100644 --- a/src/mesa/main/teximage.c +++ b/src/mesa/main/teximage.c @@ -5778,14 +5778,10 @@

[Mesa-dev] [PATCH 2/3] st/mesa: rename a few vars to 'bindings'

To be consistent. --- src/mesa/state_tracker/st_format.c | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/src/mesa/state_tracker/st_format.c b/src/mesa/state_tracker/st_format.c index da8b5e2..3f7e55e 100644 --- a/src/mesa/state_tracker/st_format.c +++

[Mesa-dev] [PATCH 3/3] st/mesa: remove unneeded #include in st_format.h

--- src/mesa/state_tracker/st_format.h | 1 - 1 file changed, 1 deletion(-) diff --git a/src/mesa/state_tracker/st_format.h b/src/mesa/state_tracker/st_format.h index 3dd9c10..466b5d0 100644 --- a/src/mesa/state_tracker/st_format.h +++ b/src/mesa/state_tracker/st_format.h @@ -33,7 +33,6 @@

[Mesa-dev] [PATCH 1/3] st/mesa: whitespace fixes in st_format.c

--- src/mesa/state_tracker/st_format.c | 18 +- 1 file changed, 13 insertions(+), 5 deletions(-) diff --git a/src/mesa/state_tracker/st_format.c b/src/mesa/state_tracker/st_format.c index 1ae677d..da8b5e2 100644 --- a/src/mesa/state_tracker/st_format.c +++

Re: [Mesa-dev] [PATCH 4/5] xlib: remove dummy GLX_MESA_set_3dfx_mode implementation

On 11/30/2017 12:21 PM, Emil Velikov wrote: On 30 November 2017 at 19:09, Ian Romanick wrote: Is xmesa.h something that apps could see? Removing stuff could, hypothetically, cause compilation problems... but also, app developers, fix your old crap. :) Some digging

Re: [Mesa-dev] [PATCH 2/2] glsl: Fix gl_NormalScale.

Reviewed-by: Brian Paul <bri...@vmware.com> On 11/23/2017 01:48 PM, Fabian Bieler wrote: GLSL shaders can access the normal scale factor with the built-in gl_NormalScale. Mesa's modelspace lighting optimization uses a different normal scale factor than defined in the spec. We have t

Re: [Mesa-dev] [PATCH 1/2] glsl: Match order of gl_LightSourceParameters elements.

Reviewed-by: Brian Paul <bri...@vmware.com> I think you could tag both of your patches for the stable branch. On 11/23/2017 01:48 PM, Fabian Bieler wrote: spotExponent and spotCosCutoff were swapped in the gl_builtin_uniform_element struct. Now the order matches

Re: [Mesa-dev] [PATCH] glx: add support for GLX_ARB_create_context_no_error (v2)

On 11/29/2017 02:30 PM, Adam Jackson wrote: On Wed, 2017-11-29 at 16:20 -0500, Adam Jackson wrote: From: Grigori Goronzy v2: Only reject no-error contexts for too-old GL if we're actually trying to create a no-error context (Adam Jackson) Reviewed-by: Adam Jackson

Re: [Mesa-dev] [PATCH 1/5] xlib: remove empty GLX_NV_vertex_array_range stubs

Series looks OK to me. Reviewed-by: Brian Paul <bri...@vmware.com> On 11/29/2017 12:23 PM, Emil Velikov wrote: From: Emil Velikov <emil.veli...@collabora.com> The extension was never implemented and seemingly never will. The DRI based libGL dropped support for it over 10 years ago

[Mesa-dev] [PATCH 1/2] svga: s/unsigned/SVGA3dDevCapIndex/

--- src/gallium/drivers/svga/svga_screen.c | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/src/gallium/drivers/svga/svga_screen.c b/src/gallium/drivers/svga/svga_screen.c index ab604b9..86f53b2 100644 --- a/src/gallium/drivers/svga/svga_screen.c +++

[Mesa-dev] [PATCH 2/2] svga: move svga_is_format_supported() to svga_format.c

where the other format-related functions live. --- src/gallium/drivers/svga/svga_format.c | 119 src/gallium/drivers/svga/svga_format.h | 10 +++ src/gallium/drivers/svga/svga_screen.c | 121 - 3 files changed, 129 insertions(+),

[Mesa-dev] [PATCH] r300: add PIPE_SHADER_CAP_MAX_HW_ATOMIC_COUNTER* switch cases

To silence compiler warnings. --- src/gallium/drivers/r300/r300_screen.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/gallium/drivers/r300/r300_screen.c b/src/gallium/drivers/r300/r300_screen.c index ac5208a..99d6302 100644 --- a/src/gallium/drivers/r300/r300_screen.c +++

[Mesa-dev] [PATCH] tgsi: bump tgsi_opcode_info::output_mode size to 4 bits

To avoid problems with MSVC. And verify size with ASSERT_BITFIELD_SIZE(). --- src/gallium/auxiliary/tgsi/tgsi_info.c | 2 ++ src/gallium/auxiliary/tgsi/tgsi_info.h | 2 +- 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/src/gallium/auxiliary/tgsi/tgsi_info.c

[Mesa-dev] [PATCH] tgsi: s/uint/enum pipe_shader_type/

--- src/gallium/auxiliary/tgsi/tgsi_info.c | 2 +- src/gallium/auxiliary/tgsi/tgsi_info.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/gallium/auxiliary/tgsi/tgsi_info.c b/src/gallium/auxiliary/tgsi/tgsi_info.c index 2baed5b..a204682 100644 ---

Re: [Mesa-dev] [PATCH v2 00/29] Silence some warnings that show up when compiling gallium/aux/util

On 11/17/2017 04:03 AM, Gert Wollny wrote: Hello Brian and Emil, considering Emils comments on the patches 17 and 29 I'd suggest to drop these two from the series. Regarding 29 (-Wmissing-field-initializers) I have to admit I'm not sure how to silence this in a save way other then really

Re: [Mesa-dev] [PATCH] util: add new ASSERT_BITFIELD_SIZE() macro (v3)

On 11/17/2017 04:59 AM, Eric Engestrom wrote: On Thursday, 2017-11-16 11:17:57 -0700, Brian Paul wrote: For checking that bitfields are large enough to hold the largest expected value. v2: move into existing util/macros.h header where STATIC_ASSERT() lives. v3: add MAYBE_UNUSED to variable

[Mesa-dev] [PATCH] svga: add missing PIPE_SHADER_CAP_MAX_HW_ATOMIC_COUNTER* cases

--- src/gallium/drivers/svga/svga_screen.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/gallium/drivers/svga/svga_screen.c b/src/gallium/drivers/svga/svga_screen.c index 8621640..ab604b9 100644 --- a/src/gallium/drivers/svga/svga_screen.c +++ b/src/gallium/drivers/svga/svga_screen.c

[Mesa-dev] [PATCH] util: add new ASSERT_BITFIELD_SIZE() macro (v3)

For checking that bitfields are large enough to hold the largest expected value. v2: move into existing util/macros.h header where STATIC_ASSERT() lives. v3: add MAYBE_UNUSED to variable declaration --- src/util/macros.h | 17 + 1 file changed, 17 insertions(+) diff --git

Re: [Mesa-dev] [PATCH v2 29/29] gallium/aux/util/u_tests.c: Fix warnigns triggered -Wmissing-field-initializers

In the subject "warnings" I can fix that before pushing. For the series, Reviewed-by: Brian Paul <bri...@vmware.com> On 11/16/2017 08:10 AM, Gert Wollny wrote: * Use a designated initializer to silence the warning. * fix one intention that was using tabs instead of sp

[Mesa-dev] [PATCH] util: add new ASSERT_BITFIELD_SIZE() macro (v2)

For checking that bitfields are large enough to hold the largest expected value. v2: move into existing util/macros.h header where STATIC_ASSERT() lives. --- src/util/macros.h | 16 1 file changed, 16 insertions(+) diff --git a/src/util/macros.h b/src/util/macros.h index

Re: [Mesa-dev] [PATCH] tgsi/exec: fix LDEXP in softpipe

Reviewed-by: Brian Paul <bri...@vmware.com> On 11/15/2017 11:35 AM, Nicolai Hähnle wrote: From: Nicolai Hähnle <nicolai.haeh...@amd.com> Bugzilla: https://urldefense.proofpoint.com/v2/url?u=https-3A__bugs.freedesktop.org_show-5Fbug.cgi-3Fid-3D103128=DwIGaQ=uilaK90D4T

[Mesa-dev] Fwd: [Mesa-users] Thank you! Keep up the good work for older AMD Cards!

FYI: Original Message Subject:[Mesa-users] Thank you! Keep up the good work for older AMD Cards! Date: Wed, 15 Nov 2017 13:56:22 +0100 From: Thomas Zoller To: mesa-us...@lists.freedesktop.org Hello, i only want to say THANK YOU to

[Mesa-dev] [PATCH 2/2] svga: s/unsigned/enum tgsi_texture_type/

--- src/gallium/drivers/svga/svga_tgsi_vgpu10.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/src/gallium/drivers/svga/svga_tgsi_vgpu10.c b/src/gallium/drivers/svga/svga_tgsi_vgpu10.c index 5fc93e2..c718eae 100644 --- a/src/gallium/drivers/svga/svga_tgsi_vgpu10.c

[Mesa-dev] [PATCH 1/2] tgsi: s/unsigned/enum tgsi_texture_type/

--- src/gallium/auxiliary/tgsi/tgsi_util.c | 6 +++--- src/gallium/auxiliary/tgsi/tgsi_util.h | 10 +- 2 files changed, 8 insertions(+), 8 deletions(-) diff --git a/src/gallium/auxiliary/tgsi/tgsi_util.c b/src/gallium/auxiliary/tgsi/tgsi_util.c index afe5690..6fc0530 100644 ---

Re: [Mesa-dev] [PATCH 08/23] gallium/aux/util/u_format_latc.c: Fix various -Wunused-param warnings,

On 11/12/2017 06:55 AM, Gert Wollny wrote: Decorate the unused params with "UNUSED". --- src/gallium/auxiliary/util/u_format_latc.c | 24 +--- 1 file changed, 17 insertions(+), 7 deletions(-) diff --git a/src/gallium/auxiliary/util/u_format_latc.c

Re: [Mesa-dev] [PATCH 03/23] gallium/aux/util/u_debug_stack.c: Silence -Wunused-result warning

)name); Indentation is wrong. Please use spaces. Same thing in patch 7. } mtx_unlock(_mutex); The series look OK otherwise. Reviewed-by: Brian Paul <bri...@vmware.com> ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 1/2] egl/haiku: Correct invalid void* conversion in calloc

) { _eglError(EGL_BAD_ALLOC, "_eglBuiltInDriverHaiku"); return NULL; For both, Reviewed-by: Brian Paul <bri...@vmware.com> Do you need me to push these for you? -Brian ___ mesa-dev maili

[Mesa-dev] [PATCH] docs: update llvmpipe.html build instructions

--- docs/llvmpipe.html | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/docs/llvmpipe.html b/docs/llvmpipe.html index 2efbbd4..e467692 100644 --- a/docs/llvmpipe.html +++ b/docs/llvmpipe.html @@ -108,10 +108,10 @@ To build everything on Linux invoke scons as: scons

[Mesa-dev] [PATCH] svga: issue debug warning for unsupported two-sided stencil state

We only have a single stencil read mask and write mask. Issue a warning if different front/back values are used. The Piglit gl-2.0-two-sided-stencil test hits this. --- src/gallium/drivers/svga/svga_pipe_depthstencil.c | 15 +++ 1 file changed, 15 insertions(+) diff --git

[Mesa-dev] [PATCH 1/2] st/mesa: move st_init_driver_flags() earlier in file

To get rid of forward declaration. --- src/mesa/state_tracker/st_context.c | 123 ++-- 1 file changed, 62 insertions(+), 61 deletions(-) diff --git a/src/mesa/state_tracker/st_context.c b/src/mesa/state_tracker/st_context.c index 8abf879..c52f42b 100644 ---

[Mesa-dev] [PATCH 2/2] st/mesa: move st_manager_destroy() earlier in file

To avoid forward declaration. --- src/mesa/state_tracker/st_manager.c | 28 +++- 1 file changed, 15 insertions(+), 13 deletions(-) diff --git a/src/mesa/state_tracker/st_manager.c b/src/mesa/state_tracker/st_manager.c index aedbc13..8a933d4 100644 ---

Re: [Mesa-dev] [PATCH] gallium/xlib: remove GL_{MAJOR,MINOR,TINY}

On 11/10/2017 11:08 AM, Emil Velikov wrote: On 10 November 2017 at 17:53, Dylan Baker wrote: These variables were removed from autotools in 2008 (sha: 80f68e1b6a0e5bd2da799c), but they have lived on here. The Scons build meanwhile doesn't set a patch/tiny version at all,

Re: [Mesa-dev] [PATCH] gallium/xlib: remove GL_{MAJOR,MINOR,TINY}

sets the version, leaving patch/tiny as 0 since that's what the autotools build as been doing forever. This shouldn't change any behavior. cc: Brian Paul <bri...@vmware.com> cc: Emil Velikov <emil.veli...@collabora.com> Signed-off-by: Dylan Baker <dylanx.c.ba...@intel.com> --- s

[Mesa-dev] [PATCH] docs: update llvmpipe.html build instructions

--- docs/llvmpipe.html | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/docs/llvmpipe.html b/docs/llvmpipe.html index 2efbbd4..e467692 100644 --- a/docs/llvmpipe.html +++ b/docs/llvmpipe.html @@ -108,10 +108,10 @@ To build everything on Linux invoke scons as: scons

Re: [Mesa-dev] [PATCH 3/4] glsl: s/unsigned/glsl_base_type/ in glsl type code (v2)

On 11/08/2017 08:27 PM, Brian Paul wrote: On 11/08/2017 08:12 PM, Brian Paul wrote: On 11/08/2017 06:28 PM, Ian Romanick wrote: Any thoughts about my data using __attribute__((__packed__))? Sorry, I didn't have time to dig into it. I took a look this evening. I think the ENUM_8BIT idea

Re: [Mesa-dev] [PATCH] util/u_thread: fix compilation on Mac OS

Reviewed-by: Brian Paul <bri...@vmware.com> Thanks. I was going to look into that one today. On 11/10/2017 04:38 AM, Nicolai Hähnle wrote: From: Nicolai Hähnle <nicolai.haeh...@amd.com> Apparently, it doesn't have pthread barriers. p_config.h (which was originally used to gua

Re: [Mesa-dev] [PATCH] threads: fix MinGW build breakage

aeh...@amd.com> On 09.11.2017 17:46, Brian Paul wrote: Fixes: f1a364878431c8 ("threads: update for late C11 changes") --- include/c11/threads_win32.h | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/include/c11/threads_win32.h b/include/c11/threads_win32.h index

[Mesa-dev] [PATCH 3/3] mesa: s/GLint/gl_buffer_index/ for _ColorDrawBufferIndexes

Also fix local variable declarations and replace -1 with BUFFER_NONE. No Piglit changes. --- src/mesa/drivers/common/meta.c | 2 +- src/mesa/main/buffers.c | 16 src/mesa/main/clear.c| 9 + src/mesa/main/framebuffer.c | 4

[Mesa-dev] [PATCH 1/3] mesa: minor reformatting, add const to gl_external_samplers()

This function should probably be moved elsewhere, too. --- src/mesa/main/mtypes.h | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/mesa/main/mtypes.h b/src/mesa/main/mtypes.h index d092630..af9115e 100644 --- a/src/mesa/main/mtypes.h +++ b/src/mesa/main/mtypes.h @@

[Mesa-dev] [PATCH 2/3] mesa: s/GLint/gl_buffer_index/ for _ColorReadBufferIndex

BUFFER_NONE is -1 so no reason for GLint. --- src/mesa/main/mtypes.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mesa/main/mtypes.h b/src/mesa/main/mtypes.h index af9115e..a8e2b39 100644 --- a/src/mesa/main/mtypes.h +++ b/src/mesa/main/mtypes.h @@ -3484,7 +3484,7 @@

[Mesa-dev] [PATCH] st/mesa: remove 'struct' keyword on function parameter

st_src_reg is a class, not a struct. Simply remove 'struct' to silence a MSVC compiler warning (class vs. struct mismatch). --- src/mesa/state_tracker/st_glsl_to_tgsi.cpp | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/mesa/state_tracker/st_glsl_to_tgsi.cpp

[Mesa-dev] [PATCH] threads: fix MinGW build breakage

Fixes: f1a364878431c8 ("threads: update for late C11 changes") --- include/c11/threads_win32.h | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/include/c11/threads_win32.h b/include/c11/threads_win32.h index 77d923a..dac8ef7 100644 --- a/include/c11/threads_win32.h +++

Re: [Mesa-dev] [PATCH] mesa: replace GLenum with GLenum16 in common structures

On 11/08/2017 08:16 PM, Marek Olšák wrote: From: Marek Olšák For lower CPU cache usage. All enums fit within 2 bytes. gl_context = 152400 -> 136824 bytes Wow. vbo_context = 22696 -> 21520 bytes --- src/mesa/drivers/dri/nouveau/nv04_state_frag.c | 4 +-

Re: [Mesa-dev] [PATCH 3/4] glsl: s/unsigned/glsl_base_type/ in glsl type code (v2)

On 11/08/2017 08:12 PM, Brian Paul wrote: On 11/08/2017 06:28 PM, Ian Romanick wrote: Any thoughts about my data using __attribute__((__packed__))? Sorry, I didn't have time to dig into it. I took a look this evening. I think the ENUM_8BIT idea will work for GCC and MSVC but only for C

Re: [Mesa-dev] [PATCH 3/4] glsl: s/unsigned/glsl_base_type/ in glsl type code (v2)

, Brian Paul wrote: Declare glsl_type::sampled_type as glsl_base_type as we do for the base_type field. And make base_type a bitfield to save a few bytes. Update glsl_type constructor to take glsl_base_type instead of unsigned and pass GLSL_TYPE_VOID instead of zero. No Piglit regressions

[Mesa-dev] [PATCH 2/4] st/mesa: use enum types instead of int/unsigned (v3)

Use the proper enum types for various variables. Makes life in gdb a little nicer. Note that the size of enum bitfields must be one larger so the high bit is always zero (for MSVC). v2: also increase size of image_format bitfield, per Eric Engestrom. v3: use the new ASSERT_BITFIELD_SIZE() macro

[Mesa-dev] [PATCH 3/4] glsl: s/unsigned/glsl_base_type/ in glsl type code (v2)

Declare glsl_type::sampled_type as glsl_base_type as we do for the base_type field. And make base_type a bitfield to save a few bytes. Update glsl_type constructor to take glsl_base_type instead of unsigned and pass GLSL_TYPE_VOID instead of zero. No Piglit regressions with llvmpipe. v2: -

[Mesa-dev] [PATCH 1/4] util: add new bitfield_assert.h header

Contains a macro for checking that bitfields are large enough to hold the largest expected value. --- src/util/bitfield_assert.h | 49 ++ 1 file changed, 49 insertions(+) create mode 100644 src/util/bitfield_assert.h diff --git

[Mesa-dev] [PATCH 4/4] util/tgsi: use ASSERT_BITFIELD_SIZE() to check opcode field size

I've noticed at least two places where we store the TGSI opcode in an unsigned:8 bitfield. We're at 249 opcodes now. If we hit 256 we'll need to grow those bitfields. Use the new ASSERT_BITFIELD_SIZE() macro to detect that. --- src/gallium/auxiliary/tgsi/tgsi_info.c | 3 +++ 1 file changed, 3

Re: [Mesa-dev] [PATCH] st/mesa: use enum types instead of int/unsigned (v2)

On 11/07/2017 11:09 AM, Roland Scheidegger wrote: Am 07.11.2017 um 18:57 schrieb Brian Paul: On 11/07/2017 09:07 AM, Roland Scheidegger wrote: Am 07.11.2017 um 16:12 schrieb Brian Paul: Use the proper enum types for various variables. Makes life in gdb a little nicer. Note that the size

Re: [Mesa-dev] [PATCH] st/mesa: use enum types instead of int/unsigned (v2)

On 11/07/2017 09:07 AM, Roland Scheidegger wrote: Am 07.11.2017 um 16:12 schrieb Brian Paul: Use the proper enum types for various variables. Makes life in gdb a little nicer. Note that the size of enum bitfields must be one larger so the high bit is always zero (for MSVC). v2: also increase

[Mesa-dev] [PATCH] util/tgsi: add static assertion to catch opcode overflowing bitfield

I've noticed at least two places where we store the TGSI opcode in an unsigned:8 bitfield. We're at 249 opcodes now. If we hit 256 we'll need to grow those bitfields. Add a static assertion to detect that. --- src/gallium/auxiliary/tgsi/tgsi_info.c | 5 + 1 file changed, 5 insertions(+)

Re: [Mesa-dev] [PATCH 1/2] st/mesa: use enum types instead of int/unsigned

On 11/07/2017 07:20 AM, Eric Engestrom wrote: On Tuesday, 2017-11-07 07:07:55 -0700, Brian Paul wrote: On 11/07/2017 03:36 AM, Eric Engestrom wrote: On Monday, 2017-11-06 14:00:30 -0700, Brian Paul wrote: Use the proper enum types for various variables. Makes life in gdb a little nicer

[Mesa-dev] [PATCH] st/mesa: use enum types instead of int/unsigned (v2)

Use the proper enum types for various variables. Makes life in gdb a little nicer. Note that the size of enum bitfields must be one larger so the high bit is always zero (for MSVC). v2: also increase size of image_format bitfield, per Eric Engestrom. Reviewed-by: Charmaine Lee

Re: [Mesa-dev] [PATCH] docs: Fix GL_MESA_program_debug enums

_INCREASING_X_MESA 0x8BB9 Reviewed-by: Brian Paul <bri...@vmware.com> ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 1/2] st/mesa: use enum types instead of int/unsigned

On 11/07/2017 03:36 AM, Eric Engestrom wrote: On Monday, 2017-11-06 14:00:30 -0700, Brian Paul wrote: Use the proper enum types for various variables. Makes life in gdb a little nicer. --- src/mesa/state_tracker/st_glsl_to_tgsi.cpp | 7 --- src/mesa/state_tracker

Re: [Mesa-dev] [PATCH 00/13] mesa: MESA_EXTENSION_OVERRIDE related fixes

can pick nearly any patch independently of the rest. Please review Emil Series looks good to me. Reviewed-by: Brian Paul <bri...@vmware.com> ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinf

Re: [Mesa-dev] Announcement: Meson build type change

On 11/07/2017 05:25 AM, Eric Engestrom wrote: Hi all, As a result of the discussion that started with this message: https://lists.freedesktop.org/archives/mesa-dev/2017-November/175104.html The default build type for Meson builds has been changed to `debugoptimized` in commit

Re: [Mesa-dev] [PATCH] glsl: s/unsigned/glsl_base_type/ in glsl type code

On 11/06/2017 02:27 PM, Ian Romanick wrote: On 11/06/2017 01:00 PM, Brian Paul wrote: Declare glsl_type::sampled_type as glsl_base_type as we do for the base_type field. And make base_type a bitfield to save a few bytes. Hmm... I have mixed feelings about this. I made a conscious decision

<    2   3   4   5   6   7   8   9   10   11   >