[Mesa-dev] [PATCH 03/14] mesa/st: Set _NumSamples in update_framebuffer_state()

Using PIPE_FORMAT_NONE to indicate what MSAA modes are supported with a framebuffer using no attachment. V.2: Rewrite MSAA mode loop to be more general. V.3: Move comment to right place after loop was rewritten. Signed-off-by: Edward O'Callaghan <eocallag...@alterapraxis.com> --- sr

[Mesa-dev] [PATCH 07/14] gallium/trace: Dump no.of samples and layers in fb state

Signed-off-by: Edward O'Callaghan <eocallag...@alterapraxis.com> Reviewed-by: Marek Olšák <marek.ol...@amd.com> --- src/gallium/drivers/trace/tr_dump_state.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/gallium/drivers/trace/tr_dump_state.c b/src/gallium/d

[Mesa-dev] radeonsi,r600g ARB_framebuffer_no_attachments rebased

ally that need the support are happy and works as expected. The series is also available as the ARB_framebuffer_no_attachments-radeonsi branches of - https://github.com/victoredwardocallaghan/mesa-GLwork Edward O'Callaghan (14): gallium: Add PIPE_CAP_FRAMEBUFFER_NO_ATTACHMENT gallium: Ob

[Mesa-dev] [PATCH 14/14] GL3.txt: Mark ARB_framebuffer_no_attachments as done

Signed-off-by: Edward O'Callaghan <eocallag...@alterapraxis.com> Reviewed-by: Marek Olšák <marek.ol...@amd.com> --- docs/GL3.txt | 2 +- docs/relnotes/11.3.0.html | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/docs/GL3.txt b/docs/GL3.txt index 03eb

[Mesa-dev] [PATCH 05/14] mesa/st: Use _mesa_geometric_ functions appropriately

of the gl_framebuffer. This patch paves the way to enable GL_ARB_framebuffer_no_attachements for all gallium drivers. V.2: Remove itermeditate variable state. Signed-off-by: Edward O'Callaghan <eocallag...@alterapraxis.com> Reviewed-by: Ilia Mirkin <imir...@alum.mit.edu> Reviewed-by: Brian Paul <br

[Mesa-dev] [PATCH 10/14] radeonsi: Allow 16 samples MSAA mode for PIPE_FORMAT_NONE

For ARB_framebuffer_no_attachment; A is_format_supported() query with 'PIPE_FORMAT_NONE' passed implies a query of the number of samples supported from the framebuffer with no attachment. Signed-off-by: Edward O'Callaghan <eocallag...@alterapraxis.com> Reviewed-by: Marek Olšák <

[Mesa-dev] [PATCH 04/14] mesa: Add comment to framebuffer_parameteri()

V.2: Change 'N.B.,' to 'NOTE:'. Signed-off-by: Edward O'Callaghan <eocallag...@alterapraxis.com> --- src/mesa/main/fbobject.c | 5 + 1 file changed, 5 insertions(+) diff --git a/src/mesa/main/fbobject.c b/src/mesa/main/fbobject.c index bb8d4c3..c81f5a0 100644 --- a/src/mesa/main/fbob

[Mesa-dev] [PATCH 13/14] r600g: Enable ARB_framebuffer_no_attachments

Signed-off-by: Edward O'Callaghan <eocallag...@alterapraxis.com> Reviewed-by: Marek Olšák <marek.ol...@amd.com> --- src/gallium/drivers/r600/r600_pipe.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/drivers/r600/r600_pipe.c b/src/gallium/drivers/r600

[Mesa-dev] [PATCH 09/14] softpipe: Set samples and layers in set_framebuffer_state() cb

Carries across the number of samples and layers state in the 'softpipe_set_framebuffer_state()' callback. This state is part of 'ARB_framebuffer_no_attachments' support. Signed-off-by: Edward O'Callaghan <eocallag...@alterapraxis.com> Reviewed-by: Marek Olšák <marek.ol...@amd.com&

[Mesa-dev] [PATCH 03/14] mesa/st: Set _NumSamples in update_framebuffer_state()

Using PIPE_FORMAT_NONE to indicate what MSAA modes are supported with a framebuffer using no attachment. V.2: Rewrite MSAA mode loop to be more general. V.3: Move comment to right place after loop was rewritten. Signed-off-by: Edward O'Callaghan <eocallag...@alterapraxis.com> --- sr

[Mesa-dev] [PATCH 11/14] radeonsi: Improve assert info out of si_set_framebuffer_state()

Lets give the developer a little hand if we are going to assert on a zero literal at the end of a branch. Signed-off-by: Edward O'Callaghan <eocallag...@alterapraxis.com> Reviewed-by: Marek Olšák <marek.ol...@amd.com> --- src/gallium/drivers/radeonsi/si_state.c | 2 ++ 1 fil

[Mesa-dev] [PATCH 12/14] radeonsi: Enable ARB_framebuffer_no_attachments

Signed-off-by: Edward O'Callaghan <eocallag...@alterapraxis.com> Reviewed-by: Marek Olšák <marek.ol...@amd.com> --- src/gallium/drivers/radeonsi/si_pipe.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/drivers/radeonsi/si_pipe.c b/src/gallium/driv

[Mesa-dev] [PATCH 06/14] gallium: Put no.of {samples, layers} into pipe_framebuffer_state

. Signed-off-by: Edward O'Callaghan <eocallag...@alterapraxis.com> Reviewed-by: Marek Olšák <marek.ol...@amd.com> --- src/gallium/auxiliary/util/u_dump_state.c | 2 ++ src/gallium/auxiliary/util/u_framebuffer.c | 30 ++ src/gallium/include/pipe/p_state.h

[Mesa-dev] [PATCH 08/14] mesa/st: Update framebuffer state with no.of samples, layers

Handle the case of ARB_framebuffer_no_attachment. Also, kill off a dead debug printf() call while we are here. Signed-off-by: Edward O'Callaghan <eocallag...@alterapraxis.com> Reviewed-by: Marek Olšák <marek.ol...@amd.com> --- src/mesa/state_tracker/st_atom_framebuffer.c | 8

[Mesa-dev] [PATCH 01/14] gallium: Add PIPE_CAP_FRAMEBUFFER_NO_ATTACHMENT

the application using 'GL_ARB_framebuffer_no_attachments' may be quantized to what the hardware expects. V.2: Fix doc for a more detailed description of the PIPE_CAP and the corresponding GL constant. V.3: Renamed and repurposed once again. V.4: Remove CAP from cap_mapping array. Signed-off-by: Edward

[Mesa-dev] [PATCH] mesa/st: Avoid a NULL-ptr dereference on possible missing callback

Just because we miss a gallium driver callback don't dereference invalid memory. Signed-off-by: Edward O'Callaghan <eocallag...@alterapraxis.com> --- src/mesa/state_tracker/st_cb_queryobj.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/mesa/state_tracker/st_cb_queryobj.c b/sr

[Mesa-dev] [PATCH] nv50: Dont illegally change format after surface_create() call

This was the wrong way to force a resource format, fix it in nv50. NOTE: Needs testing from someone with nv hw. Signed-off-by: Edward O'Callaghan <eocallag...@alterapraxis.com> --- src/gallium/drivers/nouveau/nv50/nv50_surface.c | 67 - 1 file changed, 33 inse

[Mesa-dev] [PATCH 12/14] radeonsi: Enable ARB_framebuffer_no_attachments

Signed-off-by: Edward O'Callaghan <eocallag...@alterapraxis.com> --- src/gallium/drivers/radeonsi/si_pipe.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/drivers/radeonsi/si_pipe.c b/src/gallium/drivers/radeonsi/si_pipe.c index abb39e4..da918d9 100644 ---

[Mesa-dev] [PATCH 05/14] mesa/st: Use _mesa_geometric_ functions appropriately

of the gl_framebuffer. This patch paves the way to enable GL_ARB_framebuffer_no_attachements for all gallium drivers. V.2: Remove itermeditate variable state. Signed-off-by: Edward O'Callaghan <eocallag...@alterapraxis.com> Reviewed-by: Ilia Mirkin <imir...@alum.mit.edu> Reviewed-by: Brian Paul <br

[Mesa-dev] [PATCH 13/14] r600g: Enable ARB_framebuffer_no_attachments

Signed-off-by: Edward O'Callaghan <eocallag...@alterapraxis.com> --- src/gallium/drivers/r600/r600_pipe.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/drivers/r600/r600_pipe.c b/src/gallium/drivers/r600/r600_pipe.c index 4b91874..7b4f9cb 100644 ---

[Mesa-dev] [PATCH 08/14] mesa/st: Update framebuffer state with no.of samples, layers

Handle the case of ARB_framebuffer_no_attachment. Also, kill off a dead debug printf() call while we are here. Signed-off-by: Edward O'Callaghan <eocallag...@alterapraxis.com> Reviewed-by: Marek Olšák <marek.ol...@amd.com> --- src/mesa/state_tracker/st_atom_framebuffer.c | 8

[Mesa-dev] [PATCH 06/14] gallium: Put no.of {samples, layers} into pipe_framebuffer_state

. Signed-off-by: Edward O'Callaghan <eocallag...@alterapraxis.com> Reviewed-by: Marek Olšák <marek.ol...@amd.com> --- src/gallium/auxiliary/util/u_dump_state.c | 2 ++ src/gallium/auxiliary/util/u_framebuffer.c | 30 ++ src/gallium/include/pipe/p_state.h

[Mesa-dev] [PATCH 14/14] GL3.txt: Mark ARB_framebuffer_no_attachments as done

Signed-off-by: Edward O'Callaghan <eocallag...@alterapraxis.com> --- docs/GL3.txt | 2 +- docs/relnotes/11.3.0.html | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/docs/GL3.txt b/docs/GL3.txt index 88c14c4..2468251 100644 --- a/docs/GL3.txt +++ b/docs/G

[Mesa-dev] [PATCH 02/14] gallium: Obtain ARB_framebuffer_no_attachment constants

Set default values for the constants required in ARB_framebuffer_no_attachments and obtained the number of layers from ``PIPE_CAP_MAX_TEXTURE_ARRAY_LAYERS``. We also obtain the MaxFramebufferSamples value using a query back to the driver for PIPE_FORMAT_NONE. Signed-off-by: Edward O'Callaghan

[Mesa-dev] [PATCH 04/14] mesa: Add comment to framebuffer_parameteri()

Signed-off-by: Edward O'Callaghan <eocallag...@alterapraxis.com> --- src/mesa/main/fbobject.c | 5 + 1 file changed, 5 insertions(+) diff --git a/src/mesa/main/fbobject.c b/src/mesa/main/fbobject.c index bb8d4c3..42f40b2 100644 --- a/src/mesa/main/fbobject.c +++ b/src/mesa/main/fbob

[Mesa-dev] [PATCH 09/14] softpipe: Set samples and layers in set_framebuffer_state() cb

Carries across the number of samples and layers state in the 'softpipe_set_framebuffer_state()' callback. This state is part of 'ARB_framebuffer_no_attachments' support. Signed-off-by: Edward O'Callaghan <eocallag...@alterapraxis.com> Reviewed-by: Marek Olšák <marek.ol...@amd.com&

[Mesa-dev] [PATCH 11/14] radeonsi: Improve assert info out of si_set_framebuffer_state()

Lets give the developer a little hand if we are going to assert on a zero literal at the end of a branch. Signed-off-by: Edward O'Callaghan <eocallag...@alterapraxis.com> --- src/gallium/drivers/radeonsi/si_state.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/gallium/d

[Mesa-dev] [PATCH 01/14] gallium: Add PIPE_CAP_FRAMEBUFFER_NO_ATTACHMENT

the application using 'GL_ARB_framebuffer_no_attachments' may be quantized to what the hardware expects. V.2: Fix doc for a more detailed description of the PIPE_CAP and the corresponding GL constant. V.3: Renamed and repurposed once again. Signed-off-by: Edward O'Callaghan <eocallag...@alterapraxis.

[Mesa-dev] [PATCH 03/14] mesa/st: Set _NumSamples in update_framebuffer_state()

Using PIPE_FORMAT_NONE to indicate what MSAA modes are supported with a framebuffer using no attachment. V.2: Rewrite MSAA mode loop to be more general. Signed-off-by: Edward O'Callaghan <eocallag...@alterapraxis.com> --- src/mesa/state_tracker/st_atom_framebuffer.

[Mesa-dev] [PATCH 10/14] radeonsi: Allow 16 samples MSAA mode for PIPE_FORMAT_NONE

For ARB_framebuffer_no_attachment; A is_format_supported() query with 'PIPE_FORMAT_NONE' passed implies a query of the number of samples supported from the framebuffer with no attachment. Signed-off-by: Edward O'Callaghan <eocallag...@alterapraxis.com> --- src/gallium/drivers/radeonsi/si_s

[Mesa-dev] [PATCH 07/14] gallium/trace: Dump no.of samples and layers in fb state

Signed-off-by: Edward O'Callaghan <eocallag...@alterapraxis.com> Reviewed-by: Marek Olšák <marek.ol...@amd.com> --- src/gallium/drivers/trace/tr_dump_state.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/gallium/drivers/trace/tr_dump_state.c b/src/gallium/d

[Mesa-dev] V.+9000 ARB_framebuffer_no_attachment

Here we go again.. ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [PATCH] gallium/p_context.h: Make comment more readable

Signed-off-by: Edward O'Callaghan <eocallag...@alterapraxis.com> --- src/gallium/include/pipe/p_context.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/include/pipe/p_context.h b/src/gallium/include/pipe/p_context.h index ee68fdd..1c97e82 100644 ---

[Mesa-dev] [PATCH 1/3] radeon/r600_query.c: Minor style fix

Signed-off-by: Edward O'Callaghan <eocallag...@alterapraxis.com> Reviewed-by: Nicolai Hähnle <nicolai.haeh...@amd.com> --- src/gallium/drivers/radeon/r600_query.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/drivers/radeon/r600_query.c b/src/gal

[Mesa-dev] [PATCH 3/3] mesa/st: Remove GLSLVersion clamping

While here, remove itermediate glsl_feature_level variable. Signed-off-by: Edward O'Callaghan <eocallag...@alterapraxis.com> --- src/mesa/state_tracker/st_extensions.c | 15 +-- 1 file changed, 5 insertions(+), 10 deletions(-) diff --git a/src/mesa/state_tracker/st_extension

[Mesa-dev] V.2 Misc asortment of minor fixes

This series; * Minor style fix * Return type warning * Removes GLSL version clamping for higher than 4.1. Remove 'glsl_feature_level' itermediate variable and use 'consts->GLSLVersion' directly following Nicolai's advice. ___ mesa-dev mailing list

[Mesa-dev] [PATCH 2/3] radeon/r600: Fix return type in failure branch

Commit `d4e847ea` introduced a warning about making an integer from a pointer without a cast, fix it here. Signed-off-by: Edward O'Callaghan <eocallag...@alterapraxis.com> --- src/gallium/drivers/radeon/r600_texture.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[Mesa-dev] [PATCH 02/17] gallium: Obtain ARB_framebuffer_no_attachment constants

Set default values for the constants required in ARB_framebuffer_no_attachments and obtained the number of layers from ``PIPE_CAP_MAX_TEXTURE_ARRAY_LAYERS``. We also obtain the MaxFramebufferSamples value using a query back to the driver for PIPE_FORMAT_NONE. Signed-off-by: Edward O'Callaghan

[Mesa-dev] [PATCH 04/17] mesa: Add comment to framebuffer_parameteri()

Signed-off-by: Edward O'Callaghan <eocallag...@alterapraxis.com> --- src/mesa/main/fbobject.c | 5 + 1 file changed, 5 insertions(+) diff --git a/src/mesa/main/fbobject.c b/src/mesa/main/fbobject.c index bb8d4c3..42f40b2 100644 --- a/src/mesa/main/fbobject.c +++ b/src/mesa/main/fbob

[Mesa-dev] [PATCH 09/17] softpipe: Set samples and layers in set_framebuffer_state() cb

Carries across the number of samples and layers state in the 'softpipe_set_framebuffer_state()' callback. This state is part of 'ARB_framebuffer_no_attachments' support. Signed-off-by: Edward O'Callaghan <eocallag...@alterapraxis.com> Reviewed-by: Marek Olšák <marek.ol...@amd.com&

[Mesa-dev] [PATCH 06/17] gallium: Put no.of {samples, layers} into pipe_framebuffer_state

in util_framebuffer_get_num_layers() and util_framebuffer_get_num_samples() to their canonical form. V3: 'git stash pop' the typo fix of 'cbufs' which should be 'nr_cbufs' that was missing in V2, woops! Thanks Marek for pointing this out yet again. Signed-off-by: Edward O'Callaghan <eocallag...@alterapraxis.

[Mesa-dev] [PATCH 01/17] gallium: Add PIPE_CAP_FRAMEBUFFER_NO_ATTACHMENT

the application using 'GL_ARB_framebuffer_no_attachments' may be quantized to what the hardware expects. V.2: Fix doc for a more detailed description of the PIPE_CAP and the corresponding GL constant. V.3: Renamed and repurposed once again. Signed-off-by: Edward O'Callaghan <eocallag...@alterapraxis.

[Mesa-dev] [PATCH 03/17] mesa/st: Set _NumSamples in update_framebuffer_state()

Using PIPE_FORMAT_NONE to indicate what MSAA modes are supported with a framebuffer using no attachment. Signed-off-by: Edward O'Callaghan <eocallag...@alterapraxis.com> --- src/mesa/state_tracker/st_atom_framebuffer.c | 51 1 file changed, 51 insertions(+)

[Mesa-dev] [PATCH 05/17] mesa/st: Use _mesa_geometric_ functions appropriately

of the gl_framebuffer. This patch paves the way to enable GL_ARB_framebuffer_no_attachements for all gallium drivers. Signed-off-by: Edward O'Callaghan <eocallag...@alterapraxis.com> Reviewed-by: Ilia Mirkin <imir...@alum.mit.edu> Reviewed-by: Brian Paul <bri...@vmware.com> Reviewed-by: Mar

[Mesa-dev] [PATCH 07/17] gallium/trace: Dump no.of samples and layers in fb state

Signed-off-by: Edward O'Callaghan <eocallag...@alterapraxis.com> Reviewed-by: Marek Olšák <marek.ol...@amd.com> --- src/gallium/drivers/trace/tr_dump_state.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/gallium/drivers/trace/tr_dump_state.c b/src/gallium/d

[Mesa-dev] [PATCH 11/17] radeonsi: Allow 16 samples MSAA mode for PIPE_FORMAT_NONE

For ARB_framebuffer_no_attachment; A is_format_supported() query with 'PIPE_FORMAT_NONE' passed implies a query of the number of samples supported from the framebuffer with no attachment. Signed-off-by: Edward O'Callaghan <eocallag...@alterapraxis.com> --- src/gallium/drivers/radeonsi/si_s

[Mesa-dev] [PATCH 12/17] radeonsi: Improve assert info out of si_set_framebuffer_state()

Lets give the developer a little hand if we are going to assert on a zero literal at the end of a branch. Signed-off-by: Edward O'Callaghan <eocallag...@alterapraxis.com> --- src/gallium/drivers/radeonsi/si_state.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/gallium/d

[Mesa-dev] [PATCH 16/17] nvc0: Enable ARB_framebuffer_no_attachment

Signed-off-by: Edward O'Callaghan <eocallag...@alterapraxis.com> --- src/gallium/drivers/nouveau/nvc0/nvc0_screen.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/drivers/nouveau/nvc0/nvc0_screen.c b/src/gallium/drivers/nouveau/nvc0/nvc0_screen.c index d

[Mesa-dev] [PATCH 13/17] radeonsi: Enable ARB_framebuffer_no_attachments

Signed-off-by: Edward O'Callaghan <eocallag...@alterapraxis.com> --- src/gallium/drivers/radeonsi/si_pipe.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/drivers/radeonsi/si_pipe.c b/src/gallium/drivers/radeonsi/si_pipe.c index 51ebb96..d00e562 100644 ---

[Mesa-dev] [PATCH 15/17] nvc0: handle the case where there are no framebuffer attachments

From: Ilia Mirkin <imir...@alum.mit.edu> Signed-off-by: Ilia Mirkin <imir...@alum.mit.edu> Reviewed-by: Edward O'Callaghan <eocallag...@alterapraxis.com> --- src/gallium/drivers/nouveau/nvc0/nvc0_program.c| 7 +++ src/gallium/drivers/nouveau/nvc0/nvc0_sta

[Mesa-dev] [PATCH 17/17] GL3.txt: Mark ARB_framebuffer_no_attachments as done

Signed-off-by: Edward O'Callaghan <eocallag...@alterapraxis.com> --- docs/GL3.txt | 2 +- docs/relnotes/11.3.0.html | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/docs/GL3.txt b/docs/GL3.txt index 88c14c4..8cb17f3 100644 --- a/docs/GL3.txt +++ b/docs/G

[Mesa-dev] [PATCH 14/17] r600g: Enable ARB_framebuffer_no_attachments

Signed-off-by: Edward O'Callaghan <eocallag...@alterapraxis.com> --- src/gallium/drivers/r600/r600_pipe.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/drivers/r600/r600_pipe.c b/src/gallium/drivers/r600/r600_pipe.c index 4b91874..7b4f9cb 100644 ---

[Mesa-dev] [PATCH 10/17] gallium/util: Ensure util_framebuffer_get_num_samples() is valid

ad of "N.B." in comment. Signed-off-by: Edward O'Callaghan <eocallag...@alterapraxis.com> Reviewed-by: Marek Olšák <marek.ol...@amd.com> --- src/gallium/auxiliary/util/u_framebuffer.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/src/gallium/auxiliary/uti

[Mesa-dev] [PATCH 08/17] mesa/st: Update framebuffer state with no.of samples, layers

Handle the case of ARB_framebuffer_no_attachment. Also, kill off a dead debug printf() call while we are here. Signed-off-by: Edward O'Callaghan <eocallag...@alterapraxis.com> Reviewed-by: Marek Olšák <marek.ol...@amd.com> --- src/mesa/state_tracker/st_atom_framebuffer.c | 8

[Mesa-dev] ARB_framebuffer_no_attachment - final for real this time

I hope to have finally addressed everything by now, fingers crossed. ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [PATCH 3/3] mesa/st: Remove GLSLVersion clamping

Signed-off-by: Edward O'Callaghan <eocallag...@alterapraxis.com> --- src/mesa/state_tracker/st_extensions.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/src/mesa/state_tracker/st_extensions.c b/src/mesa/state_tracker/st_extensions.c index b03f531..6645189

[Mesa-dev] [PATCH 2/3] mesa/st: Trivial, use glsl_feature_level var consistently

Signed-off-by: Edward O'Callaghan <eocallag...@alterapraxis.com> --- src/mesa/state_tracker/st_extensions.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/mesa/state_tracker/st_extensions.c b/src/mesa/state_tracker/st_extensions.c index 2fdaba0..b03f531

[Mesa-dev] Misc asortment of minor fixes

The only functional change in this series is taking off the breaks on higher GLSL versions than 4.1. This will likely be relevant by weeks end. ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org

[Mesa-dev] [PATCH 1/3] radeon/r600_query.c: Minor style fix

Signed-off-by: Edward O'Callaghan <eocallag...@alterapraxis.com> --- src/gallium/drivers/radeon/r600_query.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/drivers/radeon/r600_query.c b/src/gallium/drivers/radeon/r600_query.c index f8b6241..f9a5721

[Mesa-dev] [PATCH 09/17] softpipe: Set samples and layers in set_framebuffer_state() cb

Carries across the number of samples and layers state in the 'softpipe_set_framebuffer_state()' callback. This state is part of 'ARB_framebuffer_no_attachments' support. Signed-off-by: Edward O'Callaghan <eocallag...@alterapraxis.com> --- src/gallium/drivers/softpipe/sp_state_surface.c | 2

[Mesa-dev] [PATCH 17/17] GL3.txt: Mark ARB_framebuffer_no_attachments as done

Signed-off-by: Edward O'Callaghan <eocallag...@alterapraxis.com> --- docs/GL3.txt | 2 +- docs/relnotes/11.3.0.html | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/docs/GL3.txt b/docs/GL3.txt index 3058996..b9fc86b 100644 --- a/docs/GL3.txt +++ b/docs/G

[Mesa-dev] [PATCH 06/17] gallium: Put no.of {samples, layers} into pipe_framebuffer_state

in util_framebuffer_get_num_layers() and util_framebuffer_get_num_samples() to their canonical form. V3: 'git stash pop' the typo fix of 'cbufs' which should be 'nr_cbufs' that was missing in V2, woops! Thanks Marek for pointing this out yet again. Signed-off-by: Edward O'Callaghan <eocallag...@alterapraxis.

[Mesa-dev] [PATCH 16/17] nvc0: Enable ARB_framebuffer_no_attachment

Signed-off-by: Edward O'Callaghan <eocallag...@alterapraxis.com> --- src/gallium/drivers/nouveau/nvc0/nvc0_screen.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/gallium/drivers/nouveau/nvc0/nvc0_screen.c b/src/gallium/drivers/nouveau/nvc0/nvc0_screen.c index 9

[Mesa-dev] [PATCH 10/17] mesa/st: update MSAA enable

From: Bas Nieuwenhuizen The rasterizer state used Multisample._Enable to enable msaa. However that gets updated in core mesa before any st validation happens. Setting it depends on _NumSamples which happens during st validation. To break this cyclic dependency I

[Mesa-dev] [PATCH 15/17] nvc0: handle the case where there are no framebuffer attachments

From: Ilia Mirkin <imir...@alum.mit.edu> Signed-off-by: Ilia Mirkin <imir...@alum.mit.edu> Reviewed-by: Edward O'Callaghan <eocallag...@alterapraxis.com> --- src/gallium/drivers/nouveau/nvc0/nvc0_program.c| 7 +++ src/gallium/drivers/nouveau/nvc0/nvc0_sta

[Mesa-dev] [PATCH 05/17] mesa/st: Use _mesa_geometric_ functions appropriately

of the gl_framebuffer. This patch paves the way to enable GL_ARB_framebuffer_no_attachements for all gallium drivers. Signed-off-by: Edward O'Callaghan <eocallag...@alterapraxis.com> Reviewed-by: Ilia Mirkin <imir...@alum.mit.edu> Reviewed-by: Brian Paul <bri...@vmware.com> --- src/

[Mesa-dev] [PATCH 11/17] gallium/aux: Fix u_blitter.c for layers/samples

Signed-off-by: Edward O'Callaghan <eocallag...@alterapraxis.com> --- src/gallium/auxiliary/util/u_blitter.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/gallium/auxiliary/util/u_blitter.c b/src/gallium/auxiliary/util/u_blitter.c index 43fbd8e..c4a32e8

[Mesa-dev] [PATCH 13/17] radeonsi: Enable ARB_framebuffer_no_attachments

Signed-off-by: Edward O'Callaghan <eocallag...@alterapraxis.com> --- src/gallium/drivers/radeonsi/si_pipe.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/gallium/drivers/radeonsi/si_pipe.c b/src/gallium/drivers/radeonsi/si_pipe.c index 46fa592..1472ccf

[Mesa-dev] [PATCH 04/17] mesa: Add comment to framebuffer_parameteri()

Signed-off-by: Edward O'Callaghan <eocallag...@alterapraxis.com> --- src/mesa/main/fbobject.c | 5 + 1 file changed, 5 insertions(+) diff --git a/src/mesa/main/fbobject.c b/src/mesa/main/fbobject.c index d490918..a480a04 100644 --- a/src/mesa/main/fbobject.c +++ b/src/mesa/main/fbob

[Mesa-dev] [PATCH 08/17] mesa/st: Update framebuffer state with no.of samples, layers

Handle the case of ARB_framebuffer_no_attachment. Also, kill off a dead debug printf() call while we are here. Signed-off-by: Edward O'Callaghan <eocallag...@alterapraxis.com> --- src/mesa/state_tracker/st_atom_framebuffer.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-)

[Mesa-dev] [PATCH 07/17] gallium/trace: Dump no.of samples and layers in fb state

Signed-off-by: Edward O'Callaghan <eocallag...@alterapraxis.com> --- src/gallium/drivers/trace/tr_dump_state.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/gallium/drivers/trace/tr_dump_state.c b/src/gallium/drivers/trace/tr_dump_state.c index 0627e5a..8f827db 100644 ---

[Mesa-dev] ARB_framebuffer_no_attachment for radeonsi,r600g,nvc0

Due to popular demand this _should_ implement this GL extension correctly now and include the various community feedback. Sorry for this taking so very long because of external real-life pressures.. In any case here it is. This passes piglit fully on nvc0 (checked awhile ago); on radeonsi today

[Mesa-dev] [PATCH 02/17] mesa/st: Set _NumSamples in update_framebuffer_state()

Signed-off-by: Edward O'Callaghan <eocallag...@alterapraxis.com> --- src/mesa/main/mtypes.h | 8 +++ src/mesa/state_tracker/st_atom_framebuffer.c | 35 src/mesa/state_tracker/st_extensions.c | 4 3 files changed, 47 inse

[Mesa-dev] [PATCH 12/17] gallium/util: Ensure util_framebuffer_get_num_samples() is valid

Upon context creation, internal driver structures are malloc()'ed and memset() to zero them. This results in a invalid number of samples 'by default'. Handle this in the simplest way to avoid elaborate and probably equally sub-optimial solutions. Signed-off-by: Edward O'Callaghan <eocal

[Mesa-dev] [PATCH 14/17] r600g: Enable ARB_framebuffer_no_attachments

Signed-off-by: Edward O'Callaghan <eocallag...@alterapraxis.com> --- src/gallium/drivers/r600/r600_pipe.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/gallium/drivers/r600/r600_pipe.c b/src/gallium/drivers/r600/r600_pipe.c index 0d22faa..96c0382 100644 ---

[Mesa-dev] [PATCH 03/17] gallium: Obtain ARB_framebuffer_no_attachment constants

Set default values for the constants required in ARB_framebuffer_no_attachments and obtained the number of layers from ``PIPE_CAP_MAX_TEXTURE_ARRAY_LAYERS``. Signed-off-by: Edward O'Callaghan <eocallag...@alterapraxis.com> --- src/mesa/state_tracker/st_extensions.c | 19

[Mesa-dev] [PATCH 01/17] gallium: Add PIPE_CAP_MSAA_MODES

. Signed-off-by: Edward O'Callaghan <eocallag...@alterapraxis.com> --- src/gallium/docs/source/screen.rst | 7 +++ src/gallium/drivers/freedreno/freedreno_screen.c | 1 + src/gallium/drivers/i915/i915_screen.c | 1 + src/gallium/drivers/ilo/ilo_screen.c

[Mesa-dev] [PATCH] mesa/dri/r200: Refrain from using symbol links in repo

Just use the relative path in the Makefile.source over symbol links that are not necessarily portable. Untested as I don't have this old hardware. Signed-off-by: Edward O'Callaghan <eocallag...@alterapraxis.com> --- src/mesa/drivers/dri/r200/Makefile.sources

[Mesa-dev] [PATCH] nv{c, 5}0: Remove duplicate logic from nvc0_set_framebuffer_state()

We already have this logic in the gallium/util functions so lets reduce some entropy while here. V.2: Apply change to nv50 also as suggested by Samuel Pitoiset. Signed-off-by: Edward O'Callaghan <eocallag...@alterapraxis.com> --- src/gallium/drivers/nouveau/nv50/nv50_state.

[Mesa-dev] V.2; nv{5,c}0: Remove duplicate logic from nvc0_set_framebuffer_state()

N.B., untested as I don't currently have access to this hw. V.2: Apply change also to nv50 as suggested by Samuel Pitoiset. ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [PATCH] nvc0: Remove duplicate logic from nvc0_set_framebuffer_state()

We already have this logic in the gallium/util functions so lets reduce some entropy while here. N.B., untested as I don't currently have access to this hw. Signed-off-by: Edward O'Callaghan <eocallag...@alterapraxis.com> --- src/gallium/drivers/nouveau/nvc0/nvc0_state.c | 13 +-

[Mesa-dev] [PATCH v2 2/9] mesa/st: Use _mesa_geometric_ functions appropriately

of the gl_framebuffer. This patch paves the way to enable GL_ARB_framebuffer_no_attachements for all gallium drivers. Signed-off-by: Edward O'Callaghan <eocallag...@alterapraxis.com> Reviewed-by: Ilia Mirkin <imir...@alum.mit.edu> Reviewed-by: Brian Paul <bri...@vmware.com> --- src/

[Mesa-dev] [PATCH v2 8/9] nvc0: handle the case where there are no framebuffer attachments

From: Ilia Mirkin <imir...@alum.mit.edu> Signed-off-by: Ilia Mirkin <imir...@alum.mit.edu> Reviewed-by: Edward O'Callaghan <eocallag...@alterapraxis.com> --- src/gallium/drivers/nouveau/nvc0/nvc0_program.c| 7 +++ src/gallium/drivers/nouveau/nvc0/nvc0_screen.c

[Mesa-dev] [PATCH v2 7/9] r600g: Enable ARB_framebuffer_no_attachments

Signed-off-by: Edward O'Callaghan <eocallag...@alterapraxis.com> --- src/gallium/drivers/r600/r600_pipe.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/gallium/drivers/r600/r600_pipe.c b/src/gallium/drivers/r600/r600_pipe.c index 36297f3..28b34de 100644 ---

[Mesa-dev] [PATCH v2 6/9] radeonsi: Enable ARB_framebuffer_no_attachments

Signed-off-by: Edward O'Callaghan <eocallag...@alterapraxis.com> --- src/gallium/drivers/radeonsi/si_pipe.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/gallium/drivers/radeonsi/si_pipe.c b/src/gallium/drivers/radeonsi/si_pipe.c index d3f3677..a58a9d5

[Mesa-dev] [PATCH v2 9/9] GL3.txt: Mark ARB_framebuffer_no_attachments as done

Signed-off-by: Edward O'Callaghan <eocallag...@alterapraxis.com> --- docs/GL3.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/GL3.txt b/docs/GL3.txt index 257fc73..350462f 100644 --- a/docs/GL3.txt +++ b/docs/GL3.txt @@ -157,7 +157,7 @@ GL 4.3, GLS

[Mesa-dev] [PATCH v2 5/9] mesa/st: Update framebuffer state with no.of samples, layers

Handle the case of ARB_framebuffer_no_attachment. Also, kill off a dead debug printf() call while we are here. Signed-off-by: Edward O'Callaghan <eocallag...@alterapraxis.com> Reviewed-by: Ilia Mirkin --- src/mesa/state_tracker/st_atom_framebuffer.c | 8 +--- 1 file changed, 5 inse

[Mesa-dev] [PATCH v2 1/9] gallium: Add PIPE_CAP_FRAMEBUFFER_LAYERS

Add PIPE_CAP to determine the number of layers for a framebuffer for GL_ARB_framebuffer_no_attachments. Signed-off-by: Edward O'Callaghan <eocallag...@alterapraxis.com> --- src/gallium/docs/source/screen.rst | 2 ++ src/gallium/drivers/freedreno/freedreno_screen.c | 1

[Mesa-dev] [PATCH v2 4/9] gallium/trace: Dump no.of samples and layers in fb state

Signed-off-by: Edward O'Callaghan <eocallag...@alterapraxis.com> Reviewed-by: Ilia Mirkin --- src/gallium/drivers/trace/tr_dump_state.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/gallium/drivers/trace/tr_dump_state.c b/src/gallium/drivers/trace/tr_dump_state.c index c

[Mesa-dev] [PATCH v2 3/9] gallium: Put no.of {samples, layers} into pipe_framebuffer_state

Here we store the number of samples and layers directly in the pipe_framebuffer_state so that in the case of ARB_framebuffer_no_attachment we may make use of them directly. Further, we adjust various gallium/auxiliary helper functions accordingly. Signed-off-by: Edward O'Callaghan <eocal

[Mesa-dev] [PATCH 3/7] mesa_st: Use _mesa_geometric_ functions appropriately

of the gl_framebuffer. This patch paves the way to enable GL_ARB_framebuffer_no_attachements for all gallium drivers. Signed-off-by: Edward O'Callaghan <eocallag...@alterapraxis.com> --- src/mesa/state_tracker/st_atom_rasterizer.c | 3 ++- src/mesa/state_tracker/st_atom_scissor.c| 8 ++-- sr

[Mesa-dev] [PATCH 2/7] mesa: the _mesa_geometric_* functions require full types from mtypes.h

From: Ilia Mirkin Signed-off-by: Ilia Mirkin --- src/mesa/main/framebuffer.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mesa/main/framebuffer.h b/src/mesa/main/framebuffer.h index bfc8a08..ab077ed 100644 ---

[Mesa-dev] [PATCH 1/7] gallium: Add PIPE_CAP_FRAMEBUFFER_LAYERS

Add PIPE_CAP to determine the number of layers for a framebuffer for GL_ARB_framebuffer_no_attachments. Signed-off-by: Edward O'Callaghan <eocallag...@alterapraxis.com> --- src/gallium/docs/source/screen.rst | 2 ++ src/gallium/drivers/freedreno/freedreno_screen.c | 1

[Mesa-dev] [PATCH 7/7] radeonsi: Enable ARB_framebuffer_no_attachments

Signed-off-by: Edward O'Callaghan <eocallag...@alterapraxis.com> --- src/gallium/drivers/radeonsi/si_pipe.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/gallium/drivers/radeonsi/si_pipe.c b/src/gallium/drivers/radeonsi/si_pipe.c index f219bc4..ffc25fb

[Mesa-dev] [PATCH 4/7] gallium: Put no.of {samples, layers} into pipe_framebuffer_state

Here we store the number of samples and layers directly in the pipe_framebuffer_state so that in the case of ARB_framebuffer_no_attachment we may make use of them directly. Further, we adjust various gallium/auxiliary helper functions accordingly. Signed-off-by: Edward O'Callaghan <eocal

[Mesa-dev] [PATCH 5/7] mesa_st: Update framebuffer state with no.of samples, layers

Handle the case of ARB_framebuffer_no_attachment. Also, kill off a dead debug printf() call while we are here. --- src/mesa/state_tracker/st_atom_framebuffer.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/src/mesa/state_tracker/st_atom_framebuffer.c

[Mesa-dev] [PATCH 6/7] mesa: invalidate framebuffer when changing parameters

: Ilia Mirkin <imir...@alum.mit.edu> Signed-off-by: Edward O'Callaghan <eocallag...@alterapraxis.com> --- src/mesa/main/fbobject.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/mesa/main/fbobject.c b/src/mesa/main/fbobject.c index 3be216d..2d4acb3 100644 --- a/src/mesa/main/fb

[Mesa-dev] [PATCH] gallium/aux: Turn TGSI_CHAN_* into enum

Signed-off-by: Edward O'Callaghan <eocallag...@alterapraxis.com> --- src/gallium/auxiliary/tgsi/tgsi_exec.h | 10 ++ src/gallium/auxiliary/tgsi/tgsi_util.c | 16 2 files changed, 14 insertions(+), 12 deletions(-) diff --git a/src/gallium/auxiliary/tgsi/tgsi_exec.h

[Mesa-dev] [PATCH 1/2] gallium/aux: Use TGSI chan name defines inplace of literals

Signed-off-by: Edward O'Callaghan <eocallag...@alterapraxis.com> --- src/gallium/auxiliary/tgsi/tgsi_util.c | 13 +++-- 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/src/gallium/auxiliary/tgsi/tgsi_util.c b/src/gallium/auxiliary/tgsi/tgsi_util.c index 653e650..5

[Mesa-dev] [PATCH 4/6] gallium/drivers/ilo: Use unsigned for loop index

Found-by: Coccinelle Signed-off-by: Edward O'Callaghan <eocallag...@alterapraxis.com> Reviewed-by: Brian Paul <bri...@vmware.com> --- src/gallium/drivers/ilo/core/ilo_builder.c | 8 src/gallium/drivers/ilo/shader/ilo_shader_fs.c | 16 src/gallium

<    1   2   3   4   5   6   >