[Mesa-dev] [PATCH 3/6] gallium: Use unsigned for loop index

2016-01-05 Thread Edward O'Callaghan
Found-by: Coccinelle Signed-off-by: Edward O'Callaghan <eocallag...@alterapraxis.com> Reviewed-by: Brian Paul <bri...@vmware.com> --- src/gallium/auxiliary/gallivm/lp_bld_tgsi_soa.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/gallium/auxil

[Mesa-dev] [PATCH 6/6] gallium/drivers/svga: Use unsigned for loop index

2016-01-05 Thread Edward O'Callaghan
Fix a 's/unsigned int/unsigned/' consistency case while here. Found-by: Coccinelle Signed-off-by: Edward O'Callaghan <eocallag...@alterapraxis.com> Reviewed-by: Brian Paul <bri...@vmware.com> --- src/gallium/drivers/svga/svga_resource_buffer_upload.c | 2 +- src/gallium/

[Mesa-dev] [PATCH 2/6] gallium/drivers: Remove unnecessary semicolons

2016-01-05 Thread Edward O'Callaghan
Found-by: Coccinelle Signed-off-by: Edward O'Callaghan <eocallag...@alterapraxis.com> Reviewed-by: Brian Paul <bri...@vmware.com> --- src/gallium/drivers/i915/i915_state.c | 2 +- src/gallium/drivers/ilo/shader/ilo_shader_vs.c| 2 +- src/gallium/drivers/llvmpipe/lp_

[Mesa-dev] [PATCH 5/6] gallium/drivers/r600: Use unsigned for loop index

2016-01-05 Thread Edward O'Callaghan
Found-by: Coccinelle Signed-off-by: Edward O'Callaghan <eocallag...@alterapraxis.com> Reviewed-by: Brian Paul <bri...@vmware.com> --- src/gallium/drivers/r600/r600_shader.c | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/src/gallium/

[Mesa-dev] [PATCH 1/6] gallium: Remove unnecessary semicolons

2016-01-05 Thread Edward O'Callaghan
Fix silly issue with MSVC case fall-though support to need a extra 'break;' Found-by: Coccinelle Signed-off-by: Edward O'Callaghan <eocallag...@alterapraxis.com> Reviewed-by: Brian Paul <bri...@vmware.com> --- src/gallium/auxiliary/draw/draw_pipe_aaline.c | 2 +- src/gallium/auxil

[Mesa-dev] [PATCH 3/6] gallium: Use unsigned for loop index

2015-12-16 Thread Edward O'Callaghan
Found-by: Coccinelle Signed-off-by: Edward O'Callaghan <eocallag...@alterapraxis.com> Reviewed-by: Brian Paul <bri...@vmware.com> --- src/gallium/auxiliary/gallivm/lp_bld_tgsi_soa.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/gallium/auxil

[Mesa-dev] [PATCH 2/6] gallium/drivers: Remove unnecessary semicolons

2015-12-16 Thread Edward O'Callaghan
Found-by: Coccinelle Signed-off-by: Edward O'Callaghan <eocallag...@alterapraxis.com> Reviewed-by: Brian Paul <bri...@vmware.com> --- src/gallium/drivers/i915/i915_state.c | 2 +- src/gallium/drivers/ilo/shader/ilo_shader_vs.c| 2 +- src/gallium/drivers/llvmpipe/lp_

[Mesa-dev] [PATCH 4/6] gallium/drivers/ilo: Use unsigned for loop index

2015-12-16 Thread Edward O'Callaghan
Found-by: Coccinelle Signed-off-by: Edward O'Callaghan <eocallag...@alterapraxis.com> Reviewed-by: Brian Paul <bri...@vmware.com> --- src/gallium/drivers/ilo/core/ilo_builder.c | 8 src/gallium/drivers/ilo/shader/ilo_shader_fs.c | 16 src/gallium

[Mesa-dev] [PATCH 1/6] gallium: Remove unnecessary semicolons

2015-12-16 Thread Edward O'Callaghan
Fix silly issue with MSVC case fall-though support to need a extra 'break;' Found-by: Coccinelle Signed-off-by: Edward O'Callaghan <eocallag...@alterapraxis.com> Reviewed-by: Brian Paul <bri...@vmware.com> --- src/gallium/auxiliary/draw/draw_pipe_aaline.c | 2 +- src/gallium/auxil

[Mesa-dev] [PATCH 5/6] gallium/drivers/r600: Use unsigned for loop index

2015-12-16 Thread Edward O'Callaghan
Found-by: Coccinelle Signed-off-by: Edward O'Callaghan <eocallag...@alterapraxis.com> Reviewed-by: Brian Paul <bri...@vmware.com> --- src/gallium/drivers/r600/r600_shader.c | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/src/gallium/

[Mesa-dev] [PATCH 6/6] gallium/drivers/svga: Use unsigned for loop index

2015-12-16 Thread Edward O'Callaghan
Found-by: Coccinelle Signed-off-by: Edward O'Callaghan <eocallag...@alterapraxis.com> Reviewed-by: Brian Paul <bri...@vmware.com> --- src/gallium/drivers/svga/svga_tgsi_insn.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/src/gallium/

[Mesa-dev] [PATCH V.2] Further Coccinelle inspired cleanups

2015-12-16 Thread Edward O'Callaghan
V.2 * Fixup issue with MSVC needing a 'break;' on fall-though. - The following patch series continues on what can be done with Coccinelle to clean up Mesa3D house keeping duties. On a good note we have a pretty clean tree for the fairly trivial runs so far. [PATCH 1/6] gallium: Remove

[Mesa-dev] Further Coccinelle inspired cleanups

2015-12-14 Thread Edward O'Callaghan
The following patch series continues on what can be done with Coccinelle to clean up Mesa3D house keeping duties. On a good note we have a pretty clean tree for the fairly trivial runs so far. [PATCH 1/6] gallium: Remove unnecessary semicolons [PATCH 2/6] gallium/drivers: Remove unnecessary

[Mesa-dev] [PATCH 1/6] gallium: Remove unnecessary semicolons

2015-12-14 Thread Edward O'Callaghan
Found-by: Coccinelle Signed-off-by: Edward O'Callaghan <eocallag...@alterapraxis.com> --- src/gallium/auxiliary/draw/draw_pipe_aaline.c | 2 +- src/gallium/auxiliary/gallivm/lp_bld_swizzle.c | 2 +- src/gallium/auxiliary/nir/tgsi_to_nir.c| 2 +- src/gallium/auxiliary/util/u_sur

[Mesa-dev] [PATCH 6/6] gallium/drivers/svga: Use unsigned for loop index

2015-12-14 Thread Edward O'Callaghan
Found-by: Coccinelle Signed-off-by: Edward O'Callaghan <eocallag...@alterapraxis.com> --- src/gallium/drivers/svga/svga_tgsi_insn.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/src/gallium/drivers/svga/svga_tgsi_insn.c b/src/gallium/driver

[Mesa-dev] [PATCH 2/6] gallium/drivers: Remove unnecessary semicolons

2015-12-14 Thread Edward O'Callaghan
Found-by: Coccinelle Signed-off-by: Edward O'Callaghan <eocallag...@alterapraxis.com> --- src/gallium/drivers/i915/i915_state.c | 2 +- src/gallium/drivers/ilo/shader/ilo_shader_vs.c| 2 +- src/gallium/drivers/llvmpipe/lp_test_blend.c | 2 +- src/gallium/drivers/ll

[Mesa-dev] [PATCH 3/6] gallium: Use unsigned for loop index

2015-12-14 Thread Edward O'Callaghan
Found-by: Coccinelle Signed-off-by: Edward O'Callaghan <eocallag...@alterapraxis.com> --- src/gallium/auxiliary/gallivm/lp_bld_tgsi_soa.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/gallium/auxiliary/gallivm/lp_bld_tgsi_soa.c b/src/gallium/auxiliary/g

[Mesa-dev] [PATCH 4/6] gallium/drivers/ilo: Use unsigned for loop index

2015-12-14 Thread Edward O'Callaghan
Found-by: Coccinelle Signed-off-by: Edward O'Callaghan <eocallag...@alterapraxis.com> --- src/gallium/drivers/ilo/core/ilo_builder.c | 8 src/gallium/drivers/ilo/shader/ilo_shader_fs.c | 16 src/gallium/drivers/ilo/shader/ilo_shader_vs.c | 4 ++-- src/g

[Mesa-dev] [PATCH 5/6] gallium/drivers/r600: Use unsigned for loop index

2015-12-14 Thread Edward O'Callaghan
Found-by: Coccinelle Signed-off-by: Edward O'Callaghan <eocallag...@alterapraxis.com> --- src/gallium/drivers/r600/r600_shader.c | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/src/gallium/drivers/r600/r600_shader.c b/src/gallium/drivers/r600/r600_sh

[Mesa-dev] [PATCH 1/2] softpipe: implement some support for multiple viewports

2015-12-11 Thread Edward O'Callaghan
Mostly related to making sure the rasterizer can correctly pick out the correct scissor box for the current viewport. Signed-off-by: Edward O'Callaghan <eocallag...@alterapraxis.com> --- src/gallium/drivers/softpipe/sp_context.h | 9 ++- src/gallium/drivers/softpipe/sp_

[Mesa-dev] [PATCH 2/2] softpipe: Update GL3.txt doc with GL_ARB_viewport_array support

2015-12-11 Thread Edward O'Callaghan
Signed-off-by: Edward O'Callaghan <eocallag...@alterapraxis.com> --- docs/GL3.txt | 2 +- src/gallium/drivers/softpipe/sp_screen.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/docs/GL3.txt b/docs/GL3.txt index 7eda002..84b5a17

[Mesa-dev] [PATCH] gallium/aux../util: Make u_prims_for_vertices() safe

2015-12-09 Thread Edward O'Callaghan
dereference from ' info ' being NULL from a u_prim_vertex_count() call. Signed-off-by: Edward O'Callaghan <eocallag...@alterapraxis.com> --- src/gallium/auxiliary/util/u_prim.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/gallium/auxiliary/util/u_prim.h b/src/gallium/auxiliar

[Mesa-dev] softpipe: V.2 implement some support for multiple viewports

2015-12-08 Thread Edward O'Callaghan
This fixes my initial attempt so that piglit now passes 14/14. Thanks to a couple of tips from Roland in the previous patch I was able to fix the remaining issue. This should be golden now. ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org

[Mesa-dev] [RFC] softpipe: initial attempt at ARB_viewport_array

2015-12-07 Thread Edward O'Callaghan
The follow patch passes all but two tests on softpipe for ARB_viewport_array. Although, admittedly the tests it does fail are basically the most imported :p. There are a couple of things needed to polish this off but this gets most of the fluff out the way I guess. I was unsure how to handle the

[Mesa-dev] [PATCH] softpipe: implement some support for multiple viewports

2015-12-07 Thread Edward O'Callaghan
Mostly related to making sure the rasterizer can correctly pick out the correct scissor box for the current viewport. Signed-off-by: Edward O'Callaghan <eocallag...@alterapraxis.com> --- src/gallium/drivers/softpipe/sp_context.h | 7 +++- src/gallium/drivers/so

[Mesa-dev] [PATCH 2/2] r600: Add ARB_copy_image support

2015-12-07 Thread Edward O'Callaghan
Signed-off-by: Edward O'Callaghan <eocallag...@alterapraxis.com> --- docs/GL3.txt | 2 +- src/gallium/drivers/r600/r600_pipe.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/docs/GL3.txt b/docs/GL3.txt index 50b429c..f564263 100644 --- a/do

[Mesa-dev] r600g: ARB_copy_image support

2015-12-07 Thread Edward O'Callaghan
The follow passes piglit with 1358/1358 on AURBA. ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [PATCH 1/2] r600g: allow copying between compatible un/compressed formats

2015-12-07 Thread Edward O'Callaghan
See: `commit e82c527f1fc2f8ddc64954ecd06b0de3cea92e93` which is where a block in src maps to a pixel in dst and vice versa. e.g. DXT1 <-> R32G32_UINT DXT5 <-> R32G32B32A32_UINT Signed-off-by: Edward O'Callaghan <eocallag...@alterapraxis.com> --- src/gallium/driver

[Mesa-dev] [PATCH] gallium/radeon*: Remove useless casts

2015-12-05 Thread Edward O'Callaghan
These are unnecessary and are likely just left overs from prior work. Signed-off-by: Edward O'Callaghan <eocallag...@alterapraxis.com> --- src/gallium/drivers/r600/compute_memory_pool.c | 13 + src/gallium/drivers/r600/evergreen_compute.c | 4 ++-- src/gallium/driver

[Mesa-dev] [PATCH] gallium: Remove redundant NULL ptr checks

2015-12-05 Thread Edward O'Callaghan
Signed-off-by: Edward O'Callaghan <eocallag...@alterapraxis.com> --- src/gallium/auxiliary/draw/draw_pipe_aaline.c | 3 +-- src/gallium/auxiliary/pipebuffer/pb_bufmgr_debug.c | 10 -- 2 files changed, 5 insertions(+), 8 deletions(-) diff --git a/src/gallium/auxiliar

[Mesa-dev] [PATCH] gallium/drivers/nouveau: Clean up clear_texture()

2015-12-04 Thread Edward O'Callaghan
We should translate and set the format before dispatching the call to pipe->create_surface(), instead of creating a surface with the given format and changing it after. Signed-off-by: Edward O'Callaghan <eocallag...@alterapraxis.com> --- src/gallium/drivers/nouveau/nv50/nv50_surfa

[Mesa-dev] gallium/drivers/nouveau: Clean up clear_texture()

2015-12-04 Thread Edward O'Callaghan
I don't actually have access to Nvid ASIC's at the moment so this is untested for regressions in ARB_clear_texture piglits. ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [PATCH 3/7] gallium/drivers/svga: Make use of ARRAY_SIZE macro

2015-12-03 Thread Edward O'Callaghan
Signed-off-by: Edward O'Callaghan <eocallag...@alterapraxis.com> --- src/gallium/drivers/svga/svga_state_tss.c | 2 +- src/gallium/drivers/svga/svgadump/svga_shader_op.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/gallium/drivers/svga/svga_state_ts

[Mesa-dev] [PATCH 5/7] gallium/aux../u_mm.c: Fix zero integer literal to pointer comparison

2015-12-03 Thread Edward O'Callaghan
Signed-off-by: Edward O'Callaghan <eocallag...@alterapraxis.com> --- src/gallium/auxiliary/util/u_mm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/auxiliary/util/u_mm.c b/src/gallium/auxiliary/util/u_mm.c index 2069b56..bd4c4e1 100644 --- a/src/g

[Mesa-dev] [PATCH 2/7] gallium/drivers/llvmpipe: Make use of ARRAY_SIZE macro

2015-12-03 Thread Edward O'Callaghan
Signed-off-by: Edward O'Callaghan <eocallag...@alterapraxis.com> --- src/gallium/drivers/llvmpipe/lp_test_blend.c | 6 +++--- src/gallium/drivers/llvmpipe/lp_test_conv.c | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/gallium/drivers/llvmpipe/lp_test_blend.c

[Mesa-dev] [PATCH 1/7] gallium/drivers/nouveau: Make use of ARRAY_SIZE macro

2015-12-03 Thread Edward O'Callaghan
Signed-off-by: Edward O'Callaghan <eocallag...@alterapraxis.com> --- src/gallium/drivers/nouveau/nv30/nv30_transfer.c | 2 +- src/gallium/drivers/nouveau/nv50/nv50_state.c | 6 +++--- src/gallium/drivers/nouveau/nv50/nv50_state_validate.c | 3 +-- src/gallium/drivers/nouvea

[Mesa-dev] A few misc cleanups using Coccinelle semantic scripts

2015-12-03 Thread Edward O'Callaghan
`Write one patch run everywhere.' These hopefully get a chunk of the churn (sorry about that) out the way for more interesting Coccinelle semantic patching of mesa. ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org

[Mesa-dev] [PATCH 4/7] gallium/winsys: Make use of ARRAY_SIZE macro

2015-12-03 Thread Edward O'Callaghan
Signed-off-by: Edward O'Callaghan <eocallag...@alterapraxis.com> --- src/gallium/winsys/amdgpu/drm/amdgpu_surface.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/src/gallium/winsys/amdgpu/drm/amdgpu_surface.c b/src/gallium/winsys/amdgpu/drm/amdgpu_surface.c

[Mesa-dev] radeonsi ARB_clear_texture support

2015-12-03 Thread Edward O'Callaghan
The following patches make steps towards getting ARB_clear_texture support working on radeonsi. There is still some outstanding work to be done before we may toggle on the PIPE and check it off as done. The following is thus preliminary refactoring to set the stage for further work without the

[Mesa-dev] [RFC 3/3] radeonsi: Add ARB_clear_texture support

2015-12-03 Thread Edward O'Callaghan
this. Signed-off-by: Edward O'Callaghan <eocallag...@alterapraxis.com> --- src/gallium/drivers/radeonsi/si_blit.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/src/gallium/drivers/radeonsi/si_blit.c b/src/gallium/drivers/radeonsi/si_blit.c index 13d8e6f..e1185c9 100644 ---

[Mesa-dev] [RFC 2/3] gallium: Move nv50 clear_texture impl down to util_surface

2015-12-03 Thread Edward O'Callaghan
ARB_clear_texture is reasonably generic enough that it should be moved down to become part of the fallback mechanism of pipe->clear_texture. Signed-off-by: Edward O'Callaghan <eocallag...@alterapraxis.com> --- src/gallium/auxiliary/util/u_surface.c | 83 +

[Mesa-dev] [RFC 1/3] gallium/aux/util: Trivial, we already have format use it

2015-12-03 Thread Edward O'Callaghan
No need to dereference again, fixup for clarity. Signed-off-by: Edward O'Callaghan <eocallag...@alterapraxis.com> --- src/gallium/auxiliary/util/u_surface.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/auxiliary/util/u_surface.c b/src/gallium/auxiliar

[Mesa-dev] [PATCH 2/2] gallium/util: Fix util_blitter_clear_depth_stencil() for num_layers>1

2015-11-25 Thread Edward O'Callaghan
Previously util_blitter_clear_depth_stencil() could not clear more than the first layer. We need to generalise this as we did for util_blitter_clear_render_target(). Signed-off-by: Edward O'Callaghan <eocallag...@alterapraxis.com> --- src/gallium/auxiliary/util/u_blitter.

[Mesa-dev] [PATCH 1/2] gallium/util: Fix util_blitter_clear_render_target() for num_layers>1

2015-11-25 Thread Edward O'Callaghan
Previously util_blitter_clear_render_target() could not clear more than the first layer. We need to generalise this so that ARB_clear_texture can pass the 3d piglit test. Signed-off-by: Edward O'Callaghan <eocallag...@alterapraxis.com> --- src/gallium/auxiliary/util/u_blitter.

[Mesa-dev] Generalise util_blitter_clear_{render_target, depth_stencil}()

2015-11-25 Thread Edward O'Callaghan
The following patches generalise the blitter_clear functions such that they may work with multiple layers: Changes since v1: - Directly calc num_layers over using util_framebuffer_get_num_layers() on the framebuffer state. ___ mesa-dev mailing list

[Mesa-dev] [PATCH] gallium/util: Fix util_blitter_clear_render_target() for num_layers>1

2015-11-24 Thread Edward O'Callaghan
Previously util_blitter_clear_render_target() could not clear more than the first layer. We need to generalise this so that ARB_clear_texture can pass the 3d piglit test. Signed-off-by: Edward O'Callaghan <eocallag...@alterapraxis.com> --- src/gallium/auxiliary/util/u_blitter.

Re: [Mesa-dev] [PATCH] r600g/sb: Support gs5 sampler indexing

2015-09-21 Thread Edward O'Callaghan
Reviewed-by: Edward O'Callaghan <eocallag...@alterapraxis.com> -- Edward O'Callaghan edward.ocallag...@koparo.com On Tue, Sep 22, 2015, at 12:21 AM, Glenn Kennard wrote: > Signed-off-by: Glenn Kennard <glenn.kenn...@gmail.com> > --- > Just UBO support left before gs5 ca

Re: [Mesa-dev] [PATCH 2/2] radeonsi: implement TXQS support

2015-09-19 Thread Edward O'Callaghan
This series is, Reviewed-by: Edward O'Callaghan <eocallag...@alterapraxis.com> -- Edward O'Callaghan edward.ocallag...@koparo.com On Sun, Sep 20, 2015, at 06:26 AM, Ilia Mirkin wrote: > Signed-off-by: Ilia Mirkin <imir...@alum.mit.edu> > Tested-by: Fredrik Bruh

Re: [Mesa-dev] [PATCH 0/4] gallium: add support for retrieving number of texture samples

2015-09-11 Thread Edward O'Callaghan
This series is, Reviewed-by: Edward O'Callaghan <eocallag...@alterapraxis.com> -- Edward O'Callaghan edward.ocallag...@koparo.com On Fri, Sep 11, 2015, at 01:15 PM, Ilia Mirkin wrote: > My hope was (as you can see in the last patch) to enable this for all > drivers that support

Re: [Mesa-dev] [PATCH 2/2] r600g: lower number of driver const buffers

2015-09-11 Thread Edward O'Callaghan
This series is, Reviewed-by: Edward O'Callaghan <eocallag...@alterapraxis.com> -- Edward O'Callaghan edward.ocallag...@koparo.com On Fri, Sep 11, 2015, at 08:09 PM, Glenn Kennard wrote: > Series is: > > Reviewed-by: Glenn Kennard <glenn

Re: [Mesa-dev] [PATCH 1/2] r600: define some values for the fetch constant offsets.

2015-09-11 Thread Edward O'Callaghan
Reviewed-by: Edward O'Callaghan <eocallag...@alterapraxis.com> -- Edward O'Callaghan edward.ocallag...@koparo.com On Fri, Sep 11, 2015, at 02:43 PM, Dave Airlie wrote: > From: Dave Airlie <airl...@redhat.com> > > This just puts these in one place and #defines them. >

Re: [Mesa-dev] [PATCH 1/2] r600/llvm: remove dead code for LLVM 3.3

2015-09-07 Thread Edward O'Callaghan
Kill it ! -- Edward O'Callaghan edward.ocallag...@koparo.com On Mon, Sep 7, 2015, at 08:14 AM, Marek Olšák wrote: > From: Marek Olšák <marek.ol...@amd.com> > > LLVM 3.3 has been unsupported for quite a while. > --- > src/gallium/drivers/r

Re: [Mesa-dev] [PATCH] r600: don't use shader key without verifying shader type (v2)

2015-09-07 Thread Edward O'Callaghan
LGTM, thanks for catching this! -- Edward O'Callaghan edward.ocallag...@koparo.com On Tue, Sep 8, 2015, at 09:32 AM, Dave Airlie wrote: > From: Dave Airlie <airl...@redhat.com> > > Since 7a32652231f96eac14c4bfce02afe77b4132fb77 > r600: Turn 'r600_shader_key' struct into

Re: [Mesa-dev] [PATCH 2/2] gallium/radeon: drop support for LLVM 3.4

2015-09-07 Thread Edward O'Callaghan
Kill it! -- Edward O'Callaghan edward.ocallag...@koparo.com On Mon, Sep 7, 2015, at 08:14 AM, Marek Olšák wrote: > From: Marek Olšák <marek.ol...@amd.com> > > This allows using the new tex instrinsics unconditionally. > --- > configure.ac

[Mesa-dev] [PATCH] r600g: Simplify out a couple of unnecessary branches

2015-09-01 Thread Edward O'Callaghan
From: Edward O'Callaghan <eocallag...@alterapraxis.com> Signed-off-by: Edward O'Callaghan <eocallag...@alterapraxis.com> --- src/gallium/drivers/r600/r600_shader.c | 8 ++-- 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/src/gallium/drivers/r600/r600_shader.c b

Re: [Mesa-dev] [PATCH] r600g: fix calculation for gpr allocation

2015-08-31 Thread Edward O'Callaghan
Reviewed-by: Edward O'Callaghan <eocallag...@alterapraxis.com> -- Edward O'Callaghan edward.ocallag...@koparo.com On Tue, Sep 1, 2015, at 12:34 PM, Dave Airlie wrote: > From: Dave Airlie <airl...@redhat.com> > > I've been chasing a geom shader hang on rv635 since I w

[Mesa-dev] [PATCH 4/4] r600g: Use TGSI parse results instead of manually exfiltrating

2015-08-29 Thread Edward O'Callaghan
From: Edward O'Callaghan eocallag...@alterapraxis.com This makes better use of the work that the TGSI API has done for us. Signed-off-by: Edward O'Callaghan eocallag...@alterapraxis.com --- src/gallium/drivers/r600/r600_shader.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[Mesa-dev] [PATCH 2/4] r600g: Move geometry properties state from shader to selector

2015-08-29 Thread Edward O'Callaghan
From: Edward O'Callaghan eocallag...@alterapraxis.com Signed-off-by: Edward O'Callaghan eocallag...@alterapraxis.com --- src/gallium/drivers/r600/evergreen_state.c | 16 src/gallium/drivers/r600/r600_pipe.h | 5 + src/gallium/drivers/r600/r600_shader.c | 6

[Mesa-dev] [PATCH 3/4] r600g: Set geometry properties in r600_create_shader_state()

2015-08-29 Thread Edward O'Callaghan
From: Edward O'Callaghan eocallag...@alterapraxis.com The selector is shared by all shader variants, so the individual shaders shouldn't change it. Use tgsi_shader_scan() results to set geometry properties within a r600_create_shader_state() call and treat said propertices in the selector as read

[Mesa-dev] [PATCH 0/4] r600g: Make better use of the TGSI API (V.2)

2015-08-29 Thread Edward O'Callaghan
From: Edward O'Callaghan eocallag...@alterapraxis.com Minor cleanups that intend to make better use of the TGSI parser API tgsi_scan_shader(). V.2 adjustment; Set geometery property state within r600_create_shader_state(). Edward O'Callaghan (4): r600g: Remove dead assigment to 'gs_input_prim

[Mesa-dev] [PATCH 1/4] r600g: Remove dead assigment to 'gs_input_prim' in shader state

2015-08-29 Thread Edward O'Callaghan
From: Edward O'Callaghan eocallag...@alterapraxis.com Note that 'geometry shader properties' should be carried in the selector state over the shader state in any case. Signed-off-by: Edward O'Callaghan eocallag...@alterapraxis.com --- src/gallium/drivers/r600/r600_shader.c | 3 --- src/gallium

[Mesa-dev] [PATCH 0/4] r600g: Make better use of the TGSI API

2015-08-25 Thread Edward O'Callaghan
From: Edward O'Callaghan eocallag...@alterapraxis.com Minor cleanups that intend to make better use of the TGSI parser API tgsi_scan_shader(). Edward O'Callaghan (4): r600g: Remove dead assigment to 'gs_input_prim' in shader state r600g: Move geometry properties state from shader to selector

[Mesa-dev] [PATCH 1/4] r600g: Remove dead assigment to 'gs_input_prim' in shader state

2015-08-25 Thread Edward O'Callaghan
From: Edward O'Callaghan eocallag...@alterapraxis.com Note that 'geometry shader properties' should be carried in the selector state over the shader state in any case. Signed-off-by: Edward O'Callaghan eocallag...@alterapraxis.com --- src/gallium/drivers/r600/r600_shader.c | 3 --- src/gallium

[Mesa-dev] [PATCH 2/4] r600g: Move geometry properties state from shader to selector

2015-08-25 Thread Edward O'Callaghan
From: Edward O'Callaghan eocallag...@alterapraxis.com Signed-off-by: Edward O'Callaghan eocallag...@alterapraxis.com --- src/gallium/drivers/r600/evergreen_state.c | 16 src/gallium/drivers/r600/r600_pipe.h | 5 + src/gallium/drivers/r600/r600_shader.c | 6

[Mesa-dev] [PATCH 3/4] r600g: Don't repeat tgsi_scan_shader(), just use result

2015-08-25 Thread Edward O'Callaghan
From: Edward O'Callaghan eocallag...@alterapraxis.com tgsi_shader_scan() has already happened so just use the results. Signed-off-by: Edward O'Callaghan eocallag...@alterapraxis.com Signed-off-by: Dave Airlie airlied at redhat.com --- src/gallium/drivers/r600/r600_shader.c | 35

[Mesa-dev] [PATCH 4/4] r600g: Use TGSI parse results instead of manually exfiltrating

2015-08-25 Thread Edward O'Callaghan
From: Edward O'Callaghan eocallag...@alterapraxis.com This makes better use of the work that the TGSI API has done for us. Signed-off-by: Edward O'Callaghan eocallag...@alterapraxis.com --- src/gallium/drivers/r600/r600_shader.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [Mesa-dev] r600 multiple stream support + one misc debug patch

2015-08-25 Thread Edward O'Callaghan
This patch series is: Reviewed-by: Edward O'Callaghan eocallag...@alterapraxis.com P.S. thanks for polishing it Dave! -- Edward O'Callaghan edward.ocallag...@koparo.com On Tue, Aug 25, 2015, at 11:18 AM, Dave Airlie wrote: This adds multiple stream support for ARB_gpu_shader5, and one

[Mesa-dev] [PATCH] r600g: minor refactor for tessellation support

2015-08-19 Thread Edward O'Callaghan
From: Edward O'Callaghan eocallag...@alterapraxis.com This gets some churn out the way while prepping for r600g tessellation support that I am trying to work on. Since that will take me some time this also avoids rebases and the such like while keeping seperate indirectly related patches

[Mesa-dev] [PATCH] r600: Rewrite r600_shader_selector_key() to use a switch stmt

2015-08-19 Thread Edward O'Callaghan
From: Edward O'Callaghan eocallag...@alterapraxis.com Signed-off-by: Edward O'Callaghan eocallag...@alterapraxis.com --- src/gallium/drivers/r600/r600_state_common.c | 24 +--- 1 file changed, 17 insertions(+), 7 deletions(-) diff --git a/src/gallium/drivers/r600

[Mesa-dev] [PATCH 1/2] r600: Rewrite r600_shader_selector_key() to use a switch stmt

2015-08-19 Thread Edward O'Callaghan
From: Edward O'Callaghan eocallag...@alterapraxis.com Signed-off-by: Edward O'Callaghan eocallag...@alterapraxis.com --- src/gallium/drivers/r600/r600_state_common.c | 24 +--- 1 file changed, 17 insertions(+), 7 deletions(-) diff --git a/src/gallium/drivers/r600

[Mesa-dev] [PATCH 2/2] r600: Turn 'r600_shader_key' struct into union

2015-08-19 Thread Edward O'Callaghan
From: Edward O'Callaghan eocallag...@alterapraxis.com This struct was getting a bit crowded, following the lead of radeonsi, mirror the idea of having sub-structures for each shader type. Turning 'r600_shader_key' into an union saves some trivial memory and CPU cycles for the shader keys. Signed

[Mesa-dev] [PATCH 0/2] r600g: minor refactor for tessellation support [V.2]

2015-08-19 Thread Edward O'Callaghan
From: Edward O'Callaghan eocallag...@alterapraxis.com This gets some churn out the way while prepping for r600g tessellation support that I am trying to work on. Since that will take me some time this also avoids rebases and the such like while keeping seperate indirectly related patches

Re: [Mesa-dev] [PATCH] winsys/amdgpu: fix the type of memory usage counters

2015-08-18 Thread Edward O'Callaghan
Reviewed-by: Edward O'Callaghan eocallag...@alterapraxis.com -- Edward O'Callaghan edward.ocallag...@koparo.com On Wed, Aug 19, 2015, at 02:48 AM, Alex Deucher wrote: On Tue, Aug 18, 2015 at 12:43 PM, Marek Olšák mar...@gmail.com wrote: From: Marek Olšák marek.ol...@amd.com Reviewed

Re: [Mesa-dev] [PATCH 2/2] android: enable amdgpu winsys in radeonsi driver

2015-08-18 Thread Edward O'Callaghan
Reviewed-by: Edward O'Callaghan eocallag...@alterapraxis.com -- Edward O'Callaghan edward.ocallag...@koparo.com On Tue, Aug 18, 2015, at 07:53 PM, Mauro Rossi wrote: --- src/gallium/targets/dri/Android.mk | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src

Re: [Mesa-dev] [PATCH 1/2] android: fix cflags and includes for amdgpu winsys

2015-08-18 Thread Edward O'Callaghan
Reviewed-by: Edward O'Callaghan eocallag...@alterapraxis.com -- Edward O'Callaghan edward.ocallag...@koparo.com On Tue, Aug 18, 2015, at 07:53 PM, Mauro Rossi wrote: --- src/gallium/winsys/amdgpu/drm/Android.mk | 10 ++ 1 file changed, 10 insertions(+) diff --git a/src

Re: [Mesa-dev] [PATCH 05/12] glsl: fix isinf() for doubles

2015-08-16 Thread Edward O'Callaghan
Reviewed-by: Edward O'Callaghan eocallag...@alterapraxis.com -- Edward O'Callaghan edward.ocallag...@koparo.com On Sat, Aug 15, 2015, at 09:56 AM, Timothy Arceri wrote: Reviewed-by: Timothy Arceri t_arc...@yahoo.com.au ___ mesa-dev mailing list

Re: [Mesa-dev] [PATCH 06/12] glsl: fix ir_constant::equals() for doubles

2015-08-16 Thread Edward O'Callaghan
Reviewed-by: Edward O'Callaghan eocallag...@alterapraxis.com -- Edward O'Callaghan edward.ocallag...@koparo.com On Sat, Aug 15, 2015, at 09:52 AM, Timothy Arceri wrote: Reviewed-by: Timothy Arceri t_arc...@yahoo.com.au ___ mesa-dev mailing

Re: [Mesa-dev] [PATCH 01/12] nir/builder: include nir.h

2015-08-16 Thread Edward O'Callaghan
Reviewed-by: Edward O'Callaghan eocallag...@alterapraxis.com -- Edward O'Callaghan edward.ocallag...@koparo.com On Sat, Aug 15, 2015, at 08:30 AM, Connor Abbott wrote: This makes intelligent autocomplete plugins much happier. Signed-off-by: Connor Abbott connor.w.abb...@intel.com

Re: [Mesa-dev] [PATCH 03/12] nir: fix constant folding of bfi

2015-08-16 Thread Edward O'Callaghan
Reviewed-by: Edward O'Callaghan eocallag...@alterapraxis.com -- Edward O'Callaghan edward.ocallag...@koparo.com On Sat, Aug 15, 2015, at 08:30 AM, Connor Abbott wrote: Signed-off-by: Connor Abbott connor.w.abb...@intel.com --- src/glsl/nir/nir_opcodes.py | 4 ++-- 1 file changed, 2

Re: [Mesa-dev] [PATCH] gallium: add support for GLES texture float extensions (v2)

2015-08-13 Thread Edward O'Callaghan
Reviewed-by: Edward O'Callaghan eocallag...@alterapraxis.com -- Edward O'Callaghan edward.ocallag...@koparo.com On Wed, Aug 12, 2015, at 08:45 PM, Marek Olšák wrote: From: Marek Olšák marek.ol...@amd.com Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=74329 v2: add a CAP

Re: [Mesa-dev] [PATCH 1/2] r600g: fix polygon offset scale

2015-08-11 Thread Edward O'Callaghan
Reviewed-by: Edward O'Callaghan eocallaghan at alterapraxis.com -- Edward O'Callaghan edward.ocallag...@koparo.com On Wed, Aug 12, 2015, at 09:02 AM, Marek Olšák wrote: From: Marek Olšák marek.ol...@amd.com The value was copied from r300g, which uses 1/12 subpixels, but this hw uses 1

Re: [Mesa-dev] [PATCH] st/mesa: small cleanup in st_extensions.c

2015-08-11 Thread Edward O'Callaghan
Reviewed-by: Edward O'Callaghan eocallaghan at alterapraxis.com -- Edward O'Callaghan edward.ocallag...@koparo.com On Wed, Aug 12, 2015, at 07:34 AM, Ilia Mirkin wrote: Reviewed-by: Ilia Mirkin imir...@alum.mit.edu On Tue, Aug 11, 2015 at 5:26 PM, Marek Olšák mar...@gmail.com wrote

Re: [Mesa-dev] [PATCH 2/2][RFC] docs: Add the 2015 ARB extensions

2015-08-11 Thread Edward O'Callaghan
Reviewed-by: Edward O'Callaghan eocallaghan at alterapraxis.com -- Edward O'Callaghan edward.ocallag...@koparo.com On Wed, Aug 12, 2015, at 03:48 AM, Thomas Helland wrote: Signed-off-by: Thomas Helland thomashellan...@gmail.com --- This adds a section for the extensions nvidia has chosen

Re: [Mesa-dev] [PATCH 1/5] main: add extension GL_ARB_shader_image_size

2015-08-11 Thread Edward O'Callaghan
Reviewed-by: Edward O'Callaghan eocallaghan at alterapraxis.com -- Edward O'Callaghan edward.ocallag...@koparo.com On Wed, Aug 12, 2015, at 02:43 AM, Martin Peres wrote: Signed-off-by: Martin Peres martin.pe...@linux.intel.com --- src/glsl/glcpp/glcpp-parse.y| 3 +++ src/glsl

Re: [Mesa-dev] [PATCH 2/2] r600g: allow setting geometry shader sampler states

2015-08-11 Thread Edward O'Callaghan
Reviewed-by: Edward O'Callaghan eocallaghan at alterapraxis.com -- Edward O'Callaghan edward.ocallag...@koparo.com On Wed, Aug 12, 2015, at 09:03 AM, Marek Olšák wrote: From: Marek Olšák marek.ol...@amd.com We were ignoring them. This is both hilarious and sad. Cc: mesa-sta

Re: [Mesa-dev] [PATCH] r600, compute: setup compute sampler states and views

2015-08-11 Thread Edward O'Callaghan
-- Edward O'Callaghan edward.ocallag...@koparo.com On Wed, Aug 12, 2015, at 05:54 AM, Marek Olšák wrote: On Mon, Aug 10, 2015 at 8:30 PM, Zoltan Gilian zoltan.gil...@gmail.com wrote: --- src/gallium/drivers/r600/evergreen_compute.c | 25 ++ src/gallium/drivers

Re: [Mesa-dev] [PATCH] radeonsi: add new OLAND pci id

2015-08-10 Thread Edward O'Callaghan
Reviewed-by: Edward O'Callaghan eocallag...@alterapraxis.com -- Edward O'Callaghan edward.ocallag...@koparo.com On Tue, Aug 11, 2015, at 05:36 AM, Alex Deucher wrote: Signed-off-by: Alex Deucher alexander.deuc...@amd.com Cc: mesa-sta...@lists.freedesktop.org --- include/pci_ids

Re: [Mesa-dev] [PATCH] gallium/radeon: fix r600g build if LLVM is disabled

2015-08-09 Thread Edward O'Callaghan
LGTM Reviewed-by: Edward O'Callaghan eocallaghan at alterapraxis.com -- Edward O'Callaghan edward.ocallag...@koparo.com On Sat, Aug 8, 2015, at 10:05 PM, Marek Olšák wrote: From: Marek Olšák marek.ol...@amd.com MESA_LLVM_VERSION_PATCH is undefined. --- src/gallium/drivers/radeon

Re: [Mesa-dev] [PATCH 1/3] addrlib: add support for Fiji (v2)

2015-08-04 Thread Edward O'Callaghan
LGTM Reviewed-by: Edward O'Callaghan eocallag...@alterapraxis.com -- Edward O'Callaghan edward.ocallag...@koparo.com On Tue, Aug 4, 2015, at 03:51 AM, Alex Deucher wrote: v2: fix tonga chip check Reviewed-by: Marek Olšák marek.ol...@amd.com Reviewed-by: Christian König christian.koe

Re: [Mesa-dev] [PATCH 2/3] radeonsi: add support for FIJI (v4)

2015-08-04 Thread Edward O'Callaghan
LGTM Reviewed-by: Edward O'Callaghan eocallag...@alterapraxis.com -- Edward O'Callaghan edward.ocallag...@koparo.com On Tue, Aug 4, 2015, at 03:51 AM, Alex Deucher wrote: v2: incorporate comments from Marek v3: add missing fiji case in winsys init use tonga raster config (double

Re: [Mesa-dev] [PATCH 3/3] radeonsi: add fiji pci id

2015-08-04 Thread Edward O'Callaghan
LGTM Reviewed-by: Edward O'Callaghan eocallag...@alterapraxis.com -- Edward O'Callaghan edward.ocallag...@koparo.com On Tue, Aug 4, 2015, at 03:51 AM, Alex Deucher wrote: Reviewed-by: Marek Olšák marek.ol...@amd.com Reviewed-by: Christian König christian.koe...@amd.com Reviewed

Re: [Mesa-dev] [PATCH] r600: Remove assert that not general in some stream instr's

2015-07-31 Thread Edward O'Callaghan
O'Callaghan edward.ocallag...@koparo.com On Fri, Jul 31, 2015, at 12:47 PM, Dave Airlie wrote: seems like one I wrote already.. http://lists.freedesktop.org/archives/mesa-dev/2015-July/088404.html Dave. On 31 July 2015 at 12:42, Edward O'Callaghan eocallag...@alterapraxis.com wrote: Don't

[Mesa-dev] [PATCH] r600: Remove assert that not general in some stream instr's

2015-07-30 Thread Edward O'Callaghan
Don't trigger assert on some stream emit instructions. Signed-off-by: Edward O'Callaghan eocallag...@alterapraxis.com --- src/gallium/drivers/r600/sb/sb_bc_finalize.cpp | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/gallium/drivers/r600/sb/sb_bc_finalize.cpp b/src/gallium/drivers/r600

[Mesa-dev] [PATCH/RFC] Minor assert fix

2015-07-30 Thread Edward O'Callaghan
I believe this assert isn't vaild in generality of possible stream emit instructions out the sb backend finalizer. Edward O'Callaghan (1): r600: Remove assert that not general in some stream instr's src/gallium/drivers/r600/sb/sb_bc_finalize.cpp | 2 -- 1 file changed, 2 deletions

[Mesa-dev] [PATCH 1/2] r600: Fix some printf format warns pretaining to PRIi64

2015-07-29 Thread Edward O'Callaghan
Signed-off-by: Edward O'Callaghan eocallag...@alterapraxis.com --- src/gallium/drivers/r600/compute_memory_pool.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/gallium/drivers/r600/compute_memory_pool.c b/src/gallium/drivers/r600/compute_memory_pool.c index

[Mesa-dev] [PATCH 0/2] Misc compiler warn fixes

2015-07-29 Thread Edward O'Callaghan
Rather boring patches to fix a few compiler warnings. Edward O'Callaghan (2): r600: Fix some printf format warns pretaining to PRIi64 mesa: Fix printf format specifier warn of the ptrdiff_t src/gallium/drivers/r600/compute_memory_pool.c | 8 src/mesa/main/bufferobj.c

Re: [Mesa-dev] [PATCH 2/2] mesa: Fix printf format specifier warn of the ptrdiff_t

2015-07-29 Thread Edward O'Callaghan
On Thu, Jul 30, 2015, at 09:53 AM, Ilia Mirkin wrote: I assume that you mean the C99 spec? I don't think MSVC supports %t or %z :( Correct, why not it is standard C99 sounds like a compiler bug to me if that is really the case :/ On Wed, Jul 29, 2015 at 7:46 PM, Edward O'Callaghan eocallag

[Mesa-dev] [PATCH 2/2] mesa: Fix printf format specifier warn of the ptrdiff_t

2015-07-29 Thread Edward O'Callaghan
See §7.19.6.1, paragraph 7 of the ISO C specification. Signed-off-by: Edward O'Callaghan eocallag...@alterapraxis.com --- src/mesa/main/bufferobj.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mesa/main/bufferobj.c b/src/mesa/main/bufferobj.c index 9425b09..453b864

Re: [Mesa-dev] Support 'GL_ARB_conditional_render_inverted' for r600 radeonsi

2015-07-28 Thread Edward O'Callaghan
. -- Edward O'Callaghan edward.ocallag...@koparo.com On Tue, Jul 28, 2015, at 09:26 PM, Marek Olšák wrote: Hi Edward, please use git send-email next time. Now I have to paste your patch here. diff --git a/docs/GL3.txt b/docs/GL3.txt index 15bb57f..6d9d424 100644 --- a/docs/GL3.txt +++ b

[Mesa-dev] Support 'GL_ARB_conditional_render_inverted' for r600 radeonsi

2015-07-27 Thread Edward O'Callaghan
for helping me test this! Kind Regards, Edward. -- Edward O'Callaghan edward.ocallag...@koparo.com From 430bb99cdd589611a56b19d1a649bfad3c20d261 Mon Sep 17 00:00:00 2001 From: Edward O'Callaghan eocallag...@alterapraxis.com Date: Mon, 27 Jul 2015 11:01:47 +1000 Subject: [PATCH] r600,radeonsi

<    1   2   3   4   5   6   >