Re: [Mesa-dev] Is it time to stop using the mailing list for patch review?

2019-12-11 Thread Marek Olšák
On Wed, Dec 11, 2019 at 12:02 PM Brian Paul wrote: > On 12/09/2019 04:07 PM, Dylan Baker wrote: > > Hi everyone, > > > > I think its time we discussed whether we're going to continue to do > patch review > > on the mailing list, or if it it should all go through gitlab. I think > we should > >

Re: [Mesa-dev] Is it time to stop using the mailing list for patch review?

2019-12-09 Thread Marek Olšák
Do we plan to remove the patchwork action on push? Marek On Mon, Dec 9, 2019 at 9:10 PM Roland Scheidegger wrote: > So, I'm guilty of being one of the few still using the mailing list... > But in any case, certainly I can switch to using MRs if everybody > prefers that now (meaning, I'm really

Re: [Mesa-dev] Remove classic drivers or fork src/mesa for gallium?

2019-12-03 Thread Marek Olšák
On Wed., Dec. 4, 2019, 01:20 Tapani Pälli, wrote: > Hi; > > On 12/4/19 2:39 AM, Marek Olšák wrote: > > Hi, > > > > Here are 2 proposals to simplify and better optimize the GL->Gallium > > translation. > > > > 1) Move classic drivers to a fork o

[Mesa-dev] gallium: rename "state tracker" to "api" in most places

2019-12-03 Thread Marek Olšák
Hi, FYI, this is a pretty big change, so I'm posting it here as well: https://gitlab.freedesktop.org/mesa/mesa/merge_requests/2956 Only the GL state tracker will keep its name. All other state trackers will be called "API implementations". Marek ___

[Mesa-dev] Remove classic drivers or fork src/mesa for gallium?

2019-12-03 Thread Marek Olšák
Hi, Here are 2 proposals to simplify and better optimize the GL->Gallium translation. 1) Move classic drivers to a fork of Mesa, and remove them from master. Classic drivers won't share any code with master. glvnd will load them, but glvnd is not ready for this yet. 2) Keep classic drivers.

Re: [Mesa-dev] [PATCH] radeonsi: Add support for midstream bitrate change in encoder

2019-12-03 Thread Marek Olšák
+Leo On Mon, Dec 2, 2019 at 11:31 PM Satyajit Sahu wrote: > Added support for bitrate change in between encoding. > > Signed-off-by: Satyajit Sahu > > diff --git a/src/gallium/drivers/radeon/radeon_vce.c > b/src/gallium/drivers/radeon/radeon_vce.c > index 84d3c1e2fa4..7d7a2fa4eb3 100644 > ---

Re: [Mesa-dev] [PATCH] util/u_thread: don't restrict u_thread_get_time_nano() to __linux__

2019-12-02 Thread Marek Olšák
I've pushed this. Thanks! Marek On Mon, Dec 2, 2019 at 5:12 PM Marek Olšák wrote: > Reviewed-by: Marek Olšák > > Marek > > On Sat, Nov 30, 2019 at 10:17 AM Jonathan Gray wrote: > >> pthread_getcpuclockid() and clock_gettime() are also available on at least >

Re: [Mesa-dev] [PATCH] util/futex: use futex syscall on OpenBSD

2019-12-02 Thread Marek Olšák
Pushed. Thanks! Marek On Sat, Nov 30, 2019 at 10:19 AM Jonathan Gray wrote: > Make use of the futex syscall added in OpenBSD 6.2. > > Signed-off-by: Jonathan Gray > --- > src/util/futex.h | 18 ++ > 1 file changed, 18 insertions(+) > > diff --git a/src/util/futex.h

Re: [Mesa-dev] [PATCH] util/u_thread: don't restrict u_thread_get_time_nano() to __linux__

2019-12-02 Thread Marek Olšák
Reviewed-by: Marek Olšák Marek On Sat, Nov 30, 2019 at 10:17 AM Jonathan Gray wrote: > pthread_getcpuclockid() and clock_gettime() are also available on at least > OpenBSD, FreeBSD, NetBSD, DragonFly, Cygwin. > > Signed-off-by: Jonathan Gray > --- > src/util/u_thread.

Re: [Mesa-dev] [PATCH] winsys/amdgpu: avoid double simple_mtx_unlock()

2019-11-28 Thread Marek Olšák
Pushed, thanks! Marek On Thu, Nov 28, 2019 at 12:56 AM Jonathan Gray wrote: > pthread_mutex_unlock() when unlocked is documented by posix as > being undefined behaviour. On OpenBSD pthread_mutex_unlock() will call > abort(3) if this happens. > > This occurs in amdgpu_winsys_create() after >

Re: [Mesa-dev] [radeonsi] enable OpenGL 4.6

2019-11-27 Thread Marek Olšák
Hi, The setting is radeonsi_enable_nir=true Marek On Wed., Nov. 27, 2019, 23:42 Dieter Nützel, wrote: > Hello Marek and Pierre-Eric, > > GREAT work but this time I'm to stupid (tired). > I only 'see' 4.5. - E.g. that R600_DEBUG/AMD_DEBUG=nir is set. > Was at the dentist yesterday... > > >

Re: [Mesa-dev] gl_nir_lower_samplers_as_deref vs drawpixels lowering

2019-11-25 Thread Marek Olšák
The way shader variants work in st/mesa is that NIR is generated, finalized, and stored in the cache. This helps the most common case when there is only one variant. If shader variants make changes to NIR, like adding samplers, uniforms, and inputs, it needs to be finalized again, which means many

Re: [Mesa-dev] [v2, 2/2] state_tracker: Handle texture view min level in st_generate_mipmap()

2019-11-04 Thread Marek Olšák
I've pushed this patch. Thanks! Marek On Mon, Nov 4, 2019 at 7:31 AM Paul Gofman wrote: > Signed-off-by: Paul Gofman > --- > Corresponding piglit test patch: > https://patchwork.freedesktop.org/patch/338798/ > > src/mesa/state_tracker/st_gen_mipmap.c | 8 +++- > 1 file changed, 7

Re: [Mesa-dev] [PATCH] ac: add missing Arcturus to the info of pc lines

2019-11-04 Thread Marek Olšák
Actually, pc_lines should be 0, so a case with only a break statement should be used. Marek On Mon, Nov 4, 2019 at 1:00 PM Marek Olšák wrote: > Reviewed-by: Marek Olšák > > Marek > > On Mon, Nov 4, 2019 at 11:30 AM Liu, Leo wrote: > >> Signed-off-by: Leo

Re: [Mesa-dev] [PATCH] ac: add missing Arcturus to the info of pc lines

2019-11-04 Thread Marek Olšák
Reviewed-by: Marek Olšák Marek On Mon, Nov 4, 2019 at 11:30 AM Liu, Leo wrote: > Signed-off-by: Leo Liu > Cc: Marek Olšák > --- > src/amd/common/ac_gpu_info.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/src/amd/common/ac_gpu_info.c b/src/amd/common/

Re: [Mesa-dev] Is libdrm-2.4.100 released or not?

2019-10-29 Thread Marek Olšák
Yes, it's released. Marek On Tue., Oct. 29, 2019, 15:10 Dieter Nützel, wrote: > Asking about this one: > > ac: get tcc_harvested from the kernel > commit 9edcce2a32ed872fef3167258ad2ae4952ca4c60 > > [-] > -_drm_amdgpu_ver = '2.4.99' > +_drm_amdgpu_ver = '2.4.100' > [-] > > Thanks, > Dieter >

Re: [Mesa-dev] mesa/st: support lowering user-clip-planes automatically

2019-10-21 Thread Marek Olšák
On Mon, Oct 21, 2019 at 5:37 AM Erik Faye-Lund wrote: > On Fri, 2019-10-18 at 18:23 -0400, Marek Olšák wrote: > > Oh BTW, drivers that want to implement pipe_screen::finalize_nir to > > improve cached shader compilation can't use any of those lowering > > passes, becaus

Re: [Mesa-dev] mesa/st: support lowering user-clip-planes automatically

2019-10-18 Thread Marek Olšák
(radeonsi doesn't need any). If you need more, you either need to invest a significant amount of time to make driver-specific NIR work with the lowering passes, or give up on good shader cache efficiency. Marek On Fri, Oct 18, 2019 at 4:17 PM Marek Olšák wrote: > Note that none of the lower

Re: [Mesa-dev] mesa/st: support lowering user-clip-planes automatically

2019-10-18 Thread Marek Olšák
be done at the machine-level assembly code, so that you don't have to completely recompile from a higher-level IR. Marek On Fri, Oct 18, 2019 at 4:08 PM Marek Olšák wrote: > On Fri, Oct 18, 2019 at 9:07 AM Ilia Mirkin wrote: > >> On Fri, Oct 18, 2019 at 9:04 AM Erik Faye-Lu

Re: [Mesa-dev] mesa/st: support lowering user-clip-planes automatically

2019-10-18 Thread Marek Olšák
On Fri, Oct 18, 2019 at 9:07 AM Ilia Mirkin wrote: > On Fri, Oct 18, 2019 at 9:04 AM Erik Faye-Lund > wrote: > > > > On Fri, 2019-10-18 at 08:57 -0400, Ilia Mirkin wrote: > > > On Fri, Oct 18, 2019 at 8:51 AM Erik Faye-Lund > > > wrote: > > > > On Thu, 2019-10-17 at 22:24 -0400, Ilia Mirkin

[Mesa-dev] libdrm can't be released because of meson

2019-10-16 Thread Marek Olšák
Hi, Since autotools is no longer in libdrm, it's not possible to make a release: $ ../modular/release.sh --gpgkey ... Processing "/home/marek/dev/drm/." Info: working off the "master" branch tracking the remote "origin/master". Info: creating new git worktree. Preparing

Re: [Mesa-dev] libdrm versioning - switch to 19.0.0?

2019-10-11 Thread Marek Olšák
I see. It will be 2.year.n then unless there are objections. Marek On Fri, Oct 11, 2019 at 12:47 PM Dylan Baker wrote: > Quoting Eric Engestrom (2019-10-11 06:10:58) > > On Thursday, 2019-10-10 16:14:47 -0400, Marek Olšák wrote: > > > Hi, > > > > > > I expe

Re: [Mesa-dev] libdrm versioning - switch to 19.0.0?

2019-10-11 Thread Marek Olšák
On Fri., Oct. 11, 2019, 02:02 Dave Airlie, wrote: > On Fri, 11 Oct 2019 at 14:56, Rob Clark wrote: > > > > On Thu, Oct 10, 2019 at 7:46 PM Jason Ekstrand > wrote: > > > > > > On October 10, 2019 15:15:29 Marek Olšák wrote: > > >> > > >

Re: [Mesa-dev] [radeonsi] Clover broken after new 'nir_serialize'

2019-10-10 Thread Marek Olšák
It should be fixed now. Marek On Thu, Oct 10, 2019 at 6:42 PM Marek Olšák wrote: > Hi, > > Sorry for the breakage. I guess it's a recently added file, because I > didn't see it in my IDE. > > Marek > > On Thu, Oct 10, 2019 at 6:27 PM Dieter Nützel > wrote: > &

Re: [Mesa-dev] [radeonsi] Clover broken after new 'nir_serialize'

2019-10-10 Thread Marek Olšák
Hi, Sorry for the breakage. I guess it's a recently added file, because I didn't see it in my IDE. Marek On Thu, Oct 10, 2019 at 6:27 PM Dieter Nützel wrote: > Hello Marek, > > forgotten to update Clover? > > Greetings, > Dieter > > [1261/1386] Compiling C++ object >

[Mesa-dev] libdrm versioning - switch to 19.0.0?

2019-10-10 Thread Marek Olšák
Hi, I expect to make a new libdrm release soon. Any objections to changing the versioning scheme? Current: 2.4.n n = starts from 0, incremented per release New proposals: year.n.0 (19.0.0) year.month.n (19.10.0) year.month.day (19.10.10) Marek ___

Re: [Mesa-dev] [PATCH 1/2] gallium/tgsi: add support for DEMOTE and READ_HELPER opcodes

2019-10-07 Thread Marek Olšák
Reviewed-by: Marek Olšák Marek On Wed, Oct 2, 2019 at 7:49 PM Ilia Mirkin wrote: > This mirrors the intrinsics in the GLSL IR. One could imagine an > alternate definition where reading the semantic would account for the > READ_HELPER functionality, but that feels potentially dodgy

Re: [Mesa-dev] [PATCH] mesa: fix texStore for FORMAT_Z32_FLOAT_S8X24_UINT

2019-09-12 Thread Marek Olšák
> > stripped by the ML. Adding here. > > > > On Tue, Aug 27, 2019 at 6:49 PM Marek Olšák wrote: > > > > > > Yes, but if the original author doesn't reply, I'd like to push this. > > > > > > Marek > > > > > > On Thu, Aug 1

Re: [Mesa-dev] [PATCH] teximage: ensure that Tex*SubImage* checks format

2019-09-03 Thread Marek Olšák
Reviewed-by: Marek Olšák Marek On Mon, Sep 2, 2019 at 7:40 PM Ilia Mirkin wrote: > We were previously not doing at least some of the checks. This uses the > same logic that is used in glTexImage*. > > Signed-off-by: Ilia Mirkin > --- > > This seems to leave the Intel C

Re: [Mesa-dev] [PATCH] mesa: fix texStore for FORMAT_Z32_FLOAT_S8X24_UINT

2019-08-27 Thread Marek Olšák
DEX -- could it not be 1-byte? IOW, > should this just be a char *, and use byte addressing and be done with > it? > > On Thu, Aug 15, 2019 at 7:56 PM Marek Olšák wrote: > > > > From: Jiadong Zhu > > > > _mesa_texstore_z32f_x24s8 calculates source rowStride at a >

Re: [Mesa-dev] Navi14 for 19.2

2019-08-27 Thread Marek Olšák
+ Juan, Emil, Jeremy Thanks, Marek On Mon, Aug 26, 2019 at 3:05 PM Marek Olšák wrote: > Hi, > > I'd like to push the Navi14 merge request to 19.2 no later than Tuesday > August 27. > > https://gitlab.freedesktop.org/mesa/mesa/merge_requests/1726 > > Please ack if it's

Re: [Mesa-dev] Difference between TransformFeedback Gallium <-> Vulkan (V3D)

2019-08-26 Thread Marek Olšák
On Mon, Aug 26, 2019 at 6:51 PM Jason Ekstrand wrote: > On Mon, Aug 26, 2019 at 6:43 AM Daniel Stone wrote: > >> Hi Andreas, >> >> On Sun, 25 Aug 2019 at 21:11, Andreas Bergmeier >> wrote: >> > For a few weeks now I am working on implementing Vulkan for VideoCore 6 >> AKA 42 (using V3D/DRM).

[Mesa-dev] Navi14 for 19.2

2019-08-26 Thread Marek Olšák
Hi, I'd like to push the Navi14 merge request to 19.2 no later than Tuesday August 27. https://gitlab.freedesktop.org/mesa/mesa/merge_requests/1726 Please ack if it's OK with you, Thanks, Marek ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org

Re: [Mesa-dev] Mesa 19.2.0 release plan

2019-08-21 Thread Marek Olšák
FYI, I'm considering adding Navi14 support into 19.2, basically this MR: https://gitlab.freedesktop.org/mesa/mesa/merge_requests/1726 Marek On Wed, Aug 21, 2019 at 1:04 PM Jason Ekstrand wrote: > On Wed, Aug 21, 2019 at 10:05 AM apinheiro wrote: > >> (Thanks Chema for pointing me this thread)

Re: [Mesa-dev] [PATCH] gallium/vl: use compute preference for all multimedia, not just blit

2019-08-20 Thread Marek Olšák
Reviewed-by: Marek Olšák Marek On Sat, Aug 17, 2019 at 12:17 PM Ilia Mirkin wrote: > The compute paths in vl are a bit AMD-specific. For example, they (on > nouveau), try to use a BGRX8 image format, which is not supported. > Fixing all this is probably possible, but since the comp

[Mesa-dev] [PATCH] mesa: fix texStore for FORMAT_Z32_FLOAT_S8X24_UINT

2019-08-15 Thread Marek Olšák
Signed-off-by: Marek Olšák --- src/mesa/main/texstore.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) mode change 100644 => 100755 src/mesa/main/texstore.c diff --git a/src/mesa/main/texstore.c b/src/mesa/main/texstore.c old mode 100644 new mode 100755 index 2913d4bc067..20769504

Re: [Mesa-dev] [PATCH v7 1/5] egl/android: Delete set_damage_region from egl dri vtbl

2019-08-12 Thread Marek Olšák
For the first 4 patches: Reviewed-by: Marek Olšák Marek On Mon, Aug 12, 2019 at 6:07 AM Boris Brezillon < boris.brezil...@collabora.com> wrote: > From: Harish Krupo > > The intension of the KHR_partial_update was not to send the damage back > to the platform but

Re: [Mesa-dev] [PATCH] st/mesa: don't allocate mipmapped texture for NEAREST_MIPMAP_LINEAR

2019-08-10 Thread Marek Olšák
Ping On Fri., Aug. 2, 2019, 19:13 Marek Olšák, wrote: > From: Marek Olšák > > --- > src/mesa/state_tracker/st_cb_texture.c | 12 > 1 file changed, 12 insertions(+) > > diff --git a/src/mesa/state_tracker/st_cb_texture.c > b/src/mesa/state_tracker

Re: [Mesa-dev] [PATCH] util/slab: add slab_free_fast()

2019-08-07 Thread Marek Olšák
Reviewed-by: Marek Olšák Marek On Wed, Aug 7, 2019 at 6:02 PM Rob Clark wrote: > From: Rob Clark > > I noticed slab_free() showing up at the top of perf results in > gl_driver2, due to "streaming" GPU state objects, which are allocated > and destroyed

Re: [Mesa-dev] [PATCH] mesa: remove super old TODOs from shaderapi.c

2019-08-06 Thread Marek Olšák
Reviewed-by: Marek Olšák Marek On Tue, Aug 6, 2019 at 8:21 PM Timothy Arceri wrote: > --- > src/mesa/main/shaderapi.c | 5 - > 1 file changed, 5 deletions(-) > > diff --git a/src/mesa/main/shaderapi.c b/src/mesa/main/shaderapi.c > index 1351f7fd06f..607d30e2bd4 10064

Re: [Mesa-dev] [PATCH] radeonsi: Bump number of allowed global buffers to 48 (again, for clover Blender assertion)

2019-08-06 Thread Marek Olšák
Do you know why global buffers are in the compute state and not in the context? Marek On Tue, Aug 6, 2019 at 10:50 PM Dieter Nützel wrote: > Am 20.06.2019 20:44, schrieb Jan Vesely: > > On Sat, 2019-06-15 at 07:38 +0200, Dieter Nützel wrote: > >> Am 14.06.2019 08:13, schrieb Jan Vesely: > >> >

Re: [Mesa-dev] [PATCH 2/4] gallium: redefine ATOMINC_WRAP to be more hardware-friendly

2019-08-06 Thread Marek Olšák
For the first two: Reviewed-by: Marek Olšák Marek On Tue, Aug 6, 2019 at 11:06 PM Ilia Mirkin wrote: > Both AMD and NVIDIA hardware define it this way. Instead of replicating > the logic everywhere, just fix it up in one place. > > Signed-off-by: Ilia Mirkin > --- >

Re: [Mesa-dev] EXT_shader_image_load_store requires format-less loads?

2019-08-06 Thread Marek Olšák
It's possible that I misread the spec, because the format qualifier looked imprecise. Feel free to fix this. Marek On Tue, Aug 6, 2019 at 8:10 PM Ilia Mirkin wrote: > Hi Pierre-Eric, > > I see you recently added EXT_shader_image_load_store - nice. It seems > like you're relying on the

Re: [Mesa-dev] Re mesa/st: add tgsi-lowering code for depth-clamp

2019-08-02 Thread Marek Olšák
I think > the ij coefficients themselves are different? Not sure, it just seems > like z has to be taken into account *somewhere* otherwise the whole > thing can't possibly work. > > -ilia > > On Fri, Aug 2, 2019 at 8:11 PM Marek Olšák wrote: > > > > IIRC, perspective

Re: [Mesa-dev] Re mesa/st: add tgsi-lowering code for depth-clamp

2019-08-02 Thread Marek Olšák
IIRC, perspective interpolation is driven by W, not Z. Interpolating W and then computing barycentric coordinates using 1/W is what causes the perspective distortion. Marek On Fri, Aug 2, 2019 at 4:59 PM Ilia Mirkin wrote: > On Fri, Aug 2, 2019 at 3:46 PM Gert Wollny > wrote: > > > > Am

[Mesa-dev] [PATCH] radeonsi: fix an assertion failure: assert(!res->b.is_shared)

2019-08-02 Thread Marek Olšák
From: Marek Olšák This only appears to happen on Raven2. Possible way to reproduce: resource_get_handle(WINSYS_HANDLE_TYPE_KMS) --> sets is_shared = true resource_get_handle(WINSYS_HANDLE_TYPE_DMABUF) --> fail Cc: 19.1 19.2 --- src/gallium/drivers/radeonsi/si_texture.c | 3 +--

[Mesa-dev] [PATCH] st/mesa: don't allocate mipmapped texture for NEAREST_MIPMAP_LINEAR

2019-08-02 Thread Marek Olšák
From: Marek Olšák --- src/mesa/state_tracker/st_cb_texture.c | 12 1 file changed, 12 insertions(+) diff --git a/src/mesa/state_tracker/st_cb_texture.c b/src/mesa/state_tracker/st_cb_texture.c index 0edb3ea5c7e..1ace61863ff 100644 --- a/src/mesa/state_tracker/st_cb_texture.c

Re: [Mesa-dev] A question about order of st_update_*p

2019-07-26 Thread Marek Olšák
right? > So st_update_gp should be after st_update_vp, but now it is in the > front of st_update_vp. > > On Fri, Jul 26, 2019 at 1:07 PM Marek Olšák wrote: > > > > > > > > On Fri., Jul. 26, 2019, 15:58 Lepton Wu, wrote: > >> > >> If shader A de

Re: [Mesa-dev] A question about order of st_update_*p

2019-07-26 Thread Marek Olšák
Fri, Jul 26, 2019 at 12:34 PM Marek Olšák wrote: > > > > The order shouldn't matter, but there can be a reason behind it, e.g. if > a shader depends on the update of the following shader. > > > > Marek > > > > On Wed, Jul 24, 2019 at 7:19 PM Lepton Wu

Re: [Mesa-dev] A question about order of st_update_*p

2019-07-26 Thread Marek Olšák
The order shouldn't matter, but there can be a reason behind it, e.g. if a shader depends on the update of the following shader. Marek On Wed, Jul 24, 2019 at 7:19 PM Lepton Wu wrote: > In src/mesa/state_tracker/st_atom_list.h, > > Now it's this order: > > ST_STATE(ST_NEW_FS_STATE,

Re: [Mesa-dev] [PATCH 1/4] gallium/vl: fix compute tgsi shaders to not process undefined components

2019-07-26 Thread Marek Olšák
Reviewed-by: Marek Olšák Marek On Thu, Jul 25, 2019 at 11:30 PM Ilia Mirkin wrote: > This caused nouveau's function handling logic to think that the MAIN > function was due to receive external parameters, and cascaded some > failures after that. Instead avoid having the undefined c

Re: [Mesa-dev] [PATCH] radv/gfx10: fix intensity formats by setting ALPHA_IS_ON_MSB

2019-07-24 Thread Marek Olšák
On Wed, Jul 24, 2019 at 9:18 AM Bas Nieuwenhuizen wrote: > On Wed, Jul 24, 2019 at 3:00 PM Samuel Pitoiset > wrote: > > > > This fixes > > dEQP-VK.rasterization.primitive_size.points.point_size_* > > > > This also fixes some black squares with the Sascha SSAO demo. > > > > Signed-off-by: Samuel

Re: [Mesa-dev] [PATCH 1/2] radv/gfx10: always build the GS copy shader but uses it on-demand

2019-07-17 Thread Marek Olšák
I think Vulkan doesn't need to use legacy GS, because gs_invocations doesn't multiply the max_out_vertices limit in Vulkan, but it does multiply it in GL. Marek On Tue, Jul 16, 2019 at 10:39 AM Samuel Pitoiset wrote: > It should be possible to build it on-demand too but it requires > more

Re: [Mesa-dev] [PATCH] st/mesa: accelerate glCopyPixels(STENCIL)

2019-07-11 Thread Marek Olšák
is patch landed master with the v3d driver. So Marek > and anyone reading this email, could you execute that test and confirms > if only regress with v3d? > > Thanks in advance. > > On 25/6/19 2:12, Marek Olšák wrote: > > From: Marek Olšák > > > > --- &

[Mesa-dev] [PATCH] pipe-loader: use radeonsi for MM if amdgpu dri is used

2019-07-11 Thread Marek Olšák
From: Jeremy Newton The amdgpu dri is used for the closed source AMD driver. Since this driver does not implement multimedia, we fall back to radeonsi in mesa to do multimedia. This corrects the dri driver name for when it is set to amdgpu. Signed-off-by: Jeremy Newton Signed-off-by: Marek

Re: [Mesa-dev] [PATCH] gallium: switch boolean -> bool at the interface definitions

2019-07-08 Thread Marek Olšák
Reviewed-by: Marek Olšák Marek ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH] gallium: remove boolean from state tracker APIs

2019-07-08 Thread Marek Olšák
Reviewed-by: Marek Olšák Marek ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 3/3] android: amd/addrlib: add gfx10 support

2019-07-08 Thread Marek Olšák
For the series: Acked-by: Marek Olšák Marek On Sat, Jul 6, 2019 at 4:17 PM Mauro Rossi wrote: > Fix the following building error: > > external/mesa/src/amd/addrlib/src/gfx10/gfx10addrlib.cpp:35:10: > fatal error: 'gfx10_gb_reg.h' file not found > ^~~~ >

Re: [Mesa-dev] [PATCH] ac: select the GFX ring when halting waves with UMR on GFX10

2019-07-08 Thread Marek Olšák
Reviewed-by: Marek Olšák Marek On Sun, Jul 7, 2019 at 1:32 PM Samuel Pitoiset wrote: > GFX10 has two rings, so UMR want to know which one to halt. > Select the first one by default. > > Signed-off-by: Samuel Pitoiset > --- > src/amd/common/ac_debug.c | 9 ++

Re: [Mesa-dev] radeonsi: glmark2 - regression (GL_INVALID_OPERATION in glFramebufferTexture2D) - bisected

2019-07-03 Thread Marek Olšák
NDEBUG in the future Marek On Wed, Jul 3, 2019 at 4:00 AM Michel Dänzer wrote: > On 2019-07-02 7:29 p.m., Marek Olšák wrote: > > If you don't wanna see the messages, don't use debugoptimized. > > Makes sense, but means it needs to be guarded by DEBUG, not NDEBUG. > > >

Re: [Mesa-dev] radeonsi: glmark2 - regression (GL_INVALID_OPERATION in glFramebufferTexture2D) - bisected

2019-07-02 Thread Marek Olšák
ieter Nützel wrote: > >>> > >>> /opt/mesa> git bisect good > >>> b5697c311b6f29dee40b96c48bad3279e3667c1e is the first bad commit > >>> commit b5697c311b6f29dee40b96c48bad3279e3667c1e > >>> Author: Marek Olšák > >>> Date: T

Re: [Mesa-dev] [PATCH v5 4/5] st/dri2: Implement DRI2bufferDamageExtension

2019-07-02 Thread Marek Olšák
On Tue., Jul. 2, 2019, 09:50 Boris Brezillon, wrote: > From: Daniel Stone > > Add a pipe_screen->set_damage_region() hook to propagate > set-damage-region requests to the driver, it's then up to the driver to > decide what to do with this piece of information. > > If the hook is left

Re: [Mesa-dev] boolean usage in gallium

2019-06-29 Thread Marek Olšák
boolean predates c99 support in MSVC. I think there is no reason for boolean in gallium now. Marek On Sat., Jun. 29, 2019, 00:09 Ilia Mirkin, wrote: > Ken pointed out on IRC today that there was still a lot of "boolean" > (vs bool/_Bool) usage in gallium. In fact, many interfaces are >

Re: [Mesa-dev] [PATCH] st/mesa: accelerate glCopyPixels(STENCIL)

2019-06-28 Thread Marek Olšák
ping On Mon, Jun 24, 2019 at 8:12 PM Marek Olšák wrote: > From: Marek Olšák > > --- > src/mesa/state_tracker/st_cb_drawpixels.c | 58 +++ > 1 file changed, 38 insertions(+), 20 deletions(-) > > diff --git a/src/mesa/state_tracker/st_cb_draw

Re: [Mesa-dev] [PATCH 5/8] radeonsi: don't set spi_ps_input_* for monolithic shaders

2019-06-24 Thread Marek Olšák
ne bit in a > group is set and I think we end up with input_ena = 0 for monolithic > shaders now? > > On Thu, Jun 20, 2019 at 6:20 AM Marek Olšák wrote: > > > > From: Marek Olšák > > > > The driver doesn't use these values and ac_rtld has assertions > > ex

[Mesa-dev] [PATCH] st/mesa: accelerate glCopyPixels(STENCIL)

2019-06-24 Thread Marek Olšák
From: Marek Olšák --- src/mesa/state_tracker/st_cb_drawpixels.c | 58 +++ 1 file changed, 38 insertions(+), 20 deletions(-) diff --git a/src/mesa/state_tracker/st_cb_drawpixels.c b/src/mesa/state_tracker/st_cb_drawpixels.c index 59868d3ff1d..26d3cc33e5c 100644 --- a/src

Re: [Mesa-dev] [PATCH 5/6] gallium/util: Make it possible to disable persistent maps in the upload manager

2019-06-21 Thread Marek Olšák
Reviewed-by: Marek Olšák Marek On Wed, Jun 19, 2019 at 4:42 AM Thomas Hellström (VMware) < tho...@shipmail.org> wrote: > From: Thomas Hellstrom > > For svga, the use of persistent / coherent maps is typically slightly > slower than without them. It's probably a

Re: [Mesa-dev] [PATCH] ac: change ac_query_gpu_info() signatures

2019-06-21 Thread Marek Olšák
or r300 and r600. Hence we > copied the typedef. > > Seemingly this will be a problem since a libdrm_amdgpu wants to change > the API, while not updating the code(?). > libdrm_amdgpu can't change the API. Reviewed-by: Marek Olšák Marek ___ mesa-dev mai

Re: [Mesa-dev] [PATCH v2] radv: implement VK_EXT_sample_locations

2019-06-21 Thread Marek Olšák
Gfx10 remembers sample positions in compressed Z/S memory, so the hw doesn't need the decompress pass for shader loads. Marek On Wed, May 22, 2019 at 4:20 PM Marek Olšák wrote: > The depth decompress pass needs to know the sample locations. > > If shader loads read from compres

[Mesa-dev] [PATCH 2/3] gallium/u_blitter: implement copying from ZS to color and vice versa

2019-06-21 Thread Marek Olšák
From: Marek Olšák This is for drivers that can't map depth and stencil and need to blit them to a color texture for CPU access. This also useful for drivers using separate depth and stencil. --- src/gallium/auxiliary/tgsi/tgsi_opcode_tmp.h | 6 + src/gallium/auxiliary/util/u_blitter.c

[Mesa-dev] [PATCH 3/3] radeonsi: use a fragment shader blit instead of DB->CB copy for ZS CPU mappings

2019-06-21 Thread Marek Olšák
From: Marek Olšák This mainly removes and simplifies code that is no longer needed. There were some issues with the DB->CB stencil copy on gfx10, so let's just use a fragment shader blit for all ZS mappings. It's more reliable. --- src/gallium/drivers/radeonsi/si_blit.c| 29 +---

[Mesa-dev] [PATCH 1/3] gallium/util: rewrite depth-stencil blit shaders

2019-06-21 Thread Marek Olšák
From: Marek Olšák - merge all 3 functions (Z, S, ZS) - don't write the color output - read the value from texel.x, then write it to position.z or stencil.y (don't use the value from texel.y or texel.z) --- src/gallium/auxiliary/util/u_blitter.c| 19 +- src/gallium/auxiliary/util

Re: [Mesa-dev] [PATCH 7/7] radeonsi: don't use the low-optimizing compiler on LLVM 9

2019-06-20 Thread Marek Olšák
Yeah, I dropped it because LLVM is still slow. Marek On Thu, Jun 20, 2019 at 6:45 PM Dieter Nützel wrote: > Hello Marek, > > is this (#7) obsolete, now? > Kind reminder. > > Thanks, > Dieter > > Am 13.06.2019 02:40, schrieb Marek Olšák: > > From: Marek Olšák

[Mesa-dev] [PATCH 5/8] radeonsi: don't set spi_ps_input_* for monolithic shaders

2019-06-19 Thread Marek Olšák
From: Marek Olšák The driver doesn't use these values and ac_rtld has assertions expecting the value of 0. --- src/gallium/drivers/radeonsi/si_shader.c | 39 1 file changed, 26 insertions(+), 13 deletions(-) diff --git a/src/gallium/drivers/radeonsi/si_shader.c b/src

[Mesa-dev] [PATCH 2/8] amd/rtld: update the ELF representation of LDS symbols

2019-06-19 Thread Marek Olšák
From: Nicolai Hähnle The initial prototype used a processor-specific symbol type, but feedback suggests that an approach using processor-specific section name that encodes the alignment analogous to SHN_COMMON symbols is preferred. This patch keeps both variants around for now to reduce

[Mesa-dev] [PATCH 8/8] radeonsi: rename and re-document cache flush flags

2019-06-19 Thread Marek Olšák
From: Marek Olšák SMEM and VMEM caches are L0 on gfx10. --- src/gallium/drivers/radeonsi/si_compute.c | 2 +- .../drivers/radeonsi/si_compute_blit.c| 12 +++--- src/gallium/drivers/radeonsi/si_descriptors.c | 2 +- src/gallium/drivers/radeonsi/si_gfx_cs.c | 8 ++-- src

[Mesa-dev] [PATCH 6/8] radeonsi: flatten the switch for DPBB tunables

2019-06-19 Thread Marek Olšák
From: Marek Olšák --- .../drivers/radeonsi/si_state_binning.c| 18 -- 1 file changed, 4 insertions(+), 14 deletions(-) diff --git a/src/gallium/drivers/radeonsi/si_state_binning.c b/src/gallium/drivers/radeonsi/si_state_binning.c index 6285ccc28c2..a6b1830b661 100644

[Mesa-dev] [PATCH 4/8] radeonsi: set the calling convention for inlined function calls

2019-06-19 Thread Marek Olšák
From: Marek Olšák otherwise the behavior is undefined --- src/amd/common/ac_llvm_build.c | 8 src/amd/common/ac_llvm_build.h | 3 +++ src/gallium/drivers/radeonsi/si_compute_prim_discard.c | 2 +- src/gallium/drivers/radeonsi/si_shader.c

[Mesa-dev] [PATCH 1/8] ac/surface: remove addrlib_family_rev_id

2019-06-19 Thread Marek Olšák
From: Marek Olšák --- src/amd/common/ac_gpu_info.c | 2 + src/amd/common/ac_gpu_info.h | 2 + src/amd/common/ac_surface.c | 111 +-- 3 files changed, 7 insertions(+), 108 deletions(-) diff --git a/src/amd/common/ac_gpu_info.c b/src/amd/common/ac_gpu_info.c

[Mesa-dev] [PATCH 3/8] radeonsi: refactor si_update_vgt_shader_config

2019-06-19 Thread Marek Olšák
From: Nicolai Hähnle We'll have to extend this at some point, and using a bitfield union in this way makes it easier to get the right index without excessive branching. --- src/gallium/drivers/radeonsi/si_pipe.h| 23 ++- .../drivers/radeonsi/si_state_shaders.c | 65

Re: [Mesa-dev] [Mesa-stable] [PATCH] radeonsi: reduce MAX_GEOMETRY_OUTPUT_VERTICES

2019-06-18 Thread Marek Olšák
It's not needed in stable. This is a corner case for piglit. Marek On Tue, Jun 18, 2019 at 6:03 AM Juan A. Suarez Romero wrote: > On Fri, 2019-06-14 at 19:00 -0400, Marek Olšák wrote: > > From: Nicolai Hähnle > > > > This fixes piglit spec@glsl-1.50@gs-max-output. >

Re: [Mesa-dev] [PATCH] ac, radeonsi: Always mark buffer stores as inaccessiblememonly

2019-06-18 Thread Marek Olšák
Reviewed-by: Marek Olšák Marek On Tue, Jun 18, 2019 at 12:20 PM Haehnle, Nicolai wrote: > Makes sense to me. > > Acked-by: Nicolai Hähnle > > -Original Message- > From: Connor Abbott > Sent: Dienstag, 18. Juni 2019 15:21 > To: mesa-dev@lists.freedeskt

Re: [Mesa-dev] [PATCH] amd: update addrlib

2019-06-17 Thread Marek Olšák
On Sat, Jun 15, 2019 at 5:51 PM Bas Nieuwenhuizen wrote: > I'm not quite sure why the dimension changes are needed for radeonsi, > but for both polarisd and vega the compressed texture CTS tests pass > on RADV. > Addrlib no longer supports linear compressed formats, so 64-bit or 128-bit integer

Re: [Mesa-dev] [PATCH] amd/rtld: update the ELF representation of LDS symbols

2019-06-17 Thread Marek Olšák
Reviewed-by: Marek Olšák Marek On Mon, Jun 17, 2019 at 2:47 PM Haehnle, Nicolai wrote: > The following hunk needs to be added: > > > @@ -503,7 +521,9 @@ static bool resolve_symbol(const struct > ac_rtld_upload_info *u, > >unsigned part_idx,

Re: [Mesa-dev] [PATCH] ac: update llvm.amdgcn.icmp intrinsic name for LLVM 9+

2019-06-14 Thread Marek Olšák
Reviewed-by: Marek Olšák Marek On Fri, Jun 14, 2019 at 5:57 AM Samuel Pitoiset wrote: > LLVM r363339 changed llvm.amdgcn.icmp.i* to llvm.amdgcn.icmp.i64.i*. > > Signed-off-by: Samuel Pitoiset > --- > src/amd/common/ac_llvm_build.c | 7 --- > 1 file changed, 4 insertio

[Mesa-dev] [PATCH] radeonsi: reduce MAX_GEOMETRY_OUTPUT_VERTICES

2019-06-14 Thread Marek Olšák
From: Nicolai Hähnle This fixes piglit spec@glsl-1.50@gs-max-output. --- src/gallium/drivers/radeonsi/si_get.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/gallium/drivers/radeonsi/si_get.c b/src/gallium/drivers/radeonsi/si_get.c index c1bddca1a66..9496817ac84

[Mesa-dev] [PATCH] amd: update addrlib

2019-06-14 Thread Marek Olšák
From: Marek Olšák --- Please test and fix RADV if needed. Compressed textures may be broken. This change contains the necessary radeonsi fixes for this addrlib. src/amd/addrlib/inc/addrinterface.h | 12 +- src/amd/addrlib/inc/addrtypes.h | 36 +- src/amd/addrlib/src

Re: [Mesa-dev] [PATCH 2/2] ac: make ac_compute_cmask() a static function

2019-06-13 Thread Marek Olšák
Reviewed-by: Marek Olšák Marek On Thu, Jun 13, 2019 at 11:14 AM Samuel Pitoiset wrote: > Signed-off-by: Samuel Pitoiset > --- > src/amd/common/ac_surface.c | 6 +++--- > src/amd/common/ac_surface.h | 4 > 2 files changed, 3 insertions(+), 7 deletions(-) > > diff -

Re: [Mesa-dev] [PATCH] gallium: add z24s8_as_r8g8b8a8 format

2019-06-13 Thread Marek Olšák
I'm OK with this. Reviewed-by: Marek Olšák Marek On Thu, Jun 13, 2019 at 1:39 PM Rob Clark wrote: > From: Rob Clark > > This maps to a special format that recent generations of adreno have, > for blitting z24s8. Conceptually it is similar to doing Z and/or S > blit

Re: [Mesa-dev] [PATCH] include: update GL headers from the registry

2019-06-13 Thread Marek Olšák
Kind ping. Marek On Tue, Jun 11, 2019 at 8:06 PM Marek Olšák wrote: > From: Marek Olšák > > --- > include/GL/glcorearb.h | 261 +++ > include/GL/glext.h | 269 + > include/GLES/gl.h |

Re: [Mesa-dev] [PATCH] ac: add radeon_info::is_amdgpu instead of checking drm_major == 3

2019-06-13 Thread Marek Olšák
It's only a random cleanup. Marek On Thu, Jun 13, 2019 at 2:57 AM Samuel Pitoiset wrote: > Why do you need that? > > On 6/12/19 11:31 PM, Marek Olšák wrote: > > From: Marek Olšák > > > > and clean up > > --- > > src/amd/common/ac_gpu_info.c

Re: [Mesa-dev] [Mesa-stable] [PATCH 3/3] amd: Apply elf relocations and allow code with relocations

2019-06-12 Thread Marek Olšák
FYI, I just pushed the new linker. Marek On Mon, Jun 3, 2019 at 10:39 PM Jan Vesely wrote: > Fixes piglits: > call.cl > calls-larget-struct.cl > calls-struct.cl > calls-workitem-id.cl > realign-stack.cl > tail-calls.cl > > Cc:

[Mesa-dev] [PATCH 1/7] ac/registers: remove deprecated/inapplicable definitions

2019-06-12 Thread Marek Olšák
From: Marek Olšák --- src/amd/registers/amdgfxregs.json | 180 -- 1 file changed, 180 deletions(-) diff --git a/src/amd/registers/amdgfxregs.json b/src/amd/registers/amdgfxregs.json index 371efef7201..23643c3dc7b 100644 --- a/src/amd/registers/amdgfxregs.json +++ b

[Mesa-dev] [PATCH 6/7] ac/rtld: report better error messages for LDS overallocation

2019-06-12 Thread Marek Olšák
From: Nicolai Hähnle --- src/amd/common/ac_rtld.c | 13 +++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/src/amd/common/ac_rtld.c b/src/amd/common/ac_rtld.c index 18f198f8af2..57d6b0151b4 100644 --- a/src/amd/common/ac_rtld.c +++ b/src/amd/common/ac_rtld.c @@ -283,21

[Mesa-dev] [PATCH 2/7] ac/registers: use better names for disambiguated definitions

2019-06-12 Thread Marek Olšák
From: Marek Olšák --- src/amd/registers/makeregheader.py | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/amd/registers/makeregheader.py b/src/amd/registers/makeregheader.py index 859a59b9f3e..1d73cb47bdf 100644 --- a/src/amd/registers/makeregheader.py +++ b/src

[Mesa-dev] [PATCH 7/7] radeonsi: don't use the low-optimizing compiler on LLVM 9

2019-06-12 Thread Marek Olšák
From: Marek Olšák The compilation is faster on LLVM 9. --- src/gallium/drivers/radeonsi/si_pipe.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/gallium/drivers/radeonsi/si_pipe.c b/src/gallium/drivers/radeonsi/si_pipe.c index 8527999645b..d2fd058f2cd 100644

[Mesa-dev] [PATCH 3/7] amd/rtld: fix sorting of LDS symbols by alignment

2019-06-12 Thread Marek Olšák
From: Nicolai Hähnle --- src/amd/common/ac_rtld.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/amd/common/ac_rtld.c b/src/amd/common/ac_rtld.c index dc9cc04705b..92020c5f0dd 100644 --- a/src/amd/common/ac_rtld.c +++ b/src/amd/common/ac_rtld.c @@ -123,23 +123,23 @@

[Mesa-dev] [PATCH 5/7] ac/rtld: check correct LDS max size

2019-06-12 Thread Marek Olšák
From: Marek Olšák --- src/amd/common/ac_rtld.c | 8 +++- src/amd/common/ac_rtld.h | 2 ++ src/gallium/drivers/radeonsi/si_shader.c | 3 +++ 3 files changed, 12 insertions(+), 1 deletion(-) diff --git a/src/amd/common/ac_rtld.c b/src/amd/common/ac_rtld.c

[Mesa-dev] [PATCH 4/7] radeonsi: add s_sethalt to shaders for debugging

2019-06-12 Thread Marek Olšák
From: Nicolai Hähnle --- src/amd/common/ac_rtld.c| 9 + src/amd/common/ac_rtld.h| 9 + src/gallium/drivers/radeonsi/si_debug_options.h | 1 + src/gallium/drivers/radeonsi/si_shader.c| 3 +++ 4 files changed, 22

Re: [Mesa-dev] [PATCH 04/10] radeonsi: use ac_shader_config

2019-06-12 Thread Marek Olšák
On Wed, May 8, 2019 at 1:52 AM Marek Olšák wrote: > On Fri, May 3, 2019 at 7:19 AM Nicolai Hähnle wrote: > >> From: Nicolai Hähnle >> >> --- >> src/amd/common/ac_binary.c| 2 + >> src/gallium/drivers/radeonsi/si_compute.c | 14

<    1   2   3   4   5   6   7   8   9   10   >