On Mon, Oct 29, 2018 at 12:43 PM Michel Dänzer wrote:
> On 2018-10-28 11:27 a.m., Gustaw Smolarczyk wrote:
> > pon., 17 wrz 2018 o 18:24 Michel Dänzer napisał(a):
> >>
> >> On 2018-09-15 3:04 a.m., Marek Olšák wrote:
> >>> On Fri, Sep 14,
For the series:
Reviewed-by: Marek Olšák
Marek
On Mon, Oct 29, 2018 at 4:52 PM Dylan Baker wrote:
> Quoting Brian Paul (2018-10-29 12:24:13)
> > On 10/29/2018 12:57 PM, Dylan Baker wrote:
> > > CC: v...@freedesktop.org
> > > CC: Roland Scheidegger
>
t;
> Am 08.09.2018 00:06, schrieb Marek Olšák:
> > Hi Dieter,
> >
> > Here:
> > https://cgit.freedesktop.org/~mareko/mesa/log/?h=ext_gpu_shader4
> >
> > Marek
> >
> > On Tue, Sep 4, 2018 at 8:43 PM, Dieter Nützel
> > wrote:
> >>
On Tue, Oct 23, 2018 at 1:30 PM Gert Wollny wrote:
> From: Gert Wollny
>
> With this patch the extension EXT_sRGB_write_control is enabled for
> gallium drivers that support sRGB formats as render targets.
>
> Tested (and pass) on r600 (evergreen) and softpipe:
>
>
Pushed, thanks!
Marek
On Sat, Oct 27, 2018 at 3:46 AM Andre Heider wrote:
> amdgpu doesn't use the INPUT but the AVERAGE subfeature:
>
> $ sensors -u
> amdgpu-pci-0100
> Adapter: PCI adapter
> power1:
> power1_average: 17.233
> power1_cap: 180.000
>
> Signed-off-by: Andre Heider
> ---
>
Reviewed-by: Marek Olšák
Marek
On Mon, Oct 29, 2018 at 5:27 AM Timothy Arceri
wrote:
> Fixes: edded1237607 ("mesa: rework ParameterList to allow packing")
> ---
> src/mesa/state_tracker/st_atom_constbuf.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
Reviewed-by: Marek Olšák
Marek
On Sun, Oct 21, 2018 at 12:06 PM Rhys Perry
wrote:
> TGSI has no I64MAD/U64MAD opcode.
>
> Fixes: 278580729a5 ('st/glsl_to_tgsi: add support for 64-bit integers')
> Signed-off-by: Rhys Perry
> ---
> src/mesa/state_tracker/st_glsl_to_tgsi.cpp
Reviewed-by: Marek Olšák
Marek
On Sat, Oct 20, 2018 at 12:03 AM Timothy Arceri
wrote:
> ffs() just returns the bit that is set, we need to know what
> stage that bit represents so use u_bit_scan() instead.
>
> Fixes: 2ca5d9548fc4 ("st/glsl_to_nir: gather next_sta
From: Marek Olšák
and add has_dcc_constant_encode.
---
src/gallium/drivers/radeonsi/si_clear.c | 10 --
src/gallium/drivers/radeonsi/si_pipe.c | 1 +
src/gallium/drivers/radeonsi/si_pipe.h | 1 +
src/gallium/drivers/radeonsi/si_state.c | 2 +-
4 files changed, 11 insertions(+), 3
From: Marek Olšák
---
src/gallium/drivers/radeonsi/si_clear.c | 26 -
1 file changed, 21 insertions(+), 5 deletions(-)
diff --git a/src/gallium/drivers/radeonsi/si_clear.c
b/src/gallium/drivers/radeonsi/si_clear.c
index 8aa3355afc8..2900c31fd21 100644
--- a/src/gallium
On Sat, Oct 27, 2018 at 4:35 AM Gustaw Smolarczyk
wrote:
> sob., 27 paź 2018 o 04:28 Marek Olšák napisał(a):
> >
> > From: Marek Olšák
> >
> > ---
> > src/amd/addrlib/amdgpu_asic_addr.h | 2 ++
> > src/amd/addrlib/gfx9/gfx9addrlib.cp
From: Marek Olšák
v2: fix enabling primitive binning
---
src/amd/addrlib/amdgpu_asic_addr.h | 2 ++
src/amd/addrlib/gfx9/gfx9addrlib.cpp| 2 +-
src/amd/common/ac_gpu_info.c| 6 ++
src/amd/common/ac_llvm_util.c | 2 ++
src
gt; >0x7fbc480757d0: f64 = fmul nsz 0x7fbc4806f0e0, 0x7fbc4806f420
> > 0x7fbc4806f0e0: f64 = bitcast 0x7fbc4806f078
> >
> > On 30/8/18 6:13 am, Marek Olšák wrote:
> > > From: Marek Olšák
> > >
> > > Cc: 18.1 18.2
> > > ---
> >
The values can't be set per CB.
Marek
On Mon, Oct 29, 2018 at 7:04 AM Samuel Pitoiset
wrote:
> Are the values similar when they are set per CB instead of globally?
>
> On 10/27/18 4:28 AM, Marek Olšák wrote:
> > From: Marek Olšák
> >
> > ---
> > src/gallium
From: Marek Olšák
---
src/amd/addrlib/amdgpu_asic_addr.h | 2 ++
src/amd/addrlib/gfx9/gfx9addrlib.cpp| 2 +-
src/amd/common/ac_gpu_info.c| 6 ++
src/amd/common/ac_llvm_util.c | 1 +
src/amd/common/ac_surface.c
From: Marek Olšák
---
src/gallium/drivers/radeonsi/si_pipe.h | 1 +
src/gallium/drivers/radeonsi/si_state.c | 14 +-
2 files changed, 14 insertions(+), 1 deletion(-)
diff --git a/src/gallium/drivers/radeonsi/si_pipe.h
b/src/gallium/drivers/radeonsi/si_pipe.h
index dc95afb7421
From: Marek Olšák
---
src/gallium/drivers/radeonsi/si_clear.c | 18 +++---
1 file changed, 7 insertions(+), 11 deletions(-)
diff --git a/src/gallium/drivers/radeonsi/si_clear.c
b/src/gallium/drivers/radeonsi/si_clear.c
index 520e5b94f4a..8aa3355afc8 100644
--- a/src/gallium
From: Marek Olšák
Only radeonsi uses them, so adjust them to match its needs.
---
src/gallium/auxiliary/renderonly/renderonly.c | 2 +-
src/gallium/auxiliary/vl/vl_winsys_dri.c | 2 +-
src/gallium/auxiliary/vl/vl_winsys_dri3.c | 4 ++--
src/gallium/drivers/etnaviv
On Wed, Oct 24, 2018 at 12:34 PM Erik Faye-Lund <
erik.faye-l...@collabora.com> wrote:
> On Thu, 2018-10-18 at 15:42 -0400, Marek Olšák wrote:
> > I think you need something like this:
> >
>
> https://cgit.freedesktop.org/~mareko/mesa/c
; /**< PIPE_IMAGE_ACCESS_x */
>
Can you use uint16_t for both access masks? Other than that:
Reviewed-by: Marek Olšák
Marek
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
For the series:
Reviewed-by: Marek Olšák
Marek
On Sun, Oct 14, 2018 at 8:48 PM Dave Airlie wrote:
> From: Dave Airlie
>
> The drawpixel lowering references undeclared samplers, but also
> missing a texture handle.
> ---
> src/compiler/nir/nir_lower
Reviewed-by: Marek Olšák
Marek
On Thu, Oct 18, 2018 at 10:13 AM Connor Abbott wrote:
> The comment was wrong, since the loop above casts to a type with the
> correct bitsize already.
>
> Fixes: 7e7ee82698247d8f93fe37775b99f4838b0247dd ("ac: add support for
> 16bit buffer
alue,
> +unsigned src_channels,
> +unsigned dst_channels)
> {
> LLVMTypeRef elemtype;
> - LLVMValueRef chan[4];
> + LLVMValueRef chan[dst_channels];
>
That doesn't look like a valid syntax.
Pushed, thanks!
Marek
On Fri, Oct 19, 2018 at 3:56 PM Jiang, Sonny wrote:
> Signed-off-by: Sonny Jiang
> Tested-by: Michel Dänzer
> ---
> src/gallium/drivers/radeonsi/si_pipe.c | 6 --
> src/gallium/drivers/radeonsi/si_state.c | 5 +++--
> 2 files changed, 7 insertions(+), 4
It looks like there is a deadlock in LLVM when 2 shaders are compiled at
the same time. I don't know why it doesn't happen with OpenGL.
Marek
On Thu, Oct 18, 2018 at 3:32 AM Michel Dänzer wrote:
> On 2018-10-17 6:43 p.m., Marek Olšák wrote:
> > Can you test the attached patch?
>
&g
Hi Sonny,
Can you send a version that only does >= CIK && drm_major == 3? It's
equivalent to your version but simpler.
Marek
On Thu, Oct 18, 2018 at 12:40 PM Jiang, Sonny wrote:
> Signed-off-by: Sonny Jiang
> ---
> src/gallium/drivers/radeonsi/si_pipe.c | 7 +--
>
This is OK.
Reviewed-by: Marek Olšák
Marek
On Thu, Oct 18, 2018 at 3:43 PM Jan Vesely wrote:
> Fixes assertion failure/crash when running luxmark/luxball on clover.
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=108272
> CC: mesa-sta...@lists.freedesktop.org
> Signed
I think you need something like this:
https://cgit.freedesktop.org/~mareko/mesa/commit/?h=amd-extension-pack=ad774f9db1d735811a8d830ad90a2f8208aa0a7b
I also have:
rgtc:
https://cgit.freedesktop.org/~mareko/mesa/commit/?h=amd-extension-pack=c9c0ffc2d40f0119fb31bf0515f321cd877090dd
bptc:
Can you test the attached patch?
Marek
On Wed, Oct 17, 2018 at 9:31 AM Michel Dänzer wrote:
> On 2018-10-07 9:05 a.m., Marek Olšák wrote:
> > From: Marek Olšák
> >
> > Fast color clears should be much faster. Also, fast color clears on
> > evicted buffers sh
From: Marek Olšák
Cc: 18.1 18.2
---
src/gallium/drivers/radeonsi/si_state_draw.c | 10 --
1 file changed, 8 insertions(+), 2 deletions(-)
diff --git a/src/gallium/drivers/radeonsi/si_state_draw.c
b/src/gallium/drivers/radeonsi/si_state_draw.c
index 83eb646b791..612ca910cb9 100644
From: Marek Olšák
This fixes dEQP-GLES2.functional.rasterization.limits.points.
Broken by: ea039f789d9b54e1bd1d644b6a29863ca3500314
---
src/gallium/drivers/radeonsi/si_get.c | 5 +++--
src/gallium/drivers/radeonsi/si_pipe.h | 1 +
src/gallium/drivers/radeonsi/si_state.c | 2 +-
3 files
On Thu, Oct 11, 2018 at 4:43 AM Samuel Pitoiset
wrote:
>
> WD_SWITCH_ON_EOP seems to be the only workaround that fixes
> the GPU hangs with Yakuza and The Evil Within on Vega. I don't
> like as it might decrease geometry performance as pointed out
> by Marek, but I don't know how to implement a
This will decrease geometry performance 2x.
The correct workaround is to set PARTIAL_VS_WAVE_ON for all strip
primitive types with restart indices.
Marek
On Tue, Oct 9, 2018 at 8:15 AM Samuel Pitoiset
wrote:
>
> Otherwise, Yakuza hangs the GPU with DXVK. We don't know if
> linetrip and
I didn't see any issue when I was testing Tahiti and Hawaii on amdgpu.
radeon is too unstable for a 16-thread piglit, so I never use it.
You can try to set reg_saved = 0 in si_begin_new_gfx_cs. That should
prevent issues with CLEAR_STATE.
Marek
On Mon, Oct 8, 2018 at 12:30 PM Michel Dänzer
From: Marek Olšák
---
src/gallium/drivers/radeonsi/si_state.c | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/src/gallium/drivers/radeonsi/si_state.c
b/src/gallium/drivers/radeonsi/si_state.c
index af1b9f0acc8..d3c63406dd4 100644
--- a/src/gallium/drivers/radeonsi
From: Marek Olšák
We should get fewer context rolls with the SET_CONTEXT_REG optimization,
but it would have been for nothing if the scissor state rolled the context
anyway. Don't emit the scissor state if there is no context roll.
---
src/gallium/drivers/radeonsi/si_pipe.h| 1 +
src
From: Marek Olšák
---
src/gallium/drivers/radeonsi/si_buffer.c | 15 ---
1 file changed, 4 insertions(+), 11 deletions(-)
diff --git a/src/gallium/drivers/radeonsi/si_buffer.c
b/src/gallium/drivers/radeonsi/si_buffer.c
index a03a94453a4..c7260e06ccf 100644
--- a/src/gallium
From: Marek Olšák
Fast color clears should be much faster. Also, fast color clears on
evicted buffers should be 200x faster on GFX8 and older.
---
src/gallium/drivers/radeonsi/Makefile.sources | 1 +
src/gallium/drivers/radeonsi/meson.build | 1 +
src/gallium/drivers/radeonsi
We could certainly increase the width and height to 32 bits for
pipe_blit_info, not pipe_box.
Marek
On Sat, Oct 6, 2018 at 4:01 PM Ilia Mirkin wrote:
>
> There's a WebGL test here
>
> https://www.khronos.org/registry/webgl/sdk/tests/conformance2/rendering/blitframebuffer-size-overflow.html
>
>
With my comments addressed, patches 2 - 6 are:
Reviewed-by: Marek Olšák
Since I will need to compute the division terms during draw calls, I
may need to switch the math to uint32_t for my case (e.g. via a C++
template).
Marek
On Sat, Oct 6, 2018 at 12:11 AM Jason Ekstrand wrote:
>> W
On Sat, Oct 6, 2018 at 12:11 AM Jason Ekstrand wrote:
>
> While I generally trust rediculousfish to have done his homework, we've
> made some adjustments to suite the needs of mesa and it'd be good to
> test those. Also, there's no better place than unit tests to clearly
> document the different
On Sat, Oct 6, 2018 at 12:11 AM Jason Ekstrand wrote:
>
> From: Marek Olšák
>
> ---
> src/util/fast_idiv_by_const.c | 21 +
> src/util/fast_idiv_by_const.h | 5 +++--
> 2 files changed, 24 insertions(+), 2 deletions(-)
>
> diff --git a/src/util
Thanks. I pushed the series.
Please see also this commit:
https://cgit.freedesktop.org/mesa/mesa/commit/?id=86f004bdfcc1c14ace99f5fccf540c0d813d2254
I added it because the logic was broken for 64-bit reg_saved.
Marek
On Wed, Oct 3, 2018 at 11:55 AM Sonny Jiang wrote:
>
> Signed-off-by: Sonny
Reviewed-by: Marek Olšák
Marek
On Fri, Oct 5, 2018 at 6:23 AM Michel Dänzer wrote:
>
> From: Michel Dänzer
>
> Signed-off-by: Michel Dänzer
> ---
> src/gbm/backends/dri/gbm_dri.c | 4
> 1 file changed, 4 insertions(+)
>
> diff --git a/src/gbm/backends/dri/g
Reviewed-by: Marek Olšák
Marek
On Fri, Oct 5, 2018 at 6:22 AM Michel Dänzer wrote:
>
> From: Michel Dänzer
>
> Signed-off-by: Michel Dänzer
> ---
> src/gallium/state_trackers/dri/dri2.c | 13 +
> 1 file changed, 13 insertions(+)
>
> diff --git a/src
Reviewed-by: Marek Olšák
Marek
On Thu, Oct 4, 2018 at 8:55 PM Dave Airlie wrote:
>
> From: Dave Airlie
>
> Found by coverity
> ---
> src/mesa/state_tracker/st_glsl_to_tgsi.cpp | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/src/mesa/state_tracker/st_gls
On Thu, Oct 4, 2018 at 3:25 AM Samuel Pitoiset
wrote:
>
> Did you benchmark copies and clears with GDS?
No, I didn't.
Marek
Marek
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
On Thu, Oct 4, 2018 at 3:25 AM Samuel Pitoiset
wrote:
>
>
>
> On 10/3/18 12:35 AM, Marek Olšák wrote:
> > From: Marek Olšák
> >
> > ---
> > src/amd/common/sid.h | 5 +
> > src/gallium/drivers/radeonsi/si_fence.c
On Wed, Oct 3, 2018 at 4:16 AM Eero Tamminen wrote:
>
> Hi,
>
> On 10/3/18 2:00 AM, Marek Olšák wrote:
> > On Tue, Oct 2, 2018 at 6:36 PM Rob Clark wrote:
> >> On Tue, Oct 2, 2018 at 6:30 PM Marek Olšák wrote:
> >>> From: Marek Olšák
> [...]
> >
I could add a flag to util queue not to do this. Then your driver can use
the flag.
Marek
On Tue, Oct 2, 2018, 7:00 PM Marek Olšák wrote:
> On Tue, Oct 2, 2018 at 6:36 PM Rob Clark wrote:
> >
> > On Tue, Oct 2, 2018 at 6:30 PM Marek Olšák wrote:
> > >
On Tue, Oct 2, 2018 at 6:36 PM Rob Clark wrote:
>
> On Tue, Oct 2, 2018 at 6:30 PM Marek Olšák wrote:
> >
> > From: Marek Olšák
> >
> > ---
> > src/util/u_queue.c | 12
> > 1 file changed, 12 insertions(+)
> >
> > diff --g
From: Marek Olšák
This will be more useful when we change the quant mode to increase subpixel
precision and decrease the viewport range (which might not be possible
if the viewport is not centered in the viewport range).
---
src/gallium/drivers/radeonsi/si_gfx_cs.c | 1 +
src/gallium
From: Marek Olšák
---
src/gallium/drivers/radeonsi/si_get.c | 4 +-
src/gallium/drivers/radeonsi/si_pipe.h| 8 +++
.../drivers/radeonsi/si_state_viewport.c | 50 ---
3 files changed, 53 insertions(+), 9 deletions(-)
diff --git a/src/gallium/drivers
From: Marek Olšák
We'll modify the quant mode there, which also affects the guarband
computation.
---
src/gallium/drivers/radeonsi/si_gfx_cs.c | 1 +
src/gallium/drivers/radeonsi/si_state.c | 8 +++-
src/gallium/drivers/radeonsi/si_state.h | 2 ++
src/gallium
From: Marek Olšák
---
src/gallium/drivers/radeonsi/si_pipe.c | 7 +++
src/gallium/drivers/radeonsi/si_pipe.h | 13 -
src/gallium/drivers/radeonsi/si_state.c | 19 +--
src/gallium/drivers/radeonsi/si_state_msaa.c | 10 +-
4 files changed
From: Marek Olšák
---
src/gallium/drivers/radeonsi/si_gfx_cs.c | 1 +
src/gallium/drivers/radeonsi/si_state.c | 15 +++
src/gallium/drivers/radeonsi/si_state.h | 1 +
3 files changed, 13 insertions(+), 4 deletions(-)
diff --git a/src/gallium/drivers/radeonsi/si_gfx_cs.c
b/src
From: Marek Olšák
---
src/gallium/drivers/radeonsi/si_cp_dma.c | 104 ++-
src/gallium/drivers/radeonsi/si_pipe.c | 4 +
src/gallium/drivers/radeonsi/si_pipe.h | 2 +
3 files changed, 89 insertions(+), 21 deletions(-)
diff --git a/src/gallium/drivers/radeonsi
From: Marek Olšák
Apps may rely on them.
---
src/gallium/drivers/radeonsi/si_state_msaa.c | 43
1 file changed, 26 insertions(+), 17 deletions(-)
diff --git a/src/gallium/drivers/radeonsi/si_state_msaa.c
b/src/gallium/drivers/radeonsi/si_state_msaa.c
index 10232a5e18b
From: Marek Olšák
---
src/amd/common/ac_gpu_info.c| 13 +++--
src/amd/common/ac_gpu_info.h| 3 ++-
src/amd/vulkan/si_cmd_buffer.c | 2 +-
src/gallium/drivers/radeonsi/si_pipe.c | 9 +
src/gallium/drivers/radeonsi/si_pipe.h | 3 +++
src
From: Marek Olšák
and write_event_eop -> release_mem
---
src/amd/common/sid.h | 1 +
src/gallium/drivers/radeonsi/si_fence.c | 32 +--
src/gallium/drivers/radeonsi/si_perfcounter.c | 14
src/gallium/drivers/radeonsi/si_pipe.h|
From: Marek Olšák
---
src/amd/common/ac_llvm_build.c | 10 +-
src/amd/common/ac_llvm_build.h | 10 ++
src/amd/common/ac_nir_to_llvm.c | 2 +-
src/amd/vulkan/radv_nir_to_llvm.c| 2 +-
src/gallium/drivers/radeonsi/si_shader.c | 6 +++---
5
From: Marek Olšák
---
src/amd/common/ac_llvm_build.c| 19 +--
src/amd/common/ac_llvm_build.h| 1 +
src/amd/common/ac_nir_to_llvm.c | 2 +-
.../drivers/radeonsi/si_shader_tgsi_mem.c | 4 +---
4 files changed, 20 insertions
From: Marek Olšák
---
src/amd/common/sid.h | 11 +--
src/amd/vulkan/radv_cmd_buffer.c | 6 +++---
src/amd/vulkan/radv_query.c | 8
src/gallium/drivers/radeonsi/si_compute.c | 2 +-
src/gallium/drivers/radeonsi
From: Marek Olšák
---
src/amd/common/ac_llvm_build.c | 11 ---
1 file changed, 4 insertions(+), 7 deletions(-)
diff --git a/src/amd/common/ac_llvm_build.c b/src/amd/common/ac_llvm_build.c
index 4cbf599d946..fc6dc396d38 100644
--- a/src/amd/common/ac_llvm_build.c
+++ b/src/amd/common
From: Marek Olšák
harmless
---
src/gallium/drivers/radeonsi/si_state_draw.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/gallium/drivers/radeonsi/si_state_draw.c
b/src/gallium/drivers/radeonsi/si_state_draw.c
index 3d56d8e9ab4..81eb34d75e2 100644
--- a/src/gallium
From: Marek Olšák
---
src/amd/common/sid.h | 5 +
src/gallium/drivers/radeonsi/si_fence.c | 19 ++-
src/gallium/drivers/radeonsi/si_perfcounter.c | 2 ++
src/gallium/drivers/radeonsi/si_pipe.h| 2 +-
src/gallium/drivers/radeonsi
Hi,
Interesting bits:
- CP DMA support for GDS (unused but there is a test)
- switch back to DX sample positions
- center the viewport in the scanline area for maximizing the guardband
- optimal PA_SU_PRIM_FILTER_CNTL
- higher subpixel precision for 4K and lower resolutions
(for more precise
From: Marek Olšák
---
src/util/u_queue.c | 12
1 file changed, 12 insertions(+)
diff --git a/src/util/u_queue.c b/src/util/u_queue.c
index 22d2cdd0fa2..9dd1a69ed7a 100644
--- a/src/util/u_queue.c
+++ b/src/util/u_queue.c
@@ -232,20 +232,32 @@ struct thread_input {
};
static
On Sat, Sep 8, 2018 at 12:33 AM Timothy Arceri wrote:
>
> ---
> .../glapi/gen/EXT_direct_state_access.xml | 10 +
> src/mesa/main/bufferobj.c | 45 +--
> src/mesa/main/bufferobj.h | 3 ++
> src/mesa/main/tests/dispatch_sanity.cpp
features.txt can be updated.
Marek
On Sat, Sep 8, 2018 at 12:34 AM Timothy Arceri wrote:
>
> This is available in ARB_buffer_storage when
> EXT_direct_state_access is present.
> ---
> src/mapi/glapi/gen/gl_API.xml | 7 +++
> src/mesa/main/bufferobj.c | 15
The patch subject should be changed, because it adds only a tiny
subset of the extension.
Marek
On Sat, Sep 8, 2018 at 12:32 AM Timothy Arceri wrote:
>
> From: Chris Forbes
>
> Signed-off-by: Chris Forbes
> ---
> .../glapi/gen/EXT_direct_state_access.xml | 101 ++
>
features.txt should be updated.
Marek
On Sat, Sep 8, 2018 at 12:31 AM Timothy Arceri wrote:
>
> From: Chris Forbes
>
> Allows the legacy matrix stacks to be manipulated without disturbing the
> matrix mode selector.
>
> Signed-off-by: Chris Forbes
> ---
> src/mesa/main/matrix.c | 370
This is probably OK, though the TODO list in features.txt should also
be updated when a new subset is implemented.
Marek
On Sat, Sep 8, 2018 at 12:32 AM Timothy Arceri wrote:
>
> This extension is huge and this gives us a TODO list of functions
> to implement.
> ---
>
Pushed, thanks!
Marek
On Sun, Sep 23, 2018 at 6:45 PM Józef Kucia wrote:
>
> Fixes GPU hangs.
>
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=107857
> Signed-off-by: Józef Kucia
> ---
> src/gallium/drivers/radeonsi/si_shader.c | 9 ++---
> 1 file changed, 6 insertions(+), 3
For the series:
Reviewed-by: Marek Olšák
Marek
On Tue, Sep 18, 2018 at 10:14 PM Timothy Arceri wrote:
>
> ---
> src/gallium/drivers/r600/r600_pipe_common.c | 14 +++---
> 1 file changed, 7 insertions(+), 7 deletions(-)
>
> diff --git a/src/gallium/drivers/r600/r600_
st rework it according to you, that's fine. Changing the types
is tricky. Template code in a C header included several times would work.
C++ templates would be ideal.
What's your timeframe for this? Mine is certainly more than a month.
Marek
> --Jason
>
>
> On Sun, Sep 23, 2018 at 11:58 AM
The patch I attached was written for 18.2. It won't apply on master.
It looks the same, but the change is in a different function.
Marek
On Mon, Oct 1, 2018 at 6:25 PM Juan A. Suarez Romero
wrote:
>
> On Mon, 2018-10-01 at 14:29 -0400, Marek Olšák wrote:
> > The attached patch
The attached patch is for 18.2.
Thanks,
Marek
On Mon, Oct 1, 2018 at 4:14 AM Juan A. Suarez Romero
wrote:
>
> On Mon, 2018-09-24 at 20:21 -0400, Marek Olšák wrote:
> > Looks good to me.
> >
> > Marek
>
> This patch was nominated to stable, but I can't apply i
What improvement do you get from this?
Thanks,
Marek
On Fri, Sep 28, 2018 at 10:27 AM Samuel Pitoiset
wrote:
>
> Like we disable DCC/CMASK for small color surfaces as well.
> Serious Sam 2017 creates a 1x1 depth surface and I think
> it should be faster to decompress compared to the benefit
> of
Since LLVM 7.0 has already been released:
Reviewed-by: Marek Olšák
Marek
On Tue, Sep 25, 2018 at 12:46 AM Timothy Arceri wrote:
>
> On 25/9/18 10:35 am, Marek Olšák wrote:
> > Do you know what's broken in LLVM? Or is it a problem with the ISA?
>
> I haven't actually dug a
On Tue, Sep 25, 2018 at 5:33 AM Jason Ekstrand wrote:
>
> On Mon, Sep 24, 2018 at 7:15 PM Marek Olšák wrote:
>>
>> This patch also handles all types, just differently. If you change the
>> typedefs in the header, you'll get a different type and the code is
>>
For the remaining patches (3-6), it would be better to precompute the
register values in struct si_shader, so that the emit functions are as
cheap as possible.
Marek
On Mon, Sep 24, 2018 at 10:51 PM, Marek Olšák wrote:
> On Tue, Sep 18, 2018 at 4:21 PM, Sonny Jiang wrote:
>> S
On Tue, Sep 18, 2018 at 4:21 PM, Sonny Jiang wrote:
> Signed-off-by: Sonny Jiang
> ---
> src/gallium/drivers/radeonsi/si_gfx_cs.c | 15 ++-
> src/gallium/drivers/radeonsi/si_state.h | 19 ++-
> .../drivers/radeonsi/si_state_shaders.c | 112 --
> 3 files
On Tue, Sep 18, 2018 at 4:21 PM, Sonny Jiang wrote:
> Signed-off-by: Sonny Jiang
> ---
> src/gallium/drivers/radeonsi/si_gfx_cs.c | 1 +
> src/gallium/drivers/radeonsi/si_pm4.c | 3 +++
> src/gallium/drivers/radeonsi/si_pm4.h | 11 ++
>
Reviewed-by: Marek Olšák
Marek
On Thu, Sep 20, 2018 at 4:27 AM, Erik Faye-Lund
wrote:
> In st_renderbuffer_alloc_storage, we avoid allocating storage for
> zero-sized buffers, leading to this pointer being NULL. We already
> take care to avoid dereferencing these pointers for colo
Do you know what's broken in LLVM? Or is it a problem with the ISA?
Marek
On Fri, Sep 21, 2018 at 10:38 PM, Timothy Arceri wrote:
> This ports the fix from 3d41757788ac. Both LLVM 7 & 8 continue
> to have this problem.
>
> It fixes rendering issues in some menu and loading screens of
> Civ VI
: Explain in the code why UGE is used.
>
> Signed-off-by: Axel Davy
> Reviewed-by: Marek Olšák
>
> CC:
> ---
> src/gallium/drivers/radeonsi/si_shader_tgsi_alu.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/src/gallium/drivers/radeonsi/si_
ithm,
because the multiplier always fits into 32 bits. The most operations
you'll ever need are: 2 shifts, 32-bit saturated ADD and UMUL_HI.
Marek
On Mon, Sep 24, 2018 at 7:41 PM, Marek Olšák wrote:
> Did you copy the code from the same author?
>
> Does your version also have an interface for
wo. Perhaps you guys
>> could unify these?
>>
>> On 09/23/2018 09:57 AM, Marek Olšák wrote:
>> > From: Marek Olšák
>> >
>> > Compilers can use this to generate optimal code for integer division
>> > by a constant.
>> >
>> > A
Please add a comment that UGE is used because NaN means no kill.
Thanks. You can also nominate this for stable. Other than those:
Reviewed-by: Marek Olšák
Marek
On Sun, Sep 23, 2018 at 1:00 PM, Axel Davy wrote:
> Fixes: https://bugs.freedesktop.org/show_bug.cgi?id=105333
> Fixes:
Reviewed-by: Marek Olšák
Marek
On Tue, Sep 18, 2018 at 11:26 AM, Michel Dänzer wrote:
> From: Michel Dänzer
>
> As discussed in the review of the patch which added the comment:
>
> Nothing happens when a thread is created, because pthread_atfork doesn't
> affect creatin
On Fri, Sep 21, 2018 at 11:34 AM, Emil Velikov wrote:
> On 21 September 2018 at 00:42, Timothy Arceri wrote:
>> On 20/9/18 11:09 pm, Ian Romanick wrote:
>>>
>>> On 09/19/2018 11:36 PM, Federico Dossena wrote:
As most of you are probably aware of, id2 and id3 games store GL
From: Marek Olšák
---
src/gallium/drivers/radeonsi/si_state_shaders.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/src/gallium/drivers/radeonsi/si_state_shaders.c
b/src/gallium/drivers/radeonsi/si_state_shaders.c
index 157a0e3..0bf783f 100644
--- a/src/gallium/drivers
From: Marek Olšák
so that it's not NULL when loading radeonsi and a GCN GPU is not
present in the system.
---
src/gallium/drivers/radeonsi/si_pipe.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/src/gallium/drivers/radeonsi/si_pipe.c
b/src/gallium/drivers/radeonsi/si_pipe.c
index 0b38feb
From: Marek Olšák
---
src/amd/common/ac_llvm_build.c | 44 ++
src/amd/common/ac_llvm_build.h | 13 +
2 files changed, 57 insertions(+)
diff --git a/src/amd/common/ac_llvm_build.c b/src/amd/common/ac_llvm_build.c
index ab0ba09..793ff81 100644
From: Marek Olšák
We know the divisors when we upload them, so instead we can precompute
and upload division factors derived from each divisor.
This fast division consists of add, mul_hi, and two shifts,
and we have to load 4 dwords intead of 1.
This probably won't affect any apps.
---
src
From: Marek Olšák
Compilers can use this to generate optimal code for integer division
by a constant.
Additionally, an unsigned division by a uniform that is constant but not
known at compile time can still be optimized by passing 2-4 division
factors to the shader as uniforms and executing one
Reviewed-by: Marek Olšák
Marek
On Wed, Sep 19, 2018 at 11:14 PM, Alex Deucher wrote:
> Signed-off-by: Alex Deucher
> Cc: mesa-sta...@lists.freedesktop.org
> ---
> include/pci_ids/radeonsi_pci_ids.h | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/include/pci_i
I'm pretty sure it's correct.
Marek
On Tue, Sep 18, 2018 at 4:09 AM, andrey simiklit
wrote:
> Hi,
>
> Please find my comments below:
>
> Regards,
> Andrii.
>
> On Tue, Sep 18, 2018 at 4:49 AM Marek Olšák wrote:
>>
>> Reviewed-by: Marek Olšák
>>
>
Did you try --libdir /usr/lib/i386-linux-gnu ?
Marek
On Mon, Sep 17, 2018 at 11:02 PM, Brian Paul wrote:
> Hi Dylan,
>
> I have my 32-bit cross-compile working, but "ninja -C builddir install"
> isn't putting the 32-bit libs and drivers in the right place.
>
> I've been playing with the meson
801 - 900 of 12096 matches
Mail list logo
