Hi all,
Today I faced a problem regarding my account @asimiklit on
gitlab.freedesktop.org, I can't sign in. It looks like user @asimiklit was
removed as well as my MRs. Something went wrong and I would like to sort
out the reason. Does somebody know something about this?
Additionally: My
Hi,
I would like to request merge access for piglit gitlab. I have contributed
a number of commits for mesa/piglit. It would help in my work because
sometimes even already reviewed MRs remain not pushed for months.
Regards,
Andrii (asimiklit).
___
On Tue, Jan 8, 2019 at 11:01 PM Chris Wilson
wrote:
> Quoting Kenneth Graunke (2019-01-08 20:17:01)
> > On Tuesday, January 8, 2019 3:11:37 AM PST Chris Wilson wrote:
> > > Quoting Lionel Landwerlin (2019-01-08 11:03:26)
> > > > Hi Andrii,
> > > >
> > > > Although I think what these patches do
ck wrote:
> > > On Thu, Jul 19, 2018 at 12:08 PM andrey simiklit
> > >
> > > Jason, can we reconsider Andrii's patch? It still applies cleanly
> > > (https://patchwork.freedesktop.org/patch/237490/)
> >
> > Looking at the patch and the "Simple repro
>
> Hi all,
>
> On Thu, Jul 19, 2018 at 12:08 PM andrey simiklit
> wrote:
> > > Ugh... not so good. According to Oliver on the bug, this just make
> the assert go away and doesn't actually fix anything. Likely this is
> needed but not sufficient.
> >
> &
Hello,
Could somebody take a look at this old patch?
Thanks,
Andrii.
On Tue, Nov 13, 2018 at 6:41 PM Eric Engestrom
wrote:
> On Tuesday, 2018-11-13 14:19:31 +0200, asimiklit.w...@gmail.com wrote:
> > From: Andrii Simiklit
> >
> > 1. main/texcompress_etc.c:1314:12:
> > warning: ‘*((void
Thanks a lot)
Andrii.
On Fri, Feb 8, 2019 at 9:39 AM Kenneth Graunke
wrote:
> On Thursday, February 7, 2019 3:35:01 AM PST andrey simiklit wrote:
> > ping. the piglit test was pushed)
> >
> > Thanks,
> > Andrii.
>
> I land
ping. the piglit test was pushed)
Thanks,
Andrii.
On Tue, Jan 22, 2019 at 1:31 PM andrey simiklit
wrote:
> Hello,
>
> Could somebody help me with a push of the following patch?
> https://patchwork.freedesktop.org/patch/254397
>
> This fix is needed to fix these fails:
>
the following test:
tex-upside-down-miptree
from Intel CI "[expected-crashes]" sections.
Thanks,
Andrii.
On Mon, Jan 14, 2019 at 3:05 PM andrey simiklit
wrote:
> Hello,
>
> The test for this issue is pushed to the piglit.
> It would be great to push the mesa fix too if it
Hello,
The test for this issue is pushed to the piglit.
It would be great to push the mesa fix too if it is still an acceptable for
all :)
Thanks,
Andrii.
On Sat, Oct 20, 2018 at 12:29 PM andrey simiklit
wrote:
> Hello,
>
> On Fri, Oct 19, 2018 at 15:14 Kenneth Graunke
Hello,
Looks like the same fix could be done in the following functions:
radv_GetPhysicalDeviceQueueFamilyProperties
radv_GetPhysicalDeviceQueueFamilyProperties2
just for case if you want to fix all these issues:)
Regards,
Andrii.
On Mon, Jan 7, 2019 at 6:35 PM Samuel Pitoiset
wrote:
> This
On Tue, Jan 8, 2019 at 6:16 PM Chris Wilson
wrote:
> Quoting andrey simiklit (2019-01-08 16:00:45)
> > On Tue, Jan 8, 2019 at 1:11 PM Chris Wilson
> wrote:
> >
> > Quoting Lionel Landwerlin (2019-01-08 11:03:26)
> > > Hi Andrii,
> > >
> &
On Tue, Jan 8, 2019 at 1:11 PM Chris Wilson
wrote:
> Quoting Lionel Landwerlin (2019-01-08 11:03:26)
> > Hi Andrii,
> >
> > Although I think what these patches do makes sense, I think it's missing
> > the bigger picture.
> > There is a lot more state that gets lost if we have to revert all of
Hi all,
Could somebody take a look at this patch?
Regards,
Andrii.
On Mon, Nov 19, 2018 at 11:19 PM wrote:
> From: Andrii Simiklit
>
> This patch is needed to avoid missing 3DSTATE_URB_* commands in a batch
> after
> rollback operation.
>
> To be able to test easily this issue
> the
Hi all,
Could somebody take a look at this patch?
Regards,
Andrii.
On Mon, Nov 19, 2018 at 11:19 PM wrote:
> From: Andrii Simiklit
>
> This patch is needed to avoid incorrect value of StreamOffset flag
> in 3DSTATE_SO_BUFFER command after rollback operation.
>
> To be able to test easily
Hello,
I'm sorry for disturbing, could I ask you to push this patch if it
possible? )))
Regards,
Andrii.
On Fri, Nov 30, 2018 at 6:19 PM andrey simiklit
wrote:
> On Fri, Nov 30, 2018 at 5:49 PM Eric Engestrom
> wrote:
>
>> On Friday, 2018-11-30 15:47:11 +, Lionel L
On Fri, Nov 30, 2018 at 5:49 PM Eric Engestrom
wrote:
> On Friday, 2018-11-30 15:47:11 +, Lionel Landwerlin wrote:
> > On 14/11/2018 16:30, asimiklit.w...@gmail.com wrote:
> > > From: Andrii Simiklit
> > >
> > > 1. tools/i965_disasm.c:58:4: warning:
> > > ignoring return value of
Hello,
Could somebody take a look at this patch?
Thanks a lot,
Andrii.
On Tue, Nov 6, 2018 at 12:33 PM andrey simiklit
wrote:
> Hi all,
>
> Have somebody some suggestions for this test?
> This patch is needed to test an issue (assertion in mesa) which will be
> fixed by
Hello,
Could you please take a look on this v4 if it is possible?
Thanks,
Andrii.
On Wed, Nov 14, 2018 at 6:30 PM wrote:
> From: Andrii Simiklit
>
> 1. tools/i965_disasm.c:58:4: warning:
> ignoring return value of ‘fread’,
> declared with attribute warn_unused_result
>
Hello,
I tried to compile latest mesa master this morning but faced with a
compilation error:
intel_fbo.c: In function ‘intel_validate_framebuffer’:
intel_fbo.c:696:25: error: ‘GL_FRAMEBUFFER_INCOMPLETE_DIMENSIONS’
undeclared (first use in this function); did you mean
On Tue, Nov 13, 2018 at 6:35 PM Eric Engestrom
wrote:
> On Tuesday, 2018-11-13 14:19:30 +0200, asimiklit.w...@gmail.com wrote:
> > From: Andrii Simiklit
> >
> > 1. brw_pipe_control.c:311:34: warning:
> > unused variable ‘devinfo’
> > 2. brw_program_binary.c:209:19: warning:
> > unused
Hello,
Thanks a lot for review.
Regards,
Andrii.
On Sat, Nov 10, 2018 at 5:38 AM Timothy Arceri
wrote:
> Nice! Series is:
>
> Reviewed-by: Timothy Arceri
>
> On 10/10/18 9:07 am, Ian Romanick wrote:
> > From: Ian Romanick
> >
> > Section 3.7 (Identifiers) of the GLSL spec says:
> >
> >
On Fri, Nov 9, 2018 at 3:19 PM Eric Engestrom
wrote:
> On Tuesday, 2018-09-11 15:42:06 +0300, asimiklit.w...@gmail.com wrote:
> > From: Andrii Simiklit
> >
> > 1. brw_blorp.c:1502:4: warning:
> > ‘num_layers’ may be used uninitialized in this function
> > 2. brw_blorp.c:1502:4: warning:
> >
On Fri, Nov 9, 2018 at 2:45 PM Eric Engestrom
wrote:
> On Tuesday, 2018-09-11 15:42:04 +0300, asimiklit.w...@gmail.com wrote:
> > From: Andrii Simiklit
> >
> > 1. tools/i965_disasm.c:58:4: warning:
> > ignoring return value of ‘fread’,
> > declared with attribute warn_unused_result
> >
Hello,
Thanks for review.
Please find my comments below:
On Fri, Nov 9, 2018 at 2:52 PM Eric Engestrom
wrote:
> On Tuesday, 2018-09-11 15:42:05 +0300, asimiklit.w...@gmail.com wrote:
> > From: Andrii Simiklit
> >
> > 1. nir/nir_lower_vars_to_ssa.c:691:21: warning:
> >unused variable
Hello,
Please find my comment below:
On Wed, Nov 7, 2018 at 4:49 PM Toni Lönnberg
wrote:
> Preliminary work for adding handling of different pipes to gen_decoder.
> Each
> instruction needs to have a definition describing which engine it is meant
> for.
> If left undefined, by default, the
Hello,
I don't know how we usually do in such cases.
Could I just restore back the 'review-by' tags here due to trivial changes
or this patch should pass review process once again?
Thanks,
Andrii.
On Mon, Nov 5, 2018 at 10:42 AM Jordan Justen
wrote:
> On 2018-11-05 00:11:52, andrey simik
Hello,
Please find my comment below:
On Mon, Nov 5, 2018 at 5:36 PM Lionel Landwerlin <
lionel.g.landwer...@intel.com> wrote:
> We add a function that allows us to check whether a particular
> description of a Vulkan format is available for a given device.
>
> Signed-off-by: Lionel Landwerlin
Hello,
Any updates here?
I think that I missed tag:
Reported-by: Ian Romanick
Here: https://bugzilla.freedesktop.org/show_bug.cgi?id=92552#c9
The patch for the test which will check it:
https://patchwork.freedesktop.org/patch/256432/
Thanks,
Andrii.
On Thu, Oct 11, 2018 at 2:12 PM wrote:
>
Hello,
Any updates here? :-)
This test is needed to check issue which should be fixed by the following
mesa patch:
https://patchwork.freedesktop.org/patch/256063/
This issue mentioned in this bug by Ian Romanick :
https://bugzilla.freedesktop.org/show_bug.cgi?id=92552#c9
Regards,
Andrii.
On
Hi all,
Have somebody some suggestions for this test?
This patch is needed to test an issue (assertion in mesa) which will be
fixed by this mesa patch:
https://patchwork.freedesktop.org/patch/254397/
Regards,
Andrii.
On Tue, Oct 23, 2018 at 4:44 PM wrote:
> From: Andrii Simiklit
>
> Test
Hello,
Good news, thanks :-)
One more thanks for clarification about Intel CI workflow.
Thanks,
Andrii.
On Mon, Nov 5, 2018 at 6:31 PM Mark Janes wrote:
> andrey simiklit writes:
>
> > Hello,
> >
> > I tested this patch few times and have the following results:
>
:52, andrey simiklit wrote:
> > Hello,
> >
> > I tested this patch few times and have the following results:
> >
> https://mesa-ci.01.org/global_logic/builds/38/group/63a9f0ea7bb98050796b649e85481845
> >
> https://mesa-ci.01.org/global_logic/builds/41/group/63a9f0ea7bb9
Hello,
I tested this patch few times and have the following results:
https://mesa-ci.01.org/global_logic/builds/38/group/63a9f0ea7bb98050796b649e85481845
https://mesa-ci.01.org/global_logic/builds/41/group/63a9f0ea7bb98050796b649e85481845
Hello,
Please find my comments below:
On Thu, Nov 1, 2018 at 12:24 PM Eric Engestrom
wrote:
> warning: field 'base' with variable sized type 'struct
> drm_i915_query_topology_info'
> not at the end of a struct or class is a GNU extension
> [-Wgnu-variable-sized-type-not-at-end]
>
>
Hello,
Sorry, one more point here.
Could I ask you to push it, because I don't have a push rights :-)
Thanks a lot,
Andrii.
On Fri, Oct 26, 2018 at 6:09 PM Lionel Landwerlin <
lionel.g.landwer...@intel.com> wrote:
> On 26/10/2018 15:29, asimiklit.w...@gmail.com wrote:
> > From: Andrii Simiklit
Hello,
On Tue, Oct 30, 2018 at 9:14 PM Kenneth Graunke
wrote:
> On Friday, October 26, 2018 1:06:52 AM PDT andrey simiklit wrote:
> > Hi,
> >
> > Could you please help me with a push. I don't have a right for it :-)
> >
> > Thanks,
> > Andrii.
>
>
Hello,
Thanks a lot)
Regards,
Andrii.
On Tue, Oct 30, 2018 at 9:22 PM Jordan Justen
wrote:
> On 2018-10-26 01:06:52, andrey simiklit wrote:
> > Hi,
> >
> > Could you please help me with a push. I don't have a right for it :-)
> >
>
> I pushed these two patc
Hello,
Thanks a lot for reviewing and for quick reply.
Sorry, I forgot ( I thought that it impossible to have the feedback in a 10
minutes on Friday :-) ) to update my inbox and sent version v2,
I guess that I fix small issue in v2:
- aub_file_finish();
+ if(aub.file) {
+
Hi,
Could you please help me with a push. I don't have a right for it :-)
Thanks,
Andrii.
On Thu, Oct 11, 2018 at 9:22 PM Jordan Justen
wrote:
> On 2018-10-11 03:01:56, andrey simiklit wrote:
> > Hello,
> >
> > Thanks for reviewing.
> > Please find my comment be
Hello,
Please find my comment below:
On Mon, Oct 8, 2018 at 2:15 PM Daniel Schürmann <
daniel.schuerm...@campus.tu-berlin.de> wrote:
> ---
> src/compiler/nir/meson.build | 1 +
> src/compiler/nir/nir.h | 2 +
> src/compiler/nir/nir_divergence_analysis.c |
Hello,
On Fri, Oct 12, 2018 at 01:52 Ian Romanick wrote:
> On 10/11/2018 12:12 PM, Kenneth Graunke wrote:
> > On Thursday, October 11, 2018 11:58:40 AM PDT Kenneth Graunke wrote:
> >> On Tuesday, October 2, 2018 9:16:01 AM PDT asimiklit.w...@gmail.com
> wrote:
> >>> From: Andrii Simiklit
> >>>
Hello,
On Fri, Oct 19, 2018 at 15:14 Kenneth Graunke wrote:
> On Thursday, October 11, 2018 12:12:38 PM PDT Kenneth Graunke wrote:
> > On Thursday, October 11, 2018 11:58:40 AM PDT Kenneth Graunke wrote:
> > > On Tuesday, October 2, 2018 9:16:01 AM PDT asimiklit.w...@gmail.com
> wrote:
> > > >
Hi,
Thanks for your advices.
I will be on vacation from 13.10.2018 till 20.10.2018
so I will try to do it after vacation.
Thanks,
Andrii.
On Thu, Oct 11, 2018 at 6:10 PM Rafael Antognolli <
rafael.antogno...@intel.com> wrote:
> On Thu, Oct 11, 2018 at 03:12:08PM +0300, andrey simik
Hi all,
I have tested it on Intel CI and it just fixes test without any regression:
https://mesa-ci.01.org/global_logic/builds/27/group/63a9f0ea7bb98050796b649e85481845
This patch fixes piglit test:
https://bugs.freedesktop.org/show_bug.cgi?id=92822
At the moment it is marked as expected
Hi,
Thanks for reviewing.
This 'simple reproducer' just can cause assertion
in the debug mesa version but I don't know
how to check things which cause it using opengl api at the moment.
I mean it can be some internal mesa things inaccessible outside
but anyway I am going to try to do it.
Hello,
Thanks for reviewing.
Please find my comment below.
On Thu, Oct 11, 2018 at 12:37 AM Jordan Justen
wrote:
> On 2018-09-12 09:05:44, wrote:
> > From: Andrii Simiklit
> >
> > There's no point reverting to the last saved point if that save point is
> > the empty batch, we will just
Hello,
Please find my comments below:
On Sat, Oct 6, 2018 at 1:07 AM Ian Romanick wrote:
> On 10/05/2018 03:02 PM, Ian Romanick wrote:
> > On 10/04/2018 07:08 AM, asimiklit.w...@gmail.com wrote:
> >> From: Andrii Simiklit
> >>
> >> GLSL 3.7 (Identifiers):
> >> "However, as noted in the
Hello,
+ i...@freedesktop.org
and add missing bugzilla link
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=108247
Regards,
Andrii.
On Thu, Oct 4, 2018 at 5:08 PM wrote:
> From: Andrii Simiklit
>
> GLSL 3.7 (Identifiers):
> "However, as noted in the specification, there are some cases
Hi,
Please find my comment below:
Regards,
Andrii.
On Wed, Sep 26, 2018 at 6:39 PM Eric Engestrom
wrote:
> Signed-off-by: Eric Engestrom
> ---
> src/vulkan/wsi/wsi_common_display.c | 95 -
> 1 file changed, 94 insertions(+), 1 deletion(-)
>
> diff --git
Hi,
Please find my comments below:
Regards,
Andrii.
On Tue, Sep 18, 2018 at 4:49 AM Marek Olšák wrote:
> Reviewed-by: Marek Olšák
>
> Marek
>
> On Wed, Sep 12, 2018 at 6:50 AM, Timothy Arceri
> wrote:
> > This reverts commit bc65dcab3bc48673ff6180afb036561a4b8b1119.
> >
> > This was
Hello,
Please find my comment below:
Regards,
Andrii.
On Fri, Sep 14, 2018 at 12:23 PM Gert Wollny
wrote:
> From: Tomeu Vizoso
>
> Pass the size of a resource when creating it so a backing can be kept in
> the other side.
>
> Also pass the required offset to transfer commands.
>
> This moves
Hello,
Thanks a lot for reviewing and testing on CI.
I will send new patch as soon as fix all these issues.
Regards,
Andrii.
On Thu, Sep 13, 2018 at 2:32 PM Tapani Pälli wrote:
>
>
> On 09/07/2018 03:25 PM, andrey simiklit wrote:
> > Hi all,
> >
> > Could someb
://patchwork.freedesktop.org/patch/247612/
Regards,
Andrii.
On Fri, Sep 7, 2018 at 12:42 PM andrey simiklit
wrote:
> On Fri, Sep 7, 2018 at 12:09 PM Emil Velikov
> wrote:
>
>> On 6 September 2018 at 17:58, Eric Engestrom
>> wrote:
>> > On Thursday, 2018-09-06 17:43:50 +0300, asimiklit.w.
Hello,
Thanks for your reply.
Please find my comments below:
On Mon, Sep 10, 2018 at 2:45 PM Chris Wilson
wrote:
> Quoting andrey simiklit (2018-08-21 13:00:57)
> > Hi all,
> >
> > The bug for this issue was created:
> > https://bugs.freedesktop.org/show_bug.c
On Fri, Sep 7, 2018 at 4:35 PM Chris Wilson
wrote:
> As a prelude to handling large address spaces, first allow ourselves the
> luxury of handling the full 4G.
>
> Reported-by: Andrey Simiklit
> Cc: Kenneth Graunke
> ---
> src/mesa/drivers/dri/i965/brw_context.h
Hi all,
Could somebody check it on CI to confirm that this patch do not add
regressions or maybe even take a look at this patch.
Regards,
Andrii.
On Mon, Aug 27, 2018 at 12:39 PM andrey simiklit
wrote:
> Hi all,
>
> It would be great if somebody look at this.
> I guess that th
Hi all,
Could somebody run it on CI to confirm that this patch fixes one test and
not add regressions or maybe even take a look at this patch)
Regards,
Andrii.
On Fri, Aug 31, 2018 at 5:13 PM wrote:
> From: Andrii Simiklit
>
> It fixes a bit incorrectly implemented
On Fri, Sep 7, 2018 at 12:09 PM Emil Velikov
wrote:
> On 6 September 2018 at 17:58, Eric Engestrom
> wrote:
> > On Thursday, 2018-09-06 17:43:50 +0300, asimiklit.w...@gmail.com wrote:
> >> From: Andrii Simiklit
> >>
> >> This patch improve usage of [v][s][n]printf functions.
> >> Fixes cross
On Fri, Sep 7, 2018 at 5:38 AM Ian Romanick wrote:
> It seems like it might better to just replace all the calllers of
> _mesa_*printf with util_*printf.
>
Thanks. Yes you're right. I am going to rework it today.
> On 09/06/2018 07:43 AM, asimiklit.w...@gmail.com wrote:
> > From: Andrii
On Fri, Sep 7, 2018 at 5:40 AM Ian Romanick wrote:
> On 09/06/2018 07:43 AM, asimiklit.w...@gmail.com wrote:
> > From: Andrii Simiklit
> >
> > I guess it makes this implementation more portable.
> >
> > Signed-off-by: Andrii Simiklit
> > ---
> > src/amd/vulkan/radv_util.c | 5 +++--
> >
On Thu, Sep 6, 2018 at 7:58 PM Eric Engestrom
wrote:
> On Thursday, 2018-09-06 17:43:50 +0300, asimiklit.w...@gmail.com wrote:
> > From: Andrii Simiklit
> >
> > This patch improve usage of [v][s][n]printf functions.
> > Fixes cross platform implementation of vsnprintf
> >
> > v2: Linux man
On Thu, Sep 6, 2018 at 3:20 PM Emil Velikov
wrote:
> Hi Andrii,
>
> I think you might be overthinking my comments.
> There's nothing special, nor am I trying to force my opinion.
>
> If you think my suggestions make sense, great. Otherwise don't bother too
> much.
>
Thanks a lot for your advices
Hello,
Thanks for your reply.
Yes you are right.
The new code was added 7 days ago)
Regards,
Andrii.
On Tue, Sep 4, 2018 at 8:53 PM Marek Olšák wrote:
> On Mon, Sep 3, 2018 at 5:05 AM, andrey simiklit
> wrote:
> > Hello,
> >
> > I believe that this check already added
Hi,
Thanks for your reply.
These WIN32 compat functions seem iffy.
> Namely - often we'll issue a va_copy only to use the original va.
>
As far as I found there is the following reason to use va_copy:
https://linux.die.net/man/3/vsnprintf
"These functions do not call the va_end macro. Because
Hi,
Thanks a lot.
Regards,
Andrii.
On Mon, Sep 3, 2018 at 1:16 PM Lionel Landwerlin <
lionel.g.landwer...@intel.com> wrote:
> Done.
>
> -
> Lionel
>
> On 03/09/2018 08:55, andrey simiklit wrote:
>
> Hi all,
>
> Could somebody push this small patch to mesa?
Hi,
I guess it is just a small mistake in description that:
'z' was before:
z = y - x;
and became after:
z = x - y;
I think you inadvertently misspelled in the description and you mean:
>
> This pass attempts to dectect code sequences like
>
> if (x < y) {
> z = y - x;
>
Hi,
One more small think here:
> +int virgl_encode_set_hw_atomic_buffers(struct virgl_context *ctx,
> + unsigned start_slot, unsigned
count,
> + const struct pipe_shader_buffer
*buffers)
> +{
> + int i;
I believe that
Hello,
I believe that this check already added inside _mesa_lookup_vao:
>_mesa_lookup_vao(struct gl_context *ctx, GLuint id)
>{
> if (id == 0) {
> return NULL;
> } else {
> ...
>}
I guess that the '_mesa_lookup_vao' function returns NULL for zero indexes.
So we will never pass
Hi all,
Could somebody push this small patch to mesa?
Regards,
Andrii.
On Mon, Aug 20, 2018 at 9:13 PM Lionel Landwerlin <
lionel.g.landwer...@intel.com> wrote:
> On 20/08/2018 17:20, asimiklit.w...@gmail.com wrote:
> > From: Andrii Simiklit
> >
> > The "gen_group_get_length" function can
;
> >
> > Thanks for contributing!
> >
> > Sam
> >
> > On 28/08/18 13:59, andrey simiklit wrote:
> > > Hi all,
> > >
> > > Could somebody push it if it seems good for all?
> > >
> > > Regards,
> > > An
Hi all,
Could somebody push it if it seems good for all?
Regards,
Andrii.
On Thu, Aug 23, 2018 at 4:53 PM Samuel Iglesias Gonsálvez <
sigles...@igalia.com> wrote:
> The patch seems fine to me. I also tested it on Intel CI and there were no
> regressions.
>
> Reviewed-by: Samuel Iglesias
that the last batch
<https://bugs.freedesktop.org/attachment.cgi?id=141200> of log has an
aperture with negative value "(-1023.8Mb aperture)".
Please correct me if I am incorrect.
Regards,
Andrii.
On Tue, Aug 21, 2018 at 3:00 PM andrey simiklit
wrote:
> Hi all,
>
> The bug f
Hi all,
The bug for this issue was created:
https://bugs.freedesktop.org/show_bug.cgi?id=107626
Regards,
Andrii.
On Mon, Aug 20, 2018 at 5:43 PM, wrote:
> From: Andrii Simiklit
>
> If we restore the 'new batch' using 'intel_batchbuffer_reset_to_saved'
> function we must restore the default
Hi all,
This workaround just helps me to avoid the graphical corruption on SNB but
I not sure is it good idea.
Regards,
Andrii.
On Wed, Aug 15, 2018 at 6:20 PM, wrote:
> From: Andrii Simiklit
>
> When the SVBI Payload Enable is false I guess the register R1.4
> which contains the Maximum
Hi all,
Thanks for your reply.
We shouldn't even get to use the iterator if it's an unknown instruction.
> The decoder should just advance dword by dword until it finds something
> that
> makes sense again.
>
Got it)
So this is an expected behavior there:
return iter_group_offset_bits(iter,
Hi,
Sorry I missed the main thought here.
The "gen_group_get_length" function returns *int*
but the "iter_group_offset_bits" function returns *uint32_t*
So *uint32_t*(*int*(-32)) = *0xFFE0U* and it looks like unexpected
behavior for me:
iter_group_offset_bits(iter, iter->group_iter + 1) <
Hi,
> Ugh... not so good. According to Oliver on the bug, this just make the
assert go away and doesn't actually fix anything. Likely this is needed
but not sufficient.
So as far as I understand Oliver found the bad commit in xorg glamor:
https://bugs.freedesktop.org/show_bug.cgi?id=107287
So
HI all,
Sorry, just ignore this patch with incorrect subject.
I will send correct one shortly.
Regards,
Andrii.
On Thu, Jun 21, 2018 at 4:12 PM, Andrii Simiklit
wrote:
> We can not use the VUE Dereference flags combination for EOT
> message under ILK and SNB because the threads are not
Hello,
Thanks for a fast feedback.
I have created new patch:
"i965/gen6/gs: Handle case where a GS doesn't allocate VUE"
which contains all fixes.
Regards,
Andrii.
On Tue, Jun 19, 2018 at 3:16 PM, Iago Toral wrote:
> Hi Andrii,
>
> thanks for the fix!
>
> Kenneth, this patch makes it so that
80 matches
Mail list logo
