Re: [Mesa-dev] [PATCH] Make single-buffered GLES representation internally consistent

On Fri 01 Jul 2016, Chad Versace wrote: > On Thu 30 Jun 2016, Stéphane Marchesin wrote: > > On Thu, Jun 30, 2016 at 3:20 PM, Gurchetan Singh > > wrote: > > > There are a few places in the code where clearing and reading are done on > > > incorrect buffers for GLES

Re: [Mesa-dev] [PATCH] Make single-buffered GLES representation internally consistent

On Thu 30 Jun 2016, Stéphane Marchesin wrote: > On Thu, Jun 30, 2016 at 3:20 PM, Gurchetan Singh > wrote: > > There are a few places in the code where clearing and reading are done on > > incorrect buffers for GLES contexts. See comments for details. This > > fixes

Re: [Mesa-dev] [PATCH] Make single-buffered GLES representation internally consistent

On Thu, Jun 30, 2016 at 3:20 PM, Gurchetan Singh wrote: > There are a few places in the code where clearing and reading are done on > incorrect buffers for GLES contexts. See comments for details. This > fixes 75 GLES3 dEQP tests on the surfaceless platform with no

[Mesa-dev] [PATCH] Make single-buffered GLES representation internally consistent

There are a few places in the code where clearing and reading are done on incorrect buffers for GLES contexts. See comments for details. This fixes 75 GLES3 dEQP tests on the surfaceless platform with no regressions. v2: Corrected unclear comment v3: Make the change in context.c instead of

[Mesa-dev] [PATCH] Make single-buffered GLES representation internally consistent

There a few places in the code where clearing and reading are done on incorrect buffers for GLES contexts. See comments for details. This fixes 75 GLES3 dEQP tests on the surfaceless platform with no regressions. v2: Corrected unclear comment v3: Make the change in context.c instead of get.c

Re: [Mesa-dev] [PATCH] Make single-buffered GLES representation internally consistent

Hi Ilia, Setting it correctly initially is more messy. At least in my use case, we know the context type from EGL_RENDERABLE_TYPE before the framebuffer is created. We would need to add the context information to the visual used by _mesa_initialize_window_framebuffer. That requires including

Re: [Mesa-dev] [PATCH] Make single-buffered GLES representation internally consistent

On Mon, Jun 27, 2016 at 6:30 PM, Gurchetan Singh wrote: > Hi Ilia, > > The changes for get.c where prompted by the es3fIntegerStateQueryTests (see > modules/gles3/functional/es3fIntegerStateQueryTests.cpp in the dEQP tree). > Specifically, these few lines: > >>> const

Re: [Mesa-dev] [PATCH] Make single-buffered GLES representation internally consistent

Hi Ilia, The changes for get.c where prompted by the es3fIntegerStateQueryTests (see modules/gles3/functional/es3fIntegerStateQueryTests.cpp in the dEQP tree). Specifically, these few lines: >> const GLint validInitialValues[] = {GL_BACK, GL_NONE}; >> m_verifier->verifyIntegerAnyOf(m_testCtx,

Re: [Mesa-dev] [PATCH] Make single-buffered GLES representation internally consistent

On Mon, Jun 27, 2016 at 4:17 PM, Gurchetan Singh wrote: > There a few places in the code where clearing and reading are done on > incorrect > buffers for GLES contexts. See comments for details. This fixes 75 GLES3 > dEQP tests on the surfaceless platform with no

[Mesa-dev] [PATCH] Make single-buffered GLES representation internally consistent

There a few places in the code where clearing and reading are done on incorrect buffers for GLES contexts. See comments for details. This fixes 75 GLES3 dEQP tests on the surfaceless platform with no regressions. v2: Corrected unclear comment --- src/mesa/main/buffers.c | 14 --

[Mesa-dev] [PATCH] Make single-buffered GLES representation internally consistent

There a few places in the code where clearing and reading are done on incorrect buffers for GLES contexts. See comments for details. This fixes 75 GLES3 dEQP tests on the surfaceless platform with no regressions. --- src/mesa/main/buffers.c | 14 -- src/mesa/main/clear.c | 8