Re: [Mesa-dev] [PATCH] nir: don't emit empty initializers for MSVC

2019-05-02 Thread Brian Paul
On 05/02/2019 01:35 PM, Connor Abbott wrote: This will crash at runtime, since it'll construct a "struct transform" with all NULL pointers, and then the loop below in ${pass_name}_block() will see that there's one transform in the array since it uses ARRAY_SIZE and then crash trying to access

Re: [Mesa-dev] [PATCH] nir: don't emit empty initializers for MSVC

2019-05-02 Thread Connor Abbott
Whoops, that should be "radeonsi with radeonsi_enable_nir=true" since NIR isn't enabled by default yet. On Thu, May 2, 2019 at 9:35 PM Connor Abbott wrote: > This will crash at runtime, since it'll construct a "struct transform" > with all NULL pointers, and then the loop below in

Re: [Mesa-dev] [PATCH] nir: don't emit empty initializers for MSVC

2019-05-02 Thread Connor Abbott
This will crash at runtime, since it'll construct a "struct transform" with all NULL pointers, and then the loop below in ${pass_name}_block() will see that there's one transform in the array since it uses ARRAY_SIZE and then crash trying to access it. Running piglit with i965, or radeonsi will

[Mesa-dev] [PATCH] nir: don't emit empty initializers for MSVC

2019-05-02 Thread Brian Paul
This fixes a build failure with MSVC. --- I've compiled tested this, but not sure how to runtime test it. --- src/compiler/nir/nir_algebraic.py | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/compiler/nir/nir_algebraic.py b/src/compiler/nir/nir_algebraic.py index 6db749e..dc25421