On Tue, 2019-06-25 at 12:36 -0700, Vasily Khoruzhick wrote:
> On Tue, Jun 25, 2019 at 11:54 AM Alyssa Rosenzweig
> wrote:
>
> Hi Alyssa,
>
> > Rather than using a magic lookup table with no explanations, let's
> > add
> > liberal comments to the code to explain what this tiling scheme is
> >
Am 28.06.2019 um 22:56 schrieb Vasily Khoruzhick:
On Tue, Jun 25, 2019 at 1:26 PM Alyssa Rosenzweig
wrote:
Rather than using a magic lookup table with no explanations, let's add
liberal comments to the code to explain what this tiling scheme is and
how to encode/decode it efficiently.
It's
On Tue, Jun 25, 2019 at 1:26 PM Alyssa Rosenzweig
wrote:
>
> Rather than using a magic lookup table with no explanations, let's add
> liberal comments to the code to explain what this tiling scheme is and
> how to encode/decode it efficiently.
>
> It's not so mysterious after all -- just
> LGTM however I haven't tested it.
I have; there are some regressions I need to deal with. One of them was
silly (switching src_stride/dst_stride argument order in the load call).
The others are either CI fails or legitimate bugs.
Regardless, I won't push until it's green on our side :)
>
>
On Tue, Jun 25, 2019 at 11:54 AM Alyssa Rosenzweig
wrote:
Hi Alyssa,
> Rather than using a magic lookup table with no explanations, let's add
> liberal comments to the code to explain what this tiling scheme is and
> how to encode/decode it efficiently.
>
> It's not so mysterious after all --
Rather than using a magic lookup table with no explanations, let's add
liberal comments to the code to explain what this tiling scheme is and
how to encode/decode it efficiently.
It's not so mysterious after all -- just reordering bits with some XORs
thrown in.
v2: Correct copyright identifier.
Hi Alyssa,
On Tue, 25 Jun 2019 at 19:54, Alyssa Rosenzweig
wrote:
> @@ -2,6 +2,7 @@
> * Copyright (c) 2011-2013 Luc Verhaegen
> * Copyright (c) 2018 Alyssa Rosenzweig
> * Copyright (c) 2018 Vasily Khoruzhick
> + * Copyright (c) 2019 Collabora
Please use 'Collabora, Ltd.' as that's our
Rather than using a magic lookup table with no explanations, let's add
liberal comments to the code to explain what this tiling scheme is and
how to encode/decode it efficiently.
It's not so mysterious after all -- just reordering bits with some XORs
thrown in.
Signed-off-by: Alyssa Rosenzweig
