Re: [Mesa-dev] [PATCH] st/mesa: bound the sampler count before calling into the driver.

2013-03-10 Thread Stéphane Marchesin
On Sat, Mar 9, 2013 at 1:35 PM, Jose Fonseca jfons...@vmware.com wrote: - Original Message - On Sat, Mar 9, 2013 at 12:30 PM, Jose Fonseca jfons...@vmware.com wrote: Looks a sensible thing to do. Reviewed-by: Jose Fonseca jfons...@vmware.com Thanks for the review. Any

Re: [Mesa-dev] [PATCH] st/mesa: bound the sampler count before calling into the driver.

2013-03-10 Thread Marek Olšák
On Sat, Mar 9, 2013 at 9:43 PM, Stéphane Marchesin stephane.marche...@gmail.com wrote: On Sat, Mar 9, 2013 at 12:30 PM, Jose Fonseca jfons...@vmware.com wrote: Looks a sensible thing to do. Reviewed-by: Jose Fonseca jfons...@vmware.com Thanks for the review. Any insight how the caller can

Re: [Mesa-dev] [PATCH] st/mesa: bound the sampler count before calling into the driver.

2013-03-09 Thread Jose Fonseca
Looks a sensible thing to do. Reviewed-by: Jose Fonseca jfons...@vmware.com Any insight how the caller can be fixed so that this doesn't happen? Jose - Original Message - With the current code, the sampler count can become higher than PIPE_MAX_SAMPLERS and once it gets to the driver

Re: [Mesa-dev] [PATCH] st/mesa: bound the sampler count before calling into the driver.

2013-03-09 Thread Stéphane Marchesin
On Sat, Mar 9, 2013 at 12:30 PM, Jose Fonseca jfons...@vmware.com wrote: Looks a sensible thing to do. Reviewed-by: Jose Fonseca jfons...@vmware.com Thanks for the review. Any insight how the caller can be fixed so that this doesn't happen? It happens to me when draw stages add more

Re: [Mesa-dev] [PATCH] st/mesa: bound the sampler count before calling into the driver.

2013-03-09 Thread Jose Fonseca
- Original Message - On Sat, Mar 9, 2013 at 12:30 PM, Jose Fonseca jfons...@vmware.com wrote: Looks a sensible thing to do. Reviewed-by: Jose Fonseca jfons...@vmware.com Thanks for the review. Any insight how the caller can be fixed so that this doesn't happen? It

[Mesa-dev] [PATCH] st/mesa: bound the sampler count before calling into the driver.

2013-03-08 Thread Stéphane Marchesin
With the current code, the sampler count can become higher than PIPE_MAX_SAMPLERS and once it gets to the driver this can lead to miscellaneous crashes and memory corruptions. Although this is taken care of in debug mode with an assert, there is still a way to cause a crash/overflow in release