Re: [Mesa-dev] [PATCH] util: no-op __builtin_types_compatible_p() for non-GCC compilers

2019-03-29 Thread Ian Romanick
On 3/29/19 1:54 PM, Brian Paul wrote: > On 03/29/2019 12:58 PM, Ian Romanick wrote: >> On 3/29/19 9:57 AM, Brian Paul wrote: >>> __builtin_types_compatible_p() is GCC-specific and breaks the >>> MSVC build. >>> >>> This intrinsic has been in u_vector_foreach() for a long time, but >>> that macro

Re: [Mesa-dev] [PATCH] util: no-op __builtin_types_compatible_p() for non-GCC compilers

2019-03-29 Thread Brian Paul
On 03/29/2019 12:58 PM, Ian Romanick wrote: On 3/29/19 9:57 AM, Brian Paul wrote: __builtin_types_compatible_p() is GCC-specific and breaks the MSVC build. This intrinsic has been in u_vector_foreach() for a long time, but that macro has only recently been used in code

Re: [Mesa-dev] [PATCH] util: no-op __builtin_types_compatible_p() for non-GCC compilers

2019-03-29 Thread Ian Romanick
On 3/29/19 9:57 AM, Brian Paul wrote: > __builtin_types_compatible_p() is GCC-specific and breaks the > MSVC build. > > This intrinsic has been in u_vector_foreach() for a long time, but > that macro has only recently been used in code > (nir/nir_opt_comparison_pre.c) that's built with MSVC. > >

Re: [Mesa-dev] [PATCH] util: no-op __builtin_types_compatible_p() for non-GCC compilers

2019-03-29 Thread Jose Fonseca
Looks good Reviewed-by: Jose Fonseca From: Brian Paul Sent: Friday, March 29, 2019 16:57 To: mesa-dev@lists.freedesktop.org Cc: Ian Romanick; Jose Fonseca; Neha Bhende Subject: [PATCH] util: no-op __builtin_types_compatible_p() for non-GCC compilers

[Mesa-dev] [PATCH] util: no-op __builtin_types_compatible_p() for non-GCC compilers

2019-03-29 Thread Brian Paul
__builtin_types_compatible_p() is GCC-specific and breaks the MSVC build. This intrinsic has been in u_vector_foreach() for a long time, but that macro has only recently been used in code (nir/nir_opt_comparison_pre.c) that's built with MSVC. Fixes: 2cf59861a ("nir: Add partial redundancy