Re: [Mesa-dev] [PATCH 1/5] st/nine: Disable depth write when nothing gets updated

2019-03-09 Thread Axel Davy
On 08/03/2019 07:26, Kenneth Graunke wrote: On Thursday, March 7, 2019 2:23:53 PM PST Axel Davy wrote: I don't think we actually need the NEVER check, but it seems fine. Patches 1 and 3 are: Reviewed-by: Kenneth Graunke I'm not really up to speed to review the others. Thanks, I got a review

Re: [Mesa-dev] [PATCH 1/5] st/nine: Disable depth write when nothing gets updated

2019-03-07 Thread Kenneth Graunke
On Thursday, March 7, 2019 2:23:53 PM PST Axel Davy wrote: > I do not see any perf impact on radeonsi, but it > seems iris needs this. > It seems something sensible to do. > > Signed-off-by: Axel Davy > Reviewed-by: Timur Kristóf > Tested-by: Andre Heider > --- > It may be argued this kind of

[Mesa-dev] [PATCH 1/5] st/nine: Disable depth write when nothing gets updated

2019-03-07 Thread Axel Davy
I do not see any perf impact on radeonsi, but it seems iris needs this. It seems something sensible to do. Signed-off-by: Axel Davy Reviewed-by: Timur Kristóf Tested-by: Andre Heider --- It may be argued this kind of stuff should be done in the driver. I don't mind either way. The ogl state