Re: [Mesa-dev] [PATCH 2/2] i965: Do NIR shader cloning in the caller.

2018-11-10 Thread Alejandro Piñeiro
I was tempted to suggest to add a comment somewhere mentioning this policy change, but there are so many functions that Im not sure what would be that somewhere. Ramblings apart: Reviewed-by: Alejandro Piñeiro On 10/11/18 09:17, Kenneth Graunke wrote: > This moves nir_shader_clone() to the

[Mesa-dev] [PATCH 2/2] i965: Do NIR shader cloning in the caller.

2018-11-10 Thread Kenneth Graunke
This moves nir_shader_clone() to the driver-specific compile function, rather than the shared src/intel/compiler code. This allows i965 to do key-specific passes before calling brw_compile_*. Vulkan should not need this cloning as it doesn't compile multiple variants. We do need to continue