Re: [Mesa-dev] [PATCH 2/3] panfrost: Allocate scanout BOs in panfrost device

2019-07-05 Thread Alyssa Rosenzweig
Ah, sure. Thank you for clarifying! signature.asc Description: PGP signature ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 2/3] panfrost: Allocate scanout BOs in panfrost device

2019-07-05 Thread Daniel Stone
On Fri, 5 Jul 2019 at 14:38, Alyssa Rosenzweig wrote: > > +bool should_tile = !is_streaming && is_texture && is_2d && > > !is_scanout; > > I'm not opposed, but why can't we tile PIPE_BIND_SHARED textures? lima > does exactly that. If we can't tile them, we certainly can't AFBC them. We

Re: [Mesa-dev] [PATCH 2/3] panfrost: Allocate scanout BOs in panfrost device

2019-07-05 Thread Alyssa Rosenzweig
> +bool should_tile = !is_streaming && is_texture && is_2d && > !is_scanout; I'm not opposed, but why can't we tile PIPE_BIND_SHARED textures? lima does exactly that. If we can't tile them, we certainly can't AFBC them. signature.asc Description: PGP signature

Re: [Mesa-dev] [PATCH 2/3] panfrost: Allocate scanout BOs in panfrost device

2019-07-04 Thread Boris Brezillon
On Thu, 4 Jul 2019 10:04:42 +0200 Tomeu Vizoso wrote: > @@ -382,11 +362,14 @@ panfrost_resource_create_bo(struct panfrost_screen > *screen, struct panfrost_reso > > /* Tiling textures is almost always faster, unless we only use it > once */ > > +#define SCANOUT (PIPE_BIND_SCANOUT

[Mesa-dev] [PATCH 2/3] panfrost: Allocate scanout BOs in panfrost device

2019-07-04 Thread Tomeu Vizoso
In preparation for using AFBC for BOs that could be scanned out (though they are likely to be only shared with the compositor for now), use the buffer allocation UABI of the GPU driver, as dumb buffers cannot be allocated for AFBC. Signed-off-by: Tomeu Vizoso ---