Re: [Mesa-dev] [PATCH 2/7] nir: Add a nir_lower_io flag for using load_interpolated_input intrins.

2016-07-19 Thread Kenneth Graunke
On Tuesday, July 19, 2016 12:57:23 PM PDT Jason Ekstrand wrote: > On Mon, Jul 18, 2016 at 10:00 PM, Chris Forbes wrote: > > > Seems a little unfortunate to add a random bool to this interface which is > > otherwise fairly descriptive, but OK. > > > > I agree that this is a bit

Re: [Mesa-dev] [PATCH 2/7] nir: Add a nir_lower_io flag for using load_interpolated_input intrins.

2016-07-19 Thread Jason Ekstrand
On Mon, Jul 18, 2016 at 10:00 PM, Chris Forbes wrote: > Seems a little unfortunate to add a random bool to this interface which is > otherwise fairly descriptive, but OK. > I agree that this is a bit unfortunate. I was going to suggest adding a flags parameter and a bitfield

Re: [Mesa-dev] [PATCH 2/7] nir: Add a nir_lower_io flag for using load_interpolated_input intrins.

2016-07-18 Thread Chris Forbes
Seems a little unfortunate to add a random bool to this interface which is otherwise fairly descriptive, but OK. On Tue, Jul 19, 2016 at 8:26 AM, Kenneth Graunke wrote: > While my intention is that the new intrinsics should be usable by all > drivers, we need to make them

[Mesa-dev] [PATCH 2/7] nir: Add a nir_lower_io flag for using load_interpolated_input intrins.

2016-07-18 Thread Kenneth Graunke
While my intention is that the new intrinsics should be usable by all drivers, we need to make them optional until all drivers switch. This doesn't do anything yet, but I added it as a separate patch to keep the interface churn separate for easier review. Signed-off-by: Kenneth Graunke