Re: [Mesa-dev] [PATCH 7/7] i965: Delete the FS_OPCODE_INTERPOLATE_AT_CENTROID virtual opcode.

Patches 2, 3, 4, and 7 are Reviewed-by: Jason Ekstrand I've left comments on a few others. On Mon, Jul 18, 2016 at 10:30 PM, Jason Ekstrand wrote: > On Jul 18, 2016 10:11 PM, "Chris Forbes" wrote: > > > > I remember arguing about

Re: [Mesa-dev] [PATCH 7/7] i965: Delete the FS_OPCODE_INTERPOLATE_AT_CENTROID virtual opcode.

On Jul 18, 2016 10:11 PM, "Chris Forbes" wrote: > > I remember arguing about this when it got added -- tradeoff was payload size/register pressure vs needing to call out to this unit, if centroid barycentric coords weren't required for anything else? It does seem fairly

Re: [Mesa-dev] [PATCH 7/7] i965: Delete the FS_OPCODE_INTERPOLATE_AT_CENTROID virtual opcode.

I remember arguing about this when it got added -- tradeoff was payload size/register pressure vs needing to call out to this unit, if centroid barycentric coords weren't required for anything else? It does seem fairly pointless, though. For the series:- Reviewed-by: Chris Forbes

[Mesa-dev] [PATCH 7/7] i965: Delete the FS_OPCODE_INTERPOLATE_AT_CENTROID virtual opcode.

We no longer use this message. As far as I can tell, it's fairly useless - the equivalent information is provided in the payload. Signed-off-by: Kenneth Graunke --- src/mesa/drivers/dri/i965/brw_defines.h| 1 - src/mesa/drivers/dri/i965/brw_fs.cpp | 2