[Mesa-dev] [PATCH] nv50/ir: don't consider the main compute function as taking arguments

2019-07-25 Thread Ilia Mirkin
With OpenCL, kernels can take arguments and return values (?). However in practice, there is no more TGSI compute implementation, and even if there were, it would probably have named functions and no explicit main. This improves RA considerably for compute shaders, since temps are not kept around

[Mesa-dev] [PATCH] nv50/ir: handle insn not being there for definition of CVT arg

2019-07-25 Thread Ilia Mirkin
This can happen if it's e.g. a uniform or a function argument. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=111217 Signed-off-by: Ilia Mirkin Cc: mesa-sta...@lists.freedesktop.org --- src/gallium/drivers/nouveau/codegen/nv50_ir_peephole.cpp | 5 +++-- 1 file changed, 3 insertions(+),

[Mesa-dev] [PATCH 4/4] nouveau: flip DEBUG -> !NDEBUG

2019-07-25 Thread Ilia Mirkin
The meson conversion chose to change the meaning of DEBUG to "used for debugging" to be "used for expensive things for debugging", primarily for nir_validate. Flip things over so that we get nice things with optimizations enabled. While we're at it, also kill off nouveau_statebuf.h which is

[Mesa-dev] [PATCH 3/4] nvc0: allow a non-user buffer to be bound at position 0

2019-07-25 Thread Ilia Mirkin
Previously the code only handled it for positions 1 and up (as would be for UBO's in GL). It's not a lot of trouble to handle this, and vl or vdpau want this. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=111213 Signed-off-by: Ilia Mirkin Cc: mesa-sta...@lists.freedesktop.org ---

[Mesa-dev] [PATCH 2/4] nv50, nvc0: update sampler/view bind functions to accept NULL array

2019-07-25 Thread Ilia Mirkin
Apparently vl (or vdpau) wants to pass that in now. Handle it. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=111213 Signed-off-by: Ilia Mirkin Cc: mesa-sta...@lists.freedesktop.org --- src/gallium/drivers/nouveau/nv50/nv50_state.c | 14 --

[Mesa-dev] [PATCH 1/4] gallium/vl: fix compute tgsi shaders to not process undefined components

2019-07-25 Thread Ilia Mirkin
This caused nouveau's function handling logic to think that the MAIN function was due to receive external parameters, and cascaded some failures after that. Instead avoid having the undefined components in the first place. Fixes: f6ac0b5d71 (gallium/auxiliary/vl: Add compute shader to support

Re: [Mesa-dev] [PATCH] radv: Set correct metadata size for GFX9+.

2019-07-25 Thread Samuel Pitoiset
Reviewed-by: Samuel Pitoiset On 7/25/19 4:55 PM, Bas Nieuwenhuizen wrote: Without correct size, radeonsi assumes the metadata is incorrect, which can and will cause issues. Since the metadata is really incorrect without the size, let us fix that. Fixes: e43cc3e3afc "radv/gfx9: handle GFX9

[Mesa-dev] [PATCH] radv: Set correct metadata size for GFX9+.

2019-07-25 Thread Bas Nieuwenhuizen
Without correct size, radeonsi assumes the metadata is incorrect, which can and will cause issues. Since the metadata is really incorrect without the size, let us fix that. Fixes: e43cc3e3afc "radv/gfx9: handle GFX9 opaque metadata" --- src/amd/vulkan/radv_image.c | 3 ++- 1 file changed, 2

Re: [Mesa-dev] [PATCH] radv/gfx10: Disable DCC with scanout.

2019-07-25 Thread Bas Nieuwenhuizen
bleh, you're right So we should not be using DCC ... On Thu, Jul 25, 2019 at 4:37 PM Samuel Pitoiset wrote: > > It's already disabled later in this function? > > On 7/25/19 4:34 PM, Bas Nieuwenhuizen wrote: > > (a) radv does not set the DCC fields required yet. > > (b) radeonsi just broke

Re: [Mesa-dev] [PATCH] radv/gfx10: Disable DCC with scanout.

2019-07-25 Thread Samuel Pitoiset
It's already disabled later in this function? On 7/25/19 4:34 PM, Bas Nieuwenhuizen wrote: (a) radv does not set the DCC fields required yet. (b) radeonsi just broke their DCC metadata. Fixes: f8b6c5a1a63 "radeonsi: rewrite si_get_opaque_metadata, also for gfx10 support" ---

[Mesa-dev] [PATCH] radv/gfx10: Disable DCC with scanout.

2019-07-25 Thread Bas Nieuwenhuizen
(a) radv does not set the DCC fields required yet. (b) radeonsi just broke their DCC metadata. Fixes: f8b6c5a1a63 "radeonsi: rewrite si_get_opaque_metadata, also for gfx10 support" --- src/amd/vulkan/radv_image.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/amd/vulkan/radv_image.c

Re: [Mesa-dev] [PATCH] radv/gfx10: use L2 for DMA copy/fill operations

2019-07-25 Thread Samuel Pitoiset
On 7/25/19 3:39 PM, Bas Nieuwenhuizen wrote: r-b though it sounds like some of our cache flushes might be not ideal. Yes. On Thu, Jul 25, 2019 at 3:35 PM Samuel Pitoiset wrote: It's coherent and faster. GFX7-GFX9 should also support this but for now only uses L2 for GFX10 because it's

Re: [Mesa-dev] [PATCH] radv/gfx10: use L2 for DMA copy/fill operations

2019-07-25 Thread Bas Nieuwenhuizen
r-b though it sounds like some of our cache flushes might be not ideal. On Thu, Jul 25, 2019 at 3:35 PM Samuel Pitoiset wrote: > > It's coherent and faster. GFX7-GFX9 should also support this but > for now only uses L2 for GFX10 because it's untested on previous gens. > > This fixes

[Mesa-dev] [PATCH] radv/gfx10: use L2 for DMA copy/fill operations

2019-07-25 Thread Samuel Pitoiset
It's coherent and faster. GFX7-GFX9 should also support this but for now only uses L2 for GFX10 because it's untested on previous gens. This fixes dEQP-VK.memory.pipeline_barrier.transfer_* This also fixes some missing geometry in Dawn Of War III because VBOs weren't updated correctly.

Re: [Mesa-dev] [PATCH] panfrost/ci: Update kernel to 5.2

2019-07-25 Thread Alyssa Rosenzweig
A-b On Thu, Jul 25, 2019 at 01:26:07PM +0200, Tomeu Vizoso wrote: > Signed-off-by: Tomeu Vizoso > --- > src/gallium/drivers/panfrost/ci/debian-install.sh | 4 ++-- > src/gallium/drivers/panfrost/ci/gitlab-ci.yml | 2 +- > 2 files changed, 3 insertions(+), 3 deletions(-) > > diff --git

[Mesa-dev] [PATCH] panfrost/ci: Update kernel to 5.2

2019-07-25 Thread Tomeu Vizoso
Signed-off-by: Tomeu Vizoso --- src/gallium/drivers/panfrost/ci/debian-install.sh | 4 ++-- src/gallium/drivers/panfrost/ci/gitlab-ci.yml | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/gallium/drivers/panfrost/ci/debian-install.sh

[Mesa-dev] [Bug 111200] Xorg Graphical Corruption when using anything Vulkan on Navi10

2019-07-25 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=111200 Samuel Pitoiset changed: What|Removed |Added Resolution|--- |FIXED Status|NEEDINFO

[Mesa-dev] [Bug 111200] Xorg Graphical Corruption when using anything Vulkan on Navi10

2019-07-25 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=111200 --- Comment #2 from Matt --- Thanks Bas - that's fixed the corruption on my current snapshot Further to the newness of the navi support - should we as users be logging bugs for general instability or should we just be patient as the support

Re: [Mesa-dev] [PATCH v2] radv/gfx10: fix intensity formats by setting ALPHA_IS_ON_MSB

2019-07-25 Thread Bas Nieuwenhuizen
On Wed, Jul 24, 2019 at 4:47 PM Samuel Pitoiset wrote: > > This fixes > dEQP-VK.rasterization.primitive_size.points.point_size_* > > This also fixes some black squares with the Sascha SSAO demo. > > v2: - do not set for multiple channels > - call vi_alpha_is_on_msb() for pre-GFX10 > -

[Mesa-dev] [Bug 111141] [REGRESSION] [BISECTED] [DXVK] 1-bit booleans and Elite Dangerous shader mis-optimization

2019-07-25 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=41 --- Comment #17 from Connor Abbott --- No, crashing when replaying is definitely not expected, although the result of some bug could definitely be a GPU hang. It's really strange, though, since I can replay it just fine on my machine with a

[Mesa-dev] [Bug 111150] [BRW] WRC 5 asserts with gallium nine and iris.

2019-07-25 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=50 --- Comment #9 from Illia Iorin --- (In reply to Nanley Chery from comment #7) > I just updated the MR to fix the issue in iris. Please let me know if it > still helps. Updated MR fixes assert in WRC5. -- You are receiving this mail