Re: Intel clc dependency

On 4/10/24 13:53, Timo Aaltonen wrote: Brian Paul kirjoitti 6.4.2024 klo 1.05: I'm trying to build the Intel Vulkan driver.  First time in a few months.  I'm having build problems related to clc.  I'm on Ubuntu 22.04 [...] [1347/3181] Generating src/intel/vulkan/...om command (wrapped

Re: Intel clc dependency

the whole thing. On Fri, Apr 5, 2024, 6:05 PM Brian Paul <mailto:brian.p...@broadcom.com>> wrote: I'm trying to build the Intel Vulkan driver.  First time in a few months.  I'm having build problems related to clc.  I'm on Ubuntu 22.04 [...] [1347/3181] Generating

Intel clc dependency

I'm trying to build the Intel Vulkan driver. First time in a few months. I'm having build problems related to clc. I'm on Ubuntu 22.04 [...] [1347/3181] Generating src/intel/vulkan/...om command (wrapped by meson to set env) FAILED:

Re: Porting / AMIGA / PiStorm32 / developer needed - Back to the roots

On 4/12/23 02:30, Ignacio Soriano Hernandez wrote: !! External Email Dear Mesa dev community, Please let me apologize if you consider this off topic but I think that this is probably the audience that could help in reviving and getting back to the roots where Mesa3D originated from. To use

Re: [Mesa-dev] Mesa (master): lavapipe: bump maxMemoryAllocationCount

On 3/17/21 6:12 PM, GitLab Mirror wrote: Module: Mesa Branch: master Commit: 23100f3b6531d7055ae4d42e07bda09d991ea438 URL:

[Mesa-dev] Fwd: [Mesa-users] Surfaceless mesa 20.3.X?

Forwarding to mesa-dev where you may get more help. There was talk of changing software rendering but I'm not sure what's changed. What version of Mesa are you using? -Brian Forwarded Message Subject:[Mesa-users] Surfaceless mesa 20.3.X? Date: Wed, 27 Jan 2021

[Mesa-dev] Fwd: [Mesa-users] Issues with removal of classic OSMesa

Hi Andreas, I'm forwarding your message to the mesa-dev list for better visibility. BTW, when you say "antialiasing" below, what exactly do you mean? -Brian Forwarded Message Subject:[Mesa-users] Issues with removal of classic OSMesa Date: Thu, 31 Dec 2020

Re: [Mesa-dev] GLSLstd450NMin/NMax/NClamp

On 11/17/2020 01:59 PM, Brian Paul wrote: On 11/17/2020 11:45 AM, Ian Romanick wrote: On 11/17/20 9:25 AM, Brian Paul wrote: It appears these SPIR-V extension functions don't behave as they should on Intel (don't know about other Vulkan drivers). They're supposed to be NaN-aware

Re: [Mesa-dev] SpvOpSelect w/ float operands

On 11/18/2020 02:49 AM, Connor Abbott wrote: On Tue, Nov 17, 2020 at 9:56 PM Brian Paul wrote: On 11/17/2020 11:49 AM, Ian Romanick wrote: On 11/17/20 9:25 AM, Brian Paul wrote: Using the Intel Vulkan driver, we've found some cases where SpvOpSelect is returning -0.0 (negative zeros

[Mesa-dev] fp/int64 on gen11/12?

Another Intel question: It looks like gen11/gen12 don't have fp/int64 enabled in the Vulkan driver. From gen_device_info.c: #define GEN11_FEATURES(_gt, _slices, _subslices, _l3) \ GEN8_FEATURES, \ GEN11_HW_INFO, \

Re: [Mesa-dev] GLSLstd450NMin/NMax/NClamp

On 11/17/2020 11:45 AM, Ian Romanick wrote: On 11/17/20 9:25 AM, Brian Paul wrote: It appears these SPIR-V extension functions don't behave as they should on Intel (don't know about other Vulkan drivers). They're supposed to be NaN-aware such that if one argument is NaN, the other argument

Re: [Mesa-dev] SpvOpSelect w/ float operands

On 11/17/2020 11:49 AM, Ian Romanick wrote: On 11/17/20 9:25 AM, Brian Paul wrote: Using the Intel Vulkan driver, we've found some cases where SpvOpSelect is returning -0.0 (negative zeros) instead of normal 0.0 depending on the arguments. Do you have a specific test case that fails? Yeah

[Mesa-dev] SpvOpSelect w/ float operands

Using the Intel Vulkan driver, we've found some cases where SpvOpSelect is returning -0.0 (negative zeros) instead of normal 0.0 depending on the arguments. I'm wondering if "SpvOpSelect x, a, b" for floats is being implemented with something like "a*x + b*(1-x)" ? That might explain

[Mesa-dev] GLSLstd450NMin/NMax/NClamp

It appears these SPIR-V extension functions don't behave as they should on Intel (don't know about other Vulkan drivers). They're supposed to be NaN-aware such that if one argument is NaN, the other argument is returned. From our testing, it looks like NMax works as expected, but not NMin

Re: [Mesa-dev] llvmpipe is OpenGL 4.5 conformant.

Nice work!  It's good to see llvmpipe being maintained and improved like that. -Brian On 10/30/2020 02:24 PM, Dave Airlie wrote: Just to let everyone know, a month ago I submitted the 20.2 llvmpipe driver for OpenGL 4.5 conformance under the SPI/X.org umbrella, and it is now official[1].

Re: [Mesa-dev] Gallium interface rename proposals

This all sounds find to me, FWIW. -Brian On 09/19/2020 04:24 AM, Marek Olšák wrote: Hi, I don't know if you have been following gitlab, but there are a few cleanups that I have been considering doing. Rename PIPE_TRANSFER flags to PIPE_MAP, and pipe_transfer_usage to pipe_map_flags:

Re: [Mesa-dev] New Mesa3D.org website proposal

On Sun, Jun 14, 2020 at 9:28 AM Daniel Stone wrote: > Hi, > > On Fri, 29 May 2020 at 10:08, Erik Faye-Lund > wrote: > > In the light of the explanation above, do you still have objections to > > this split? > > > > Obviously, we haven't moved forward yet ;-) > > Well, we have now after getting

Re: [Mesa-dev] New Mesa3D.org website proposal

On 05/13/2020 03:13 AM, Erik Faye-Lund wrote: On Tue, 2020-05-12 at 12:17 +0200, Erik Faye-Lund wrote: On Thu, 2020-05-07 at 11:03 -0600, Brian Paul wrote: On 05/07/2020 04:33 AM, Erik Faye-Lund wrote: Hey Brian TLDR; are you OK with me moving forward with the rework of mesa3d.org? Yes

Re: [Mesa-dev] New Mesa3D.org website proposal

On Tue, May 12, 2020 at 4:04 AM Daniel Stone wrote: > Hi Brian, > > On Fri, 8 May 2020 at 15:30, Brian Paul wrote: > > Done. easydns says it may take up to 3 hours to go into effect. > > Thanks for doing this! Could you please add the following TXT records > as well (no

Re: [Mesa-dev] RFC: Memory allocation on Mesa

On 05/11/2020 10:13 AM, Jose Fonseca wrote: Hi, To give everybody a bit of background context, this email comes from https://gitlab.freedesktop.org/mesa/mesa/-/issues/2911 . The short story is that Gallium components (but not Mesa) used to have their malloc/free calls intercepted, to

Re: [Mesa-dev] New Mesa3D.org website proposal

On Thu, May 7, 2020 at 12:16 PM Brian Paul wrote: > On 05/07/2020 11:35 AM, Daniel Stone wrote: > > Hi, > > > > On Thu, 7 May 2020 at 18:08, Erik Faye-Lund > > wrote: > >> On Thu, 2020-05-07 at 11:03 -0600, Brian Paul wrote: > >>> It seems

Re: [Mesa-dev] New Mesa3D.org website proposal

On 05/07/2020 11:35 AM, Daniel Stone wrote: Hi, On Thu, 7 May 2020 at 18:08, Erik Faye-Lund wrote: On Thu, 2020-05-07 at 11:03 -0600, Brian Paul wrote: It seems like only the front page is served at the moment. Is it possible to get a look at the rest? The front page looks nice. Yeah, we

Re: [Mesa-dev] New Mesa3D.org website proposal

On 05/07/2020 04:33 AM, Erik Faye-Lund wrote: Hey Brian TLDR; are you OK with me moving forward with the rework of mesa3d.org? Yes... (BTW, sorry about the URL mangling below) As you hopefully are aware of, I've been working on a new website for mesa3d.org, split into a

[Mesa-dev] Windows build broken

by: commit f8f1413070ae079443ab31a75679cfd10cb756ed Author: Pierre-Eric Pelloux-Prayer Date: Mon Mar 16 10:49:17 2020 +0100 util/u_process: add util_get_process_exec_path Reviewed-by: Marek Olšák Part-of:

Re: [Mesa-dev] Drop scons for 20.1?

___ > > From: Kristian Høgsberg > > Sent: Wednesday, February 26, 2020 18:37 > > To: Jason Ekstrand > > Cc: Rob Clark ; mesa-dev < > mesa-dev@lists.freedesktop.org>; Dylan Baker ; > Jose Fonseca ; Brian Paul > > Subject: Re: [Mesa-dev] Drop scons

Re: [Mesa-dev] [Review Request (master branch)] svga: Use pipe_shader_state_from_tgsi to set shader state

I'm going to update the docs regarding patches and gitlab. It's kind of a mess now. -Brian On 02/11/2020 03:03 AM, Michel Dänzer wrote: Hi Charmaine, it looks like you pushed this patch and another one directly to the main Mesa repository master branch. Pushing directly to the main

Re: [Mesa-dev] Is it time to stop using the mailing list for patch review?

On 12/11/2019 10:42 AM, Jason Ekstrand wrote: On Wed, Dec 11, 2019 at 11:33 AM Michel Dänzer <mailto:mic...@daenzer.net>> wrote: On 2019-12-11 5:47 p.m., Brian Paul wrote: > > I've had little time for Mesa work the past 18 months. That makes me sad, I hope y

Re: [Mesa-dev] Is it time to stop using the mailing list for patch review?

On 12/09/2019 04:07 PM, Dylan Baker wrote: Hi everyone, I think its time we discussed whether we're going to continue to do patch review on the mailing list, or if it it should all go through gitlab. I think we should stop using the mailing list, here are some reasons: 1) Most development is

Re: [Mesa-dev] [PATCH] util/atomic: Fix p_atomic_add for unlocked and msvc paths

Reviewed-by: Brian Paul On 12/09/2019 10:49 AM, srol...@vmware.com wrote: From: Roland Scheidegger Braces mismatch (flagged by CI, untested). Fixes: 385d13f26d2 "util/atomic: Add a _return variant of p_atomic_add" --- src/util/u_atomic.h | 4 ++-- 1 file changed, 2 insert

Re: [Mesa-dev] [PATCH] nir: no-op C99 _Pragma() with MSVC

On 11/22/2019 09:16 PM, Ian Romanick wrote: On 11/22/19 6:49 PM, Brian Paul wrote: This fixes a build failure on MSVC. BTW, it looks like clang supports _Pragma() but I don't know if it understands the "gcc unroll N" directive. It probably doesn't, but that should be okay. This j

[Mesa-dev] [PATCH] nir: no-op C99 _Pragma() with MSVC

This fixes a build failure on MSVC. BTW, it looks like clang supports _Pragma() but I don't know if it understands the "gcc unroll N" directive. Signed-off-by: Brian Paul --- src/compiler/nir/nir_range_analysis.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/src/co

Re: [Mesa-dev] [PATCH] Call shmget() with permission 0600 instead of 0777

Ping again. On 10/24/2019 03:25 PM, Brian Paul wrote: Ping.  Anyone? -Brian On Tue, Oct 22, 2019 at 3:52 PM Brian Paul <mailto:bri...@vmware.com>> wrote: A security advisory (TALOS-2019-0857/CVE-2019-5068) found that creating shared memory regions with permission mode 0

[Mesa-dev] [PATCH] spirv: s/{}/{0}/ initializer to fix MSVC build

Trivial. --- src/compiler/spirv/vtn_variables.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/compiler/spirv/vtn_variables.c b/src/compiler/spirv/vtn_variables.c index 944d1f0..37ad4f2 100644 --- a/src/compiler/spirv/vtn_variables.c +++

[Mesa-dev] [PATCH] nir: fix a couple signed/unsigned comparison warnings in nir_builder.h

--- src/compiler/nir/nir_builder.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/compiler/nir/nir_builder.h b/src/compiler/nir/nir_builder.h index de00fe7..aed4759 100644 --- a/src/compiler/nir/nir_builder.h +++ b/src/compiler/nir/nir_builder.h @@ -782,7 +782,7 @@

[Mesa-dev] [PATCH] s/APIENTRY/GLAPIENTRY/ in teximage.c

The later is the right symbol for entrypoint functions. --- src/mesa/main/texgetimage.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mesa/main/texgetimage.c b/src/mesa/main/texgetimage.c index e43f336..d6ec4c5 100644 --- a/src/mesa/main/texgetimage.c +++

Re: [Mesa-dev] [PATCH] Call shmget() with permission 0600 instead of 0777

Ping. Anyone? -Brian On Tue, Oct 22, 2019 at 3:52 PM Brian Paul wrote: > A security advisory (TALOS-2019-0857/CVE-2019-5068) found that > creating shared memory regions with permission mode 0777 could allow > any user to access that memory. Several Mesa drivers use shared- > me

[Mesa-dev] [PATCH] Call shmget() with permission 0600 instead of 0777

A security advisory (TALOS-2019-0857/CVE-2019-5068) found that creating shared memory regions with permission mode 0777 could allow any user to access that memory. Several Mesa drivers use shared- memory XImages to implement back buffers for improved performance. This path changes the shmget()

Re: [Mesa-dev] [PATCH] st/nir: fix illegal designated initializer in st_glsl_to_nir.cpp

On 09/11/2019 03:06 PM, Ian Romanick wrote: On 9/10/19 10:53 PM, Brian Paul wrote: IIRC, designated initializers are not legal C++. Fixes the MSVC build. Fixes: 83fd1e58 ("glsl/nir: Add and use a gl_nir_link() function") --- src/mesa/state_tracker/st_glsl_to_nir.cpp | 2 +- 1 fi

[Mesa-dev] [PATCH] st/nir: fix illegal designated initializer in st_glsl_to_nir.cpp

IIRC, designated initializers are not legal C++. Fixes the MSVC build. Fixes: 83fd1e58 ("glsl/nir: Add and use a gl_nir_link() function") --- src/mesa/state_tracker/st_glsl_to_nir.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mesa/state_tracker/st_glsl_to_nir.cpp

Re: [Mesa-dev] [PATCH 4/4] scons: Make GCC builds stricter.

For the series, Reviewed-by: Brian Paul On 08/27/2019 04:57 AM, Jose Fonseca wrote: Uses some of the same -Werror options used by Meson, as suggested by Michel Daezer. --- scons/gallium.py | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/scons/gallium.py b/scons

Re: [Mesa-dev] [PATCH] st/mesa: don't allocate mipmapped texture for NEAREST_MIPMAP_LINEAR

Reviewed-by: Brian Paul On 08/10/2019 10:14 AM, Marek Olšák wrote: Ping On Fri., Aug. 2, 2019, 19:13 Marek Olšák, <mailto:mar...@gmail.com>> wrote: From: Marek Olšák mailto:marek.ol...@amd.com>> ---  src/mesa/state_tracker/st_cb_texture.c | 12 ++

Re: [Mesa-dev] [PATCH] gallivm: fix issue with AtomicCmpXchg wrapper on llvm 3.5-3.8

be moved into the body of LLVMBuildAtomicCmpXchg() so the whole function isn't duplicated? Other than that, Reviewed-by: Brian Paul ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] Mesa (update-reviewers-for-vmware): i965/clear: clear_value better precision

On 08/02/2019 09:56 AM, Eric Engestrom wrote: On Friday, 2019-08-02 17:50:17 +0200, Michel Dänzer wrote: On 2019-08-02 5:37 p.m., Brian Paul wrote: Ugh, I didn't mean to do this.  I'm trying to figure out how to make a merge request with gitlab. Just push to a branch in your personal

Re: [Mesa-dev] Mesa (update-reviewers-for-vmware): i965/clear: clear_value better precision

Ugh, I didn't mean to do this. I'm trying to figure out how to make a merge request with gitlab. -Brian On 08/02/2019 09:35 AM, GitLab Mirror wrote: Module: Mesa Branch: update-reviewers-for-vmware Commit: a86eccfb78092493b3999849db62613838951756 URL:

Re: [Mesa-dev] [PATCH] gallivm: fix a missing argument to CreateAtomicCmpXchg

ing), + mapFromLLVMOrdering(FailureOrdering), SingleThread ? llvm::SynchronizationScope::SingleThread : llvm::SynchronizationScope::CrossThread)); } #endif Reviewed-by: Brian P

Re: [Mesa-dev] [PATCH 1/2] nir/loop_analyze: used nir_alu_src to track loop limit

On 06/19/2019 02:08 AM, Timothy Arceri wrote: This helps reduce the amount of abstraction in this pass and allows us to retain more information about the src such as any swizzles. Retaining the swizzle information is required for a bugfix in the following patch. Fixes: 6772a17acc8e ("nir: Add a

Re: [Mesa-dev] [PATCH] nir: silence three compiler warnings seen with MinGW

Ping. -Brian On 05/20/2019 07:36 AM, Brian Paul wrote: Silence two unused var warnings. And init elem_size, elem_align to zero to silence "maybe uninitialized" warnings. --- src/compiler/nir/nir_lower_int_to_float.c | 2 +- src/compiler/nir/nir_opt_copy_prop_vars.c | 4 +--- sr

Re: [Mesa-dev] Mesa (master): glsl: do not use deprecated bison-keyword

On 05/23/2019 02:48 AM, Erik Faye-Lund wrote: On Wed, 2019-05-22 at 18:06 +0200, Akim Demaille wrote: Hi Erik, Le 22 mai 2019 à 08:54, Erik Faye-Lund < erik.faye-l...@collabora.com> a écrit : I ended up reverting the change [from-%error-verbose to %define parse.error verbose] , and I can't

Re: [Mesa-dev] Mesa (master): glsl: do not use deprecated bison-keyword

I think this change broke the MSVC build for us. I may not have time to investigate until later today. -Brian On 05/21/2019 05:41 AM, GitLab Mirror wrote: Module: Mesa Branch: master Commit: eb85124a9f6e9cb94d0d4a99f91bbae374777e3a URL:

Re: [Mesa-dev] [PATCH 2/2] mesa: unreference current winsys buffers when unbinding winsys buffers

Both look OK to me. Do they need to be tagged with "Cc: mesa-sta...@lists.freedesktop.org" for the stable branches? Reviewed-by: Brian Paul On 05/18/2019 07:46 PM, Charmaine Lee wrote: This fixes surface leak when no winsys buffers are bound. --- src/mesa/main/context.c | 4 +++

[Mesa-dev] [PATCH] nir: silence three compiler warnings seen with MinGW

Silence two unused var warnings. And init elem_size, elem_align to zero to silence "maybe uninitialized" warnings. --- src/compiler/nir/nir_lower_int_to_float.c | 2 +- src/compiler/nir/nir_opt_copy_prop_vars.c | 4 +--- src/compiler/nir_types.cpp| 2 +- 3 files changed, 3

[Mesa-dev] [PATCH] svga: clamp max_const_buffers to SVGA_MAX_CONST_BUFS

In case the device reports 15 (or more) buffers. --- src/gallium/drivers/svga/svga_screen.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/gallium/drivers/svga/svga_screen.c b/src/gallium/drivers/svga/svga_screen.c index 02c1a99..b70fd85 100644 ---

Re: [Mesa-dev] [PATCH 0/6] Update mesa state handling past VAO changes.

The series LGTM. Reviewed-by: Brian Paul On 05/12/2019 07:05 AM, mathias.froehl...@gmx.net wrote: From: Mathias Fröhlich Hi Brian, The series is a collection of comment updates and state handling cleanup past the VAO changes that went into mesa. There are two fixes for potential bugs

[Mesa-dev] [PATCH] st/mesa: fix uninitialized lower_flrp_progress variable

The 'progress' variable is initialized to false in other locations. This fixes a new Coverity warning. --- src/mesa/state_tracker/st_glsl_to_nir.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mesa/state_tracker/st_glsl_to_nir.cpp

Re: [Mesa-dev] [PATCH] gallivm: fix broken 8-wide s3tc decoding

LGTM. Just two little nits below. Reviewed-by: Brian Paul Perhaps you could review the 5-patch series of clean-ups I posted on Saturday? On 05/06/2019 06:12 PM, srol...@vmware.com wrote: From: Roland Scheidegger Brian noticed there was an uninitialized var for the 8-wide case and 128

[Mesa-dev] [PATCH 2/5] ddebug: fix a few MSVC compiler warnings

Don't return an expression in void functions. Replace an unsigned int with proper enum. --- src/gallium/auxiliary/driver_ddebug/dd_context.c | 15 --- src/gallium/auxiliary/driver_ddebug/dd_screen.c | 2 +- 2 files changed, 9 insertions(+), 8 deletions(-) diff --git

[Mesa-dev] [PATCH 1/5] glsl: s/GLboolean/bool/ to silence MSVC compiler warning

It complains about mixing GLboolean and bool in the |= expression. --- src/compiler/glsl/glsl_parser_extras.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/compiler/glsl/glsl_parser_extras.cpp b/src/compiler/glsl/glsl_parser_extras.cpp index d99ab3d..41f2a97 100644

[Mesa-dev] [PATCH 4/5] gallium/pp: s/uint/enum tgsi_semantic/ to fix MSVC warning

--- src/gallium/auxiliary/postprocess/pp_program.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/auxiliary/postprocess/pp_program.c b/src/gallium/auxiliary/postprocess/pp_program.c index 52786de..4cd3990 100644 ---

[Mesa-dev] [PATCH 3/5] noop: s/enum pipe_transfer_usage/unsigned/ to fix MSVC warning

The function pointer declaration in pipe_context uses unsigned for the bitmask. --- src/gallium/auxiliary/driver_noop/noop_pipe.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/auxiliary/driver_noop/noop_pipe.c b/src/gallium/auxiliary/driver_noop/noop_pipe.c

[Mesa-dev] [PATCH 5/5] gallium/util: fix two MSVC compiler warnings

Remove stray const qualifier. s/unsigned/enum tgsi_semantic/ --- src/gallium/auxiliary/util/u_format_zs.h | 2 +- src/gallium/auxiliary/util/u_simple_shaders.c | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/gallium/auxiliary/util/u_format_zs.h

[Mesa-dev] [PATCH] nir/algebraic: Don't emit empty arrays for MSVC

Just don't emit the transform array at all if there are no transforms for a state, and avoid trying to walk over it. Original patch by Connor Abbott. Updated with suggestions by Dylan Baker. --- src/compiler/nir/nir_algebraic.py | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff

Re: [Mesa-dev] [PATCH 03/10] mesa: Implement _mesa_array_element by walking enabled arrays.

On 05/02/2019 11:18 PM, Mathias Fröhlich wrote: Hi Brian, On Friday, 3 May 2019 00:17:51 CEST Brian Paul wrote: On 05/02/2019 03:27 AM, mathias.froehl...@gmx.net wrote: From: Mathias Fröhlich In glArrayElement, use the bitmask trick to just walk the enabled vao arrays. This should be about

Re: [Mesa-dev] [PATCH 03/10] mesa: Implement _mesa_array_element by walking enabled arrays.

pings[MAP_INTERNAL].Pointer, + _mesa_vertex_attrib_address(array, binding)) + + elt * binding->Stride; + return src; +} Could you add some brief comments on those functions to explain what they do? Otherwise, for the rest of the series, Reviewed-by: Brian Paul Nice work!! -Brian + + voi

Re: [Mesa-dev] [PATCH 01/10] mesa: Factor out index function that will have multiple use.

On 05/02/2019 03:27 AM, mathias.froehl...@gmx.net wrote: From: Mathias Fröhlich For access to glArrayElement methods factor out a function to get the table lookup index for normalized/integer/double access. The function will be used in the next patch at least twice. Signed-off-by: Mathias

Re: [Mesa-dev] [PATCH 02/10] mesa: Use glVertexAttrib*NV functions for fixed function attribs.

. By that use a loop to walk the attributes. I'm not sure I understand that last sentence. The code looks fine. Reviewed-by: Brian Paul Signed-off-by: Mathias Fröhlich --- src/mesa/main/api_arrayelt.c | 185 ++- 1 file changed, 28 insertions(+), 157 deletions

Re: [Mesa-dev] [PATCH] nir/algebraic: Don't emit empty initializers for MSVC

On 05/02/2019 02:34 PM, Connor Abbott wrote: Just don't emit the transform array at all if there are no transforms for a state, and avoid trying to walk over it. --- Brian, does this build on Windows? I tested it on my shader-db on radeonsi. Yes, it compiles. Thanks! Tested-by: Brian Paul

Re: [Mesa-dev] [PATCH] nir: don't emit empty initializers for MSVC

to access it. Hmm, any ideas for how to fix this? -Brian Running piglit with i965, or radeonsi will reproduce the crash. On Thu, May 2, 2019 at 7:52 PM Brian Paul <mailto:bri...@vmware.com>> wrote: This fixes a build failure with MSVC. --- I've compiled tested thi

[Mesa-dev] [PATCH] nir: don't emit empty initializers for MSVC

This fixes a build failure with MSVC. --- I've compiled tested this, but not sure how to runtime test it. --- src/compiler/nir/nir_algebraic.py | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/compiler/nir/nir_algebraic.py b/src/compiler/nir/nir_algebraic.py index 6db749e..dc25421

[Mesa-dev] [PATCH 1/2] svga: move host logging to winsys

From: Charmaine Lee This patch adds a host_log interface to svga_winsys and moves the host logging code to the winsys layer. Reviewed-by: Brian Paul --- src/gallium/drivers/svga/Makefile.sources | 2 - src/gallium/drivers/svga/meson.build | 1 - src/gallium/drivers/svga

[Mesa-dev] [PATCH 2/2] svga: add SVGA_NO_LOGGING env var (v2)

valgrind crashes when we try to initialize host logging. This env var can be used to disable logging. v2: rebase onto "svga: move host logging to winsys". Cc: mesa-sta...@lists.freedesktop.org --- docs/envvars.html | 3 +++ src/gallium/drivers/svga/svga_screen.c | 16

[Mesa-dev] [PATCH] glsl: work around MinGW 7.x compiler bug

I'm not sure what triggered this, but building with scons platform=windows toolchain=crossmingw machine=x86 build=profile with MinGW g++ 7.3 or 7.4 causes an internal compiler error. We can work around it by forcing -O1 optimization. --- src/compiler/glsl/builtin_variables.cpp | 15

[Mesa-dev] [PATCH] llvmpipe: init some vars to NULL to silence MinGW compiler warnings

--- src/gallium/auxiliary/gallivm/lp_bld_format_s3tc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/gallium/auxiliary/gallivm/lp_bld_format_s3tc.c b/src/gallium/auxiliary/gallivm/lp_bld_format_s3tc.c index 9561c34..90b2be9 100644 ---

[Mesa-dev] [PATCH] svga: add SVGA_NO_LOGGING env var

valgrind crashes when we try to initialize host logging. This env var can be used to disable logging. Cc: mesa-sta...@lists.freedesktop.org --- docs/envvars.html | 3 +++ src/gallium/drivers/svga/svga_screen.c | 4 +++- 2 files changed, 6 insertions(+), 1 deletion(-) diff

Re: [Mesa-dev] [PATCH 1/5] winsys/svga: Add an environment variable to force host-backed operation

The series looks good to me. Reviewed-by: Brian Paul On 04/30/2019 05:04 AM, Thomas Hellstrom wrote: The vmwgfx kernel module has a compatibility mode for user-space that is not guest-backed resource aware. Add an environment variable to facilitate testing of this mode on guest-backed aware

Re: [Mesa-dev] [PATCH 1/3] pipebuffer: use new pb_usage_flags enum type

It was committed in early March: b286e74df66e25cadd1c82d9ddc4d1fc3887b646 -Brian On 04/23/2019 07:25 AM, Thomas Hellstrom wrote: Hi, Brian, Did this series get reviewed? I don't see any replies? /Thomas On Tue, 2019-03-05 at 20:48 -0700, Brian Paul wrote: Use a new enum type instead

Re: [Mesa-dev] [PATCH] gallivm: fix saturated signed add / sub with llvm 9

th llvm's ability to recognize the pattern but seems * a bit brittle. + * NOTE: llvm 9+ always uses (non arch specific) intrinsic. */ LLVMValueRef no_ov = lp_build_cmp(bld, PIPE_FUNC_GREATER, a, b); a = lp_build_select(bld, no_ov, a, b); LGTM

Re: [Mesa-dev] [PATCH] gallivm: fix bogus assert in get_indirect_index

the buffer size. */ if (reg_file != TGSI_FILE_CONSTANT) { - assert(index_limit > 0); + assert(index_limit >= 0); max_index = lp_build_const_int_vec(bld->bld_base.base.gallivm, uint_bld->type, index_limit); Review

Re: [Mesa-dev] [PATCH] [rfc] st/mesa: don't update fb state is raster discard is set.

On 04/10/2019 12:10 AM, Dave Airlie wrote: From: Dave Airlie This avoid softpipe trying to get image when no window has ever been exposed, and no image will be exposed. I'm not entirely sure this is correct or useful, but it definitely helps with some softpipe get images when we haven't got a

Re: [Mesa-dev] [PATCH] haiku: Fix hgl dispatch build. Tested under meson/scons.

9 100644 > --- a/src/hgl/GLDispatcher.h > +++ b/src/hgl/GLDispatcher.h > @@ -15,7 +15,7 @@ > #include > #include > > -#include "glheader.h" > +#include "main/glheader.h" > > #include "glapi/glapi.h" > > -- Looks OK to me. Revi

Re: [Mesa-dev] [PATCH] util: no-op __builtin_types_compatible_p() for non-GCC compilers

On 03/29/2019 12:58 PM, Ian Romanick wrote: On 3/29/19 9:57 AM, Brian Paul wrote: __builtin_types_compatible_p() is GCC-specific and breaks the MSVC build. This intrinsic has been in u_vector_foreach() for a long time, but that macro has only recently been used in code (nir

[Mesa-dev] [PATCH] util: no-op __builtin_types_compatible_p() for non-GCC compilers

__builtin_types_compatible_p() is GCC-specific and breaks the MSVC build. This intrinsic has been in u_vector_foreach() for a long time, but that macro has only recently been used in code (nir/nir_opt_comparison_pre.c) that's built with MSVC. Fixes: 2cf59861a ("nir: Add partial redundancy

Re: [Mesa-dev] [PATCH] softpipe: fix clears to only clear specified color buffers.

oftpipe->framebuffer.nr_cbufs; i++) { - sp_tile_cache_clear(softpipe->cbuf_cache[i], color, 0); + if (buffers & (PIPE_CLEAR_COLOR0 << i)) +sp_tile_cache_clear(softpipe->cbuf_cache[i], color, 0); } }

Re: [Mesa-dev] [PATCH] [rfc] draw/vs: partly fix basevertex/vertex id

.i[j] = basevertex; } if (shader->info.uses_vertexid_nobase) { unsigned vid = machine->SysSemanticToIndex[TGSI_SEMANTIC_VERTEXID_NOBASE]; Reviewed-by: Brian Paul ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH] st/mesa: fix texture deletion context mix-up issues (v2)

binds the context as the current one. If the contexts textures are not shared, they'll be deleted. If they are shared, they won't be deleted. I think that part is fairly straight-forward. -Brian Jose *From:* Brian

Re: [Mesa-dev] [PATCH] draw/gs: fix point size outputs from geometry shader.

stage->point( stage, header ); Reviewed-by: Brian Paul ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH] draw: bail instead of assert on instance count (v2)

assert(draw->pt.user.elts); Reviewed-by: Brian Paul ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [PATCH] st/mesa: fix texture deletion context mix-up issues (v2)

When we destroy a context, we need to temporarily make that context the current one for the thread. That's because during context tear-down we make many calls to _mesa_reference_texobj(, NULL). Note there's no context parameter. If the texture's refcount goes to zero and we need to delete it,

[Mesa-dev] [PATCH] nir: fix a few signed/unsigned comparison warnings

--- src/compiler/nir_types.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/compiler/nir_types.cpp b/src/compiler/nir_types.cpp index aff575c..3bf93c5 100644 --- a/src/compiler/nir_types.cpp +++ b/src/compiler/nir_types.cpp @@ -690,7 +690,7 @@

[Mesa-dev] [PATCH] st/mesa: fix texture deletion context mix-up issues

When we destroy a context, we need to temporarily make that context the current one for the thread. That's because during context tear-down we make many calls to _mesa_reference_texobj(, NULL). Note there's no context parameter. If the texture's refcount goes to zero and we need to delete it,

Re: [Mesa-dev] [PATCH 1/2] softpipe: fix 32-bit bitfield extract

All four patches look good to me Reviewed-by: Brian Paul On 03/20/2019 10:16 PM, Dave Airlie wrote: From: Dave Airlie These didn't deal with the width == 32 case that TGSI is defined with. Fixes piglit tests if ARB_gpu_shader5 is enabled. --- src/gallium/auxiliary/tgsi/tgsi_exec.c | 14

Re: [Mesa-dev] [PATCH] softpipe: fix texture view crashes

ce->format, +(float *) tc->tile->data.color); } } numCleared++; Reviewed-by: Brian Paul ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [PATCH] st/mesa: implement "zombie" sampler views (v2)

When st_texture_release_all_sampler_views() is called the texture may have sampler views belonging to several contexts. If we unreference a sampler view and its refcount hits zero, we need to be sure to destroy the sampler view with the same context which created it. This was not the case with

Re: [Mesa-dev] [PATCH 1/8] st/mesa: implement "zombie" sampler views

On 03/15/2019 09:54 AM, Jose Fonseca wrote: On 14/03/2019 19:37, Brian Paul wrote: When st_texture_release_all_sampler_views() is called the texture may have sampler views belonging to several contexts.  If we unreference a sampler view and its refcount hits zero, we need to be sure to destroy

[Mesa-dev] [PATCH 2/8] st/mesa: implement "zombie" shaders list

As with the preceding patch for sampler views, this patch does basically the same thing but for shaders. However, reference counting isn't needed here (instead of calling cso_delete_XXX_shader() we call st_save_zombie_shader(). The Redway3D Watch is one app/demo that needs this change.

[Mesa-dev] [PATCH 6/8] swr: remove call to pipe_sampler_view_release()

As with svga, llvmpipe drivers in previous patches. Compile tested only. --- src/gallium/drivers/swr/swr_state.cpp | 5 - 1 file changed, 5 deletions(-) diff --git a/src/gallium/drivers/swr/swr_state.cpp b/src/gallium/drivers/swr/swr_state.cpp index d7baa71..42d196f 100644 ---

[Mesa-dev] [PATCH 5/8] llvmpipe: stop using pipe_sampler_view_release()

This was used to avoid freeing a sampler view which was created by a context that was already deleted. But the state tracker does not allow that. --- src/gallium/drivers/llvmpipe/lp_state_sampler.c | 6 -- 1 file changed, 6 deletions(-) diff --git

[Mesa-dev] [PATCH 3/8] st/mesa: stop using pipe_sampler_view_release()

In all instances here we can replace pipe_sampler_view_release(pipe, view) with pipe_sampler_view_reference(view, NULL) because the views in question are private to the state tracker context. So there's no danger of freeing a sampler view with the wrong context. Testing done: google chrome, misc

[Mesa-dev] [PATCH 1/8] st/mesa: implement "zombie" sampler views

When st_texture_release_all_sampler_views() is called the texture may have sampler views belonging to several contexts. If we unreference a sampler view and its refcount hits zero, we need to be sure to destroy the sampler view with the same context which created it. This was not the case with

[Mesa-dev] [PATCH 8/8] gallium/util: remove pipe_sampler_view_release()

It's no longer used. --- src/gallium/auxiliary/util/u_inlines.h | 20 1 file changed, 20 deletions(-) diff --git a/src/gallium/auxiliary/util/u_inlines.h b/src/gallium/auxiliary/util/u_inlines.h index fa1e920..567d3d0 100644 --- a/src/gallium/auxiliary/util/u_inlines.h +++

[Mesa-dev] [PATCH 4/8] svga: stop using pipe_sampler_view_release()

This function was used in the past to avoid deleting a sampler view for a context that no longer exists. But the Mesa state tracker ensures that cannot happen. Use the standard refcounting function instead. Also, remove the code which checked for context mis-matches in

  1   2   3   4   5   6   7   8   9   10   >