Re: [Mesa-dev] [PATCH] Typo: ammount -> amount

Reviewed-by: Edward O'Callaghan <funfunc...@folklore1984.net> On 04/23/2017 11:13 PM, Giuseppe Bilotta wrote: > --- > src/compiler/nir/nir_array.h | 2 +- > src/compiler/spirv/spirv_to_nir.c | 2 +- > src/gallium/winsys/svga/drm/vmw_context.c | 2 +- >

Re: [Mesa-dev] [PATCH 00/11] some GLSL cleanups

Series is, Reviewed-by: Edward O'Callaghan <funfunc...@folklore1984.net> On 04/21/2017 08:44 PM, Samuel Iglesias Gonsálvez wrote: > Series is, > > Reviewed-by: Samuel Iglesias Gonsálvez <sigles...@igalia.com> > > Sam > > On Fri, 2017-04-21 at 1

Re: [Mesa-dev] [PATCH 2/2] glsl: get rid of values_for_type()

Reviewed-by: Edward O'Callaghan <funfunc...@folklore1984.net> On 04/21/2017 11:20 AM, Timothy Arceri wrote: > Looks ok to me. Series: > > Reviewed-by: Timothy Arceri <tarc...@itsqueeze.com> > ___ > mesa-dev mailing list >

Re: [Mesa-dev] [PATCH v3] radv: Use host memory pool for non-freeable descriptors.

Acked-by: Edward O'Callaghan <funfunc...@folklore1984.net> On 04/19/2017 09:53 AM, Bas Nieuwenhuizen wrote: > v2: Handle out of pool memory error. > v3: Actually use VK_ERROR_OUT_OF_POOL_MEMORY_KHR for the error condition. > > Signed-off-by: Bas Nieuwenhuizen <ba...@google.

Re: [Mesa-dev] [PATCH 3/3] st/mesa: enable ARB_parallel_shader_compile

On 04/18/2017 09:01 PM, Nicolai Hähnle wrote: > On 17.04.2017 14:07, Edward O'Callaghan wrote: >> Signed-off-by: Edward O'Callaghan <funfunc...@folklore1984.net> >> --- >> docs/features.txt | 2 +- >> src/mesa/state_tracker/st_extensio

Re: [Mesa-dev] [PATCH 2/3] mesa: implement ARB_parallel_shader_compile

On 04/18/2017 03:39 PM, Jason Ekstrand wrote: > On Mon, Apr 17, 2017 at 4:49 PM, Edward O'Callaghan > <funfunc...@folklore1984.net <mailto:funfunc...@folklore1984.net>> wrote: > > > > On 04/18/2017 01:13 AM, Jason Ekstrand wrote: > > I don'

Re: [Mesa-dev] [PATCH] gallium/targets: fix bool setting on BE architectures

rgets/pipe-loader/pipe_radeonsi.c >> +++ b/src/gallium/targets/pipe-loader/pipe_radeonsi.c >> @@ -26,7 +26,7 @@ static const struct drm_conf_ret throttle_ret = { >> >> static const struct drm_conf_ret share_fd_ret = { >> .type = DRM_CONF_BOOL, >> -

Re: [Mesa-dev] Draft ARB_parallel_shader_compile RFC

this? I'm pretty sure the > MaxShaderCompilerThreadsARB entrypoint is unreachable. Ah yes, I tested the query but couldn't get that hooked up. How can I get it to become part of the dispatch table? > > On Mon, Apr 17, 2017 at 8:07 AM, Edward O'Callaghan > <funfunc...@folklore1984.net> wro

Re: [Mesa-dev] [PATCH 2/3] mesa: implement ARB_parallel_shader_compile

f it does, the front-end > tends to take significant quantities of time so it'd be nice to > parallelize that. Indeed the frontend part I believe is where the remaining work is to be done. > > On Mon, Apr 17, 2017 at 5:07 AM, Edward O'Callaghan > <funfunc...@folklore1984.net <mail

[Mesa-dev] [PATCH 1/3] mesa: Add ARB_parallel_shader_compile boilerplate

Signed-off-by: Edward O'Callaghan <funfunc...@folklore1984.net> --- src/mesa/main/extensions_table.h | 1 + src/mesa/main/mtypes.h | 1 + 2 files changed, 2 insertions(+) diff --git a/src/mesa/main/extensions_table.h b/src/mesa/main/extensions_table.h index d11cb0f..58ac77a

[Mesa-dev] [PATCH 3/3] st/mesa: enable ARB_parallel_shader_compile

Signed-off-by: Edward O'Callaghan <funfunc...@folklore1984.net> --- docs/features.txt | 2 +- src/mesa/state_tracker/st_extensions.c | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/docs/features.txt b/docs/features.txt index 5f63632..4021fbc

[Mesa-dev] [PATCH 2/3] mesa: implement ARB_parallel_shader_compile

Signed-off-by: Edward O'Callaghan <funfunc...@folklore1984.net> --- src/mesa/main/get.c| 4 src/mesa/main/mtypes.h | 6 ++ src/mesa/main/shaderapi.c | 20 src/mesa/main/shaderapi.h | 3 +++ sr

[Mesa-dev] Draft ARB_parallel_shader_compile RFC

y threaded. Anyhoo I just wanted to get some feedback.. Please kindly review, Edward O'Callaghan (3): [PATCH 1/3] mesa: Add ARB_parallel_shader_compile boilerplate [PATCH 2/3] mesa: implement ARB_parallel_shader_compile [PATCH 3/3] st/mesa: enable ARB_parallel_shad

Re: [Mesa-dev] [PATCH] android: amd/addrlib: trivial fix for gfx9 support

or generated. >> >> Fixes: 7f160ef "amd/addrlib: import gfx9 support" > > Reviewed-by: Nicolai Hähnle <nicolai.haeh...@amd.com> Reviewed-by: Edward O'Callaghan <funfunc...@folklore1984.net> > >> --- >> src/amd/Android.addrlib.mk | 2

Re: [Mesa-dev] [PATCH] mesa: print target string in glBindTexture() error message

Reviewed-by: Edward O'Callaghan <funfunc...@folklore1984.net> On 04/15/2017 01:02 PM, Timothy Arceri wrote: > Reviewed-by: Timothy Arceri <tarc...@itsqueeze.com> > > On 15/04/17 04:42, Brian Paul wrote: >> --- >> src/mesa/main/texobj.c | 3 ++- >> 1 fi

Re: [Mesa-dev] [PATCH 0/5] gallium, radeonsi: enable ARB_shader_viewport_layer_array

This series is, Reviewed-by: Edward O'Callaghan <funfunc...@folklore1984.net> On 04/14/2017 06:30 AM, Nicolai Hähnle wrote: > Hi all, > > This is another small one, as the extension is mostly a merge of > AMD_vertex_shader_layer and AMD_vertex_shader_viewport_index, and >

Re: [Mesa-dev] [PATCH] gallium/radeon: never use staging buffers with AMD_pinned_memory

Reviewed-by: Edward O'Callaghan <funfunc...@folklore1984.net> On 04/13/2017 01:56 AM, Marek Olšák wrote: > Reviewed-by: Marek Olšák <marek.ol...@amd.com> > > Marek > > On Wed, Apr 12, 2017 at 12:44 PM, Nicolai Hähnle <nhaeh...@gmail.com> wrote: >> From:

Re: [Mesa-dev] [PATCH] radv: Enable query inheritance.

Acked-by: Edward O'Callaghan <funfunc...@folklore1984.net> On 04/13/2017 07:20 AM, Bas Nieuwenhuizen wrote: > timestamp and pipeline_statistics only do something on begin & end, > so they don't need any action. > > Occlusion queries only do something to enable/disable and

Re: [Mesa-dev] [PATCH 1/2] radv: Add occlusion query shader.

One trivial comment but otherwise 1&2 are, Reviewed-by: Edward O'Callaghan <funfunc...@folklore1984.net> On 04/10/2017 09:34 AM, Bas Nieuwenhuizen wrote: > Adds a shader for writing occlusion query results to a buffer, as the > CP packet isn't support on SI or secondary buff

Re: [Mesa-dev] [PATCH] amd/addrlib: use correct variable name in header

On 04/10/2017 12:31 PM, Thomas H.P. Andersen wrote: > On Sun, Apr 9, 2017 at 8:25 PM, Marek Olšák wrote: >> Reviewed-by: Marek Olšák >> >> Marek > > Thanks. I do not have commit access, so will need someone to push it for me. Done, thanks for the fix!

Re: [Mesa-dev] [PATCH 00/13] Better Travis-CI integration

On 04/08/2017 05:05 AM, Emil Velikov wrote: > Hi all, > > Inspired by the work from Andres, I've went ahead and made our > integration a bit better. Highlights include: > - run in container - faster startup times, always 2 cores > - removed unneeded packages > - "build everything" -

Re: [Mesa-dev] [PATCH] radv: move to using nir clip/cull merge pass.

Reviewed-by: Edward O'Callaghan <funfunc...@folklore1984.net> On 03/29/2017 04:14 PM, Dave Airlie wrote: > From: Dave Airlie <airl...@redhat.com> > > Doing this before tessellation makes doing some bits of > tessellation a bit cleaner. It also cleans up a bit of t

Re: [Mesa-dev] [PATCH v2] mesa/main: Fix memset in formatquery.c

On 03/27/2017 01:49 PM, Brian Paul wrote: > On Sun, Mar 26, 2017 at 5:51 PM, Edward O'Callaghan > <funfunc...@folklore1984.net <mailto:funfunc...@folklore1984.net>> wrote: > > V.1: > We memset number of elements without multiplication by the > elemen

Re: [Mesa-dev] [PATCH 2/2] radv: add external memory support.

On 03/17/2017 09:05 AM, Bas Nieuwenhuizen wrote: > On Wed, Mar 15, 2017 at 1:25 AM, Dave Airlie wrote: >> From: Dave Airlie >> >> This adds support for exporting 2D images, to an >> opaque fd. >> >> This implements the: >>

Re: [Mesa-dev] [PATCH] glsl, st/shader_cache: check the whole sha1 for zero

Reviewed-by: Edward O'Callaghan <funfunc...@folklore1984.net> On 03/27/2017 11:42 AM, Timothy Arceri wrote: > > > On 27/03/17 10:18, Grazvydas Ignotas wrote: >> On Sun, Mar 26, 2017 at 11:45 PM, Timothy Arceri >> <tarc...@itsqueeze.com> wrote: >>> &g

Re: [Mesa-dev] [PATCH 1/2] radv/formats: reverse how the image format properties KHR2 is handled

Patches 1&2 are, Reviewed-by: Edward O'Callaghan <funfunc...@folklore1984.net> On 03/15/2017 11:25 AM, Dave Airlie wrote: > From: Dave Airlie <airl...@redhat.com> > > This just aligns with how anv does it. > > Signed-off-by: Dave Airlie <airl...@r

[Mesa-dev] [PATCH v2] mesa/main: Fix memset in formatquery.c

V.1: We memset number of elements without multiplication by the element size. V.2: We explicitly set each member to -1 over using a confusing memset(). Signed-off-by: Edward O'Callaghan <funfunc...@folklore1984.net> --- src/mesa/main/formatquery.c | 2 +- 1 file changed, 1 insertion

Re: [Mesa-dev] [PATCH 1/6] mesa: inline _mesa_update_texture

This series is, Reviewed-by: Edward O'Callaghan <funfunc...@folklore1984.net> On 03/24/2017 10:42 AM, Marek Olšák wrote: > From: Marek Olšák <marek.ol...@amd.com> > > --- > src/mesa/main/state.c| 7 +-- > src/mesa/main/texstate.c | 22 --

Re: [Mesa-dev] [PATCH] mesa/marshal: add custom BufferData/BufferSubData marshalling

Acked-by: Edward O'Callaghan <funfunc...@folklore1984.net> On 03/23/2017 05:32 PM, Timothy Arceri wrote: > GL_AMD_pinned_memory requires memory to be aligned correctly, so > we skip marshalling in this case. Also copying the data defeats > the purpose of EXTERNAL_VIRTUAL_ME

Re: [Mesa-dev] [PATCH 00/18] Good bye pragma once

Reviewed-by: Edward O'Callaghan <funfunc...@folklore1984.net> Thanks for getting rid of them Emil. On 03/21/2017 03:12 AM, Emil Velikov wrote: > Hi all, > > We have a strange mix of pragma once vs ifndef guards in-tree. > > Since the former is less common, and conclud

[Mesa-dev] [PATCH] mesa/main: Fix memset in formatquery.c

We memset number of elements without multiplication by the element size. Signed-off-by: Edward O'Callaghan <funfunc...@folklore1984.net> --- src/mesa/main/formatquery.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mesa/main/formatquery.c b/src/mesa/main/formatq

Re: [Mesa-dev] [PATCH] radv: trivial tidy ups

Reviewed-by: Edward O'Callaghan <funfunc...@folklore1984.net> On 03/14/2017 03:50 PM, Timothy Arceri wrote: > --- > src/amd/vulkan/radv_pipeline.c | 6 +- > src/amd/vulkan/radv_pipeline_cache.c | 1 + > 2 files changed, 2 insertions(+), 5 deletions(-) > > dif

Re: [Mesa-dev] assorted uint/unsigned -> enum clean-ups

Totally forgot to look at doing this, thanks Brian for going though. Reviewed-by: Edward O'Callaghan <funfunc...@folklore1984.net> On 03/07/2017 01:08 PM, Brian Paul wrote: > Use gallium enum types in a bunch of places. > I compile tested most drivers, but not all. >

Re: [Mesa-dev] [PATCH] swr: enable clear_texture with util_clear_texture

Reviewed-by: Edward O'Callaghan <funfunc...@folklore1984.net> On 02/26/2017 02:09 PM, Bruce Cherniak wrote: > Passes corresponding piglit tests. > --- > src/gallium/drivers/swr/swr_context.cpp | 1 + > src/gallium/drivers/swr/swr_screen.cpp | 2 +- > 2 files changed, 2 inse

Re: [Mesa-dev] [PATCH] radv/ac: Add integer->integer casts.

Acked-by: Edward O'Callaghan <funfunc...@folklore1984.net> On 02/26/2017 12:39 PM, Bas Nieuwenhuizen wrote: > Signed-off-by: Bas Nieuwenhuizen <ba...@google.com> > --- > src/amd/common/ac_nir_to_llvm.c | 18 ++ > 1 file changed, 18 insertions(+) > &g

Re: [Mesa-dev] [PATCH v5] st/nine: Drop USER_INDEX_BUFFERS check

Very noisy but you got there in the end, Reviewed-by: Edward O'Callaghan <funfunc...@folklore1984.net> On 02/25/2017 10:50 PM, Mike Lothian wrote: > This fixes 4a883966c1f74f43afc145d2c3d27af7b8c5e01a where the > PIPE_CAP was removed. > > Now USER_INDEX_BUFFERS are alw

Re: [Mesa-dev] [PATCH v4] st/nine: Drop USER_INDEX_BUFFERS check

eedesktop.org/show_bug.cgi?id=99953 > Reported-and-tested-by: Vinson Lee <v...@freedesktop.org> (v1) > Cc: Marek Olšák <marek.ol...@amd.com> > Cc: Axel Davy <axel.d...@ens.fr> > Signed-off-by: Mike Lothian <m...@fireburn.co.uk> > Signed-off-by: Edward O'Callaghan

Re: [Mesa-dev] [PATCH] st/nine: Drop USER_INDEX_BUFFERS check

oh yes I missed that, you want to have drop the negation in your patch Mike. On 02/25/2017 10:28 PM, Mike Lothian wrote: > I think my question regarding the double negative still stands. Is it > "!This->cmst_active" ot "This->cmst_active" > > On Sat, 2

Re: [Mesa-dev] [PATCH] gallium/nine: Fix build regression

yes sorry disregard this one, I got report this independently. sorry for the noise. On 02/25/2017 10:18 PM, Mike Lothian wrote: > Are we better off just checking for cmst_active now? Since that's all > we're checking > > On Sat, 25 Feb 2017 at 11:12 Edward O'Callaghan > <funfu

[Mesa-dev] [PATCH] st/nine: Drop USER_INDEX_BUFFERS check

desktop.org> (v1) Cc: Marek Olšák <marek.ol...@amd.com> Cc: Axel Davy <axel.d...@ens.fr> Signed-off-by: Mike Lothian <m...@fireburn.co.uk> Signed-off-by: Edward O'Callaghan <funfunc...@folklore1984.net> --- src/gallium/state_trackers/nine/device9.c | 3 +-- src/gallium/s

[Mesa-dev] [PATCH] gallium/nine: Fix build regression

commit 4a88396 dropped 'PIPE_CAP_USER_INDEX_BUFFERS' however this case was missed. Signed-off-by: Edward O'Callaghan <funfunc...@folklore1984.net> --- src/gallium/state_trackers/nine/device9.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/state_tracker

Re: [Mesa-dev] [PATCH] doc: GL_ARB_buffer_storage is supported on llvmpipe/swr

Acked-by: Edward O'Callaghan <funfunc...@folklore1984.net> On 02/25/2017 07:45 AM, Gregory Hainaut wrote: > At least, the extension is exported (gallium capability > PIPE_CAP_BUFFER_MAP_PERSISTENT_COHERENT is 1) > > Signed-off-by: Gregory Hainaut <gregory.hain...@gma

Re: [Mesa-dev] [PATCH 1/2] st/mesa: fix crash in shader cache cased by race condition

1&2 are, Reviewed-by: Edward O'Callaghan <funfunc...@folklore1984.net> On 02/23/2017 02:59 PM, Timothy Arceri wrote: > If a thread doesn't load GLSL IR from cache but does load TGSI > from cache (that was created by another thread) than it will > crash due to expecting gl_pro

Re: [Mesa-dev] [PATCH] radeon: fix r600 builds when old version of llvm is present

Reviewed-by: Edward O'Callaghan <funfunc...@folklore1984.net> On 02/23/2017 01:37 PM, Timothy Arceri wrote: > --- > src/gallium/drivers/radeon/r600_pipe_common.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/src/gallium/drivers/radeon/r600_p

Re: [Mesa-dev] [PATCH 1/4 v3] gallium: implement util_clear_texture

On 02/23/2017 12:52 PM, Roland Scheidegger wrote: > For the series: > Reviewed-by: Roland Scheidegger <srol...@vmware.com> Reviewed-by: Edward O'Callaghan <funfunc...@folklore1984.net> > > (I'll commit this tomorrow). > > Roland > > Am 22.02.2017 um 1

Re: [Mesa-dev] [PATCH 4/4] mesa: Avoid out-of-bounds stack read via _mesa_Materiali

indeed 1, 3 & 4 - good catches, Reviewed-by: Edward O'Callaghan <funfunc...@folklore1984.net> On 02/23/2017 07:29 AM, Marek Olšák wrote: > For 1, 3, 4: > > Reviewed-by: Marek Olšák <marek.ol...@amd.com> > > I need some time to review patch 2 unless someone

[Mesa-dev] [PATCH v3] radeonsi, r600g: Alias 'R600_DEBUG' with 'RADEON_DEBUG'

The name has become a little misleading now that it applies to both r600g and radeonsi. V.2: Michel Dänzer - R600_DEBUG must continue to work. V.3: fixup missed case in V.2. Signed-off-by: Edward O'Callaghan <funfunc...@folklore1984.net> --- src/gallium/drivers/r600/r600_pipe.c

Re: [Mesa-dev] V4 TGSI on-disk shader cache

The rest of this series is, Reviewed-by: Edward O'Callaghan <funfunc...@folklore1984.net> On 02/22/2017 02:45 PM, Timothy Arceri wrote: > Changes in V4: > > - split tgsi cache code into its own file > - add missing fallback for tgsi cache miss > - share the sha1 generated

Re: [Mesa-dev] [PATCH 1/2] vulkan/wsi: move image count to shared structure.

wait, why is this needed at all Dave? The application should be querying and picking the correct GPU as you well know. This seems unwise to tamper with the mechanism defined by the specification. Kindly, Edward. On 02/21/2017 01:47 PM, Jason Ekstrand wrote: > Fine by me > > Reviewed-by: Jason

Re: [Mesa-dev] [PATCH 1/3] radv/ac: rename num clips/cull to output clips/culls

This series is, Reviewed-by: Edward O'Callaghan <funfunc...@folklore1984.net> On 02/21/2017 03:14 PM, Dave Airlie wrote: > From: Dave Airlie <airl...@redhat.com> > > As geom shaders can have different ones on entry and exit. > > also move to uint8_t as these are neve

Re: [Mesa-dev] [PATCH V4 4/4] r600/radeonsi: enable glsl/tgsi on-disk cache

Reviewed-by: Edward O'Callaghan <funfunc...@folklore1984.net> On 02/21/2017 05:10 PM, Timothy Arceri wrote: > For gpu generations that use LLVM we create a timestamp string > containing both the LLVM and Mesa build times, otherwise we just > use the Mesa build time. >

Re: [Mesa-dev] [PATCH V2 3.5/4] st/mesa: get on-disk shader cache

Reviewed-by: Edward O'Callaghan <funfunc...@folklore1984.net> On 02/21/2017 02:18 PM, Timothy Arceri wrote: > V2: make sure callback exists before calling it > --- > src/mesa/state_tracker/st_context.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git

Re: [Mesa-dev] [PATCH v2] radeonsi: handle MultiDrawIndirect in si_get_draw_start_count

v2 is, Acked-by: Edward O'Callaghan <funfunc...@folklore1984.net> On 02/21/2017 09:05 AM, Nicolai Hähnle wrote: > From: Nicolai Hähnle <nicolai.haeh...@amd.com> > > Also handle the GL_ARB_indirect_parameters case where the count itself > is in a buffer. > > Use

Re: [Mesa-dev] [PATCH v2] radeonsi, r600g: Alias 'R600_DEBUG' with 'RADEON_DEBUG'

On 02/20/2017 10:41 PM, Gustaw Smolarczyk wrote: > 2017-02-20 11:19 GMT+01:00 Edward O'Callaghan <funfunc...@folklore1984.net>: >> >> On 02/20/2017 09:15 PM, Edward O'Callaghan wrote: >>> The name has become a little misleading now that it applies >>>

Re: [Mesa-dev] [PATCH v2] radeonsi, r600g: Alias 'R600_DEBUG' with 'RADEON_DEBUG'

On 02/20/2017 09:15 PM, Edward O'Callaghan wrote: > The name has become a little misleading now that it applies > to both r600g and radeonsi. > > V.2: Michel Dänzer - R600_DEBUG must continue to work. > > Signed-off-by: Edward O'Callaghan <funfunc...@folklore1984.net&

[Mesa-dev] [PATCH v2] radeonsi, r600g: Alias 'R600_DEBUG' with 'RADEON_DEBUG'

The name has become a little misleading now that it applies to both r600g and radeonsi. V.2: Michel Dänzer - R600_DEBUG must continue to work. Signed-off-by: Edward O'Callaghan <funfunc...@folklore1984.net> --- src/gallium/drivers/r600/r600_pipe.c | 1 + src/gallium/d

[Mesa-dev] [PATCH] radeonsi, r600g: Rename 'R600_DEBUG' -> 'RADEON_DEBUG'

The name has become a little misleading now that it applies to both r600g and radeonsi. Signed-off-by: Edward O'Callaghan <funfunc...@folklore1984.net> --- src/gallium/drivers/r600/r600_pipe.c | 2 +- src/gallium/drivers/radeon/r600_pipe_common.c | 2 +- src/g

Re: [Mesa-dev] [PATCH] radv: handle subpass cache flushes

Reviewed-by: Edward O'Callaghan <funfunc...@folklore1984.net> On 02/20/2017 04:17 PM, Dave Airlie wrote: > From: Dave Airlie <airl...@redhat.com> > > This splits out the cache flush bit setting code > dependent on the src/dest access flags. > > It then calls it

Re: [Mesa-dev] [PATCH 4/4] r600/radeonsi: enable glsl/tgsi on-disk cache

On 02/20/2017 11:15 AM, Timothy Arceri wrote: > --- > src/gallium/drivers/r600/r600_pipe.c | 19 +++ > src/gallium/drivers/radeon/r600_pipe_common.c | 8 +++- > src/gallium/drivers/radeon/r600_pipe_common.h | 5 + > src/gallium/drivers/radeonsi/si_pipe.c

Re: [Mesa-dev] [PATCH] radv: Invert ring SGPR check.

Acked-by: Edward O'Callaghan <funfunc...@folklore1984.net> On 02/19/2017 01:39 PM, Bas Nieuwenhuizen wrote: > I assume this wants to check if all pipelines use the same SGPR for > the rings. > > Signed-off-by: Bas Nieuwenhuizen <ba...@google.com> > --- > src/am

Re: [Mesa-dev] [PATCH 1/3] radeon/ac: add emit umsb shared code.

This series is, Reviewed-by: Edward O'Callaghan <funfunc...@folklore1984.net> On 02/16/2017 02:55 PM, Dave Airlie wrote: > From: Dave Airlie <airl...@redhat.com> > > Since we shared imsb, makes sense to share umsb. > > Signed-off-by: Dave Airlie <airl...@redha

Re: [Mesa-dev] [PATCH 1/4] radeon/ac: add ac_emit_imsb helper.

This series is, Reviewed-by: Edward O'Callaghan <funfunc...@folklore1984.net> On 02/16/2017 02:48 PM, Dave Airlie wrote: > From: Dave Airlie <airl...@redhat.com> > > We want to use a different intrinsic on newer llvm, so move this > code to a shared area. > > Si

Re: [Mesa-dev] [RFC] spec: MESA_program_binary

On 02/16/2017 01:52 PM, Timothy Arceri wrote: > In order add functionality to ARB_get_program_binary we need > binary format enums. > --- > > Techland games such as Dead Island and Dying Light make use of > GetProgramBinary(). My current guess is the Dead Island crash >

Re: [Mesa-dev] [PATCH] radv: query cmds should mark a cmd buffer as having draws.

Reviewed-by: Edward O'Callaghan <funfunc...@folklore1984.net> On 02/15/2017 11:00 AM, Dave Airlie wrote: > From: Dave Airlie <airl...@redhat.com> > > This fixes a regression with the remove non-draw cmd buffers in > queries. > > Fixes: 8b47b97215a radv: detect c

Re: [Mesa-dev] [PATCH 0/3] radv: Support image operations without format.

This series LGTM, Reviewed-by: Edward O'Callaghan <funfunc...@folklore1984.net> On 02/15/2017 11:36 AM, Bas Nieuwenhuizen wrote: > No regressions on CTS 1.0.2 mustpass, though I don't think there are > tests for these extensions. I checked there were no references to the > format i

Re: [Mesa-dev] [PATCH] radv: adopt some init config workarounds from radeonsi.

Reviewed-by: Edward O'Callaghan <funfunc...@folklore1984.net> On 02/14/2017 05:25 PM, Dave Airlie wrote: > From: Dave Airlie <airl...@redhat.com> > > Just one bonaire fix. > > Signed-off-by: Dave Airlie <airl...@redhat.com> > --- > src/amd/vulkan/si_

Re: [Mesa-dev] radv cik fixes

This series is, Reviewed-by: Edward O'Callaghan <funfunc...@folklore1984.net> On 02/14/2017 05:10 PM, Dave Airlie wrote: > Hey, > > This is a bunch of CIK fixes I found thanks to Lyude for remote > access to a test machine. > > The main one is 1/4, it changes the me

Re: [Mesa-dev] Time to merge threaded GL dispatch? (aka glthread)

rt glmark anyway, so the fix > will most likely be disabling multithreading on the fly than trying to > fix the crash. > > Marek > > > On Feb 10, 2017 12:58 PM, "Edward O'Callaghan" > <funfunc...@folklore1984.net <mailto:funfunc...@folklore1984.net>>

Re: [Mesa-dev] Time to merge threaded GL dispatch? (aka glthread)

On 02/10/2017 10:50 PM, Marek Olšák wrote: > On Fri, Feb 10, 2017 at 12:48 PM, Edward O'Callaghan > <funfunc...@folklore1984.net> wrote: >> >> >> On 02/10/2017 10:36 PM, Marek Olšák wrote: >>> On Fri, Feb 10, 2017 at 12:26 PM, Edward O'Callaghan

Re: [Mesa-dev] Time to merge threaded GL dispatch? (aka glthread)

On 02/10/2017 10:36 PM, Marek Olšák wrote: > On Fri, Feb 10, 2017 at 12:26 PM, Edward O'Callaghan > <funfunc...@folklore1984.net> wrote: >> >> >> On 02/08/2017 09:13 AM, Timothy Arceri wrote: >>> On Tue, 2017-02-07 at 10:56 +0100, Marek Olšák wrote: >&

Re: [Mesa-dev] Time to merge threaded GL dispatch? (aka glthread)

On 02/08/2017 09:13 AM, Timothy Arceri wrote: > On Tue, 2017-02-07 at 10:56 +0100, Marek Olšák wrote: >> On Tue, Feb 7, 2017 at 2:57 AM, Kenneth Graunke > g> wrote: >>> On Monday, February 6, 2017 8:54:40 PM PST Marek Olšák wrote: On Mon, Feb 6, 2017 at 8:20 PM, Ernst

Re: [Mesa-dev] [PATCH] radeon/ac: move common llvm build functions to a separate file.

Reviewed-by: Edward O'Callaghan <funfunc...@folklore1984.net> On 02/03/2017 11:05 AM, Dave Airlie wrote: > From: Dave Airlie <airl...@redhat.com> > > Suggested by Marek. > > Signed-off-by: Dave Airlie <airl...@redhat.com> > --- > src/amd/Makefile.sources

Re: [Mesa-dev] [PATCH] glsl: binding qualifier must match with opaque-uniforms only

Reviewed-by: Edward O'Callaghan <funfunc...@folklore1984.net> On 02/06/2017 05:53 AM, Andres Gomez wrote: > The binding point is a valid layout qualifier for Uniform Blocks, > Shader Storage Blocks and Opaque-Uniforms. > > From page 60 (page 66 of the PDF) of the G

Re: [Mesa-dev] [PATCH 0/8] radv: implement sparseBinding

From what I understand this series is, Reviewed-by: Edward O'Callaghan <funfunc...@folklore1984.net> A few rather trivial style bits to be fixed pertaining of space before '(', e.g., 'if(..)' -> 'if ('. On 02/05/2017 10:43 PM, Bas Nieuwenhuizen wrote: > This implements the sparseBin

Re: [Mesa-dev] [PATCH 0/2] RadeonSI: Use UMR for hang debugging

Thanks for getting this out to the wider community ! Patch 1 isn't the most ideal way to invocate the umr binary but I can't think of an immediately better solution. So, Patches 1 & 2 are, Reviewed-by: Edward O'Callaghan <funfunc...@folklore1984.net> On 02/05/2017 09:44 AM, Marek O

Re: [Mesa-dev] [RFC PATCH 1/1] st/dri: add a new driconf option override_glsl_version for ARK games

On 02/04/2017 05:48 AM, Bas Nieuwenhuizen wrote: > > On Fri, Feb 3, 2017, at 19:24, Jason Ekstrand wrote: >> On Fri, Feb 3, 2017 at 9:23 AM, Samuel Pitoiset >> > wrote: >> >> This is similar to the MESA_GLSL_VERSION_OVERRIDE

Re: [Mesa-dev] [PATCH] radv: fix compute shared memory stores since 64-bit.

Reviewed-by: Edward O'Callaghan <funfunc...@folklore1984.net> On 02/03/2017 12:04 PM, Dave Airlie wrote: > From: Dave Airlie <airl...@redhat.com> > > These regressed and caused doom to stop loading. > > Fixes: > 03724af26 radv/ac: Implement Float64 load/store

Re: [Mesa-dev] [PATCH] radv/ac: correctly size shared memory usage.

Reviewed-by: Edward O'Callaghan <funfunc...@folklore1984.net> On 02/03/2017 12:47 PM, Dave Airlie wrote: > From: Dave Airlie <airl...@redhat.com> > > We count the number of slots used, but slots are vec4 sized, > so we have to scale by 16 not 4. > > Si

[Mesa-dev] [PATCH 1/3] ilo: EOL unplumb unmaintained gallium drv from winsys

This is no longer actively maintained and is just accumulating bitrot. Signed-off-by: Edward O'Callaghan <funfunc...@folklore1984.net> --- .../auxiliary/pipe-loader/pipe_loader_drm.c| 5 --- src/gallium/auxiliary/target-helpers/drm_helper.h | 29 - src/gallium/targe

[Mesa-dev] [PATCH 3/3] ilo: EOL unmaintained older gallium intel driver

This is no longer actively maintained and is just accumulating bitrot. Signed-off-by: Edward O'Callaghan <funfunc...@folklore1984.net> --- src/gallium/drivers/ilo/Android.mk | 35 - src/gallium/drivers/ilo/Automake.inc | 11 - src/gallium/drivers/ilo/Makef

[Mesa-dev] [PATCH 2/3] ilo: EOL drop unmaintained gallium drv from buildsys

This is no longer actively maintained and is just accumulating bitrot. Signed-off-by: Edward O'Callaghan <funfunc...@folklore1984.net> --- Android.mk | 4 ++-- Makefile.am | 2 +- configure.ac

Re: [Mesa-dev] Potentially EOL ilo gallium driver

On 02/02/2017 12:38 AM, Emil Velikov wrote: > On 1 February 2017 at 12:49, Edward O'Callaghan > <funfunc...@folklore1984.net> wrote: >> Hi guys, >> >> Chia-I Wu thanks so much for getting back to me on this and I think your >> right that Vk is the future -

Re: [Mesa-dev] Potentially EOL ilo gallium driver

t; descriptions, etc.). Sorry for the confusions and burdens it bring to > others, and thanks to the few individuals/groups who find it useful > for their needs at various times. > > > On Thu, Dec 8, 2016 at 8:33 AM, Edward O'Callaghan > <funfunc...@folklore1984.net> wrot

Re: [Mesa-dev] [PATCH 1/2] radv/ac: add const_index to fetch index for gs inputs

Patches 1&2 are, Reviewed-by: Edward O'Callaghan <funfunc...@folklore1984.net> On 02/01/2017 12:12 PM, Dave Airlie wrote: > From: Dave Airlie <airl...@redhat.com> > > This fixes clip distance fetches as they are single item loads > with a const_index like

Re: [Mesa-dev] [PATCH 1/3] st: st_atom_shader.c C99 tidy up

Patches 1,2&3 are, Reviewed-by: Edward O'Callaghan <funfunc...@folklore1984.net> On 02/01/2017 11:58 AM, Timothy Arceri wrote: > From: Timothy Arceri <t_arc...@yahoo.com.au> > > --- > src/mesa/state_tracker/st_atom_shader.c | 4 +--- > 1 file changed, 1 inserti

Re: [Mesa-dev] [PATCH 0/3] radv: VK_KHR_shader_draw_parameters.

This series is, Reviewed-by: Edward O'Callaghan <funfunc...@folklore1984.net> On 02/01/2017 07:42 AM, Bas Nieuwenhuizen wrote: > A basic implementation of VK_KHR_shader_draw_parameters. I haven't > bothered with optimizing it away in the case the shader doesn't > use it, but the i

Re: [Mesa-dev] [PATCH 7/7] radv: Expose VK_KHR_maintenance1

Patches 4&5 LGTM, Reviewed-by: Edward O'Callaghan <funfunc...@folklore1984.net> On 01/30/2017 12:19 PM, Bas Nieuwenhuizen wrote: > Patch 1-3, 6-7 are > > Reviewed-by: Bas Nieuwenhuizen <b...@basnieuwenhuizen.nl> > > The other two you'll need to find someone el

Re: [Mesa-dev] [PATCH] radeonsi: fix texture gather on stencil textures

Acked-by: Edward O'Callaghan <funfunc...@folklore1984.net> On 01/18/2017 07:32 PM, Nicolai Hähnle wrote: > From: Nicolai Hähnle <nicolai.haeh...@amd.com> > > At least on VI, texture gather doesn't work with a 24_8 data format, so > use 8_8_8_8 and a modified swi

Re: [Mesa-dev] [PATCH] radeonsi: reject invalid vertex element formats

Reviewed-by: Edward O'Callaghan <funfunc...@folklore1984.net> On 01/19/2017 08:35 AM, Marek Olšák wrote: > From: Marek Olšák <marek.ol...@amd.com> > > This should fix a coverity defect. > --- > src/gallium/drivers/radeonsi/si_state.c | 5 + > 1 file changed, 5

Re: [Mesa-dev] [PATCH] radeonsi: don't forget to add HTILE to the buffer list for texturing

Ah nice catch, Reviewed-by: Edward O'Callaghan <funfunc...@folklore1984.net> On 01/19/2017 08:21 AM, Marek Olšák wrote: > From: Marek Olšák <marek.ol...@amd.com> > > This fixes VM faults. Discovered by Samuel Pitoiset. > > Cc: 17.0 13.0 <mesa-sta...@lists.freedes

Re: [Mesa-dev] Clean ups (fortnightly spamming)

This series is, Acked-by: Edward O'Callaghan <funfunc...@folklore1984.net> On 01/19/2017 05:23 PM, Timothy Arceri wrote: > Thanks to all that have help review the series so far. 70+ patches have > landed since I jumped into this just 10 to go. > > The first 3 are the majo

Re: [Mesa-dev] [PATCH] radeonsi: for the tess barrier, only use emit_waitcnt on SI and LLVM 3.9+

Reviewed-by: Edward O'Callaghan <funfunc...@folklore1984.net> On 01/17/2017 11:49 PM, Marek Olšák wrote: > From: Marek Olšák <marek.ol...@amd.com> > > Cc: 17.0 13.0 <mesa-sta...@lists.freedesktop.org> > --- > src/gallium/drivers/radeonsi/si_shader.c | 7 +-

Re: [Mesa-dev] [PATCH 1/2] radv/ac: switch an if to switch

Patches 1 & 2 are, Reviewed-by: Edward O'Callaghan <funfunc...@folklore1984.net> On 01/17/2017 09:47 AM, Dave Airlie wrote: > From: Dave Airlie <airl...@redhat.com> > > makes it easier to add other shader stages. > > Signed-off-by: Dave Airlie <airl...@r

Re: [Mesa-dev] Clean ups (hopefully last time)

I think if there is other serious objections, this series is Acked-by: Edward O'Callaghan <funfunc...@folklore1984.net> On 01/09/2017 04:13 PM, Timothy Arceri wrote: > Sorry to keep spamming the list with these but a bunch have now landed > and theire was a bug fix and a bunch

Re: [Mesa-dev] [PATCH] mapi: update the asm code to support x32

Reviewed-by: Edward O'Callaghan <funfunc...@folklore1984.net> On 01/09/2017 04:38 AM, Grazvydas Ignotas wrote: > Fixes crashes when both glx-tls and asm are enabled on x32. > > Cc: mesa-sta...@lists.freedesktop.org > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=

Re: [Mesa-dev] [PATCH mesa] drirc: remove spurious tabs

Reviewed-by: Edward O'Callaghan <funfunc...@folklore1984.net> On 01/06/2017 08:06 AM, Eric Engestrom wrote: > Signed-off-by: Eric Engestrom <e...@engestrom.ch> > --- > src/mesa/drivers/dri/common/drirc | 16 > 1 file changed, 8 insertions(+), 8 deletions(

Re: [Mesa-dev] [PATCH] winsys/amdgpu: fix a race condition between fence updates and IB submissions

Acked-by: Edward O'Callaghan <funfunc...@folklore1984.net> On 01/03/2017 07:20 AM, Marek Olšák wrote: > From: Marek Olšák <marek.ol...@amd.com> > > The CS thread is needed to ensure proper ordering of operations and can't > be disabled (without complicating the code).

Re: [Mesa-dev] [PATCH 0/3] RadeonSI L2 prefetch for shader binaries

This series is, Reviewed-by: Edward O'Callaghan <funfunc...@folklore1984.net> On 01/03/2017 07:18 AM, Marek Olšák wrote: > Please review. > > Marek > ___ > mesa-dev mailing list > mesa-dev@lists.freedesktop.org > https://li

Re: [Mesa-dev] [PATCH 1/3] radeonsi: cleanly communicate whether si_shader_dump should check R600_DEBUG

This series is, Acked-by: Edward O'Callaghan <funfunc...@folklore1984.net> On 01/04/2017 06:17 AM, Marek Olšák wrote: > From: Marek Olšák <marek.ol...@amd.com> > > --- > src/gallium/drivers/radeonsi/si_compute.c | 2 +- > src/gallium/drivers/radeonsi/si_deb

Re: [Mesa-dev] [PATCH 1/2] spirv: add interface for drivers to define support extensions.

I like it, Reviewed-by: Edward O'Callaghan <funfunc...@folklore1984.net> On 12/28/2016 10:30 AM, Dave Airlie wrote: > From: Dave Airlie <airl...@redhat.com> > > I expect over time the struct contents will change as all > drivers support stuff etc, but for now this sho

  1   2   3   4   5   6   >