Re: [Mesa-dev] [PATCH] meta: Use ARB_explicit_attrib_location in the rest of the meta shaders.

2016-03-22 Thread Ian Romanick
I thought I already had this patch, but it looks like it was on my to-do list. I had patches to use GL_ARB_explicit_uniform_location, and those needed GL_ARB_explicit_attrib_location (to get the layout keyword). https://patchwork.freedesktop.org/patch/74220/ (and others... I'm not sure why I

Re: [Mesa-dev] [PATCH] meta: Use ARB_explicit_attrib_location in the rest of the meta shaders.

2016-03-15 Thread Matt Turner
Indeed, none of nouveau_vieux, radeon, or r200 support GLSL. Of course, no classic driver except i965 supports #version 130, so those are clear. Reviewed-by: Matt Turner ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org

[Mesa-dev] [PATCH] meta: Use ARB_explicit_attrib_location in the rest of the meta shaders.

2016-03-15 Thread Kenneth Graunke
This is cleaner than using glBindAttribLocation(). Not all drivers support the extension, but I don't think those drivers use GLSL in the first place. Apparently some Meta shaders already use GL_ARB_explicit_attrib_location, so I think it should be okay. Honestly, I'm not sure how the old code