Re: [mkgmap-dev] [PATCH] Bug in label encoding

2010-02-08 Thread Toby Speight
0 In article 20100208071528.ga11...@x60s, 0 Marko Mäkelä URL:mailto:marko.mak...@iki.fi (Marko) wrote: Marko An integer version of your formula would also work in this case: Marko Marko int len = (off * 6 + 7) / 8 = 43/8 = 5.375 = 5 Marko Marko This formula is clear to me: it will

Re: [mkgmap-dev] Bad routing error here in Rome...

2010-02-08 Thread Marco Certelli
Hello, Mark is trying to reproduce the error I got on my PC but He couldn't so far. I'm now trying to rebuild img on another PC. I'll let you know about my new tests as soon as I have news. Ciao, Marco. --- Lun 8/2/10, Lambertus o...@na1400.info ha scritto: Da: Lambertus o...@na1400.info

Re: [mkgmap-dev] Small bug in mkgmap style handling on action rules

2010-02-08 Thread Steve Ratcliffe
for setting the name. BTW is the --name-tag-list option still usefull. I think it can be better done directly from the style-file (or is it faster to do via name-tag-list??). I think it is useful. Obviously not so much for your style as it sets a constructed name on most things itself. But

[mkgmap-dev] Commit: r1566: Drop all tags from the osm file that are not used

2010-02-08 Thread svn commit
Version 1566 was commited by steve on 2010-02-08 12:33:09 + (Mon, 08 Feb 2010) BRANCH: style-speed Drop all tags from the osm file that are not used in the applied style. Whether this makes a big difference or not depends on the country. In the UK which is mostly manually taged it doesn't

Re: [mkgmap-dev] Commit: r1566: Drop all tags from the osm file thatare not used

2010-02-08 Thread Chris Miller
What might be nice is if this stripping can be done before (or during) the split. That way the splitter would have to do less work, and possibly would also be able to perform a better split. The downside would be that any style changes might necessitate another splitter run. Would it be

Re: [mkgmap-dev] Commit: r1566: Drop all tags from the osm file thatare not used

2010-02-08 Thread Marko Mäkelä
On Mon, Feb 08, 2010 at 01:30:13PM +, Chris Miller wrote: What might be nice is if this stripping can be done before (or during) the split. That way the splitter would have to do less work, and possibly would also be able to perform a better split. The downside would be that any style

Re: [mkgmap-dev] Splitter caused a RestrictionRelation warning

2010-02-08 Thread Chris Miller
Hi Marko, MM This is just FYI when you work on preserving relations. Currently, MM I think that the current behaviour (discarding nodes or ways outside MM the MM cutting area) is OK for route relations but not for anything else MM (turn restriction, through-road, multipolygon). Sounds

Re: [mkgmap-dev] Commit: r1566: Drop all tags from the osmfile thatare not used

2010-02-08 Thread Chris Miller
MM What about this: MM MM mkgmap --style=some_style --generate-whitelist whitelist.txt MM splitter --whitelist=whitelist.txt ... MM mkgmap --style=some_style ... MM Marko Sounds good to me, at least as far as the splitter is concerned. Certainly easier than trying to share the mkgmap code.

[mkgmap-dev] [PATCH v1] Reduce memory footprint of tags

2010-02-08 Thread WanMil
The discussions around Commit: r1566: Drop all tags from the osm file that are not used inspired me to address the memory footprints of the tags. The patch reduces the memory footprint by using the String.intern() method. This ensures that the String highway exists only once when stored as

Re: [mkgmap-dev] Bad routing error here in Rome...

2010-02-08 Thread Johann Gail
Have you tried compile a map with the default style files? Regards, Johann Marco Certelli schrieb: Hello, Mark is trying to reproduce the error I got on my PC but He couldn't so far. I'm now trying to rebuild img on another PC. I'll let you know about my new tests as soon as I have news.

Re: [mkgmap-dev] Bad routing error here in Rome...

2010-02-08 Thread Marco Certelli
--- Lun 8/2/10, Johann Gail johann.g...@gmx.de ha scritto: Da: Johann Gail johann.g...@gmx.de Oggetto: Re: [mkgmap-dev] Bad routing error here in Rome... A: Development list for mkgmap mkgmap-dev@lists.mkgmap.org.uk Data: Lunedì 8 febbraio 2010, 20:00 Have you tried compile a map with the

Re: [mkgmap-dev] Commit: r1566: Drop all tags from the osm file thatare not used

2010-02-08 Thread Ralf Kleineisel
On 08.02.2010 14:35, Marko Mäkelä wrote: mkgmap --style=some_style --generate-whitelist whitelist.txt splitter --whitelist=whitelist.txt ... mkgmap --style=some_style ... What about that new 'geotagman' OSM pre-processor tool which Toby Speight presented here a few days ago? This looks like

Re: [mkgmap-dev] [PATCH] Bug in label encoding

2010-02-08 Thread Ronny Klier
Am 08.02.2010 10:46, schrieb Steve Ratcliffe: On 07/02/10 23:47, Ronny Klier wrote: I think there is a bug in label encoding in Format6Encoder. For some string length the last encoded byte is not stored. E.g. having a string 10007 the encoded byte buffer looks like this [0] [0x86] [1]

Re: [mkgmap-dev] [PATCH v1] Reduce memory footprint of tags

2010-02-08 Thread Toby Speight
Interning all the key names could also be useful for speed by allowing a '==' comparison instead of calling String.equals(). Though I suspect the latter tests object identity as its first move, so perhaps your patch improves this enough as a side-effect (and it's safer to not have to think which

Re: [mkgmap-dev] Problem with --adjust-turn-headings

2010-02-08 Thread Apollinaris Schoell
Hi Mark, I think I have an example where this is useful. On a ~200km drive I got one keep left announcement where there was only a normal exit from the motorway. Before blindly adding this relation I want to understand how the current algorithm should work. maybe I should fix the osm data first

Re: [mkgmap-dev] Problem with --adjust-turn-headings

2010-02-08 Thread Mark Burton
Hi Apollinaris, Hi Mark, I think I have an example where this is useful. On a ~200km drive I got one keep left announcement where there was only a normal exit from the motorway. Before blindly adding this relation I want to understand how the current algorithm should work. maybe I

Re: [mkgmap-dev] Re : [PATCH v1] Multipolygon: do not remove ways that completely, contain the bounding box (WanMil)

2010-02-08 Thread WanMil
Hello Wanmil, I tried your patch and it did not work for me. As Steve pointed out the problem, I commented all the code of the patched removeWaysOutsideBox() and the sea multipolygon is generated as expected. I don't know if it is linked but there are still some artefacts which appear in

Re: [mkgmap-dev] Problem with --adjust-turn-headings

2010-02-08 Thread Apollinaris Schoell
Hi Mark, found a problem in the osm data. there was a short bridge with the name of the exit instead of the motorway name. the turn instruction was exactly as expected according to your implementation. I have another interesting one here