Re: Performance problem with invoke dynamic

2011-08-12 Thread Christian Thalinger
On Aug 10, 2011, at 9:10 PM, Christian Thalinger wrote: On Jul 28, 2011, at 7:29 PM, Ola Bini wrote: On 2011-07-28 10.11, Christian Thalinger wrote: On Jul 28, 2011, at 6:10 PM, Ola Bini wrote: The bad performance sounds like something is not inlined at all. How are you invoking

Re: JRuby invokedynamic updates

2011-08-12 Thread Rémi Forax
On 08/12/2011 08:22 PM, Tom Rodriguez wrote: I wonder if this patch is not too much. If a big method is called through an invokedynamic + method handle then it will be inlined. That's not how it works. The methods called by the adapter will still have to pass normal inlining checks before

Re: JRuby invokedynamic updates

2011-08-12 Thread Charles Oliver Nutter
On Fri, Aug 12, 2011 at 1:18 PM, Tom Rodriguez tom.rodrig...@oracle.com wrote: I wonder if we need to be slightly more selective than this.  Most method handle chains are relatively small and we shouldn't be penalized for that but they could be arbitrarily large too.  Worst case they just