Re: review request (S): 7077803: java.lang.InternalError in java.lang.invoke.MethodHandleNatives.init

2011-09-20 Thread Christian Thalinger
Looks good. -- Christian On Sep 20, 2011, at 12:09 AM, John Rose wrote: 7077803: java.lang.InternalError in java.lang.invoke.MethodHandleNatives.init http://cr.openjdk.java.net/~jrose/7077803/webrev.00 Remove access checking and access narrowing logic from MethodHandles.unreflectX calls,

Re: review request (L): 7030453: JSR 292 ClassValue.get method is too slow

2011-09-20 Thread Christian Thalinger
On Sep 19, 2011, at 11:58 PM, John Rose wrote: http://cr.openjdk.java.net/~jrose/7030453/webrev.00 src/share/classes/java/lang/ClassValue.java: 233 /** Value stream for for hashCodeForCache. See similar structure in ThreadLocal. */ Two for's. 578 * from the ehad of a non-null

Re: SIGSEGV while Parse::optimize_inlining an invokedynamic call.

2011-09-20 Thread Christian Thalinger
On Sep 19, 2011, at 4:40 PM, Sebastian Sickelmann wrote: Hi, i tried to simplify the TestNew2 class. But now it is to simple. The crash is gone. I tried to make the process between Main and NEW2 more complex, but this doesn't brings the crash back. i uploaded the new jar to

Re: SIGSEGV while Parse::optimize_inlining an invokedynamic call.

2011-09-20 Thread Christian Thalinger
On Sep 19, 2011, at 11:09 AM, Christian Thalinger wrote: [Moving hotspot-runtime-dev to Bcc] On Sep 17, 2011, at 9:05 PM, Sebastian Sickelmann wrote: Hi, while doing further investigations on my idea [0] i observed a reproducable crash of the vm. It seems to me that it happens while

Re: review request (L): 7030453: JSR 292 ClassValue.get method is too slow

2011-09-20 Thread John Rose
On Sep 20, 2011, at 1:02 AM, Christian Thalinger wrote: On Sep 19, 2011, at 11:58 PM, John Rose wrote: http://cr.openjdk.java.net/~jrose/7030453/webrev.00 src/share/classes/java/lang/ClassValue.java: 233 /** Value stream for for hashCodeForCache. See similar structure in

Re: SIGSEGV while Parse::optimize_inlining an invokedynamic call.

2011-09-20 Thread Sebastian Sickelmann
Am 20.09.2011 13:19, schrieb Christian Thalinger: On Sep 19, 2011, at 11:09 AM, Christian Thalinger wrote: [Moving hotspot-runtime-dev to Bcc] On Sep 17, 2011, at 9:05 PM, Sebastian Sickelmann wrote: Hi, while doing further investigations on my idea [0] i observed a reproducable crash of

Re: review request (L): 7030453: JSR 292 ClassValue.get method is too slow

2011-09-20 Thread John Rose
On Sep 19, 2011, at 2:58 PM, John Rose wrote: http://cr.openjdk.java.net/~jrose/7030453/webrev.00 After some comments from David Holmes (thanks David!) I added internal comments about race conditions. I refreshed the webrev with the additional comments. I also changed one variable to be

hg: mlvm/mlvm/jdk: update 7030453 and 7077803 to review versions

2011-09-20 Thread john . r . rose
Changeset: f0d08d7dda75 Author:jrose Date: 2011-09-20 16:11 -0700 URL: http://hg.openjdk.java.net/mlvm/mlvm/jdk/rev/f0d08d7dda75 update 7030453 and 7077803 to review versions ! cval-tune-7030453.patch ! meth-acc-7077803.patch ___