Re: [WikimediaMobile] [ve-tech] [spike] Determine where the performance problems are with VE

2014-05-27 Thread Jon Robson
Thanks a bunch Ed and friends for focusing on the rendering of shields. Will be good to see the impact this has on both desktop and mobile :-) On Sat, May 24, 2014 at 12:27 PM, Juliusz Gonera jgon...@wikimedia.org wrote: Awesome, thanks! On 05/24/2014 02:31 AM, Ed Sanders wrote: So with

Re: [WikimediaMobile] [ve-tech] [spike] Determine where the performance problems are with VE

2014-05-23 Thread Tomasz Finc
On Fri, May 16, 2014 at 7:19 AM, Jon Robson jrob...@wikimedia.org wrote: I'm not quite sure at which point we say that we have succeeded in improving VE mobile performance but when someone finally bothers reviewing https://gerrit.wikimedia.org/r/131892 we should have a better idea if mobile is

Re: [WikimediaMobile] [ve-tech] [spike] Determine where the performance problems are with VE

2014-05-23 Thread Ed Sanders
So with our latest changes we've also deferred the rendering of shields until the are first focused (tapped, in mobile). This should completely eliminate any page load bottleneck these were causing. On 16 May 2014 15:19, Jon Robson jrob...@wikimedia.org wrote: The % of time spent in these

Re: [WikimediaMobile] [ve-tech] [spike] Determine where the performance problems are with VE

2014-05-16 Thread Jon Robson
The % of time spent in these functions has been reduced somewhat according to my latest profiling, but the MobileFrontend nth-child selector /still/ exists so it's still ridiculously high on mobile. I'm not quite sure at which point we say that we have succeeded in improving VE mobile performance

Re: [WikimediaMobile] [ve-tech] [spike] Determine where the performance problems are with VE

2014-05-15 Thread Trevor Parscal
We now have our QA person (Rummana) testing on an iPad, which is helping to surface issues in general, but her focus has mostly been on bugs. We do have some scheduled bandwidth to deal with these problems, and now that we have a sort of deadline, I think it's a good idea to get some focus on

Re: [WikimediaMobile] [ve-tech] [spike] Determine where the performance problems are with VE

2014-05-15 Thread James Forrester
On 15 May 2014 19:22, Arthur Richards aricha...@wikimedia.org wrote: On Thu, May 1, 2014 at 3:53 PM, Trevor Parscal tpars...@wikimedia.org wrote: The issues on load I believe we are having have to do with shields. ​ ​ ​ Trevor and VE folks more broadly, is this something you have now

Re: [WikimediaMobile] [ve-tech] [spike] Determine where the performance problems are with VE

2014-05-15 Thread Arthur Richards
On Thu, May 15, 2014 at 10:26 AM, Trevor Parscal tpars...@wikimedia.orgwrote: We now have our QA person (Rummana) testing on an iPad, which is helping to surface issues in general, but her focus has mostly been on bugs. We do have some scheduled bandwidth to deal with these problems, and now

Re: [WikimediaMobile] [ve-tech] [spike] Determine where the performance problems are with VE

2014-05-15 Thread Roan Kattouw
On May 15, 2014 10:27 AM, Roan Kattouw rkatt...@wikimedia.org wrote: Ed has been fixing some things to do with shields and phantoms. I'll send you some Gerrit links in a minute. https://gerrit.wikimedia.org/r/#/c/133236/ https://gerrit.wikimedia.org/r/#/c/130823/ The former should address the

Re: [WikimediaMobile] [ve-tech] [spike] Determine where the performance problems are with VE

2014-05-15 Thread Jon Robson
I'm still waiting for Kaldari or someone in mobile to merge https://gerrit.wikimedia.org/r/131892 before I can confirm the current state. It definitely seems to be marginally improved on desktop and mobile (with desktop benefiting most) after a few runs. For the record the nasty page I'm testing

Re: [WikimediaMobile] [ve-tech] [spike] Determine where the performance problems are with VE

2014-05-15 Thread Roan Kattouw
On Thu, May 15, 2014 at 3:58 PM, Jon Robson jrob...@wikimedia.org wrote: I'm still waiting for Kaldari or someone in mobile to merge https://gerrit.wikimedia.org/r/131892 before I can confirm the current state. It definitely seems to be marginally improved on desktop and mobile (with desktop

Re: [WikimediaMobile] [ve-tech] [spike] Determine where the performance problems are with VE

2014-05-15 Thread Ed Sanders
I believe iPad testing is available on crossbrowsertesting.com On 16 May 2014 00:06, Roan Kattouw rkatt...@wikimedia.org wrote: On Thu, May 15, 2014 at 3:58 PM, Jon Robson jrob...@wikimedia.org wrote: I'm still waiting for Kaldari or someone in mobile to merge

Re: [WikimediaMobile] [ve-tech] [spike] Determine where the performance problems are with VE

2014-05-15 Thread Ed Sanders
I think the root issue in that we are committing CSS on all children. We've yet to come up with a more efficient way of computing the outline of an element but we're open to ideas. Potentially we could drop the shields and only compute outlines on focus. I believe we only need the shields for IE

Re: [WikimediaMobile] [ve-tech] [spike] Determine where the performance problems are with VE

2014-05-01 Thread Trevor Parscal
The issues on load I believe we are having have to do with shields. Shields are transparent 1x1 gif images we inject into the DOM to simulate selecting over objects which are made up of complex HTML structures. They originally also protected the HTML structure from being clicked on directly