Re: [Mugle-dev] Proposal for Key/Value API changes

2011-05-28 Thread Scott Ritchie
In terms of providing a rich API while keeping the code as simple for the students as possible, i like the idea of keeping the existing code the same, but have them pass the .class object, and then using browser side reflection. On Fri, May 27, 2011 at 9:57 PM, Matt Giuca matt.gi...@gmail.com

Re: [Mugle-dev] Delete UserGameProfile

2011-05-26 Thread Scott Ritchie
--REPLY ALL-- It may be a problem with the key lookup - check the UserGameProfileGetter - when the UGP isnt found, it tries to create a new one and return it, so there may be a problem with the logic there. Removing the UGPs shouldnt be too hard - the remove function just needs to call the

Re: [Mugle-dev] Policy decision: Full names

2011-05-25 Thread Scott Ritchie
That sounds good, i think we had initially set it to private for privacy reasons. On Wed, May 25, 2011 at 8:44 PM, Matt Giuca matt.gi...@gmail.com wrote: Hi, I was under the impression that we would show users full names publicly. However, that doesn't seem to be the case; the public view

Re: [Mugle-dev] [Bug 788083] Re: Anyone can request private games for a given devteam

2011-05-25 Thread Scott Ritchie
I think implementing the security properly would solve a lot of the bugs we currently have. I just wish i had the time to sit down for a few hours and do it. On Wed, May 25, 2011 at 11:11 PM, Matt Giuca 788...@bugs.launchpad.netwrote: ** Description changed: Currently, the

Re: [Mugle-dev] [Bug 786016] Re: Direct Access to Services from client side

2011-05-25 Thread Scott Ritchie
I dont think, this is a non-issue, once security is implemented properly. On Wed, May 25, 2011 at 11:32 PM, Matt Giuca 786...@bugs.launchpad.netwrote: Can someone figure out if this is still an issue? I don't want old bugs lying around if they are not real concerns. -- You received this bug

Re: [Mugle-dev] Behaviour of remove

2011-05-24 Thread Scott Ritchie
Well the other option is when you remove a devteam for example, the client side removes the key from the clientside object, which we then have to pass back and check all the keys the client side gives, whereas now we don't accept any of the keys from the clientside, so association and

Re: [Mugle-dev] MUGLE is now live

2011-05-23 Thread Scott Ritchie
Wow, good work everyone. Sorry i wasnt able to help much last night! On Tue, May 24, 2011 at 9:12 AM, coles.da...@gmail.com coles.da...@gmail.com wrote: Wow! That is looking really awesome! I've seen how busy you've been - I archived all the MUGLE messages on Sunday and by today my inbox

Re: [Mugle-dev] Cannot populate datastore

2011-05-22 Thread Scott Ritchie
Prageeth and i are working on this at the moment; It's a problem with the GameVersion creation. On Sun, May 22, 2011 at 4:16 PM, Matt Giuca matt.gi...@gmail.com wrote: The populate datastore button has stopped working again. Can someone confirm this and/or fix it? I can't see any errors in

Re: [Mugle-dev] Cannot populate datastore

2011-05-22 Thread Scott Ritchie
We're getting GameVersion.create() complain that the GameData key is null (which it isnt) it seems to be a problem with the wrapper. On Sun, May 22, 2011 at 4:21 PM, Matt Giuca matt.gi...@gmail.com wrote: Weird ... I just found that it was my own problem, and now it works. So is it broken for

Re: [Mugle-dev] Mixing tabs and spaces

2011-05-22 Thread Scott Ritchie
Sorry must have been tired last night when i set it up, so i didnt see the plugin. I can't get launchpad to download the package though, the bazaar request keeps timing out (bzr update on our package worked fine though) On Sun, May 22, 2011 at 4:42 PM, Prageeth Silva

Re: [Mugle-dev] Mixing tabs and spaces

2011-05-22 Thread Scott Ritchie
, Scott Ritchie s.ritchi...@gmail.comwrote: Sorry must have been tired last night when i set it up, so i didnt see the plugin. I can't get launchpad to download the package though, the bazaar request keeps timing out (bzr update on our package worked fine though) Weird. It's working for me. Try

Re: [Mugle-dev] Mixing tabs and spaces

2011-05-22 Thread Scott Ritchie
I just put through a commit, and it didnt complain about tabs, so hopefully its ok On Sun, May 22, 2011 at 5:21 PM, Scott Ritchie s.ritchi...@gmail.comwrote: I downloaded the two python files manually. I'm still debugging stuff so hopefully itll work when i commit next On Sun, May 22, 2011

[Mugle-dev] Using the persistence Manager many times in one method

2011-05-22 Thread Scott Ritchie
Don't do it - you need to close it off every so often. Spent the last two hours tracking down a bug only to find it was just flat out failing to create any more queries. So just FYI. -- Mailing list: https://launchpad.net/~mugle-dev Post to : mugle-dev@lists.launchpad.net Unsubscribe :

Re: [Mugle-dev] Using the persistence Manager many times in one method

2011-05-22 Thread Scott Ritchie
Yeah i couldnt figure it out - but in DataStoreServiceImpl (and all methods it called), it just crashed inside GameFile.create() when you tried to do pm.newQuery() throwing JDOFatalUserException, and was resolved by using the GetterMethods which handled the PersistenceManager by themselves (rather

Re: [Mugle-dev] Getting a Key from a Long

2011-05-22 Thread Scott Ritchie
Ill still be around. Im happy with the code so long as it runs :) On Sun, May 22, 2011 at 11:33 PM, Matt Giuca matt.gi...@gmail.com wrote: OK thanks both of you. Will either of you be up still in 30-60 minutes? I'd like someone to review this GameFile code before I merge it. Because I

Re: [Mugle-dev] [Bug 786594] [NEW] Upload service does not check permissions

2011-05-22 Thread Scott Ritchie
I would suggest taking a look at the checkPermissions() method inside GameFileServiceImpl - it should be almost identical to what you need. On Mon, May 23, 2011 at 2:04 AM, Matt Giuca 786...@bugs.launchpad.netwrote: *** This bug is a security vulnerability *** Private security bug reported:

Re: [Mugle-dev] [Bug 786685] [NEW] Views aren't restricted by permission

2011-05-22 Thread Scott Ritchie
This should be the case with the markup of permissions for Public and Private in the data classes themselves. The edit page itself should be blocked, but there's nothing stopping them from viewing those fields (because they need to) if they do edit an object and pass it back it will

Re: [Mugle-dev] [Bug 786685] Re: Views aren't restricted by permission

2011-05-22 Thread Scott Ritchie
Yes, that's what prageeth's annotations do, the getter for the gametoken in GameData should be marked with something along the lines of PUBLIC=admin, PRIVATE=guest Meaning that unless you're an admin, you can only see the gametoken if it belongs to a game in a devteam you are part of.

Re: [Mugle-dev] Mixing tabs and spaces

2011-05-20 Thread Scott Ritchie
My code is one line, don't worry about it. Do you have instructions on how to set this up in eclipse? On 20/05/2011, at 3:59 PM, Matt Giuca matt.gi...@gmail.com wrote: Guys, I know it is late in the game, but if I am going to be working on this project over the weekend I am going to go

[Mugle-dev] Populate datastore

2011-05-20 Thread Scott Ritchie
If we're deploying on Monday, and we are keeping the populate datastore button as a testing mechanism, I feel it would be apppropriate to move it to the admin panel, and code it properly so it checks the datastore before writing. -- Mailing list: https://launchpad.net/~mugle-dev Post to

[Mugle-dev] [Bug 786016] [NEW] Direct Access to Services from client side

2011-05-20 Thread Scott Ritchie
*** This bug is a security vulnerability *** Public security bug reported: While Prageeth has coded the casting of shared objects to datastore objects to have security checks, these can be bypassed by calling the shared services directly. The type of these classes should be changed to Protected

Re: [Mugle-dev] Displaying error messages on the UI

2011-05-19 Thread Scott Ritchie
Hi im just going through and chaning the existing onFailure error messages to use this new error display. Just a design question; Do we want to show the stack trace in the panel below the error's message? On Thu, May 19, 2011 at 2:30 AM, Prageeth Silva prageethsi...@gmail.comwrote: Displaying

Re: [Mugle-dev] Mugle UI

2011-05-19 Thread Scott Ritchie
Saturday im working 9-5 on campus, then intend to head home and do mugle development that night and sunday. As far as the UI goes, i spent a few hours last night reworking the DevTeam addition in the admin panel to be like the stockwatcher tutorial - once i have that working properly i can

Re: [Mugle-dev] Mugle UI

2011-05-19 Thread Scott Ritchie
the backend doesn't want to create or edit badges/games ;) On Fri, May 20, 2011 at 9:38 AM, Scott Ritchie s.ritchi...@gmail.comwrote: Hi prageeth, My thoughts on this would be to have the admin be able to edit these directly from the respective edit pages. My new AdminViewBuilder will have

Re: [Mugle-dev] Mugle UI

2011-05-19 Thread Scott Ritchie
a window pop up to confirm the removal of a devteam/badge/game? I'll commit it when i get home tonight and can get on over port 22. On Fri, May 20, 2011 at 9:56 AM, Jens Pfau jens.p...@gmail.com wrote: Ok cool. I am curious what's the problem. On Fri, May 20, 2011 at 9:55 AM, Scott Ritchie s.ritchi

Re: [Mugle-dev] Mugle UI

2011-05-19 Thread Scott Ritchie
Additionally if you're wondering about the List kept of urlNames - i made the decision to go down that path rather than call showDevTeams() for every addition/deletion to keep from reloading every devTeam from the datastore each time. On Fri, May 20, 2011 at 11:16 AM, Scott Ritchie s.ritchi

Re: [Mugle-dev] Mugle UI

2011-05-19 Thread Scott Ritchie
by refreshing the page. On Fri, May 20, 2011 at 11:21 AM, Scott Ritchie s.ritchi...@gmail.comwrote: Additionally if you're wondering about the List kept of urlNames - i made the decision to go down that path rather than call showDevTeams() for every addition/deletion to keep from reloading

Re: [Mugle-dev] Mugle UI

2011-05-19 Thread Scott Ritchie
Thanks, I only have an additional small change made which clears the textbox after adding, but I'll put that in later On 20/05/2011, at 1:37 PM, Matt Giuca matt.gi...@gmail.com wrote: Thanks Scott. I committed those changes now (the attached file and the small bug fix). You should see

[Mugle-dev] [Bug 730086] [NEW] Add Serializable classes of model to be passed by GWT RPC

2011-03-06 Thread Scott Ritchie
Public bug reported: Write serializable versions of each of the model classes to be passed over by GWT RPC so they can be accessed by the client side of the platform; Should only have getters (and setters ?), and should only contain information the client side should be able to see (so there'll