Re: RFR: 8329745: Update the documentation of ServerSocket and Socket to refer to StandardSocketOptions instead of legacy SocketOptions [v4]

2024-04-06 Thread Jaikiran Pai
> Can I please get a review of this doc-only changes to java.net.ServerSocket > and java.net.Socket classes? > > As noted in https://bugs.openjdk.org/browse/JDK-8329745, these classes > currently refer to the legacy `java.net.SocketOptions` interface and instead > should be refering to the

Re: RFR: 8329745: Update the documentation of ServerSocket and Socket to refer to StandardSocketOptions instead of legacy SocketOptions [v3]

2024-04-06 Thread Jaikiran Pai
On Sat, 6 Apr 2024 09:10:10 GMT, Alan Bateman wrote: >> Jaikiran Pai has updated the pull request incrementally with one additional >> commit since the last revision: >> >> remove some @see from constructors > > src/java.base/share/classes/java/net/ServerSocket.java line 189: > >> 187:

Re: RFR: 8329733: Update the documentation in java.net.SocketOptions to direct to java.net.StandardSocketOptions [v2]

2024-04-06 Thread Jaikiran Pai
On Fri, 5 Apr 2024 11:49:25 GMT, Jaikiran Pai wrote: >> Can I please get a review of this doc-only change which proposes to clean up >> the documentation of `java.net.SocketOptions` interface? >> >> As noted in https://bugs.openjdk.org/browse/JDK-8329733, the existing >> documentation in this

Re: RFR: 8329733: Update the documentation in java.net.SocketOptions to direct to java.net.StandardSocketOptions [v2]

2024-04-06 Thread Alan Bateman
On Sat, 6 Apr 2024 08:41:23 GMT, Jaikiran Pai wrote: > Alan, in context of another old issue > https://bugs.openjdk.org/browse/JDK-6431396 would you want anything more to > be added/updated for the `SO_BINDADDR` field's javadoc as part of this PR? > The current update in PR already takes into

Re: RFR: 8329733: Update the documentation in java.net.SocketOptions to direct to java.net.StandardSocketOptions [v2]

2024-04-06 Thread Alan Bateman
On Fri, 5 Apr 2024 11:49:25 GMT, Jaikiran Pai wrote: >> Can I please get a review of this doc-only change which proposes to clean up >> the documentation of `java.net.SocketOptions` interface? >> >> As noted in https://bugs.openjdk.org/browse/JDK-8329733, the existing >> documentation in this

Re: RFR: 8329745: Update the documentation of ServerSocket and Socket to refer to StandardSocketOptions instead of legacy SocketOptions [v3]

2024-04-06 Thread Alan Bateman
On Fri, 5 Apr 2024 13:03:13 GMT, Jaikiran Pai wrote: >> Can I please get a review of this doc-only changes to java.net.ServerSocket >> and java.net.Socket classes? >> >> As noted in https://bugs.openjdk.org/browse/JDK-8329745, these classes >> currently refer to the legacy

Re: RFR: 8329733: Update the documentation in java.net.SocketOptions to direct to java.net.StandardSocketOptions [v2]

2024-04-06 Thread Jaikiran Pai
On Fri, 5 Apr 2024 11:49:25 GMT, Jaikiran Pai wrote: >> Can I please get a review of this doc-only change which proposes to clean up >> the documentation of `java.net.SocketOptions` interface? >> >> As noted in https://bugs.openjdk.org/browse/JDK-8329733, the existing >> documentation in this

Integrated: 8329733: Update the documentation in java.net.SocketOptions to direct to java.net.StandardSocketOptions

2024-04-06 Thread Jaikiran Pai
On Fri, 5 Apr 2024 06:56:06 GMT, Jaikiran Pai wrote: > Can I please get a review of this doc-only change which proposes to clean up > the documentation of `java.net.SocketOptions` interface? > > As noted in https://bugs.openjdk.org/browse/JDK-8329733, the existing > documentation in this