Re: RFR: 8317376: Minor improvements to the 'this' escape analyzer [v4]

2024-04-09 Thread Archie Cobbs
> Please review several fixes and improvements to the `this-escape` lint > warning analyzer. > > The goal here is to apply some relatively simple logical fixes that improve > the precision and accuracy of the analyzer, and capture the remaining > low-hanging fruit so we can consider the

Re: RFR: 8315767: InetAddress: constructing objects from BSD literal addresses

2024-04-09 Thread Daniel Fuchs
On Tue, 26 Mar 2024 17:25:54 GMT, Sergey Chernyshev wrote: > There are two distinct approaches to parsing IPv4 literal addresses. One is > the Java baseline "strict" syntax (all-decimal d.d.d.d form family), another > one is the "loose" syntax of RFC 6943 section 3.1.1 [1] (POSIX `inet_addr`

Re: RFR: 8315767: InetAddress: constructing objects from BSD literal addresses

2024-04-09 Thread Daniel Fuchs
On Tue, 26 Mar 2024 17:25:54 GMT, Sergey Chernyshev wrote: > There are two distinct approaches to parsing IPv4 literal addresses. One is > the Java baseline "strict" syntax (all-decimal d.d.d.d form family), another > one is the "loose" syntax of RFC 6943 section 3.1.1 [1] (POSIX `inet_addr`

Re: RFR: 8326568: jdk/test/com/sun/net/httpserver/bugs/B6431193.java should use try-with-resource and try-finally [v3]

2024-04-09 Thread Jaikiran Pai
On Mon, 8 Apr 2024 15:34:11 GMT, Darragh Clarke wrote: >> Currently this test occasionally doesn't cleanup between runs, sometimes not >> stopping the server or leaving Streams open >> >> Changes: >> - Use try-with-resources to ensure streams close. >> - Use try-finally to make sure the server

Re: RFR: 8326568: jdk/test/com/sun/net/httpserver/bugs/B6431193.java should use try-with-resource and try-finally [v3]

2024-04-09 Thread Daniel Fuchs
On Mon, 8 Apr 2024 15:34:11 GMT, Darragh Clarke wrote: >> Currently this test occasionally doesn't cleanup between runs, sometimes not >> stopping the server or leaving Streams open >> >> Changes: >> - Use try-with-resources to ensure streams close. >> - Use try-finally to make sure the server

Re: RFR: 8329745: Update the documentation of ServerSocket and Socket to refer to StandardSocketOptions instead of legacy SocketOptions [v4]

2024-04-09 Thread Jaikiran Pai
On Sun, 7 Apr 2024 01:43:31 GMT, Jaikiran Pai wrote: >> Can I please get a review of this doc-only changes to java.net.ServerSocket >> and java.net.Socket classes? >> >> As noted in https://bugs.openjdk.org/browse/JDK-8329745, these classes >> currently refer to the legacy

Integrated: 8329745: Update the documentation of ServerSocket and Socket to refer to StandardSocketOptions instead of legacy SocketOptions

2024-04-09 Thread Jaikiran Pai
On Fri, 5 Apr 2024 07:31:47 GMT, Jaikiran Pai wrote: > Can I please get a review of this doc-only changes to java.net.ServerSocket > and java.net.Socket classes? > > As noted in https://bugs.openjdk.org/browse/JDK-8329745, these classes > currently refer to the legacy `java.net.SocketOptions`

Re: RFR: 8329745: Update the documentation of ServerSocket and Socket to refer to StandardSocketOptions instead of legacy SocketOptions [v4]

2024-04-09 Thread Daniel Fuchs
On Sun, 7 Apr 2024 01:43:31 GMT, Jaikiran Pai wrote: >> Can I please get a review of this doc-only changes to java.net.ServerSocket >> and java.net.Socket classes? >> >> As noted in https://bugs.openjdk.org/browse/JDK-8329745, these classes >> currently refer to the legacy

Re: RFR: 8329745: Update the documentation of ServerSocket and Socket to refer to StandardSocketOptions instead of legacy SocketOptions [v4]

2024-04-09 Thread Alan Bateman
On Tue, 9 Apr 2024 07:54:19 GMT, Daniel Fuchs wrote: > @jaikiran the only reservation I have is that the new wording makes it look > like the default implementation of `ServerSocket` methods is going to call > `SocketImpl::getOption(SocketOption<>)` while in fact it still calls >

Re: RFR: 8329745: Update the documentation of ServerSocket and Socket to refer to StandardSocketOptions instead of legacy SocketOptions [v4]

2024-04-09 Thread Daniel Fuchs
On Sun, 7 Apr 2024 01:43:31 GMT, Jaikiran Pai wrote: >> Can I please get a review of this doc-only changes to java.net.ServerSocket >> and java.net.Socket classes? >> >> As noted in https://bugs.openjdk.org/browse/JDK-8329745, these classes >> currently refer to the legacy