Re: [Cbe-oss-dev] spidernet: dynamic phy setup code

2007-02-01 Thread Ishizaki Kou
I apologize if you received this mail many times. Jens-san This patch modifies the patch submitted by Kou Ishizaki to make it work on the blade (http://marc.theaimsgroup.com/?l=linux-netdevm=116593424505539w=2). Unfortunately I dont have access to a Celleb so I cannot test it there. Thanks

Re: [PATCH] r8169: fix a race between PCI probe and dev_open

2007-02-01 Thread Francois Romieu
Linus Torvalds [EMAIL PROTECTED] : [...] Doesn't this basically mean that *any* use of rtl8169_set_speed() is buggy? The second use of rtl8169_set_speed is in the change_mtu handler which performs a complete down/cycle after a release of the timer. It's still ugly though. If the current buggy

Re: [PATCH] r8169: fix a race between PCI probe and dev_open

2007-02-01 Thread Francois Romieu
Herbert Xu [EMAIL PROTECTED] : [...] Normally register_netdev should be the very last thing in a probe routine. Yes. I did not feel safe changing it before 2.6.20. -- Ueimor - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More

A potential bug in tcp_vegas.c

2007-02-01 Thread Xiaoliang (David) Wei
Hi gurus, I am testing tcp_vegas.c in Linux with the NS-2 TCP-Linux. It seems that the ssthresh is not correctly reset in this file and the problem might lead to very unfair behavior among Vegas flows, when some flows exit slow start due to loss, not delay. Please see the details at:

Re: spidernet: dynamic phy setup code

2007-02-01 Thread Jens Osterkamp
On Friday 26 January 2007 9:21 pm, Benjamin Herrenschmidt wrote: Can't we have a device-tree property indicating wether to use fiber or copper ? Well, yes, I am sure we could, but what would be the benefit of doing so if we can get the same information dynamically ? Jens - To unsubscribe

Re: spidernet: add improved phy support in sungem_phy.c

2007-02-01 Thread Jens Osterkamp
Francois, thank you for your comments. I'll send a revised patch soon. +#define BCM5421_MODE_MASK1 5 Please add parenthesis. Done. is fine despite the lack of parenthesis above but it is error-prone. Corrected. + + if ( mode == GMII_COPPER) { ^^^ +

Re: spidernet: add improved phy support in sungem_phy.c

2007-02-01 Thread Jens Osterkamp
On Tuesday 30 January 2007 11:30 pm, Linas Vepstas wrote: Shifting to the right by 5 bits has no effect on the result of this conditional. Either the bit is set, or its not. There is no need to shift. + if ( (phy_reg 0x0020) 7 ) { You are right, I corrected this. The result here

[PATCH] [v2] spidernet: add improved phy support

2007-02-01 Thread Jens Osterkamp
This patch adds improved version of enable_fiber for both the 5421 and the 5461 phy. It is now possible to specify with these wether you want autonegotiation or not. This is needed for bladecenter switches where some expect autonegotiation and some dont seem to like this at all. Depending on this

Re: [Cbe-oss-dev] spidernet: dynamic phy setup code

2007-02-01 Thread Jens Osterkamp
Ishizaki-san, This patch partially works on celleb but remains following several problems. 1. It doesn't recover once an ethernet cable which is connected to a spider_net card is unpluged. My understanding is that you are using the LINK interrupt to detect this. For the blade this is

[PATCH] spidernet : fix memory leak in spider_net_stop

2007-02-01 Thread Jens Osterkamp
We forget to call spider_net_free_rx_chain_contents which does the actual dev_kfree_skb. New skbs are allocated from skbuff_head_cache on each ifconfig up letting the cache grow infinitely. This patch fixes it. Signed-off-by: Jens Osterkamp [EMAIL PROTECTED] Index:

Re: [PATCH] HTB O(1) class lookup

2007-02-01 Thread Andi Kleen
Simon Lodal [EMAIL PROTECTED] writes: Memory is generally not an issue, but CPU is, and you can not beat the CPU efficiency of plain array lookup (always faster, and constant time). Actually that's not true when the array doesn't fit in cache. The cost of going out to memory over caches is

Re: [NET_SCHED]: act_ipt: fix regression in ipt action

2007-02-01 Thread jamal
On Thu, 2007-01-02 at 00:21 +0100, Patrick McHardy wrote: plain text document attachment (x) [NET_SCHED]: act_ipt: fix regression in ipt action Looks fine to me - Thanks Patrick. cheers, jamal - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to

Re: [PATCH] r8169: fix a race between PCI probe and dev_open

2007-02-01 Thread Jeff Garzik
Linus Torvalds wrote: On Wed, 31 Jan 2007, Francois Romieu wrote: Call chain: - rtl8169_init_one - register_netdev (dev_open starts to race...) - rtl8169_init_phy - rtl8169_set_speed - tp-set_speed - mod_timer(tp-timer, ...) (if netif_running()

Re: [RFC][PATCH][XFRM][0/5] extension for XFRM databases

2007-02-01 Thread jamal
Hello, I think i may have understood your approach before but i am a little lost right now, so bear with me. Could we not achieve your goals by using (on XFRM at least) XFRM_MSG_UPDPOLICY and XFRM_MSG_UPDSA ? cheers, jamal On Thu, 2007-01-02 at 13:09 +0900, Shinta Sugimoto wrote: Hello,

Re: [RFC][PATCH][XFRM][1/5] extension to XFRM for dynamic endpoint update (MIGRATE)

2007-02-01 Thread James Morris
On Thu, 1 Feb 2007, Shinta Sugimoto wrote: +int xfrm_migrate(struct xfrm_selector *sel, u8 dir, u8 type, + struct xfrm_migrate *m, int num_migrate) +{ + int i, err, nx_cur = 0, nx_new = 0; + struct xfrm_policy *pol = NULL; [...] +donothing: + if (pol) +

Re: [RFC][PATCH][XFRM][4/5] extension to XFRM for dynamic endpoint update (MIGRATE)

2007-02-01 Thread James Morris
On Thu, 1 Feb 2007, Shinta Sugimoto wrote: + /* allow IPSEC_PROTO_ANY to match all protocols */ + //sel.proto = pfkey_proto_to_xfrm(sa-sadb_address_proto); + sel.proto = sa-sadb_address_proto; Which one is correct ? :-) + /* allow IPSEC_PROTO_ANY to match all protocols */ +

Re: [PATCH 4/6] d80211: don't display name of invisible network device

2007-02-01 Thread Jiri Benc
On Wed, 31 Jan 2007 19:58:58 +0100, Johannes Berg wrote: Well, that's a bug indeed, but the cure isn't don't allow any qos operations but rather don't allow removal of the 802.11 qdisc. This solution can be described as don't allow 802.11 qdisc customization for now, introduce that as a new

Re: [PATCH] HTB O(1) class lookup

2007-02-01 Thread jamal
On Thu, 2007-01-02 at 07:08 +0100, Patrick McHardy wrote: I have a patch for HFSC which introduces dynamic resizing of the class hash. One thing that has bitten me recently was tests to try and see how far i can go insert xfrm SAD/SPDs - the resizing of the hashes kept allocing more and

Re: [PATCH 4/6] d80211: don't display name of invisible network device

2007-02-01 Thread Johannes Berg
On Thu, 2007-02-01 at 16:17 +0100, Jiri Benc wrote: On Wed, 31 Jan 2007 19:58:58 +0100, Johannes Berg wrote: Well, that's a bug indeed, but the cure isn't don't allow any qos operations but rather don't allow removal of the 802.11 qdisc. This solution can be described as don't allow 802.11

Re: [PATCH] spidernet : fix memory leak in spider_net_stop

2007-02-01 Thread Linas Vepstas
A variant of this patch is queued up for 2.6.21, as a part of the patch http://www.mail-archive.com/netdev@vger.kernel.org/msg28213.html I beleive its in the -mm tree, I have not checked. --linas On Thu, Feb 01, 2007 at 12:07:47PM +0100, Jens Osterkamp wrote: We forget to call

[BNX2]: PHY workaround for 5709 A0.

2007-02-01 Thread Michael Chan
[BNX2]: PHY workaround for 5709 A0. 5709 A0 copper devices will not link up with some link partners without this workaround. Update driver to 1.5.5. Signed-off-by: Michael Chan [EMAIL PROTECTED] diff --git a/drivers/net/bnx2.c b/drivers/net/bnx2.c index 953808e..ee7b75b 100644 ---

Re: sky2 or acpi problem ?

2007-02-01 Thread Stephen Hemminger
On Thu, 01 Feb 2007 18:59:55 +0100 Lionel Landwerlin [EMAIL PROTECTED] wrote: Hi, we already had words on lkml about this bug with sky2 driver. I was having problems, and you told me to use the disable_msi=1 parameter to see what happens. After a couple of hours of testing with heavly

Re: New list for wireless dev discussions

2007-02-01 Thread John W. Linville
On Tue, Jan 30, 2007 at 03:39:44PM -0500, John W. Linville wrote: At the wireless summit in London, we collectively decided to move day-to-day wireless development discussions to our own list. I am hosting a list for this purpose: http://lists.tuxdriver.org/mailman/listinfo/wireless

Re: New list for wireless dev discussions

2007-02-01 Thread Jeff Garzik
John W. Linville wrote: In response to some community requests, I have asked David Miller to create a list for us on vger.kernel.org. David has obliged that request, so I have restricted new subscriptions to [EMAIL PROTECTED] and I am asking everyone to move wireless discussions to the new

meaningful spinlock contention when bound to non-intr CPU?

2007-02-01 Thread Rick Jones
For various nefarious porpoises relating to comparing and contrasting a single 10G NIC with N 1G ports and hopefully finding interesting processor cache (mis)behaviour in the stack, I got my hands on a pair of 8 core systems with plenty of RAM and I/O slots. (rx6600 with 1.6 GHz dual-core

Re: meaningful spinlock contention when bound to non-intr CPU?

2007-02-01 Thread Rick Jones
Rick Jones wrote: A 2.6.10-rc5 kernel onto each system thanks to pointers from Dan Frazier. gaak - 2.6.20-rc5 that is. - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at

Re: [PATCH] spidernet : fix memory leak in spider_net_stop

2007-02-01 Thread Jens Osterkamp
On Thursday 01 February 2007 6:36 pm, Linas Vepstas wrote: A variant of this patch is queued up for 2.6.21, as a part of the patch http://www.mail-archive.com/netdev@vger.kernel.org/msg28213.html I beleive its in the -mm tree, I have not checked. Ah, good ! I knew that you had several

A potential bug in tcp_vegas.c

2007-02-01 Thread Xiaoliang (David) Wei
Hi gurus, I am testing tcp_vegas.c in Linux with the NS-2 TCP-Linux. It seems that the ssthresh is not correctly reset to 2 in the tcp_vegas_cong_avoid function. The problem might lead to very unfair behavior among Vegas flows, when some flows exit slow start due to loss, not delay. Please see

Re: [PATCH 3/3] Check num sacks in SACK fast path

2007-02-01 Thread David Miller
From: Baruch Even [EMAIL PROTECTED] Date: Thu, 1 Feb 2007 09:22:52 +0200 * David Miller [EMAIL PROTECTED] [070131 22:52]: We should never see a SACK block from sequence zero to zero, which would be an empty SACK block. That would work as well at the cost of extra writing to memory for

when having to acquire an SA, ipsec drops the packet

2007-02-01 Thread Joy Latten
IPsec returns EAGAIN when it needs to acquire an SA. There have been a thread or two about this... Has there been any info or progress in how best to fix this? James Morris presented some work/ideas, http://vger.kernel.org/jmorris_ipsec_sa_resolution_netconf2006.pdf When using labeled xfrms

Re: when having to acquire an SA, ipsec drops the packet

2007-02-01 Thread James Morris
On Thu, 1 Feb 2007, Joy Latten wrote: IPsec returns EAGAIN when it needs to acquire an SA. There have been a thread or two about this... Has there been any info or progress in how best to fix this? James Morris presented some work/ideas,

[take35 6/10] kevent: Pipe notifications.

2007-02-01 Thread Evgeniy Polyakov
Pipe notifications. diff --git a/fs/pipe.c b/fs/pipe.c index 68090e8..0c75bf1 100644 --- a/fs/pipe.c +++ b/fs/pipe.c @@ -16,6 +16,7 @@ #include linux/uio.h #include linux/highmem.h #include linux/pagemap.h +#include linux/kevent.h #include asm/uaccess.h #include asm/ioctls.h @@ -313,6

[take35 7/10] kevent: Signal notifications.

2007-02-01 Thread Evgeniy Polyakov
Signal notifications. This type of notifications allows to deliver signals through kevent queue. One can find example application signal.c on project homepage. If KEVENT_SIGNAL_NOMASK bit is set in raw_u64 id then signal will be delivered only through queue, otherwise both delivery types are

[take35 1/10] kevent: Description.

2007-02-01 Thread Evgeniy Polyakov
Description. diff --git a/Documentation/kevent.txt b/Documentation/kevent.txt new file mode 100644 index 000..d6e126f --- /dev/null +++ b/Documentation/kevent.txt @@ -0,0 +1,271 @@ +Description. + +int kevent_init(struct kevent_ring *ring, unsigned int ring_size, + unsigned int

[take35 4/10] kevent: Socket notifications.

2007-02-01 Thread Evgeniy Polyakov
Socket notifications. This patch includes socket send/recv/accept notifications. Signed-off-by: Evgeniy Polyakov [EMAIL PROTECTED] diff --git a/fs/inode.c b/fs/inode.c index bf21dc6..82817b1 100644 --- a/fs/inode.c +++ b/fs/inode.c @@ -21,6 +21,7 @@ #include linux/cdev.h #include

[take35 3/10] kevent: poll/select() notifications.

2007-02-01 Thread Evgeniy Polyakov
poll/select() notifications. This patch includes generic poll/select notifications. kevent_poll works simialr to epoll and has the same issues (callback is invoked not from internal state machine of the caller, but through process awake, a lot of allocations and so on). Signed-off-by: Evgeniy

[take35 10/10] kevent: Kevent based AIO (aio_sendfile()/aio_sendfile_path()).

2007-02-01 Thread Evgeniy Polyakov
Kevent based AIO (aio_sendfile()/aio_sendfile_path()). aio_sendfile()/aio_sendfile_path() contains of two major parts: AIO state machine and page processing code. The former is just a small subsystem, which allows to queue callback for theirs invocation in process' context on behalf of pool

[take35 0/10] kevent: Generic event handling mechanism.

2007-02-01 Thread Evgeniy Polyakov
Generic event handling mechanism. Kevent is a generic subsytem which allows to handle event notifications. It supports both level and edge triggered events. It is similar to poll/epoll in some cases, but it is more scalable, it is faster and allows to work with essentially eny kind of events.

[take35 8/10] kevent: Kevent posix timer notifications.

2007-02-01 Thread Evgeniy Polyakov
Kevent posix timer notifications. Simple extension to POSIX timers which allows to deliver notification of the timer expiration through kevent queue. Example application posix_timer.c can be found in archive on project homepage. Signed-off-by: Evgeniy Polyakov [EMAIL PROTECTED] diff --git

[take35 9/10] kevent: Private userspace notifications.

2007-02-01 Thread Evgeniy Polyakov
Private userspace notifications. Allows to register notifications of any private userspace events over kevent. Events can be marked as ready using kevent_ctl(KEVENT_READY) command. Signed-off-by: Evgeniy Polyakov [EMAIL PROTECTED] diff --git a/kernel/kevent/kevent_unotify.c

[take35 5/10] kevent: Timer notifications.

2007-02-01 Thread Evgeniy Polyakov
Timer notifications. Timer notifications can be used for fine grained per-process time management, since interval timers are very inconvenient to use, and they are limited. This subsystem uses high-resolution timers. id.raw[0] is used as number of seconds id.raw[1] is used as number of

ip_auto_config bug in 2.6.20-rc6

2007-02-01 Thread Joakim Tjernlund
The following commandline: root=/dev/mtdblock6 rw rootfstype=jffs2 ip=192.168.1.10:::255.255.255.0:localhost.localdomain:eth1:off console=ttyS0,115200 makes ip_auto_config fall back to DHCP and complain IP-Config: Incomplete network configuration information. depending on if CONFIG_IP_PNP_DHCP

[PATCH] net/smc911x: Match up spin lock/unlock

2007-02-01 Thread Peter Korsgaard
smc911x_phy_configure's error handling unconditionally unlocks the spinlock even if it wasn't locked. Patch fixes it. Signed-off-by: Peter Korsgaard [EMAIL PROTECTED] --- drivers/net/smc911x.c |5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) Index:

sky2 or acpi problem ?

2007-02-01 Thread Lionel Landwerlin
Hi, we already had words on lkml about this bug with sky2 driver. I was having problems, and you told me to use the disable_msi=1 parameter to see what happens. After a couple of hours of testing with heavly ethernet load, I answered you it had fixed the problem. I was wrong. Now, it takes much

Re: sky2 or acpi problem ?

2007-02-01 Thread Lionel Landwerlin
Le jeudi 01 février 2007 à 19:20 +0100, Fagyal Csongor a écrit : Lionel Landwerlin wrote: I have idle=poll now, according to this thread: http://www.gossamer-threads.com/lists/linux/kernel/725399 No lockup so far, but I only have this setting since yesterday... I tried idle=poll too,

Re: sky2 or acpi problem ?

2007-02-01 Thread Fagyal Csongor
Lionel Landwerlin wrote: Hi, we already had words on lkml about this bug with sky2 driver. I was having problems, and you told me to use the disable_msi=1 parameter to see what happens. After a couple of hours of testing with heavly ethernet load, I answered you it had fixed the problem. I was

Re: Hidden SSID's

2007-02-01 Thread Jouni Malinen
On Tue, Jan 30, 2007 at 08:35:18PM -0600, Larry Finger wrote: If one does the equivalent of 'iwlist eth1 scan essid myssid', then a probe response with NETWORK_EMPTY_ESSID set in the network flags will have 'myssid' returned in the SSID field of the returned buffer. If the input command

Re: sky2 hangs

2007-02-01 Thread Stephen Hemminger
On Thu, 1 Feb 2007 19:55:32 +0100 Thomas Glanzmann [EMAIL PROTECTED] wrote: Hello, I have a sky2 network card in my intel mac mini. It stops working when I do havy network load like watching a divx over http/sshfs. However if I remove the driver module and load it again it works and even the

Re: sky2 hangs

2007-02-01 Thread Stephen Hemminger
On Thu, 1 Feb 2007 19:55:32 +0100 Thomas Glanzmann [EMAIL PROTECTED] wrote: Hello, I have a sky2 network card in my intel mac mini. It stops working when I do havy network load like watching a divx over http/sshfs. Is this heavy Tx load (ie your watching movie from mac mini). or Rx load (you

Re: sky2 hangs

2007-02-01 Thread Thomas Glanzmann
Hello Sam, Is this heavy Tx load (ie your watching movie from mac mini). or Rx load (you are watching movie on mac mini). it's inbound (Rx) traffic. Watching a Movie, git pull from linus, or scp kernel tar tree from my laptop to my mac mini. Thomas - To unsubscribe from this list:

Re: sky2 hangs

2007-02-01 Thread Thomas Glanzmann
Hello Stephen, It was intentional in 2.6 to allow interfaces to be hot-removed. Remember with Internet protocols there is no hard binding (normally) between address and device and connections should not go down if link fails. of course. That makes sense. I just wondered when the change in

sky2 hangs

2007-02-01 Thread Thomas Glanzmann
Hello, I have a sky2 network card in my intel mac mini. It stops working when I do havy network load like watching a divx over http/sshfs. However if I remove the driver module and load it again it works and even the tcp connection doesn't get shutdown. I automated the above procedure using a

Re: sky2 hangs

2007-02-01 Thread Stephen Hemminger
I can reproduce the problem now (on mac mini). Interestingly it seems to whack the whole ethernet switch when it happens. - a previously suggested fix - passing idle=poll to the kernel - did not work for me at the end It is not an MSI or IRQ problem. It is a phy problem (see below). - the

Re: sky2 hangs

2007-02-01 Thread Fagyal Csongor
Hello, I have a sky2 network card in my intel mac mini. It stops working when I do havy network load like watching a divx over http/sshfs. However if I remove the driver module and load it again it works and even the tcp connection doesn't get shutdown. I automated the above procedure using a

Re: [Fwd: Re: [PATCH 1/10] cxgb3 - main header files]

2007-02-01 Thread Steve Wise
On Fri, 2007-01-19 at 09:07 -0800, Roland Dreier wrote: Jeff has pulled in the Chelsio Ethernet driver. If you are ready to merge in the RDMA driver, you can pull it from Yes, I saw that... OK, I'll get serious about reviewing the RDMA stuff. Hey Roland, Have you had a chance to

Re: [PATCH 10/10] cxgb3 - Add dual licensing

2007-02-01 Thread Arjan van de Ven
On Tue, 2007-01-30 at 19:44 -0800, Divy Le Ray wrote: Dual licensing, needed for OFED 1.2 Hi, did you get permission from all the people who contributed code to your driver ? If not.. that'd be a problem -- if you want to mail me at work (you don't), use arjan (at) linux.intel.com Test

Re: sky2 hangs

2007-02-01 Thread Thomas Glanzmann
Hello Fagyal, - a previously suggested fix - passing idle=poll to the kernel - did not work for me at the end same for me. I tried the two module parameters and the kernel parameter: pci=nomsi sky2.disable_msi=1 sky2.idle_timeout=1000 - the locks I have happen very periodically (somewhere

Re: sky2 hangs

2007-02-01 Thread Thomas Glanzmann
Hello Stephen, I can reproduce the problem now (on mac mini). Interestingly it seems to whack the whole ethernet switch when it happens. wow. I have Linksys wrt54g has 'ethernet switch' and my Snom 320 VoIP phone still works when the mini network card goes down. On the other side the wrt54g

Re: [Fwd: Re: [PATCH 1/10] cxgb3 - main header files]

2007-02-01 Thread Roland Dreier
Have you had a chance to review this? Still on my list. Can we trade? Can you look at the IPoIB connected mode stuff in the ipoib-cm branch in git://git.kernel.org/pub/scm/linux/kernel/git/roland/infiniband.git and let me know if you see anything you don't like? - R. - To unsubscribe