Re: bad networking related lag in v2.6.22-rc2

2007-05-24 Thread David Miller
From: Patrick McHardy [EMAIL PROTECTED] Date: Thu, 24 May 2007 07:41:00 +0200 David Miller wrote: * Herbert Xu [EMAIL PROTECTED] wrote: [NET_SCHED]: Fix qdisc_restart return value when dequeue is empty Applied, thanks everyone. Even though it didn't fix this problem, this patch I

Re: bad networking related lag in v2.6.22-rc2

2007-05-24 Thread Anant Nitya
On Thursday 24 May 2007 03:00:56 David Miller wrote: From: Ingo Molnar [EMAIL PROTECTED] Date: Wed, 23 May 2007 13:40:21 +0200 * Herbert Xu [EMAIL PROTECTED] wrote: [NET_SCHED]: Fix qdisc_restart return value when dequeue is empty My previous patch that changed the return value of

[PATCH] remove unnecessary dependency on VIA velocity config

2007-05-24 Thread Yoichi Yuasa
Hi, This patch has removed unnecessary dependency on VIA velocity config. Yoichi Signed-off-by: Yoichi Yuasa [EMAIL PROTECTED] diff -pruN -X generic/Documentation/dontdiff generic-orig/drivers/net/Kconfig generic/drivers/net/Kconfig --- generic-orig/drivers/net/Kconfig2007-05-24

Re: [IPv6] UDP Encapsulation of IPsec ESP Packets

2007-05-24 Thread Herbert Xu
Fernando Luis V??zquez Cao [EMAIL PROTECTED] wrote: I noticed that IPv4-over-IPv6 made into 2.6.21 (thank you!) and that prompted to check the progress with the implementation of rfc3948 (UDP Encapsulation of IPsec ESP Packets) in Linux. For IPv4 the code is already there, but that does not

Re: [PATCH 2/2] [IPV6] MIP6: Loadable module support for MIPv6.

2007-05-24 Thread Ingo Oeser
Masahide NAKAMURA schrieb: Ingo Oeser wrote: What about MODULE_ALIAS(xfrm-type-10-60) and MODULE_ALIAS(xfrm-type-10-43) in mip6.c ? Just replace your second patch (Loadable module support) with one, which additionally adds these two lines to mip6.c ... The aliases in modprobe.conf(5)

Re: [PATCH 2/2] [IPV6] MIP6: Loadable module support for MIPv6.

2007-05-24 Thread Herbert Xu
On Thu, May 24, 2007 at 10:48:27AM +0900, Masahide NAKAMURA wrote: I prefer to use new macro like XFRM mode to unify XFRM protocols i.e. esp[46].c, ah[46].c, ipcomp[46].c, and mip6.c if we care about it. Can I add it as extensional patch if nobody has a plan to do this yet? You're most

Re: [IPv6] UDP Encapsulation of IPsec ESP Packets

2007-05-24 Thread Fernando Luis Vázquez Cao
On Thu, 2007-05-24 at 18:34 +1000, Herbert Xu wrote: Fernando Luis V??zquez Cao [EMAIL PROTECTED] wrote: I noticed that IPv4-over-IPv6 made into 2.6.21 (thank you!) and that prompted to check the progress with the implementation of rfc3948 (UDP Encapsulation of IPsec ESP Packets) in Linux.

Re: [IPv6] UDP Encapsulation of IPsec ESP Packets

2007-05-24 Thread Fernando Luis Vázquez Cao
On Thu, 2007-05-24 at 18:03 +0900, Fernando Luis Vázquez Cao wrote: On Thu, 2007-05-24 at 18:34 +1000, Herbert Xu wrote: Fernando Luis V??zquez Cao [EMAIL PROTECTED] wrote: I noticed that IPv4-over-IPv6 made into 2.6.21 (thank you!) and that prompted to check the progress with the

Generic netlink interface help

2007-05-24 Thread Rodolfo Giometti
Hello, I'm trying to use this new API for my LinuxPPS support but I have some difficulties in understanding the code! Looking at http://linux-net.osdl.org/index.php/Generic_Netlink_HOWTO is not clear... for example in line: msg_head = genlmsg_put(skb, pid, seq, type, 0, flags,

Re: Generic netlink interface help

2007-05-24 Thread Samuel Ortiz
Hi Rodolfo, On 5/24/2007, Rodolfo Giometti [EMAIL PROTECTED] wrote: Hello, I'm trying to use this new API for my LinuxPPS support but I have some difficulties in understanding the code! Looking at http://linux-net.osdl.org/index.php/Generic_Netlink_HOWTO is not clear... for example in line:

Re: Generic netlink interface help

2007-05-24 Thread Rodolfo Giometti
On Thu, May 24, 2007 at 09:43:30AM -, Samuel Ortiz wrote: You could look at Johannes Berg 802.11 generic netlink implementation for a good example (net/wireless/nl80211.c in John Linville's tree):

Re: Generic netlink interface help

2007-05-24 Thread Samuel Ortiz
On 5/24/2007, Rodolfo Giometti [EMAIL PROTECTED] wrote: You probably want to use the libnl library. The latest SVN code has support for generic netlink: http://people.suug.ch/~tgr/libnl/ Regarding this issue I'd like to know if could be possible to avoid using this library... my LinuxPPS

Re: Generic netlink interface help

2007-05-24 Thread Rodolfo Giometti
On Thu, May 24, 2007 at 10:04:08AM -, Samuel Ortiz wrote: Yes it's possible, even though it could be more tedious and painful. I know that. Have you some links to suggest to me in order to have some programming examples? Thanks, Rodolfo -- GNU/Linux Solutions e-mail:

Re: [PATCH] fix e100 rx path on ARM (was [PATCH] e100 rx: or s and el bits)

2007-05-24 Thread Milton Miller
Some further thoughts ... On May 24, 2007, at 12:26 AM, Milton Miller wrote: On May 23, 2007, at 4:32 PM, David Acker wrote: Milton Miller wrote: My current reading of the manual is that the C bit will not be set on an RFD that is size 0. It goes on to processes EL and S, and decides to stop

Re: [NET] meth driver renovation

2007-05-24 Thread Ralf Baechle
On Wed, May 23, 2007 at 01:02:18PM -0700, Shane McDonald wrote: static void __exit meth_exit_module(void) { - unregister_netdev(meth_dev); - free_netdev(meth_dev); + platform_driver_register(meth_driver); }

[NET] meth driver renovation

2007-05-24 Thread Ralf Baechle
The meth ethernet driver for the SGI IP32 aka O2 is so far still an old style driver which does not use the device driver model. This is now causing issues with some udev based gadgetry in debian-stable. Fixed by converting the meth driver to a platform device. Signed-off-by: Ralf Baechle

Re: [PATCH] fix e100 rx path on ARM (was [PATCH] e100 rx: or s and el bits)

2007-05-24 Thread David Acker
Milton Miller wrote: On May 23, 2007, at 4:32 PM, David Acker wrote: Milton Miller wrote: My current reading of the manual is that the C bit will not be set on an RFD that is size 0. It goes on to processes EL and S, and decides to stop and interrupt RNR or suspend, or just go to the next

Re: [PATCH] PCI legacy I/O port free driver - Making Intel e1000 driver legacy I/O port free

2007-05-24 Thread Tomohiro Kusumi
Dear Auke I'm sorry for being so late. Let me answer your questions. 82545's: 82545EM_COPPER 82545EM_FIBER Here you skip 3 other 82545 device ID's, was that intentional? Maybe my understanding on the e1000 driver was wrong. I looked up the following code, and thought the device IDs

Re: [PATCH] fix e100 rx path on ARM (was [PATCH] e100 rx: or s and el bits)

2007-05-24 Thread David Acker
Milton Miller wrote: Ok here's my just-before-dinner brainstorming, as relayed after dinner: We add two flags to struct rx: one says this packet is EL, and one says it is or was size 0. We create a function, find_mark_el(struct nic, is_running) that is called after initial alloc and/or after

Re: Generic netlink interface help

2007-05-24 Thread Paul Moore
On Thursday, May 24 2007 7:21:44 am Rodolfo Giometti wrote: On Thu, May 24, 2007 at 10:04:08AM -, Samuel Ortiz wrote: Yes it's possible, even though it could be more tedious and painful. I know that. Have you some links to suggest to me in order to have some programming examples? The

Re: [PATCH 2/2] [IPV6] MIP6: Loadable module support for MIPv6.

2007-05-24 Thread Masahide NAKAMURA
Hi Ingo, Ingo Oeser wrote: Masahide NAKAMURA schrieb: Ingo Oeser wrote: What about MODULE_ALIAS(xfrm-type-10-60) and MODULE_ALIAS(xfrm-type-10-43) in mip6.c ? Just replace your second patch (Loadable module support) with one, which additionally adds these two lines to mip6.c ... The

Re: [RESEND][PATCH] [NET_SCHED]make qdisc_restart more readable

2007-05-24 Thread jamal
On Thu, 2007-24-05 at 05:41 +0200, Patrick McHardy wrote: jamal wrote: + if (unlikely (ret != NETDEV_TX_BUSY net_ratelimit())) + printk(KERN_DEBUG BUG %s code %d qlen %d\n,dev-name, ret, q-q.qlen); This seems to be based on an old version, your latest patch changed this

Re: Generic netlink interface help

2007-05-24 Thread jamal
On Thu, 2007-24-05 at 13:21 +0200, Rodolfo Giometti wrote: On Thu, May 24, 2007 at 10:04:08AM -, Samuel Ortiz wrote: Yes it's possible, even though it could be more tedious and painful. I know that. Have you some links to suggest to me in order to have some programming examples?

Re: [PATCH] fix e100 rx path on ARM (was [PATCH] e100 rx: or s and el bits)

2007-05-24 Thread Milton Miller
On May 24, 2007, at 7:51 AM, David Acker wrote: Milton Miller wrote: Comments? Questions? This sounds pretty reasonable. I will take a stab at coding this up today; I always think better looking at code. Thanks. By the way, find_mark_el should probably get passed the old fill point. The

RE: [RESEND][PATCH] [NET_SCHED]make qdisc_restart more readable

2007-05-24 Thread Waskiewicz Jr, Peter P
sigh. I wont be able to do this change until tonight or tommorow morning. I think the process i am using to re-generate patches maybe too consuming? Maybe you could offer some advice. Heres what i do: 1. clone Daves latest tree localy 2. clone another tree from that 3. create patch on

Re: [RESEND][PATCH] [NET_SCHED]make qdisc_restart more readable

2007-05-24 Thread Patrick McHardy
Waskiewicz Jr, Peter P wrote: sigh. I wont be able to do this change until tonight or tommorow morning. I think the process i am using to re-generate patches maybe too consuming? Maybe you could offer some advice. Heres what i do: 1. clone Daves latest tree localy 2. clone another tree from

Bluetooth fixes for 2.6.22-rc2

2007-05-24 Thread Marcel Holtmann
Hi Dave, here are two more bug fixes that should go into 2.6.22 before its final release. The USB driver change is minor and the L2CAP change has been verified with Bluetooth compliance tester and also the L2CAP robustness testing. Regards Marcel Please pull from

[PATCH] ethtool: new ID to decode the registers of the 8168 (realtek)

2007-05-24 Thread Francois Romieu
Tested with an Asrock 945G-DVI (LOM). Signed-off-by: Francois Romieu [EMAIL PROTECTED] --- realtek.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/realtek.c b/realtek.c index 64ab7f8..8daba69 100644 --- a/realtek.c +++ b/realtek.c @@ -45,6 +45,7 @@ static struct

Re: [PATCH] s2io: don't run MSI handlers if device is offline.

2007-05-24 Thread Jeff Garzik
Linas Vepstas wrote: Don't run any of the MSI handlers if the channel is off; also don't gather device statatistics. Also, netif_wake not needed, per suggestions from Sivakumar Subramani [EMAIL PROTECTED]. Signed-off-by: Linas Vepstas [EMAIL PROTECTED] Cc: Ramkrishna Vepa [EMAIL PROTECTED]

Re: [PATCH 1/2] ucc_geth: Fix MODULE_DEVICE_TABLE() duplication

2007-05-24 Thread Jeff Garzik
Li Yang wrote: Fix MODULE_DEVICE_TABLE() duplication in ucc_geth.c and ucc_geth_mii.c for ucc_geth to be compiled as module. Signed-off-by: Li Yang [EMAIL PROTECTED] --- drivers/net/ucc_geth_mii.c |2 -- 1 files changed, 0 insertions(+), 2 deletions(-) applied 1-2 - To unsubscribe from

Re: [PATCH] asix.c - Add Belkin F5D5055 ids

2007-05-24 Thread Jeff Garzik
David Hollis wrote: (Originally sent to linux-usb-devel) The attached patch adds the device IDs for the Belkin F5D5055 device. Reported by Andy Juniper [EMAIL PROTECTED] Signed-off-by: David Hollis [EMAIL PROTECTED] applied - To unsubscribe from this list: send the line unsubscribe

Re: [PATCH] remove unnecessary dependency on VIA velocity config

2007-05-24 Thread Jeff Garzik
Yoichi Yuasa wrote: Hi, This patch has removed unnecessary dependency on VIA velocity config. Yoichi Signed-off-by: Yoichi Yuasa [EMAIL PROTECTED] applied - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at

Re: [NET] meth driver renovation

2007-05-24 Thread Jeff Garzik
Ralf Baechle wrote: The meth ethernet driver for the SGI IP32 aka O2 is so far still an old style driver which does not use the device driver model. This is now causing issues with some udev based gadgetry in debian-stable. Fixed by converting the meth driver to a platform device.

Re: [PATCH 1/10] spidernet: skb used after netif_receive_skb

2007-05-24 Thread Jeff Garzik
Linas Vepstas wrote: From: Florin Malita [EMAIL PROTECTED] The stats update code in spider_net_pass_skb_up() is touching the skb after it's been passed up to the stack. To avoid that, just update the stats first. Signed-off-by: Florin Malita [EMAIL PROTECTED] Signed-off-by: Linas Vepstas

Re: [PATCH 2/10] spidernet: beautify error messages

2007-05-24 Thread Jeff Garzik
Linas Vepstas wrote: Make error messages print which interface they apply to. Signed-off-by: Linas Vepstas [EMAIL PROTECTED] drivers/net/spider_net.c | 10 ++ drivers/net/spider_net.h |2 +- 2 files changed, 7 insertions(+), 5 deletions(-) applied 2-10 to #upstream

Re: [Kgdb-bugreport] [PATCH] 8139too: harden against TX ring overflow

2007-05-24 Thread Sergei Shtylyov
Hello, I wrote: This driver's 4-packet deep TX queue is too sensible to the careless callers ignoring its state (like netpoll in trapped mode), so add queue full check at the start of the hard_start_xmit() method (only under #ifndef RTL8139_NDEBUG, otherwise the queue will get stuck once dirty

Re: [patch 1/6] 8139too: force media setting cleanup

2007-05-24 Thread Jeff Garzik
[EMAIL PROTECTED] wrote: From: Bernard Lee [EMAIL PROTECTED] Setting bit 4 5 alone in 8139too module media option does not really force 100Mbps full-duplex mode. When media option bit 0-3 is cleared, 8139too module does not force media setting. Therefore, bit 0-3 requires to be set for bit 4

Re: [Kgdb-bugreport] [PATCH] 8139too: harden against TX ring overflow

2007-05-24 Thread Jeff Garzik
Sergei Shtylyov wrote: Hello, I wrote: This driver's 4-packet deep TX queue is too sensible to the careless callers ignoring its state (like netpoll in trapped mode), so add queue full check at the start of the hard_start_xmit() method (only under #ifndef RTL8139_NDEBUG, otherwise the queue

Re: [Kgdb-bugreport] [PATCH] 8139too: harden against TX ring overflow

2007-05-24 Thread Sergei Shtylyov
Jeff Garzik wrote: This driver's 4-packet deep TX queue is too sensible to the careless callers ignoring its state (like netpoll in trapped mode), so add queue full check at the start of the hard_start_xmit() method (only under #ifndef RTL8139_NDEBUG, otherwise the queue will get stuck once

Re: [Kgdb-bugreport] [PATCH] 8139too: harden against TX ring overflow

2007-05-24 Thread Jeff Garzik
Sergei Shtylyov wrote: Jeff Garzik wrote: This driver's 4-packet deep TX queue is too sensible to the careless callers ignoring its state (like netpoll in trapped mode), so add queue full check at the start of the hard_start_xmit() method (only under #ifndef RTL8139_NDEBUG, otherwise the

Re: [PATCH 10/12] drivers: PMC MSP71xx ethernet driver

2007-05-24 Thread Jeff Garzik
Marc St-Jean wrote: +inline static void +mspeth_skb_headerinit(struct sk_buff *skb) +{ + /* these are essential before init */ + dst_release(skb-dst); +#ifdef CONFIG_XFRM + secpath_put(skb-sp); +#endif +#ifdef CONFIG_NETFILTER + nf_conntrack_put(skb-nfct); +#if

Re: [PATCH] Add select PHYLIB to the UCC_GETH Kconfig option

2007-05-24 Thread Jeff Garzik
Jan Altenberg wrote: ucc_geth has been migrated to use the common phylib code. So lets add a 'select PHYLIB' to the UCC_GETH Kconfig entry. Signed-off-by: Jan Altenberg [EMAIL PROTECTED] --- drivers/net/Kconfig |1 + 1 file changed, 1 insertion(+) Index: linux-2.6/drivers/net/Kconfig

Re: [PATCH] ethtool: new ID to decode the registers of the 8168 (realtek)

2007-05-24 Thread Jeff Garzik
Francois Romieu wrote: Tested with an Asrock 945G-DVI (LOM). Signed-off-by: Francois Romieu [EMAIL PROTECTED] --- realtek.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) applied Also, I have really fallen off the ball when it comes to the r8169 kernel driver. My apologies.

Re: [PATCH 1/4] forcedeth: add vitesse phy

2007-05-24 Thread Jeff Garzik
Ayaz Abdulla wrote: This patch adds errata support for the vitesse phy. Signed-off-by: Ayaz Abdulla [EMAIL PROTECTED] --- old/drivers/net/forcedeth.c 2007-05-01 15:30:53.0 -0400 +++ new/drivers/net/forcedeth.c

Re: [PATCH 2/4] forcedeth: fix power management support

2007-05-24 Thread Jeff Garzik
Ayaz Abdulla wrote: This patch fixes the power management functions. It includes lowering the phy speed to conserve power. Signed-off-by: Ayaz Abdulla [EMAIL PROTECTED] Several issues here: 1) Your patch description needs to explain the problems in the power management code. It is

Re: [PATCH 4/4] forcedeth: version bump

2007-05-24 Thread Jeff Garzik
Ayaz Abdulla wrote: This patch bumps up the version. Signed-off-by: Ayaz Abdulla [EMAIL PROTECTED] --- old/drivers/net/forcedeth.c 2007-05-21 20:09:03.0 -0400 +++ new/drivers/net/forcedeth.c 2007-05-21

Re: [PATCH 3/4] forcedeth: fix cpu irq mask

2007-05-24 Thread Jeff Garzik
Ayaz Abdulla wrote: This patch fixes the cpu irq mask define to include the timer irq. Another flag check was setting up the timer bit in all cases so we didn't notice the issue. Signed-off-by: Ayaz Abdulla [EMAIL PROTECTED] applied to #upstream-fixes - To unsubscribe from this list: send

Re: [PATCH 10/12] drivers: PMC MSP71xx ethernet driver

2007-05-24 Thread Marc St-Jean
Jeff Garzik wrote: Marc St-Jean wrote: +inline static void +mspeth_skb_headerinit(struct sk_buff *skb) +{ + /* these are essential before init */ + dst_release(skb-dst); +#ifdef CONFIG_XFRM + secpath_put(skb-sp); +#endif +#ifdef CONFIG_NETFILTER +

Re: [PATCH 10/12] drivers: PMC MSP71xx ethernet driver

2007-05-24 Thread Jeff Garzik
Marc St-Jean wrote: I asked if the remaining section (above) was acceptable so we could retain our buffer recycling which enhances throughput. I never received a rely so it was left in my last patch. The above comment now answers my part of my initial question. Are you aware of a better way to

[git patches] net driver fixes

2007-05-24 Thread Jeff Garzik
Please pull from 'upstream-linus' branch of master.kernel.org:/pub/scm/linux/kernel/git/jgarzik/netdev-2.6.git upstream-linus to receive the following updates: arch/mips/sgi-ip32/Makefile |2 +- arch/mips/sgi-ip32/ip32-platform.c | 20 + drivers/net/Kconfig

[PATCH 0/7] sky2: patches for 2.6.22

2007-05-24 Thread Stephen Hemminger
The following are non-critical fixes found during review of code. I don't expect them to fix the outstanding bugzilla or mailing list problem reports. Mostly they are of the form, don't touch bits that aren't used on that chip. -- Stephen Hemminger [EMAIL PROTECTED] - To unsubscribe from this

[PATCH 5/7] sky2: enable IRQ on duplex renegotiation

2007-05-24 Thread Stephen Hemminger
Don't want IRQ on FIFO error because there is nothing useful to do with it. But do want IRQ on duplex change. Signed-off-by: Stephen Hemminger [EMAIL PROTECTED] --- a/drivers/net/sky2.h2007-05-22 10:42:36.0 -0700 +++ b/drivers/net/sky2.h2007-05-22 10:44:35.0 -0700

[PATCH 6/7] sky2: enable clocks before probe

2007-05-24 Thread Stephen Hemminger
Some chips need to have internal clocks enabled (via PCI config) before the PCI space is readable. Signed-off-by: Stephen Hemminger [EMAIL PROTECTED] --- drivers/net/sky2.c | 102 ++--- drivers/net/sky2.h | 19 + 2 files changed, 92

[PATCH 2/7] sky2: checksum offload plus vlan bug

2007-05-24 Thread Stephen Hemminger
Driver was not correctly setting up transmit descriptor when doing VLAN tag insertion with checksum offload. Signed-off-by: Stephen Hemminger [EMAIL PROTECTED] --- a/drivers/net/sky2.c2007-05-22 10:42:36.0 -0700 +++ b/drivers/net/sky2.c2007-05-22 10:43:12.0 -0700

[PATCH 4/7] sky2: PHY page register fixes

2007-05-24 Thread Stephen Hemminger
Several of the PHY registers are multiplexed; access to register must be proceeded by setting page register. The driver setup is safer if this is done before the access rather than depending on the last value. Signed-off-by: Stephen Hemminger [EMAIL PROTECTED] --- drivers/net/sky2.c | 25

[PATCH 1/7] sky2: dont set bogus bit in PHY register

2007-05-24 Thread Stephen Hemminger
This code inherited from the sk98lin driver is incorrect on the Yukon2. The GPHY_CTRL register values are specific to the internal PHY of the chip and the values used were leftovers. Driver was setting bit 13 which is now the INT polarity for the PHY! Signed-off-by: Stephen Hemminger [EMAIL

[PATCH 7/7] sky2: version 1.15

2007-05-24 Thread Stephen Hemminger
Why? Most bug reports on vendor kernels with backported drivers. Signed-off-by: Stephen Hemminger [EMAIL PROTECTED] --- drivers/net/sky2.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/net/sky2.c2007-05-24 11:20:26.0 -0700 +++ b/drivers/net/sky2.c

[PATCH 3/7] sky2: program proper register for fiber PHY

2007-05-24 Thread Stephen Hemminger
Driver was reading value from one register, setting bit and then writing the wrong register. Signed-off-by: Stephen Hemminger [EMAIL PROTECTED] --- a/drivers/net/sky2.c2007-05-22 10:43:12.0 -0700 +++ b/drivers/net/sky2.c2007-05-22 10:44:32.0 -0700 @@ -364,7 +364,7

Re: [PATCH 10/12] drivers: PMC MSP71xx ethernet driver

2007-05-24 Thread Marc St-Jean
Jeff Garzik wrote: Marc St-Jean wrote: I asked if the remaining section (above) was acceptable so we could retain our buffer recycling which enhances throughput. I never received a rely so it was left in my last patch. The above comment now answers my part of my initial

Re: [PATCH] ethtool: new ID to decode the registers of the 8168 (realtek)

2007-05-24 Thread Francois Romieu
Jeff Garzik [EMAIL PROTECTED] : [...] Would you be kind enough to resend ? Of course. If there are important bug fixes that need to go into 2.6.22, that are safe enough to put in at this late date, please split those off from other improvements. It's safer and simpler to wait for the next

Re: Bluetooth fixes for 2.6.22-rc2

2007-05-24 Thread David Miller
From: Marcel Holtmann [EMAIL PROTECTED] Date: Thu, 24 May 2007 18:47:24 +0200 Hi Dave, here are two more bug fixes that should go into 2.6.22 before its final release. The USB driver change is minor and the L2CAP change has been verified with Bluetooth compliance tester and also the L2CAP

Re: [PATCH netdev] wrong timeout value in sk_wait_data() v2

2007-05-24 Thread David Miller
From: Vasily Averin [EMAIL PROTECTED] Date: Thu, 24 May 2007 09:23:14 +0400 sys_setsockopt() do not check properly timeout values for SO_RCVTIMEO/SO_SNDTIMEO, for example it's possible to set negative timeout values. POSIX do not defines behaviour for sys_setsockopt in case negative timeouts,

Re: [PATCH][af_key]pfkey_add: Optimize SA adds and algorithm probes

2007-05-24 Thread Mark Huth
Herbert Xu wrote: On Fri, May 18, 2007 at 02:34:12PM +1000, Herbert Xu wrote: Actually, I think we should just probe for the specific algorithm requested rather than everything. See patch below. Doh, forgot to actually remove the probe call :) [IPSEC] pfkey: Load specific algorithm in

Re: [PATCH][af_key]pfkey_add: Optimize SA adds and algorithm probes

2007-05-24 Thread David Miller
From: Mark Huth [EMAIL PROTECTED] Date: Thu, 24 May 2007 17:15:30 -0700 I'm a bit curious why all of the crypto modules got loaded, but it doesn't matter. When SADB_REGISTER is performed on a PF_KEY socket, it calls xfrm_probe_algs() which iterates over the lists and loads all the availble

[PATCH]: Packet drops during larval state resolution

2007-05-24 Thread David Miller
The current IPSEC rule resolution behavior we have does not work for a lot of people, even though technically it's an improvement from the -EAGAIN buisness we had before. Right now we'll block until the key manager resolves the route. That works for simple cases, but many folks would rather

Re: [RESEND][PATCH] [NET_SCHED]make qdisc_restart more readable

2007-05-24 Thread jamal
On Thu, 2007-24-05 at 18:13 +0200, Patrick McHardy wrote: Waskiewicz Jr, Peter P wrote: One tree, multiple branches, very quick to move between them, low overhead. If this works for you, also look at stacked GIT (stg) for pushing and popping patches from your tree - very handy. I

[RESEND][PATCH] [NET_SCHED]make qdisc_restart more readable

2007-05-24 Thread jamal
Dave please apply this patch; against latest net-2.6 cheers, jamal [NET_SCHED]: Cleanup readability of qdisc restart Over the years this code has gotten hairier. Resulting in many long discussions over long summer days and patches that get it wrong. This patch helps tame that code so normal

Re: [RESEND][PATCH] [NET_SCHED]make qdisc_restart more readable

2007-05-24 Thread David Miller
From: jamal [EMAIL PROTECTED] Date: Thu, 24 May 2007 21:58:00 -0400 Dave please apply this patch; against latest net-2.6 Jamal, as much as I love your patch, it's a cleanup and doesn't fix any bugs and we're outside of the merge window for 2.6.22 I'll queue this up for sure when I open up the

Re: [RESEND][PATCH] [NET_SCHED]make qdisc_restart more readable

2007-05-24 Thread jamal
On Thu, 2007-24-05 at 19:03 -0700, David Miller wrote: I'll queue this up for sure when I open up the 2.6.23 tree. Thats good enough - thanks. cheers, jamal - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at

RE: [PATCH] Add select PHYLIB to the UCC_GETH Kconfig option

2007-05-24 Thread Li Yang-r58472
-Original Message- From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] On Behalf Of Jeff Garzik Sent: Friday, May 25, 2007 5:48 AM To: Jan Altenberg Cc: Phillips Kim-R1AAHA; [EMAIL PROTECTED]; netdev@vger.kernel.org Subject: Re: [PATCH] Add select PHYLIB to the UCC_GETH Kconfig option

[PATCH] [XFRM]: Add module alias for transformation type. (Re: [PATCH 2/2] [IPV6] MIP6: Loadable module support for MIPv6.)

2007-05-24 Thread nakam
Hi Ingo and all, This is the third one of MIPv6 module patch. It can be applied after two patches which are already sent to the list. Could you review it? It is clean-up for XFRM type modules and adds aliases with its protocol: ESP, AH, IPCOMP, IPIP and IPv6 for IPsec ROUTING and DSTOPTS for

[PATCH]: Make XFRM_ACQ_EXPIRES tweakable

2007-05-24 Thread David Miller
I've had several requests for the capability to change this timeout, which I think is perfectly reasonable. So I intend to merge the following upstream unless I hear some objections :-) commit 7191f131aff4797f2a906495c7b285d8adf47da2 Author: David S. Miller [EMAIL PROTECTED] Date: Thu May 24

Re: [PATCH]: Make XFRM_ACQ_EXPIRES tweakable

2007-05-24 Thread Eric Dumazet
David Miller a écrit : I've had several requests for the capability to change this timeout, which I think is perfectly reasonable. So I intend to merge the following upstream unless I hear some objections :-) commit 7191f131aff4797f2a906495c7b285d8adf47da2 Author: David S. Miller [EMAIL

Re: [PATCH] [XFRM]: Add module alias for transformation type. (Re: [PATCH 2/2] [IPV6] MIP6: Loadable module support for MIPv6.)

2007-05-24 Thread Herbert Xu
On Fri, May 25, 2007 at 01:23:23PM +0900, [EMAIL PROTECTED] wrote: diff --git a/include/net/xfrm.h b/include/net/xfrm.h index 1e53520..c9f895f 100644 --- a/include/net/xfrm.h +++ b/include/net/xfrm.h @@ -19,9 +19,19 @@ #include net/ipv6.h #include net/ip6_fib.h +#define

Re: [PATCH] [XFRM]: Add module alias for transformation type.

2007-05-24 Thread YOSHIFUJI Hideaki / 吉藤英明
In article [EMAIL PROTECTED] (at Fri, 25 May 2007 15:32:20 +1000), Herbert Xu [EMAIL PROTECTED] says: On Fri, May 25, 2007 at 01:23:23PM +0900, [EMAIL PROTECTED] wrote: diff --git a/include/net/xfrm.h b/include/net/xfrm.h index 1e53520..c9f895f 100644 --- a/include/net/xfrm.h +++

Re: [PATCH] [XFRM]: Add module alias for transformation type.

2007-05-24 Thread Herbert Xu
On Fri, May 25, 2007 at 02:34:34PM +0900, YOSHIFUJI Hideaki / 吉藤英明 wrote: Could we use the existing IPPROTO_* values for all of these? No, because they are of enums. Good point. I've forgotten about these module alias hacks :) Cheers, -- Visit Openswan at http://www.openswan.org/ Email:

[PATCH] NET: add MAINTAINERS entry for ucc_geth driver

2007-05-24 Thread Li Yang
Signed-off-by: Li Yang [EMAIL PROTECTED] --- MAINTAINERS |7 +++ 1 files changed, 7 insertions(+), 0 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index 4c3277c..3faed72 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -1463,6 +1463,13 @@ L: [EMAIL PROTECTED] L: [EMAIL