Re: [PATCH] make all initialized struct seq_operations const

2007-07-11 Thread David Miller
From: Philippe De Muyter [EMAIL PROTECTED] Date: Fri, 6 Jul 2007 15:25:43 +0200 Make all initialized struct seq_operations in net/ const Signed-off-by: Philippe De Muyter [EMAIL PROTECTED] Applied, thanks a lot. - To unsubscribe from this list: send the line unsubscribe netdev in the body of

Re: [PATCH v2 -mm 8/9] netconsole: Support multiple logging targets

2007-07-11 Thread Satyam Sharma
Hi Joel, On Tue, 10 Jul 2007, Joel Becker wrote: On Wed, Jul 11, 2007 at 03:47:09AM +0530, Satyam Sharma wrote: Hmm, I put it in there because I expected that the user must have had at least one target configured (added to target_list) if he's got the module loaded/built-in (and netconsole

Re: [PATCH] [NET]: Another unnecessary net/tcp.h inclusion in net/dn.h

2007-07-11 Thread David Miller
From: Ilpo_Järvinen [EMAIL PROTECTED] Date: Sun, 8 Jul 2007 18:26:26 +0300 (EEST) No longer needed. Signed-off-by: Ilpo Järvinen [EMAIL PROTECTED] Applied, thanks a lot! - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More

Re: [PATCH] [2.6.22] Remove unneeded pointer idev from addrconf_cleanup() in net/ipv6/addrconf.c

2007-07-11 Thread David Miller
From: Micah Gruber [EMAIL PROTECTED] Date: Mon, 9 Jul 2007 11:30:46 +0800 This trivial patch removes the unneeded pointer idev returned from __in6_dev_get(), which is never used. The check for NULL can be simply done by if (__in6_dev_get(dev) == NULL). Signed-off-by: Micah Gruber [EMAIL

Re: [PATCH net-2.6.23 take2] UDP: Cleanup UDP encapsulation code

2007-07-11 Thread David Miller
From: Patrick McHardy [EMAIL PROTECTED] Date: Fri, 06 Jul 2007 15:31:56 +0200 Rémi Denis-Courmont wrote: On Thursday 05 July 2007 20:25:50 ext James Chapman wrote: Rémi Denis-Courmont wrote: By the way, couldn't encap_type be remove altogether (using two slightly different callbacks

Re: [PATCH resend] rewrite AF_UNIX garbage collector, fixes race

2007-07-11 Thread Miklos Szeredi
But myself, nor any other developers, are going to review your work any faster if you do things like try to slip things in behind the maintainer's back as you attempted to do yesterday by asking Andrew to put your AF_UNIX garbage collector rewrite directly into his -mm tree. mmm... I

Re: [PATCH resend] rewrite AF_UNIX garbage collector, fixes race

2007-07-11 Thread David Miller
From: Miklos Szeredi [EMAIL PROTECTED] Date: Wed, 11 Jul 2007 08:41:30 +0200 This may seem low priority and irrelevant, but it _is_ a bug, and it's affecting a real world application. So please take that into consideration. I'm not the only person who hasn't reviewed your latest patch yet.

Re: [PATCH resend] rewrite AF_UNIX garbage collector, fixes race

2007-07-11 Thread Miklos Szeredi
This may seem low priority and irrelevant, but it _is_ a bug, and it's affecting a real world application. So please take that into consideration. I'm not the only person who hasn't reviewed your latest patch yet. You may want to consider that this might have something to do with

Re: [PATCH resend] rewrite AF_UNIX garbage collector, fixes race

2007-07-11 Thread David Miller
From: Miklos Szeredi [EMAIL PROTECTED] Date: Wed, 11 Jul 2007 09:04:10 +0200 Dave, I really appreciate the work you do. Please forgive my impatience. No problem. Your patch is first in line for me to review tomorrow ok? - To unsubscribe from this list: send the line unsubscribe netdev in the

Re: [PATCH resend] rewrite AF_UNIX garbage collector, fixes race

2007-07-11 Thread Miklos Szeredi
Dave, I really appreciate the work you do. Please forgive my impatience. No problem. Your patch is first in line for me to review tomorrow ok? Great, thanks. Miklos - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More

Re: Races in net_rx_action vs netpoll?

2007-07-11 Thread Olaf Kirch
On Wednesday 11 July 2007 07:44, David Miller wrote: +#ifdef CONFIG_NETPOLL + /* Prevent race with netpoll - yes, this is a kludge. +* But at least it doesn't penalize the non-netpoll +* code path. */ + if (test_bit(__LINK_STATE_POLL_LIST_FROZEN, dev-state)) +

Re: [Cbe-oss-dev] [PATCH] spidernet: don't use debug flag

2007-07-11 Thread Ishizaki Kou
Linas-san, GDTDCEIDIS flag is defined that it is for debug and should not be used. !? Certainly, my spec doesn't say anything like this; First, I'm sorry to say that GDTDCEDIS is for debug. It's my misunderstanding. My HW manual of SCC simply said that GDTDCEDIS must not be set(Is it same

Bluetooth patches for 2.6.23

2007-07-11 Thread Marcel Holtmann
Hi Dave, these are the Bluetooth patches for the 2.6.23 kernel release. Please pull and send them of to Linus. Regards Marcel Please pull from git://git.kernel.org/pub/scm/linux/kernel/git/holtmann/bluetooth-2.6.git This will update the following files: drivers/bluetooth/hci_usb.c

Re: Bluetooth patches for 2.6.23

2007-07-11 Thread Christoph Hellwig
On Wed, Jul 11, 2007 at 10:09:23AM +0200, Marcel Holtmann wrote: Hi Dave, these are the Bluetooth patches for the 2.6.23 kernel release. Please pull and send them of to Linus. Any chance you could take a look at http://lkml.org/lkml/2007/4/22/199 for the next merge batch? - To unsubscribe

[PATCH][RFC] network splice receive v3

2007-07-11 Thread Jens Axboe
Hi, Here's an updated implementation of tcp network splice receive support. It actually works for me now, no data corruption seen. For the original announcement and how to test it, see: http://marc.info/?l=linux-netdevm=118103093400770w=2 The splice core changes needed to support this are now

[PATCH] Virtual ethernet device (v2.1)

2007-07-11 Thread Pavel Emelianov
= Since the netlink NEWLINK interface is now in the netdev tree I resend the veth driver patch as submittion for inclusion. = LOG: Veth stands for Virtual ETHernet. It is a

[PATCH] Module for ip utility to support veth device (v.2.1)

2007-07-11 Thread Pavel Emelianov
The usage is # ip link add [name] type veth [peer name] [mac mac] [peer_mac mac] This version doesn't include the fix for ip/iplink.c as Patrick said that he had included it into his patches already. Signed-off-by: Pavel Emelianov [EMAIL PROTECTED] --- Makefile|6 +++- link_veth.c |

Re: [git patches] net driver updates

2007-07-11 Thread Jiri Kosina
On Tue, 10 Jul 2007, Jeff Garzik wrote: Various minor updates. The only thing of note is sk98lin driver removal. Please pull from 'upstream-linus' branch of master.kernel.org:/pub/scm/linux/kernel/git/jgarzik/netdev-2.6.git upstream-linus This is probably going to cause a new entry in

Re: [PATCH 0/5] more about numa_node with struct device

2007-07-11 Thread Christoph Hellwig
On Tue, Jul 10, 2007 at 04:52:19PM -0700, Yinghai Lu wrote: these are revised or new patch with numa_node in struct device in addition to Do you have a pointer to a background posting why you want all this? - To unsubscribe from this list: send the line unsubscribe netdev in the body of a

Re: [PATCH] Virtual ethernet device (v2.1)

2007-07-11 Thread Evgeniy Polyakov
Hi. On Wed, Jul 11, 2007 at 01:31:15PM +0400, Pavel Emelianov ([EMAIL PROTECTED]) wrote: Veth stands for Virtual ETHernet. It is a simple tunnel driver that works at the link layer and looks like a pair of ethernet devices interconnected with each other. Mainly it allows to communicate

Re: Bluetooth patches for 2.6.23

2007-07-11 Thread Marcel Holtmann
Hi Christoph, these are the Bluetooth patches for the 2.6.23 kernel release. Please pull and send them of to Linus. Any chance you could take a look at http://lkml.org/lkml/2007/4/22/199 for the next merge batch? the patch looks good, but it hasn't had enough testing and I need to get

Re: [RFC][PATCH v2 -mm 0/9] netconsole: Multiple targets and dynamic reconfigurability

2007-07-11 Thread Keiichi KII
Hi Satyam, I'm going to test/review these patches and report the result of tests on IA64/x86 until this Friday. [0/9] netconsole: Multiple targets and dynamic reconfigurability This patchset is a rework of the original idea and patches posted by Keiichi Kii and Takayoshi Kochi at:

Re: sky2 hangs without any messages

2007-07-11 Thread Daniel J Blueman
On 05/07/07, Stephen Hemminger [EMAIL PROTECTED] wrote: Well, it didn't fix my test, but it made it better. The following seemed to work longer... --- a/drivers/net/sky2.c2007-07-05 09:09:45.0 -0700 +++ b/drivers/net/sky2.c2007-07-05 09:09:51.0 -0700 @@ -2490,6

Re: [PATCH] Virtual ethernet device (v2.1)

2007-07-11 Thread Christian Borntraeger
Am Mittwoch, 11. Juli 2007 schrieb Pavel Emelianov: drivers/net/veth.c | 452 include/net/veth.h | 14 + I know, I am late in the game, but wont the name collide somewhat with drivers/net/ibmveth.h, drivers/net/iseries_veth.c, and drivers/net/ibmveth.c? Christian - To unsubscribe from

Re: [PATCH 1/5] try parent numa_node at first before using default

2007-07-11 Thread Stefan Richter
Yinghai Lu wrote: --- a/drivers/base/core.c +++ b/drivers/base/core.c @@ -547,6 +547,8 @@ static void klist_children_put(struct klist_node *n) void device_initialize(struct device *dev) { + int node; + kobj_set_kset_s(dev, devices_subsys); kobject_init(dev-kobj);

ethtool locking

2007-07-11 Thread Ben Dooks
I am currently upgrading the DM9000 network driver to support ethtool for items such as controlling the MII interface and have the following question about locking with the ethtool interface: Most devices use an overall spinlock when changing the settings such as in the 8139too.c driver: static

Re: [PATCH 1/5] try parent numa_node at first before using default

2007-07-11 Thread Stefan Richter
I wrote: - device_move() should update the device.node. device.numa_node of course. -- Stefan Richter -=-=-=== -=== -=-== http://arcgraph.de/sr/ - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at

Re: [PATCH v2 -mm 4/9] netconsole: Add some useful tips to documentation

2007-07-11 Thread Jesper Juhl
On 11/07/07, Satyam Sharma [EMAIL PROTECTED] wrote: On Tue, 10 Jul 2007, Joel Becker wrote: On Wed, Jul 11, 2007 at 03:40:22AM +0530, Satyam Sharma wrote: IMHO something that mentions /proc/sys/kernel/printk would be better. You don't need to have built with SysRq support for that, it's

Re: iproute2 showing wrong number of bytes on 64bit architectures.

2007-07-11 Thread Andreas Henriksson
(Sorry for breaking the thread, please CC me on future replies...) If I understand the discussion correctly, the problem in itself isn't greater then that different methods of gathering the statistics have different rollovers and thus confuse people who aren't aware of which method each tool

Re: [PATCH] Virtual ethernet device (v2.1)

2007-07-11 Thread Pavel Emelianov
Christian Borntraeger wrote: Am Mittwoch, 11. Juli 2007 schrieb Pavel Emelianov: drivers/net/veth.c | 452 include/net/veth.h | 14 + I know, I am late in the game, but wont the name collide somewhat with drivers/net/ibmveth.h, drivers/net/iseries_veth.c, and drivers/net/ibmveth.c?

Re: [PATCH] Virtual ethernet device (v2.1)

2007-07-11 Thread Patrick McHardy
Pavel Emelianov wrote: +static const struct nla_policy veth_policy[VETH_INFO_MAX + 1] = { + [VETH_INFO_MAC] = { .type = NLA_BINARY, .len = ETH_ALEN }, + [VETH_INFO_PEER]= { .type = NLA_STRING }, + [VETH_INFO_PEER_MAC]= { .type = NLA_BINARY, .len = ETH_ALEN },

Re: [PATCH] IPv6: optionaly validate RAs on raw sockets

2007-07-11 Thread YOSHIFUJI Hideaki / 吉藤英明
In article [EMAIL PROTECTED] (at Tue, 10 Jul 2007 21:11:17 +0300), Remi Denis-Courmont [EMAIL PROTECTED] says: ICMPv6 Router Advertisements may now contain informations that is mostly of interest to userland. This currently mostly consists of recursive DNS server addresses (though one should

Re: [PATCH] IPv6: optionaly validate RAs on raw sockets

2007-07-11 Thread Rémi Denis-Courmont
On Wednesday 11 July 2007 15:29:16 YOSHIFUJI Hideaki / 吉藤英明 wrote: In article [EMAIL PROTECTED] (at Tue, 10 Jul 2007 21:11:17 +0300), Remi Denis-Courmont [EMAIL PROTECTED] says: ICMPv6 Router Advertisements may now contain informations that is mostly of interest to userland. This currently

Re: [PATCH] Virtual ethernet device (v2.1)

2007-07-11 Thread Pavel Emelianov
Patrick McHardy wrote: Pavel Emelianov wrote: +static const struct nla_policy veth_policy[VETH_INFO_MAX + 1] = { +[VETH_INFO_MAC] = { .type = NLA_BINARY, .len = ETH_ALEN }, +[VETH_INFO_PEER]= { .type = NLA_STRING }, +[VETH_INFO_PEER_MAC]= { .type = NLA_BINARY,

[IPROUTE]: Fix meta ematch usage of 0 values

2007-07-11 Thread Patrick McHardy
[IPROUTE]: Fix meta ematch usage of 0 values em_meta doesn't send 0 values to the kernel. breaking matching on them and resulting in Missing value TLV messages on dump. Signed-off-by: Patrick McHardy [EMAIL PROTECTED] diff --git a/tc/em_meta.c b/tc/em_meta.c index 5fc0c59..b727422 100644 ---

Re: [PATCH] Virtual ethernet device (v2.1)

2007-07-11 Thread Patrick McHardy
Pavel Emelianov wrote: Patrick McHardy wrote: Pavel Emelianov wrote: +static const struct nla_policy veth_policy[VETH_INFO_MAX + 1] = { +[VETH_INFO_MAC] = { .type = NLA_BINARY, .len = ETH_ALEN }, +[VETH_INFO_PEER]= { .type = NLA_STRING }, +[VETH_INFO_PEER_MAC]=

Re: [PATCH] Virtual ethernet device (v2.1)

2007-07-11 Thread Pavel Emelianov
Patrick McHardy wrote: Pavel Emelianov wrote: Patrick McHardy wrote: Pavel Emelianov wrote: +static const struct nla_policy veth_policy[VETH_INFO_MAX + 1] = { + [VETH_INFO_MAC] = { .type = NLA_BINARY, .len = ETH_ALEN }, + [VETH_INFO_PEER]= { .type = NLA_STRING }, +

Re: Fwd: r8169 driver supporting the 8167 dev ID

2007-07-11 Thread Jonathan Larsen
I got git installed on my dev box. i went to my linux source dir and ran, git init git add . git format-patch v2.6.18..v2.6.23-rc1 -- drivers/net/r8169.c and i got an error fatal: bad revision 'v2.6.18..v2.6.23-rc1' what did i do wrong? im sure im missing something easy. On 7/10/07, Jonathan

Re: [PATCH] Virtual ethernet device (v2.1)

2007-07-11 Thread Patrick McHardy
Pavel Emelianov wrote: Patrick McHardy wrote: Mhh doing it later means dealing with compatibility issues, which is why I'm asking now. We currently support IFLA_NAME, IFLA_MTU, Oh, I see. IFLA_TXQLEN, IFLA_WEIGTH, IFLA_OPERSTATE and IFLA_LINKMODE, and with my patch additionally

Re: [PATCH] IPv6: optionaly validate RAs on raw sockets

2007-07-11 Thread David Stevens
I think #2 in your list is the right choice, and that has nothing to do with adding a non-standard option (which I completely agree is a bad idea). It looked like you're just checking if the machine is acting as a router or not and if it comes from a link-local address; is that right? Of

Re: [PATCH] Virtual ethernet device (v2.1)

2007-07-11 Thread Pavel Emelianov
Patrick McHardy wrote: Pavel Emelianov wrote: Patrick McHardy wrote: Mhh doing it later means dealing with compatibility issues, which is why I'm asking now. We currently support IFLA_NAME, IFLA_MTU, Oh, I see. IFLA_TXQLEN, IFLA_WEIGTH, IFLA_OPERSTATE and IFLA_LINKMODE, and with my

Re: No network on Asus P5B (r8169)

2007-07-11 Thread Clemens Brunner
Francois Romieu wrote: Does your setup exclude the wake up issue described in http://gentoo-wiki.com/HARDWARE_RTL8168 ? You're right, that was the problem! With the wake up on LAN option enabled in Windows, networking is working perfectly in Linux (32 bit and 64 bit). Which leaves only one

[NET]: gen_estimator deadlock fix

2007-07-11 Thread Ranko Zivojnovic
Fixes ABBA deadlock noted by Patrick McHardy [EMAIL PROTECTED]: There is at least one ABBA deadlock, est_timer() does: read_lock(est_lock) spin_lock(e-stats_lock) (which is dev-queue_lock) and qdisc_destroy calls htb_destroy under dev-queue_lock, which calls htb_destroy_class, then

Re: [Bugme-new] [Bug 8724] New: Unaligned acess in udp_recvmsg() on EV56

2007-07-11 Thread Ivan Kokshaysky
On Sun, Jul 08, 2007 at 03:29:35PM -0700, Andrew Morton wrote: This problem does NOT seem to affect my Tsunami/Shark (EV68AL) box running the same kernel version on the same LAN. Not sure if it's CPU generation related (EV5 vs EV6), or if it's the NIC (via_rhine on the EV5 vs e100 on

Re: [PATCH] IPv6: optionaly validate RAs on raw sockets

2007-07-11 Thread Vlad Yasevich
Rémi Denis-Courmont wrote: On Wednesday 11 July 2007 15:29:16 YOSHIFUJI Hideaki / 吉藤英明 wrote: In article [EMAIL PROTECTED] (at Tue, 10 Jul 2007 21:11:17 +0300), Remi Denis-Courmont [EMAIL PROTECTED] says: ICMPv6 Router Advertisements may now contain informations that is mostly of interest to

[PATCH 1/1] eHEA: Introducing support vor DLPAR memory add

2007-07-11 Thread Thomas Klein
This patch adds support for DLPAR memory add to the eHEA driver. To detect whether memory was added the driver uses its own memory mapping table and checks for kernel addresses whether they're located in already known memory sections. If not the function ehea_rereg_mrs() is triggered which

[RFC 0/3] lro: Generic Large Receive Offload for TCP traffic

2007-07-11 Thread Jan-Bernd Themann
Generic Large Receive Offload proposal After some discussions on the mailing list concerning our LRO approach, we agreed to provide a generic LRO patch. The algorithm is based on the version we developed for eHEA. The performance improvements we observed were significant. The LRO functionality

[RFC 3/3] lro: LRO support for eHEA

2007-07-11 Thread Jan-Bernd Themann
LRO support for eHEA Signed-off-by: Jan-Bernd Themann [EMAIL PROTECTED] --- drivers/net/ehea/ehea.h |9 +++- drivers/net/ehea/ehea_main.c | 102 +++--- 2 files changed, 104 insertions(+), 7 deletions(-) diff --git a/drivers/net/ehea/ehea.h

[RFC 2/3] lro: Kconfig and Makefile

2007-07-11 Thread Jan-Bernd Themann
Kconfig and Makefile changes for LRO Signed-off-by: Jan-Bernd Themann [EMAIL PROTECTED] --- net/ipv4/Kconfig |9 + net/ipv4/Makefile |1 + 2 files changed, 10 insertions(+), 0 deletions(-) diff --git a/net/ipv4/Kconfig b/net/ipv4/Kconfig index 010fbb2..25279f4 100644 ---

Re: sky2 hangs without any messages

2007-07-11 Thread Stephen Hemminger
On Wed, 11 Jul 2007 11:15:20 +0100 Daniel J Blueman [EMAIL PROTECTED] wrote: On 05/07/07, Stephen Hemminger [EMAIL PROTECTED] wrote: Well, it didn't fix my test, but it made it better. The following seemed to work longer... --- a/drivers/net/sky2.c2007-07-05 09:09:45.0

Re: ethtool locking

2007-07-11 Thread Stephen Hemminger
On Wed, 11 Jul 2007 11:58:08 +0100 Ben Dooks [EMAIL PROTECTED] wrote: I am currently upgrading the DM9000 network driver to support ethtool for items such as controlling the MII interface and have the following question about locking with the ethtool interface: Most devices use an overall

Re: sky2 hangs without any messages

2007-07-11 Thread Daniel J Blueman
On 11/07/07, Stephen Hemminger [EMAIL PROTECTED] wrote: On Wed, 11 Jul 2007 11:15:20 +0100 Daniel J Blueman [EMAIL PROTECTED] wrote: On 05/07/07, Stephen Hemminger [EMAIL PROTECTED] wrote: Well, it didn't fix my test, but it made it better. The following seemed to work longer... ---

Re: [PATCH] IPv6: optionaly validate RAs on raw sockets

2007-07-11 Thread David Stevens
Since you asked for another idea, how about using netlink to send _validated_ RA information to interested parties? -vlad That sounds like a good idea to me (FWIW), though I also still think a simple raw-socket application would do it just fine, possibly with no kernel modification

Re: [PATCH] IPv6: optionaly validate RAs on raw sockets

2007-07-11 Thread Rémi Denis-Courmont
Le mercredi 11 juillet 2007, David Stevens a écrit : That sounds like a good idea to me (FWIW), though I also still think a simple raw-socket application would do it just fine, possibly with no kernel modification at all. But since the kernel wouldn't be maintaining the DNS

Re: [PATCH] Virtual ethernet device (v2.1)

2007-07-11 Thread Patrick McHardy
Pavel Emelianov wrote: OK. I'll try to make the generic call. Could you please send me the patches with IFLA_ADDRESS support for booth kernel and ip utility. I'll send the kernel patches seperately in a few minutes. iproute doesn't need any further patches. - To unsubscribe from this list:

[RTNETLINK 00/04]: rtnl_link improvements

2007-07-11 Thread Patrick McHardy
These patches simplify the rtnl_link API and add support for specifying the initial device address. The rtnl_link patches depend on the VLAN fix because I didn't want to build on top of the broken address handling. Please apply, thanks. drivers/net/dummy.c | 61

[ETH 01/04]: Validate address in eth_mac_addr

2007-07-11 Thread Patrick McHardy
[ETH]: Validate address in eth_mac_addr Signed-off-by: Patrick McHardy [EMAIL PROTECTED] --- commit 690fb4dbafa9f60f8cb520d5def544580107b3a4 tree ded62c0fcd8497b5cf9459213e1579cc700abb39 parent 99d24edeb6abc6ca3a0d0fbdb83c664c04403c8c author Patrick McHardy [EMAIL PROTECTED] Wed, 11 Jul 2007

[RTNETLINK 03/04]: rtnl_link API simplification

2007-07-11 Thread Patrick McHardy
[RTNETLINK]: rtnl_link API simplification All drivers need to unregister their devices in the module unload function. While doing so they must hold the rtnl and atomically unregister the rtnl_link ops as well. This makes the rtnl_link_unregister function that takes the rtnl itself completely

[RTNETLINK 04/04]: rtnl_link: allow specifying initial device address

2007-07-11 Thread Patrick McHardy
[RTNETLINK]: rtnl_link: allow specifying initial device address Drivers need to validate the initial addresses in their netlink attribute validation function or manually reject them if they can't support this. Signed-off-by: Patrick McHardy [EMAIL PROTECTED] --- commit

[PATCH] tcp: tcp probe wraparound handling and other changes

2007-07-11 Thread Stephen Hemminger
Switch from formatting messages in probe routine and copying with kfifo, to using a small circular queue of information and formatting on read. This avoids wraparound issues with kfifo, and saves one copy. Also make sure to state correct license, rather than copying off some other driver I

Re: [VLAN 02/04]: Fix MAC address handling

2007-07-11 Thread Patrick McHardy
Patrick McHardy wrote: [VLAN]: Fix MAC address handling +static void vlan_sync_address(struct net_device *dev, + struct net_device *vlandev) +{ + struct vlan_dev_info *vlan = VLAN_DEV_INFO(vlandev); + + if (!compare_ether_addr(vlan-real_dev_addr,

[NET_SCHED]: ematch: module autoloading

2007-07-11 Thread Patrick McHardy
[NET_SCHED]: ematch: module autoloading Signed-off-by: Patrick McHardy [EMAIL PROTECTED] --- commit daa5d0f76104559af6718688e0e37ff9fda9ea6a tree 78efa14a3dda378a4b9dbc88ff5e1108671a4028 parent 5ff8523dfdac610944d1f85f54e30cd96dc6104b author Patrick McHardy [EMAIL PROTECTED] Wed, 11 Jul 2007

[PATCH 2.6.23] iw_cxgb3: remove the cm_id reference on listen failures.

2007-07-11 Thread Steve Wise
iw_cxgb3: remove the cm_id reference on listen failures. Signed-off-by: Steve Wise [EMAIL PROTECTED] --- drivers/infiniband/hw/cxgb3/iwch_cm.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/drivers/infiniband/hw/cxgb3/iwch_cm.c b/drivers/infiniband/hw/cxgb3/iwch_cm.c

Re: [VLAN 02/04]: Fix MAC address handling

2007-07-11 Thread Ben Greear
Patrick McHardy wrote: Patrick McHardy wrote: [VLAN]: Fix MAC address handling +static void vlan_sync_address(struct net_device *dev, + struct net_device *vlandev) +{ + struct vlan_dev_info *vlan = VLAN_DEV_INFO(vlandev); + + if

Re: [PATCH][RFC] network splice receive v3

2007-07-11 Thread Joel Becker
On Wed, Jul 11, 2007 at 11:19:27AM +0200, Jens Axboe wrote: Subject: [PATCH] splice: don't assume regular pages in splice_to_pipe() Allow caller to pass in a release function, there might be other resources that need releasing as well. Needed for network receive. diff --git a/fs/splice.c

Re: [Bugme-new] [Bug 8736] New: New TC deadlock scenario

2007-07-11 Thread Andrew Morton
On Wed, 11 Jul 2007 08:45:12 -0700 (PDT) [EMAIL PROTECTED] wrote: http://bugzilla.kernel.org/show_bug.cgi?id=8736 Summary: New TC deadlock scenario Product: Networking Version: 2.5 KernelVersion: 2.6.22 Platform: All OS/Version:

Re: [PATCH][RFC] network splice receive v3

2007-07-11 Thread Jens Axboe
On Wed, Jul 11 2007, Joel Becker wrote: On Wed, Jul 11, 2007 at 11:19:27AM +0200, Jens Axboe wrote: Subject: [PATCH] splice: don't assume regular pages in splice_to_pipe() Allow caller to pass in a release function, there might be other resources that need releasing as well. Needed for

Re: [Bugme-new] [Bug 8736] New: New TC deadlock scenario

2007-07-11 Thread Patrick McHardy
Andrew Morton wrote: http://bugzilla.kernel.org/show_bug.cgi?id=8736 Here is another scenario I bumped onto - qdisc_watchdog_cancel() and qdisc_restart() deadlock. CPU#0 qdisc_watchdog() fires and gets dev-queue_lock qdisc_run()...qdisc_restart()... - releases dev-queue_lock and enters

Re: [VLAN 02/04]: Fix MAC address handling

2007-07-11 Thread Patrick McHardy
Ben Greear wrote: Patrick McHardy wrote: [VLAN]: Fix MAC address handling The new patch looks good to me..though this is some tricky code so I might have missed something... Thanks Ben. I'm pretty sure the new one is fine. Definitely not worse than before :) - To unsubscribe from this

[PATCH] IPROUTE2: Fix bug in display of ipv6 cloned/cached routes

2007-07-11 Thread Sridhar Samudrala
This patch fixes a bug in the 'ip' command to display IPv6 cloned routes. ip -6 route ls cache returns empty even when there are cloned routes because of of a missing else in print_route() routine. Thanks Sridhar Signed-off-by: Sridhar Samudrala [EMAIL PROTECTED] diff --git

Re: [PATCH] IPROUTE2: Fix bug in display of ipv6 cloned/cached routes

2007-07-11 Thread Patrick McHardy
Sridhar Samudrala wrote: This patch fixes a bug in the 'ip' command to display IPv6 cloned routes. ip -6 route ls cache returns empty even when there are cloned routes because of of a missing else in print_route() routine. Looks good. The ip6_multiple_tables case seems to be missing

Linux 2.6.22: Leak r=1 1

2007-07-11 Thread Sami Farin
That's right, so descriptive is the new Linux kernel 2.6.22. Took a while to grep what is leaking. Linux safari.finland.fbi 2.6.22-cfs-v19 #3 SMP Tue Jul 10 00:22:25 EEST 2007 i686 i686 i386 GNU/Linux Just normal Internet usage, azureus for example =) I think this is easy to trigger. But that

Re: Linux 2.6.22: Leak r=1 1

2007-07-11 Thread Chuck Ebbert
On 07/11/2007 01:40 PM, Sami Farin wrote: That's right, so descriptive is the new Linux kernel 2.6.22. Took a while to grep what is leaking. You didn't post that: $ find . -type f | xargs grep Leak r= /dev/null ./net/ipv4/tcp_input.c: printk(KERN_DEBUG Leak r=%u %d\n, - To

Re: Fwd: r8169 driver supporting the 8167 dev ID

2007-07-11 Thread Francois Romieu
Jonathan Larsen [EMAIL PROTECTED] : I got git installed on my dev box. i went to my linux source dir and ran, git init git add . git format-patch v2.6.18..v2.6.23-rc1 -- drivers/net/r8169.c and i got an error fatal: bad revision 'v2.6.18..v2.6.23-rc1' what did i do wrong? im sure im

Re: [patch 5/7] CAN: Add virtual CAN netdevice driver

2007-07-11 Thread Oliver Hartkopp
Hi Patrick, what's your opinion about my reply to your remark? Should we just change the module parameter from loopback to loopbacktest to make the test intention obvious? Or should we remove the loopback test functionality? Regards, Oliver Oliver Hartkopp wrote: Patrick McHardy wrote:

Re: [Cbe-oss-dev] [PATCH] spidernet: don't use debug flag

2007-07-11 Thread Linas Vepstas
On Wed, Jul 11, 2007 at 04:57:38PM +0900, Ishizaki Kou wrote: [...] I need more investigation. Please drop the patch. OK. --linas p.s. I tested ifdown/ifup, and didn't see any problems. Does your bug happen immediately, or does it take many attempts to trigger it? - To unsubscribe from this

Re: [PATCH] Virtual ethernet device (v2.1)

2007-07-11 Thread David Miller
From: Christian Borntraeger [EMAIL PROTECTED] Date: Wed, 11 Jul 2007 12:54:24 +0200 Am Mittwoch, 11. Juli 2007 schrieb Pavel Emelianov: drivers/net/veth.c | 452 include/net/veth.h | 14 + I know, I am late in the game, but wont the name collide somewhat with

Re: [PATCH] IPv6: optionaly validate RAs on raw sockets

2007-07-11 Thread David Miller
From: Rémi_Denis-Courmont [EMAIL PROTECTED] Date: Wed, 11 Jul 2007 19:19:11 +0300 Le mercredi 11 juillet 2007, David Stevens a écrit : That sounds like a good idea to me (FWIW), though I also still think a simple raw-socket application would do it just fine, possibly with no

Re: [PATCH 1/5] try parent numa_node at first before using default

2007-07-11 Thread Greg KH
On Wed, Jul 11, 2007 at 12:54:58PM +0200, Stefan Richter wrote: Yinghai Lu wrote: --- a/drivers/base/core.c +++ b/drivers/base/core.c @@ -547,6 +547,8 @@ static void klist_children_put(struct klist_node *n) void device_initialize(struct device *dev) { + int node; +

Re: [PATCH] IPv6: optionaly validate RAs on raw sockets

2007-07-11 Thread James Morris
On Wed, 11 Jul 2007, David Miller wrote: One remaining corner case is NFS/IPv6 root, whereby userland won't have a chance to start before the network, and hence may miss the solicited RA. Or would it? By default, the next unsolicited RA can be anytime from now to after 10 minutes, so

Re: [PATCH 1/5] try parent numa_node at first before using default

2007-07-11 Thread Yinghai Lu
Greg KH wrote: On Wed, Jul 11, 2007 at 12:54:58PM +0200, Stefan Richter wrote: Yinghai Lu wrote: --- a/drivers/base/core.c +++ b/drivers/base/core.c @@ -547,6 +547,8 @@ static void klist_children_put(struct klist_node *n) void device_initialize(struct device *dev) { + int node; +

Re: [2.6.23 PATCH 13/18] dm: netlink

2007-07-11 Thread Andrew Morton
On Wed, 11 Jul 2007 22:01:37 +0100 Alasdair G Kergon [EMAIL PROTECTED] wrote: From: Mike Anderson [EMAIL PROTECTED] This patch adds a dm-netlink skeleton support to the Makefile, and the dm directory. ... +config DM_NETLINK + bool DM netlink events (EXPERIMENTAL) + depends

Re: [2.6.23 PATCH 14/18] dm: netlink add to core

2007-07-11 Thread Andrew Morton
On Wed, 11 Jul 2007 22:01:59 +0100 Alasdair G Kergon [EMAIL PROTECTED] wrote: From: Mike Anderson [EMAIL PROTECTED] This patch adds support for the dm_path_event dm_send_event funtions which create and send netlink attribute events. ... --- linux.orig/drivers/md/dm-netlink.c

Re: sky2 hangs without any messages

2007-07-11 Thread Daniel J Blueman
On 11/07/07, Daniel J Blueman [EMAIL PROTECTED] wrote: On 05/07/07, Stephen Hemminger [EMAIL PROTECTED] wrote: Well, it didn't fix my test, but it made it better. The following seemed to work longer... --- a/drivers/net/sky2.c2007-07-05 09:09:45.0 -0700 +++

Re: sky2 hangs without any messages

2007-07-11 Thread Stephen Hemminger
On Wed, 11 Jul 2007 22:39:49 +0100 Daniel J Blueman [EMAIL PROTECTED] wrote: On 11/07/07, Daniel J Blueman [EMAIL PROTECTED] wrote: On 05/07/07, Stephen Hemminger [EMAIL PROTECTED] wrote: Well, it didn't fix my test, but it made it better. The following seemed to work

Re: [PATCH 0/5] more about numa_node with struct device

2007-07-11 Thread Yinghai Lu
On 7/11/07, Christoph Hellwig [EMAIL PROTECTED] wrote: On Tue, Jul 10, 2007 at 04:52:19PM -0700, Yinghai Lu wrote: these are revised or new patch with numa_node in struct device in addition to Do you have a pointer to a background posting why you want all this?

Re: sky2 hangs without any messages

2007-07-11 Thread Daniel J Blueman
On 11/07/07, Stephen Hemminger [EMAIL PROTECTED] wrote: On Wed, 11 Jul 2007 22:39:49 +0100 Daniel J Blueman [EMAIL PROTECTED] wrote: On 11/07/07, Daniel J Blueman [EMAIL PROTECTED] wrote: On 05/07/07, Stephen Hemminger [EMAIL PROTECTED] wrote: Well, it didn't fix my test, but it made

[1/5][TG3]: Fix irq_sync race condition.

2007-07-11 Thread Michael Chan
[TG3]: Fix irq_sync race condition. Gagan Arneja [EMAIL PROTECTED] pointed out that tg3_reset_task() could potentially race with another thread calling tg3_full_lock() such as the ethtool_set_xxx() functions. This may trigger the BUG_ON() in tg3_irq_quiesce() or cause the irq_sync flag to be

[2/5][TG3]: Fix the polarity bit.

2007-07-11 Thread Michael Chan
[TG3]: Fix the polarity bit. For most pre-5705 devices, multiple link interrupts were being generated for a single physical link change. The source of the interrupts was determined to be unnecessary toggling of the MAC link polarity bit. This patch changes the way the link polarity bit gets

[3/5][TG3]: Enable auto MDI.

2007-07-11 Thread Michael Chan
[TG3]: Enable auto MDI. This patch adds automatic MDI crossover support when autonegotiation is turned off. Automatic MDI crossover allows link to be established without the use of a crossover cable. Signed-off-by: Matt Carlson [EMAIL PROTECTED] Signed-off-by: Michael Chan [EMAIL PROTECTED]

[4/5][TG3]: Add missing NVRAM strapping.

2007-07-11 Thread Michael Chan
[TG3]: Add missing NVRAM strapping. This patch adds a missing NVRAM strapping for 5755 devices. Signed-off-by: Matt Carlson [EMAIL PROTECTED] Signed-off-by: Michael Chan [EMAIL PROTECTED] diff --git a/drivers/net/tg3.c b/drivers/net/tg3.c index 4f59e5c..0d40f9d 100644 --- a/drivers/net/tg3.c

[5/5][TG3]: Update version to 3.78.

2007-07-11 Thread Michael Chan
[TG3]: Update version to 3.78. Signed-off-by: Michael Chan [EMAIL PROTECTED] diff --git a/drivers/net/tg3.c b/drivers/net/tg3.c index 0d40f9d..3245f16 100644 --- a/drivers/net/tg3.c +++ b/drivers/net/tg3.c @@ -64,8 +64,8 @@ #define DRV_MODULE_NAMEtg3 #define PFX

Re: sky2 hangs without any messages

2007-07-11 Thread Daniel J Blueman
On 11/07/07, Daniel J Blueman [EMAIL PROTECTED] wrote: On 11/07/07, Stephen Hemminger [EMAIL PROTECTED] wrote: On Wed, 11 Jul 2007 22:39:49 +0100 Daniel J Blueman [EMAIL PROTECTED] wrote: On 11/07/07, Daniel J Blueman [EMAIL PROTECTED] wrote: On 05/07/07, Stephen Hemminger [EMAIL

Re: [patch 5/7] CAN: Add virtual CAN netdevice driver

2007-07-11 Thread Patrick McHardy
Oliver Hartkopp wrote: Hi Patrick, what's your opinion about my reply to your remark? Should we just change the module parameter from loopback to loopbacktest to make the test intention obvious? Or should we remove the loopback test functionality? I'll look into it tommorrow, please be

Re: d80211 deadlock with wpa_supplicant and rmmod

2007-07-11 Thread seventh guardian
Hello, First of all I'm fairly new to this list (in all, this is my first message), so please be gentle.. I promise I will try not to waste your precious time. I believe we have a deadlock in d80211. I have it too. But I'm using iwl3945 driver, in-kernel mac80211, and a gentoo kernel

[PATCH] spidernet: enable poll() before registering interrupts

2007-07-11 Thread Arnd Bergmann
We must not call netif_poll_enable after enabling interrupts, because an interrupt might come in and set the __LINK_STATE_RX_SCHED bit before we get to clear that bit again. If that happens, the next call to the -poll() function will oops. Signed-off-by: Arnd Bergmann [EMAIL PROTECTED] --- This

Re: [2.6.23 PATCH 13/18] dm: netlink

2007-07-11 Thread Mike Anderson
Andrew Morton [EMAIL PROTECTED] wrote: On Wed, 11 Jul 2007 22:01:37 +0100 Alasdair G Kergon [EMAIL PROTECTED] wrote: From: Mike Anderson [EMAIL PROTECTED] This patch adds a dm-netlink skeleton support to the Makefile, and the dm directory. ... +config DM_NETLINK + bool

RE: [RFC 2/2] shrink size of scatterlist on common i386/x86-64

2007-07-11 Thread Williams, Mitch A
Muli Ben-Yehuda wrote: Net result: zilch. No performance increase, no noticeable CPU utilization benefits. Nothing. So I dropped it. Do you have pointers to the patches perchance? Muli, I've been looking for this code and it looks like it's gone. I was using a Power5 system that I had

Re: d80211 deadlock with wpa_supplicant and rmmod

2007-07-11 Thread John W. Linville
On Thu, Jul 12, 2007 at 12:17:35AM +0100, seventh guardian wrote: Hello, First of all I'm fairly new to this list (in all, this is my first message), so please be gentle.. I promise I will try not to waste your precious time. I believe we have a deadlock in d80211. I have it too. But I'm

Re: [2.6.23 PATCH 14/18] dm: netlink add to core

2007-07-11 Thread Mike Anderson
Andrew Morton [EMAIL PROTECTED] wrote: On Wed, 11 Jul 2007 22:01:59 +0100 Alasdair G Kergon [EMAIL PROTECTED] wrote: From: Mike Anderson [EMAIL PROTECTED] This patch adds support for the dm_path_event dm_send_event funtions which create and send netlink attribute events. ...

  1   2   >