Re: [PATCH] [RFC] allow admin/users to specify rto_min in milliseconds rather than jiffies

2007-09-05 Thread Stephen Hemminger
On Tue, 4 Sep 2007 13:20:47 -0700 (PDT) Rick Jones [EMAIL PROTECTED] wrote: Build upon David Miller's initial patches to set the per-route rto_min so users can specify the rto_min in the same units (milliseconds) in which they are displayed. This is desirable because asking users to convert

Re: [patch 02/18] sundance: PHY address form 0, only for device I D 0x0200 (IP100A) (20070605)

2007-09-05 Thread Jesse Huang
Dear Jeff: We found current sundance.c in kernel 2.6.22 is working fine for IP100A. We need not to modify following codes: - for (phy = 1; phy = 32 phy_idx MII_CNT; phy++) { + if (sundance_pci_tbl[np-chip_id].device == 0x0200) + phy = 0; + else +

Re: [PATCH 1/2]: [NET_SCHED]: Make all rate based scheduler work with TSO.

2007-09-05 Thread Jesper Dangaard Brouer
On Tue, 2007-09-04 at 13:40 -0400, Bill Fink wrote: On Tue, 04 Sep 2007, Patrick McHardy wrote: Bill Fink wrote: On Sat, 1 Sep 2007, Jesper Dangaard Brouer wrote: Yes, you need to specify the MTU on the command line for jumbo frames. Thanks! Works much better now, although it

Re: [PATCH] [sis900] convert to NAPI, WAS Re: pktgen terminating condition

2007-09-05 Thread James Chapman
Mandeep Singh Baines wrote: Daniele Venzano ([EMAIL PROTECTED]) wrote: The patch looks good and I think it can be pushed higher (-mm ?) for some wider testing. I don't have the hardware available to do some tests myself, unfortunately, but it would be similar to yours anyway. I'd like to

Re: Oops in 2.6.22.1: skb_copy_and_csum_datagram_iovec()

2007-09-05 Thread Neil Brown
On Wednesday August 22, [EMAIL PROTECTED] wrote: Chuck Ebbert [EMAIL PROTECTED] wrote: https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=253290 18:57:54 osama kernel: [c05be67f] kernel_recvmsg+0x31/0x40 18:57:54 osama kernel: [e0bc52d4] svc_udp_recvfrom+0x114/0x368 [sunrpc]

Re: Oops in 2.6.22.1: skb_copy_and_csum_datagram_iovec()

2007-09-05 Thread Neil Brown
On Wednesday September 5, [EMAIL PROTECTED] wrote: On Wednesday August 22, [EMAIL PROTECTED] wrote: Chuck Ebbert [EMAIL PROTECTED] wrote: https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=253290 18:57:54 osama kernel: [c05be67f] kernel_recvmsg+0x31/0x40 18:57:54 osama kernel:

Re: [PATCH] [sis900] convert to NAPI, WAS Re: pktgen terminating condition

2007-09-05 Thread James Chapman
jamal wrote: On Wed, 2007-05-09 at 13:03 +0100, James Chapman wrote: I have a patch that solves the high interrupt rate problem by keeping the driver in polled mode longer. It's written for the latest NAPI version that DaveM posted recently. I'll try to get some time to write it up and post

Re: [PATCH 2/2]: [NET_SCHED]: Making rate table lookups more flexible.

2007-09-05 Thread Jesper Dangaard Brouer
On Tue, 2007-09-04 at 18:25 +0200, Patrick McHardy wrote: Jesper Dangaard Brouer wrote: On Sun, 2007-09-02 at 23:16 +0200, Patrick McHardy wrote: Jesper Dangaard Brouer wrote: On Sun, 2 Sep 2007, Patrick McHardy wrote: Lets focus on the general case, where the functionality actually

Re: [PATCH 9/11] cxgb3 - engine microcode update

2007-09-05 Thread Steve Wise
Jeff Garzik wrote: Divy Le Ray wrote: From: Divy Le Ray [EMAIL PROTECTED] Load microcode engine when the interface is configured up. Bump up version to 1.1.0. Allow the driver to be and running with older microcode images. Allow ethtool to log the microcode version. Signed-off-by: Divy Le

Re: [PATCH] [sis900] convert to NAPI, WAS Re: pktgen terminating condition

2007-09-05 Thread jamal
On Wed, 2007-05-09 at 14:55 +0100, James Chapman wrote: Thanks Jamal. Yes, I'd already read your paper. I think my idea is different to the ideas described in your paper I am hoping you can pick from the lessons of what has been tried and failed and the justification for critiqueing

[PATCH] 3c59x: sparse warning fix

2007-09-05 Thread Stephen Hemminger
--- a/drivers/net/3c59x.c 2007-09-05 15:15:16.0 +0100 +++ b/drivers/net/3c59x.c 2007-09-05 15:16:29.0 +0100 @@ -1122,7 +1122,7 @@ static int __devinit vortex_probe1(struc + sizeof(struct boom_tx_desc) * TX_RING_SIZE,

Re: [PATCH 9/11] cxgb3 - engine microcode update

2007-09-05 Thread Jeff Garzik
On Wed, Sep 05, 2007 at 09:00:04AM -0500, Steve Wise wrote: Jeff Garzik wrote: Divy Le Ray wrote: From: Divy Le Ray [EMAIL PROTECTED] Load microcode engine when the interface is configured up. Bump up version to 1.1.0. Allow the driver to be and running with older microcode images.

Re: [PATCH 9/11] cxgb3 - engine microcode update

2007-09-05 Thread Steve Wise
Jeff Garzik wrote: On Wed, Sep 05, 2007 at 09:00:04AM -0500, Steve Wise wrote: Jeff Garzik wrote: Divy Le Ray wrote: From: Divy Le Ray [EMAIL PROTECTED] Load microcode engine when the interface is configured up. Bump up version to 1.1.0. Allow the driver to be and running with older

Re: [PATCH RFC] iw_cxgb3: Support iwarp-only interfaces to avoid 4-tuple conflicts with the host stack.

2007-09-05 Thread Roland Dreier
What's wrong with my suggestion of having the iwarp driver create an iwX interface to go with the normal ethX interface? It seems simpler to me, and there's a somewhat similar precedent with how mac80211 devices create both wlan0 and wmaster0 interfaces. - R. It seemed much

Re: [PATCH] Remove unneeded pointer iph from ipcomp6_input() in net/ipv6/ipcomp6.c

2007-09-05 Thread David Miller
From: Micah Gruber [EMAIL PROTECTED] Date: Wed, 05 Sep 2007 13:44:40 +0800 This trivial patch removes the unneeded pointer iph, which is never used. Signed-off-by: Micah Gruber [EMAIL PROTECTED] Applied, thanks. - To unsubscribe from this list: send the line unsubscribe netdev in the body

Re: [PATCH] Remove unneeded pointer newdp from dccp_v4_request_recv_sock() in net/dccp/ipv4.c

2007-09-05 Thread David Miller
From: Micah Gruber [EMAIL PROTECTED] Date: Wed, 05 Sep 2007 13:47:05 +0800 This trivial patch removes the unneeded pointer newdp, which is never used. Signed-off-by: Micah Gruber [EMAIL PROTECTED] Applied, thanks. - To unsubscribe from this list: send the line unsubscribe netdev in the body

WiFi and changed MAC addrs

2007-09-05 Thread Ben Woodard
I just spent basically a day of my weekend grappling with this problem http://wiki.xensource.com/xenwiki/XenWifi before I understood it well enough to realize that the fact that Xen changed the MAC addr for my WiFi card was the root cause of the problem. This got me thinking: If a particular

Re: kernel crashes inside MV643xx driver

2007-09-05 Thread Andrew Morton
On Mon, 20 Aug 2007 14:38:57 +0800 gshan [EMAIL PROTECTED] wrote: Hi All, After I started the NFS server, it crashed: 3Badness in local_bh_enable at /home/cli4/sandbox/main/TelicaRoot/components/mvlinux/cge/devkit/lsp/7xx/linux/kernel/softirq.c:195 Badness in local_bh_enable at

Re: WiFi and changed MAC addrs

2007-09-05 Thread Johannes Berg
On Wed, 2007-09-05 at 08:20 -0700, Ben Woodard wrote: If a particular piece of hardware will refuse to send frames after the MAC address has been changed, then shouldn't the card's driver refuse to allow a change of the MAC address and return an error in response to the IOCTL that tries to

Re: [PATCH RFC] iw_cxgb3: Support iwarp-only interfaces to avoid 4-tuple conflicts with the host stack.

2007-09-05 Thread Steve Wise
Roland Dreier wrote: What's wrong with my suggestion of having the iwarp driver create an iwX interface to go with the normal ethX interface? It seems simpler to me, and there's a somewhat similar precedent with how mac80211 devices create both wlan0 and wmaster0 interfaces. -

[PATCH] sky2: restore multicast list on resume and other ops

2007-09-05 Thread Stephen Hemminger
Need to restore multicast settings on resume and after 'ethtool -r'. Signed-off-by: Stephen Hemminger [EMAIL PROTECTED] --- a/drivers/net/sky2.c2007-09-05 13:57:22.0 +0100 +++ b/drivers/net/sky2.c2007-09-05 13:57:24.0 +0100 @@ -149,6 +149,8 @@ static const char

request for information about the ath5k licensing

2007-09-05 Thread Reyk Floeter
- Forwarded message from Reyk Floeter [EMAIL PROTECTED] - Date: Wed, 5 Sep 2007 17:18:23 +0200 From: Reyk Floeter [EMAIL PROTECTED] To: [EMAIL PROTECTED], [EMAIL PROTECTED], [EMAIL PROTECTED], [EMAIL PROTECTED], [EMAIL PROTECTED], [EMAIL PROTECTED] Subject: request for

Re: kernel crashes inside MV643xx driver

2007-09-05 Thread Stephen Hemminger
On Wed, 5 Sep 2007 08:24:52 -0700 Andrew Morton [EMAIL PROTECTED] wrote: On Mon, 20 Aug 2007 14:38:57 +0800 gshan [EMAIL PROTECTED] wrote: Hi All, After I started the NFS server, it crashed: 3Badness in local_bh_enable at

Re: [PATCH] 3c59x: sparse warning fix

2007-09-05 Thread Joe Perches
On Wed, 2007-09-05 at 15:23 +0100, Stephen Hemminger wrote: --- a/drivers/net/3c59x.c 2007-09-05 15:15:16.0 +0100 +++ b/drivers/net/3c59x.c 2007-09-05 15:16:29.0 +0100 @@ -1122,7 +1122,7 @@ static int __devinit vortex_probe1(struc

Re: kernel crashes inside MV643xx driver

2007-09-05 Thread Dale Farnsworth
On Wed, Sep 05, 2007 at 08:24:52AM -0700, Andrew Morton wrote: On Mon, 20 Aug 2007 14:38:57 +0800 gshan [EMAIL PROTECTED] wrote: Hi All, After I started the NFS server, it crashed: 3Badness in local_bh_enable at

[patch 0/1] [PATCH] Fix Kconfigs for net-2.6.24

2007-09-05 Thread dlezcano
Fixes for 3 typos in Kconfig files -- - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

[patch 1/1] Fix some Kconfigs on net-2.6.24

2007-09-05 Thread dlezcano
From: Daniel Lezcano [EMAIL PROTECTED] Three fixes for Kconfigs. Signed-off-by: Daniel Lezcano [EMAIL PROTECTED] --- drivers/input/misc/Kconfig |2 +- drivers/leds/Kconfig |2 +- drivers/telephony/Kconfig |2 +- 3 files changed, 3 insertions(+), 3 deletions(-) Index:

Re: [PATCH RFC] iw_cxgb3: Support iwarp-only interfaces to avoid 4-tuple conflicts with the host stack.

2007-09-05 Thread Steve Wise
Steve Wise wrote: Roland Dreier wrote: What's wrong with my suggestion of having the iwarp driver create an iwX interface to go with the normal ethX interface? It seems simpler to me, and there's a somewhat similar precedent with how mac80211 devices create both wlan0 and

Re: [PATCH] [RFC] allow admin/users to specify rto_min in milliseconds rather than jiffies

2007-09-05 Thread Rick Jones
Stephen Hemminger wrote: On Tue, 4 Sep 2007 13:20:47 -0700 (PDT) Rick Jones [EMAIL PROTECTED] wrote: Build upon David Miller's initial patches to set the per-route rto_min so users can specify the rto_min in the same units (milliseconds) in which they are displayed. This is desirable because

Re: [PATCH] make _minimum_ TCP retransmission timeout configurable

2007-09-05 Thread Ilpo Järvinen
On Wed, 29 Aug 2007, David Miller wrote: From: Rick Jones [EMAIL PROTECTED] Date: Wed, 29 Aug 2007 16:06:27 -0700 I belive the biggest component comes from link-layer retransmissions. There can also be some short outtages thanks to signal blocking, tunnels, people with big hats and

[TG3]: Workaround MSI bug on 5714/5780.

2007-09-05 Thread Michael Chan
[TG3]: Workaround MSI bug on 5714/5780. A hardware bug was revealed after a recent PCI MSI patch was made to always disable legacy INTX when enabling MSI. The 5714/5780 chips will not generate MSI when INTX is disabled, causing MSI failure messages to be reported, and another patch was made to

Re: [PATCH] 3c59x: sparse warning fix

2007-09-05 Thread Francois Romieu
Joe Perches [EMAIL PROTECTED] : [...] Shouldn't this be: if (pkt_len rx_copybreak) { skb = dev_alloc_skb(pkt_len + 2); if (!skb) { bad_news! (like the refill rx ring buffers block) } It is not that bad a news: the

Re: [TG3]: Workaround MSI bug on 5714/5780.

2007-09-05 Thread Andy Gospodarek
On 9/5/07, Michael Chan [EMAIL PROTECTED] wrote: [TG3]: Workaround MSI bug on 5714/5780. A hardware bug was revealed after a recent PCI MSI patch was made to always disable legacy INTX when enabling MSI. The 5714/5780 chips will not generate MSI when INTX is disabled, causing MSI failure

Re: Oops in 2.6.22.1: skb_copy_and_csum_datagram_iovec()

2007-09-05 Thread Herbert Xu
Hi Neil: On Wed, Sep 05, 2007 at 01:50:21PM +0100, Neil Brown wrote: iov == NULL used to work. Well it used to work mostly. In fact, it still does work mostly too. I think it stopped working at commit 759e5d006462d53fb708daa8284b4ad909415da1 Previously, as len==0, MSG_TRUNC

Re: [Lksctp-developers] SCTP: Fix dead loop while received unexpected chunk with length set to zero

2007-09-05 Thread Vlad Yasevich
Wei Yongjun wrote: Packet changed: 1. Used sctp_sf_ootb() to handle OOTB packet 2. Remove length check from sctp_sf_tabort_8_4_8() in last patch 3. Add length check to sctp_sf_ootb() 4. Changed validity check order in sctp_sf_do_5_1B_init() and other functions to fix possible attack. Can

Re: [PATCH v3 2/2][BNX2]: Add iSCSI support to BNX2 devices.

2007-09-05 Thread Anil Veerabhadrappa
On Wed, 2007-09-05 at 13:34 -0500, Mike Christie wrote: Michael Chan wrote: +* This file defines HSI constants for the iSCSI flows +*/ + +/* iSCSI request op codes */ +#define ISCSI_OPCODE_NOP_OUT (0 | 0x40) +#define ISCSI_OPCODE_SCSI_CMD (1)

Re: [PATCH 9/11] cxgb3 - engine microcode update

2007-09-05 Thread Divy Le Ray
I think 9-14 still need to be incorporated. I don't see them in your upstream branch, and they aren't in linus' tree either. I am not the blocker here. Sorry for the delay - again. I'm resubmitting these patches against net#upstream. Cheers, Divy - To unsubscribe from this list: send

[PATCH 1/7 RESEND] cxgb3 - Firmware update

2007-09-05 Thread Divy Le Ray
From: Divy Le Ray [EMAIL PROTECTED] Update firmware version. Allow the driver to be up and running with older FW image Signed-off-by: Divy Le Ray [EMAIL PROTECTED] --- drivers/net/cxgb3/common.h |2 +- drivers/net/cxgb3/cxgb3_main.c |9 + drivers/net/cxgb3/t3_hw.c |

[PATCH 2/7 RESEND] cxgb3 - log and clear PEX errors

2007-09-05 Thread Divy Le Ray
From: Divy Le Ray [EMAIL PROTECTED] Clear pciE PEX errors late at module load time. Log details when PEX errors occur. Signed-off-by: Divy Le Ray [EMAIL PROTECTED] --- drivers/net/cxgb3/t3_hw.c |6 ++ 1 files changed, 6 insertions(+), 0 deletions(-) diff --git

[PATCH 3/7 RESEND] cxgb3 - remove false positive in xgmac workaround

2007-09-05 Thread Divy Le Ray
From: Divy Le Ray [EMAIL PROTECTED] Qualify toggling of xgmac tx enable with not getting pause frames, we might not make forward progress because the peer is sending lots of pause frames. Signed-off-by: Divy Le Ray [EMAIL PROTECTED] --- drivers/net/cxgb3/common.h |1 +

[PATCH 6/7] cxgb3 - Add T3C rev

2007-09-05 Thread Divy Le Ray
From: Divy Le Ray [EMAIL PROTECTED] add driver recognition for T3C rev board. Signed-off-by: Divy Le Ray [EMAIL PROTECTED] --- drivers/net/cxgb3/common.h |1 + drivers/net/cxgb3/cxgb3_main.c |3 +++ 2 files changed, 4 insertions(+), 0 deletions(-) diff --git

[PATCH 7/7] cxgb3 - Update engine microcode version

2007-09-05 Thread Divy Le Ray
From: Divy Le Ray [EMAIL PROTECTED] The new microcode engine version is set to 1.1.0 Signed-off-by: Divy Le Ray [EMAIL PROTECTED] --- drivers/net/cxgb3/common.h |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/cxgb3/common.h b/drivers/net/cxgb3/common.h

[PATCH 5/7 RESEND] cxgb3 - CQ context operations time out too soon.

2007-09-05 Thread Divy Le Ray
From: Divy Le Ray [EMAIL PROTECTED] Currently, the driver only tries up to 5 times (5us) to get the results of a CQ context operation. Testing has shown the chip can take as much as 50us to return the response on SG_CONTEXT_CMD operations. So we up the retry count to 100 to cover high loads.

Re: kernel crashes inside MV643xx driver

2007-09-05 Thread Satyam Sharma
On Wed, 5 Sep 2007, Dale Farnsworth wrote: On Wed, Sep 05, 2007 at 08:24:52AM -0700, Andrew Morton wrote: On Mon, 20 Aug 2007 14:38:57 +0800 gshan [EMAIL PROTECTED] wrote: Hi All, After I started the NFS server, it crashed: 3Badness in local_bh_enable at

Re: BUG: scheduling while atomic: ifconfig/0x00000002/4170

2007-09-05 Thread Satyam Sharma
Hi, On 02/09/07, Florian Lohoff [EMAIL PROTECTED] wrote: Hi, with current git i got this when ifconfig eth1 down. eth1 had a mac address which looked really like an eth1394 ethernet although the module was not loaded. Something is really broken in 2.6.23-currentgit. I always get

[PATCH 1/1] netcore: minor cleanup for register_netdevice

2007-09-05 Thread FNST-Wang Chen
- minor logic cleanup Signed-off-by: Wang Chen [EMAIL PROTECTED] diff -Nurp linux-2.6.22.4.org/net/core/dev.c linux-2.6.22.4/net/core/dev.c --- linux-2.6.22.4.org/net/core/dev.c2007-08-22 15:33:40.0 +0800 +++ linux-2.6.22.4/net/core/dev.c2007-09-06 13:27:35.0 +0800 @@

Re: [PATCH 1/1] netcore: minor cleanup for register_netdevice

2007-09-05 Thread Krishna Kumar2
Some init handlers set iflink, and hence it is required. See tunnel init routines (ipip_tunnel_init), macvlan_init(), etc [EMAIL PROTECTED] wrote on 09/06/2007 10:57:24 AM: - minor logic cleanup Signed-off-by: Wang Chen [EMAIL PROTECTED] diff -Nurp linux-2.6.22.4.org/net/core/dev.c

Re: [Spam-fortigate] Re: [PATCH 1/1] netcore: minor cleanup for register_netdevice

2007-09-05 Thread FNST-Wang Chen
oops i am wrong YOSHIFUJI Hideaki / 吉藤英明 said the following on 2007-9-6 13:34: I disagree. Some of dev-init() functions set up dev-iflink; e.g., ipip_tunnel_init() etc. In article [EMAIL PROTECTED] (at Thu, 06 Sep 2007 13:27:24 +0800), FNST-Wang Chen [EMAIL PROTECTED] says: - minor

Re: [PATCH] [sis900] convert to NAPI, WAS Re: pktgen terminating condition

2007-09-05 Thread Mandeep Singh Baines
jamal ([EMAIL PROTECTED]) wrote: On Wed, 2007-05-09 at 14:55 +0100, James Chapman wrote: Thanks Jamal. Yes, I'd already read your paper. I think my idea is different to the ideas described in your paper I am hoping you can pick from the lessons of what has been tried and failed and