On Mon, 17 Sep 2007, Brandeburg, Jesse wrote:
L F wrote:
On 9/17/07, Kok, Auke [EMAIL PROTECTED] wrote:
The statistic we were looking at _will_ increase when running in
half duplex, but if it increases when running in full duplex might
indicate a hardware failure. Probably you have fixed
On 17 Sep 2007, Urs Thuermann wrote:
Thomas Gleixner [EMAIL PROTECTED] writes:
Please do, having the patch in mail makes it easier to review and to
comment.
OK, here it is:
One more typo.
This patch adds documentation for the PF_CAN protocol family.
Signed-off-by: Oliver Hartkopp
Bill Fink [EMAIL PROTECTED] writes:
One more typo.
decive - device above.
Thank you. It's fixed now.
urs
-
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
On Thursday 13 September 2007 20:57, Roland Dreier wrote:
HW specific:
- I already merged patches to enable MSI-X by default for mthca and
mlx4. I hope there aren't too many systems that get hosed if a
MSI-X interrupt is generated.
- Jack and Michael's mlx4 FMR support. Will
Hello,
Now it seems to me ok and I hope it can be applied cleanly. The only
change here is Copy neighbour instead Copy neighbout in the
comment in net/ipv4/xfrm4_policy.c
Regards,
Ian Brown
Signed-off-by: [EMAIL PROTECTED]
--- a/net/ipv4/xfrm4_policy.c 2007-09-01 09:08:24.0 +0300
Bill Fink [EMAIL PROTECTED] writes:
It may also be a useful test to disable hardware TSO support
via ethtool -K ethX tso off.
All suggestions here on the list, i.e. checking for flow control,
duplex, cable problems, etc. don't explain (at least to me) why LF
sees file corruption. How can a
Hi Dave,
Sorry for bothering you. I see that you are currently
very busy. I just wanted to remind you that iam waiting for your
feedback on the patch set. Just incase you want me to resend , please
let me know. If this work is already in your queue, ignore this mail.
Regards,
I proposed introducing a list_for_each_entry_continue_reverse macro
to be used in setup_net() when unrolling the failed -init callback.
Here is the macro and some more cleanup in the setup_net() itself
to remove one variable from the stack :) The same thing is for the
cleanup_net() - the existing
On 18 Sep 2007, Urs Thuermann wrote:
Bill Fink [EMAIL PROTECTED] writes:
It may also be a useful test to disable hardware TSO support
via ethtool -K ethX tso off.
All suggestions here on the list, i.e. checking for flow control,
duplex, cable problems, etc. don't explain (at least to
-Original Message-
From: [EMAIL PROTECTED]
[mailto:[EMAIL PROTECTED]
On Behalf Of Kumar Gala
Sent: Friday, September 14, 2007 10:08 PM
To: Jeff Garzik
Cc: [EMAIL PROTECTED] list; netdev
Subject: Re: [PATCH] ucc_geth: fix compilation
On Sep 13, 2007, at 10:23 AM, Anton
Hal Rosenstock wrote:
Has anyone tested these with QoS actually be used ? I suppose this
requires Connect-X.
You can test it with a switch without ConnectX.
If you want that the HCA will react to the QoS setting too then you
should have ConnectX
Tziporet
-
To unsubscribe from this
Some comment from looking at the driver in the -mm tree:
- please kill the CPU_CHIP_SWAP macros and use the normal linux
cpu_to_le*/le*_to_cpu and verify them using sparse.
See Documentation/sparse.txt on how to do that
- please include the linux header in the .c file, not the .h
-
Hello,
I have the following problem:
router A has two interfaces eth0 and eth1.
router B has two interfaces eth0 and eth1.
The networks on A:eth1 and B:eth1 are connected over an ipsec-tunnel.
the mtu on A:eth1 is 1400 (all others are 1500).
both run 2.6.22.6
If I now ping a host HA on
David Miller [EMAIL PROTECTED] writes:
This is limiting embryonic mini-socket creation. The listen overflow
should only increment when the 3-way handshake completion is aborted
because the listening socket limit is exceeded, which is entirely
different from the embryonic limit.
That's true,
While using IPoIB over EHCA (rc6 bits), unregister_netdev hangs with
the message: waiting for ib2 to become free. Usage count = -515276,
etc.
The problem is that the poll handler does netif_rx_complete (which
does a dev_put) followed by netif_rx_reschedule() to schedule for
more receives (which
Follow-up cleanup and while loop optimization in the poll handler.
net_rx_action guarantees that 'budget' is atleast 1.
Note: This could also be done for poll handlers of other drivers.
Signed-off-by: Krishna Kumar [EMAIL PROTECTED]
---
ipoib_ib.c | 22 --
1 files changed,
Final follow-up optimizations: If the poll loop executes more than
once (and it happens on my system with two flood pings):
- no need to calculate budget - done on every iteration (but
will require to do this once, when returning from fn)
- check for one variable
On Fri, Aug 31, 2007 at 05:06:25PM +0800, Herbert Xu wrote:
I've audited ppp_generic.c and pppoe.c. I'll do pppol2tp
tomorrow.
Tomrrow took a while to come :)
Here are the fixes for pppol2tp.
Cheers,
--
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmVHI~} [EMAIL
[PPP] L2TP: Disallow non-UDP datagram sockets
With the addition of UDP-Lite we need to refine the socket check so that
only genuine UDP sockets are allowed through.
Signed-off-by: Herbert Xu [EMAIL PROTECTED]
---
drivers/net/pppol2tp.c | 11 ++-
1 files changed, 6 insertions(+), 5
OK first of all I'm not really sure if this is the place but was told by
Dave Dillow to send to the netdev kernel mailing list. So that's what
I'm doing :)
I tried searching the mailing lists and didn't find anything that seemed
relevant, it is possible I missed something the archives are
[PPP] L2TP: Fix skb handling in pppol2tp_recv_core
The function pppol2tp_recv_core doesn't handle non-linear packets properly.
It also fails to check the remote offset field.
This patch fixes these problems. It also removes an unnecessary check on
the UDP header which has already been performed
[PPP] L2TP: Fix skb handling in pppol2tp_xmit
This patch makes pppol2tp_xmit call skb_cow_head so that we don't modify
cloned skb data. It also gets rid of skb2 we only need to preserve the
original skb for congestion notification, which is only applicable for
ppp_async and ppp_sync.
The other
On Mon, Sep 17, 2007 at 06:51:57PM -0700, David Miller wrote:
From: Andrew Morton [EMAIL PROTECTED]
Date: Mon, 17 Sep 2007 16:53:18 -0700
The Tehuti driver you should probably pull from the above git tree.
Ok I added in the Tehuti driver to net-2.6.24 and made sure the
napi_struct
On Mon, Sep 17, 2007 at 04:49:29PM -0700, Andrew Morton wrote:
On Mon, 17 Sep 2007 19:18:30 -0400
John W. Linville [EMAIL PROTECTED] wrote:
P.S. Andrew, I'll send you a link to a new git-wireless.patch --
I'm sure you don't want a complicated git invocation... Until then,
I don't think
On Tue, Sep 18, 2007 at 01:32:00PM +0200, Mikael Leivisk? wrote:
OK first of all I'm not really sure if this is the place but was told by
Dave Dillow to send to the netdev kernel mailing list. So that's what
I'm doing :)
I tried searching the mailing lists and didn't find anything that
Urs Thuermann wrote:
This patch adds a protocol/address family number, ARP hardware type,
ethernet packet type, and a line discipline number for the SocketCAN
implementation.
Signed-off-by: Oliver Hartkopp [EMAIL PROTECTED]
Signed-off-by: Urs Thuermann [EMAIL PROTECTED]
Acked-by: Patrick
Urs Thuermann wrote:
This patch adds the CAN core functionality but no protocols or drivers.
No protocol implementations are included here. They come as separate
patches. Protocol numbers are already in include/linux/can.h.
Signed-off-by: Oliver Hartkopp [EMAIL PROTECTED]
Signed-off-by:
* Urs Thuermann:
How can a corrupted frame pass the TCP checksum check?
The TCP/IP checksums are extremely weak. If the corruption is due to
defective SRAM or something like that, it's likely that it causes an
error pattern which is 16-bit-aligned. And an even number of
16-bit-aligned bit
1234567890123456789012345678901234567890123456789012345678901234567890
1 2 3 4 5 6 7
Hello everybody.
I have a pretty strange problem with linux 2.6.22.6
This is my 'ip ru sh', 'ip a s', 'ip r s' and
'iptables -t mangle -nvxL' output:
0:
Urs Thuermann wrote:
This patch adds the CAN raw protocol.
Signed-off-by: Oliver Hartkopp [EMAIL PROTECTED]
Signed-off-by: Urs Thuermann [EMAIL PROTECTED]
Also looks good, a few minor comments below.
Index: net-2.6.24/net/can/Kconfig
FS
Subject : hanging ext3 dbench tests
References : http://lkml.org/lkml/2007/9/11/176
Last known good : ?
Submitter : Andy Whitcroft [EMAIL PROTECTED]
Caused-By : ?
Handled-By : ?
Status : under test -- unreproducible at present
Yep... Hard to do
On Sep 18, 2007, at 3:56 AM, Li Yang-r58472 wrote:
-Original Message-
From: [EMAIL PROTECTED]
[mailto:[EMAIL PROTECTED]
On Behalf Of Kumar Gala
Sent: Friday, September 14, 2007 10:08 PM
To: Jeff Garzik
Cc: [EMAIL PROTECTED] list; netdev
Subject: Re: [PATCH] ucc_geth: fix compilation
On Tue, 2007-09-18 at 16:24 +0200, Jan Kara wrote:
Subject : umount triggers a warning in jfs and takes almost a minute
References : http://lkml.org/lkml/2007/9/4/73
Last known good : ?
Submitter : Oliver Neukum [EMAIL PROTECTED]
Caused-By : ?
Handled-By
David Miller wrote:
From: lepton [EMAIL PROTECTED]
Date: Tue, 18 Sep 2007 10:16:17 +0800
Hi,
In some situation, icmp_reply and ip_send_reply will send
out packet with the wrong source addr, the following patch
will fix this.
I don't understand why we must use rt-rt_src in the current
Thanks for testing on ehca...
While using IPoIB over EHCA (rc6 bits), unregister_netdev hangs with
I don't think you're actually using rc6 bits, since in your patch you have:
-poll_more:
and I think that is only in Dave's net-2.6.24 tree now, right?
The problem is that the poll handler
Am Dienstag 18 September 2007 schrieb Jan Kara:
Subject : umount triggers a warning in jfs and takes almost a minute
References : http://lkml.org/lkml/2007/9/4/73
Last known good : ?
Submitter : Oliver Neukum [EMAIL PROTECTED]
Caused-By : ?
Handled-By : ?
(I edited Cc: -jeff, +sven, hope you don't mind)
On 17/09/07 18:08 -0400, Jon Smirl wrote:
On 9/17/07, Domen Puncer [EMAIL PROTECTED] wrote:
Export phy_mii_ioctl, so network drivers can use it when built
as modules too.
Domen, do you want to collect all of these changes for MPC5200 FEC in
Urs Thuermann wrote:
Patrick McHardy [EMAIL PROTECTED] writes:
Looks pretty good, please see below for a few comments (mostly minor
nitpicking, a few things that look like real bugs). Nothing that
couldn't be fixed after merging though.
Thank you for your review. I'll go through it and
Use spin_lock_bh()/spin_unlock_bh() for the phydev lock throughout as it
is used in phy_timer() that is called as a softirq and all the other
operations may happen in the user context.
Signed-off-by: Maciej W. Rozycki [EMAIL PROTECTED]
---
There has been a change recently that did such a
Patrick McHardy [EMAIL PROTECTED] writes:
Looks pretty good, please see below for a few comments (mostly minor
nitpicking, a few things that look like real bugs). Nothing that
couldn't be fixed after merging though.
Thank you for your review. I'll go through it and your other mail
this
Urs Thuermann wrote:
This patch adds the virtual CAN bus (vcan) network driver.
The vcan device is just a loopback device for CAN frames, no
real CAN hardware is involved.
Signed-off-by: Oliver Hartkopp [EMAIL PROTECTED]
Signed-off-by: Urs Thuermann [EMAIL PROTECTED]
Also looks mostly
Signed-off-by: Vitaly Bordug [EMAIL PROTECTED]
---
drivers/net/fs_enet/fs_enet-main.c |6 --
1 files changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/net/fs_enet/fs_enet-main.c
b/drivers/net/fs_enet/fs_enet-main.c
index a4a2a0e..927cd9e 100644
---
Signed-off-by: Vitaly Bordug [EMAIL PROTECTED]
---
drivers/net/fs_enet/fs_enet-main.c | 16
1 files changed, 16 insertions(+), 0 deletions(-)
diff --git a/drivers/net/fs_enet/fs_enet-main.c
b/drivers/net/fs_enet/fs_enet-main.c
index 927cd9e..0e2d2b2 100644
---
Hi,
On Saturday 15 September 2007 00:12, David Miller wrote:
Ok, for now I'm going to try and deal with this by reverting
the list handling to something approximating the old NAPI
code, as per the patch below.
I've only quickly test booted into this kernel on my workstation.
So take care
This is the latest ethtool -S :
beehive:~# ethtool -S eth4
NIC statistics:
rx_packets: 33491526
tx_packets: 41410384
rx_bytes: 28384277429
tx_bytes: 46178788616
rx_broadcast: 3144
tx_broadcast: 2068
rx_multicast: 79
tx_multicast: 0
rx_errors: 0
My apologies for the repost, this should have gone to netdev and Dave Miller
as well.
On (18/09/07 17:20), Mel Gorman didst pronounce:
Hi Andrew,
PPC64 failed to build with the driver drivers/net/ehea with the
following error
CC [M] drivers/net/ehea/ehea_main.o
Quoting Roland Dreier [EMAIL PROTECTED]:
Subject: InfiniBand/RDMA merge plans for 2.6.24
With 2.6.24 probably opening in the not-too-distant future, it's
probably a good time to review what my plans are for when the merge
window opens.
Roland, could you merge the common TX CQ patch please?
On Tue, 18 Sep 2007, Florian Weimer wrote:
* Urs Thuermann:
How can a corrupted frame pass the TCP checksum check?
The TCP/IP checksums are extremely weak. If the corruption is due to
defective SRAM or something like that, it's likely that it causes an
error pattern which is
Bring the physical link down when the interface is down, by placing
the PHY in power-down state. This mirrors the behavior of other
drivers including e1000 and tg3.
Signed-off-by: Ed Swierk [EMAIL PROTECTED]
forcedeth-phy-power-down.patch
Description: Binary data
Log no link during initialization at KERN_INFO as it's not an error,
and occurs every time the interface comes up (when the
forcedeth-phy-power-down patch is applied).
Signed-off-by: Ed Swierk [EMAIL PROTECTED]
forcedeth-open-no-link-printk.patch
Description: Binary data
Limit of 1 is forbidden, crashes with 2, works with 3:
https://bugzilla.redhat.com/show_bug.cgi?id=219895
=
If the defect is produced at a console (as in ctrl-alt-f0-6) a kernel stack
trace can be seen the moment ping is invoked. Since the stack trace is not
written to the
David Miller wrote:
Ok, I changed my mind and decided to retain the optlen==0
intended behavior. It fell out of fixing the small
string length case.
This is likely what I'll push to Linus and later -stable
as a fix for this stuff.
I manually patched this into 2.6.20 and ran some tests.
My
I ran a test here in the lab and was not able to reproduce the issue
you're describing. My setup is with 2 systems connected through a
100Mbit switch. Client runs Windows XP and the server is Linux RHEL5
with updated samba 3.0.26a (latest I could download from samba.org).
I was able to copy 1GB
Andi Kleen wrote:
David Miller [EMAIL PROTECTED] writes:
This is limiting embryonic mini-socket creation. The listen overflow
should only increment when the 3-way handshake completion is aborted
because the listening socket limit is exceeded, which is entirely
different from the embryonic
Roland, could you merge the common TX CQ patch please?
It actually fixes a real problem.
Yes, I will, but it collides with the net-2.6.24 NAPI rework I think,
so it may not go in until a few days after the merge window.
Have you verified that the patch cures the interrupt overload issues?
-
On Tue, 2007-09-18 at 18:23 +0100, Denys Vlasenko wrote:
Hi Michael,
In bnx2_fw.h I see the following:
static u32 bnx2_RXP_b06FwBss[(0x13dc/4) + 1] = { 0x0 };
static struct fw_info bnx2_rxp_fw_06 = {
...
.bss= bnx2_RXP_b06FwBss,
...
};
I grepped
Once this is applied upstream, I can pull it back in to ofed-1.2.5 and
ofed-1.3.
Steve.
Sean Hefty wrote:
RDMA/CMA: Use neigh_event_send() to initiate neighbour discovery.
Calling arp_send() to initiate neighbour discovery (ND) doesn't do the
full ND protocol. Namely, it doesn't handle
Quoting Roland Dreier [EMAIL PROTECTED]:
Subject: Re: InfiniBand/RDMA merge plans for 2.6.24
Roland, could you merge the common TX CQ patch please?
It actually fixes a real problem.
Yes, I will, but it collides with the net-2.6.24 NAPI rework I think,
so it may not go in until a few
Chuck Ebbert wrote:
Limit of 1 is forbidden, crashes with 2, works with 3:
From disassembling sch_sfq.ko it seems that it is on line 360 of sch_sfq.c:
sch-qstats.backlog -= skb-len;
where skb is an invalid pointer:
Is it a NULL pointer or something random?
-
To unsubscribe from this
Maybe this new notification function should be in net/core/dev.c
instead of exporting call_netdevice_notifiers()?
Or actually, does it work to add the call to the notifiers directly in
unregister_netdev() so that device drivers don't have to worry about it?
(And is the existing patch missing
Patrick McHardy wrote:
Chuck Ebbert wrote:
Limit of 1 is forbidden, crashes with 2, works with 3:
From disassembling sch_sfq.ko it seems that it is on line 360 of sch_sfq.c:
sch-qstats.backlog -= skb-len;
where skb is an invalid pointer:
Is it a NULL pointer or something random?
It looks like the comments for dev_put() and dev_hold() got reversed somehow.
Signed-off-by: Roland Dreier [EMAIL PROTECTED]
---
include/linux/netdevice.h |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/include/linux/netdevice.h b/include/linux/netdevice.h
index
On Tue, 2007-09-18 at 18:55 +0100, Denys Vlasenko wrote:
On Tuesday 18 September 2007 19:45, Michael Chan wrote:
We can compress all the different sections of the firmware. Currently,
we only compress the biggest chunks and the rest are uncompressed.
These zeros should compress to almost
From: Michael Chan [EMAIL PROTECTED]
Date: Tue, 18 Sep 2007 11:45:14 -0700
On Tue, 2007-09-18 at 18:23 +0100, Denys Vlasenko wrote:
Do you have any plans to switch to request_firmware() interface,
which will allow you to avoid keeping firmware in unswappable kernel
memory and thus free
In doing some stress testing of the NetXen driver, I found that my machine was
dying in all sorts of weird ways. I saw several different crashes, BUG
messages in the TCP stack and some assert messages in the TCP stack as well.
I really didn't think that there could be six different bugs all
On Tuesday 18 September 2007 19:45, Michael Chan wrote:
We can compress all the different sections of the firmware. Currently,
we only compress the biggest chunks and the rest are uncompressed.
These zeros should compress to almost nothing. But I agree that the
firmware is still big.
You
netif_rx_complete() takes a netdev parameter and does dev_put() on
that netdev, so netif_rx_reschedule() needs to also take a netdev
parameter and do dev_hold() on it to avoid reference counts from
getting becoming negative because of unbalanced dev_put()s.
This should fix the problem reported by
From: Varun Chandramohan [EMAIL PROTECTED]
Date: Tue, 18 Sep 2007 13:30:40 +0530
Sorry for bothering you. I see that you are currently
very busy. I just wanted to remind you that iam waiting for your
feedback on the patch set. Just incase you want me to resend , please
let
From: Jan-Bernd Themann [EMAIL PROTECTED]
Date: Tue, 18 Sep 2007 18:15:45 +0200
One other thing I observed is that I can not unload the module as the
ref counter of the eth device is too low. I haven't tracked down the
source of this problem yet.
This is probably because of the resched
Jeff Dave,
Here it is -- it's big, it's...well...beautiful in its own way...well,
at least it seems to work... :-)
There are some outstanding issues. The driver does more than it
probably should under the covers instead of in the stack, and the
issue of including headers with a
From: H. Peter Anvin [EMAIL PROTECTED]
Date: Tue, 18 Sep 2007 11:41:34 -0700
David Miller wrote:
I don't like it because it means people have to setup full initrd's
in order to do network booting with such network cards.
klibc could help with that, if there is interest in exploring
From: Michael Chan [EMAIL PROTECTED]
Date: Tue, 18 Sep 2007 13:05:51 -0700
The bnx2 firmware changes quite frequently. A new driver quite often
requires new firmware to work correctly. Splitting them up makes things
difficult for the user.
The firmware in tg3 is a lot more mature and I
Patrick McHardy wrote:
Never mind, I found the reason. When enqueuing the packet, sfq_enqueue
contains an off-by-one in the limit check (which IIRC is there for a
reason, but I can't remember right now) and drops the packet again.
dev_queue_xmit() calls qdisc_run() anyway and the empty qdisc
From: John W. Linville [EMAIL PROTECTED]
Date: Tue, 18 Sep 2007 14:50:40 -0400
Jeff Dave,
Here it is -- it's big, it's...well...beautiful in its own way...well,
at least it seems to work... :-)
There are some outstanding issues. The driver does more than it
probably should under the
On 9/18/07, Domen Puncer [EMAIL PROTECTED] wrote:
More testing and getting it to work properly on Phytec pcm030 would
be great.
I compiled it as a module:
CC [M] drivers/net/fec_mpc52xx/fec.o
drivers/net/fec_mpc52xx/fec.c:613: warning: 'mpc52xx_fec_mac_setup'
defined but not used
This code
David Miller wrote:
From: H. Peter Anvin [EMAIL PROTECTED]
Date: Tue, 18 Sep 2007 11:41:34 -0700
David Miller wrote:
I don't like it because it means people have to setup full initrd's
in order to do network booting with such network cards.
klibc could help with that, if there is interest
On 9/18/07, Domen Puncer [EMAIL PROTECTED] wrote:
More testing and getting it to work properly on Phytec pcm030 would
be great.
Do we want to do anything about this?
[1.569657] net eth0: attached phy 0 to driver Generic PHY
[2.576013] Sending DHCP requests .6PHY: f0003000:00 - Link is
Return some useful information such as the maximum listen backlog and the
current listen backlog in the tcp_info structure and INET_DIAG_INFO.
Signed-off-by: Rick Jones [EMAIL PROTECTED]
Signed-off-by: Eric Dumazet [EMAIL PROTECTED]
---
diff -r bdcdd0e1ee9d net/ipv4/tcp.c
--- a/net/ipv4/tcp.c
From: H. Peter Anvin [EMAIL PROTECTED]
Date: Tue, 18 Sep 2007 12:27:04 -0700
Well, what I was referring to here, of course, was the initramfs
integrated in the kernel image, so it all comes out of the kernel build
tree and produces a single bootable image. The fact that part of it
contains
From: Patrick McHardy [EMAIL PROTECTED]
Date: Tue, 18 Sep 2007 21:15:28 +0200
OK the off-by-one prevents an out-of-bounds array access, which
would cause a crash itself. Despite what I said above, sfq does
try to handle dequeues while empty, but forgets to update q-tail
when dropping the last
From: Roland Dreier [EMAIL PROTECTED]
Date: Tue, 18 Sep 2007 10:58:37 -0700
netif_rx_complete() takes a netdev parameter and does dev_put() on
that netdev, so netif_rx_reschedule() needs to also take a netdev
parameter and do dev_hold() on it to avoid reference counts from
getting becoming
Enable users of ip to specify the times for rtt, rttvar and rto_min
in human-friendly terms a la tc while maintaining backwards
compatability with the previous raw mechanism. Builds upon
David Miller's uncommited patch to set rto_min.
Signed-off-by: Rick Jones [EMAIL PROTECTED]
---
From: Roland Dreier [EMAIL PROTECTED]
Date: Tue, 18 Sep 2007 11:04:22 -0700
It looks like the comments for dev_put() and dev_hold() got reversed somehow.
Signed-off-by: Roland Dreier [EMAIL PROTECTED]
Applied, thanks Roland.
-
To unsubscribe from this list: send the line unsubscribe netdev
Herbert Xu wrote:
[PPP] L2TP: Disallow non-UDP datagram sockets
With the addition of UDP-Lite we need to refine the socket check so that
only genuine UDP sockets are allowed through.
Signed-off-by: Herbert Xu [EMAIL PROTECTED]
Acked-by: James Chapman [EMAIL PROTECTED]
-
To unsubscribe from
Herbert Xu wrote:
[PPP] L2TP: Fix skb handling in pppol2tp_recv_core
The function pppol2tp_recv_core doesn't handle non-linear packets properly.
It also fails to check the remote offset field.
This patch fixes these problems. It also removes an unnecessary check on
the UDP header which has
From: Herbert Xu [EMAIL PROTECTED]
Date: Tue, 18 Sep 2007 20:04:38 +0800
On Fri, Aug 31, 2007 at 05:06:25PM +0800, Herbert Xu wrote:
I've audited ppp_generic.c and pppoe.c. I'll do pppol2tp
tomorrow.
Tomrrow took a while to come :)
It took me two weeks to apply the original patch set
Herbert Xu wrote:
[PPP] L2TP: Fix skb handling in pppol2tp_xmit
This patch makes pppol2tp_xmit call skb_cow_head so that we don't modify
cloned skb data. It also gets rid of skb2 we only need to preserve the
original skb for congestion notification, which is only applicable for
ppp_async and
From: Pavel Emelyanov [EMAIL PROTECTED]
Date: Tue, 18 Sep 2007 12:06:53 +0400
I proposed introducing a list_for_each_entry_continue_reverse macro
to be used in setup_net() when unrolling the failed -init callback.
Here is the macro and some more cleanup in the setup_net() itself
to remove
From: Rick Jones [EMAIL PROTECTED]
Date: Tue, 18 Sep 2007 12:54:31 -0700 (PDT)
Return some useful information such as the maximum listen backlog and the
current listen backlog in the tcp_info structure and INET_DIAG_INFO.
Signed-off-by: Rick Jones [EMAIL PROTECTED]
Signed-off-by: Eric
From: James Chapman [EMAIL PROTECTED]
Date: Tue, 18 Sep 2007 21:19:33 +0100
This one causes my test system to lock up. I'll investigate. Please
don't apply this patch for now.
I'll make sure not to push this until we figure out what's
wrong, thanks for checking James.
-
To unsubscribe from
On Tue, Sep 18, 2007 at 01:08:10PM -0700, David Miller wrote:
From: H. Peter Anvin [EMAIL PROTECTED]
Date: Tue, 18 Sep 2007 12:27:04 -0700
Well, what I was referring to here, of course, was the initramfs
integrated in the kernel image, so it all comes out of the kernel build
tree and
Sam Ravnborg wrote:
Except there seems to be great resistance to include userland code in the
kernel as demonstrated at last KS. Or this is maybe just a single vocal
person and the topic were brought up late?
Anyway - if we again consider klibc I will do my best to make the
build stuff as
Jeff Dave,
This series adds the b43 and b43legacy drivers, as well as the ssb
bus infrastructure upon which they depend.
These drivers support the BCM43xx wireless hardware from Broadcom.
The b43 driver supports modern hardware using the version 4 firmware,
while the b43legacy driver uses the
Hi,
while going through going netlink code I found out that netlink_bind()
does not properly check bind parameters. I checked both 2.6.23-rc1 as
well as 2.6.16.53, both are affected.
With a small test prog I wasn't able to crash my maschine though, but
data was accessed out of bounds.
Please
Holger Eitzenberger [EMAIL PROTECTED] writes:
while going through going netlink code I found out that netlink_bind()
does not properly check bind parameters. I checked both 2.6.23-rc1 as
well as 2.6.16.53, both are affected.
With a small test prog I wasn't able to crash my maschine though,
The previous patchlet wasn't correct, please apply this one.
Sorry for the noise.
/holger
[NETLINK] Check for correct bind parameters
Before this change it was possible to pass less than sockaddr_nl
bytes, which might lead to arbitrary data being accessed in
netlink_bind().
Take two.
Patrick McHardy [EMAIL PROTECTED] writes:
+++ net-2.6.24/include/linux/can.h 2007-09-17 10:27:09.0 +0200
Is this file used only from within the kernel? If so you could use
the nicer-to-look-at u8/u16/u32 types instead of the double underscored
ones.
No, this file contains the
On Tue, Sep 18, 2007 at 12:21:50PM -0700, David Miller wrote:
From: Michael Chan [EMAIL PROTECTED]
Date: Tue, 18 Sep 2007 13:05:51 -0700
The bnx2 firmware changes quite frequently. A new driver quite often
requires new firmware to work correctly. Splitting them up makes things
From: John W. Linville [EMAIL PROTECTED]
Date: Tue, 18 Sep 2007 16:28:19 -0400
This series adds the b43 and b43legacy drivers, as well as the ssb
bus infrastructure upon which they depend.
These drivers support the BCM43xx wireless hardware from Broadcom.
The b43 driver supports modern
On Tue, Sep 18, 2007 at 02:31:34PM -0700, David Miller wrote:
From: Willy Tarreau [EMAIL PROTECTED]
Date: Tue, 18 Sep 2007 23:30:25 +0200
On Tue, Sep 18, 2007 at 12:21:50PM -0700, David Miller wrote:
From: Michael Chan [EMAIL PROTECTED]
Date: Tue, 18 Sep 2007 13:05:51 -0700
The
1 - 100 of 127 matches
Mail list logo
