As discussed before, this patch provides userland with a way to access
relevant options in Router Advertisements, after they are processed and
validated by the kernel. Extra options are processed in a generic way;
this patch only exports RDNSS options described in RFC5006, but support
to control
This patch fixes a few typos in comments in include/net/netlink.h
Signed-off-by: Pierre Ynard [EMAIL PROTECTED]
diff --git a/include/net/netlink.h b/include/net/netlink.h
index 83113df..1afd3e8 100644
--- a/include/net/netlink.h
+++ b/include/net/netlink.h
@@ -84,7 +84,7 @@
*
From: Klaus D. Wacker [EMAIL PROTECTED]
HiperSockets infrastructure (layer-3 mode) supports only IPv4 or
IPv6 packets. Sending other packet types disturbs TCP/IP on z/VM,
which issues messages about invalid packets.
Qeth send routine will detect packet type on sending over a
HiperSockets
--
The following patches in qeth and lcs driver are intended for 2.6.24:
- qeth: drop non-IP outbound packets on HiperSocket devices
- qeth: EDDP-mode - correct filling of qdio buffers
- qeth: avoid duplicate deletion of multicast addresses
- lcs: avoid kernel panic in lcs_recovery driven by
From: Ursula Braun [EMAIL PROTECTED]
if qeth_set_multicast_list() is performed on 2 CPUs in parallel,
card-ip_list may end corrupted.
Solution: In function __qeth_delete_all_mc()
remove card-ip_list entry before invoking
qeth_deregister_addr_entry(). Thus a 2nd invocation of
From: Frank Blaschka [EMAIL PROTECTED]
Fix filling the qdio buffers in EDDP mode.
Signed-off-by: Frank Blaschka [EMAIL PROTECTED]
Signed-off-by: Ursula Braun [EMAIL PROTECTED]
---
drivers/s390/net/qeth_eddp.c | 16 +---
drivers/s390/net/qeth_main.c |3 ++-
2 files changed, 11
From: Klaus D. Wacker [EMAIL PROTECTED]
When the lcs irq routine detects channel failures it drives device recovery.
After this event the device is no longer usable for shutdown requests,
because the lcs_irq routine may get wrong channel status information.
In such a case the lcs_irq routine
qeth: discard inbound packets with unknown header id
Signed-off-by: Ursula Braun [EMAIL PROTECTED]
Debugging statements are added for inbound packets with unknown
header id. Those packets are discarded and no longer processed as
osn-packets.
---
drivers/s390/net/qeth_main.c |7 ++-
1
On Thu, Oct 04, 2007 at 09:44:26AM -0700, Stephen Hemminger wrote:
Bugzilla report of open bugs. Yes you could run it yourself but
many of these bugs seem to be old and need some attention or work
to get resolved.
Perhaps we should at least ask the reporters of the older bugs
whether the
On Thu, 4 Oct 2007, TAKANO Ryousei wrote:
This patch allows to process only newly reported SACK blocks at the
sender side. An ACK packet contains up to three SACK blocks, and some
A SACK option that specifies n blocks will have a length of 8*n+2
bytes, so the 40 bytes available for TCP
On Thu, 2007-10-04 at 15:13 -0400, John W. Linville wrote:
That should work as well although I think you should update the comment
above :)
The comment still seem applicable. How would you word it?
Whoops, you're right, I misremembered explaining the use of the pointer.
johannes
Hello,
I have encountered an error which looks tg3-related. Upon adding some
htb queue rules (which I don't have handy ATM but can provide if
needed), after some time we get such messages in the kernel log:
Oct 3 17:04:04 sbd kernel: [ 1941.584154] tg3: eth0: The system may be
re-ordering
This patch adds the CAN broadcast manager (bcm) protocol.
Signed-off-by: Oliver Hartkopp [EMAIL PROTECTED]
Signed-off-by: Urs Thuermann [EMAIL PROTECTED]
---
include/linux/can/bcm.h | 65 +
net/can/Kconfig | 13
net/can/Makefile|3
net/can/bcm.c | 1763
This patch adds the virtual CAN bus (vcan) network driver.
The vcan device is just a loopback device for CAN frames, no
real CAN hardware is involved.
Signed-off-by: Oliver Hartkopp [EMAIL PROTECTED]
Signed-off-by: Urs Thuermann [EMAIL PROTECTED]
---
drivers/net/Makefile |1
Hello Dave, hello Patrick,
this is the tenth post of the patch series that adds the PF_CAN
protocol family for the Controller Area Network.
We've fixed some cosmetic issues as remarked by Arnaldo:
* Rename our static debug variables to {can,raw,bcm,vcan}_debug.
* Use module_param_named() so
This patch adds entries in the CREDITS and MAINTAINERS file for CAN.
Signed-off-by: Oliver Hartkopp [EMAIL PROTECTED]
Signed-off-by: Urs Thuermann [EMAIL PROTECTED]
---
CREDITS | 16
MAINTAINERS |9 +
2 files changed, 25 insertions(+)
Index:
On Thu, 4 Oct 2007, TAKANO Ryousei wrote:
This patch allows to detect loss of retransmitted packets more
accurately by using the highest end sequence number among SACK
blocks. Before the retransmission queue is scanned, the highest
end sequence number (high_end_seq) is retrieved, and this
This patch adds the CAN raw protocol.
Signed-off-by: Oliver Hartkopp [EMAIL PROTECTED]
Signed-off-by: Urs Thuermann [EMAIL PROTECTED]
---
include/linux/can/raw.h | 31 +
net/can/Kconfig | 11
net/can/Makefile|3
net/can/raw.c | 810
This patch adds a protocol/address family number, ARP hardware type,
ethernet packet type, and a line discipline number for the SocketCAN
implementation.
Signed-off-by: Oliver Hartkopp [EMAIL PROTECTED]
Signed-off-by: Urs Thuermann [EMAIL PROTECTED]
---
include/linux/if.h |4 +++-
This patch adds documentation for the PF_CAN protocol family.
Signed-off-by: Oliver Hartkopp [EMAIL PROTECTED]
Signed-off-by: Urs Thuermann [EMAIL PROTECTED]
---
Documentation/networking/00-INDEX |2
Documentation/networking/can.txt | 637 ++
2 files
Linux tau 2.6.23-rc8-mm2-686 #1 SMP Wed Oct 3 23:56:32 CEST 2007 i686
GNU/Linux
eth0 renamed to eth1
sysfs: duplicate filename 'eth1' can not be created
WARNING: at fs/sysfs/dir.c:433 sysfs_add_one()
[c0104f9c] dump_trace+0x68/0x1d5
[c0105121] show_trace_log_lvl+0x18/0x2c
[c0105b9b]
NetArt - Grzegorz Nosek wrote:
I have encountered an error which looks tg3-related. Upon adding some
htb queue rules (which I don't have handy ATM but can provide if
needed), after some time we get such messages in the kernel log:
Please provide the HTB queue rules and the type of traffic
The code in netfilter/nfnetlink.c and in ./net/netlink/genetlink.c looks
like outdated copy/paste from rtnetlink.c. Push them into sync with the
original.
Changes from v1:
- deleted comment in nfnetlink_rcv_msg by request of Patrick McHardy
Signed-off-by: Denis V. Lunev [EMAIL PROTECTED]
There is no need to process outstanding netlink user-kernel packets
during rtnl_unlock now. There is no rtnl_trylock in the rtnetlink_rcv
anymore.
Normal code path is the following:
netlink_sendmsg
netlink_unicast
netlink_sendskb
skb_queue_tail
netlink_data_ready
From: Frank Blaschka [EMAIL PROTECTED]
Fix filling the qdio buffers in EDDP mode.
Signed-off-by: Frank Blaschka [EMAIL PROTECTED]
Signed-off-by: Ursula Braun [EMAIL PROTECTED]
---
drivers/s390/net/qeth_eddp.c | 16 +---
drivers/s390/net/qeth_main.c |3 ++-
2 files changed, 11
From: Ursula Braun [EMAIL PROTECTED]
if qeth_set_multicast_list() is performed on 2 CPUs in parallel,
card-ip_list may end corrupted.
Solution: In function __qeth_delete_all_mc()
remove card-ip_list entry before invoking
qeth_deregister_addr_entry(). Thus a 2nd invocation of
From: Klaus D. Wacker [EMAIL PROTECTED]
When the lcs irq routine detects channel failures it drives device recovery.
After this event the device is no longer usable for shutdown requests,
because the lcs_irq routine may get wrong channel status information.
In such a case the lcs_irq routine
From: Ursula Braun [EMAIL PROTECTED]
Debugging statements are added for inbound packets with unknown
header id. Those packets are discarded and no longer processed as
osn-packets.
Signed-off-by: Ursula Braun [EMAIL PROTECTED]
---
drivers/s390/net/qeth_main.c |7 ++-
1 file changed, 6
From: Klaus D. Wacker [EMAIL PROTECTED]
HiperSockets infrastructure (layer-3 mode) supports only IPv4 or
IPv6 packets. Sending other packet types disturbs TCP/IP on z/VM,
which issues messages about invalid packets.
Qeth send routine will detect packet type on sending over a
HiperSockets
--
Sorry, 2nd attempt, because patch 5/5 missed title line
The following patches in qeth and lcs driver are intended for 2.6.24:
- qeth: drop non-IP outbound packets on HiperSocket devices
- qeth: EDDP-mode - correct filling of qdio buffers
- qeth: avoid duplicate deletion of multicast addresses
This patch make processing netlink user - kernel messages synchronious.
This change was inspired by the talk with Alexey Kuznetsov about current
netlink messages processing. He says that he was badly wrong when introduced
asynchronious user - kernel communication.
The call netlink_unicast is the
netlink_sendskb does not use third argument. Clean it and save a couple of
bytes.
Signed-off-by: Denis V. Lunev [EMAIL PROTECTED]
Acked-by: Alexey Kuznetsov [EMAIL PROTECTED]
--- ./include/linux/netlink.h.nlk5 2007-08-26 19:30:37.0 +0400
+++ ./include/linux/netlink.h 2007-10-02
On Fri, Oct 05, 2007 at 07:16:50AM -0700, Michael Chan wrote:
NetArt - Grzegorz Nosek wrote:
I have encountered an error which looks tg3-related. Upon adding some
htb queue rules (which I don't have handy ATM but can provide if
needed), after some time we get such messages in the
There are currently two ways to determine whether the netlink socket is a
kernel one or a user one. This patch creates a single inline call for
this purpose and unifies all the calls in the af_netlink.c
No similar calls are found outside af_netlink.c.
Signed-off-by: Denis V. Lunev [EMAIL
This patch introduces sndbuf size check before
memory allcation for send buffer.
signed-off-by: Satoshi Oshima [EMAIL PROTECTED]
signed-off-by: Hideo Aoki [EMAIL PROTECTED]
Index: 2.6.23-rc7-udp_limit/net/ipv4/ip_output.c
===
---
This patch introduces global variable for UDP memory accounting.
The unit is page.
signed-off-by: Satoshi Oshima [EMAIL PROTECTED]
signed-off-by: Hideo Aoki [EMAIL PROTECTED]
Index: 2.6.23-rc3-udp_limit/include/net/sock.h
===
---
This patch introduces memory usage accounting for UDP.
signed-off-by: Satoshi Oshima [EMAIL PROTECTED]
signed-off-by: Hideo Aoki [EMAIL PROTECTED]
Index: 2.6.23-rc8-udp_limit/net/ipv4/ip_output.c
===
---
This patch introduces memory limitation for UDP.
signed-off-by: Satoshi Oshima [EMAIL PROTECTED]
signed-off-by: Hideo Aoki [EMAIL PROTECTED]
Index: 2.6.23-rc9-udp_limit/include/net/udp.h
===
---
Hi,
I post a patch set of UDP memory accounting and
limitation.
This patch set is for kernel 2.6.23-rc9. The
differences from take 3 are
* fixing double accounting bug of ip_send_page()
* adding UDP memory limitation.
How to use UDP memory limitation:
This patch set add
Did these patches change on resend? Or just addressees?
Jeff
-
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Jeff,
patches have not changed on resend, just the header part of [patch 5/5].
Ursula
Jeff Garzik
[EMAIL PROTECTED]
I just checked the following into net-2.6.24, besides minor
tweaks and bug fixes, this is probably what is going to Linus.
I verified it builds no just on sparc64 but also even on 32-bit
platforms such as x86. :-)
Thanks!
Build failed on x86_64
ERROR: __bad_udelay [drivers/net/niu.ko]
I just checked the following into net-2.6.24, besides minor
tweaks and bug fixes, this is probably what is going to Linus.
I verified it builds no just on sparc64 but also even on 32-bit
platforms such as x86. :-)
Thanks!
Output of checkpatch.pl for your patch:
CHECK: Use #include
I just checked the following into net-2.6.24, besides minor
tweaks and bug fixes, this is probably what is going to Linus.
I verified it builds no just on sparc64 but also even on 32-bit
platforms such as x86. :-)
Thanks!
Sparse warnings from new driver.
CHECK drivers/net/niu.c
On Sat, 06 Oct 2007 00:02:47 +0900
Satoshi OSHIMA [EMAIL PROTECTED] wrote:
This patch introduces memory limitation for UDP.
signed-off-by: Satoshi Oshima [EMAIL PROTECTED]
signed-off-by: Hideo Aoki [EMAIL PROTECTED]
Index: 2.6.23-rc9-udp_limit/net/ipv4/sysctl_net_ipv4.c
Fix warnings from sparse checker about shadowed definition and improperly
formatted ethtool_strings.
I chose to change module parameter rather than uglify the code by changing
the variable name.
Signed-off-by: Stephen Hemminger [EMAIL PROTECTED]
---
CHECK drivers/net/s2io.c
Denis V. Lunev wrote:
This patch make processing netlink user - kernel messages synchronious.
This change was inspired by the talk with Alexey Kuznetsov about current
netlink messages processing. He says that he was badly wrong when introduced
asynchronious user - kernel communication.
The
maximilian attems wrote:
Linux tau 2.6.23-rc8-mm2-686 #1 SMP Wed Oct 3 23:56:32 CEST 2007 i686
GNU/Linux
eth0 renamed to eth1
sysfs: duplicate filename 'eth1' can not be created
WARNING: at fs/sysfs/dir.c:433 sysfs_add_one()
[c0104f9c] dump_trace+0x68/0x1d5
[c0105121]
Hi David,
some minor nits.
Could this driver be split into more files. 8k lines per file
is quite a lot. Although GCC might optimize it best this way :-)
David Miller schrieb:
+#define nr64(reg)readq(np-regs + (reg))
+#define nw64(reg, val) writeq((val), np-regs +
Ingo Oeser schrieb:
+static void niu_init_xif(struct niu *);
+
+static int link_status_10g(struct niu *np, int *link_up_p)
+{
+ unsigned long flags;
+ int err, link_up;
+
+ if (np-link_config.loopback_mode != LOOPBACK_DISABLED)
+ return -EINVAL;
+
+ link_up
Patrick McHardy wrote:
Denis V. Lunev wrote:
This patch make processing netlink user - kernel messages synchronious.
This change was inspired by the talk with Alexey Kuznetsov about current
netlink messages processing. He says that he was badly wrong when introduced
asynchronious user -
Ingo Oeser wrote:
Hi David,
some minor nits.
Could this driver be split into more files. 8k lines per file
is quite a lot. Although GCC might optimize it best this way :-)
gcc does optimize it better this way, but overall, it's maintainer's
preference. It's far easier for many to have
(Please reply via emailed reply-to-all, not via the bugzilla web interface)
On Fri, 5 Oct 2007 09:01:50 -0700 (PDT)
[EMAIL PROTECTED] wrote:
http://bugzilla.kernel.org/show_bug.cgi?id=9128
Summary: PF_KEY SADB_GET messages return SADB_DUMP from the
kernel
Ingo Oeser wrote:
Hi David,
some minor nits.
Could this driver be split into more files. 8k lines per file
is quite a lot. Although GCC might optimize it best this way :-)
Ingo,
Some r info on Neptune HW to explains some of the constants ...
Regards
Matheos
+ ctrl_val =
Stephen Hemminger wrote:
Fix warnings from sparse checker about shadowed definition and improperly
formatted ethtool_strings.
I chose to change module parameter rather than uglify the code by changing
the variable name.
Changing the name of existing module parameters can potentially
Auke Kok wrote:
A small bug crawled in the -DDEBUG enabled code. Fix this to
properly call the backreference device name.
Signed-off-by: Auke Kok [EMAIL PROTECTED]
---
drivers/net/e1000e/hw.h |2 +-
drivers/net/e1000e/netdev.c |4 +---
2 files changed, 2 insertions(+), 4
Auke Kok wrote:
A merge/cleanup code accidentally dropped 8254x code in and removed
8257x code here. Undo this mistake and use the pci-e relevant register
test similar as to what is in e1000.
Signed-off-by: Auke Kok [EMAIL PROTECTED]
---
drivers/net/e1000e/ethtool.c | 14 ++
1
Auke Kok wrote:
A small bug crawled in the -DDEBUG enabled code. Fix this to
properly call the backreference device name.
Signed-off-by: Auke Kok [EMAIL PROTECTED]
---
drivers/net/e1000e/hw.h |2 +-
drivers/net/e1000e/netdev.c |4 +---
2 files changed, 2 insertions(+), 4
applied 1-5
-
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Auke Kok wrote:
The e1000 register dump code can print out e1000e register dump
information as well, so enable it for e1000e devices.
Signed-off-by: Auke Kok [EMAIL PROTECTED]
applied
-
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL
Francois Romieu wrote:
The 8169/8110SC currently announces itself as:
[...]
eth0: RTL8169sc/8110sc at 0x, ..:..:..:..:..:.., XID 1800 IRQ ..
It uses RTL_GIGA_MAC_VER_05 and this part of the changeset can cut
its
Please pull from 'upstream-davem' branch of
master.kernel.org:/pub/scm/linux/kernel/git/jgarzik/netdev-2.6.git
upstream-davem
to receive the following updates:
Auke Kok (2):
e1000e: fix debugging printout code
e1000e: Fix ethtool register test code
Frank Blaschka (1):
qeth:
Fix a rather large performance regression.
Please pull from 'upstream-linus' branch of
master.kernel.org:/pub/scm/linux/kernel/git/jgarzik/netdev-2.6.git
upstream-linus
to receive the following updates:
drivers/net/r8169.c | 16 +---
1 files changed, 13 insertions(+), 3
Jay Vosburgh wrote:
IPoIB uses a two layer neighboring scheme, such that for each struct neighbour
whose device is an ipoib one, there is a struct ipoib_neigh buddy which is
created on demand at the tx flow by an ipoib_neigh_alloc(skb-dst-neighbour)
call.
When using the bonding driver,
Fix warnings from sparse checker about shadowed definition and improperly
formatted ethtool_strings.
Signed-off-by: Stephen Hemminger [EMAIL PROTECTED]
---
CHECK drivers/net/s2io.c
drivers/net/s2io.c:2892:15: warning: symbol 'lro' shadows an earlier one
drivers/net/s2io.c:471:1: originally
From: maximilian attems [EMAIL PROTECTED]
Date: Fri, 5 Oct 2007 15:11:15 +0200
net eth1: device_rename: sysfs_create_symlink failed (-17)
...
no idea if aboves belongs to netdev or sysfs dep.
I think the report belongs to udev.
It tries to rename network devices even if they already
have the
From: Stephen Hemminger [EMAIL PROTECTED]
Date: Fri, 5 Oct 2007 08:40:36 -0700
WARNING: braces {} are not necessary for single statement blocks
#691: FILE: drivers/net/niu.c:603:
+ if (lp-loopback_mode == LOOPBACK_PHY) {
+ test_cfg_val |= ((ENET_TEST_MD_PAD_LOOPBACK
+
From: Stephen Hemminger [EMAIL PROTECTED]
Date: Fri, 5 Oct 2007 08:39:24 -0700
Build failed on x86_64
ERROR: __bad_udelay [drivers/net/niu.ko] undefined!
Can you figure out which udelay() call is too big and
thus causing problems?
-
To unsubscribe from this list: send the line unsubscribe
David Miller wrote:
From: Stephen Hemminger [EMAIL PROTECTED]
Date: Fri, 5 Oct 2007 08:40:36 -0700
WARNING: braces {} are not necessary for single statement blocks
#691: FILE: drivers/net/niu.c:603:
+ if (lp-loopback_mode == LOOPBACK_PHY) {
+ test_cfg_val |=
From: Krishna Kumar [EMAIL PROTECTED]
Some simple optimizations in e1000_xmit_frame.
Signed-off-by: Krishna Kumar [EMAIL PROTECTED]
---
drivers/net/e1000/e1000_main.c |9 -
1 files changed, 4 insertions(+), 5 deletions(-)
diff --git a/drivers/net/e1000/e1000_main.c
After an e1000 patch from Krishna Kumar [EMAIL PROTECTED].
Signed-off-by: Auke Kok [EMAIL PROTECTED]
---
drivers/net/e1000e/netdev.c |9 -
1 files changed, 4 insertions(+), 5 deletions(-)
diff --git a/drivers/net/e1000e/netdev.c b/drivers/net/e1000e/netdev.c
index 71c9fed..033e124
From: Ingo Oeser [EMAIL PROTECTED]
Date: Fri, 5 Oct 2007 18:46:19 +0200
Could this driver be split into more files. 8k lines per file
is quite a lot. Although GCC might optimize it best this way :-)
Absolutely not!!!
I hate multiple file drivers, with a passion, they absolutely and
On Fri, 05 Oct 2007 14:12:47 -0700 (PDT)
David Miller [EMAIL PROTECTED] wrote:
From: Stephen Hemminger [EMAIL PROTECTED]
Date: Fri, 5 Oct 2007 08:39:24 -0700
Build failed on x86_64
ERROR: __bad_udelay [drivers/net/niu.ko] undefined!
Can you figure out which udelay() call is too big
From: Ingo Oeser [EMAIL PROTECTED]
Date: Fri, 5 Oct 2007 18:46:19 +0200
David Miller schrieb:
+#define nr64(reg) readq(np-regs + (reg))
+#define nw64(reg, val) writeq((val), np-regs + (reg))
+
+#define nr64_mac(reg) readq(np-mac_regs + (reg))
+#define
Kok, Auke [EMAIL PROTECTED] writes:
maximilian attems wrote:
Linux tau 2.6.23-rc8-mm2-686 #1 SMP Wed Oct 3 23:56:32 CEST 2007 i686
GNU/Linux
eth0 renamed to eth1
sysfs: duplicate filename 'eth1' can not be created
WARNING: at fs/sysfs/dir.c:433 sysfs_add_one()
[c0104f9c]
On Fri, 05 Oct 2007 17:14:31 -0400
Jeff Garzik [EMAIL PROTECTED] wrote:
David Miller wrote:
From: Stephen Hemminger [EMAIL PROTECTED]
Date: Fri, 5 Oct 2007 08:40:36 -0700
WARNING: braces {} are not necessary for single statement blocks
#691: FILE: drivers/net/niu.c:603:
+ if
Matheos, no developers, including me, are going to read this since it
was in HTML, please post in plain ASCII text if you'd like to discuss
the driver with us, thanks.
-
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL PROTECTED]
More majordomo
From: Jeff Garzik [EMAIL PROTECTED]
Date: Fri, 05 Oct 2007 17:14:31 -0400
You just have to ignore some of its complaints. Part of my coding style
includes the multiple assignment thing that checkpatch complains about:
status =
msi-status = br32(QDMA_STAT);
and I am not
From: Stephen Hemminger [EMAIL PROTECTED]
Date: Fri, 5 Oct 2007 14:21:48 -0700
All it's complaints don't have to be fixed, same goes for sparse.
It just helps catch unintentional cruft.
That's true.
-
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to
Stephen Hemminger [EMAIL PROTECTED] writes:
On Fri, 28 Sep 2007 22:47:16 -0400
Jeff Garzik [EMAIL PROTECTED] wrote:
Ayaz Abdulla wrote:
I am trying to track down a forcedeth driver issue described by bug 9047
in bugzilla (2.6.23-rc7-git1 forcedeth w/ MCP55 oops under heavy load).
I
Ingo Oeser wrote:
Hi David,
Repost since my last post ended up being html
Regards,
matheos
some minor nits.
Some Neptune HW info to explain some of the constants ...
Could this driver be split into more files. 8k lines per file
+ case 0:
+ ctrl_reg =
After a cable unplug the forced flow control settings were lost
accidentally and the flow control settings fell back to the default
EEPROM determined values. This breaks for people who want to
run without fc enabled - after a cable reset the driver would
refuse to run with fc disabled.
From: Matheos Worku [EMAIL PROTECTED]
Date: Fri, 05 Oct 2007 15:18:37 -0700
+static void niu_set_max_burst(struct niu *np, struct tx_ring_info *rp)
+{
+ int mtu = np-dev-mtu;
+
+ rp-max_burst = mtu + 32;
+ if (rp-max_burst 4096)
+ rp-max_burst = 4096;
Why 32 and
From: Stephen Hemminger [EMAIL PROTECTED]
Date: Fri, 5 Oct 2007 08:35:56 -0700
These match with existing netif_msg_XXX and your
driver already has msglvl ethtool hook.
...
Do you really want to print all these at KERN_ERR level?
Both fixed, thanks!
From
From: Stephen Hemminger [EMAIL PROTECTED]
Date: Fri, 5 Oct 2007 08:35:56 -0700
pr_info() ?
All corrected, thanks!
From 11aaa8adc8e9141a440faaa3260ad5922c71eeda Mon Sep 17 00:00:00 2001
From: David S. Miller [EMAIL PROTECTED]
Date: Fri, 5 Oct 2007 15:53:21 -0700
Subject: [PATCH] [NIU]: Use
From: Stephen Hemminger [EMAIL PROTECTED]
Date: Fri, 5 Oct 2007 08:35:56 -0700
+static int __niu_wait_bits_clear(struct niu *np, unsigned long reg,
+u64 bits, int limit, int delay)
+{
+ BUILD_BUG_ON(limit = 0 || delay 0);
redundant you already checked
From: Stephen Hemminger [EMAIL PROTECTED]
Date: Fri, 5 Oct 2007 08:35:56 -0700
+ BUG_ON(!page);
BUG_ON checks for NULL are useless if the code following is
just going to dereference the pointer anyway.
Agreed, all such cases fixed in the patch below, thanks!
+ for (i = 0; i
I tested this by simulating a slow passive side responder, and it worked as
expected for those tests. Using an MRA does add another MAD to the CM
exchange,
which is why it is sent only after seeing a duplicate request.
Alternatively,
we can take the OFED module parameter patch.
From: Stephen Hemminger [EMAIL PROTECTED]
Date: Fri, 5 Oct 2007 08:35:56 -0700
+static void niu_log_rxchan_errors(struct niu *np, struct rx_ring_info *rp,
+ u64 stat)
+{
+ printk(KERN_ERR PFX %s: RX channel %u errors ( ,
+ np-dev-name,
From: Stephen Hemminger [EMAIL PROTECTED]
Date: Fri, 5 Oct 2007 08:35:56 -0700
+static int niu_set_settings(struct net_device *dev, struct ethtool_cmd
*cmd)
+{
+ return -EINVAL;
+}
Why not leave function ptr null and get -EOPNOTSUPP
To be honest, it's there mostly to remind me
From: Stephen Hemminger [EMAIL PROTECTED]
Date: Fri, 5 Oct 2007 14:18:50 -0700
--- a/drivers/net/niu.c 2007-10-05 08:09:31.0 -0700
+++ b/drivers/net/niu.c 2007-10-05 08:42:06.0 -0700
@@ -804,7 +804,7 @@ static int bcm8704_init_user_dev3(struct
if (err)
David Miller wrote:
From: Stephen Hemminger [EMAIL PROTECTED]
Date: Fri, 5 Oct 2007 08:35:56 -0700
+static void niu_log_rxchan_errors(struct niu *np, struct rx_ring_info *rp,
+ u64 stat)
+{
+ printk(KERN_ERR PFX %s: RX channel %u errors ( ,
+
From: Stephen Hemminger [EMAIL PROTECTED]
Date: Fri, 5 Oct 2007 08:40:36 -0700
Output of checkpatch.pl for your patch:
I've made cures for the cases which make sense, thanks!
commit 2ab9ea48dae8fd46e525460700e7e497c9cb92f8
Author: David S. Miller [EMAIL PROTECTED]
Date: Fri Oct 5 16:41:00
From: Stephen Hemminger [EMAIL PROTECTED]
Date: Fri, 5 Oct 2007 08:43:17 -0700
Sparse warnings from new driver.
CHECK drivers/net/niu.c
drivers/net/niu.c:619:7: warning: symbol 'err' shadows an earlier one
drivers/net/niu.c:574:6: originally declared here
drivers/net/niu.c:4673:7:
From: Ingo Oeser [EMAIL PROTECTED]
Date: Fri, 5 Oct 2007 18:49:49 +0200
Ingo Oeser schrieb:
+static void niu_init_xif(struct niu *);
+
+static int link_status_10g(struct niu *np, int *link_up_p)
+{
+ unsigned long flags;
+ int err, link_up;
+
+ if
From: Ingo Oeser [EMAIL PROTECTED]
Date: Fri, 5 Oct 2007 18:46:19 +0200
+static int niu_num_alt_addr(struct niu *np)
static int niu_num_alt_addr(const struct niu *np)
There are a lot of functions that can be modified to take
a const struct niu * argument, if I find some time I'll
go over the
Fix a bunch of sparse warnings. Mostly about 0 used as
NULL pointer, and shadowed variable declarations.
The two noteable changes are:
* hash size should have been unsigned
* cls_u32 had a case where error code wasn't been
propogated properly, so it could return 0 but still
have an error.
Fix some of the easy warnings in network device drivers.
Signed-off-by: Stephen Hemminger [EMAIL PROTECTED]
---
drivers/net/acenic.c | 37 +++--
drivers/net/atl1/atl1_main.c |5 +++--
drivers/net/dl2k.c |8
drivers/net/e100.c
On Fri, 05 Oct 2007 17:04:28 -0700 (PDT)
David Miller [EMAIL PROTECTED] wrote:
From: Stephen Hemminger [EMAIL PROTECTED]
Date: Fri, 5 Oct 2007 08:43:17 -0700
Sparse warnings from new driver.
CHECK drivers/net/niu.c
drivers/net/niu.c:619:7: warning: symbol 'err' shadows an earlier one
From: Stephen Hemminger [EMAIL PROTECTED]
Date: Fri, 5 Oct 2007 17:28:01 -0700
On Fri, 05 Oct 2007 17:04:28 -0700 (PDT)
David Miller [EMAIL PROTECTED] wrote:
From: Stephen Hemminger [EMAIL PROTECTED]
Date: Fri, 5 Oct 2007 08:43:17 -0700
drivers/net/niu.c:203:2: error: bad constant
1 - 100 of 107 matches
Mail list logo
