-Original Message-
From: Herbert Xu [mailto:[EMAIL PROTECTED]
Sent: den 9 oktober 2007 05:17
To: [EMAIL PROTECTED]
Cc: netdev@vger.kernel.org
Subject: Re: raw PF_PACKET protocol selection
Joakim Tjernlund [EMAIL PROTECTED] wrote:
I trying to open my own raw PF_PACKET
From: Ilpo Järvinen [EMAIL PROTECTED]
Subject: Re: [RFC][PATCH 1/2] TCP: fix lost retransmit detection
Date: Mon, 8 Oct 2007 14:11:55 +0300 (EEST)
On Sun, 7 Oct 2007, TAKANO Ryousei wrote:
From: Ilpo Järvinen [EMAIL PROTECTED]
Subject: Re: [RFC][PATCH 1/2] TCP: fix lost retransmit
Fix inconsistency of terms:
1) D-SACK
2) F-RTO
Signed-off-by: Ryousei Takano [EMAIL PROTECTED]
---
Documentation/networking/ip-sysctl.txt |6 +++---
net/ipv4/tcp_input.c | 16
2 files changed, 11 insertions(+), 11 deletions(-)
diff --git
On Mon, Oct 08, 2007 at 06:16:17PM +0200, Eliezer Tamir wrote:
bnx2x_hsi.h - machine generated hardware and microcode definitions
over 7000 lines... how much of this is really needed?
-
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL PROTECTED]
TCP Vegas implementation has a bug in the process of disabling
slow-start with gamma parameter. The bug may lead to extreme
unfairness in the presence of early packet loss. See details in:
http://www.cs.caltech.edu/~weixl/technical/ns2linux/known_linux/index.html#vegas
Switch the order of if
On Tue, Oct 09, 2007 at 08:08:22AM +0200, Joakim Tjernlund ([EMAIL PROTECTED])
wrote:
Your program works fine here. You did run it as root, right?
Yes and ETH_P_ALL is the only protocol that prints anything
I am on 2.6.22
ETH_P_ARP works too.
Did you try stracing it?
Just did and
To judge the timing for DAD, netif_carrier_ok() is used. However,
there is a possibility that dev-qdisc stays noop_qdisc even if
netif_carrier_ok() returns true. In that case, DAD NS is not sent out.
We need to defer the IPv6 device initialization until a valid qdisc
is specified.
Signed-off-by:
Jay Vosburgh wrote:
Jeff Garzik [EMAIL PROTECTED] wrote:
Moni Shoua wrote:
Jay Vosburgh wrote:
ACK patches 3 - 9.
Roland, are you comfortable with the IB changes in patches 1 and 2?
Jeff, when Roland acks patches 1 and 2, please apply all 9.
-J
Hi Jeff,
Roland acked the
On Tue, 2007-10-09 at 11:13 +0400, Evgeniy Polyakov wrote:
On Tue, Oct 09, 2007 at 08:08:22AM +0200, Joakim Tjernlund ([EMAIL
PROTECTED]) wrote:
Your program works fine here. You did run it as root, right?
Yes and ETH_P_ALL is the only protocol that prints anything
I am on 2.6.22
On Tue, Oct 09, 2007 at 09:27:38AM +0200, Joakim Tjernlund ([EMAIL PROTECTED])
wrote:
Did you change eth_type_trans() to catch your proto?
Just fond out something:
if I redirect my prog like so:
./sniff log
and press Ctrl-C after a packet has been sent to it,
it does NOT work. I
On Tue, 2007-10-09 at 11:34 +0400, Evgeniy Polyakov wrote:
On Tue, Oct 09, 2007 at 09:27:38AM +0200, Joakim Tjernlund ([EMAIL
PROTECTED]) wrote:
Did you change eth_type_trans() to catch your proto?
Just fond out something:
if I redirect my prog like so:
./sniff log
and press
On Tue, Oct 09, 2007 at 09:27:38AM +0200, Joakim Tjernlund wrote:
Just fond out something:
if I redirect my prog like so:
./sniff log
and press Ctrl-C after a packet has been sent to it,
it does NOT work. I don't get ANY output in my log file, not
even the printf(-\n) appears.
J Hadi Salim [EMAIL PROTECTED] wrote on 10/08/2007 07:35:20 PM:
I dont see something from Krishna's approach that i can take and reuse.
This maybe because my old approaches have evolved from the same path.
There is a long list but as a sample: i used to do a lot more work while
holding the
On Tue, Oct 09, 2007 at 09:51:25AM +0200, Joakim Tjernlund ([EMAIL PROTECTED])
wrote:
On Tue, 2007-10-09 at 11:34 +0400, Evgeniy Polyakov wrote:
On Tue, Oct 09, 2007 at 09:27:38AM +0200, Joakim Tjernlund ([EMAIL
PROTECTED]) wrote:
Did you change eth_type_trans() to catch your proto?
On Tue, 2007-10-09 at 12:17 +0400, Evgeniy Polyakov wrote:
On Tue, Oct 09, 2007 at 09:51:25AM +0200, Joakim Tjernlund ([EMAIL
PROTECTED]) wrote:
On Tue, 2007-10-09 at 11:34 +0400, Evgeniy Polyakov wrote:
On Tue, Oct 09, 2007 at 09:27:38AM +0200, Joakim Tjernlund ([EMAIL
PROTECTED])
The TCP bug fix that went into Linus's tree today created some
conflicts with net-2.6.24, so I rebased:
kernel.org:/pub/scm/linux/kernel/git/davem/net-2.6.24.git
I took the opportunity to integrate fix patches into the patches which
introduced those bugs or build failures.
BTW, when
The unregister_netdevice() and dev_change_net_namespace()
both check for dev-flags to be IFF_UP before calling the
dev_close(), but the dev_close() checks for IFF_UP itself,
so remove those unneeded checks.
Signed-off-by: Pavel Emelyanov [EMAIL PROTECTED]
---
diff --git a/net/core/dev.c
Hi Peter,
Waskiewicz Jr, Peter P [EMAIL PROTECTED] wrote on
10/09/2007 04:03:42 AM:
true, that needs some resolution. Heres a hand-waving thought:
Assuming all packets of a specific map end up in the same
qdiscn queue, it seems feasible to ask the qdisc scheduler to
give us enough
From: Krishna Kumar2 [EMAIL PROTECTED]
Date: Tue, 9 Oct 2007 16:28:27 +0530
Isn't it enough that the multiqueue+batching drivers handle skbs
belonging to different queue's themselves, instead of qdisc having
to figure that out? This will reduce costs for most skbs that are
neither batched nor
Hi Dave,
David Miller [EMAIL PROTECTED] wrote on 10/09/2007 04:32:55 PM:
Isn't it enough that the multiqueue+batching drivers handle skbs
belonging to different queue's themselves, instead of qdisc having
to figure that out? This will reduce costs for most skbs that are
neither batched
David Miller [EMAIL PROTECTED] wrote on 10/09/2007 04:32:55 PM:
Ignore LLTX, it sucks, it was a big mistake, and we will get rid of
it.
Great, this will make life easy. Any idea how long that would take?
It seems simple enough to do.
thanks,
- KK
-
To unsubscribe from this list: send the
From: Krishna Kumar2 [EMAIL PROTECTED]
Date: Tue, 9 Oct 2007 16:51:14 +0530
David Miller [EMAIL PROTECTED] wrote on 10/09/2007 04:32:55 PM:
Ignore LLTX, it sucks, it was a big mistake, and we will get rid of
it.
Great, this will make life easy. Any idea how long that would take?
It
Pavel Emelyanov wrote:
The unregister_netdevice() and dev_change_net_namespace()
both check for dev-flags to be IFF_UP before calling the
dev_close(), but the dev_close() checks for IFF_UP itself,
so remove those unneeded checks.
Signed-off-by: Pavel Emelyanov [EMAIL PROTECTED]
---
diff
Jeff Garzik wrote:
Pavel Emelyanov wrote:
The unregister_netdevice() and dev_change_net_namespace()
both check for dev-flags to be IFF_UP before calling the
dev_close(), but the dev_close() checks for IFF_UP itself,
so remove those unneeded checks.
Signed-off-by: Pavel Emelyanov [EMAIL
The newly created net namespace is set to 0 with memset()
in setup_net(). The setup_net() is also called for the
init_net_ns(), which is zeroed naturally as a global var.
So remove this memset and allocate new nets with the
kmem_cache_zalloc().
Signed-off-by: Pavel Emelyanov [EMAIL PROTECTED]
On Tue, 9 Oct 2007, TAKANO Ryousei wrote:
From: Ilpo Järvinen [EMAIL PROTECTED]
Subject: Re: [RFC][PATCH 1/2] TCP: fix lost retransmit detection
Date: Mon, 8 Oct 2007 14:11:55 +0300 (EEST)
On Sun, 7 Oct 2007, TAKANO Ryousei wrote:
From: Ilpo Järvinen [EMAIL PROTECTED]
Just
Lost_retrans handling of sacktag was found to be flawed, two
problems that were found have an intertwined solution. Fastpath
problem has existed since hints got added and the other problem
has probably been there even longer than that. ...This change
may add non-trivial processing cost.
Initial
Follows own function for each task principle, this is really
somewhat separate task being done in sacktag. Also reduces
indentation.
In addition, added ack_seq local var to break some long
lines fixed coding style things.
Signed-off-by: Ilpo Järvinen [EMAIL PROTECTED]
---
net/ipv4/tcp_input.c
Detection implemented with lost_retrans must work also when
fastpath is taken, yet most of the queue is skipped including
(very likely) those retransmitted skb's we're interested in.
This problem appeared when the hints got added, which removed
a need to always walk over the whole write queue
This addition of lost_retrans_low to tcp_sock might be
unnecessary, it's not clear how often lost_retrans worker is
executed when there wasn't work to do.
Cc: TAKANO Ryousei [EMAIL PROTECTED]
Signed-off-by: Ilpo Järvinen [EMAIL PROTECTED]
---
include/linux/tcp.h |2 ++
net/ipv4/tcp_input.c
Currently indexes for netdevices come sequentially one by
one, and the same stays true even for devices that are
created for namespaces.
Side effects of this are:
* lo device has not 1 index in a namespace. This may break
some userspace that relies on it (and AFAIR something
really broke
David Miller wrote:
From: Krishna Kumar2 [EMAIL PROTECTED]
Date: Tue, 9 Oct 2007 16:51:14 +0530
David Miller [EMAIL PROTECTED] wrote on 10/09/2007 04:32:55 PM:
Ignore LLTX, it sucks, it was a big mistake, and we will get rid of
it.
Great, this will make life easy. Any idea how long that
ax88796: add superh to kconfig depencencies
This patch adds sh architecture support to the ax88796 kconfig.
Signed-off-by: Magnus Damm [EMAIL PROTECTED]
---
This is a broken out version of the larger patch recently posted to netdev:
On Tue, Oct 09, 2007 at 08:44:25AM -0400, Jeff Garzik wrote:
David Miller wrote:
I can just threaten to do them all and that should get the driver
maintainers going :-)
What, like this? :)
Awsome :)
--
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmVHI~} [EMAIL
Herbert Xu wrote:
On Tue, Oct 09, 2007 at 08:44:25AM -0400, Jeff Garzik wrote:
David Miller wrote:
I can just threaten to do them all and that should get the driver
maintainers going :-)
What, like this? :)
Awsome :)
Note my patch is just to get the maintainers going. :) I'm not going
On Tue, 9 Oct 2007, Ilpo Järvinen wrote:
Lost_retrans handling of sacktag was found to be flawed, two
problems that were found have an intertwined solution. Fastpath
problem has existed since hints got added and the other problem
has probably been there even longer than that. ...This change
On Tue, 2007-09-10 at 08:39 +0530, Krishna Kumar2 wrote:
Driver might ask for 10 and we send 10, but LLTX driver might fail to get
lock and return TX_LOCKED. I haven't seen your code in greater detail, but
don't you requeue in that case too?
For others drivers that are non-batching and LLTX,
On Tue, 2007-09-10 at 13:44 +0530, Krishna Kumar2 wrote:
My feeling is that since the approaches are very different,
My concern is the approaches are different only for short periods of
time. For example, I do requeueing, have xmit_win, have -end_xmit,
do batching from core etc; if you see
On Mon, 2007-08-10 at 15:40 -0700, Kok, Auke wrote:
My biggest problem with the patch as you sent it that it's a tonload of
changes
and no implicit benefit immediately as I can see.
The patch looks scary but is pretty tame when you apply it and stare at
it.
I would really have to see
On Tue, 2007-09-10 at 12:00 +0800, Herbert Xu wrote:
OK, after waking up a bit more
me too;-
What I'm worried about is would we see worse behaviour with
drivers that do all their TX clean-up with the TX lock held
Good point Herbert.
When i looked around i only found one driver that
On Mon, 8 Oct 2007, Steve Wise wrote:
The correct solution, IMO, is to enhance the core low level 4-tuple
allocation services to be more generic (eg: not be tied to a struct
sock). Then the host tcp stack and the host rdma stack can allocate
TCP/iWARP ports/4tuples from this common
On Tue, Oct 09, 2007 at 09:51:38PM +0900, Magnus Damm wrote:
ax88796: add superh to kconfig depencencies
This patch adds sh architecture support to the ax88796 kconfig.
Signed-off-by: Magnus Damm [EMAIL PROTECTED]
Acked-by: Paul Mundt [EMAIL PROTECTED]
-
To unsubscribe from this list: send
Steps to reproduce:
Server:
[EMAIL PROTECTED] ~]# cat /etc/exports
/export *(ro,insecure)
// there is insecure ... I am using ports like 1024 to 61000
[EMAIL PROTECTED] ~] service nfs restart
Client:
[EMAIL PROTECTED] ~]# echo 32768 32768
/proc/sys/net/ipv4/ip_local_port_range
32768
Hi Dave:
Here's another round of patches which ends with the moving down
of the state lock into x-type-output. I need to stop getting
distracted by fixing bugs and concentrate on creating them :)
Cheers,
--
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmVHI~} [EMAIL
[IPSEC]: Remove bogus ref count in xfrm_secpath_reject
Constructs of the form
xfrm_state_hold(x);
foo(x);
xfrm_state_put(x);
tend to be broken because foo is either synchronous where this is totally
unnecessary or if foo is asynchronous then the reference count is in the
[IPSEC]: Store IPv6 nh pointer in mac_header on output
Current the x-mode-output functions store the IPv6 nh pointer in the
skb network header. This is inconvenient because the network header then
has to be fixed up before the packet can leave the IPsec stack. The mac
header field is unused on
[IPSEC]: Remove gratuitous km wake-up events on ACQUIRE
There is no point in waking people up when creating/updating larval states
because they'll just go back to sleep again as larval states by definition
cannot be found by xfrm_state_find.
We should only wake them up when the larvals mature or
[IPSEC]: Move common code into xfrm_alloc_spi
This patch moves some common code that conceptually belongs to the xfrm core
from af_key/xfrm_user into xfrm_alloc_spi.
In particular, the spin lock on the state is now taken inside xfrm_alloc_spi.
Previously it also protected the construction of the
[IPSEC]: Lock state when copying non-atomic fields to user-space
This patch adds locking so that when we're copying non-atomic fields such as
life-time or coaddr to user-space we don't get a partial result.
For af_key I've changed every instance of pfkey_xfrm_state2msg apart from
expiration
[XFRM] user: Move attribute copying code into copy_to_user_state_extra
Here's a good example of code duplication leading to code rot. The
notification patch did its own netlink message creation for xfrm states.
It duplicated code that was already in dump_one_state. Guess what, the
next time
[IPSEC]: Move state lock into x-type-output
This patch releases the lock on the state before calling x-type-output.
It also adds the lock to the spots where they're currently needed.
Most of those places (all except mip6) are expected to disappear with
async crypto.
Signed-off-by: Herbert Xu
Pavel Emelyanov wrote:
Currently indexes for netdevices come sequentially one by
one, and the same stays true even for devices that are
created for namespaces.
Side effects of this are:
* lo device has not 1 index in a namespace. This may break
some userspace that relies on it (and AFAIR
On Tue, 2007-10-09 at 08:18 -0700, David Brownell wrote:
This patch makes the host RNDIS driver talk to RNDIS devices with an MTU
less than 1.5k, instead of refusing to talk to such a device.
Please apply.
Signed-Off-by: Thomas Sailer [EMAIL PROTECTED]
Acked-by: David Brownell [EMAIL
Many (very many) seq files in net/ allocate some private data
to use it later (mostly for iteration state). All this code
was obviously get using copy-paste method, so move it into
one place.
Almost all of these places either set this private to 0, or
keep uninitialized. Some places, however,
This function allocates the zeroed chunk of memory and
call seq_open(). The __seq_open_private() helper returns
the allocated memory to make it possible for the caller
to initialize it.
Signed-off-by: Pavel Emelyanov [EMAIL PROTECTED]
---
diff --git a/fs/seq_file.c b/fs/seq_file.c
index
This concerns the ipv4 and ipv6 code mostly, but also the netlink
and unix sockets.
The netlink code is an example of how to use the __seq_open_private()
call - it saves the net namespace on this private.
Signed-off-by: Pavel Emelyanov [EMAIL PROTECTED]
---
diff --git a/net/ipv4/arp.c
Just switch to the consolidated calls.
ipt_recent() has to initialize the private, so use
the __seq_open_private() helper.
Signed-off-by: Pavel Emelyanov [EMAIL PROTECTED]
Cc: Patrick McHardy [EMAIL PROTECTED]
---
diff --git a/net/ipv4/netfilter/ipt_recent.c b/net/ipv4/netfilter/ipt_recent.c
jamal wrote:
On Mon, 2007-08-10 at 15:40 -0700, Kok, Auke wrote:
My biggest problem with the patch as you sent it that it's a tonload of
changes
and no implicit benefit immediately as I can see.
The patch looks scary but is pretty tame when you apply it and stare at
it.
I would
Just switch to the consolidated code.
Signed-off-by: Pavel Emelyanov [EMAIL PROTECTED]
Cc: Patrick Caulfield [EMAIL PROTECTED]
---
diff --git a/net/decnet/dn_neigh.c b/net/decnet/dn_neigh.c
index b66e3be..e851b14 100644
--- a/net/decnet/dn_neigh.c
+++ b/net/decnet/dn_neigh.c
@@ -580,24 +580,8
Just switch to the consolidated code
Signed-off-by: Pavel Emelyanov [EMAIL PROTECTED]
Cc: Samuel Ortiz [EMAIL PROTECTED]
---
diff --git a/net/irda/irlap.c b/net/irda/irlap.c
index 3d76aaf..f3236ac 100644
--- a/net/irda/irlap.c
+++ b/net/irda/irlap.c
@@ -1219,29 +1219,11 @@ static const struct
Just switch to the consolidated code.
Signed-off-by: Pavel Emelyanov [EMAIL PROTECTED]
Cc: Neil Brown [EMAIL PROTECTED]
---
diff --git a/net/sunrpc/cache.c b/net/sunrpc/cache.c
index ebe344f..8e05557 100644
--- a/net/sunrpc/cache.c
+++ b/net/sunrpc/cache.c
@@ -1218,23 +1218,15 @@ static const
On Mon, 2007-10-08 at 21:29 -0700, David Miller wrote:
From: Eliezer Tamir [EMAIL PROTECTED]
Date: Tue, 09 Oct 2007 06:13:23 +0200
Due to the size of the patch I can not post it to the list.
Understood
Here is an FTP link.
ftp://[EMAIL
Sorry if this is a dumb question, but what is the model you intend for
SNMP? Do you want each namespace to be its own virtual machine with
its own, separate MIB?
Ifindex's have to uniquely identify the interface (virtual or otherwise)
to remote
queriers (not just local applications), so unless
Pavel Emelyanov [EMAIL PROTECTED] writes:
Currently indexes for netdevices come sequentially one by
one, and the same stays true even for devices that are
created for namespaces.
Side effects of this are:
* lo device has not 1 index in a namespace. This may break
some userspace that
David Stevens [EMAIL PROTECTED] writes:
Sorry if this is a dumb question, but what is the model you intend for
SNMP? Do you want each namespace to be its own virtual machine with
its own, separate MIB?
Each network namespace appears to user space as a completely separate
network stack. So
On 09 Oct 2007 18:51:51 +0200
Andi Kleen [EMAIL PROTECTED] wrote:
David Miller [EMAIL PROTECTED] writes:
2) Switch the default qdisc away from pfifo_fast to a new DRR fifo
with load balancing using the code in #1. I think this is kind
of in the territory of what Peter said he is
I wonder about the whole idea of queueing in general at such high speeds.
Given the normal bi-modal distribution of packets, and the predominance
of 1500 byte MTU; does it make sense to even have any queueing in software
at all?
Yes that is my point -- it should just pass it through directly
Keep tx and rx elements separate on different cachelines to prevent
bouncing.
Signed-off-by: Jeremy Fitzhardinge [EMAIL PROTECTED]
Cc: Stephen Hemminger [EMAIL PROTECTED]
Cc: Christoph Hellwig [EMAIL PROTECTED]
---
drivers/net/xen-netfront.c | 37 ++---
1 file
IMO the net driver really should provide a hint as to what it wants.
8139cp and tg3 would probably prefer multiple TX queue
behavior to match silicon behavior -- strict prio.
If I understand what you just said, I disagree. If your hardware is
running strict prio, you don't want to enforce
Waskiewicz Jr, Peter P wrote:
IMO the net driver really should provide a hint as to what it wants.
8139cp and tg3 would probably prefer multiple TX queue
behavior to match silicon behavior -- strict prio.
If I understand what you just said, I disagree. If your hardware is
running strict
Hi,
On Mon, Oct 08, 2007 at 05:58:36PM +0200, Karsten Keil wrote:
You could try following patch with 2.6.23-rc8-mm2, it change I4L to use
alloc_netdev().
I just did the horribly unthinkable:
I rebooted the production internet gateway *remotely*, and:
[EMAIL PROTECTED]:/home/andi# uname -a
A misunderstanding, I think.
To my brain, DaveM's item #2 seemed to assume/require the NIC
hardware to balance fairly across hw TX rings, which seemed
to preclude the
8139cp/tg3 style of strict-prio hardware. That's what I was
responding to.
As long as there is some modular way to
From: Pavel Emelyanov [EMAIL PROTECTED]
Date: Tue, 09 Oct 2007 15:48:19 +0400
The newly created net namespace is set to 0 with memset()
in setup_net(). The setup_net() is also called for the
init_net_ns(), which is zeroed naturally as a global var.
So remove this memset and allocate new
From: [EMAIL PROTECTED] (Eric W. Biederman)
Date: Tue, 09 Oct 2007 11:43:58 -0600
David Stevens [EMAIL PROTECTED] writes:
Sorry if this is a dumb question, but what is the model you intend for
SNMP? Do you want each namespace to be its own virtual machine with
its own, separate MIB?
From: David Stevens [EMAIL PROTECTED]
Date: Tue, 9 Oct 2007 09:18:25 -0700
Ifindex's have to uniquely identify the interface (virtual or
otherwise) to remote queriers (not just local applications), so
unless you pay the price of separating all the SNMP MIBs per
namespace too, it seems you'll
From: Pavel Emelyanov [EMAIL PROTECTED]
Date: Tue, 09 Oct 2007 16:19:25 +0400
Currently indexes for netdevices come sequentially one by
one, and the same stays true even for devices that are
created for namespaces.
Side effects of this are:
* lo device has not 1 index in a namespace.
From: Jeff Garzik [EMAIL PROTECTED]
Date: Tue, 09 Oct 2007 08:44:25 -0400
David Miller wrote:
From: Krishna Kumar2 [EMAIL PROTECTED]
Date: Tue, 9 Oct 2007 16:51:14 +0530
David Miller [EMAIL PROTECTED] wrote on 10/09/2007 04:32:55 PM:
Ignore LLTX, it sucks, it was a big mistake, and
David Miller wrote:
From: Jeff Garzik [EMAIL PROTECTED]
Date: Tue, 09 Oct 2007 08:44:25 -0400
David Miller wrote:
From: Krishna Kumar2 [EMAIL PROTECTED]
Date: Tue, 9 Oct 2007 16:51:14 +0530
David Miller [EMAIL PROTECTED] wrote on 10/09/2007 04:32:55 PM:
Ignore LLTX, it sucks, it was a big
I'd say we can probably try to get rid of it in 2.6.25, this is
assuming we get driver authors to cooperate and do the conversions
or alternatively some other motivated person.
I can just threaten to do them all and that should get the driver
maintainers going :-)
I can definitely
From: Herbert Xu [EMAIL PROTECTED]
Date: Tue, 09 Oct 2007 22:36:31 +0800
[IPSEC]: Remove bogus ref count in xfrm_secpath_reject
Constructs of the form
xfrm_state_hold(x);
foo(x);
xfrm_state_put(x);
tend to be broken because foo is either synchronous where this is
From: Herbert Xu [EMAIL PROTECTED]
Date: Tue, 09 Oct 2007 22:36:32 +0800
[IPSEC]: Store IPv6 nh pointer in mac_header on output
Current the x-mode-output functions store the IPv6 nh pointer in the
skb network header. This is inconvenient because the network header then
has to be fixed up
From: Herbert Xu [EMAIL PROTECTED]
Date: Tue, 09 Oct 2007 22:36:33 +0800
[IPSEC]: Remove gratuitous km wake-up events on ACQUIRE
There is no point in waking people up when creating/updating larval states
because they'll just go back to sleep again as larval states by definition
cannot be
From: Herbert Xu [EMAIL PROTECTED]
Date: Tue, 09 Oct 2007 22:36:34 +0800
[IPSEC]: Move common code into xfrm_alloc_spi
This patch moves some common code that conceptually belongs to the xfrm core
from af_key/xfrm_user into xfrm_alloc_spi.
In particular, the spin lock on the state is now
From: Herbert Xu [EMAIL PROTECTED]
Date: Tue, 09 Oct 2007 22:36:35 +0800
[XFRM] user: Move attribute copying code into copy_to_user_state_extra
Here's a good example of code duplication leading to code rot. The
notification patch did its own netlink message creation for xfrm states.
It
From: Herbert Xu [EMAIL PROTECTED]
Date: Tue, 09 Oct 2007 22:36:36 +0800
[IPSEC]: Lock state when copying non-atomic fields to user-space
This patch adds locking so that when we're copying non-atomic fields such as
life-time or coaddr to user-space we don't get a partial result.
For
From: Herbert Xu [EMAIL PROTECTED]
Date: Tue, 09 Oct 2007 22:36:37 +0800
[IPSEC]: Move state lock into x-type-output
This patch releases the lock on the state before calling x-type-output.
It also adds the lock to the spots where they're currently needed.
Most of those places (all except
From: Andi Kleen [EMAIL PROTECTED]
Date: 09 Oct 2007 18:51:51 +0200
Hopefully that new qdisc will just use the TX rings of the hardware
directly. They are typically large enough these days. That might avoid
some locking in this critical path.
Indeed, I also realized last night that for the
From: Roland Dreier [EMAIL PROTECTED]
Date: Tue, 09 Oct 2007 13:22:44 -0700
I can definitely kill LLTX for IPoIB by 2.6.25 and I just added it to
my TODO list so I don't forget.
In fact if 2.6.23 drags on long enough I may do it for 2.6.24
Before you add new entries to your list, how is
On Tue, 09 Oct 2007 13:43:31 -0700 (PDT)
David Miller [EMAIL PROTECTED] wrote:
From: Andi Kleen [EMAIL PROTECTED]
Date: 09 Oct 2007 18:51:51 +0200
Hopefully that new qdisc will just use the TX rings of the hardware
directly. They are typically large enough these days. That might avoid
David Miller [EMAIL PROTECTED] writes:
From: [EMAIL PROTECTED] (Eric W. Biederman)
Date: Tue, 09 Oct 2007 11:43:58 -0600
David Stevens [EMAIL PROTECTED] writes:
Sorry if this is a dumb question, but what is the model you intend for
SNMP? Do you want each namespace to be its own virtual
Hallo Dave,
9.1MB, 739 changesets, keep those patches flowing!
Last week I have sent another version of our patch series for PF_CAN.
The changes after the last review feedback were only cosmetics.
Do you have any plans with that code for this or the next release?
Regards,
urs
-
To unsubscribe
From: [EMAIL PROTECTED] (Eric W. Biederman)
Date: Tue, 09 Oct 2007 15:00:10 -0600
Regardless it is early yet and there is plenty of time to revisit this
after we solved the easier and less controversial problems.
Ok.
I would encourage you to learn how the SNMP mibs work, and whether
they
From: Urs Thuermann [EMAIL PROTECTED]
Date: 09 Oct 2007 23:13:42 +0200
Last week I have sent another version of our patch series for PF_CAN.
The changes after the last review feedback were only cosmetics.
Do you have any plans with that code for this or the next release?
I think PF_CAN will
From: Stephen Hemminger [EMAIL PROTECTED]
Date: Tue, 9 Oct 2007 13:53:40 -0700
I was thinking why not have a default transmit queue len of 0 like
the virtual devices.
I'm not so sure.
Even if the device has huge queues I still think we need a software
queue for when the hardware one backs up.
From: Jeff Garzik [EMAIL PROTECTED]
Date: Tue, 09 Oct 2007 16:20:14 -0400
David Miller wrote:
If you unconditionally take those locks in the transmit function,
there is probably an ABBA deadlock elsewhere in the driver now, most
likely in the TX reclaim processing, and you therefore need
Before you add new entries to your list, how is that ibm driver NAPI
conversion coming along? :-)
I still haven't done much. OK, I will try to get my board booting
again this week.
-
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL PROTECTED]
On Tue, 2007-09-10 at 14:22 -0700, David Miller wrote:
Even if the device has huge queues I still think we need a software
queue for when the hardware one backs up.
It should be fine to just pretend the qdisc exists despite it sitting
in the driver and not have s/ware queues at all to avoid
Please provide feedback on the code and/or architecture.
They are now updated to work with the latest rebased net-2.6.24
from a few hours ago.
I am on travel mode so wont have time to do more testing for the next
few days - i do consider this to be stable at this point based on
what i have been
This patch introduces the netdevice interface for batching.
cheers,
jamal
[NET_BATCH] Introduce batching interface
This patch introduces the netdevice interface for batching.
BACKGROUND
-
A driver dev-hard_start_xmit() has 4 typical parts:
a) packet formating (example vlan, mss,
This patch adds the usage of batching within the core.
cheers,
jamal
[NET_BATCH] net core use batching
This patch adds the usage of batching within the core.
Performance results demonstrating improvement are provided separately.
I have #if-0ed some of the old functions so the patch is more
1 - 100 of 152 matches
Mail list logo
