Re: [PATCH] vortex_up should initialize err

2007-10-18 Thread Steffen Klassert
On Wed, Oct 17, 2007 at 08:28:36PM -0400, Jeff Garzik wrote: Badari Pulavarty wrote: Simple compile warning fix. (against 2.6.23-git12) Thanks, Badari vortex_up() should initialize 'err' for a successful return. drivers/net/3c59x.c: In function `vortex_up': drivers/net/3c59x.c:1494:

Re: [RFC] remove netpoll receive code

2007-10-18 Thread David Miller
From: Stephen Hemminger [EMAIL PROTECTED] Date: Wed, 17 Oct 2007 13:21:31 -0700 I propose that we take out all the whole netpoll rx path. If/when kgdb gets submitted a better and alternative receive path can be added. I would like to kill the RX side handling of netpoll too, but I don't think

Re: [PATCH/RFA] sch_generic: fix carrier-on bug?

2007-10-18 Thread David Miller
From: Jeff Garzik [EMAIL PROTECTED] Date: Tue, 16 Oct 2007 17:55:55 -0400 While looking at a net driver with the following construct, if (!netif_carrier_ok(dev)) netif_carrier_on(dev); it stuck me that the netif_carrier_ok() check was redundant, since

Re: [PATCH] PHYLIB: IRQ event workqueue handling fixes

2007-10-18 Thread Jarek Poplawski
On Wed, Oct 17, 2007 at 10:58:09AM +0200, Jarek Poplawski wrote: ... 8) phy_stop_interrupts(): I'm not sure this additional call from DEBUG_SHIRQ should be so dangerous, eg.: /* * status == PHY_HALTED * interrupts are stopped after phy_stop() */ if

Re: [RFC] remove netpoll receive code

2007-10-18 Thread Andrew Morton
On Wed, 17 Oct 2007 23:28:38 -0700 (PDT) David Miller [EMAIL PROTECTED] wrote: From: Stephen Hemminger [EMAIL PROTECTED] Date: Wed, 17 Oct 2007 13:21:31 -0700 I propose that we take out all the whole netpoll rx path. If/when kgdb gets submitted a better and alternative receive path can be

[PATCH] flush_work_sync vs. flush_scheduled_work Re: [PATCH] PHYLIB: IRQ event workqueue handling fixes

2007-10-18 Thread Jarek Poplawski
After reading this and earlier threads about phylib's way of using workqueue I think such a lighter and safer wrt. locking alternative for flush_scheduled_work should be useful, but maybe it's only my imagination. So, let's ask Oleg Nesterov, whose solutions are here only copy-cut-pasted

Re: [PATCH] vortex_up should initialize err

2007-10-18 Thread Andrew Morton
On Thu, 18 Oct 2007 08:05:06 +0200 Steffen Klassert [EMAIL PROTECTED] wrote: On Wed, Oct 17, 2007 at 08:28:36PM -0400, Jeff Garzik wrote: Badari Pulavarty wrote: Simple compile warning fix. (against 2.6.23-git12) Thanks, Badari vortex_up() should initialize 'err' for a successful

Re: [PATCH 12/12] Drop bogus reference to tc-filters and add lartc.org link to manpage.

2007-10-18 Thread Andreas Henriksson
On Wed, Oct 17, 2007 at 11:02:57AM -0700, Stephen Hemminger wrote: The tagging naming convention is messed up, but they are there: $ git tag -l I don't want to be a pain in the ass, but this is the list from my clone of

s390x: getting ipv6 bugs on mainline since 2.6.23-git3

2007-10-18 Thread Andy Whitcroft
Seems we are getting some kind of bug out of our s390x partition (lnxabat1) when booting latest mainline releases, specifically since 2.6.23-git3. Kernel BUG at 0002 Ýverbose debug info unavailable¨ illegal operation: 0001 Ý#1¨ Modules linked in: dm_mod sit tunnel4 ipv6 qeth ccwgroup

[PATCH] [TCP]: Add highest_sack_end_seq check back to lost_retrans call

2007-10-18 Thread Ilpo Järvinen
On Thu, 18 Oct 2007, TAKANO Ryousei wrote: From: David Miller [EMAIL PROTECTED] Subject: Re: [PATCH 7/7] [TCP]: Limit processing lost_retrans loop to work-to-do cases Date: Thu, 11 Oct 2007 17:36:22 -0700 (PDT) From: Ilpo_Järvinen [EMAIL PROTECTED] Date: Thu, 11 Oct 2007 14:41:07 +0300

Re: [PATCH][NET] gianfar: fix obviously wrong #ifdef CONFIG_GFAR_NAPI placement

2007-10-18 Thread Andy Whitcroft
The check then is to see if a non {}'d block has no statements in it if the ifdef is null. Hmmm. May be possible. Will think on it. if (err) +#ifdef CONFIG_GFAR_NAPI napi_disable(priv-napi); +#endif -apw - To unsubscribe from this list: send the line unsubscribe netdev

Re: bizarre network timing problem

2007-10-18 Thread Felix von Leitner
the packet trace was a bit too cooked perhaps, but there were indications that at times the TCP window was going to zero - perhaps something with window updates or persist timers? Does TCP use different window sizes on loopback? Why is this not happening on ethernet? How could I test this

[PATCH 0/3] netdev: ARRAY_SIZE() cleanups

2007-10-18 Thread Alejandro Martinez Ruiz
Hi, these patches convert more cases of array size calculations to use the ARRAY_SIZE() macro. First patch converts those of the form 'sizeof(arr) / ETH_GSTRING_LEN', second one some other mostly obvious cases, and the third applies to the almost dead sk98lin driver (which also removes a useless

Re: s390x: getting ipv6 bugs on mainline since 2.6.23-git3

2007-10-18 Thread Patrick McHardy
Andy Whitcroft wrote: Seems we are getting some kind of bug out of our s390x partition (lnxabat1) when booting latest mainline releases, specifically since 2.6.23-git3. Kernel BUG at 0002 Ýverbose debug info unavailable? illegal operation: 0001 Ý#1? Modules linked in: dm_mod sit

[PATCH 1/3] netdev: use ARRAY_SIZE() instead of sizeof(array) / ETH_GSTRING_LEN

2007-10-18 Thread Alejandro Martinez Ruiz
From: Alejandro Martinez Ruiz [EMAIL PROTECTED] Date: Thu, 18 Oct 2007 10:00:15 +0200 Subject: [PATCH] netdev: use ARRAY_SIZE() instead of sizeof(array) / ETH_GSTRING_LEN Using ARRAY_SIZE() on arrays of the form array[][K] makes it unnecessary to know the value of K when checking its size.

[PATCH 2/3] netdev: ARRAY_SIZE() cleanups

2007-10-18 Thread Alejandro Martinez Ruiz
From: Alejandro Martinez Ruiz [EMAIL PROTECTED] Date: Thu, 18 Oct 2007 10:16:33 +0200 Subject: [PATCH] netdev: ARRAY_SIZE() cleanups Convert array size calculations to use ARRAY_SIZE(). Signed-off-by: Alejandro Martinez Ruiz [EMAIL PROTECTED] --- drivers/net/e1000e/ethtool.c |3 +--

[PATCH 3/3] sk98lin: kill bogus check and convert to use ARRAY_SIZE()

2007-10-18 Thread Alejandro Martinez Ruiz
From: Alejandro Martinez Ruiz [EMAIL PROTECTED] Date: Thu, 18 Oct 2007 10:22:02 +0200 Subject: [PATCH] sk98lin: kill bogus check and convert to use ARRAY_SIZE() This converts uses of ARRAY_SIZE(), and while at it also kills unreachable code as far as I can say. I can't tell what was the author

Re: [Bugme-new] [Bug 9174] New: linux-2.6.23-git11 kernel panic

2007-10-18 Thread Patrick McHardy
Andrew Morton wrote: On Wed, 17 Oct 2007 07:36:16 -0700 (PDT) [EMAIL PROTECTED] wrote: http://bugzilla.kernel.org/show_bug.cgi?id=9174 Summary: linux-2.6.23-git11 kernel panic EIP is at packet_rcv_0x1a2/0x360 Please find out on which device the packet socket is opened by

[PATCH 1/2] Interface group: core (netlink) part

2007-10-18 Thread Laszlo Attila Toth
Interface groups let handle different interfaces together especially in netfilter modules. Modified net device structure and netlink interface. Signed-off-by: Laszlo Attila Toth [EMAIL PROTECTED] --- include/linux/if_link.h |2 ++ include/linux/netdevice.h |2 ++ net/core/rtnetlink.c

[IPROUTE PATCH] Interface group as new ip link option

2007-10-18 Thread Laszlo Attila Toth
Interfaces can be grouped and each group has an unique positive integer ID. It can be set via ip link. Symbolic names can be specified in /etc/iproute2/rt_ifgroup. Signed-off-by: Laszlo Attila Toth [EMAIL PROTECTED] --- include/linux/if_link.h |2 + include/rt_names.h |2 +

[IPTABLES PATCH] Interface group match

2007-10-18 Thread Laszlo Attila Toth
Matching ifgroup value of incoming and/or outgoing interface. Signed-off-by: Laszlo Attila Toth [EMAIL PROTECTED] --- extensions/Makefile |2 +- extensions/libip6t_ifgroup.man | 36 +++ extensions/libipt_ifgroup.man| 36 +++

[PATCH 0/2] Interface groups, round two

2007-10-18 Thread Laszlo Attila Toth
Hello, Here is the new version of ifgroup patches. The interface group value is u_int32_t in net_device which should be enough. Previously it was an int. Usage: ip link set eth0 group 4 but currently it cannot be unset, only changed to another value. In /etc/iproute2/rt_ifgroup each value

[PATCH 2/2] Interface group match

2007-10-18 Thread Laszlo Attila Toth
Interface group values can be checked on both input and output interfaces. Signed-off-by: Laszlo Attila Toth [EMAIL PROTECTED] --- include/linux/netfilter/xt_ifgroup.h | 18 ++ net/netfilter/Kconfig| 16 + net/netfilter/Makefile |1 +

[PATCH] [TCP]: Remove lost_retrans zero special cases

2007-10-18 Thread Ilpo Järvinen
On Thu, 18 Oct 2007, Ilpo Järvinen wrote: On Thu, 18 Oct 2007, TAKANO Ryousei wrote: From: David Miller [EMAIL PROTECTED] Subject: Re: [PATCH 7/7] [TCP]: Limit processing lost_retrans loop to work-to-do cases Date: Thu, 11 Oct 2007 17:36:22 -0700 (PDT) From: Ilpo_Järvinen [EMAIL

Re: [PATCH 0/2] Interface groups, round two

2007-10-18 Thread Patrick McHardy
Laszlo Attila Toth wrote: Hello, Here is the new version of ifgroup patches. The interface group value is u_int32_t in net_device which should be enough. Previously it was an int. Usage: ip link set eth0 group 4 but currently it cannot be unset, only changed to another value. The only

Re: [PATCH 1/2] Interface group: core (netlink) part

2007-10-18 Thread Patrick McHardy
Laszlo Attila Toth wrote: @@ -846,6 +850,12 @@ static int do_setlink(struct net_device *dev, struct ifinfomsg *ifm, write_unlock_bh(dev_base_lock); } + if (tb[IFLA_IFGROUP]) { + write_lock_bh(dev_base_lock); + dev-ifgroup =

Re: [PATCH 2/2] Interface group match

2007-10-18 Thread Patrick McHardy
Laszlo Attila Toth wrote: Interface group values can be checked on both input and output interfaces. Signed-off-by: Laszlo Attila Toth [EMAIL PROTECTED] --- include/linux/netfilter/xt_ifgroup.h | 18 ++ net/netfilter/Kconfig| 16 + net/netfilter/Makefile

Re: TCP port randomization

2007-10-18 Thread Krzysztof Oledzki
On Wed, 17 Oct 2007, Stephen Hemminger wrote: On Thu, 18 Oct 2007 00:31:13 +0200 (CEST) Krzysztof Oledzki [EMAIL PROTECTED] wrote: On Wed, 17 Oct 2007, Stephen Hemminger wrote: On Wed, 17 Oct 2007 23:15:48 +0200 (CEST) Krzysztof Oledzki [EMAIL PROTECTED] wrote: Hello, Is it normal

Re: s390x: getting ipv6 bugs on mainline since 2.6.23-git3

2007-10-18 Thread Martin Schwidefsky
On Thu, 2007-10-18 at 11:43 +0200, Patrick McHardy wrote: Andy Whitcroft wrote: Seems we are getting some kind of bug out of our s390x partition (lnxabat1) when booting latest mainline releases, specifically since 2.6.23-git3. Kernel BUG at 0002 Ýverbose debug info

ip_frag_reasm() can return uninitialized variable

2007-10-18 Thread Adrian Bunk
Since commit 1706d58763c36133d7fce6cc78b1444fd40db28c ip_frag_reasm() can return the value of an uninitialized variable: -- snip -- ... static int ip_frag_reasm(struct ipq *qp, struct sk_buff *prev, struct net_device *dev) { struct iphdr *iph; struct

Re: [PATCH] [TCP]: Remove lost_retrans zero special cases

2007-10-18 Thread TAKANO Ryousei
From: Ilpo Järvinen [EMAIL PROTECTED] Subject: [PATCH] [TCP]: Remove lost_retrans zero special cases Date: Thu, 18 Oct 2007 13:17:24 +0300 (EEST) [PATCH] [TCP]: Remove lost_retrans zero seqno special cases Both high-sack detection and new lowest seq variables have unnecessary zero special

Re: [Bugme-new] [Bug 9174] New: linux-2.6.23-git11 kernel panic

2007-10-18 Thread Patrick McHardy
Patrick McHardy wrote: Andrew Morton wrote: On Wed, 17 Oct 2007 07:36:16 -0700 (PDT) [EMAIL PROTECTED] wrote: http://bugzilla.kernel.org/show_bug.cgi?id=9174 Summary: linux-2.6.23-git11 kernel panic EIP is at packet_rcv_0x1a2/0x360 Please find out on which device the

Re: [PATCH] [TCP]: Remove lost_retrans zero special cases

2007-10-18 Thread Ilpo Järvinen
On Thu, 18 Oct 2007, TAKANO Ryousei wrote: From: Ilpo Järvinen [EMAIL PROTECTED] Subject: [PATCH] [TCP]: Remove lost_retrans zero special cases Date: Thu, 18 Oct 2007 13:17:24 +0300 (EEST) [PATCH] [TCP]: Remove lost_retrans zero seqno special cases Both high-sack detection and new

Re: BUG: unable to handle kernel NULL pointer dereference at virtual address 000000b0

2007-10-18 Thread Krzysztof Oledzki
On Wed, 17 Oct 2007, Eric Dumazet wrote: Krzysztof Oledzki a écrit : On Wed, 17 Oct 2007, Eric Dumazet wrote: Krzysztof Oledzki a écrit : On Wed, 17 Oct 2007, Eric Dumazet wrote: Krzysztof Oledzki a écrit : Hello, Today I found in my logs: BUG: unable to handle kernel NULL

Re: [PATCH 0/2] Interface groups, round two

2007-10-18 Thread Laszlo Attila Toth
Patrick McHardy írta: Laszlo Attila Toth wrote: Hello, Here is the new version of ifgroup patches. The interface group value is u_int32_t in net_device which should be enough. Previously it was an int. Usage: ip link set eth0 group 4 but currently it cannot be unset, only changed to

Re: [PATCH] PHYLIB: IRQ event workqueue handling fixes

2007-10-18 Thread Maciej W. Rozycki
On Thu, 18 Oct 2007, Jarek Poplawski wrote: After rethinking, it looks like this last cancel should be useless. So, if phy_interrupt() schedules only if !PHY_HALTED and phy_change() does enable_irq() with no exeptions, it seems phy_interrupt() even without lock must see PHY_HALTED state

Re: [PATCH 0/2] Interface groups, round two

2007-10-18 Thread Patrick McHardy
Laszlo Attila Toth wrote: Patrick McHardy írta: Laszlo Attila Toth wrote: The only reason why it can't be set to zero again seems to be this part from the iproute patch: +if (rtnl_ifgroup_a2n(group, *argv) || group == 0) Why don't you allow a value of zero? It has historical

Re: BUG: unable to handle kernel NULL pointer dereference at virtual address 000000b0

2007-10-18 Thread Patrick McHardy
Krzysztof Oledzki wrote: Hum, you are using IPT_TPROXY thing, which is not in linux-2.6.22.9 It is only compiled in, not used at the moment. But at least the previous version (before those patches posted a week ago) touches the routing code in exactly that function. - To unsubscribe from

Re: ip_frag_reasm() can return uninitialized variable

2007-10-18 Thread David Miller
From: Adrian Bunk [EMAIL PROTECTED] Date: Thu, 18 Oct 2007 12:52:03 +0200 Since commit 1706d58763c36133d7fce6cc78b1444fd40db28c ip_frag_reasm() can return the value of an uninitialized variable: I have a fix for this in my net-2.6 tree, thanks Adrian. - To unsubscribe from this list: send the

Re: [PATCH] PHYLIB: IRQ event workqueue handling fixes

2007-10-18 Thread Maciej W. Rozycki
On Wed, 17 Oct 2007, Jarek Poplawski wrote: I'm not sure free_irq() should maintain the depth count - rather warn on not zero. But, IMHO, any activity on freed irq seems suspicious to me (and doesn't look like very common), even if it's safe with current implementation. No way to avoid it

[PATCH 2/3] Lost locking in fl6_sock_lookup

2007-10-18 Thread Pavel Emelyanov
This routine scans the ipv6_fl_list whose update is protected with the socket lock and the ip6_sk_fl_lock. Since the socket lock is not taken in the lookup, use the other one. Signed-off-by: Pavel Emelyanov [EMAIL PROTECTED] --- diff --git a/net/ipv6/ip6_flowlabel.c b/net/ipv6/ip6_flowlabel.c

[PATCH 3/3] Fix race in ipv6_flowlabel_opt() when inserting two labels

2007-10-18 Thread Pavel Emelyanov
In the IPV6_FL_A_GET case the hash is checked for flowlabels with the given label. If it is not found, the lock, protecting the hash, is dropped to be re-get for writing. After this a newly allocated entry is inserted, but no checks are performed to catch a classical SMP race, when the

Re: [PATCH 2/3] Lost locking in fl6_sock_lookup

2007-10-18 Thread YOSHIFUJI Hideaki / 吉藤英明
In article [EMAIL PROTECTED] (at Thu, 18 Oct 2007 15:53:52 +0400), Pavel Emelyanov [EMAIL PROTECTED] says: This routine scans the ipv6_fl_list whose update is protected with the socket lock and the ip6_sk_fl_lock. struct ip6_flowlabel *fl = sfl-fl; if (fl-label

Re: [PATCH] [TCP]: Remove lost_retrans zero special cases

2007-10-18 Thread David Miller
From: Ilpo_Järvinen [EMAIL PROTECTED] Date: Thu, 18 Oct 2007 14:07:42 +0300 (EEST) Dave, please put this one to net-2.6 and forget the other patch with title [TCP]: Add highest_sack_end_seq check back..., it would just add another (wrong) zero special case back (they won't conflict with each

Re: [Bugme-new] [Bug 9174] New: linux-2.6.23-git11 kernel panic

2007-10-18 Thread David Miller
From: Patrick McHardy [EMAIL PROTECTED] Date: Thu, 18 Oct 2007 12:58:42 +0200 Patrick McHardy wrote: Andrew Morton wrote: On Wed, 17 Oct 2007 07:36:16 -0700 (PDT) [EMAIL PROTECTED] wrote: http://bugzilla.kernel.org/show_bug.cgi?id=9174 Summary: linux-2.6.23-git11 kernel

Re: [PATCH 2/3] Lost locking in fl6_sock_lookup

2007-10-18 Thread Pavel Emelyanov
YOSHIFUJI Hideaki wrote: In article [EMAIL PROTECTED] (at Thu, 18 Oct 2007 15:53:52 +0400), Pavel Emelyanov [EMAIL PROTECTED] says: This routine scans the ipv6_fl_list whose update is protected with the socket lock and the ip6_sk_fl_lock. struct ip6_flowlabel *fl = sfl-fl;

Re: [PATCH 2/3] Lost locking in fl6_sock_lookup

2007-10-18 Thread David Miller
From: Pavel Emelyanov [EMAIL PROTECTED] Date: Thu, 18 Oct 2007 16:11:58 +0400 YOSHIFUJI Hideaki wrote: In article [EMAIL PROTECTED] (at Thu, 18 Oct 2007 15:53:52 +0400), Pavel Emelyanov [EMAIL PROTECTED] says: This routine scans the ipv6_fl_list whose update is protected with the

Re: [PATCH 1/3] Lost locking when inserting a flowlabel in ipv6_fl_list

2007-10-18 Thread David Miller
From: Pavel Emelyanov [EMAIL PROTECTED] Date: Thu, 18 Oct 2007 15:51:41 +0400 The new flowlabels should be inserted into the sock list under the ip6_sk_fl_lock. This was lost in one place. This list is naturally protected with the socket lock, but the fl6_sock_lookup() is called without it,

Re: [PATCH 2/3] Lost locking in fl6_sock_lookup

2007-10-18 Thread David Miller
From: Pavel Emelyanov [EMAIL PROTECTED] Date: Thu, 18 Oct 2007 15:53:52 +0400 This routine scans the ipv6_fl_list whose update is protected with the socket lock and the ip6_sk_fl_lock. Since the socket lock is not taken in the lookup, use the other one. Signed-off-by: Pavel Emelyanov

Re: [PATCH 3/3] Fix race in ipv6_flowlabel_opt() when inserting two labels

2007-10-18 Thread David Miller
From: Pavel Emelyanov [EMAIL PROTECTED] Date: Thu, 18 Oct 2007 15:59:14 +0400 In the IPV6_FL_A_GET case the hash is checked for flowlabels with the given label. If it is not found, the lock, protecting the hash, is dropped to be re-get for writing. After this a newly allocated entry is

[PATCH 1/3] Lost locking when inserting a flowlabel in ipv6_fl_list

2007-10-18 Thread Pavel Emelyanov
The new flowlabels should be inserted into the sock list under the ip6_sk_fl_lock. This was lost in one place. This list is naturally protected with the socket lock, but the fl6_sock_lookup() is called without it, so another protection is required. Signed-off-by: Pavel Emelyanov [EMAIL

Re: [PATCH 2/3] Lost locking in fl6_sock_lookup

2007-10-18 Thread Pavel Emelyanov
David Miller wrote: From: Pavel Emelyanov [EMAIL PROTECTED] Date: Thu, 18 Oct 2007 15:53:52 +0400 This routine scans the ipv6_fl_list whose update is protected with the socket lock and the ip6_sk_fl_lock. Since the socket lock is not taken in the lookup, use the other one.

Re: [PATCH 2/3] Lost locking in fl6_sock_lookup

2007-10-18 Thread David Miller
From: Pavel Emelyanov [EMAIL PROTECTED] Date: Thu, 18 Oct 2007 16:22:49 +0400 Oops. You're right here :( I looked at the ip6_fl_lock and messed it with the ip6_sk_fl_lock. Should I resend the whole patch, or just make an incremental one? Please make an incremental one. And hurry, I'm

[PATCH] Fix again the fl6_sock_lookup() fixed locking

2007-10-18 Thread Pavel Emelyanov
YOSHIFUJI fairly pointed out, that the users increment should be done under the ip6_sk_fl_lock not to give IPV6_FL_A_PUT a chance to put this count to zero and release the flowlabel. Signed-off-by: Pavel Emelyanov [EMAIL PROTECTED] Cc: YOSHIFUJI Hideaki [EMAIL PROTECTED] --- diff --git

Re: [PATCH] Fix again the fl6_sock_lookup() fixed locking

2007-10-18 Thread David Miller
From: Pavel Emelyanov [EMAIL PROTECTED] Date: Thu, 18 Oct 2007 16:36:58 +0400 YOSHIFUJI fairly pointed out, that the users increment should be done under the ip6_sk_fl_lock not to give IPV6_FL_A_PUT a chance to put this count to zero and release the flowlabel. Signed-off-by: Pavel Emelyanov

about multiple network interface

2007-10-18 Thread wit
Hi all, Sorry, I don't know if this is the right mail list. I got the following question: I have a e100 card and a e1000 card. Whenever I boot the system, I found the eth0 matches the e1000 card, and the eth2 matches the other. How can I force the eth0 to match the e100 card and the eth2 to

Re: BUG: unable to handle kernel NULL pointer dereference at virtual address 000000b0

2007-10-18 Thread Krzysztof Oledzki
On Thu, 18 Oct 2007, Patrick McHardy wrote: Krzysztof Oledzki wrote: Hum, you are using IPT_TPROXY thing, which is not in linux-2.6.22.9 It is only compiled in, not used at the moment. But at least the previous version (before those patches posted a week ago) touches the routing code in

Re: about multiple network interface

2007-10-18 Thread Evgeniy Polyakov
On Thu, Oct 18, 2007 at 09:06:40PM +0800, wit ([EMAIL PROTECTED]) wrote: Hi all, Sorry, I don't know if this is the right mail list. I got the following question: I have a e100 card and a e1000 card. Whenever I boot the system, I found the eth0 matches the e1000 card, and the eth2

Re: [PATCH v3 0/4] FEC - fast ethernet controller for mpc52xx

2007-10-18 Thread Grant Likely
On 10/15/07, Jeff Garzik [EMAIL PROTECTED] wrote: Domen Puncer wrote: Hello! If there are no objections, I would like to get this merged when bestcomm goes in (any time now?). It's split into four parts: 1 - device tree 2 - small bestcomm change 3 - the actual driver 4 - phy

RE: [PATCH] Fix ethernet multicast for ucc_geth.

2007-10-18 Thread Li Yang-r58472
-Original Message- From: Joakim Tjernlund [mailto:[EMAIL PROTECTED] Sent: Wednesday, October 17, 2007 5:06 PM To: Netdev; Li Yang-r58472 Subject: [PATCH] Fix ethernet multicast for ucc_geth. From 5761a9e5924b34615c748fba2dcb977ed04c1243 Mon Sep 17 00:00:00 2001 From: Joakim

[PATCH] ip: justification for local port range robustness

2007-10-18 Thread Anton Arapov
Hi! There is a justifying patch for Stephen's patches. Stephen's patches disallows using a port range of one single port and brakes the meaning of the 'remaining' variable, in some places it has different meaning. My patch gives back the sense of 'remaining' variable. It should mean how many

Re: [PATCH] PHYLIB: IRQ event workqueue handling fixes

2007-10-18 Thread Maciej W. Rozycki
On Thu, 18 Oct 2007, Jarek Poplawski wrote: Technically until free_irq returns a handler should respond to calls and with proper hardware it should have no problem with checking if it's its interrupt, even after disabling this hardware, because of possible races. Well, the hardirq handler

Re: [PATCH] ip: justification for local port range robustness

2007-10-18 Thread Stephen Hemminger
On Thu, 18 Oct 2007 16:27:37 +0200 Anton Arapov [EMAIL PROTECTED] wrote: Hi! There is a justifying patch for Stephen's patches. Stephen's patches disallows using a port range of one single port and brakes the meaning of the 'remaining' variable, in some places it has different meaning.

Re: [PATCH] flush_work_sync vs. flush_scheduled_work Re: [PATCH] PHYLIB: IRQ event workqueue handling fixes

2007-10-18 Thread Oleg Nesterov
On 10/18, Jarek Poplawski wrote: +/** + * flush_work_sync - block until a work_struct's callback has terminated ^^^ Hmm... + * Similar to cancel_work_sync() but will only busy wait (without cancel) + * if the work is

Re: [PATCH] flush_work_sync vs. flush_scheduled_work Re: [PATCH] PHYLIB: IRQ event workqueue handling fixes

2007-10-18 Thread Maciej W. Rozycki
On Thu, 18 Oct 2007, Oleg Nesterov wrote: If we can't just cancel the work, can't we do something like if (cancel_work_sync(w)) w-func(w); instead? We do an equivalent of this -- all that we care about that w-func(w) would do is enable_irq() and the rest we want to

[PACKET]: Kill unused pg_vec_endpage() function

2007-10-18 Thread Patrick McHardy
[PACKET]: Kill unused pg_vec_endpage() function The conversion to vm_insert_page() left this unused function behind, remove it. Signed-off-by: Patrick McHardy [EMAIL PROTECTED] diff --git a/net/packet/af_packet.c b/net/packet/af_packet.c index e11000a..d093650 100644 ---

Re: multicast: bug or feature

2007-10-18 Thread Vlad Yasevich
Vlad Yasevich wrote: We've been trying to field some questions regarding multicast behavior and one such behavior has stumped us. I've reproduced the following behavior on 2.6.23. The application opens 2 sockets. One socket is the receiver and it simply binds to 0.0.0.0:2000 and joins a

Re: Throughput Bug?

2007-10-18 Thread Rick Jones
Matthew Faulkner wrote: Hey all I'm using netperf to perform TCP throughput tests via the localhost interface. This is being done on a SMP machine. I'm forcing the netperf server and client to run on the same core. However, for any packet sizes below 523 the throughput is much lower compared to

Re: bizarre network timing problem

2007-10-18 Thread Rick Jones
Felix von Leitner wrote: the packet trace was a bit too cooked perhaps, but there were indications that at times the TCP window was going to zero - perhaps something with window updates or persist timers? Does TCP use different window sizes on loopback? Why is this not happening on

RE: e100 problems in .23rc8 ?

2007-10-18 Thread David Mack
It appears that the needed e100 fix made it into the Fedora 2.6.23.1-23.fc8 kernel. Boots reliably now. Huge thanks and great work, guys. Dave -Original Message- From: Kok, Auke [mailto:[EMAIL PROTECTED] Sent: Friday, October 12, 2007 10:05 AM To: Herbert Xu Cc: David Mack; Dave

Re: e100 problems in .23rc8 ?

2007-10-18 Thread Kok, Auke
David Mack wrote: It appears that the needed e100 fix made it into the Fedora 2.6.23.1-23.fc8 kernel. Boots reliably now. Huge thanks and great work, guys. DaveJ, I didn't push anything upstream. Can you verify this now works? Auke Dave -Original Message- From: Kok, Auke

Re: e100 problems in .23rc8 ?

2007-10-18 Thread Chuck Ebbert
On 10/18/2007 01:59 PM, Kok, Auke wrote: David Mack wrote: It appears that the needed e100 fix made it into the Fedora 2.6.23.1-23.fc8 kernel. Boots reliably now. Huge thanks and great work, guys. DaveJ, I didn't push anything upstream. Can you verify this now works? We didn't put

[PATCH 1/2] r8169 - trivial fixes - add KERN_DEBUG to dprintk

2007-10-18 Thread Joe Perches
Prefix dprintk with KERN_DEBUG Fix a bug with existing use of dprintk (PFX KERN_INFO PFX) Signed-off-by: Joe Perches [EMAIL PROTECTED] diff --git a/drivers/net/r8169.c b/drivers/net/r8169.c index 419c00c..9c11087 100644 --- a/drivers/net/r8169.c +++ b/drivers/net/r8169.c @@ -44,7 +44,8 @@

[PATCH 2/2] r8169 - trivial fix - printk(PFX KERN_level...) to printk(KERN_level PFX...)

2007-10-18 Thread Joe Perches
Signed-off-by: Joe Perches [EMAIL PROTECTED] diff --git a/drivers/net/r8169.c b/drivers/net/r8169.c index 419c00c..9c11087 100644 --- a/drivers/net/r8169.c +++ b/drivers/net/r8169.c @@ -2310,7 +2311,7 @@ static void rtl8169_reinit_task(struct work_struct *work) ret = rtl8169_open(dev);

Re: [PATCH 1/2] r8169 - trivial fixes - add KERN_DEBUG to dprintk

2007-10-18 Thread Francois Romieu
Joe Perches [EMAIL PROTECTED] : Prefix dprintk with KERN_DEBUG Fix a bug with existing use of dprintk (PFX KERN_INFO PFX) Signed-off-by: Joe Perches [EMAIL PROTECTED] Ok, I will add #1 and #2 to the next submission to Jeff. -- Ueimor - To unsubscribe from this list: send the line

Re: [PATCH v3 0/4] FEC - fast ethernet controller for mpc52xx

2007-10-18 Thread Jeff Garzik
Grant Likely wrote: On 10/15/07, Jeff Garzik [EMAIL PROTECTED] wrote: Domen Puncer wrote: Hello! If there are no objections, I would like to get this merged when bestcomm goes in (any time now?). It's split into four parts: 1 - device tree 2 - small bestcomm change 3 - the actual driver 4 -

[0/3] Distributed storage. Mirror algo extension for automatic recovery.

2007-10-18 Thread Evgeniy Polyakov
Hi. I'm pleased to announce sixth release of the distributed storage subsystem, which allows to form a storage on top of remote and local nodes, which in turn can be exported to another storage as a node to form tree-like storages. This release includes mirroring algorithm extension, which

[1/3] Distributed storage. Core files.

2007-10-18 Thread Evgeniy Polyakov
Signed-off-by: Evgeniy Polyakov [EMAIL PROTECTED] diff --git a/drivers/block/Makefile b/drivers/block/Makefile index dd88e33..fcf042d 100644 --- a/drivers/block/Makefile +++ b/drivers/block/Makefile @@ -29,3 +29,4 @@ obj-$(CONFIG_VIODASD) += viodasd.o obj-$(CONFIG_BLK_DEV_SX8) +=

[2/3] Distributed storage. Network state machine.

2007-10-18 Thread Evgeniy Polyakov
Signed-off-by: Evgeniy Polyakov [EMAIL PROTECTED] diff --git a/drivers/block/dst/kst.c b/drivers/block/dst/kst.c new file mode 100644 index 000..b0608c9 --- /dev/null +++ b/drivers/block/dst/kst.c @@ -0,0 +1,1606 @@ +/* + * 2007+ Copyright (c) Evgeniy Polyakov [EMAIL PROTECTED] + * All rights

[3/3] Distributed storage. Documentation and algorithms.

2007-10-18 Thread Evgeniy Polyakov
Signed-off-by: Evgeniy Polyakov [EMAIL PROTECTED] diff --git a/Documentation/dst/algorithms.txt b/Documentation/dst/algorithms.txt new file mode 100644 index 000..1437a6a --- /dev/null +++ b/Documentation/dst/algorithms.txt @@ -0,0 +1,115 @@ +Each storage by itself is just a set of contiguous

[PATCH] phy/bitbang: missing MODULE_LICENSE

2007-10-18 Thread Randy Dunlap
From: Randy Dunlap [EMAIL PROTECTED] Missing MODULE_LICENSE(), loading this module taints the kernel. Signed-off-by: Randy Dunlap [EMAIL PROTECTED] --- drivers/net/phy/mdio-bitbang.c |2 ++ 1 file changed, 2 insertions(+) --- linux-2.6.23-git7.orig/drivers/net/phy/mdio-bitbang.c +++

Re: [PATCH] pcnet32: fix non-napi packet reception

2007-10-18 Thread Lennart Sorensen
On Wed, Oct 17, 2007 at 05:04:01PM -0700, Don Fry wrote: I have no objections myself. It has been slowly moving that direction. First with the napi implementation, default off, labeled experimental. Then removing experimental and then making the default on. If any other user of the pcnet32

[PATCH] trivial - QUICC UCC driver - remove buggy and unused vdbg macro

2007-10-18 Thread Joe Perches
remove buggy and unused vdbg macro Signed-off-by: Joe Perches [EMAIL PROTECTED] diff --git a/drivers/net/ucc_geth_mii.c b/drivers/net/ucc_geth_mii.c index df884f0..a4b481c 100644 --- a/drivers/net/ucc_geth_mii.c +++ b/drivers/net/ucc_geth_mii.c @@ -46,13 +46,6 @@ #include ucc_geth_mii.h

[PATCH 00/13] r8169: pull request for 'upstream-jeff' branch

2007-10-18 Thread Francois Romieu
Please pull from branch 'upstream-jeff' in repository git://git.kernel.org/pub/scm/linux/kernel/git/romieu/netdev-2.6.git upstream-jeff to get the changes below. Following mails on netdev describe each patch. Distance from 'master' (d85714d81cc0408daddb68c10f7fd69eafe7c213)

broken PCNET32 in 2.6.24 requires experimental PCNET32_NAPI?

2007-10-18 Thread Erez Zadok
I'm using Linus's git tree as of commit d85714d81cc0408daddb68c10f7fd69eafe7c213. I built that kernel under vmware workstation 6.0.1 which emulates a pcnet32 nic. When I only turn on CONFIG_PCNET32, my network interface doesn't seem to come up fully: my dhcp server sees a request, offers an IP

Re: broken PCNET32 in 2.6.24 requires experimental PCNET32_NAPI?

2007-10-18 Thread Jeff Garzik
Erez Zadok wrote: I'm using Linus's git tree as of commit d85714d81cc0408daddb68c10f7fd69eafe7c213. I built that kernel under vmware workstation 6.0.1 which emulates a pcnet32 nic. When I only turn on CONFIG_PCNET32, my network interface doesn't seem to come up fully: my dhcp server sees a

[PATCH 01/13] r8169: add KERN_DEBUG to dprintk (trivial)

2007-10-18 Thread Francois Romieu
- prefix dprintk with KERN_DEBUG - fix a bug with existing use of dprintk (PFX KERN_INFO PFX) Signed-off-by: Joe Perches [EMAIL PROTECTED] Signed-off-by: Francois Romieu [EMAIL PROTECTED] Cc: Edward Hsu [EMAIL PROTECTED] --- drivers/net/r8169.c |5 +++-- 1 files changed, 3 insertions(+), 2

[PATCH 07/13] r8169: add MAC identifiers

2007-10-18 Thread Francois Romieu
The identifiers have been extracted from Realtek's drivers: - version 8.002.00 of the r8168 driver - version 6.002.00 of the r8169 driver - version 1.002.00 of the r8101 driver 1. RTL_GIGA_MAC_VER_17 (8168Bf) is isolated from RTL_GIGA_MAC_VER_12 (8168Be) Both are still handled the same in

[PATCH 10/13] r8169: phy init for the 8168

2007-10-18 Thread Francois Romieu
The values have been extracted from Realtek's r8168 driver version 8.002.00. Signed-off-by: Francois Romieu [EMAIL PROTECTED] Cc: Edward Hsu [EMAIL PROTECTED] --- drivers/net/r8169.c | 52 +++ 1 files changed, 52 insertions(+), 0 deletions(-)

[PATCH 11/13] r8169: phy init cleanup

2007-10-18 Thread Francois Romieu
Consistent use of hexadecimal. No change of behavior otherwise. Signed-off-by: Francois Romieu [EMAIL PROTECTED] Cc: Edward Hsu [EMAIL PROTECTED] --- drivers/net/r8169.c | 18 +++--- 1 files changed, 11 insertions(+), 7 deletions(-) diff --git a/drivers/net/r8169.c

[PATCH 05/13] r8169: remove private net_device_stats structure

2007-10-18 Thread Francois Romieu
Use net_device_stats in the net_device structure. Signed-off-by: Francois Romieu [EMAIL PROTECTED] Cc: Edward Hsu [EMAIL PROTECTED] --- drivers/net/r8169.c | 34 +- 1 files changed, 17 insertions(+), 17 deletions(-) diff --git a/drivers/net/r8169.c

[PATCH 13/13] r8169: more phy init for the 8168

2007-10-18 Thread Francois Romieu
Realtek's r8168 driver version 8.003.00 adds new init sequences (they do not appear in version 8.002.00). Signed-off-by: Francois Romieu [EMAIL PROTECTED] Cc: Edward Hsu [EMAIL PROTECTED] --- drivers/net/r8169.c | 34 ++ 1 files changed, 34 insertions(+), 0

[PATCH 08/13] r8169: remove dead wood

2007-10-18 Thread Francois Romieu
Signed-off-by: Francois Romieu [EMAIL PROTECTED] Cc: Edward Hsu [EMAIL PROTECTED] --- drivers/net/r8169.c | 66 +- 1 files changed, 2 insertions(+), 64 deletions(-) diff --git a/drivers/net/r8169.c b/drivers/net/r8169.c index 9deda50..3a3ba79

[PATCH 09/13] r8169: make room for more phy init changes

2007-10-18 Thread Francois Romieu
The code is reworked to easily add phy-dependant init changes. No change of behavior should be noticed. Signed-off-by: Francois Romieu [EMAIL PROTECTED] Cc: Edward Hsu [EMAIL PROTECTED] --- drivers/net/r8169.c | 56 -- 1 files changed, 31

[PATCH 12/13] r8169: update the phy init for the 8168C

2007-10-18 Thread Francois Romieu
The values have been updated between version 8.002.00 and version 8.003.00 of Realtek's r8168 driver. This modification syncs the 8168C with version 8.003.00. Signed-off-by: Francois Romieu [EMAIL PROTECTED] Cc: Edward Hsu [EMAIL PROTECTED] --- drivers/net/r8169.c |2 ++ 1 files changed, 2

[PATCH 03/13] r8169: convert bitfield to plain enum mask

2007-10-18 Thread Francois Romieu
Signed-off-by: Francois Romieu [EMAIL PROTECTED] Cc: Edward Hsu [EMAIL PROTECTED] --- drivers/net/r8169.c | 14 +++--- 1 files changed, 11 insertions(+), 3 deletions(-) diff --git a/drivers/net/r8169.c b/drivers/net/r8169.c index 9c11087..16ecba1 100644 --- a/drivers/net/r8169.c +++

[PATCH 04/13] r8169: MSI support

2007-10-18 Thread Francois Romieu
It is currently limited to the tested 0x8136 and 0x8168. 8169sb/8110sb ought to handle it as well where they support MSI. Signed-off-by: Francois Romieu [EMAIL PROTECTED] Cc: Edward Hsu [EMAIL PROTECTED] Tester-Cc: Rolf Eike Beer [EMAIL PROTECTED] --- drivers/net/r8169.c | 50

[PATCH 06/13] r8169: use the existing symbolic name of vendor PCI ID 0x1259

2007-10-18 Thread Francois Romieu
Signed-off-by: Francois Romieu [EMAIL PROTECTED] Cc: Edward Hsu [EMAIL PROTECTED] --- drivers/net/r8169.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/net/r8169.c b/drivers/net/r8169.c index 951c56e..c290aa5 100644 --- a/drivers/net/r8169.c +++

Re: [PATCH] [Bug 9187] ir-functions.c:(.text+0xbce18): undefined reference to `input_event'

2007-10-18 Thread David Miller
From: Randy Dunlap [EMAIL PROTECTED] Date: Thu, 18 Oct 2007 21:53:50 -0700 [EMAIL PROTECTED] wrote:] From: Randy Dunlap [EMAIL PROTECTED] Drivers that use lro functions should depend on INET, otherwise they may not link correctly. Let's not select INET. Select should be used only

Re: [PACKET]: Kill unused pg_vec_endpage() function

2007-10-18 Thread David Miller
Applied, thanks! - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

  1   2   >