[PATCH] Re: Loopback address to eth0 interface and rooting goes wrong

2008-01-24 Thread Bjørn Mork
Hello Gary gary.manchon (at) gmail.com found a problem where he was unable to recover from a bad network interface configuration (ifconfig eth0 127.0.0.1), ref http://www.uwsg.iu.edu/hypermail/linux/net/0801.2/0009.html This was confirmed by several people. I suspect that the problem might

Re: [Bugme-new] [Bug 9806] New: (tun dev) Impossible to deassert IFF_ONE_QUEUE or IFF_NO_PI

2008-01-24 Thread Andrew Morton
On Wed, 23 Jan 2008 13:13:13 -0800 (PST) [EMAIL PROTECTED] wrote: http://bugzilla.kernel.org/show_bug.cgi?id=9806 Summary: (tun dev) Impossible to deassert IFF_ONE_QUEUE or IFF_NO_PI Product: Drivers Version: 2.5 KernelVersion:

Re: bluetooth : lockdep warning on rfcomm

2008-01-24 Thread Dave Young
On Jan 24, 2008 11:02 AM, Dave Young [EMAIL PROTECTED] wrote: = [ INFO: possible recursive locking detected ] 2.6.24-rc8-mm1 #8 - bluepush/3213 is trying to acquire lock: (sk_lock-AF_BLUETOOTH){--..},

Re: [IPV4 0/9] TRIE performance patches

2008-01-24 Thread Robert Olsson
Stephen Hemminger writes: Dumping by prefix is possible, but unless 32x slower. Dumping in address order is just as logical. Like I said, I'm investigating what quagga handles. How about taking a snapshot to in address order (as you did) to some allocated memory, returning from that

[resend][PATCH] Introducing socket mark socket option

2008-01-24 Thread Laszlo Attila Toth
A userspace program may wish to set the mark for each packets its send without using the netfilter MARK target. Changing the mark can be used for mark based routing without netfilter or for packet filtering. It requires CAP_NET_ADMIN capability. Signed-off-by: Laszlo Attila Toth [EMAIL

Re: [resend][PATCH] Introducing socket mark socket option

2008-01-24 Thread Patrick McHardy
Laszlo Attila Toth wrote: A userspace program may wish to set the mark for each packets its send without using the netfilter MARK target. Changing the mark can be used for mark based routing without netfilter or for packet filtering. It requires CAP_NET_ADMIN capability. Looks good to me. --

Re: 2.6.24-rc8-mm1 : net tcp_input.c warnings

2008-01-24 Thread Ilpo Järvinen
On Thu, 24 Jan 2008, Dave Young wrote: Hi Dave ( others), Thanks. Thanks a lot, I was first to ignore all these because they occurred with newreno, but looked again... :-/ New warning trigged with your debug patch: This was probably with the earlier one I sent to you because there's still

Re: My 802.3ad is my bond

2008-01-24 Thread Steven Whitehouse
Hi, On Wed, 2008-01-23 at 09:13 -0800, Jay Vosburgh wrote: Steven Whitehouse [EMAIL PROTECTED] wrote: [...] This commit: ece95f7fefe3afae19e641e1b3f5e64b00d5b948 seems to have caused a problem with parsing bond arguments as now only the numeric arguments seem to work (in modprobe.conf) and

Re: 2.6.24-rc8-mm1 : net tcp_input.c warnings

2008-01-24 Thread Ilpo Järvinen
On Thu, 24 Jan 2008, Ilpo Järvinen wrote: And anyway, there were some fackets_out related problems reported as well and this doesn't help for that but I think I've lost track of who was seeing it due to large number of reports :-), could somebody refresh my memory because I currently don't

[PATCH UCC TDM 1/3 Updated] Platform changes for UCC TDM driver for MPC8323eRDB. Also includes related QE changes and dts entries.

2008-01-24 Thread Poonam_Aggrwal-b10812
Thanks Stephen for your comments, incorporated them. From: Poonam Aggrwal [EMAIL PROTECTED] This patch makes necessary changes in the QE and UCC framework to support TDM. It also adds support to configure the BRG properly through device tree entries. Includes the device tree changes for UCC TDM

[PATCH 1/1][NETNS] Add missing initialization of nl_info.nl_net in rtm_to_fib6_config()

2008-01-24 Thread Benjamin Thery
Add missing initialization of the new nl_info.nl_net field in rtm_to_fib6_config(). This will be needed the store network namespace associated to the fib6_config struct. Signed-off-by: Benjamin Thery [EMAIL PROTECTED] --- net/ipv6/route.c |1 + 1 file changed, 1 insertion(+) Index:

[PATCH UCC TDM 2/3 ]Updated: UCC TDM driver for QE based MPC83xx platforms.

2008-01-24 Thread Poonam_Aggrwal-b10812
Incorporated Stephen's comments. From: Poonam Agarwal-b10812 [EMAIL PROTECTED] The UCC TDM driver basically multiplexes and demultiplexes data from different channels. It can interface with for example SLIC kind of devices to receive TDM data demultiplex it and send to upper modules. At the

Re: 2.6.24-rc8-mm1 : net tcp_input.c warnings

2008-01-24 Thread Krishna Kumar2
Hi Ilpo, I have tried parallel iperfs with this patch and don't get any more warnings. I will run overnight to be sure. thanks, - KK [EMAIL PROTECTED] wrote on 01/24/2008 03:24:18 PM: On Thu, 24 Jan 2008, Dave Young wrote: Hi Dave ( others), Thanks. Thanks a lot, I was first to ignore

[XFRM]: constify 'struct xfrm_type'

2008-01-24 Thread Eric Dumazet
Signed-off-by: Eric Dumazet [EMAIL PROTECTED] include/net/xfrm.h |8 net/ipv4/ah4.c |2 +- net/ipv4/esp4.c |2 +- net/ipv4/ipcomp.c |2 +- net/ipv4/xfrm4_tunnel.c |2 +- net/ipv6/ah6.c |2 +- net/ipv6/esp6.c |2 +-

Re: [PATCH net-2.6.25] Add packet filtering based on process's security context.

2008-01-24 Thread Tetsuo Handa
Hello. Are there any remaining questions/problems about this patch? If none, I want this patch applied to net-2.6.25 tree. Regards. --- This patch modifies security_socket_post_accept() and introduces security_socket_post_recv_datagram() LSM hooks. Currently,

Re: [Lksctp-developers] [PATCH] SCTP: Fix kernel panic while received AUTH chunk with BAD shared key identifier

2008-01-24 Thread Neil Horman
On Tue, Jan 22, 2008 at 05:29:20PM +0900, Wei Yongjun wrote: This patch fix this problem. Signed-off-by: Wei Yongjun [EMAIL PROTECTED] --- a/net/sctp/auth.c 2008-01-21 00:03:25.0 -0500 +++ b/net/sctp/auth.c 2008-01-21 21:31:47.0 -0500 @@ -420,15 +420,15 @@ struct

[PATCH 1/5] netns netfilter: per-netns ip6tables

2008-01-24 Thread Alexey Dobriyan
* Propagate netns from userspace down to xt_find_table_lock() * Register ip6 tables in netns (modules still use init_net) Signed-off-by: Alexey Dobriyan [EMAIL PROTECTED] --- include/linux/netfilter_ipv6/ip6_tables.h |3 + net/ipv6/netfilter/ip6_tables.c | 50

[PATCH 2/5] netns netfilter: per-netns IPv6 FILTER, MANGLE, RAW

2008-01-24 Thread Alexey Dobriyan
Now it's possible to list and manipulate per-netns ip6tables rules. Filtering decisions are based on init_net's table so far. P.S.: remove init_net check in inet6_create() to see the effect Signed-off-by: Alexey Dobriyan [EMAIL PROTECTED] --- include/net/netns/ipv6.h |6 +

[PATCH 3/5] netns netfilter: per-netns arp_tables

2008-01-24 Thread Alexey Dobriyan
* Propagate netns from userspace. * arpt_register_table() registers table in supplied netns. Signed-off-by: Alexey Dobriyan [EMAIL PROTECTED] --- include/linux/netfilter_arp/arp_tables.h |3 + net/ipv4/netfilter/arp_tables.c | 55 +--

[PATCH 4/5] netns netfilter: per-netns arp_tables FILTER

2008-01-24 Thread Alexey Dobriyan
Signed-off-by: Alexey Dobriyan [EMAIL PROTECTED] --- include/net/netns/ipv4.h |1 net/ipv4/netfilter/arptable_filter.c | 38 +-- 2 files changed, 29 insertions(+), 10 deletions(-) --- a/include/net/netns/ipv4.h +++ b/include/net/netns/ipv4.h @@

[PATCH 5/5] netns netfilter: put table module on netns stop

2008-01-24 Thread Alexey Dobriyan
When number of entries exceeds number of initial entries, foo-tables code will pin table module. But during table unregister on netns stop, that additional pin was forgotten. Signed-off-by: Alexey Dobriyan [EMAIL PROTECTED] --- net/ipv4/netfilter/arp_tables.c |3 +++

Re: 2.6.24-rc8-mm1 : net tcp_input.c warnings

2008-01-24 Thread Kamalesh Babulal
On Thu, Jan 24, 2008 at 11:54:18AM +0200, Ilpo Järvinen wrote: On Thu, 24 Jan 2008, Dave Young wrote: Hi Dave ( others), Thanks. Thanks a lot, I was first to ignore all these because they occurred with newreno, but looked again... :-/ New warning trigged with your debug patch:

[PATCH net-2.6.25][NETNS]: Fix race between put_net() and netlink_kernel_create().

2008-01-24 Thread Pavel Emelyanov
The comment about race free view of the set of network namespaces was a bit hasty. Look (there even can be only one CPU, as discovered by Alexey Dobriyan and Denis Lunev): put_net() if (atomic_dec_and_test(net-refcnt)) /* true */ __put_net(net); queue_work(...); /* * note:

Re: [Bugme-new] [Bug 9808] New: system hung with htb QoS

2008-01-24 Thread Andrew Morton
On Thu, 24 Jan 2008 03:03:11 -0800 (PST) [EMAIL PROTECTED] wrote: http://bugzilla.kernel.org/show_bug.cgi?id=9808 Summary: system hung with htb QoS Product: Networking Version: 2.5 KernelVersion: 2.6.23.9 Platform: All OS/Version:

Re: [PATCH net-2.6.25] Add packet filtering based on process's security context.

2008-01-24 Thread Paul Moore
On Thursday 24 January 2008 6:47:55 am Tetsuo Handa wrote: Are there any remaining questions/problems about this patch? If none, I want this patch applied to net-2.6.25 tree. Hello, Taking into consideration that there are no current in-tree users of this patch and the only known user of this

[NET]: should explicitely initialize atomic_t field in struct dst_ops

2008-01-24 Thread Eric Dumazet
All but one struct dst_ops static initializations miss explicit initialization of entries field. As this field is atomic_t, we should use ATOMIC_INIT(0), and not rely on atomic_t implementation. Signed-off-by: Eric Dumazet [EMAIL PROTECTED] net/ipv4/route.c|2 ++

Re: [PATCH] UCC TDM driver for QE based MPC83xx platforms.

2008-01-24 Thread Timur Tabi
Stephen Rothwell wrote: + tdm_ctrl[device_num]-ut_info-uf_info.tdm_tx_clk = + (char *) of_get_property(np, fsl,tdm-tx-clk, NULL); ^ We don't normall put spaces here. Since when? -- Timur Tabi Linux kernel developer at Freescale --

Re: [PATCH UCC TDM 1/3 Updated] Platform changes for UCC TDM driver for MPC8323eRDB. Also includes related QE changes and dts entries.

2008-01-24 Thread Anton Vorontsov
Hello Poonam, On Thu, Jan 24, 2008 at 04:00:06PM +0530, Poonam_Aggrwal-b10812 wrote: Thanks Stephen for your comments, incorporated them. From: Poonam Aggrwal [EMAIL PROTECTED] This patch makes necessary changes in the QE and UCC framework to support TDM. It also adds support to configure

[PATCH net-2.6.25][IPV6]: Introduce the INET6_TW_MATCH() macro.

2008-01-24 Thread Pavel Emelyanov
We have INET_MATCH, INET_TW_MATCH and INET6_MATCH to test sockets and twbuckets for matching, but ipv6 twbuckets are tested manually. Here's the INET6_TW_MATCH to help with it. Since the commit b3652b2dc5ec6ccd946ae9136b30c6babb81305a [IPV6]: Mischecked tw match in __inet6_check_established.

Re: [PATCH UCC TDM 1/3 Updated] Platform changes for UCC TDM driver for MPC8323eRDB. Also includes related QE changes and dts entries.

2008-01-24 Thread Timur Tabi
Anton Vorontsov wrote: Can we not introduce new pio-maps in the device trees? There were debates regarding this, and if I understood everything correctly, pio-maps considered as a bad taste. Better do bunch of par_io_config_pin() in the board file. Better yet fixup the firmware (u-boot) to set

[VLAN] set_rx_mode support for unicast address list

2008-01-24 Thread Chris Leech
Reuse the existing logic for multicast list synchronization for the unicast address list. The core of dev_mc_sync/unsync are split out as __dev_addr_sync/unsync and moved from dev_mcast.c to dev.c. These are then used to implement dev_unicast_sync/unsync as well. I'm working on cleaning up

Re: [IPV4 0/9] TRIE performance patches

2008-01-24 Thread Stephen Hemminger
On Thu, 24 Jan 2008 10:36:45 +0100 Robert Olsson [EMAIL PROTECTED] wrote: Stephen Hemminger writes: Dumping by prefix is possible, but unless 32x slower. Dumping in address order is just as logical. Like I said, I'm investigating what quagga handles. How about taking a snapshot

Re: [PATCH UCC TDM 1/3 Updated] Platform changes for UCC TDM driver for MPC8323eRDB. Also includes related QE changes and dts entries.

2008-01-24 Thread Anton Vorontsov
On Thu, Jan 24, 2008 at 09:55:31AM -0600, Timur Tabi wrote: Anton Vorontsov wrote: Can we not introduce new pio-maps in the device trees? There were debates regarding this, and if I understood everything correctly, pio-maps considered as a bad taste. Better do bunch of par_io_config_pin()

Re: [PATCH UCC TDM 1/3 Updated] Platform changes for UCC TDM driver for MPC8323eRDB. Also includes related QE changes and dts entries.

2008-01-24 Thread Timur Tabi
Anton Vorontsov wrote: Are you saying that TDM is sharing same pins with the other QE device, and we can choose to use/not use some device depending on which driver is loaded? No. I'd have to closely examine the DTS, but I don't think that UCC devices share pins at all. But that isn't my

Re: [Bugme-new] [Bug 9806] New: (tun dev) Impossible to deassert IFF_ONE_QUEUE or IFF_NO_PI

2008-01-24 Thread Nathaniel Filardo
On Jan 24, 2008 3:33 AM, Andrew Morton [EMAIL PROTECTED] wrote: On Wed, 23 Jan 2008 13:13:13 -0800 (PST) [EMAIL PROTECTED] wrote: http://bugzilla.kernel.org/show_bug.cgi?id=9806 Thanks. Could you please submit the patch via email? Send it to all recipients of this email. Attached. --nwf;

Re: [XFRM]: constify 'struct xfrm_type'

2008-01-24 Thread Joe Perches
On Thu, 2008-01-24 at 12:26 +0100, Eric Dumazet wrote: - struct xfrm_type *type; + const struct xfrm_type *type; Perhaps const foo * const bar; for most or all of these conversions? -- To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL

Re: [PATCH UCC TDM 1/3 Updated] Platform changes for UCC TDM driver for MPC8323eRDB. Also includes related QE changes and dts entries.

2008-01-24 Thread Anton Vorontsov
On Thu, Jan 24, 2008 at 10:33:47AM -0600, Timur Tabi wrote: Anton Vorontsov wrote: Are you saying that TDM is sharing same pins with the other QE device, and we can choose to use/not use some device depending on which driver is loaded? No. I'd have to closely examine the DTS, but I don't

Re: [VLAN] set_rx_mode support for unicast address list

2008-01-24 Thread Patrick McHardy
Chris Leech wrote: Reuse the existing logic for multicast list synchronization for the unicast address list. The core of dev_mc_sync/unsync are split out as __dev_addr_sync/unsync and moved from dev_mcast.c to dev.c. These are then used to implement dev_unicast_sync/unsync as well. I'm working

Re: [PATCH 1/5] netns netfilter: per-netns ip6tables

2008-01-24 Thread Patrick McHardy
Alexey Dobriyan wrote: * Propagate netns from userspace down to xt_find_table_lock() * Register ip6 tables in netns (modules still use init_net) Signed-off-by: Alexey Dobriyan [EMAIL PROTECTED] --- include/linux/netfilter_ipv6/ip6_tables.h |3 + net/ipv6/netfilter/ip6_tables.c |

Re: [PATCH 3/5] netns netfilter: per-netns arp_tables

2008-01-24 Thread Patrick McHardy
Alexey Dobriyan wrote: * Propagate netns from userspace. * arpt_register_table() registers table in supplied netns. Applied. -- To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at

Re: [PATCH 4/5] netns netfilter: per-netns arp_tables FILTER

2008-01-24 Thread Patrick McHardy
Alexey Dobriyan wrote: Signed-off-by: Alexey Dobriyan [EMAIL PROTECTED] Applied. -- To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 5/5] netns netfilter: put table module on netns stop

2008-01-24 Thread Patrick McHardy
Alexey Dobriyan wrote: When number of entries exceeds number of initial entries, foo-tables code will pin table module. But during table unregister on netns stop, that additional pin was forgotten. Applied, thanks. -- To unsubscribe from this list: send the line unsubscribe netdev in the

Slow OOM in netif_RX function

2008-01-24 Thread Ivan Dichev
Hello, I got problem with my linux router. It has slow persistent OOM problems from few months ago. Every working(I mean days when more traffic is generated) day my router is leaking with 15-20 MB memory and after 2 weeks the restart is a MUST. From /proc/slabinfo I saw that size-2048 and size-512

[Patch 2.6.24 1/1]S2io: Support for vlan_rx_kill_vid entry point

2008-01-24 Thread Sreenivasa Honnur
- Added s2io_vlan_rx_kill_vid entry point function for unregistering vlan. - Fix to aggregate vlan packets. IP offset is incremented by 4 bytes if the packet contains vlan header. Signed-off-by: Surjit Reang [EMAIL PROTECTED] Signed-off-by: Ramkrishna Vepa [EMAIL PROTECTED] --- diff -Nurp

[Patch 2.6.24 1/2]S2io: Fix for LRO Bugs

2008-01-24 Thread Sreenivasa Honnur
Resubmitting patch from Al Viro [EMAIL PROTECTED], with subject - [PATCH] s2io LRO bugs. a) initiate_new_session() sets -tcp_ack to ntohl(...); everything else stores and expects to find there the net-endian value. b) check for monotonic timestamps in verify_l3_l4_lro_capable() compares the

[Patch 2.6.24 3/3]S2io: Version update for [Patch 2.6.24 1/3] [Patch 2.6.24 2/3]

2008-01-24 Thread Sreenivasa Honnur
- Updated version number. Signed-off-by: Surjit Reang [EMAIL PROTECTED] Signed-off-by: Ramkrishna Vepa [EMAIL PROTECTED] --- diff -Nurp 2-0-26-18-2/drivers/net/s2io.c 2-0-26-18-3/drivers/net/s2io.c --- 2-0-26-18-2/drivers/net/s2io.c 2008-01-24 04:27:23.0 +0530 +++

[Patch 2.6.24 1/3]S2io: Support for vlan_rx_kill_vid entry point

2008-01-24 Thread Sreenivasa Honnur
- Added s2io_vlan_rx_kill_vid entry point function for unregistering vlan. - Fix to aggregate vlan packets. IP offset is incremented by 4 bytes if the packet contains vlan header. Signed-off-by: Surjit Reang [EMAIL PROTECTED] Signed-off-by: Ramkrishna Vepa [EMAIL PROTECTED] --- diff -Nurp

[Patch 2.6.24 2/3]S2io: Fix for LRO Bugs

2008-01-24 Thread Sreenivasa Honnur
Resubmitting patch from Al Viro [EMAIL PROTECTED], with subject - [PATCH] s2io LRO bugs. a) initiate_new_session() sets -tcp_ack to ntohl(...); everything else stores and expects to find there the net-endian value. b) check for monotonic timestamps in verify_l3_l4_lro_capable() compares the

Re: [XFRM]: constify 'struct xfrm_type'

2008-01-24 Thread Eric Dumazet
Joe Perches a écrit : On Thu, 2008-01-24 at 12:26 +0100, Eric Dumazet wrote: - struct xfrm_type *type; + const struct xfrm_type *type; Perhaps const foo * const bar; for most or all of these conversions? Hum... Having const data is nice because moving them from .data to

Re: Slow OOM in netif_RX function

2008-01-24 Thread Stephen Hemminger
On Thu, 24 Jan 2008 19:28:09 +0200 Ivan Dichev [EMAIL PROTECTED] wrote: Hello, I got problem with my linux router. It has slow persistent OOM problems from few months ago. Every working(I mean days when more traffic is generated) day my router is leaking with 15-20 MB memory and after 2

Re: [XFRM]: constify 'struct xfrm_type'

2008-01-24 Thread Joe Perches
On Thu, 2008-01-24 at 19:23 +0100, Eric Dumazet wrote: Having const data is nice because moving them from .data to .rodata, but what would be practical gains to use a const pointer ??? const data is good, using pointers to const data is good. using const pointers to const data is good. using

Re: Slow OOM in netif_RX function

2008-01-24 Thread Eric Dumazet
Ivan Dichev a écrit : Hello, I got problem with my linux router. It has slow persistent OOM problems from few months ago. Every working(I mean days when more traffic is generated) day my router is leaking with 15-20 MB memory and after 2 weeks the restart is a MUST. From /proc/slabinfo I saw

Re: [XFRM]: constify 'struct xfrm_type'

2008-01-24 Thread Eric Dumazet
Joe Perches a écrit : On Thu, 2008-01-24 at 19:23 +0100, Eric Dumazet wrote: Having const data is nice because moving them from .data to .rodata, but what would be practical gains to use a const pointer ??? const data is good, using pointers to const data is good. Yes, this is what is done.

Re: [XFRM]: constify 'struct xfrm_type'

2008-01-24 Thread Joe Perches
On Thu, 2008-01-24 at 20:24 +0100, Eric Dumazet wrote: I still dont understand what *you* want to do. Mark the accesses as * const not const * -- To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at

RE: [Bugme-new] [Bug 9808] New: system hung with htb QoS

2008-01-24 Thread Brandeburg, Jesse
Andrew Morton wrote: I'm also receiving this quite often: Jan 15 12:23:17 ftp kernel: e1000: eth0: e1000_clean_tx_irq: Detected Tx Unit Hang Jan 15 12:23:17 ftp kernel: Tx Queue 0 Jan 15 12:23:17 ftp kernel: TDH 2a Jan 15 12:23:17 ftp kernel: TDT

Re: [PATCH UCC TDM 3/3 ] Modified Documentation to explain dts entries for TDM driver

2008-01-24 Thread Scott Wood
On Thu, Jan 24, 2008 at 10:24:13AM +0530, Poonam_Aggrwal-b10812 wrote: + ix) Baud Rate Generator (BRG) + + Required properties: + - compatible : shpuld be fsl,cpm-brg + - fsl,brg-sources : define the input clock for all 16 BRGs. The input +clock source could be 1 to 24 for CLK1 to

Re: [PATCH UCC TDM 1/3 Updated] Platform changes for UCC TDM driver for MPC8323eRDB. Also includes related QE changes and dts entries.

2008-01-24 Thread Scott Wood
On Thu, Jan 24, 2008 at 10:33:47AM -0600, Timur Tabi wrote: Yes, but deciding what the UCC does might not be static. At what point do we declare, UCC5 is for eth0 and eth0 only? When the board designer decides to hook eth0 up to UCC5. If the board designer decides to hook multiple devices up

Slow OOM in netif_RX function

2008-01-24 Thread Ivan H. Dichev
Eric Dumazet writes: Ivan Dichev a écrit : Hello, I got problem with my linux router. It has slow persistent OOM problems from few months ago. Every working(I mean days when more traffic is generated) day my router is leaking with 15-20 MB memory and after 2 weeks the restart is a MUST. From

Re: [Bugme-new] [Bug 9808] New: system hung with htb QoS

2008-01-24 Thread Andrew Morton
On Thu, 24 Jan 2008 12:06:58 -0800 Brandeburg, Jesse [EMAIL PROTECTED] wrote: Would you be willing to try the 7.6.15 driver at e1000.sourceforge.net, it has many more fixes for e1000 than what is available in the in-kernel driver. I just posted a patch in the Tracker/Patches area that

[PATCH] fib_trie: rescan if key is lost during dump

2008-01-24 Thread Stephen Hemminger
Normally during a dump the key of the last dumped entry is used for continuation, but since lock is dropped it might be lost. In that case fallback to the old counter based N^2 behaviour. This means the dump will end up skipping some routes which matches what FIB_HASH does. Signed-off-by:

Re: Slow OOM in netif_RX function

2008-01-24 Thread Francois Romieu
Ivan H. Dichev [EMAIL PROTECTED] : [...] Any other ideas appreciated. Plot the slab values and the counters of the iptables rules against time ? -- Ueimor -- To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at

[PATCH 2.6.25] RDMA/cxgb3: Fix the T3A workaround checks.

2008-01-24 Thread Steve Wise
RDMA/cxgb3: Fix the T3A workaround checks. Correctly work around T3A issues by checking hwtype != T3A instead of hwtype == T3B. Needed for new hw types. Signed-off-by: Steve Wise [EMAIL PROTECTED] --- drivers/infiniband/hw/cxgb3/cxio_hal.c |2 +-

[PATCH] SMC91x: Use IRQ save and restore versions of spinlocks

2008-01-24 Thread Kevin Hilman
Under certain circumstances (e.g. kgdb over ethernet), the TX code may be called with interrupts disabled. The spin_unlock_irq() calls in the driver unconditionally re-enable interrupts, which may trigger the netdev softirq to run and cause spinlock recursion in the net stack. For example,

Re: [PATCH 2.6.25] RDMA/cxgb3: Fix the T3A workaround checks.

2008-01-24 Thread Roland Dreier
thanks, applied. -- To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 07/14] [rndis_host] Split up rndis_host.c

2008-01-24 Thread David Brownell
On Saturday 19 January 2008, Jussi Kivilinna wrote: Split up rndis_host.c into rndis_host.h and rndis_base.c. This is done so that rndis_wext can reuse common parts with rndis_host. Signed-off-by: Jussi Kivilinna [EMAIL PROTECTED] Acked-by: David Brownell [EMAIL PROTECTED] ---

Re: [PATCH 10/14] [rndis_host] Add rndis_early_init function pointer to 'struct rndis_data'.

2008-01-24 Thread David Brownell
On Saturday 19 January 2008, Jussi Kivilinna wrote: Function pointer is for rndis minidrivers that need to do work on device right after RNDIS_INIT. For example setting device specific configuration parameters with OID_GEN_RNDIS_CONFIG_PARAMETER. Signed-off-by: Jussi Kivilinna [EMAIL

Re: [PATCH 00/14] RFC: Driver for Wireless RNDIS USB devices.

2008-01-24 Thread David Brownell
On Saturday 19 January 2008, Jussi Kivilinna wrote: Hello, This is second try on wireless RNDIS patchset started by Bjorge Dijkstra. Since Bjorge has disappeared, I claim maintainership of rndis_wext and this patchset until he returns. This patchset adds support for various 802.11 USB

Re: [PATCH 13/14] [rndis_host] blacklist known wireless RNDIS devices

2008-01-24 Thread David Brownell
On Saturday 19 January 2008, Jussi Kivilinna wrote: Blacklist known wireless RNDIS devices that will be handled by rndis_wext module. This seems destined to become a headache. Wouldn't it be better to let the probe progress far enough to detect that it's actually a WLAN device, and then back

Re: [PATCH 04/14] [rndis_host] Halt device if rndis_bind fails.

2008-01-24 Thread David Brownell
On Saturday 19 January 2008, Jussi Kivilinna wrote: When bind fails after device was initialized, shutdown device properly by sending RNDIS_MSG_HALT. Signed-off-by: Jussi Kivilinna [EMAIL PROTECTED] Signed-off-by: Bjorge Dijkstra [EMAIL PROTECTED] Acked-by: David Brownell [EMAIL PROTECTED]

Re: [PATCH 08/14] [rndis_host] export functions

2008-01-24 Thread David Brownell
On Saturday 19 January 2008, Jussi Kivilinna wrote: Export rndis_host functions and also rename rndis_bind() to generic_rndis_bind() for modules using rndis_host as base. Signed-off-by: Jussi Kivilinna [EMAIL PROTECTED] Acked-by: David Brownell [EMAIL PROTECTED] ---

Re: [PATCH 06/14] [usbnet] Use wlan device name for RNDIS wireless devices

2008-01-24 Thread David Brownell
On Saturday 19 January 2008, Jussi Kivilinna wrote: Use wlan device name for RNDIS wireless devices. Signed-off-by: Jussi Kivilinna [EMAIL PROTECTED] Signed-off-by: Bjorge Dijkstra [EMAIL PROTECTED] Acked-by: David Brownell [EMAIL PROTECTED] --- drivers/net/usb/usbnet.c |3 +++

Re: [PATCH 05/14] [rndis_host] Fix rndis packet filter flags.

2008-01-24 Thread David Brownell
On Saturday 19 January 2008, Jussi Kivilinna wrote: RNDIS packet filter flags are not exactly the same as CDC flags so we cannot reuse them. Signed-off-by: Jussi Kivilinna [EMAIL PROTECTED] Signed-off-by: Bjorge Dijkstra [EMAIL PROTECTED] Acked-by: David Brownell [EMAIL PROTECTED] ---

Re: [PATCH 09/26] atl1: refactor tx processing

2008-01-24 Thread Jay Cliburn
On Tue, 22 Jan 2008 18:31:09 -0600 Jay Cliburn [EMAIL PROTECTED] wrote: On Tue, 22 Jan 2008 04:58:17 -0500 Jeff Garzik [EMAIL PROTECTED] wrote: [...] for such a huge patch, this description is very tiny. [describe] what is refactored, and why. Is this one any better? From

Re: [PATCH 09/26] atl1: refactor tx processing

2008-01-24 Thread Chris Snook
Jay Cliburn wrote: On Tue, 22 Jan 2008 18:31:09 -0600 Jay Cliburn [EMAIL PROTECTED] wrote: On Tue, 22 Jan 2008 04:58:17 -0500 Jeff Garzik [EMAIL PROTECTED] wrote: [...] for such a huge patch, this description is very tiny. [describe] what is refactored, and why. Is this one any better?

Re: [PATCH 01/14] Fix sparse warning: returning void-valued expression

2008-01-24 Thread David Brownell
On Saturday 19 January 2008, Jussi Kivilinna wrote: From: Bjorge Dijkstra [EMAIL PROTECTED] rndis_unbind and usbnet_cdc_unbind don't return anything. Signed-off-by: Bjorge Dijkstra [EMAIL PROTECTED] Signed-off-by: Jussi Kivilinna [EMAIL PROTECTED] Acked-by: David Brownell [EMAIL

Re: [PATCH 02/14] [cdc_ether] Hardwire CDC descriptors when missing

2008-01-24 Thread David Brownell
On Saturday 19 January 2008, Jussi Kivilinna wrote: From: Bjorge Dijkstra [EMAIL PROTECTED] Just as ActiveSync devices, some regular RNDIS devices also lack the CDC descriptors (e.g. devices based on BCM4320 WLAN chip). This patch hardwires the CDC descriptors for all RNDIS style devices

Re: [PATCH 03/14] [rndis_host] Use 1KB buffer in rndis_unbind

2008-01-24 Thread David Brownell
On Saturday 19 January 2008, Jussi Kivilinna wrote: rndis_command requires the caller to pass in a buffer of at least 1KB. Signed-off-by: Jussi Kivilinna [EMAIL PROTECTED] Signed-off-by: Bjorge Dijkstra [EMAIL PROTECTED] Acked-by: David Brownell [EMAIL PROTECTED] ---

Re: [PATCH 09/14] [usbnet] add driver_priv pointer to 'struct usbnet'

2008-01-24 Thread David Brownell
On Saturday 19 January 2008, Jussi Kivilinna wrote: Add a private data pointer to usbnet for rndis_wext module to use. Signed-off-by: Jussi Kivilinna [EMAIL PROTECTED] Acked-by: David Brownell [EMAIL PROTECTED] --- drivers/net/usb/usbnet.h |1 + 1 files changed, 1 insertions(+), 0

Re: 2.6.24-rc8-mm1 : net tcp_input.c warnings

2008-01-24 Thread Dave Young
On Jan 24, 2008 5:54 PM, Ilpo Järvinen [EMAIL PROTECTED] wrote: On Thu, 24 Jan 2008, Dave Young wrote: Hi Dave ( others), Thanks. Thanks a lot, I was first to ignore all these because they occurred with newreno, but looked again... :-/ New warning trigged with your debug patch: This

Re: [PATCH] SMC91x: don't flag spurious interrupts when polling

2008-01-24 Thread Nicolas Pitre
On Thu, 24 Jan 2008, Kevin Hilman wrote: When using polling, smc_poll_controller() can call smc_interrupt() when there are likely to be no real interrups. This will trigger the spurious interrupt printk whenever the driver is being polled. This adds an 'is_polling' flags, and doesn't

[PATCH] SMC91x: don't flag spurious interrupts when polling

2008-01-24 Thread Kevin Hilman
When using polling, smc_poll_controller() can call smc_interrupt() when there are likely to be no real interrups. This will trigger the spurious interrupt printk whenever the driver is being polled. This adds an 'is_polling' flags, and doesn't trigger the spurious warning when in polling mode.

[PATCH] phylib: Add Realtek 821x eth PHY support

2008-01-24 Thread Kim Phillips
this PHY present on the MPC8315E and MPC837xE RDB boards. Signed-off-by: Johnson Leung [EMAIL PROTECTED] Signed-off-by: Kevin Lam [EMAIL PROTECTED] Signed-off-by: Joe D'Abbraccio [EMAIL PROTECTED] Signed-off-by: Kim Phillips [EMAIL PROTECTED] --- drivers/net/phy/Kconfig |5 +++

RE: [PATCH 2.6.25 1/1]S2io: Multiqueue network device support implementation

2008-01-24 Thread Ramkrishna Vepa
[Ram] I am assuming that this is with regards to msi-x interrupts. We Yes. And avoiding bouncing locks for device state between CPUs. have done away with handling tx completion in the interrupt handler, and are instead handling them in the context of the transmit. The slow path,

RE: [PATCH 2.6.25 1/1]S2io: Multiqueue network device support implementation

2008-01-24 Thread Ramkrishna Vepa
From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] On Behalf Of David Miller Sent: Wednesday, January 23, 2008 11:30 PM From: Andi Kleen [EMAIL PROTECTED] Date: Thu, 24 Jan 2008 08:25:49 +0100 have done away with handling tx completion in the interrupt handler, and are instead

Re: [PATCH v2] PS3: gelic: Add wireless support for PS3

2008-01-24 Thread John W. Linville
On Thu, Jan 24, 2008 at 08:49:45PM -0500, Dan Williams wrote: On Thu, 2008-01-24 at 14:51 +0900, Masakazu Mokuno wrote: Hi PS3: gelic: Add wireless support for PS3 This is the version 2 of the re-worked (rewritten) version of the wireless support driver for PS3. The version 1 of

Re: [PATCH 09/26] atl1: refactor tx processing

2008-01-24 Thread Jeff Garzik
Jay Cliburn wrote: On Tue, 22 Jan 2008 18:31:09 -0600 Jay Cliburn [EMAIL PROTECTED] wrote: On Tue, 22 Jan 2008 04:58:17 -0500 Jeff Garzik [EMAIL PROTECTED] wrote: [...] for such a huge patch, this description is very tiny. [describe] what is refactored, and why. Is this one any better?

Re: [PATCH v2] PS3: gelic: Add wireless support for PS3

2008-01-24 Thread Masakazu Mokuno
On Thu, 24 Jan 2008 21:47:25 -0500 John W. Linville [EMAIL PROTECTED] wrote: On Thu, Jan 24, 2008 at 08:49:45PM -0500, Dan Williams wrote: On Thu, 2008-01-24 at 14:51 +0900, Masakazu Mokuno wrote: Hi PS3: gelic: Add wireless support for PS3 This is the version 2 of the

RE: [PATCH UCC TDM 3/3 ] Modified Documentation to explain dtsentries for TDM driver

2008-01-24 Thread Aggrwal Poonam
Hi Scott The device tree already has a brg-frequency property in qe node which is the value of BRGCLK. The function get_brg_clk uses this property to find the value of BRGCLK. In case this value is 0(some older u-boots populate bus-frequency property of qe and not the brg-frequency), get_brg_clk

Re: pull request: wireless-2.6 'upstream' 2008-01-24

2008-01-24 Thread John W. Linville
On Thu, Jan 24, 2008 at 02:53:43PM -0500, John W. Linville wrote: The cfg80211 API change breaks ath5k, so I have listed it as depends on BROKEN. I am assured that the ath5k team has agreed to fix this ASAP. Meanwhile we wanted to have it in place so that we can start shaking-out problems

RE: [PATCH UCC TDM 1/3 Updated] Platform changes for UCC TDM driver for MPC8323eRDB. Also includes related QE changes and dts entries.

2008-01-24 Thread Aggrwal Poonam
Hello Anton/Tabi I am not sure which is the best place to configure the pins. Because some drivers do it in one way and some in the other. I actually tried to make the driver similar to ucc_geth because it is a QE driver. The driver has no platform code in the platform files similar to ucc_geth.

Re: pull request: wireless-2.6 'upstream' 2008-01-24

2008-01-24 Thread David Miller
From: John W. Linville [EMAIL PROTECTED] Date: Thu, 24 Jan 2008 22:57:51 -0500 On Thu, Jan 24, 2008 at 02:53:43PM -0500, John W. Linville wrote: The cfg80211 API change breaks ath5k, so I have listed it as depends on BROKEN. I am assured that the ath5k team has agreed to fix this ASAP.

Re: bluetooth : lockdep warning on rfcomm

2008-01-24 Thread Dave Young
On Jan 24, 2008 5:25 PM, Dave Young [EMAIL PROTECTED] wrote: On Jan 24, 2008 11:02 AM, Dave Young [EMAIL PROTECTED] wrote: = [ INFO: possible recursive locking detected ] 2.6.24-rc8-mm1 #8 -

[PATCH] SMC91x: poll_controller(): check for interrupts before calling handler

2008-01-24 Thread Kevin Hilman
When using polling, smc_poll_controller() can call smc_interrupt() when there are likely to be no real interrups. This will trigger the spurious interrupt printk whenever the driver is being polled. Instead, check for actual interrupts before calling smc_interrupt() Signed-off-by: Kevin Hilman