Re: [PATCH 1/4] rcu_assign_pointer: null check fix

2008-02-13 Thread Jarek Poplawski
On 13-02-2008 01:50, Stephen Hemminger wrote: ... --- a/include/linux/rcupdate.h2008-02-12 14:46:49.0 -0800 +++ b/include/linux/rcupdate.h2008-02-12 14:56:17.0 -0800 @@ -178,7 +178,7 @@ struct rcu_head { #define rcu_assign_pointer(p, v) \

Re: [PATCH] [IPROUTE2] Update various classifiers' help output for expected CLASSID syntax

2008-02-13 Thread Jarek Poplawski
On 12-02-2008 22:51, PJ Waskiewicz wrote: This updates the help output to specify that CLASSID should be hexidecimal. ... + fprintf(stderr, \nNOTE: CLASSID is parsed as hexidecimal input.\n); s/hexidecimal/hexadecimal/g (?) Regards, Jarek P. -- To unsubscribe from this list: send the line

Re: BUG: 2.6.25-rc1: iptables postrouting setup causes oops

2008-02-13 Thread Andrew Morton
On Tue, 12 Feb 2008 22:46:01 +1100 Ben Nizette [EMAIL PROTECTED] wrote: On an AVR32, root over NFS, config attached, running (from a startup script): iptables -t nat -A POSTROUTING -o eth0 -j MASQUERADE Results in (dmesg extract including a bit of context for good measure):

Re: RESEND, HTB(?) softlockup, vanilla 2.6.24

2008-02-13 Thread Jarek Poplawski
On 13-02-2008 09:13, Denys Fedoryshchenko wrote: It is very difficult to reproduce, happened after running about 1month. No changes done in classes at time of crash. Kernel 2.6.24 vanilla I will try to attach also .config Hi Denys, This report looks very interesting. I don't know how

Re: BUG: 2.6.25-rc1: iptables postrouting setup causes oops

2008-02-13 Thread Haavard Skinnemoen
On Wed, 13 Feb 2008 00:48:29 -0800 Andrew Morton [EMAIL PROTECTED] wrote: On Tue, 12 Feb 2008 22:46:01 +1100 Ben Nizette [EMAIL PROTECTED] wrote: On an AVR32, root over NFS, config attached, running (from a startup script): iptables -t nat -A POSTROUTING -o eth0 -j MASQUERADE

[PATCH] [IPV6]: Fix hardcoded removing of old module code

2008-02-13 Thread Wang Chen
Rusty hardcoded the old module code. We can remove it now. Signed-off-by: Wang Chen [EMAIL PROTECTED] --- net/ipv6/af_inet6.c |8 1 files changed, 0 insertions(+), 8 deletions(-) diff --git a/net/ipv6/af_inet6.c b/net/ipv6/af_inet6.c index bddac0e..f0aa977 100644 ---

Re: BUG: 2.6.25-rc1: iptables postrouting setup causes oops

2008-02-13 Thread Andrew Morton
On Wed, 13 Feb 2008 10:10:24 +0100 Haavard Skinnemoen [EMAIL PROTECTED] wrote: On Wed, 13 Feb 2008 00:48:29 -0800 Andrew Morton [EMAIL PROTECTED] wrote: On Tue, 12 Feb 2008 22:46:01 +1100 Ben Nizette [EMAIL PROTECTED] wrote: On an AVR32, root over NFS, config attached, running

Re: [ofa-general] [PATCH 2.6.25] RDMA/cxgb3: Fail loopbackconnections.

2008-02-13 Thread Diego Guella
One question below - Original Message - From: Roland Dreier [EMAIL PROTECTED] To: Steve Wise [EMAIL PROTECTED] Cc: netdev@vger.kernel.org; [EMAIL PROTECTED]; [EMAIL PROTECTED] Sent: Wednesday, February 13, 2008 1:26 AM Subject: Re: [ofa-general] [PATCH 2.6.25] RDMA/cxgb3: Fail

Re: [PATCH] [IRDA] irda_init() nuke useless debug printk

2008-02-13 Thread maximilian attems
On Tue, 12 Feb 2008, David Miller wrote: From: maximilian attems [EMAIL PROTECTED] Date: Tue, 12 Feb 2008 11:30:47 +0100 irda_init() dmesg line is not really informative, thus remove it. There are better ways to know that a module is loaded. Seen on a debian config with IRDA_DEBUG

[PATCH 2/2][NETLABEL]: Move some initialization code into __init section.

2008-02-13 Thread Pavel Emelyanov
Everything that is called from netlbl_init() can be marked with __init. This moves 620 bytes from .text section to .text.init one. Signed-off-by: Pavel Emelyanov [EMAIL PROTECTED] --- net/netlabel/netlabel_cipso_v4.c |2 +- net/netlabel/netlabel_domainhash.c |2 +-

Re: BUG: 2.6.25-rc1: iptables postrouting setup causes oops

2008-02-13 Thread Haavard Skinnemoen
On Wed, 13 Feb 2008 10:10:24 +0100 Haavard Skinnemoen [EMAIL PROTECTED] wrote: ip_tables: (C) 2000-2006 Netfilter Core Team nf_conntrack version 0.5.0 (1024 buckets, 4096 max) Unable to handle kernel paging request at virtual address d76a7138 ptbr = 91d3b000 pgd = e5f3 pte =

[PATCH 1/2][NETLABEL]: Shrink the genl-ops registration code.

2008-02-13 Thread Pavel Emelyanov
Turning them to array and registration in a loop saves 80 lines of code and ~300 bytes from text section. Signed-off-by: Pavel Emelyanov [EMAIL PROTECTED] --- net/netlabel/netlabel_cipso_v4.c | 43 +++ net/netlabel/netlabel_mgmt.c | 79 ++---

[PATCH][AX25] mkiss: ax_bump() locking fix

2008-02-13 Thread Jarek Poplawski
Hi, This is unchanged patch previously sent here for testing. I think it should be applied. Thanks, Jarek P. Subject: [PATCH][AX25] mkiss: ax_bump() locking fix According to one of OOPSes reported by Jann softirq can break while skb is prepared for netif_rx. The report isn't

[PATCH][AX25] ax25_out: check skb for NULL in ax25_kick()

2008-02-13 Thread Jarek Poplawski
Hi, Here is an official version of testing patch #2 from this thread. The only difference: ax25-vs is changed only after checking skb is not NULL (plus a comment). IMHO it could be applied. Thanks, Jarek P. Subject: [AX25] ax25_out: check skb for NULL in ax25_kick() According

Re: [PATCH 1/2][NETLABEL]: Shrink the genl-ops registration code.

2008-02-13 Thread Paul Moore
On Wednesday 13 February 2008 6:09:44 am Pavel Emelyanov wrote: Turning them to array and registration in a loop saves 80 lines of code and ~300 bytes from text section. Signed-off-by: Pavel Emelyanov [EMAIL PROTECTED] Definitely an improvement, thank you. Acked-by: Paul Moore [EMAIL

Re: [PATCH 2/2][NETLABEL]: Move some initialization code into __init section.

2008-02-13 Thread Paul Moore
On Wednesday 13 February 2008 6:12:06 am Pavel Emelyanov wrote: Everything that is called from netlbl_init() can be marked with __init. This moves 620 bytes from .text section to .text.init one. Signed-off-by: Pavel Emelyanov [EMAIL PROTECTED] I ran into problems with __init and __exit once

Re: [PATCH] drivers/base: export gpl (un)register_memory_notifier

2008-02-13 Thread Jan-Bernd Themann
Hi Dave, On Monday 11 February 2008 17:47, Dave Hansen wrote: Also, just ripping down and completely re-doing the entire mass of cards every time a 16MB area of memory is added or removed seems like an awfully big sledgehammer to me. I would *HATE* to see anybody else using this driver as an

[PATCH] ehea: add kdump support

2008-02-13 Thread Thomas Klein
This patch adds kdump support to the ehea driver. As the firmware doesn't free resource handles automatically, the driver has to run an as simple as possible free resource function in case of a crash shutdown. The function iterates over two arrays freeing all resource handles which are stored

Re: [ofa-general] [PATCH 2.6.25] RDMA/cxgb3: Fail loopbackconnections.

2008-02-13 Thread Roland Dreier
how can a static void function return 0? good question... I've fixed the patch in my tree. -- To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [ofa-general] [PATCH 2.6.25] RDMA/cxgb3: Fail loopbackconnections.

2008-02-13 Thread Steve Wise
Roland Dreier wrote: how can a static void function return 0? good question... I've fixed the patch in my tree. oops. -- To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at

Re: [ofa-general] [PATCH 2.6.25] RDMA/cxgb3: Fail loopbackconnections.

2008-02-13 Thread Roland Dreier
Steve, I had to update the patch adding an include and fixing the function declaration (as below)... but how much testing have you done with this?? commit 8704e9a8790cc9e394198663c1c9150c899fb9a2 Author: Steve Wise [EMAIL PROTECTED] Date: Tue Feb 12 16:09:29 2008 -0600 RDMA/cxgb3: Fail

Re: [ofa-general] [PATCH 2.6.25] RDMA/cxgb3: Fail loopbackconnections.

2008-02-13 Thread Steve Wise
Roland Dreier wrote: Steve, I had to update the patch adding an include and fixing the function declaration (as below)... but how much testing have you done with this?? Now I understand. I thought I'd fixed these! I fixed them locally in the test tree on my victim and then tested, but

Re: [PATCH] ixgbe: Correctly obtain protocol information on transmit

2008-02-13 Thread Andy Gospodarek
On Tue, Feb 12, 2008 at 03:20:33PM -0800, Auke Kok wrote: In reply to RE: [Fwd: [PATCH 2.6.25] ixgbe/igb: correctly obtain protocol information on transmit] from Andy Gospodarek: The driver was incorrectly looking at socket headers for protocol information, needed for checksumming offload.

[PATCh TAKE 2] [IPROUTE2] Add addrlabel sub-command.

2008-02-13 Thread YOSHIFUJI Hideaki / 吉藤英明
Signed-off-by: YOSHIFUJI Hideaki [EMAIL PROTECTED] --- diff --git a/ip/Makefile b/ip/Makefile index b427d58..d908817 100644 --- a/ip/Makefile +++ b/ip/Makefile @@ -1,4 +1,4 @@ -IPOBJ=ip.o ipaddress.o iproute.o iprule.o \ +IPOBJ=ip.o ipaddress.o ipaddrlabel.o iproute.o iprule.o \ rtm_map.o

Re: [ofa-general] [PATCH 2.6.25] RDMA/cxgb3: Fail loopbackconnections.

2008-02-13 Thread Steve Wise
Steve Wise wrote: Roland Dreier wrote: Steve, I had to update the patch adding an include and fixing the function declaration (as below)... but how much testing have you done with this?? Now I understand. I thought I'd fixed these! I fixed them locally in the test tree on my victim and

Re: BUG: 2.6.25-rc1: iptables postrouting setup causes oops

2008-02-13 Thread Andrew G. Morgan
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Haavard, It means your application is not capable(sic) of using the upper 32-bits of the 64-bit capability sets supported by this newer kernel. You might consider rebuilding the offending application linking it against a newer version of libcap:

RE: r8169 auto-negotiation problem

2008-02-13 Thread fgnijuhhu guduggurehug
Thanks for your response. Please try a recent kernel. Your r8169 driver is badly outdated. OK. Now using 2.6.24-1-amd64. The r8169 version still says 2.2LK-NAPI, though. _ Express yourself instantly with MSN Messenger! Download

Re: [PATCH 1/3][NETLABEL]: Compilation for CONFIG_AUDIT=n case.

2008-02-13 Thread Paul Moore
On Wednesday 13 February 2008 1:35:44 am David Miller wrote: From: Pavel Emelyanov [EMAIL PROTECTED] Date: Thu, 07 Feb 2008 20:20:30 +0300 The audit_log_start() will expand into an empty do { } while (0) construction and the audit_ctx becomes unused. The solution: push

Re: [RFC, PATCH]: Pass link level header from/to PPP interface

2008-02-13 Thread Urs Thuermann
Hello Dave, But if libpcap and tcpdump can already identify PPP packets then, besides consistency, what does this buy us other than potential breakage? My reason for the patch is mostly cleanliness and to make the kernel match what is described in packet(7). If you open a PF_PACKET/SOCK_RAW

Re: [PATCH] drivers/base: export gpl (un)register_memory_notifier

2008-02-13 Thread Dave Hansen
On Wed, 2008-02-13 at 16:17 +0100, Jan-Bernd Themann wrote: Constraints imposed by HW / FW: - eHEA has own MMU - eHEA Memory Regions (MRs) are used by the eHEA MMU to translate virtual addresses to absolute addresses (like DMA mapped memory on a PCI bus) - The number of MRs is limited

RE: [PATCH] [IPROUTE2] Update various classifiers' help output forexpected CLASSID syntax

2008-02-13 Thread Waskiewicz Jr, Peter P
+ fprintf(stderr, \nNOTE: CLASSID is parsed as hexidecimal +input.\n); s/hexidecimal/hexadecimal/g (?) Gah! Thanks Jarek, I can correct and resend. -PJ Waskiewicz -- To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More

[PATCH] [IPROUTE2] Update various classifiers' help output for expected CLASSID syntax

2008-02-13 Thread PJ Waskiewicz
update: Fix the spelling of hexidecimal This updates the help output to specify that CLASSID should be hexidecimal. This makes sure that a user entering flowid 1:10 gets his flow put into band 15 (0x10) and knows why. Signed-off-by: Peter P Waskiewicz Jr [EMAIL PROTECTED] ---

[PATCH] [NET 2.6.26]: Add per-connection option to set max TSO frame size

2008-02-13 Thread PJ Waskiewicz
Update: changed max_gso_frame_size and sk_gso_max_size from signed to unsigned - thanks Stephen! This patch adds the ability for device drivers to control the size of the TSO frames being sent to them, per TCP connection. By setting the netdevice's max_gso_frame_size value, the socket layer will

Re: BUG: 2.6.25-rc1: iptables postrouting setup causes oops

2008-02-13 Thread Haavard Skinnemoen
On Wed, 13 Feb 2008 08:42:15 -0800 Andrew G. Morgan [EMAIL PROTECTED] wrote: However, it is a warning and, for any existing app that doesn't care about newly added capabilities, the warning is benign. Ok, I see. Thanks for explaining. Haavard -- To unsubscribe from this list: send the line

Patch to latest iproute to get it to compile on FC5

2008-02-13 Thread Ben Greear
I notice that the latest snapshot and git repository for iproute will not compile on FC5 due to not finding __constant_hton* symbols and a lack of the hdlc/ioctl.h file on FC5. I am attaching a patch that appears to fix the problems for me. Please consider applying this or something similar.

[PATCH 1/3] fib_trie: move statistics to debugfs

2008-02-13 Thread Stephen Hemminger
Don't want /proc/net/fib_trie and /proc/net/fib_triestat to become permanent kernel space ABI issues, so move to the safer confines of debugfs. Signed-off-by: Stephen Hemminger [EMAIL PROTECTED] --- net/ipv4/Kconfig|9 ++- net/ipv4/fib_trie.c | 127

[PATCH 3/3] fib_trie: print statistics for multiple tables

2008-02-13 Thread Stephen Hemminger
Make debugfs/fib/trie and debugfs/fib/triestat handle multiple (alternate) route tables. Note: this usage of seq_file doesn't need/want SEQ_START_TOKEN Signed-off-by: Stephen Hemminger [EMAIL PROTECTED] --- a/net/ipv4/fib_trie.c 2008-02-13 11:41:23.0 -0800 +++

64bit counters: iproute(netlink) vs ifconfig

2008-02-13 Thread Krzysztof Oledzki
Hello, Just discovered that counters returned by the ip tool are truncated: # ip -s link show bond0 1: bond0: BROADCAST,MULTICAST,MASTER,UP,LOWER_UP mtu 1500 qdisc noqueue link/ether 00:1d:09:67:6e:2f brd ff:ff:ff:ff:ff:ff RX: bytes packets errors dropped overrun mcast 2485605521

Re: Patch to latest iproute to get it to compile on FC5

2008-02-13 Thread Stephen Hemminger
On Wed, 13 Feb 2008 11:32:32 -0800 Ben Greear [EMAIL PROTECTED] wrote: I notice that the latest snapshot and git repository for iproute will not compile on FC5 due to not finding __constant_hton* symbols and a lack of the hdlc/ioctl.h file on FC5. I am attaching a patch that appears to fix

[PATCH 2/3] fib_trie: improve output format for /proc/net/fib_trie

2008-02-13 Thread Stephen Hemminger
Make output format prettier (more tree like). local: --- 0.0.0.0/0 |--- 10.111.111.0/24 | +-- 10.111.111.0/32 link broadcast | |--- 10.111.111.254/31 | | +-- 10.111.111.254/32 host local | | +-- 10.111.111.255/32 link broadcast |--- 127.0.0.0/8 |

[PATCH 0/3] fib_trie: update (redo)

2008-02-13 Thread Stephen Hemminger
This supersedes yesterday's changes. It doesn't change list.h because that seems to make people queasy, even if it is a clone of existing code. Moves the trie related special files to debugfs. -- Stephen Hemminger [EMAIL PROTECTED] -- To unsubscribe from this list: send the line unsubscribe

Re: Patch to latest iproute to get it to compile on FC5

2008-02-13 Thread Ben Greear
Stephen Hemminger wrote: On Wed, 13 Feb 2008 11:32:32 -0800 Ben Greear [EMAIL PROTECTED] wrote: I notice that the latest snapshot and git repository for iproute will not compile on FC5 due to not finding __constant_hton* symbols and a lack of the hdlc/ioctl.h file on FC5. I am attaching a

Re: [PATCh TAKE 2] [IPROUTE2] Add addrlabel sub-command.

2008-02-13 Thread Stephen Hemminger
On Thu, 14 Feb 2008 03:20:12 +1100 (EST) YOSHIFUJI Hideaki / 吉藤英明 [EMAIL PROTECTED] wrote: Signed-off-by: YOSHIFUJI Hideaki [EMAIL PROTECTED] --- diff --git a/ip/Makefile b/ip/Makefile index b427d58..d908817 100644 --- a/ip/Makefile +++ b/ip/Makefile @@ -1,4 +1,4 @@ -IPOBJ=ip.o

Re: 64bit counters: iproute(netlink) vs ifconfig

2008-02-13 Thread Stephen Hemminger
On Wed, 13 Feb 2008 21:20:59 +0100 (CET) Krzysztof Oledzki [EMAIL PROTECTED] wrote: Hello, Just discovered that counters returned by the ip tool are truncated: # ip -s link show bond0 1: bond0: BROADCAST,MULTICAST,MASTER,UP,LOWER_UP mtu 1500 qdisc noqueue link/ether

Re: Patch to latest iproute to get it to compile on FC5

2008-02-13 Thread Stephen Hemminger
On Wed, 13 Feb 2008 11:32:32 -0800 Ben Greear [EMAIL PROTECTED] wrote: I notice that the latest snapshot and git repository for iproute will not compile on FC5 due to not finding __constant_hton* symbols and a lack of the hdlc/ioctl.h file on FC5. I am attaching a patch that appears to fix

Re: [PATCH] [IPROUTE2] Update various classifiers' help output for expected CLASSID syntax

2008-02-13 Thread Stephen Hemminger
On Wed, 13 Feb 2008 03:49:09 -0800 PJ Waskiewicz [EMAIL PROTECTED] wrote: update: Fix the spelling of hexidecimal This updates the help output to specify that CLASSID should be hexidecimal. This makes sure that a user entering flowid 1:10 gets his flow put into band 15 (0x10) and knows why.

[PATCH] [resend] 3c509: convert to isa_driver and pnp_driver v5

2008-02-13 Thread Ondrej Zary
Hello, this patch converts 3c509 driver to isa_driver and pnp_driver. The result is that autoloading using udev and hibernation works with ISA PnP cards. It also adds hibernation support for non-PnP ISA cards. xcvr module parameter was removed as its value was not used. Tested using 3 ISA

[2.6 patch] unexport __inet_hash_connect

2008-02-13 Thread Adrian Bunk
This patch removes the unused EXPORT_SYMBOL_GPL(__inet_hash_connect). Signed-off-by: Adrian Bunk [EMAIL PROTECTED] --- ffa30930d4ba630514fd93ded245456f05358140 diff --git a/net/ipv4/inet_hashtables.c b/net/ipv4/inet_hashtables.c index 9cac6c0..e6a0072 100644 --- a/net/ipv4/inet_hashtables.c +++

[2.6 patch] unexport inet_listen_wlock

2008-02-13 Thread Adrian Bunk
This patch removes the no linger used EXPORT_SYMBOL(inet_listen_wlock). Signed-off-by: Adrian Bunk [EMAIL PROTECTED] --- 08c580a0a3219ce72f5c534c8868e75c4c224e01 diff --git a/net/ipv4/inet_hashtables.c b/net/ipv4/inet_hashtables.c index e6a0072..1aba606 100644 --- a/net/ipv4/inet_hashtables.c

[2.6 patch] make s2io.c:init_tti() static

2008-02-13 Thread Adrian Bunk
This patch makes the needlessly global init_tti() static. Signed-off-by: Adrian Bunk [EMAIL PROTECTED] --- This patch has been sent on: - 30 Jan 2008 1e8c2b07be955b181814e4c24366517a66557908 diff --git a/drivers/net/s2io.c b/drivers/net/s2io.c index 5fab7d7..bc94e84 100644 ---

RE: [2.6 patch] make s2io.c:init_tti() static

2008-02-13 Thread Ramkrishna Vepa
Please apply. Looks good. Ram -Original Message- From: Adrian Bunk [mailto:[EMAIL PROTECTED] Sent: Wednesday, February 13, 2008 1:31 PM To: Surjit Reang; Sreenivasa Honnur; Ramkrishna Vepa; Rastapur Santosh; Sivakumar Subramani Cc: netdev@vger.kernel.org; [EMAIL PROTECTED]

[PATCH 1/2] remove rcu_assign_pointer(NULL) penalty with type/macro safety

2008-02-13 Thread Paul E. McKenney
Hello! This is an updated version of the patch posted last November: http://archives.free.net.ph/message/20071201.003721.cd6ff17c.en.html This new version permits arguments with side effects, for example: rcu_assign_pointer(global_p, p++); and also verifies that the arguments

[PATCH 2/2] add rcu_assign_index() if ever needed

2008-02-13 Thread Paul E. McKenney
Hello again! This is a speculative patch that as far as I can tell is not yet required. If anyone applies RCU to a data structure allocated out of an array, using array indexes in place of pointers to link the array elements together, then the rcu_assign_index() function in this patch will be

Re: [PATCH 1/2] remove rcu_assign_pointer(NULL) penalty with type/macro safety

2008-02-13 Thread Andrew Morton
On Wed, 13 Feb 2008 14:00:24 -0800 Paul E. McKenney [EMAIL PROTECTED] wrote: Hello! This is an updated version of the patch posted last November: http://archives.free.net.ph/message/20071201.003721.cd6ff17c.en.html This new version permits arguments with side effects, for example:

Re: BUG: 2.6.25-rc1: iptables postrouting setup causes oops

2008-02-13 Thread Ben Nizette
On Wed, 2008-02-13 at 00:48 -0800, Andrew Morton wrote: On Tue, 12 Feb 2008 22:46:01 +1100 Ben Nizette [EMAIL PROTECTED] wrote: Perfectly repeatable. If my theory is correct, changing pretty much anything in the kernel config might just make it go away. But still, it would be most

Re: [PATCH 1/2] remove rcu_assign_pointer(NULL) penalty with type/macro safety

2008-02-13 Thread Paul E. McKenney
On Wed, Feb 13, 2008 at 02:35:37PM -0800, Stephen Hemminger wrote: On Wed, 13 Feb 2008 14:00:24 -0800 Paul E. McKenney [EMAIL PROTECTED] wrote: Hello! This is an updated version of the patch posted last November:

Re: [RFC, PATCH]: Pass link level header from/to PPP interface

2008-02-13 Thread David Miller
From: Urs Thuermann [EMAIL PROTECTED] Date: 13 Feb 2008 17:56:00 +0100 Do you consider this strong enough to justify this change? Can tcpdump and libpcap already handle PPP properly? -- To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED]

Re: [PATCH] fib_trie: rcu_assign_pointer warning fix

2008-02-13 Thread Paul E. McKenney
On Tue, Feb 12, 2008 at 08:46:30PM +0100, Jarek Poplawski wrote: On Tue, Feb 12, 2008 at 08:32:18PM +0100, Jarek Poplawski wrote: ... It seems the above version of this macro uses the barrier for 0, but if I miss something, or for these other: documenting reasons, ...or

Re: [PATCH 1/2] remove rcu_assign_pointer(NULL) penalty with type/macro safety

2008-02-13 Thread Paul E. McKenney
On Wed, Feb 13, 2008 at 02:42:33PM -0800, Stephen Hemminger wrote: On Wed, 13 Feb 2008 14:41:34 -0800 Paul E. McKenney [EMAIL PROTECTED] wrote: On Wed, Feb 13, 2008 at 02:35:37PM -0800, Stephen Hemminger wrote: On Wed, 13 Feb 2008 14:00:24 -0800 Paul E. McKenney [EMAIL PROTECTED]

Re: [PATCH 1/2] remove rcu_assign_pointer(NULL) penalty with type/macro safety

2008-02-13 Thread David Miller
From: Andrew Morton [EMAIL PROTECTED] Date: Wed, 13 Feb 2008 15:52:45 -0800 On Wed, 13 Feb 2008 15:37:44 -0800 Paul E. McKenney [EMAIL PROTECTED] wrote: Ah. It does take a bit to get fib_trie into one's build -- allyesconfig doesn't cut it. This is not good. The sole purpose of

Network namespace and tc?

2008-02-13 Thread Stephen Hemminger
It looks like tc filter won't work on alternate namespaces: /* Add/change/delete/get a filter node */ static int tc_ctl_tfilter(struct sk_buff *skb, struct nlmsghdr *n, void *arg) { ... if (net != init_net) return -EINVAL; Haven't played with namespace virtualization

Re: [PATCH 1/2] remove rcu_assign_pointer(NULL) penalty with type/macro safety

2008-02-13 Thread Andrew Morton
On Wed, 13 Feb 2008 15:37:44 -0800 Paul E. McKenney [EMAIL PROTECTED] wrote: Ah. It does take a bit to get fib_trie into one's build -- allyesconfig doesn't cut it. This is not good. The sole purpose of allmodconfig and allyesconfig is for compilation and linkage coverage testing. Hence we

Re: [PATCH 1/2] remove rcu_assign_pointer(NULL) penalty with type/macro safety

2008-02-13 Thread Stephen Hemminger
On Wed, 13 Feb 2008 15:37:44 -0800 Paul E. McKenney [EMAIL PROTECTED] wrote: On Wed, Feb 13, 2008 at 02:42:33PM -0800, Stephen Hemminger wrote: On Wed, 13 Feb 2008 14:41:34 -0800 Paul E. McKenney [EMAIL PROTECTED] wrote: On Wed, Feb 13, 2008 at 02:35:37PM -0800, Stephen Hemminger

Re: [PATCH 1/2] remove rcu_assign_pointer(NULL) penalty with type/macro safety

2008-02-13 Thread Stephen Hemminger
On Wed, 13 Feb 2008 15:52:45 -0800 Andrew Morton [EMAIL PROTECTED] wrote: On Wed, 13 Feb 2008 15:37:44 -0800 Paul E. McKenney [EMAIL PROTECTED] wrote: Ah. It does take a bit to get fib_trie into one's build -- allyesconfig doesn't cut it. This is not good. The sole purpose of

Re: [PATCH 1/2] remove rcu_assign_pointer(NULL) penalty with type/macro safety

2008-02-13 Thread Andrew Morton
On Wed, 13 Feb 2008 15:57:38 -0800 (PST) David Miller [EMAIL PROTECTED] wrote: From: Andrew Morton [EMAIL PROTECTED] Date: Wed, 13 Feb 2008 15:52:45 -0800 On Wed, 13 Feb 2008 15:37:44 -0800 Paul E. McKenney [EMAIL PROTECTED] wrote: Ah. It does take a bit to get fib_trie into one's

Re: [PATCH 1/2] remove rcu_assign_pointer(NULL) penalty with type/macro safety

2008-02-13 Thread Paul E. McKenney
On Wed, Feb 13, 2008 at 03:51:58PM -0800, Stephen Hemminger wrote: On Wed, 13 Feb 2008 15:37:44 -0800 Paul E. McKenney [EMAIL PROTECTED] wrote: On Wed, Feb 13, 2008 at 02:42:33PM -0800, Stephen Hemminger wrote: On Wed, 13 Feb 2008 14:41:34 -0800 Paul E. McKenney [EMAIL PROTECTED] wrote:

Re: [PATCH 1/2] remove rcu_assign_pointer(NULL) penalty with type/macro safety

2008-02-13 Thread Stephen Hemminger
On Wed, 13 Feb 2008 16:14:04 -0800 Paul E. McKenney [EMAIL PROTECTED] wrote: On Wed, Feb 13, 2008 at 03:51:58PM -0800, Stephen Hemminger wrote: On Wed, 13 Feb 2008 15:37:44 -0800 Paul E. McKenney [EMAIL PROTECTED] wrote: On Wed, Feb 13, 2008 at 02:42:33PM -0800, Stephen Hemminger wrote:

Re: [PATCH 1/2] remove rcu_assign_pointer(NULL) penalty with type/macro safety

2008-02-13 Thread Paul E. McKenney
On Wed, Feb 13, 2008 at 04:27:00PM -0800, Stephen Hemminger wrote: On Wed, 13 Feb 2008 16:14:04 -0800 Paul E. McKenney [EMAIL PROTECTED] wrote: On Wed, Feb 13, 2008 at 03:51:58PM -0800, Stephen Hemminger wrote: [ . . . ] Maybe cast both sides to void * in this case: static inline

[patch] Fix station address detection in smc

2008-02-13 Thread Chuck Ebbert
Megahertz EM1144 PCMCIA ethernet adapter needs special handling because it has two VERS_1 tuples and the station address is in the second one. Conversion to generic handling of these fields broke it. Reverting that fixes the device. https://bugzilla.redhat.com/show_bug.cgi?id=233255 Thanks go

Re: [PATCH][AX25] ax25_out: check skb for NULL in ax25_kick()

2008-02-13 Thread Jann Traschewski
Applied and stable with Kernel 2.6.24.2 since 12 hours. Regards, Jann -Ursprüngliche Nachricht- Von: Jarek Poplawski [mailto:[EMAIL PROTECTED] Gesendet: Mittwoch, 13. Februar 2008 12:56 An: David Miller Cc: Jann Traschewski; Bernard Pidoux F6BVP; Ralf Baechle;

Re: [PATCH 1/2] remove rcu_assign_pointer(NULL) penalty with type/macro safety

2008-02-13 Thread Stephen Hemminger
On Wed, 13 Feb 2008 16:42:53 -0800 Paul E. McKenney [EMAIL PROTECTED] wrote: On Wed, Feb 13, 2008 at 04:27:00PM -0800, Stephen Hemminger wrote: On Wed, 13 Feb 2008 16:14:04 -0800 Paul E. McKenney [EMAIL PROTECTED] wrote: On Wed, Feb 13, 2008 at 03:51:58PM -0800, Stephen Hemminger wrote:

[PATCH] Fix tcp_v4_send_synack() comment

2008-02-13 Thread Kris Katterjohn
Hey everyone, I've attached a patch that fixes the comment above tcp_v4_send_synack() in ipv4/tcp_ipv4.c. Signed-off-by: Kris Katterjohn [EMAIL PROTECTED] Thanks, Kris Katterjohn --- net/ipv4/tcp_ipv4.c 2008-02-10 23:51:11.0 -0600 +++ net/ipv4/tcp_ipv4.c 2008-02-13 18:31:44.0

Re: [PATCH 1/2] remove rcu_assign_pointer(NULL) penalty with type/macro safety

2008-02-13 Thread Paul E. McKenney
On Wed, Feb 13, 2008 at 04:53:56PM -0800, Stephen Hemminger wrote: On Wed, 13 Feb 2008 16:42:53 -0800 Paul E. McKenney [EMAIL PROTECTED] wrote: On Wed, Feb 13, 2008 at 04:27:00PM -0800, Stephen Hemminger wrote: [ . . . ] That is heading towards ugly... Maybe not using the macro at all

Re: [PATCH 1/2] remove rcu_assign_pointer(NULL) penalty with type/macro safety

2008-02-13 Thread Stephen Hemminger
On Wed, 13 Feb 2008 17:34:27 -0800 Paul E. McKenney [EMAIL PROTECTED] wrote: On Wed, Feb 13, 2008 at 04:53:56PM -0800, Stephen Hemminger wrote: On Wed, 13 Feb 2008 16:42:53 -0800 Paul E. McKenney [EMAIL PROTECTED] wrote: On Wed, Feb 13, 2008 at 04:27:00PM -0800, Stephen Hemminger wrote:

Re: [2.6 patch] unexport __inet_hash_connect

2008-02-13 Thread David Miller
From: Adrian Bunk [EMAIL PROTECTED] Date: Wed, 13 Feb 2008 23:29:46 +0200 This patch removes the unused EXPORT_SYMBOL_GPL(__inet_hash_connect). Signed-off-by: Adrian Bunk [EMAIL PROTECTED] Applied. -- To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to

Re: [2.6 patch] unexport inet_listen_wlock

2008-02-13 Thread David Miller
From: Adrian Bunk [EMAIL PROTECTED] Date: Wed, 13 Feb 2008 23:29:48 +0200 This patch removes the no linger used EXPORT_SYMBOL(inet_listen_wlock). Signed-off-by: Adrian Bunk [EMAIL PROTECTED] Applied. -- To unsubscribe from this list: send the line unsubscribe netdev in the body of a message

Dealing with limited resources and DMA Engine copies

2008-02-13 Thread Olof Johansson
Hi, My DMA Engine has a limited resource: It's got a descriptor ring, so it's not always possible to add a new descriptor to it (i.e. it might be full). While allocating a huge ring will help, eventually I'm sure I will hit a case where it'll overflow. I thought this was going to be taken care

[RFC] sky2: don't request unused i/o region

2008-02-13 Thread Stephen Hemminger
The sky2 driver only uses the PCI memory region (0) not the available I/O region. Some users want to use lots of boards, and the I/O space gets exhausted. Signed-off-by: Stephen Hemminger [EMAIL PROTECTED] --- a/drivers/net/sky2.c2008-02-13 18:58:21.0 -0800 +++

[PATCH 2.6.25] igb: fix legacy mode irq issue

2008-02-13 Thread Andy Gospodarek
I booted an igb kernel with the option pci=nomsi and instantly noticed that interrupts no longer worked on my igb device. I took a look at the interrupt initialization and quickly discovered a comment stating: DO NOT USE EIAME or IAME in legacy mode It seemed a bit odd that bits to enable IAM

Re: [PATCH 2/2] add rcu_assign_index() if ever needed

2008-02-13 Thread Andrew Morton
On Thu, 14 Feb 2008 09:02:09 +0530 Gautham R Shenoy [EMAIL PROTECTED] wrote: /** + * rcu_assign_index - assign (publicize) a index of a newly + * initialized array elementg that will be dereferenced by RCU I hope Andrew got that one while porting against

Re: Patch to latest iproute to get it to compile on FC5

2008-02-13 Thread Ben Greear
Here's another try at the patch to make the __constant_htonl methods be included, but without changing any of the .h files. I tested this on an FC2 system, and it compiles fine. Interesting to me, it seems you are not supposed to #include asm/byteorder.h directly, but when I tried the

Re: [RFC] sky2: don't request unused i/o region

2008-02-13 Thread Jeff Garzik
Stephen Hemminger wrote: The sky2 driver only uses the PCI memory region (0) not the available I/O region. Some users want to use lots of boards, and the I/O space gets exhausted. Signed-off-by: Stephen Hemminger [EMAIL PROTECTED] --- a/drivers/net/sky2.c2008-02-13 18:58:21.0