On Wed, 20 Feb 2008 15:47:18 +0200 Ilpo Järvinen [EMAIL PROTECTED] wrote:
vmlinux.o:
62 functions changed, 66 bytes added, 10935 bytes removed, diff: -10869
...+ these to lib/jhash.o:
jhash_3words: 112
jhash2: 276
jhash: 475
select for networking code might need a more fine-grained
On Wed, 20 Feb 2008 15:47:10 +0200 Ilpo J__rvinen [EMAIL PROTECTED] wrote:
Ok, here's the top of the list (1+ bytes):
This is good stuff - thanks.
-41525 2066 f, 3370 +, 44895 -, diff: -41525 IS_ERR
This is a surprise. I expect that the -mm-only
profile-likely-unlikely-macros.patch
(cc netdev)
On Wed, 20 Feb 2008 20:04:39 -0800 (PST) Giangiacomo Mariotti [EMAIL
PROTECTED] wrote:
This is what I got with dmesg :
[ 266.978695] WARNING: at net/ipv4/tcp_input.c:2054 tcp_mark_head_lost()
[ 266.978701] Pid: 0, comm: swapper Not tainted 2.6.24.2-my001 #1
[ 266.978703]
On Wed, 20 Feb 2008 15:46:19 +0100 Peter Zijlstra [EMAIL PROTECTED] wrote:
__GFP_MEMALLOC will allow the allocation to disregard the watermarks,
much like PF_MEMALLOC.
'twould be nice if the changelog had some explanation of the reason
for this change.
--
To unsubscribe from this list: send
On Wed, 20 Feb 2008 15:46:17 +0100 Peter Zijlstra [EMAIL PROTECTED] wrote:
@@ -213,7 +213,7 @@ enum zone_type {
struct zone {
/* Fields commonly accessed by the page allocator */
- unsigned long pages_min, pages_low, pages_high;
+ unsigned long
On Wed, 20 Feb 2008 15:46:15 +0100 Peter Zijlstra [EMAIL PROTECTED] wrote:
Allow PF_MEMALLOC to be set in softirq context. When running softirqs from
a borrowed context save current-flags, ksoftirqd will have its own
task_struct.
The second sentence doesn't make sense.
This is needed to
On Wed, 20 Feb 2008 15:46:10 +0100 Peter Zijlstra [EMAIL PROTECTED] wrote:
Another posting of the full swap over NFS series.
Well I looked. There's rather a lot of it and I wouldn't pretend to
understand it.
What is the NFS and net people's take on all of this?
--
To unsubscribe from this
On Wed, 20 Feb 2008 15:46:14 +0100 Peter Zijlstra [EMAIL PROTECTED] wrote:
Provide a method to get the upper bound on the pages needed to allocate
a given number of objects from a given kmem_cache.
This lays the foundation for a generic reserve framework as presented in
a later patch in
On Wed, 20 Feb 2008 15:46:18 +0100 Peter Zijlstra [EMAIL PROTECTED] wrote:
Change ALLOC_NO_WATERMARK page allocation such that the reserves are system
wide - which they are per setup_per_zone_pages_min(), when we scrape the
barrel, do it properly.
The changelog is fairly incomprehensible.
On Wed, 20 Feb 2008 15:46:25 +0100 Peter Zijlstra [EMAIL PROTECTED] wrote:
Provide the basic infrastructure to reserve and charge/account network memory.
We provide the following reserve tree:
1) total network reserve
2)network TX reserve
3) protocol TX pages
4)network RX
On Wed, 20 Feb 2008 15:46:27 +0100 Peter Zijlstra [EMAIL PROTECTED] wrote:
Change the skb allocation api to indicate RX usage and use this to fall back
to
the reserve when needed. SKBs allocated from the reserve are tagged in
skb-emergency.
Teach all other skb ops about emergency skbs and
On Wed, 20 Feb 2008 15:46:20 +0100 Peter Zijlstra [EMAIL PROTECTED] wrote:
Generic reserve management code.
It provides methods to reserve and charge. Upon this, generic alloc/free style
reserve pools could be build, which could fully replace mempool_t
functionality.
It should also
On Thu, 21 Feb 2008 19:00:03 +0100 Eric Dumazet [EMAIL PROTECTED] wrote:
+#ifndef cache_line_size
+#define cache_line_size()L1_CACHE_BYTES
+#endif
argh, you made me look.
Really cache_line_size() should be implemented in include/linux/cache.h.
Then we tromp the stupid private
On Friday 22 February 2008 09:26, Peter Zijlstra wrote:
On Thu, 2008-02-21 at 19:00 +0100, Eric Dumazet wrote:
Some oprofile results obtained while using tbench on a 2x2 cpu machine
were very surprising.
For example, loopback_xmit() function was using high number of cpu
cycles to
- Original Message -
From: Joonwoo Park [EMAIL PROTECTED]
To: Francesco Saverio Giudice [EMAIL PROTECTED]
Cc: netdev@vger.kernel.org
Sent: Saturday, February 23, 2008 7:44 AM
Subject: Re: Error on ip route replace command
Francesco,
It was fixed by
On Sat, 23 Feb 2008, Andrew Morton wrote:
On Wed, 20 Feb 2008 15:47:18 +0200 Ilpo Järvinen [EMAIL PROTECTED] wrote:
vmlinux.o:
62 functions changed, 66 bytes added, 10935 bytes removed, diff: -10869
...+ these to lib/jhash.o:
jhash_3words: 112
jhash2: 276
jhash: 475
On Sat, 23 Feb 2008, Andrew Morton wrote:
On Wed, 20 Feb 2008 15:47:10 +0200 Ilpo J__rvinen [EMAIL PROTECTED] wrote:
-41525 2066 f, 3370 +, 44895 -, diff: -41525 IS_ERR
This is a surprise.
It surprised me as well, there were something like 10 bytes I just
couldn't explain in IS_ERR
Andrew Morton [EMAIL PROTECTED] writes:
It should be possible to use a modular jhash.ko. The things which you
have identified as clients of the jhash library are usually loaded as modules.
For very small functions like this own modules are quite expensive. First
everything gets rounded up
Andrew Morton [EMAIL PROTECTED] writes:
-41525 2066 f, 3370 +, 44895 -, diff: -41525 IS_ERR
This is a surprise. I expect that the -mm-only
profile-likely-unlikely-macros.patch is the cause of this and mainline
doesn't have this problem.
Shouldn't they only have overhead when the
Use register offset definition for WOLcgClr. This patch does not
change the driver behaviour.
Signed-off-by: Laura Garcia Liebana [EMAIL PROTECTED]
modified: drivers/net/via-rhine.c
---
drivers/net/via-rhine.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git
Write Wake-on-LAN options in _real time_ not at shutdown. It might
be safe in case of power outage.
Signed-off-by: Laura Garcia Liebana [EMAIL PROTECTED]
modified: drivers/net/via-rhine.c
---
drivers/net/via-rhine.c | 76 +-
1 files
On Sat, 23 Feb 2008, Andi Kleen wrote:
Andrew Morton [EMAIL PROTECTED] writes:
-41525 2066 f, 3370 +, 44895 -, diff: -41525 IS_ERR
This is a surprise. I expect that the -mm-only
profile-likely-unlikely-macros.patch is the cause of this and mainline
doesn't have this problem.
On Sat, 23 Feb 2008 12:05:36 +0200 (EET) Ilpo Järvinen [EMAIL PROTECTED]
wrote:
On Sat, 23 Feb 2008, Andrew Morton wrote:
On Wed, 20 Feb 2008 15:47:18 +0200 Ilpo Järvinen [EMAIL PROTECTED]
wrote:
vmlinux.o:
62 functions changed, 66 bytes added, 10935 bytes removed, diff: -10869
On Sat, 23 Feb 2008 14:15:06 +0100 Andi Kleen [EMAIL PROTECTED] wrote:
Andrew Morton [EMAIL PROTECTED] writes:
-41525 2066 f, 3370 +, 44895 -, diff: -41525 IS_ERR
This is a surprise. I expect that the -mm-only
profile-likely-unlikely-macros.patch is the cause of this and mainline
so select it.
Signed-off-by: Sebastian Siewior [EMAIL PROTECTED]
---
drivers/net/Kconfig |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/drivers/net/Kconfig b/drivers/net/Kconfig
index f337800..a116056 100644
--- a/drivers/net/Kconfig
+++ b/drivers/net/Kconfig
@@ -2363,6
On Saturday 23 February 2008, Sebastian Siewior wrote:
so select it.
Signed-off-by: Sebastian Siewior [EMAIL PROTECTED]
---
drivers/net/Kconfig |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/drivers/net/Kconfig b/drivers/net/Kconfig
index f337800..a116056 100644
On Saturday 23 February 2008, Ivo van Doorn wrote:
On Saturday 23 February 2008, Sebastian Siewior wrote:
so select it.
Signed-off-by: Sebastian Siewior [EMAIL PROTECTED]
---
drivers/net/Kconfig |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git
Is there any reason they couldn't just be merged to mainline?
I think it's a useful facility.
ummm, now why did we made that decision... I think we decided that
it's the sort of thing which one person can run once per few months
and that will deliver its full value. I can maintain it
* Sebastian Siewior | 2008-02-23 21:06:37 [+0100]:
I add this to the patch desctiption and post a depends on patach
ARGH, this was CONFIG_WIRELESS_EXT and not MAC80211. You would like to
see a select or depend statement on that one?
Ivo
Sebastian
--
To unsubscribe from this list: send the line
On Saturday 23 February 2008, Sebastian Siewior wrote:
* Ivo van Doorn | 2008-02-23 20:50:34 [+0100]:
Additionally, what part of the driver actually uses mac80211?
I just browsed to the code, and it seems to work completely without
using mac80211. Instead it seems to work directly by
* Ivo van Doorn | 2008-02-23 20:44:59 [+0100]:
Is there any particular reason why this driver is in drivers/net instead
of drivers/net/wireless (along with all other wireless drivers?
My understanding is/was that the wireless device and the eth device are
exposed by the hypervisor to the system
* Ivo van Doorn | 2008-02-23 20:50:34 [+0100]:
Additionally, what part of the driver actually uses mac80211?
I just browsed to the code, and it seems to work completely without
using mac80211. Instead it seems to work directly by registering a
net_device structure...
CC
On Saturday 23 February 2008, Sebastian Siewior wrote:
* Sebastian Siewior | 2008-02-23 21:06:37 [+0100]:
I add this to the patch desctiption and post a depends on patach
ARGH, this was CONFIG_WIRELESS_EXT and not MAC80211. You would like to
see a select or depend statement on that one?
On Saturday 23 February 2008, Sebastian Siewior wrote:
* Ivo van Doorn | 2008-02-23 20:44:59 [+0100]:
Is there any particular reason why this driver is in drivers/net instead
of drivers/net/wireless (along with all other wireless drivers?
My understanding is/was that the wireless device
| CC drivers/net/ps3_gelic_wireless.o
| /home/bigeasy/git/linux-2.6/drivers/net/ps3_gelic_wireless.c: In function
'gelic_wl_setup_netdev_ops':
| /home/bigeasy/git/linux-2.6/drivers/net/ps3_gelic_wireless.c:2660: error:
'struct net_device' has no member named 'wireless_data'
|
Sebastian Siewior wrote:
so select it.
Signed-off-by: Sebastian Siewior [EMAIL PROTECTED]
---
drivers/net/Kconfig |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/drivers/net/Kconfig b/drivers/net/Kconfig
index f337800..a116056 100644
--- a/drivers/net/Kconfig
+++
* Jeff Garzik | 2008-02-23 15:26:07 [-0500]:
Given that this is straying clearly into wireless territory, I think the
linux-wireless folks and John Linville (wireless maintainer) are
appropriate patch targets.
Okey, I'm going to forward the pach.
Jeff
Sebastian
--
To unsubscribe
Is it possible to catch this automatically, like, by re-defining
likely/unlikely to the raw form in specific file(s)?
Sure it would be possible to define a IN_VDSO symbol in all vdso
related files and then do that. Might be useful for other things
too. vdso has some very specific requirements.
Hello,
I got a spinlock lockup using the latest Kernel 2.6.24.2 with recent
patches from Jarek Poplawski applied.
ppp_deflate nf_nat zlib_deflateBUG: unable to handle kernel NULL pointer
dereference zlib_inflate nf_conntrack_ipv4 bsd_comp slhc ppp_async xt_state
tun ppp_genericprinting eip:
From: Michael Chan [EMAIL PROTECTED]
Date: Fri, 22 Feb 2008 11:49:38 -0800
[BNX2]: More 5706S link down workaround.
The previous patches to workaround the 5706S on an HP blade were not
sufficient. The link state still does not change properly in some
cases. This patch adds polling to make
From: Michael Chan [EMAIL PROTECTED]
Date: Fri, 22 Feb 2008 11:50:11 -0800
[BNX2]: Disable parallel detect on an HP blade.
Because of some board issues, we need to disable parallel detect on
an HP blade. Without this patch, the link state can become stuck
when it goes into parallel detect
From: Michael Chan [EMAIL PROTECTED]
Date: Fri, 22 Feb 2008 11:50:32 -0800
[BNX2]: Update version to 1.7.4.
Signed-off-by: Michael Chan [EMAIL PROTECTED]
Also applied, thanks a lot.
--
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL
From: Michael Chan [EMAIL PROTECTED]
Date: Fri, 22 Feb 2008 11:16:42 -0800
On Fri, 2008-02-22 at 10:24 -0800, Stephen Hemminger wrote:
When asked to blink LEDs the tg3 driver behaves when using:
ethtool -p ethX
The default value for data is zero, and other drivers interpret this
as
From: Patrick McHardy [EMAIL PROTECTED]
Date: Fri, 22 Feb 2008 14:33:26 +0100
Thomas Graf wrote:
The reason I did it this way is to keep validate_linkmsg() generic
and make it possible to put validation code which must also apply
to new links (dev==NULL) into that function.
OK, thanks
From: Pavel Emelyanov [EMAIL PROTECTED]
Date: Fri, 22 Feb 2008 12:37:03 +0300
The neigh_hash_grow() may update the tbl-hash_rnd value, which
is used in all tbl-hash callbacks to calculate the hashval.
Two lookup routines may race with this, since they call the
-hash callback without the
From: Benjamin Herrenschmidt [EMAIL PROTECTED]
Date: Fri, 22 Feb 2008 09:50:27 +1100
I still think the change is obviously correct, so I'll give a second
close look at the code and produce a patch.
Patch coming soon? :)
--
To unsubscribe from this list: send the line unsubscribe netdev in
the
From: Phil Oester [EMAIL PROTECTED]
Date: Thu, 21 Feb 2008 14:05:42 -0800
diff --git a/net/core/dev.c b/net/core/dev.c
index 908f07c..999af2e 100644
--- a/net/core/dev.c
+++ b/net/core/dev.c
@@ -2905,6 +2905,7 @@ int __dev_addr_add(struct dev_addr_list **list, int
*count,
From: Jim Westfall [EMAIL PROTECTED]
Date: Thu, 21 Feb 2008 11:13:52 -0800
2) Second, skb_realloc_headroom() is called on 'skb' with
a second argument of 'dsize'.
This suggestion escapes me. The skb_put() call in the above
code would increase skb-tail. Wont skb_realloc_headroom()
From: Patrick McHardy [EMAIL PROTECTED]
Date: Thu, 21 Feb 2008 19:00:03 +0100
And adds back the overhead of two completely unnecessary
function calls to the VLAN fastpath. How about just
stopping this idiocy and reverting the appropriate patches
to bring back MAC_FMT and use it where
From: [EMAIL PROTECTED]
Date: Thu, 21 Feb 2008 17:51:50 +0100
Add more missing initializations of the new nl_info.nl_net field in
IPv6 stack.
This field will be used when network namespaces are fully supported.
Signed-off-by: Benjamin Thery [EMAIL PROTECTED]
Initializations to zero are
Any chance of getting this applied? It seems the build is still
broken on ia64 at least due to the export of static functions.
---
The libertas driver exports a number of symbols with no in-tree
users; remove these unused exports. lbs_reset_device() is completely
unused, with no callers at
From: Pavel Emelyanov [EMAIL PROTECTED]
Date: Thu, 21 Feb 2008 15:38:16 +0300
Changelog:
Use the added dev_alloc_name() call to create tunnel device name,
rather than iterate in a hand-made loop with an artificial limit.
Thanks Patrick for noticing this.
Signed-off-by: Pavel Emelyanov
From: Patrick McHardy [EMAIL PROTECTED]
Date: Thu, 21 Feb 2008 11:50:07 +0100
Good catch indeed, thanks.
Signed-off-by: Patrick McHardy [EMAIL PROTECTED]
Applied, thanks.
--
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL PROTECTED]
More
On Sat, 2008-02-23 at 19:58 -0800, David Miller wrote:
From: Benjamin Herrenschmidt [EMAIL PROTECTED]
Date: Fri, 22 Feb 2008 09:50:27 +1100
I still think the change is obviously correct, so I'll give a second
close look at the code and produce a patch.
Patch coming soon? :)
Yup, when
David Miller wrote:
From: Patrick McHardy [EMAIL PROTECTED]
Date: Thu, 21 Feb 2008 00:08:52 +0100
Ramkrishna Vepa wrote:
Sreenivasa Honnur wrote:
- Resubmit #2
- Transmit fifo selection based on TCP/UDP ports.
- Added tx_steering_type loadable parameter for transmit fifo
Laura Garcia wrote:
Use register offset definition for WOLcgClr. This patch does not
change the driver behaviour.
Signed-off-by: Laura Garcia Liebana [EMAIL PROTECTED]
modified: drivers/net/via-rhine.c
---
drivers/net/via-rhine.c |2 +-
1 files changed, 1 insertions(+), 1
Stephen Hemminger wrote:
Fix problems in LED management, so ethtool -p works correctly on Yukon-EC
and other chips. The driver was incorrectly setting the PHY LED overide bits.
Moral: read the spec sheet, not the vendor driver.
Signed-off-by: Stephen Hemminger [EMAIL PROTECTED]
---
Auke Kok wrote:
Signed-off-by: Auke Kok [EMAIL PROTECTED]
---
drivers/net/e1000e/netdev.c |2 --
1 files changed, 0 insertions(+), 2 deletions(-)
diff --git a/drivers/net/e1000e/netdev.c b/drivers/net/e1000e/netdev.c
index 7824bc2..fc5c63f 100644
--- a/drivers/net/e1000e/netdev.c
+++
On Sat, 2008-02-23 at 19:52 -0800, David Miller wrote:
From: Michael Chan [EMAIL PROTECTED]
Date: Fri, 22 Feb 2008 11:16:42 -0800
On Fri, 2008-02-22 at 10:24 -0800, Stephen Hemminger wrote:
When asked to blink LEDs the tg3 driver behaves when using:
ethtool -p ethX
The default
David Miller wrote:
Jeff, I really don't want to pull that tree in. Please trust me as
your upstream to handle merging issues, as needed.
I trust you... Otherwise I wouldn't have volunteered to move my
upstream from Linus to you :)
My main issues/motivations were:
* quite simply, just
This patch-set updates several sections of the bnx2x driver.
It is not appropriate to be adding features at this time
to the 2.6.25 tree.
Please wait for the opportunity to submit 2.6.26 bound
patches for new features.
I encourage you to split out just the bug fixes from this
series
From: Jeff Garzik [EMAIL PROTECTED]
Date: Sun, 24 Feb 2008 00:48:54 -0500
I trust you... Otherwise I wouldn't have volunteered to move my
upstream from Linus to you :)
...
So (as you saw in last email)... rebased and resend.
Thanks :)
--
To unsubscribe from this list: send the line
From: Eliezer Tamir [EMAIL PROTECTED]
Date: Sun, 24 Feb 2008 07:50:31 +0200
I will resubmit the bug fixes only.
Can I keep the spelling fixes in?
Sure.
--
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL PROTECTED]
More majordomo info at
On Sat, Feb 23, 2008 at 08:00:18PM -0800, David Miller wrote:
da is kzalloc()'d, how can da-da_synced not be zero?
Because it was originally kmalloc'd, not kzalloc'd. It was
fixed about 2 days prior to my patch submission, here:
http://marc.info/?l=linux-netdevm=120343348811767w=2
which I
On Wed, Feb 20, 2008 at 9:46 AM, Peter Zijlstra [EMAIL PROTECTED] wrote:
Provide the basic infrastructure to reserve and charge/account network memory.
...
Index: linux-2.6/net/core/sock.c
===
---
65 matches
Mail list logo
