From: Markus Elfring elfr...@users.sourceforge.net
The module_put() function tests whether its argument is NULL and then
returns immediately. Thus the test around the call is not needed.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring
please consider this cleanup from Markus Elfring
which removes a redundant check before calling module_put().
Markus Elfring (1):
net-ipvs: Delete an unnecessary check before the function call
module_put
net/netfilter/ipvs/ip_vs_sched.c | 2 +-
1 file changed, 1 insertion(+), 1
platform_driver does not need to set an owner because
platform_driver_register() will set it.
Signed-off-by: Krzysztof Kozlowski k.kozlow...@samsung.com
---
The coccinelle script which generated the patch was sent here:
http://www.spinics.net/lists/kernel/msg2029903.html
---
Thu, Jul 09, 2015 at 05:36:55PM CEST, jblu...@infradead.org wrote:
On Thu, Jul 9, 2015 at 12:07 PM, Jiri Pirko j...@resnulli.us wrote:
Thu, Jul 09, 2015 at 11:58:34AM CEST, jblu...@infradead.org wrote:
The code in net/ipv6/addrconf.c:addrconf_notify() tests for IFF_SLAVE to
decide if it should
David Miller wrote:
So we should look at a way at making the new behavior the default, and
in fact that makes sense and we can even optimize this piece of saddr
selection code to not do an iteration over all devices in the system
for no reason at all. It can just do a quick
If outgoing interface is specified and the candidate addresses
are restricted to the outgoing interface, it is enough to iterate
over that given interface only.
Signed-off-by: YOSHIFUJI Hideaki hideaki.yoshif...@miraclelinux.com
---
net/ipv6/addrconf.c | 201
On do, 2015-07-09 at 16:21 -0400, Roy Pledge wrote:
--- /dev/null
+++ b/drivers/soc/fsl/qbman/Kconfig
@@ -0,0 +1,33 @@
+menuconfig FSL_DPA
+ bool Freescale DPAA support
+ depends on FSL_SOC || COMPILE_TEST
Are you sure about COMPILE_TEST?
+ default n
+ help
+
On Fri, 10 Jul 2015, Stas Sergeev wrote:
10.07.2015 00:15, Florian Fainelli пишет:
Then, if the in-band status indication is not reliable (which really
should be completely understood),
Agree!
But this is not something I can help with.
Sebastien Rannou reports the problem, please ask him
On 07/10/2015 06:49 AM, Vineet Gupta wrote:
On Thursday 09 July 2015 11:55 PM, Arend van Spriel wrote:
On 07/09/2015 10:13 AM, Vineet Gupta wrote:
There's already a generic implementation so use that instead.
There is or there was? If there is now I am fine with this patch, but if
it already
On 10 July 2015 at 15:50, YOSHIFUJI Hideaki/吉藤英明
hideaki.yoshif...@miraclelinux.com wrote:
If outgoing interface is specified and the candidate addresses
are restricted to the outgoing interface, it is enough to iterate
over that given interface only.
Signed-off-by: YOSHIFUJI Hideaki
Hi,
Erik Kline wrote:
+ /* Candidate Source Address (section 4)
+* - multicast and link-local destination address,
+*the set of candidate source address MUST only
+*include addresses assigned to interfaces
+*belonging to the same link as
On 07/09/2015 05:15 PM, Vadim Kochan wrote:
On Thu, Jul 09, 2015 at 05:09:27PM +0200, Miha Marolt wrote:
On 07/09/2015 04:57 PM, Nikolay Aleksandrov wrote:
On 07/09/2015 04:55 PM, Vadim Kochan wrote:
On Thu, Jul 09, 2015 at 04:50:06PM +0200, Nikolay Aleksandrov wrote:
On 07/09/2015 04:13
On Fri, Jul 10, 2015 at 09:09:46AM +0200, Miha Marolt wrote:
On 07/09/2015 05:15 PM, Vadim Kochan wrote:
On Thu, Jul 09, 2015 at 05:09:27PM +0200, Miha Marolt wrote:
On 07/09/2015 04:57 PM, Nikolay Aleksandrov wrote:
On 07/09/2015 04:55 PM, Vadim Kochan wrote:
On Thu, Jul 09, 2015 at
If outgoing interface is specified and the candidate address is
restricted to the outgoing interface, it is enough to iterate
over that given interface only.
Signed-off-by: YOSHIFUJI Hideaki hideaki.yoshif...@miraclelinux.com
Acked-by: Erik Kline e...@google.com
---
net/ipv6/addrconf.c | 197
From: Kalesh Purayil kalesh.pura...@avagotech.com
This change will make be_setup_wol() routine more compact and readable
by removing some duplicate code.
Signed-off-by: Kalesh AP kalesh.pura...@avagotech.com
Signed-off-by: Sathya Perla sathya.pe...@avagotech.com
---
Hi David, the following patch set has code cleanup patches, minor enhancements
and non-critical fixes. Pls consider applying to the net-next tree. Thanks!
Patch 1 removes duplicate code in be_setup_wol() routine making it simpler
and more readable.
Patch 2 fixes the the bridge mode return value
From: Kalesh Purayil kalesh.pura...@avagotech.com
pci_enable_device() call sets device power state to D0; there is no need
doing it again.
Signed-off-by: Kalesh AP kalesh.pura...@avagotech.com
Signed-off-by: Sathya Perla sathya.pe...@avagotech.com
---
drivers/net/ethernet/emulex/benet/be_main.c
From: Suresh Reddy suresh.re...@emulex.com
The SET_LOOPBACK_MODE command is always issued from ethtool only in a
process context. So, while waiting for the cmd to complete, the driver
can sleep instead of holding spin_lock_bh() on the mcc_lock. This is done
by calling be_mcc_notify() instead of
From: Suresh Reddy suresh.re...@emulex.com
When the adapter is in error state, return error from be_mcc_notify()
so that the caller routines need not sleep waiting for a response.
Signed-off-by: Suresh Reddy suresh.re...@avagotech.com
Signed-off-by: Sathya Perla sathya.pe...@avagotech.com
---
From: Kalesh Purayil kalesh.pura...@avagotech.com
The current code assumes that bridge functionality (EVB) in the adapter
is enabled only when SR-IOV is enabled. This is not always true.
This patch uses the GET_HSW_CONFIG FW cmd to query this from the FW.
Signed-off-by: Kalesh AP
From: Vasundhara Volam vasundhara.vo...@avagotech.com
In the commit a6e6ff6eee12f3e
(be2net: simplify UFI compatibility checking), a return value of -1
was incorrectly used in place of false. This patch fixes it.
Fixes: a6e6ff6eee12f3e (be2net: simplify UFI compatibility checking)
Signed-off-by:
Signed-off-by: Sathya Perla sathya.pe...@avagotech.com
---
drivers/net/ethernet/emulex/benet/be.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/emulex/benet/be.h
b/drivers/net/ethernet/emulex/benet/be.h
index 8d12b41..cb5777b 100644
---
From: Venkat Duvvuru venkatkumar.duvv...@emulex.com
The dest field in the UDP-hdr of a TX skb is in network endian format.
Convert it to host endian before accessing it. The os2bmc patch,
mentioned below introduced this code.
Fixes: 760c295e0e8d (be2net: Support for OS2BMC)
Signed-off-by: Venkat
From: Suresh Reddy suresh.re...@avagotech.com
This fix makes the RX_FILTER cmd asynchronous, i.e., the caller issues
this cmd and doesn't wait for a completion from the FW. If the FW/adapter
is in an error state, this change helps in not holding up the rtnl_lock
and keeping bottom halves disabled
Reconsidering my commit 20462155 net: inet_diag: export IPV6_V6ONLY
sockopt, I am not happy with the limitations it causes for socket
analysing code in userspace. Exporting the value only if it is set makes
it hard for userspace to decide whether the option is not set or the
kernel does not
10.07.2015 11:46, Sebastien Rannou пишет:
On Fri, 10 Jul 2015, Stas Sergeev wrote:
10.07.2015 00:15, Florian Fainelli пишет:
Then, if the in-band status indication is not reliable (which really
should be completely understood),
Agree!
But this is not something I can help with.
Sebastien
This fixes race between non-atomic updates of adjacent bit-fields:
skb-cloned could be lost because netlink broadcast clones skb after
sending it to the first listener who sets skb-peeked at the same skb.
As a result atomic refcounting of skb header stays disabled and
skb_release_data() frees it
This patch clears skb-peeked set by previous recipient of broadcast.
Signed-off-by: Konstantin Khlebnikov khlebni...@yandex-team.ru
Fixes: add05ad4e9f5 (unix/dgram: peek beyond 0-sized skbs)
---
net/netlink/af_netlink.c |1 +
1 file changed, 1 insertion(+)
diff --git
On Thu, Jul 09, 2015 at 09:55:19PM +0200, Michael Tuexen wrote:
On 09 Jul 2015, at 18:54, Marcelo Ricardo Leitner mleit...@redhat.com
wrote:
Cc'ing Michael too.
I'm not familiar with the Linux kernel code, so I can't comment on it.
But making sure to use a source address belonging to
This patch clears skb-peeked set by previous recipient of broadcast.
Signed-off-by: Konstantin Khlebnikov khlebni...@yandex-team.ru
Fixes: add05ad4e9f5 (unix/dgram: peek beyond 0-sized skbs)
---
net/netlink/af_netlink.c |1 +
1 file changed, 1 insertion(+)
diff --git
On 10.07.2015 14:51, Konstantin Khlebnikov wrote:
This patch clears skb-peeked set by previous recipient of broadcast.
Signed-off-by: Konstantin Khlebnikov khlebni...@yandex-team.ru
Fixes: add05ad4e9f5 (unix/dgram: peek beyond 0-sized skbs)
---
net/netlink/af_netlink.c |1 +
1 file
On Thu, Jul 09, 2015 at 11:15:20AM -0300, Marcelo Ricardo Leitner wrote:
This patch reverts 2f2d76cc3e93 (dlm: Do not allocate a fd for
peeloff) but also takes benefit on an updated sockopt
SCTP_SOCKOPT_PEELOFF, which now avoids allocating file descriptors for
kernel users.
By this we avoid
On Wed, Jul 08, 2015 at 09:41:54PM +0200, Oleg Nesterov wrote:
Hello,
I am not familiar with this code and I have no idea how to test
these changes, so 2/2 comes as a separate change. 1/2 looks like
the obvious bugfix, and probably candidate for -stable.
Oleg.
net/core/pktgen.c |9
This patch fix a spelling typo found in API-z8530-sync-txdma-open.html.
It is because this file was generated from comment in source,
I have to fix comment in source.
Signed-off-by: Masanari Iida standby2...@gmail.com
---
drivers/net/wan/z85230.c | 2 +-
1 file changed, 1 insertion(+), 1
This reverts commit 3cc4949269e01f39443d0fcfffb5bc6b47878d45.
There is nothing wrong with coalescing during defragmentation, it
reduces truesize overhead and simplifies things for the receiving
socket (no fraglist walk needed).
However, it also destroys geometry of the original fragments.
While
On Fri, 2015-07-10 at 16:19 +0200, Thomas Graf wrote:
From: Roopa Prabhu ro...@cumulusnetworks.com
+ if (oif)
+ dev = __dev_get_by_index(net, oif);
+ ret = lwtunnel_build_state(dev, encap_type,
+encap, lwtstate);
+ if (!ret) {
+
Until now all user mdb entries were added in vlan 0, this patch adds
support to allow the user to specify the vlan for the entry.
About the uapi change a hole in struct br_mdb_entry is used so the size
and offsets are kept the same (verified with pahole and tested with older
iproute2).
Example:
$
On 07/10/2015 07:53 AM, Marcelo Ricardo Leitner wrote:
On Thu, Jul 09, 2015 at 09:55:19PM +0200, Michael Tuexen wrote:
On 09 Jul 2015, at 18:54, Marcelo Ricardo Leitner mleit...@redhat.com
wrote:
Cc'ing Michael too.
I'm not familiar with the Linux kernel code, so I can't comment on it.
But
On Thu, Jul 09, 2015 at 11:15:19AM -0300, Marcelo Ricardo Leitner wrote:
SCTP has this operation to peel off associations from a given socket and
create a new socket using this association. We currently have two ways
to use this operation:
- via getsockopt(), on which it will also create and
On do, 2015-07-09 at 16:21 -0400, Roy Pledge wrote:
--- /dev/null
+++ b/drivers/soc/fsl/qbman/Kconfig
+menuconfig FSL_DPA
+ bool Freescale DPAA support
+ depends on FSL_SOC || COMPILE_TEST
(I already commented on COMPILE_TEST in a separate mail.)
+ default n
+ help
+
On 08.07.2015 07:05, Mahesh Bandewar wrote:
On Fri, Jul 3, 2015 at 5:58 AM, Konstantin Khlebnikov
khlebni...@yandex-team.ru wrote:
Inet6addr notifier is atomic and runs in bh context without RTNL when
ipv6 receives router advertisement packet and performs autoconfiguration.
This patch adds
During driver probing the following code path is triggered.
igb_probe
-igb_sw_init
-igb_probe_vfs
-igb_pci_enable_sriov
-igb_sriov_reinit
Doing the SR-IOV re-init is not necessary during probing since we're
starting from scratch. Here we can call igb_enable_sriov() right away.
From: Roopa Prabhu ro...@cumulusnetworks.com
This patch introduces two new RTA attributes to attach encap
data to fib routes.
Example iproute2 command to attach mpls encap data to ipv4 routes
$ip route add 10.1.1.0/30 encap mpls 200 via inet 10.1.1.1 dev swp1
Signed-off-by: Roopa Prabhu
From: Roopa Prabhu ro...@cumulusnetworks.com
This patch adds support in ipv4 fib functions to parse user
provided encap attributes and attach encap state data to fib_nh
and rtable.
Signed-off-by: Roopa Prabhu ro...@cumulusnetworks.com
---
include/net/ip_fib.h | 5 ++-
include/net/route.h
From: Roopa Prabhu ro...@cumulusnetworks.com
This patch adds support in ipv6 fib functions to parse Netlink
RTA encap attributes and attach encap state data to rt6_info.
Signed-off-by: Roopa Prabhu ro...@cumulusnetworks.com
---
include/net/ip6_fib.h | 3 +++
net/ipv6/ip6_fib.c| 2 ++
From: Roopa Prabhu ro...@cumulusnetworks.com
This patch introduces lwtunnel_output function to call corresponding
lwtunnels output function to xmit the packet.
It adds two variants lwtunnel_output and lwtunnel_output6 for ipv4 and
ipv6 respectively today. But this is subject to change when
From: Roopa Prabhu ro...@cumulusnetworks.com
Provides infrastructure to parse/dump/store encap information for
light weight tunnels like mpls. Encap information for such tunnels
is associated with fib routes.
This infrastructure is based on previous suggestions from
Eric Biederman to follow the
This series combines the work previously posted by Roopa, Robert and
myself. It's according to what we discussed at NFWS. The series
accomplishes:
* Lightweight tunnel infrastructure to attach encapsulation
instructions to routes.
* Metadata dst to carry metadata between forwarding elements.
From: Roopa Prabhu ro...@cumulusnetworks.com
Signed-off-by: Roopa Prabhu ro...@cumulusnetworks.com
---
net/mpls/af_mpls.c | 11 ---
net/mpls/internal.h | 3 +++
2 files changed, 11 insertions(+), 3 deletions(-)
diff --git a/net/mpls/af_mpls.c b/net/mpls/af_mpls.c
index
On do, 2015-07-09 at 16:21 -0400, Roy Pledge wrote:
--- a/drivers/soc/fsl/qbman/Kconfig
+++ b/drivers/soc/fsl/qbman/Kconfig
+config FSL_DPA_PIRQ_FAST
+ bool
+ default y
First used in 04/11.
+config FSL_DPA_PIRQ_SLOW
+ bool
+ default y
+
+config FSL_DPA_PORTAL_SHARE
+
On Fri, 2015-07-10 at 14:51 +0300, Konstantin Khlebnikov wrote:
This fixes race between non-atomic updates of adjacent bit-fields:
skb-cloned could be lost because netlink broadcast clones skb after
sending it to the first listener who sets skb-peeked at the same skb.
As a result atomic
Allows putting a VXLAN device into a new flow-based mode in which it
will populate a ip_tunnel_info struct for each packet received and
attach it to the skb using the new metadata dst. The metadata structure
will contain the outer header and tunnel header fields which have been
stripped off.
This factors out the device configuration out of the RTNL newlink
API which allows for in-kernel creation of VXLAN net_devices.
Signed-off-by: Thomas Graf tg...@suug.ch
---
drivers/net/vxlan.c | 332
include/net/vxlan.h | 59 ++
2
This allows to get rid of the get_name() vport ops later on.
Signed-off-by: Thomas Graf tg...@suug.ch
---
net/openvswitch/datapath.c | 4 ++--
net/openvswitch/vport-internal_dev.c | 1 -
net/openvswitch/vport-netdev.c | 6 --
net/openvswitch/vport-netdev.h | 1 -
This add the ability to select a routing table based on the tunnel
id which allows to maintain separate routing tables for each virtual
tunnel network.
ip rule add from all tunnel-id 100 lookup 100
ip rule add from all tunnel-id 200 lookup 200
Signed-off-by: Thomas Graf tg...@suug.ch
---
This is the first step in representing all OVS vports as regular
struct net_devices. Move the net_device pointer into the vport
structure itself to get rid of struct vport_netdev.
Signed-off-by: Thomas Graf tg...@suug.ch
Signed-off-by: Pravin B Shelar pshe...@nicira.com
---
This gets rid of all OVS specific VXLAN code in the receive and
transmit path by using a VXLAN net_device to represent the vport.
Only a small shim layer remains which takes care of handling the
VXLAN specific OVS Netlink configuration.
Unexports vxlan_sock_add(), vxlan_sock_release(),
From: Pravin Shelar pshe...@nicira.com
Removes all of the OVS specific GRE code and makes OVS use a
GRE net_device.
Signed-off-by: Pravin B Shelar pshe...@nicira.com
---
net/core/dev.c | 5 +-
net/ipv4/ip_gre.c | 165 +-
This introduces a new IP tunnel lightweight tunnel type which allows
to specify IP tunnel instructions per route. Only IPv4 is supported
at this point.
Signed-off-by: Thomas Graf tg...@suug.ch
---
drivers/net/vxlan.c| 10 +++-
include/net/dst_metadata.h | 12 -
From: Roopa Prabhu ro...@cumulusnetworks.com
This is similar to ipv4 redirect of dst output to lwtunnel
output function for encapsulation and xmit.
Signed-off-by: Roopa Prabhu ro...@cumulusnetworks.com
---
net/ipv6/route.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/net/ipv6/route.c
Utilize the new metadata dst to attach encapsulation instructions to
the skb. The existing egress_tun_info via the OVS_CB() is left in
place until all tunnel vports have been converted to the new method.
Signed-off-by: Thomas Graf tg...@suug.ch
Signed-off-by: Pravin B Shelar pshe...@nicira.com
Add a new flowi_tunnel structure which is a subset of ip_tunnel_key to
allow routes to match on tunnel metadata. For now, the tunnel id is
added to flowi_tunnel which allows for routes to be bound to specific
virtual tunnels.
Signed-off-by: Thomas Graf tg...@suug.ch
---
include/net/flow.h | 7
From: Roopa Prabhu ro...@cumulusnetworks.com
This implementation uses lwtunnel infrastructure to register
hooks for mpls tunnel encaps.
It picks cues from iptunnel_encaps infrastructure and previous
mpls iptunnel RFC patches from Eric W. Biederman and Robert Shearman
Signed-off-by: Roopa Prabhu
Rename the tunnel metadata data structures currently internal to
OVS and make them generic for use by all IP tunnels.
Both structures are kernel internal and will stay that way. Their
members are exposed to user space through individual Netlink
attributes by OVS. It will therefore be possible to
Introduces a new dst_metadata which enables to carry per packet metadata
between forwarding and processing elements via the skb-dst pointer.
The structure is set up to be a union. Thus, each separate type of
metadata requires its own dst instance. If demand arises to carry
multiple types of
If output device wants to see the dst, inherit the dst of the
original skb and pass it on to generate the ARP request.
Signed-off-by: Thomas Graf tg...@suug.ch
---
net/ipv4/arp.c | 71 +++---
1 file changed, 43 insertions(+), 28 deletions(-)
From: Roopa Prabhu ro...@cumulusnetworks.com
For input routes with tunnel encap state this patch redirects
dst output functions to lwtunnel_output which later resolves to
the corresponding lwtunnel output function.
This has been tested to work with mpls ip tunnels.
Open items: Support for
On 10.07.2015 16:49, Eric Dumazet wrote:
On Fri, 2015-07-10 at 14:51 +0300, Konstantin Khlebnikov wrote:
This fixes race between non-atomic updates of adjacent bit-fields:
skb-cloned could be lost because netlink broadcast clones skb after
sending it to the first listener who sets skb-peeked at
In nohz_full mode, by default distribute networking shim
interrupts across the housekeeping cores, not all the cores.
Signed-off-by: Chris Metcalf cmetc...@ezchip.com
---
The alternate approaches to this might be:
1. #define housekeeping_mask cpu_online_mask in the non-nohz_full
arm in
Some of the local variable intializers in the driver turned out to be pointless,
kill them.
Signed-off-by: Sergei Shtylyov sergei.shtyl...@cogentembedded.com
---
The patch is against the Dave Miller's 'net-next.git' repo.
drivers/net/ethernet/renesas/ravb_main.c | 12 ++--
1 file
Hi Guenter,
On Jul 10, 2015, at 1:10 PM, Guenter Roeck li...@roeck-us.net wrote:
On Fri, Jul 10, 2015 at 12:57:28PM -0400, Vivien Didelot wrote:
The current _mv88e6xxx_stats_wait function does not sleep while testing
the stats busy bit. Fix this by using the generic _mv88e6xxx_wait
function.
On 10/07/15 04:20, Stas Sergeev wrote:
10.07.2015 11:46, Sebastien Rannou пишет:
On Fri, 10 Jul 2015, Stas Sergeev wrote:
10.07.2015 00:15, Florian Fainelli пишет:
Then, if the in-band status indication is not reliable (which really
should be completely understood),
Agree!
But this is not
On Fri, Jul 10, 2015 at 01:14:21PM -0400, Vlad Yasevich wrote:
On 07/10/2015 12:17 PM, Marcelo Ricardo Leitner wrote:
On Fri, Jul 10, 2015 at 11:35:28AM -0400, Vlad Yasevich wrote:
On 07/10/2015 07:53 AM, Marcelo Ricardo Leitner wrote:
On Thu, Jul 09, 2015 at 09:55:19PM +0200, Michael
return in_be32((void *)bm + offset);
^
[...]/drivers/soc/fsl/qbman/bman.c: In function ‘__bm_out’:
[...]/drivers/soc/fsl/qbman/bman.c:172:2: error: implicit declaration
of function ‘out_be32’ [-Werror=implicit-function-declaration]
out_be32((void *)bm + offset, val);
On Fri, Jul 10, 2015 at 01:33:44PM -0400, Chris Metcalf wrote:
In nohz_full mode, by default distribute networking shim
interrupts across the housekeeping cores, not all the cores.
I can't really tell, I have no idea what this driver does. It seems
to be about networking CPUs but I have no idea
Hi Vivien,
On Fri, Jul 10, 2015 at 02:20:47PM -0400, Vivien Didelot wrote:
is this really beneficial and/or needed ?
Except using existing generic code, no.
It adds at least 1ms delay to a loop which did not have any delay at
all unless the register read itself was sleeping.
I
On Fri, 2015-07-10 at 13:29 -0500, Pledge Roy-R01356 wrote:
return in_be32((void *)bm + offset);
^
[...]/drivers/soc/fsl/qbman/bman.c: In function ‘__bm_out’:
[...]/drivers/soc/fsl/qbman/bman.c:172:2: error: implicit declaration
of function ‘out_be32’
On Fri, 2015-07-10 at 10:38 +0200, Paul Bolle wrote:
On do, 2015-07-09 at 16:21 -0400, Roy Pledge wrote:
--- /dev/null
+++ b/drivers/soc/fsl/qbman/Kconfig
@@ -0,0 +1,33 @@
+menuconfig FSL_DPA
+ bool Freescale DPAA support
+ depends on FSL_SOC || COMPILE_TEST
Are you sure about
Some of the local variable intializers in the driver turned out to be pointless,
kill them.
Signed-off-by: Sergei Shtylyov sergei.shtyl...@cogentembedded.com
---
The patch is against the Dave Miller's 'net-next.git' repo.
Changes in version 2:
- fixed typo in the subject.
On 10/07/15 09:43, Stas Sergeev wrote:
Currently for fixed-link the MAC driver decides whether to use the
link status auto-negotiation or not.
Unfortunately the auto-negotiation may not work when expected by
the MAC driver. Sebastien Rannou explains:
Yes, I confirm that my HW does not
On 7/9/15 10:56 PM, Eric W. Biederman wrote:
I have given specific areas of concern, and explained myself and you are
blowing me off.
You have not had answered my question with any additional details or
code references -- ie., a specific example. Asking you for clarification
and details is
On 07/10/2015 05:19 PM, Thomas Graf wrote:
If output device wants to see the dst, inherit the dst of the
original skb and pass it on to generate the ARP request.
Signed-off-by: Thomas Graf tg...@suug.ch
---
net/ipv4/arp.c | 71 +++---
1
On Fri, 2015-07-10 at 13:36 +0200, Paul Bolle wrote:
On do, 2015-07-09 at 16:21 -0400, Roy Pledge wrote:
+#ifdef CONFIG_FSL_DPA_CHECKING
+#define DPA_ASSERT(x) \
+ do { \
+ if (!(x)) { \
+ pr_crit(ASSERT: (%s:%d) %s\n, __FILE__, __LINE__, \
+
Hello,
On Fri, 10 Jul 2015, Thomas Graf wrote:
--- a/net/ipv4/route.c
+++ b/net/ipv4/route.c
@@ -1691,6 +1691,8 @@ static int ip_route_input_slow(struct sk_buff *skb,
__be32 daddr, __be32 saddr,
by fib_lookup.
*/
+ skb_dst_drop(skb);
+
This is
The problem has been fixed. It is introduced by a third party patch,
which decreases the refcnt of timewait socket.
What is the fix?
pl share the gerrit.
--
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to majord...@vger.kernel.org
More
The current _mv88e6xxx_stats_wait function does not sleep while testing
the stats busy bit. Fix this by using the generic _mv88e6xxx_wait
function.
Note that it requires to move _mv88e6xxx_wait on top of
_mv88e6xxx_stats_wait to avoid undefined reference compilation error.
Signed-off-by: Vivien
On 7/10/15, 9:54 AM, Thomas Graf wrote:
On 07/10/15 at 05:36pm, Eric Dumazet wrote:
On Fri, 2015-07-10 at 16:19 +0200, Thomas Graf wrote:
From: Roopa Prabhu ro...@cumulusnetworks.com
+ if (oif)
+ dev = __dev_get_by_index(net, oif);
+ ret = lwtunnel_build_state(dev,
At switch setup, _mv88e6xxx_stats_wait was called without holding the
SMI mutex. Fix this by requesting the lock for this call.
Also, return the _mv88e6xxx_stats_wait code, since it may fail.
Signed-off-by: Vivien Didelot vivien.dide...@savoirfairelinux.com
---
drivers/net/dsa/mv88e6xxx.c | 7
On Fri, Jul 10, 2015 at 12:57:29PM -0400, Vivien Didelot wrote:
At switch setup, _mv88e6xxx_stats_wait was called without holding the
SMI mutex. Fix this by requesting the lock for this call.
Also, return the _mv88e6xxx_stats_wait code, since it may fail.
Signed-off-by: Vivien Didelot
On 07/10/2015 12:17 PM, Marcelo Ricardo Leitner wrote:
On Fri, Jul 10, 2015 at 11:35:28AM -0400, Vlad Yasevich wrote:
On 07/10/2015 07:53 AM, Marcelo Ricardo Leitner wrote:
On Thu, Jul 09, 2015 at 09:55:19PM +0200, Michael Tuexen wrote:
On 09 Jul 2015, at 18:54, Marcelo Ricardo Leitner
Hello.
Currently the link status auto-negotiation is enabled
for any SGMII link with fixed-link DT binding.
The regression was reported:
https://lkml.org/lkml/2015/7/8/865
Apparently not all HW that implements SGMII protocol, generates the
inband status for the auto-negotiation to work.
More
Currently fixed_phy driver recognizes only the link-up state.
This simple patch adds an implementation of link-down state.
The actual change is 1-line, the rest is an indentation.
Signed-off-by: Stas Sergeev s...@users.sourceforge.net
CC: Florian Fainelli f.faine...@gmail.com
CC:
Hi Roy,
On vr, 2015-07-10 at 15:19 +, Roy Pledge wrote:
Thanks you for your valuable feedback so far.
You're welcome. Please note that I just scan for, well, common build
issues. Ie, stuff that requires no domain specific knowledge.
Let me try to address a general issue you mention below:
On 07/10/15 at 05:36pm, Eric Dumazet wrote:
On Fri, 2015-07-10 at 16:19 +0200, Thomas Graf wrote:
From: Roopa Prabhu ro...@cumulusnetworks.com
+ if (oif)
+ dev = __dev_get_by_index(net, oif);
+ ret = lwtunnel_build_state(dev, encap_type,
+
On Fri, Jul 10, 2015 at 11:35:28AM -0400, Vlad Yasevich wrote:
On 07/10/2015 07:53 AM, Marcelo Ricardo Leitner wrote:
On Thu, Jul 09, 2015 at 09:55:19PM +0200, Michael Tuexen wrote:
On 09 Jul 2015, at 18:54, Marcelo Ricardo Leitner mleit...@redhat.com
wrote:
Cc'ing Michael too.
I'm
Currently for fixed-link the MAC driver decides whether to use the
link status auto-negotiation or not.
Unfortunately the auto-negotiation may not work when expected by
the MAC driver. Sebastien Rannou explains:
Yes, I confirm that my HW does not generate an in-band status. AFAIK, it's
a PHY
The commit 898b2970e2c9 (mvneta: implement SGMII-based in-band link state
signaling) implemented the link parameters auto-negotiation unconditionally.
Unfortunately it appears that some HW that implements SGMII protocol,
doesn't generate the inband status, so it is not possible to auto-negotiate
On Fri, Jul 10, 2015 at 12:57:28PM -0400, Vivien Didelot wrote:
The current _mv88e6xxx_stats_wait function does not sleep while testing
the stats busy bit. Fix this by using the generic _mv88e6xxx_wait
function.
Note that it requires to move _mv88e6xxx_wait on top of
_mv88e6xxx_stats_wait
On 07/10/15 at 09:57pm, Julian Anastasov wrote:
Hello,
On Fri, 10 Jul 2015, Thomas Graf wrote:
--- a/net/ipv4/route.c
+++ b/net/ipv4/route.c
@@ -1691,6 +1691,8 @@ static int ip_route_input_slow(struct sk_buff *skb,
__be32 daddr, __be32 saddr,
by fib_lookup.
On 07/10/2015 02:24 PM, Frederic Weisbecker wrote:
On Fri, Jul 10, 2015 at 01:33:44PM -0400, Chris Metcalf wrote:
In nohz_full mode, by default distribute networking shim
interrupts across the housekeeping cores, not all the cores.
I can't really tell, I have no idea what this driver does. It
1 - 100 of 129 matches
Mail list logo
